()
> hw/xen: Use xs_node_read() from xenstore_read_str() instead of
> open-coding it
Acked-by: Roger Pau Monné
> I'm slightly dubious about the last one; xen_pvdev.c didn't previously
> use anything from xen-bus-helper.c and even hardcodes zero for
> XBT_NULL. And
On Thu, Jan 09, 2025 at 11:25:13AM +, David Woodhouse wrote:
> On Thu, 2025-01-09 at 11:59 +0100, Anthony PERARD wrote:
> >
> > > char label[32];
> > > XenDevice *xendev = NULL;
> > > XenConsole *con;
> > > @@ -550,7 +551,10 @@ static void
> > > xen_console_device_create(Xen
> >
> > Fixes: a783f8ad4ec9 ('xen: add a mechanism to automatically create
> > XenDevice-s...')
> > Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
> > Signed-off-by: Roger Pau Monné
> > ---
> > hw/char/xen_console.c | 1
0x43944c929000, errp=0x15cd0165ae10)
> > at ../qemu-xen-dir-remote/hw/char/xen_console.c:555
> >
> > Replace usages of error_prepend() with error_setg() where appropriate.
> >
> > Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
>
On Mon, Dec 11, 2023 at 12:52:40AM +0800, Jiqian Chen wrote:
> In PVH dom0, it uses the linux local interrupt mechanism,
> when it allocs irq for a gsi, it is dynamic, and follow
> the principle of applying first, distributing first. And
> the irq number is alloced from small to large, but the
> ap
On Tue, Jul 04, 2023 at 10:37:38AM +0100, Anthony PERARD wrote:
> On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote:
> > On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
> > > flight 181558 xen-unstable real [real]
> > > http://l
Dropped xen-devel, adding back.
On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote:
> On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
> > flight 181558 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/181558/
>
On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
> flight 181558 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/181558/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> test-amd64-
On Tue, Apr 20, 2021 at 10:45:03AM +0100, Igor Druzhinin wrote:
> On 20/04/2021 09:53, Roger Pau Monné wrote:
> > On Tue, Apr 20, 2021 at 04:35:02AM +0100, Igor Druzhinin wrote:
> > > When we're replacing the existing mapping there is possibility of a race
> > >
On Tue, Apr 20, 2021 at 04:35:02AM +0100, Igor Druzhinin wrote:
> When we're replacing the existing mapping there is possibility of a race
> on memory map with other threads doing mmap operations - the address being
> unmapped/re-mapped could be occupied by another thread in between.
>
> Linux mma
On Sun, Jun 14, 2020 at 11:21:09PM +, Grzegorz Uriasz wrote:
> With the upstreaming of linux based stubdomains to xen, qemu can't
> assume it runs inside dom0 - permission assignment must be moved to
> libxl running in dom0. This xen patch:
> https://lists.xenproject.org/archives/html/xen-devel
assthrough support.
>
> Now, when one will want to enable igd-passthru via the -machine
> property, they will get an error message if QEMU is built without
> passthrough support.
>
> Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an accelerator
>
; code without checking if it's available.
> >
> > Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an
> > accelerator property')
> > Signed-off-by: Roger Pau Monné
> > ---
> > Cc: Stefano Stabellini
> > Cc: Anthony P
On Tue, May 19, 2020 at 01:20:51PM +0100, Peter Maydell wrote:
> On Tue, 19 May 2020 at 12:28, Roger Pau Monné wrote:
> >
> > On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote:
> > > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote:
> > &g
On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote:
> On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote:
> > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
> > index 179775db7b..660dd8a008 100644
> > --- a/hw/xen/xen_pt.h
> > +++ b/hw/xen/xen_pt.h
> > @@ -1,6 +1,7 @@
> >
('xen: convert "-machine igd-passthru" to an accelerator
> property')
> Signed-off-by: Roger Pau Monné
> ---
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: xen-de...@lists.xenproject.org
> ---
> hw/xen/xen-common.c | 4 +
t; > code without checking if it's available.
> >
> > Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an
> > accelerator property')
> > Signed-off-by: Roger Pau Monné
>
> See Kconfig fix suggested here:
> https://www.mai
On Fri, Mar 27, 2020 at 11:28:04AM +, Alex Bennée wrote:
>
> Roger Pau Monné writes:
>
> > On Thu, Mar 26, 2020 at 09:56:38AM -0700, Richard Henderson wrote:
> >> On 3/26/20 6:43 AM, Roger Pau Monne wrote:
> >> > lld 10.0.0 introduced a new link
he build of QEMU on systems using lld 10 or greater.
> >
> > Signed-off-by: Dimitry Andric
> > Signed-off-by: Roger Pau Monné
> > ---
> > Cc: Laurent Vivier
> > Cc: Richard Henderson
> > Cc: "Philippe Mathieu-Daudé"
> > Cc: Paolo Bon
On Tue, Jan 14, 2020 at 09:41:46AM -0500, Jason Andryuk wrote:
> On Tue, Jan 14, 2020 at 5:04 AM Roger Pau Monné wrote:
> >
> > On Mon, Jan 13, 2020 at 02:01:47PM -0500, Jason Andryuk wrote:
> > > On Fri, Mar 22, 2019 at 3:43 PM Jason Andryuk wrote:
> > > >
&
On Mon, Jan 13, 2020 at 02:01:47PM -0500, Jason Andryuk wrote:
> On Fri, Mar 22, 2019 at 3:43 PM Jason Andryuk wrote:
> >
> > On Thu, Mar 21, 2019 at 11:09 PM Roger Pau Monné
> > wrote:
> > >
> > > On Wed, Mar 20, 2019 at 01:28:47PM -0400, Jason Andryuk wr
On Fri, Sep 06, 2019 at 05:01:09PM +0800, Chao Gao wrote:
> On Thu, Aug 29, 2019 at 12:21:11PM +0200, Roger Pau Monné wrote:
> >On Thu, Aug 29, 2019 at 05:02:27PM +0800, Chao Gao wrote:
> >> Currently, for a HVM on Xen, no reset method is virtualized. So in a VM's
>
On Thu, Aug 29, 2019 at 05:02:27PM +0800, Chao Gao wrote:
> Currently, for a HVM on Xen, no reset method is virtualized. So in a VM's
> perspective, assigned devices cannot be reset. But some devices rely on PCI
> reset to recover from hardware hangs. When being assigned to a VM, those
> devices ca
On Wed, Mar 20, 2019 at 01:28:47PM -0400, Jason Andryuk wrote:
> On Fri, Mar 15, 2019 at 12:28 PM Andrew Cooper
> wrote:
> >
> > On 15/03/2019 09:17, Paul Durrant wrote:
> > >> -Original Message-
> > >> From: Jason Andryuk [mailto:jandr...@gmail.com]
> > >> Sent: 14 March 2019 18:16
> > >>
On Tue, Mar 19, 2019 at 02:16:44PM +, Anthony PERARD wrote:
> On Mon, Mar 18, 2019 at 10:43:12PM +0100, Marek Marczykowski-Górecki wrote:
> > On Mon, Mar 18, 2019 at 06:37:31PM +0100, Roger Pau Monne wrote:
> > > Or if it's not possible to honor the hinted address an error is returned
> > > ins
g later on when the caller of xen_remap_bucket realizes the
> > mapping has not been created at the requested address.
> >
> > Also note that at least on FreeBSD using MAP_FIXED will cause mmap to
> > try harder to honor the passed address.
> >
> > Signed-off-b
ket realizes the
> > mapping has not been created at the requested address.
> >
> > Also note that at least on FreeBSD using MAP_FIXED will cause mmap to
> > try harder to honor the passed address.
> >
> > Signed-off-by: Roger Pau Monné
> > ---
> >
Hello,
Commit 331b51 "xen: don't use xenstore to save/restore physmap
anymore" breaks live migration on FreeBSD dom0. I've checked reverting
just this specific commit and live migration works again.
The symptoms are the following, xl migrate will fail with:
migration target: Ready to receive dom
On Tue, Mar 12, 2019 at 09:58:56AM -0400, Jason Andryuk wrote:
> On Tue, Mar 12, 2019 at 8:38 AM Marek Marczykowski-Górecki
> wrote:
> >
> > On Tue, Mar 12, 2019 at 01:04:19PM +0100, Roger Pau Monné wrote:
> > > On Mon, Mar 11, 2019 at 02:02:15PM -0400, Jason Andryuk
On Mon, Mar 11, 2019 at 02:02:15PM -0400, Jason Andryuk wrote:
> MSI-X is not supported in Xen stubdoms, so it must be disabled. Use the
> existing xen_pt_hide_dev_cap to hide when running under -xen-stubdom.
I'm afraid this requires some more context. What's the actual issue
that prevents MSI-X
ugh
> continue.
>
> Cc: Roger Pau Monné
> Cc: Jan Beulich
> Signed-off-by: Zhao Yan
Reviewed-by: Roger Pau Monné
One nit below.
>
> ---
> v2: fix some coding style issue
> v3:
>1. let subject be more descriptive (roger)
>2. disable INTx a
ngelog between versions should be below the '---'.
>
> Cc: Roger Pau Monné
> Cc: Jan Beulich
> Signed-off-by: Zhao Yan
> ---
> hw/xen/xen_pt.c | 5 +
> hw/xen/xen_pt_config_init.c | 8 +++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
Adding Jan in case he has an opinion on my reply below.
On Fri, Nov 23, 2018 at 12:04:51AM -0500, Zhao Yan wrote:
> On Thu, Nov 22, 2018 at 03:18:05PM +0100, Roger Pau Monné wrote:
> > On Thu, Nov 22, 2018 at 08:11:20AM -0500, Zhao Yan wrote:
> > > On Thu, Oct 18, 2018 at 03:56
On Thu, Nov 22, 2018 at 08:11:20AM -0500, Zhao Yan wrote:
> On Thu, Oct 18, 2018 at 03:56:36PM +0100, Roger Pau Monné wrote:
> > On Thu, Oct 18, 2018 at 08:22:41AM +, Zhao, Yan Y wrote:
> > > Hi
> > > The background for this patch is that: for
On Thu, Oct 18, 2018 at 08:22:41AM +, Zhao, Yan Y wrote:
> Hi
> The background for this patch is that: for some pci device, even it's
> PCI_INTERRUPT_PIN is not 0, it actually does not support INTx mode, so we
> should just report error, disable INTx mode and continue the passthrough.
> Howev
On Fri, Aug 24, 2018 at 07:49:01PM +0300, Marcel Apfelbaum wrote:
> Hi Roger,
>
>
> On 08/24/2018 06:58 PM, Roger Pau Monné wrote:
> > Hello,
> >
> > The usage of mremap in the pvrdma code breaks the build on FreeBSD:
> >
> > /root/src/xen/tools/q
Hello,
The usage of mremap in the pvrdma code breaks the build on FreeBSD:
/root/src/xen/tools/qemu-xen-dir/hw/rdma/vmw/pvrdma_cmd.c:60:17: warning:
implicit declaration of
function 'mremap' is invalid in C99 [-Wimplicit-function-declaration]
host_virt = mremap(curr_page, 0, length, MR
ACE_SIZE when Xen gains the ability to
> emulate MCFG table accesses.
Thanks for doing this. I'm not a QEMU maintainer but:
Reviewed-by: Roger Pau Monné
> Signed-off-by: Paul Durrant
> --
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: "Michael S. Tsirkin"
On Mon, Apr 30, 2018 at 01:01:37PM +0100, Paul Durrant wrote:
> The grant copy operation was added to libxengnttab in Xen 4.8.0. If grant
> copy is available then data from the guest will be copied rather than
> mapped.
> The xen_disk source can be significantly simplified by removing this now
> re
On Mon, Apr 30, 2018 at 04:16:52PM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Roger Pau Monne
> > Sent: 30 April 2018 16:12
> > To: Paul Durrant
> > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; qemu-
> > de...@nongnu.org; Anthony Perard ; Kevin
> > Wolf ; Ste
On Wed, Jan 24, 2018 at 03:18:48PM +0100, Marek Marczykowski-Górecki wrote:
> Allow updating those two adjacent 32bit fields with one 64bit write.
> This fixes qemu crash when booting Xen inside.
>
> See discussion on Xen side of the thing here:
> http://xen.markmail.org/message/6mrmemrnmhxvaxba
X
On Wed, Oct 18, 2017 at 10:46:57AM +0200, Paolo Bonzini wrote:
> On 18/10/2017 10:32, Roger Pau Monné wrote:
> >> I'll have a try to check how much the differences would affect. If it
> >> would not take too much work, I'd like to adapt Xen NVDIMM enabling
> >
On Tue, Oct 17, 2017 at 08:16:47PM +0800, Haozhong Zhang wrote:
> On 10/17/17 13:45 +0200, Paolo Bonzini wrote:
> > On 14/10/2017 00:46, Stefano Stabellini wrote:
> > > On Fri, 13 Oct 2017, Jan Beulich wrote:
> > > On 13.10.17 at 13:13, wrote:
> > >>> To Jan, Andrew, Stefano and Anthony,
> > >
On Mon, Oct 02, 2017 at 04:30:58PM +, Anthony PERARD wrote:
> When doing a live migration of a Xen guest with libxl, the images for
> block devices are locked by the original QEMU process, and this prevent
> the QEMU at the destination to take the lock and the migration fail.
>
> From QEMU poi
should have been part of the public interface
> >> from the very start. Use them if they're available, falling back to
> >> privately defined values only when using older headers.
> >>
> >> Signed-off-by: Jan Beulich
> >
> > Reviewed-by: Roger
ly defined values only when using older headers.
>
> Signed-off-by: Jan Beulich
Reviewed-by: Roger Pau Monné
>
> --- a/hw/xen/xen_pt_msi.c
> +++ b/hw/xen/xen_pt_msi.c
> @@ -18,6 +18,11 @@
>
> #define XEN_PT_AUTO_ASSIGN -1
>
> +#ifndef XEN_DOMCTL_VMSI_X86_D
On Tue, Jun 20, 2017 at 03:19:33PM -0700, Stefano Stabellini wrote:
> On Tue, 20 Jun 2017, Paul Durrant wrote:
> > If grant copy is available then it will always be used in preference to
> > persistent maps. In this case feature-persistent should not be advertized
> > to the frontend, otherwise it
On Mon, Mar 20, 2017 at 12:38:41PM +0100, Paolo Bonzini wrote:
>
>
> On 20/03/2017 03:40, Lan Tianyu wrote:
> >>> Xen only supports emulated I440 and so we enable vIOMMU with emulated
> >>> I440 chipset. This works on Linux and Windows guest.
> >> Any plans to change this? Why is Xen not able to
On Fri, Jan 27, 2017 at 12:13:58PM +0100, Juergen Gross wrote:
> On 24/01/17 17:42, Roger Pau Monné wrote:
> > Hello,
> >
> > The following commit:
> >
> > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894
> > Author: Juergen Gross
> > Date: Tue No
On Wed, Jan 25, 2017 at 11:05:29AM +, Roger Pau Monné wrote:
> On Tue, Jan 24, 2017 at 01:30:02PM -0800, Stefano Stabellini wrote:
> > On Tue, 24 Jan 2017, Stefano Stabellini wrote:
> > > On Tue, 24 Jan 2017, Roger Pau Monné wrote:
> > > > Hello,
> &g
On Tue, Jan 24, 2017 at 01:30:02PM -0800, Stefano Stabellini wrote:
> On Tue, 24 Jan 2017, Stefano Stabellini wrote:
> > On Tue, 24 Jan 2017, Roger Pau Monné wrote:
> > > Hello,
> > >
> > > The following commit:
> > >
> > > commit 3a6c9172
Hello,
The following commit:
commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894
Author: Juergen Gross
Date: Tue Nov 22 07:10:58 2016 +0100
xen: create qdev for each backend device
Prevents me from running QEMU on FreeBSD/Xen, the following is printed on the
QEMU log:
char device redirected to
value 'feature_grant_copy' is added to recognize when the
> grant copy operation is supported by a guest.
>
> Signed-off-by: Paulina Szubarczyk
Acked-by: Roger Pau Monné
Just a couple of minor comments below, but the implementation looks fine to
me.
> ---
> Changes
On Tue, Aug 02, 2016 at 04:06:30PM +0200, Paulina Szubarczyk wrote:
> Copy data operated on during request from/to local buffers to/from
> the grant references.
>
> Before grant copy operation local buffers must be allocated what is
> done by calling ioreq_init_copy_buffers. For the 'read' operati
Ccing the maintainers.
El 23/10/15 a les 17.53, Ed Maste ha escrit:
> Acked-by: Roger Pau Monné
> Signed-off-by: Ed Maste
> ---
> As an aside this was reviewed on FreeBSD's Phabricator here:
> https://reviews.freebsd.org/D3969
>
> Resend with Signed-off-by
El 23/10/15 a les 16.39, Ed Maste ha escrit:
> ---
> As an aside this was reviewed on FreeBSD's Phabricator here:
> https://reviews.freebsd.org/D3969
This is missing the SoB, but provided that's added:
Acked-by: Roger Pau Monné
Thanks.
El 13/11/14 a les 16.36, Stefano Stabellini ha escrit:
> On Thu, 13 Nov 2014, Roger Pau Monne wrote:
>> @@ -421,7 +451,17 @@ static int ioreq_map(struct ioreq *ioreq)
>> }
>> }
>> }
>> -if (ioreq->blkdev->feature_persistent) {
>> +if (ioreq->blkdev->feature_persis
El 12/11/14 a les 18.41, Stefano Stabellini ha escrit:
> On Wed, 12 Nov 2014, Roger Pau Monne wrote:
>> This patch fixes two issues with persistent grants and the disk PV backend
>> (Qdisk):
>>
>> - Don't use batch mappings when using persistent grants, doing so prevents
>>unmapping single gra
El 20/10/14 a les 19.22, Kevin Wolf ha escrit:
> Am 20.10.2014 um 18:39 hat Roger Pau Monne geschrieben:
>> Acknowledge this and forcefully set BDRV_O_NOCACHE and O_DIRECT in order to
>> force QEMU to use aligned buffers.
>>
>> Signed-off-by: Roger Pau Monné
>&
On 22/07/14 14:26, Stefano Stabellini wrote:
> On Tue, 22 Jul 2014, Roger Pau Monné wrote:
>> On 27/05/14 15:29, Stefan Hajnoczi wrote:
>>> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote:
>>>> The current behaviour of tap_open for BSD systems diffe
loning by opening /dev/tap, implement a FreeBSD specific
>> version of tap_open that behaves like it's Linux counterpart.
>>
>> This is specially important for toolstacks that use Qemu (like Xen
>> libxl), in order to have a unified behaviour across suported
>> p
Do I need to resend this? it's been more than a month without review.
Roger.
On 13/06/14 17:35, Roger Pau Monné wrote:
> Ping?
>
> On 23/05/14 17:57, Roger Pau Monne wrote:
>> On FreeBSD polling a master pty while the other end is not connected
>> with G_IO_OUT only
source with G_IO_HUP (which
> makes the code behave the same way on both Linux and FreeBSD).
>
> Signed-off-by: Roger Pau Monné
> Cc: Peter Crosthwaite
> Cc: Michael Tokarev
> Cc: "Andreas Färber"
> Cc: Paolo Bonzini
> Cc: xen-de...@lists.xenproject.org
&g
urns -1, so
>> compare the error code with the value in errno instead of the value
>> returned by the function.
>>
>> Signed-off-by: Roger Pau Monné
>> Cc: xen-de...@lists.xenproject.org
>> Cc: Stefano Stabellini
>> Cc: Anthony Perard
>> ---
&
ever gets called:
>>
>> $ ./test_poll
>>
>> So, in order to workaround this, poll the source with G_IO_HUP (which
>> makes the code behave the same way on both Linux and FreeBSD).
>>
>> Signed-off-by: Roger Pau Monné
>> Cc: Peter Crosthwaite
>>
-1, so
>> compare the error code with the value in errno instead of the value
>> returned by the function.
>>
>> Signed-off-by: Roger Pau Monné
>> Cc: xen-de...@lists.xenproject.org
>> Cc: Stefano Stabellini
>> Cc: Anthony Perard
>> ---
On 15/04/14 18:15, Anthony PERARD wrote:
> On Tue, Apr 15, 2014 at 10:33:08AM +0200, Roger Pau Monne wrote:
>> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the
>> hypervisor are translated to ENOENT.
>>
>> Also, the error code is returned in errno if the call returns -1, so
>> co
l because Qemu is not able to access those paths
>> when running on a domain different than Dom0.
>>
>> Instead make the xenstore paths relative to the domain where Qemu is
>> actually running.
>>
>> Signed-off-by: Roger Pau Monné
>> Cc: xen-de...@lists.
and switches between userspace
>> and kernel space. The full description of the protocol can be found in
>> the public blkif.h header.
>>
>> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=xen/include/public/io/blkif.h
>>
>> Speed improvement with 15 guests perf
and switches between userspace
>> and kernel space. The full description of the protocol can be found in
>> the public blkif.h header.
>
> it would be great if you could add a link to a webpage too
Sure, thanks for the review.
>
>> Speed improvement with 15 guests perform
On 04/01/13 15:54, Stefano Stabellini wrote:
> On Thu, 3 Jan 2013, Ian Campbell wrote:
>> On Mon, 2012-12-31 at 12:16 +, Roger Pau Monne wrote:
>>> Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT,
>>> if first call to bdrv_open fails with errno = EINVAL, try a second
>>> call
2012/2/27 Ian Campbell :
> On Thu, 2012-02-23 at 13:34 +0000, Roger Pau Monné wrote:
>> 2012/2/22 Anthony Liguori :
>> > On 02/20/2012 06:11 AM, Roger Pau Monne wrote:
>> >>
>> >> Replace clock_gettime with timer_gettime, since at least under
>> >
2012/2/22 Anthony Liguori :
> On 02/20/2012 06:11 AM, Roger Pau Monne wrote:
>>
>> Replace clock_gettime with timer_gettime, since at least under
>> uclibc 0.9.33 the clock_getttime function can be used without linking
>> against librt (although the manual page states the opposite).
>>
>> Signed-of
2012/2/18 Andreas Färber :
> Am 18.02.2012 09:24, schrieb Blue Swirl:
>> On Wed, Feb 8, 2012 at 17:06, Roger Pau Monne
>> wrote:
>>> libm is used in cutils.c, but the library was not specified
>>> when linking some binaries, throwing the following error:
>>>
>>> cutils.o: In function `strtosz_suf
74 matches
Mail list logo
