On Tue, May 19, 2020 at 01:20:51PM +0100, Peter Maydell wrote: > On Tue, 19 May 2020 at 12:28, Roger Pau Monné <roger....@citrix.com> wrote: > > > > On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote: > > > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote: > > > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > > > > index 179775db7b..660dd8a008 100644 > > > > --- a/hw/xen/xen_pt.h > > > > +++ b/hw/xen/xen_pt.h > > > > @@ -1,6 +1,7 @@ > > > > #ifndef XEN_PT_H > > > > #define XEN_PT_H > > > > > > > > +#include "qemu/osdep.h" > > > > > > Why do you need osdep? > > > > For CONFIG_XEN_PCI_PASSTHROUGH IIRC. > > All .c files should always include osdep as the first include > in the file, and .h files should never include osdep (we note > this in CODING_STYLE.rst). > > If you added this #include to fix a compile issue that would > suggest that there's a .c file somewhere that's missing the > mandatory osdep include. I did a quick eyeball of all the files > that include xen_pt.h, though, and none of them are missing the > osdep include. So I think you should be able to simply drop the > osdep include here. If that produces an error, let us know what > fails and we can work out what's gone wrong.
My bad, didn't know about this rule and just looked up where CONFIG_XEN_PCI_PASSTHROUGH was defined in order to include it. Will remove in v2. Thanks, Roger.
