On Fri, Jan 10, 2025 at 10:02:53AM +, David Woodhouse wrote:
> On Fri, 2025-01-10 at 10:35 +0100, Roger Pau Monne wrote:
> > Hello,
> >
> > First patch from David introduces a new helper to fetch xenstore nodes,
> > while second patch removes the usage of scanf
Hello,
First patch from David introduces a new helper to fetch xenstore nodes,
while second patch removes the usage of scanf related functions with the
"%ms" format specifier, as it's not supported by the FreeBSD scanf libc
implementation.
Thanks, Roger.
David Woodhouse (1)
string.
Signed-off-by: David Woodhouse
[remove double newline and constify trace parameters]
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: Anthony PERARD
Cc: Paul Durrant
Cc: "Edgar E. Iglesias"
Cc: xen-de...@lists.xenproject.org
---
hw/xen/trace-events | 1
same string. Instead use
xs_node_read() to read the whole xenstore node.
Fixes: a783f8ad4ec9 ('xen: add a mechanism to automatically create
XenDevice-s...')
Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
Signed-off-by: Roger Pau Monné
---
Changes since
hem create the path with snprintf and then pass it in.
> Or with g_strdup_printf(), pass it in, then free it afterwards.
>
> So perhaps qemu_xen_xs_read() should be a printf-style function too,
> with its last arg(s) being the node name.
I just went with Anthony suggestion and introduced xs_node_read(), as
I didn't want to play with qemu_xen_xs_read(). Not that I think the
suggestion is not valid, just seemed more work than what I wanted to
do right now.
Thanks, Roger.
add a mechanism to automatically create
XenDevice-s...')
Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
Signed-off-by: Roger Pau Monné
---
Changes since v1:
- Introduce xs_node_read() helper.
- Merge with errp fixes.
---
Cc: Stefano Stabellini
Cc: Anthony PERARD
On Thu, Jan 09, 2025 at 11:59:48AM +0100, Anthony PERARD wrote:
> On Tue, Jan 07, 2025 at 10:31:40AM +0100, Roger Pau Monne wrote:
> > The 'm' parameter used to request auto-allocation of the destination
> > variable
> > is not supported on FreeBSD, and as
On Thu, Jan 09, 2025 at 11:13:45AM +0100, Anthony PERARD wrote:
> On Tue, Jan 07, 2025 at 10:31:39AM +0100, Roger Pau Monne wrote:
> > The usage of error_prepend() in some of the error contexts of
> > xen_console_device_create() is incorrect, as `errp` hasn't been initialize
0x15cd0165ae10)
at ../qemu-xen-dir-remote/hw/char/xen_console.c:555
Replace usages of error_prepend() with error_setg() where appropriate.
Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: Anthony PERAR
same string. Instead use
qemu_xen_xs_read() to read the whole xenstore node.
Fixes: a783f8ad4ec9 ('xen: add a mechanism to automatically create
XenDevice-s...')
Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
Signed-off-by: Roger Pau Monné
---
Cc: Ste
Hello,
First patch fixes some error handling paths that incorrectly used
error_prepend() in the Xen console driver. Second patch removes usage
of the 'm' character in scanf directives, as it's not supported on
FreeBSD (see usages of "%ms").
Thanks, Roger.
Roger Pau
t domain,
> }
> d->device_id = v;
>
> -xen_host_pci_get_dec_value(d, "irq", &v, errp);
> +xen_host_pci_get_dec_value(d, "gsi", &v, errp);
Don't you need to fallthrough to use the irq number on failure?
Otherwise passthrough won't work on older Linux versions that don't
expose the gsi node.
Thanks, Roger.
On Tue, Jul 04, 2023 at 10:37:38AM +0100, Anthony PERARD wrote:
> On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote:
> > On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
> > > flight 181558 xen-unstable real [real]
> > > http://l
Dropped xen-devel, adding back.
On Wed, Jun 28, 2023 at 02:31:39PM +0200, Roger Pau Monné wrote:
> On Fri, Jun 23, 2023 at 03:04:21PM +, osstest service owner wrote:
> > flight 181558 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/181558/
>
n order to run pygrub.
This is also with QEMU 7.2, as testing with upstream QEMU is blocked
ATM, so there's a chance it has already been fixed upstream.
Thanks, Roger.
On Tue, Apr 20, 2021 at 10:45:03AM +0100, Igor Druzhinin wrote:
> On 20/04/2021 09:53, Roger Pau Monné wrote:
> > On Tue, Apr 20, 2021 at 04:35:02AM +0100, Igor Druzhinin wrote:
> > > When we're replacing the existing mapping there is possibility of a race
> > >
ap(entry->vaddr_base, entry->size) != 0) {
Oh, so remappings of foreign addresses must always use the same
virtual address space, I somehow assumed that you could remap an
existing foreign map (or dummy mapping) into a different virtual
address if you so wanted.
Thanks, Roger.
with:
https://lore.kernel.org/lkml/20210118151528.81668-1-roger@citrix.com/T/#u
Fix QEMU to report a "discard-alignment" of 0, in order for it to work
with older Linux frontends.
Reported-by: Arthur Borsboom
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: Anthony
ated without first explicitly granting the permission.
In order to avoid breaking certain libxl - QEMU combinations, could
you make the check below non-fatal?
So that the current code can be kept for dom0 while not throwing an
error when used inside of a stub domain?
Thanks, Roger.
On Wed, Jun 03, 2020 at 05:04:42PM +0100, Anthony PERARD wrote:
> From: Roger Pau Monne
>
> Xen PCI passthrough support may not be available and thus the global
> variable "has_igd_gfx_passthru" might be compiled out. Common code
> should not access it in that case.
>
On Tue, May 19, 2020 at 04:52:58PM +0100, Anthony PERARD wrote:
> On Tue, May 19, 2020 at 04:31:01PM +0200, Roger Pau Monne wrote:
> > has_igd_gfx_passthru is only available when QEMU is built with
> > CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common
> >
has_igd_gfx_passthru is only available when QEMU is built with
CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common
code without checking if it's available.
Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an accelerator
property')
On Tue, May 19, 2020 at 01:20:51PM +0100, Peter Maydell wrote:
> On Tue, 19 May 2020 at 12:28, Roger Pau Monné wrote:
> >
> > On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote:
> > > On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote:
> > &g
On Mon, May 11, 2020 at 02:40:43PM +0100, Anthony PERARD wrote:
> On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote:
> > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
> > index 179775db7b..660dd8a008 100644
> > --- a/hw/xen/xen_pt.h
> > +++ b/hw/xe
Ping?
On Mon, May 04, 2020 at 12:14:43PM +0200, Roger Pau Monne wrote:
> has_igd_gfx_passthru is only available when QEMU is built with
> CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common
> code without checking if it's available.
>
> Fixes: 46472d82322d0
On Mon, May 04, 2020 at 12:35:39PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Roger,
>
> On 5/4/20 12:14 PM, Roger Pau Monne wrote:
> > has_igd_gfx_passthru is only available when QEMU is built with
> > CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common
&g
has_igd_gfx_passthru is only available when QEMU is built with
CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common
code without checking if it's available.
Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an accelerator
property')
On Fri, Mar 27, 2020 at 11:28:04AM +, Alex Bennée wrote:
>
> Roger Pau Monné writes:
>
> > On Thu, Mar 26, 2020 at 09:56:38AM -0700, Richard Henderson wrote:
> >> On 3/26/20 6:43 AM, Roger Pau Monne wrote:
> >> > lld 10.0.0 introduced a new link
On Thu, Mar 26, 2020 at 09:56:38AM -0700, Richard Henderson wrote:
> On 3/26/20 6:43 AM, Roger Pau Monne wrote:
> > lld 10.0.0 introduced a new linker option --image-base equivalent to
> > the GNU -Ttext-segment one, hence use it when available.
> >
> > This fixes t
lld 10.0.0 introduced a new linker option --image-base equivalent to
the GNU -Ttext-segment one, hence use it when available.
This fixes the build of QEMU on systems using lld 10 or greater.
Signed-off-by: Dimitry Andric
Signed-off-by: Roger Pau Monné
---
Cc: Laurent Vivier
Cc: Richard
On Tue, Jan 14, 2020 at 09:41:46AM -0500, Jason Andryuk wrote:
> On Tue, Jan 14, 2020 at 5:04 AM Roger Pau Monné wrote:
> >
> > On Mon, Jan 13, 2020 at 02:01:47PM -0500, Jason Andryuk wrote:
> > > On Fri, Mar 22, 2019 at 3:43 PM Jason Andryuk wrote:
> > > >
&
On Mon, Jan 13, 2020 at 02:01:47PM -0500, Jason Andryuk wrote:
> On Fri, Mar 22, 2019 at 3:43 PM Jason Andryuk wrote:
> >
> > On Thu, Mar 21, 2019 at 11:09 PM Roger Pau Monné
> > wrote:
> > >
> > > On Wed, Mar 20, 2019 at 01:28:47PM -0400, Jason Andryuk wr
On Fri, Sep 06, 2019 at 05:01:09PM +0800, Chao Gao wrote:
> On Thu, Aug 29, 2019 at 12:21:11PM +0200, Roger Pau Monné wrote:
> >On Thu, Aug 29, 2019 at 05:02:27PM +0800, Chao Gao wrote:
> >> Currently, for a HVM on Xen, no reset method is virtualized. So in a VM's
>
you likely need to deassign the device from the VM, perform
the reset, and then assign the device again, so that there's no Xen
internal state carried over prior to the reset?
Thanks, Roger.
.0 Host
> Controller (rev 04) (prog-if 30 [XHCI])
> Memory at f2024000 (64-bit, non-prefetchable) [size=8K]
> 00:08.0 USB controller: Intel Corporation 6 Series/C200 Series Chipset
> Family USB Enhanced Host Controller #2 (rev 05) (prog-if 20 [EHCI])
> Memory at f2028000 (32-b
On Tue, Mar 19, 2019 at 02:16:44PM +, Anthony PERARD wrote:
> On Mon, Mar 18, 2019 at 10:43:12PM +0100, Marek Marczykowski-Górecki wrote:
> > On Mon, Mar 18, 2019 at 06:37:31PM +0100, Roger Pau Monne wrote:
> > > Or if it's not possible to honor the hinted addre
eeBSD using MAP_FIXED will cause mmap to
try harder to honor the passed address.
Signed-off-by: Roger Pau Monné
Reviewed-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: Igor Druzhinin
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: "
On Mon, Mar 18, 2019 at 03:48:59PM +, Igor Druzhinin wrote:
> On 18/03/2019 15:45, Roger Pau Monne wrote:
> > Or if it's not possible to honor the hinted address an error is returned
> > instead. This makes it easier to spot the actual failure, instead of
> > failin
eeBSD using MAP_FIXED will cause mmap to
try harder to honor the passed address.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: Igor Druzhinin
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: "Michael S. Tsirkin&qu
On Fri, Mar 15, 2019 at 10:54:42AM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Roger Pau Monne [mailto:roger@citrix.com]
> > Sent: 15 March 2019 08:59
> > To: qemu-devel@nongnu.org
> > Cc: Roger Pau Monne ; Stefano Stabellini
> >
eeBSD using MAP_FIXED will cause mmap to
try harder to honor the passed address.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: Igor Druzhinin
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: "Michael S. Tsirkin&qu
0001f80 with f000
Assertion failed: (p && p == memory_region_get_ram_ptr(mr)), function
xen_add_to_physmap, file
/usr/ports/sysutils/xen-tools/work/xen-4.11.1/tools/qemu-xen/hw/i386/xen/xen-hvm.c,
line 392.
This is with Xen 4.11.1.
Thanks, Roger.
On Tue, Mar 12, 2019 at 09:58:56AM -0400, Jason Andryuk wrote:
> On Tue, Mar 12, 2019 at 8:38 AM Marek Marczykowski-Górecki
> wrote:
> >
> > On Tue, Mar 12, 2019 at 01:04:19PM +0100, Roger Pau Monné wrote:
> > > On Mon, Mar 11, 2019 at 02:02:15PM -0400, Jason Andryuk
t prevents MSI-X from working?
Roger.
ugh
> continue.
>
> Cc: Roger Pau Monné
> Cc: Jan Beulich
> Signed-off-by: Zhao Yan
Reviewed-by: Roger Pau Monné
One nit below.
>
> ---
> v2: fix some coding style issue
> v3:
> 1. let subject be more descriptive (roger)
>2. disable INTx a
ngelog between versions should be below the '---'.
>
> Cc: Roger Pau Monné
> Cc: Jan Beulich
> Signed-off-by: Zhao Yan
> ---
> hw/xen/xen_pt.c | 5 +
> hw/xen/xen_pt_config_init.c | 8 +++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
Adding Jan in case he has an opinion on my reply below.
On Fri, Nov 23, 2018 at 12:04:51AM -0500, Zhao Yan wrote:
> On Thu, Nov 22, 2018 at 03:18:05PM +0100, Roger Pau Monné wrote:
> > On Thu, Nov 22, 2018 at 08:11:20AM -0500, Zhao Yan wrote:
> > > On Thu, Oct 18, 2018 at 03:56
On Thu, Nov 22, 2018 at 08:11:20AM -0500, Zhao Yan wrote:
> On Thu, Oct 18, 2018 at 03:56:36PM +0100, Roger Pau Monné wrote:
> > On Thu, Oct 18, 2018 at 08:22:41AM +, Zhao, Yan Y wrote:
> > > Hi
> > > The background for this patch is that: for
at even when
the device is supposed to have a valid IRQ the sysfs node it is set to
0, do you know the actual underlying cause of this?
Thanks, Roger.
On Fri, Aug 24, 2018 at 07:49:01PM +0300, Marcel Apfelbaum wrote:
> Hi Roger,
>
>
> On 08/24/2018 06:58 PM, Roger Pau Monné wrote:
> > Hello,
> >
> > The usage of mremap in the pvrdma code breaks the build on FreeBSD:
> >
> > /root/src/xen/tools/q
in the configure
script, or the calls to mremap are replaced with a portable
equivalent.
Thanks, Roger.
ACE_SIZE when Xen gains the ability to
> emulate MCFG table accesses.
Thanks for doing this. I'm not a QEMU maintainer but:
Reviewed-by: Roger Pau Monné
> Signed-off-by: Paul Durrant
> --
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: "Michael S. Tsirkin"
ing this now
> redundant code.
Hm, I know this is a PITA, but FreeBSD gntdev hasn't implemented the
grant-copy operation yet.
I could try to implement it, but I can't make any promises on the time
ATM, since I'm quite busy.
Thanks, Roger.
On Mon, Apr 30, 2018 at 04:16:52PM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Roger Pau Monne
> > Sent: 30 April 2018 16:12
> > To: Paul Durrant
> > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; qemu-
> > de...@nongnu.
mrmemrnmhxvaxba
Xen code is wrong, see:
https://marc.info/?l=xen-devel&m=150511273303712
Roger.
Thanks.
I will look into this.
On 11/15/2017 10:56 AM, misairu wrote:
> Does your Subsystem ID and Subsystem Vendor ID (of your GPU) show
> correctly inside the WindowsVM?
>
> It should be the same ID shown in your host. Otherwise that will trigger
> the Code 43 error.
>
> I once have this proble
On Wed, Oct 18, 2017 at 10:46:57AM +0200, Paolo Bonzini wrote:
> On 18/10/2017 10:32, Roger Pau Monné wrote:
> >> I'll have a try to check how much the differences would affect. If it
> >> would not take too much work, I'd like to adapt Xen NVDIMM enabling
> >
l, the only entity that has all the
information about the guest it's the toolstack, and so it should be
the one in control of the ACPI tables.
Also, Xen guests can use several device models concurrently (via the
ioreq server interface), and each should be able to contribute to the
information presented in the ACPI tables. Intel is also working on
adding IOMMU emulation to the Xen hypervisor, in which case the vIOMMU
ACPI tables should be created by the toolstack and not QEMU. And
finally keep in mind that there are Xen guests (PVH) that use ACPI
tables but not QEMU.
Thanks, Roger.
can takes
> them.
What happens if the migration fails on the destination? Will QEMU pick
the lock again when resuming on the source in this case?
Thanks, Roger.
should have been part of the public interface
> >> from the very start. Use them if they're available, falling back to
> >> privately defined values only when using older headers.
> >>
> >> Signed-off-by: Jan Beulich
> >
> > Reviewed-by: Roger
ly defined values only when using older headers.
>
> Signed-off-by: Jan Beulich
Reviewed-by: Roger Pau Monné
>
> --- a/hw/xen/xen_pt_msi.c
> +++ b/hw/xen/xen_pt_msi.c
> @@ -18,6 +18,11 @@
>
> #define XEN_PT_AUTO_ASSIGN -1
>
> +#ifndef XEN_DOMCTL_VMSI_X86_D
bound.
This also requires to track the mask register for MSI interrupts, so
QEMU can also notify to Xen whether the MSI interrupt should be bound
masked or unmasked
Signed-off-by: Roger Pau Monné
Reviewed-by: Jan Beulich
Reported-by: Andreas Kinzler
---
Cc: Stefano Stabellini
Cc: Anthony Perard
bound.
This also requires to track the mask register for MSI interrupts, so
QEMU can also notify to Xen whether the MSI interrupt should be bound
masked or unmasked
Signed-off-by: Roger Pau Monné
Reviewed-by: Jan Beulich
Reported-by: Andreas Kinzler
---
Cc: Stefano Stabellini
Cc: Anthony Perard
sk register for MSI interrupts, so
> > QEMU can also notify to Xen whether the MSI interrupt should be bound
> > masked or unmasked
> >
> > Signed-off-by: Roger Pau Monné
> > Reported-by: Andreas Kinzler
>
> Reviewed-by: Jan Beulich
Thanks, Roger.
bound.
This also requires to track the mask register for MSI interrupts, so
QEMU can also notify to Xen whether the MSI interrupt should be bound
masked or unmasked
Signed-off-by: Roger Pau Monné
Reported-by: Andreas Kinzler
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Jan Beulich
Cc: qemu
iginal behavior is keep if the unmask
> > bit is not set. In this case this should be 'true' in order to keep
> > the previous behavior, which was correct for MSI.
>
> Wouldn't you want to pass the state of the mask bit here,
> rather than uniformly hard coding true or false?
Yes, I think so. I've overlooked the MSI code because I thought we
allowed QEMU to directly write to the mask register, but that's not
true, it's trapped by Xen.
Thanks, Roger.
the parameter to "unmask", so that false -> no change to mask, true
-> unconditionally unmask.
Thanks, Roger.
bound.
Signed-off-by: Roger Pau Monné
Reported-by: Andreas Kinzler
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Jan Beulich
Cc: qemu-devel@nongnu.org
---
hw/xen/xen_pt_msi.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/xen/xen_pt_msi.c b/hw/xen
On Wed, Jun 21, 2017 at 11:40:00AM +0100, Paul Durrant wrote:
> > -Original Message-
> > From: Qemu-devel [mailto:qemu-devel-
> > bounces+paul.durrant=citrix@nongnu.org] On Behalf Of Paul Durrant
> > Sent: 21 June 2017 10:36
> > To: Roger Pau Monne ;
rontend, otherwise it may needlessly copy data into persistently
> > granted buffers.
> >
> > Signed-off-by: Paul Durrant
>
> CC'ing Roger.
>
> It is true that using feature-persistent together with grant copies is a
> a very bad idea.
>
> But this c
Public bug reported:
Hello,
I have a nice working qemu with gpu passthrough setup.
I pass through my nvidia gtx 880m.
It boots in 4mins 18secs.
If I remove the "-vga none" switch and allow qemu to create a vga
adapter I can boot in 1min.
Why does a normal boot with the nvidia card hang for 3mins
I meant to say you cannot run without the intel card in windows if you
have optimus. I am glad seabios somehow hides optimus.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1680679
Title:
qemu canno
It works using seabios. I assume that the nvidia driver cannot see
optimus, and expect an intel card also, unless I use OVMF. I do know
that you cannot run off the intel card in windows. It's a no-no. Thanks
for the bios tip. Maybe I can hide the optimus feature from OVMF and
windows.
--
You rece
ok, so I will research qemu and nvidia optimus. I have a custom BIOS
made by an MSI employee. I have hundreds of bios options to play with.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1680679
Title
My uefi build script. If you see an error or issue that could cause
error 43 please confirm it:
#!/bin/bash
cd /home/dad/qemu/qemu2
sudo ./up.sh tap0
configfile=./vfio-pci1.cfg
vfiobind() {
dev="$1"
vendor=$(cat /sys/bus/pci/devices/$dev/vendor)
device=$(cat /sys/bus/pci/dev
GTX880M - uefi firmware built in, confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1680679
Title:
qemu cannot run twice
Status in QEMU:
Invalid
Bug description:
After using qemu with g
NOTE: I only get gpu passthrough to work when using seabios. UEFI will
not work with modern nvidia drivers. You get the 'code 43' error because
whatever standards nvidia expects when talking to uefi are not met by
the OVMF firmware used by qemu. This issue happens to windows users
also. They had to
NOTE: Article showing windows users updating their motherboard uefi firmware to
get around code 43:
https://devtalk.nvidia.com/default/topic/861244/cuda-setup-and-installation/geforce-740m-asus-x550l-code-43-after-windows-10-update/3
--
You received this bug notification because you are a member
I have been told that getting this to work with a laptop is rare.
I own an MSI GT70-2PE.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1680679
Title:
qemu cannot run twice
Status in QEMU:
New
B
Public bug reported:
After using qemu with gpu passthrough and then shutting down windows 7 properly
I cannot boot windows 7 a second time.
Only a full reboot of linux fixes this issue.
Qemu appears to corrupt something in linux when exiting.
I get no error messages but windows 7 never finishes b
ing the attack surface
> of the hypervisor. For KVM, for example, IOMMU emulation requires using
> the "split irqchip" feature to move the PIC and IOAPIC out of the kernel
> and back to QEMU.
Yes, that's right, we are increasing the surface of attack. But Xen also needs
it in order to support APIC IDs > 255 on PVH guests (that have a local APIC but
no QEMU).
Roger.
On Fri, Jan 27, 2017 at 12:13:58PM +0100, Juergen Gross wrote:
> On 24/01/17 17:42, Roger Pau Monné wrote:
> > Hello,
> >
> > The following commit:
> >
> > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894
> > Author: Juergen Gross
> > Date: Tue No
On Wed, Jan 25, 2017 at 11:05:29AM +, Roger Pau Monné wrote:
> On Tue, Jan 24, 2017 at 01:30:02PM -0800, Stefano Stabellini wrote:
> > On Tue, 24 Jan 2017, Stefano Stabellini wrote:
> > > On Tue, 24 Jan 2017, Roger Pau Monné wrote:
> > > > Hello,
> &g
On Tue, Jan 24, 2017 at 01:30:02PM -0800, Stefano Stabellini wrote:
> On Tue, 24 Jan 2017, Stefano Stabellini wrote:
> > On Tue, 24 Jan 2017, Roger Pau Monné wrote:
> > > Hello,
> > >
> > > The following commit:
> > >
> > > commit 3a6c9172
n for example we don't yet
support the gnttab device, so initialization of the Xen Qdisk backend can fail
(and possibly the same applies to Linux if someone decides to compile a kernel
without the gnttab device). Yet QEMU can be used without the Qdisk backend.
Roger.
value 'feature_grant_copy' is added to recognize when the
> grant copy operation is supported by a guest.
>
> Signed-off-by: Paulina Szubarczyk
Acked-by: Roger Pau Monné
Just a couple of minor comments below, but the implementation looks fine to
me.
> ---
> Changes
ttab_grant_copy(gnt, count, segs);
> +
> +if (rc) {
> +xen_be_printf(&ioreq->blkdev->xendev, 0,
> + "failed to copy data %d\n", rc);
> +ioreq->aio_errors++;
> +return -1;
> +} else {
> +r = 0;
> +}
Do you really need both r and rc here? I think you could just have rc and
use it below also.
> +for (i = 0; i < count; i++) {
> +if (segs[i].status != GNTST_okay) {
> +xen_be_printf(&ioreq->blkdev->xendev, 3,
> + "failed to copy data %d for gref %d, domid %d\n",
> rc,
> + ioreq->refs[i], ioreq->domids[i]);
> +ioreq->aio_errors++;
> +r = -1;
> +}
> +}
> +
> +return r;
> +}
> +
> static int ioreq_runio_qemu_aio(struct ioreq *ioreq);
>
> static void qemu_aio_complete(void *opaque, int ret)
Roger.
xc_domain_create depending on the libxc version detected.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: qemu-devel@nongnu.org
---
Changes since v2:
- Drop the last parameter to xen_create_domain since it's always NULL ATM
and was causing build problems with older Xen ver
xc_domain_create depending on the libxc version detected.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: qemu-devel@nongnu.org
---
Changes since v1:
- Add a compat layer to support previous libxc versions.
- Add machinery to detect current Xen unstable (4.7).
---
configure
Due to the addition of HVMlite and the requirement to always provide a valid
xc_domain_configuration_t, xc_domain_create now always takes an arch domain
config, which can be NULL in order to mimic previous behaviour.
Signed-off-by: Roger Pau Monné
---
Cc: Stefano Stabellini
Cc: qemu-devel
Ccing the maintainers.
El 23/10/15 a les 17.53, Ed Maste ha escrit:
> Acked-by: Roger Pau Monné
> Signed-off-by: Ed Maste
> ---
> As an aside this was reviewed on FreeBSD's Phabricator here:
> https://reviews.freebsd.org/D3969
>
> Resend with Signed-off-by
El 23/10/15 a les 16.39, Ed Maste ha escrit:
> ---
> As an aside this was reviewed on FreeBSD's Phabricator here:
> https://reviews.freebsd.org/D3969
This is missing the SoB, but provided that's added:
Acked-by: Roger Pau Monné
Thanks.
been added
to make sure persistent grants are only used if the whole mapped region
can be persistently mapped in the batch_maps case.
- Unmap persistent grants before switching to the closed state, so the
frontend can also free them.
Signed-off-by: Roger Pau Monné
Reported-by: George
El 13/11/14 a les 16.36, Stefano Stabellini ha escrit:
> On Thu, 13 Nov 2014, Roger Pau Monne wrote:
>> @@ -421,7 +451,17 @@ static int ioreq_map(struct ioreq *ioreq)
>> }
>> }
>> }
>> -if (ioreq->blkdev->feature_
grants before switching to the closed state, so the
frontend can also free them.
Signed-off-by: Roger Pau Monné
Reported-by: George Dunlap
Cc: Stefano Stabellini
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Cc: George Dunlap
Cc: Konrad Rzeszutek Wilk
---
Xen release exception: this is obviously an
El 12/11/14 a les 18.41, Stefano Stabellini ha escrit:
> On Wed, 12 Nov 2014, Roger Pau Monne wrote:
>> This patch fixes two issues with persistent grants and the disk PV backend
>> (Qdisk):
>>
>> - Don't use batch mappings when using persistent grants, doing so
state, so the
frontend can also free them.
Signed-off-by: Roger Pau Monné
Reported-and-Tested-by: George Dunlap
Cc: Stefano Stabellini
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Cc: George Dunlap
---
hw/block/xen_disk.c | 35 ---
1 file changed, 24 insertions(+
Introduce a new flag to mark devices that require requests to be aligned and
replace the usage of BDRV_O_NOCACHE and O_DIRECT with this flag when
appropriate.
If a character device is used as a backend on a FreeBSD host set this flag
unconditionally.
Signed-off-by: Roger Pau Monné
Reviewed-by
Introduce a new flag to mark devices that require requests to be aligned and
replace the usage of BDRV_O_NOCACHE and O_DIRECT with this flag when
appropriate.
If a character device is used as a backend on a FreeBSD host set this flag
unconditionally.
Signed-off-by: Roger Pau Monné
Cc: Kevin
El 20/10/14 a les 19.22, Kevin Wolf ha escrit:
> Am 20.10.2014 um 18:39 hat Roger Pau Monne geschrieben:
>> Acknowledge this and forcefully set BDRV_O_NOCACHE and O_DIRECT in order to
>> force QEMU to use aligned buffers.
>>
>> Signed-off-by: Roger Pau Monné
>&
1 - 100 of 152 matches
Mail list logo
