hes. However, I see that you keep
> the flush in qcow2_cache_flush_dependency(), so in the code this is
> actually fine.
>
> Can you make that more explicit in the commit message?
>
> > This seriously affects the
> > performance of database operations inside the guest.
> >
hes. However, I see that you keep
> the flush in qcow2_cache_flush_dependency(), so in the code this is
> actually fine.
>
> Can you make that more explicit in the commit message?
>
> > This seriously affects the
> > performance of database operations inside the guest.
> >
On Fri, Apr 22, 2016 at 05:40:49PM -0600, Eric Blake wrote:
> Upstream NBD protocol recently added the ability to efficiently
> write zeroes without having to send the zeroes over the wire,
> along with a flag to control whether the client wants a hole.
>
> Signed-off-by: Eric Blake
>
> ---
> v3
Hi Eric,
On Thu, Apr 07, 2016 at 10:10:58AM -0600, Eric Blake wrote:
> On 04/07/2016 04:38 AM, Vladimir Sementsov-Ogievskiy wrote:
> > On 05.04.2016 16:43, Paolo Bonzini wrote:
> >>
> >> On 05/04/2016 06:05, Kevin Wolf wrote:
> >>> The options I can think of is adding a request field "max number o
On Sat, Apr 09, 2016 at 11:57:57AM +0100, Alex Bligh wrote:
>
> On 8 Apr 2016, at 23:05, Eric Blake wrote:
>
> > RFC because there is still discussion on the NBD list about
> > adding an NBD_OPT_ to let the client suggest server defaults
> > related to scanning for zeroes during NBD_CMD_WRITE, w
On Fri, Apr 08, 2016 at 04:05:57PM -0600, Eric Blake wrote:
> RFC because there is still discussion on the NBD list about
> adding an NBD_OPT_ to let the client suggest server defaults
> related to scanning for zeroes during NBD_CMD_WRITE, which may
> tweak this patch.
>
> Upstream NBD protocol re
On Tue, Apr 05, 2016 at 03:43:08PM +0200, Paolo Bonzini wrote:
>
>
> On 05/04/2016 06:05, Kevin Wolf wrote:
> > The options I can think of is adding a request field "max number of
> > descriptors" or a flag "only single descriptor" (with the assumption
> > that clients always want one or unlimite
On Thu, Mar 24, 2016 at 09:04:07AM -0600, Eric Blake wrote:
> On 03/24/2016 06:30 AM, Pavel Borzenkov wrote:
> >> Conversely, it would be possible to send less data over the wire, as
> >> long as we require that all LBA status descriptors cover consecutive
> >> offset
On Wed, Mar 23, 2016 at 10:27:00AM -0600, Eric Blake wrote:
> On 03/23/2016 08:16 AM, Denis V. Lunev wrote:
> > From: Pavel Borzenkov
> >
> > With the availability of sparse storage formats, it is often needed to
> > query status of a particular LBA range and read on
On Thu, Mar 24, 2016 at 09:41:29AM +0100, Wouter Verhelst wrote:
> On Thu, Mar 24, 2016 at 11:25:52AM +0300, Pavel Borzenkov wrote:
> > On Wed, Mar 23, 2016 at 07:14:54PM +0100, Kevin Wolf wrote:
> > > Am 23.03.2016 um 18:58 hat Wouter Verhelst geschrieben:
> > > >
On Thu, Mar 24, 2016 at 09:26:41AM +0100, Wouter Verhelst wrote:
> On Thu, Mar 24, 2016 at 10:57:06AM +0300, Pavel Borzenkov wrote:
> > On Wed, Mar 23, 2016 at 06:21:16PM +0100, Wouter Verhelst wrote:
> > > So, the semantics of your proposed WRITE_ZEROES are exactly the same
On Wed, Mar 23, 2016 at 06:58:34PM +0100, Wouter Verhelst wrote:
> On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote:
> > From: Pavel Borzenkov
> >
> > With the availability of sparse storage formats, it is often needed to
> > query status of a particu
On Wed, Mar 23, 2016 at 07:14:54PM +0100, Kevin Wolf wrote:
> Am 23.03.2016 um 18:58 hat Wouter Verhelst geschrieben:
> > On Wed, Mar 23, 2016 at 05:16:02PM +0300, Denis V. Lunev wrote:
> > > +The type of information required by the client is passed to server
> > > in the
> > > +command fl
On Wed, Mar 23, 2016 at 06:21:16PM +0100, Wouter Verhelst wrote:
> Hi,
>
> On Wed, Mar 23, 2016 at 05:16:01PM +0300, Denis V. Lunev wrote:
> > From: Pavel Borzenkov
> >
> > There exist some cases when a client knows that the data it is going to
> > write
On Wed, Mar 23, 2016 at 09:14:10AM -0600, Eric Blake wrote:
> On 03/23/2016 08:16 AM, Denis V. Lunev wrote:
> > From: Pavel Borzenkov
> >
> > There exist some cases when a client knows that the data it is going to
> > write is all zeroes. Such cases include mirro
'sed -i' is not defined in POSIX. It doesn't work on Mac OS X the way
it's used in configure (without suffix argument). This patch implements
Peter Maydell's idea of xattr.h detection.
Cc: Peter Maydell
Signed-off-by: Pavel Borzenkov
---
configure |6 +-
1 fi
On Nov 10, 2011, at 10:18 PM, Peter Maydell wrote:
> On 10 November 2011 18:03, Pavel Borzenkov wrote:
>> diff --git a/configure b/configure
>> index 401d9a6..b83640e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1968,7 +1968,7 @@ EOF
>> if co
When SDL support is disabled, there is no way to build QEMU without
Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
allows to build QEMU without both SDL and Cocoa frontends.
Signed-off-by: Pavel Borzenkov
---
configure |7 ++-
1 files changed, 6 insert
It was commented out since the initial import from svn.
Signed-off-by: Pavel Borzenkov
---
block/raw-posix.c | 18 --
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index a3de373..17e1c6f 100644
--- a/block/raw-posix.c
Use __APPLE__ and __MACH__ macros instead of CONFIG_COCOA to detect Mac
OS X host. The patch is based on the Ben Leslie's patch:
http://patchwork.ozlabs.org/patch/97859/
Signed-off-by: Pavel Borzenkov
---
block/raw-posix.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
After applying this small patch series, you'll be able to build QEMU on Mac OS
X without both SDL and Cocoa frontends. First two patches deal with raw-posix,
which is the only CONFIG_COCOA user not related to GUI. The third patch adds
'--disable-cocoa' switch to configure.
Pav
BSD sed always requires a suffix to be passed when '-i' switch is used.
In GNU sed this suffix is optional. Due to this, configure prints the
following error when runs on Mac OS X:
sed: 1: "/var/folders/r_/1g8ws8s ...": invalid command code f
Signed-off-by: Pavel Borzenkov
-
On Thu, Nov 10, 2011 at 2:41 PM, Andreas Färber wrote:
> Am 09.11.2011 19:54, schrieb Pavel Borzenkov:
>> When SDL support is disabled, there is no way to build QEMU without
>> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
>> allows to
On Thu, Nov 10, 2011 at 2:44 PM, Peter Maydell wrote:
> On 10 November 2011 10:41, Andreas Färber wrote:
>> I remember there was a similar patch once but some issue with it kept us
>> from applying it - something unrelated to the frontend was influenced by
>> it I think... block layer?
>
> Yeah,
When SDL support is disabled, there is no way to build QEMU without
Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
allows to build QEMU without both SDL and Cocoa frontends.
Signed-off-by: Pavel Borzenkov
---
configure | 11 ++-
1 files changed, 6
On Tue, Nov 1, 2011 at 12:33 PM, Jun Koi wrote:
> On Tue, Nov 1, 2011 at 3:06 PM, Pavel Borzenkov
> wrote:
>> On Tue, Nov 1, 2011 at 7:35 AM, Jun Koi wrote:
>>> This patch explicitly initializes tcg_cpu_thread to NULL in cpus.c
>>> (One code patch in qemu_tcg_init
On Tue, Nov 1, 2011 at 7:35 AM, Jun Koi wrote:
> This patch explicitly initializes tcg_cpu_thread to NULL in cpus.c
> (One code patch in qemu_tcg_init_vcpu() relies on the value of
> tcg_cpu_thread to create env->thread and so on )
>
> Signed-off-by: Jun Koi
You don't need to explicitly initiali
Before the next patches, fix coding style of the affected functions.
Signed-off-by: Pavel Borzenkov
---
cmd.c | 168 -
1 files changed, 82 insertions(+), 86 deletions(-)
diff --git a/cmd.c b/cmd.c
index f77897e..a6e3ef4 100644
Signed-off-by: Pavel Borzenkov
---
cmd.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/cmd.c b/cmd.c
index 75415d8..0806e18 100644
--- a/cmd.c
+++ b/cmd.c
@@ -329,16 +329,21 @@ char **breakline(char *input, int *count)
int c = 0;
char *p;
char
Signed-off-by: Pavel Borzenkov
---
cmd.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/cmd.c b/cmd.c
index a6e3ef4..75415d8 100644
--- a/cmd.c
+++ b/cmd.c
@@ -47,7 +47,7 @@ compare(const void *a, const void *b)
void add_command(const cmdinfo_t *ci
The first patch fixes coding style of the functions affected by next two
patches.
Second patch fixes potential NULL pointer dereference (return value of realloc
is not checked).
Third patch fixes potential memory leak (for the case when realloc returns
NULL).
Pavel Borzenkov (3):
cmd: Fix
On Mon, Oct 31, 2011 at 10:27 AM, Markus Armbruster wrote:
> Pavel Borzenkov writes:
>
>> Signed-off-by: Pavel Borzenkov
>> ---
>> Note, that almost all code in the file violates CODING STYLE. The changed
>> lines
>> are written wrt CODING STYLE
Signed-off-by: Pavel Borzenkov
---
Note, that almost all code in the file violates CODING STYLE. The changed lines
are written wrt CODING STYLE (like commits 7d7d975c and c32d766a).
---
cmd.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/cmd.c b/cmd.c
index
Signed-off-by: Pavel Borzenkov
---
Note, that almost all code in the file violates CODING STYLE. The changed lines
are written wrt CODING STYLE (like commits 7d7d975c and c32d766a).
---
cmd.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/cmd.c b/cmd.c
index
Ping?
On Mon, Oct 24, 2011 at 3:31 PM, Pavel Borzenkov
wrote:
> Signed-off-by: Pavel Borzenkov
> ---
> hw/fw_cfg.c | 102
> ++-
> 1 files changed, 38 insertions(+), 64 deletions(-)
>
> diff --git a/hw/fw_cfg.c
On Wed, Oct 26, 2011 at 4:31 PM, Kevin Wolf wrote:
> In error cases, cid is never set.
>
> Signed-off-by: Kevin Wolf
This fix is already in the qemu-trivial queue:
http://repo.or.cz/w/qemu/stefanha.git/commit/8379e46d1fd681b8aa4714382e2cdab05e5d0575
--
Pavel
> ---
> block/vmdk.c | 2 +-
>
Signed-off-by: Pavel Borzenkov
---
hw/fw_cfg.c | 102 ++-
1 files changed, 38 insertions(+), 64 deletions(-)
diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
index 8df265c..dbcb888 100644
--- a/hw/fw_cfg.c
+++ b/hw/fw_cfg.c
@@ -60,71 +60,55
Signed-off-by: Pavel Borzenkov
---
hw/fw_cfg.c | 100 ++-
1 files changed, 37 insertions(+), 63 deletions(-)
diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
index 8df265c..d2400f5 100644
--- a/hw/fw_cfg.c
+++ b/hw/fw_cfg.c
@@ -60,71 +60,55
On Fri, Oct 21, 2011 at 12:31 PM, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 10/20/2011 07:23 PM, Stefan Hajnoczi wrote:
>>> On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote:
>>>> Spotted by Clang Analyzer
>>
On 10/21/2011 12:31 PM, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
>> On 10/20/2011 07:23 PM, Stefan Hajnoczi wrote:
>>> On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote:
>>>> Spotted by Clang Analyzer
>>>>
>>>> Si
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov
---
block/vmdk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 3969131..a75dcc2 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -207,7 +207,7 @@ static void
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov
---
block/vmdk.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 5d16ec4..3969131 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1387,7 +1387,6 @@ static int vmdk_create(const
'ret' is unconditionally overwitten by qed_read_l1_table_sync()
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov
---
block/qed.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index e87dc4d..c3e45af 100644
--- a/block/q
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov
---
block/qed.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index c3e45af..e6720db 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -1424,8 +1424,10 @@ static int
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov
---
hw/fw_cfg.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
index 8df265c..1125e7d 100644
--- a/hw/fw_cfg.c
+++ b/hw/fw_cfg.c
@@ -113,6 +113,13 @@ static FILE *probe_splashfile
checkpatch.pl doesn't report warning for if/else statements with missing
'else' braces:
if (something) {
foo;
} else
bar;
The patch has been tested using the last 100 commits.
Signed-off-by: Pavel Borzenkov
---
scripts/checkpatch.pl |2 +-
1 files changed, 1 i
Hi.
checkpatch.pl correctly reports a warning for the following code:
if (something)
foo;
else
bar;
WARNING: braces {} are necessary for all arms of this statement
#1: FILE: tmp/a.c:1:
+if (something)
[...]
+else
[...]
But if I modify it as follows, checkpatch.pl doesn't report any
w
47 matches
Mail list logo
