Re: [Qemu-devel] [PATCH v3] ps2: Fix lost scancodes by recent changes

2017-01-05 Thread OGAWA Hirofumi
e. BTW, url of your example didn't show even initial patch (if I didn't overlook). Looks like it is broken. Thanks. -- OGAWA Hirofumi

Re: [Qemu-devel] [PATCH v3] ps2: Fix lost scancodes by recent changes

2017-01-04 Thread OGAWA Hirofumi
Hervé Poussineau writes: > Le 04/01/2017 à 09:50, Gerd Hoffmann a écrit : >> On Mi, 2016-12-28 at 04:55 +0900, OGAWA Hirofumi wrote: >>> With "ps2: use QEMU qcodes instead of scancodes", key handling was >>> changed to qcode base. But all scancodes are not co

[Qemu-devel] [PATCH v2] ui/gtk: Fix mouse wheel on 3.4.0 or later

2017-01-04 Thread OGAWA Hirofumi
On 3.4.0 or later, send GDK_SCROLL_SMOOTH event, instead of GDK_SCROLL_UP/DOWN. This fixes it by converting any smooth scroll to up/down. (I.e. without smooth support) Signed-off-by: OGAWA Hirofumi --- ui/gtk.c | 13 + 1 file changed, 13 insertions(+) diff -puN ui/gtk.c~mouse

Re: [Qemu-devel] [PATCH] ui/gtk: Fix mouse wheel on 3.4.0 or later

2017-01-04 Thread OGAWA Hirofumi
k.c:1024: > +if (!gdk_event_get_scroll_deltas((GdkEvent*)scroll, &delta_x, > &delta_y)) > [...] > > ERROR: braces {} are necessary for all arms of this statement > #15: FILE: ui/gtk.c:1026: > +if (delta_y > 0) > [...] > +else > [...] > > total: 3 errors, 0 warnings, 16 lines checked -- OGAWA Hirofumi

[Qemu-devel] [PATCH v3] ps2: Fix lost scancodes by recent changes

2016-12-27 Thread OGAWA Hirofumi
With "ps2: use QEMU qcodes instead of scancodes", key handling was changed to qcode base. But all scancodes are not converted to new one. This adds some missing qcodes/scancodes what I found in using. [set1 and set3 are from ] Signed-off-by: OGAWA Hirofumi --- hw/input/ps2.c

Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-27 Thread OGAWA Hirofumi
And qemu doesn't have 0x5d entry in set3. Also http://hp.vector.co.jp/authors/VA003720/lpproj/others/kbdjpn.htm yet another site says 0x5d. Some sites says about buggy keyboards using wrong scancode in set3, and microsoft seems to removed set3 from specification. So linux translation table for 43=>0x5d, maybe result of workarounds. So looks like 0x5d is right value for set3. Thanks. -- OGAWA Hirofumi

[Qemu-devel] [PATCH v2] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread OGAWA Hirofumi
Signed-off-by: OGAWA Hirofumi --- hw/input/ps2.c|3 +++ qapi-schema.json |6 +- ui/input-keymap.c |3 +++ 3 files changed, 11 insertions(+), 1 deletion(-) diff -puN hw/input/ps2.c~fix-ps2-scancode hw/input/ps2.c --- qemu/hw/input/ps2.c~fix-ps2-scancode2016-12-23 23:

Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread OGAWA Hirofumi
Eric Blake writes: > On 12/23/2016 07:00 AM, OGAWA Hirofumi wrote: >> >> With "ps2: use QEMU qcodes instead of scancodes", key handling was >> changed to qcode base. But all scancodes are not converted to new one. >> >> This adds some missing qcodes

Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread OGAWA Hirofumi
.893893: EV_MSC MSC_SCAN 81 [... on qemu monitor "sendkey yen" ...] 06:49:58.893893: EV_KEY KEY_VOLUMEDOWN (0x72) pressed 06:49:58.893893: EV_SYN code=0 value=0 06:49:58.973841: EV_MSC MSC_SCAN 81 06:49:58.973841: EV_KEY KEY_VOLUMEDOWN (0x72) released 06:49:58.973841: EV_SYN code=0 value=0 timeout, quitting -- OGAWA Hirofumi

[Qemu-devel] [PATCH] ui/gtk: Fix mouse wheel on 3.4.0 or later

2016-12-23 Thread OGAWA Hirofumi
On 3.4.0 or later, send GDK_SCROLL_SMOOTH event, instead of GDK_SCROLL_UP/DOWN. This fixes it by converting any smooth scroll to up/down. (I.e. without smooth support) Signed-off-by: OGAWA Hirofumi --- ui/gtk.c | 10 ++ 1 file changed, 10 insertions(+) diff -puN ui/gtk.c~mouse

[Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread OGAWA Hirofumi
With "ps2: use QEMU qcodes instead of scancodes", key handling was changed to qcode base. But all scancodes are not converted to new one. This adds some missing qcodes what I found in using. Signed-off-by: OGAWA Hirofumi --- hw/input/ps2.c|3 +++ qapi-schema.json |

[Qemu-devel] [PATCH v2] ui/curses: Fix color attribute of monitor for curses

2015-12-01 Thread OGAWA Hirofumi
s reduces to expose curses define to other parts (removes COLOR_* from console.c). [Tested the first line is displayed as white on blue back for monitor in curses console] Signed-off-by: OGAWA Hirofumi --- hw/display/jazz_led.c |6 +- hw/display/vga.c |3 - include/u

Re: [Qemu-devel] [PATCH] ui/curses: Fix color attribute of monitor for curses

2015-12-01 Thread OGAWA Hirofumi
WHITE] = QEMU_RGB(0xaa, 0xaa, 0xaa), /* white */ > > The color comments are kind of redundant now ... OK. -- OGAWA Hirofumi

[Qemu-devel] [PATCH] ui/curses: Fix color attribute of monitor for curses

2015-11-29 Thread OGAWA Hirofumi
s reduces to expose curses define to other parts (removes COLOR_* from console.c). [Tested the first line is displayed as white on blue back for monitor in curses console] Signed-off-by: OGAWA Hirofumi --- hw/display/jazz_led.c |6 +- hw/display/vga.c |3 - include/u

[Qemu-devel] [PATCH v2] ui/opengl: Reduce build required libraries for opengl

2015-10-26 Thread OGAWA Hirofumi
ther than epoxy - milkymist-tmu2 glx stuff doesn't require other than epoxy (lm32 test is limited, because can't find mmone-bios.bin, so just test to load libGL with "./lm32-softmmu/qemu-system-lm32 -M milkymist,accel=qtest") Signed-off-by: OGAWA Hirofumi --- configure

Re: [Qemu-devel] [PATCH] ui/egl: Reduce required libraries to build with EGL support

2015-10-26 Thread OGAWA Hirofumi
Gerd Hoffmann writes: > On Mo, 2015-10-26 at 19:39 +0900, OGAWA Hirofumi wrote: >> Gerd Hoffmann writes: >> >> > On Sa, 2015-10-24 at 20:51 +0900, OGAWA Hirofumi wrote: >> >> To support EGL (sdl2-gl, gtk-egl, egl-helpers, etc.), we don't need to >&

Re: [Qemu-devel] [PATCH] ui/egl: Reduce required libraries to build with EGL support

2015-10-26 Thread OGAWA Hirofumi
Gerd Hoffmann writes: > On Sa, 2015-10-24 at 20:51 +0900, OGAWA Hirofumi wrote: >> To support EGL (sdl2-gl, gtk-egl, egl-helpers, etc.), we don't need to >> install "gl" or "glesv" packages. (Those are used only for milkymist-tmu2). > > They are

[Qemu-devel] [PATCH] ui/egl: Reduce required libraries to build with EGL support

2015-10-24 Thread OGAWA Hirofumi
To support EGL (sdl2-gl, gtk-egl, egl-helpers, etc.), we don't need to install "gl" or "glesv" packages. (Those are used only for milkymist-tmu2). So, this move check from opengl to egl. Signed-off-by: OGAWA Hirofumi --- configure| 34 ++

[Qemu-devel] [PATCH v2 3/3] ui/curses: Fix pageup/pagedown on -curses

2015-10-19 Thread OGAWA Hirofumi
n use scroll-up/down as usual like other display modes. Signed-off-by: OGAWA Hirofumi --- ui/curses_keys.h |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -puN ui/curses_keys.h~support-curses-pageup ui/curses_keys.h --- qemu/ui/curses_keys.h~support-curses-pageup 2015-

[Qemu-devel] [PATCH v2 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-19 Thread OGAWA Hirofumi
This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h | 12 +++- ui/curses.c | 44

[Qemu-devel] [PATCH v2 1/3] ui/curses: Fix monitor color with -curses when 256 colors

2015-10-19 Thread OGAWA Hirofumi
). FIXME: on 256 color, curses may be possible better vga color emulation. Signed-off-by: OGAWA Hirofumi --- ui/curses.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff -puN ui/curses.c~support-curses-256color ui/curses.c --- qemu/ui/curses.c~support-curses-256color2015-10

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-19 Thread OGAWA Hirofumi
Gerd Hoffmann writes: > Lets go with v2 of this patch. > > There are some codestyle issues in the patch (and the others too), > please fix them them (scripts/checkpatch.pl helps), then resend the > whole series. OK. I'll send with new thread, not this thread. -- OGAWA Hirofumi

[Qemu-devel] [PATCH v4] ui/curses: Support line graphics chars on -curses mode

2015-10-15 Thread OGAWA Hirofumi
This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h |9 ++-- ui/console.c | 13 ui/curses.c | 54

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-15 Thread OGAWA Hirofumi
t; >> This is not possible, because ACS_* is not constant (initialized by >> reading from termcap or such). > > Ah, ok. That isn't obvious from reading the code. Can you add a > comment please? Oh, sent updated patch already. I will resend a updated patch to this reply. -- OGAWA Hirofumi

[Qemu-devel] [PATCH v3] ui/curses: Support line graphics chars on -curses mode

2015-10-15 Thread OGAWA Hirofumi
This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h |9 ++-- ui/console.c | 13 ui/curses.c | 53

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-15 Thread OGAWA Hirofumi
leaner (purpose is separation of curses code), I introduced hw_text_update_cb() interface (looks like possible to use text data for other than curses interface too). But you may feel this is overkill. Well, IMO, the patch makes clear purpose of this path in following reply. Thanks. -- OGAWA Hirofumi

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-15 Thread OGAWA Hirofumi
OGAWA Hirofumi writes: >> Ok, curses and gtk can't be active at the same time. But for curses and >> vnc it is possible (qemu -curses -vnc :$display), and you probably get a >> dissorted vga text mode over vnc then. >> >> I think the mapping should hap

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-15 Thread OGAWA Hirofumi
alizers: > > chtype vga_to_curses[256] = { > [0x04] = ACS_DIAMOND, > [ ... ] > }; This is not possible, because ACS_* is not constant (initialized by reading from termcap or such). Thanks. -- OGAWA Hirofumi

[Qemu-devel] [PATCH v2 1/3] ui/curses: Support line graphics chars on -curses mode

2015-10-14 Thread OGAWA Hirofumi
This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h | 11 ++- ui/curses.c | 43 +++ 2

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-14 Thread OGAWA Hirofumi
OGAWA Hirofumi writes: > Gerd Hoffmann writes: > >> On Mi, 2015-10-14 at 20:37 +0900, OGAWA Hirofumi wrote: >>> This converts vga code to curses code in console_write_bh(). >>> >>> With this changes, we can see line graphics (for example, dialog uses)

Re: [Qemu-devel] [RFC 0/3] improve/fix -curses mode

2015-10-14 Thread OGAWA Hirofumi
Markus Armbruster writes: > Copying maintainer. You can use scripts/get_maintainer.pl to find > maintainers yourself. Ah, I was missing to use it. Thanks. > OGAWA Hirofumi writes: > >> Hi, >> >> This patchset is to improve/fix -curses mode. But this patchset

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-14 Thread OGAWA Hirofumi
Gerd Hoffmann writes: > On Mi, 2015-10-14 at 20:37 +0900, OGAWA Hirofumi wrote: >> This converts vga code to curses code in console_write_bh(). >> >> With this changes, we can see line graphics (for example, dialog uses) >> correctly. > > But it breaks line g

[Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-14 Thread OGAWA Hirofumi
This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h | 11 ++- ui/curses.c | 42 ++ 2

[Qemu-devel] [PATCH 1/3] ui/curses: Fix monitor color with -curses when 256 colors

2015-10-14 Thread OGAWA Hirofumi
). FIXME: on 256 color, curses may be possible better vga color emulation. Signed-off-by: OGAWA Hirofumi --- ui/curses.c |3 +++ 1 file changed, 3 insertions(+) diff -puN ui/curses.c~support-curses-256color ui/curses.c --- qemu/ui/curses.c~support-curses-256color2015-10-14 20:12

[Qemu-devel] [RFC 0/3] improve/fix -curses mode

2015-10-14 Thread OGAWA Hirofumi
/pagedown on -curses include/ui/console.h | 11 ++- ui/curses.c | 45 + ui/curses_keys.h |8 ++-- 3 files changed, 61 insertions(+), 3 deletions(-) Thanks. -- OGAWA Hirofumi

[Qemu-devel] [PATCH 3/3] ui/curses: Fix pageup/pagedown on -curses

2015-10-14 Thread OGAWA Hirofumi
n use scroll-up/down as usual like other display modes. Signed-off-by: OGAWA Hirofumi --- ui/curses_keys.h |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -puN ui/curses_keys.h~support-curses-pageup ui/curses_keys.h --- qemu/ui/curses_keys.h~support-curses-pageup 2015-