Re: [PATCH v1 2/3] hw/s390x: add CPI values to QOM

2025-01-24 Thread Nina Schoetterl-Glausch
On Wed, 2025-01-15 at 14:31 +0100, Shalini Chellathurai Saroja wrote: > This commit adds the firmware control-program > identifiers received from a KVM guest via the > SCLP event type Control-Program Identification to QOM. > A timestamp in which the data is received is also > added to QOM. > > Exa

Re: [PATCH v1 3/3] hw/s390x: support migration of CPI values

2025-01-24 Thread Nina Schoetterl-Glausch
t; +VMSTATE_END_OF_LIST() I see, you need the Cpi type here. How about naming it ControlProgramId and renaming CPI to ControlProgramIdMsg or similar? With that sorted out: Reviewed-by: Nina Schoetterl-Glausch

Re: [PATCH v1 1/3] hw/s390x: add SCLP event type CPI

2025-01-24 Thread Nina Schoetterl-Glausch
Please swap patch 1 and 2 and incorporate the changes of write_event_data into this patch. Reviewed-by: Nina Schoetterl-Glausch See some minor nits below. On Wed, 2025-01-15 at 14:31 +0100, Shalini Chellathurai Saroja wrote: > This commit implements the SCLP event type Control-Prog

Re: [PATCH v1 10/14] s390x/pv: check initial, not maximum RAM size

2024-09-24 Thread Nina Schoetterl-Glausch
On Tue, 2024-09-10 at 19:58 +0200, David Hildenbrand wrote: > We actually want to check the available RAM, not the maximum RAM size. > > Signed-off-by: David Hildenbrand Reviewed-by: Nina Schoetterl-Glausch Nit below. > --- > target/s390x/kvm/pv.c | 2 +- > 1 file changed,

Re: [PATCH v1 03/14] s390x/s390-virtio-hcall: prepare for more diag500 hypercalls

2024-09-17 Thread Nina Schoetterl-Glausch
On Tue, 2024-09-17 at 13:02 +0200, David Hildenbrand wrote: > On 17.09.24 12:50, David Hildenbrand wrote: > > On 17.09.24 12:45, David Hildenbrand wrote: > > > On 12.09.24 15:22, Nina Schoetterl-Glausch wrote: > > > > On Tue, 2024-09-10 at 19:57 +0200, David Hild

Re: [PATCH v1 06/14] s390x: introduce s390_get_memory_limit()

2024-09-17 Thread Nina Schoetterl-Glausch
On Tue, 2024-09-17 at 13:23 +0200, David Hildenbrand wrote: > On 16.09.24 15:20, Nina Schoetterl-Glausch wrote: > > On Tue, 2024-09-10 at 19:58 +0200, David Hildenbrand wrote: > > > Let's add s390_get_memory_limit(), to query what has been successfully > > > set vi

Re: [PATCH v1 06/14] s390x: introduce s390_get_memory_limit()

2024-09-16 Thread Nina Schoetterl-Glausch
On Tue, 2024-09-10 at 19:58 +0200, David Hildenbrand wrote: > Let's add s390_get_memory_limit(), to query what has been successfully > set via s390_set_memory_limit(). Allow setting the limit only once. > > Signed-off-by: David Hildenbrand Reviewed-by: Nina Schoetterl-Glausc

Re: [PATCH v1 03/14] s390x/s390-virtio-hcall: prepare for more diag500 hypercalls

2024-09-12 Thread Nina Schoetterl-Glausch
On Tue, 2024-09-10 at 19:57 +0200, David Hildenbrand wrote: > Let's generalize, abstracting the virtio bits. diag500 is now a generic > hypercall to handle QEMU/KVM specific things. Explicitly specify all > already defined subcodes, including legacy ones (so we know what we can > use for new hyperc

Re: [PATCH v2 00/11] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup

2024-09-09 Thread Nina Schoetterl-Glausch
On Fri, 2024-09-06 at 15:38 +0100, Peter Maydell wrote: > On Fri, 30 Aug 2024 at 15:58, Peter Maydell wrote: > > > > The main aim of this patchseries is to remove the two remaining uses > > of device_class_set_parent_reset() in the tree, which are virtio-ccw > > and the s390 CPU class. Doing that

Re: [PATCH v2 01/11] hw/s390/ccw-device: Convert to three-phase reset

2024-09-03 Thread Nina Schoetterl-Glausch
On Fri, 2024-08-30 at 15:58 +0100, Peter Maydell wrote: > Convert the TYPE_CCW_DEVICE to three-phase reset. This is a > device class which is subclassed, so it needs to be three-phase > before we can convert the subclass. > > Signed-off-by: Peter Maydell Reviewed-by: Nina Sch

Re: [PATCH for-9.2 02/10] target/s390: Convert CPU to Resettable interface

2024-08-23 Thread Nina Schoetterl-Glausch
the commit > message of f5ae2a4fd8d573cfeba; please check them as I haven't > got a clue what s390 does ;-) > --- With the already mentioned fix: Reviewed-by: Nina Schoetterl-Glausch > diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c > index 0fbfcd35d83..4e41a3dff59 100644

Re: [PATCH for-9.2 01/10] hw/s390/virtio-ccw: Convert to three-phase reset

2024-08-23 Thread Nina Schoetterl-Glausch
do the this-class reset first > and then chain up to the parent's reset, but that's what the > existing code does, so I left it alone. > --- Reviewed-by: Nina Schoetterl-Glausch

Re: [PATCH for-9.2 00/10] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup

2024-08-22 Thread Nina Schoetterl-Glausch
On Wed, 2024-08-14 at 21:06 +0100, Peter Maydell wrote: > On Wed, 14 Aug 2024 at 15:22, Christian Borntraeger > wrote: > > > > Am 13.08.24 um 18:52 schrieb Peter Maydell: > > > The main aim of this patchseries is to remove the two remaining uses > > > of device_class_set_parent_reset() in the tre

Re: [PATCH 2/3] migration: Drop unnecessary check in ram's pending_exact()

2024-03-20 Thread Nina Schoetterl-Glausch
On Wed, 2024-03-20 at 14:57 -0400, Peter Xu wrote: > On Wed, Mar 20, 2024 at 06:51:26PM +0100, Nina Schoetterl-Glausch wrote: > > On Wed, 2024-01-17 at 15:58 +0800, pet...@redhat.com wrote: > > > From: Peter Xu > > > > > > When the migration frameworks fetch

Re: [PATCH 2/3] migration: Drop unnecessary check in ram's pending_exact()

2024-03-20 Thread Nina Schoetterl-Glausch
I cc'ed Juan, but it looks like he is no longer with Redhat.

Re: [PATCH 2/3] migration: Drop unnecessary check in ram's pending_exact()

2024-03-20 Thread Nina Schoetterl-Glausch
On Wed, 2024-01-17 at 15:58 +0800, pet...@redhat.com wrote: > From: Peter Xu > > When the migration frameworks fetches the exact pending sizes, it means > this check: > > remaining_size < s->threshold_size > > Must have been done already, actually at migration_iteration_run(): > > if (mu

Re: [PATCH v2] target/s390x: improve cpu compatibility check error message

2024-03-15 Thread Nina Schoetterl-Glausch
l, and add a > hint to try a different one. > > Also add a hint for features mismatch to suggest trying > different accel, QEMU and kernel versions. > > Signed-off-by: Claudio Fontana Reviewed-by: Nina Schoetterl-Glausch > --- > target/s390x/cpu_models.c | 22 +

Re: [PATCH] target/s390x: improve cpu compatibility check error message

2024-03-14 Thread Nina Schoetterl-Glausch
On Thu, 2024-03-14 at 20:00 +0100, Claudio Fontana wrote: > some users were confused by this message showing under TCG: > > Selected CPU generation is too new. Maximum supported model > in the configuration: 'xyz' > > Try to clarify that the maximum can depend on the accel by > adding also the cu

Re: [PATCH] docs/s390: clarify even more that cpu-topology is KVM-only

2024-03-14 Thread Nina Schoetterl-Glausch
at we can point to, > whenever we need to reference accelerators and how to select them. > > Signed-off-by: Claudio Fontana Reviewed-by: Nina Schoetterl-Glausch Tested-by: Nina Schoetterl-Glausch (meaning I ran make html) > --- > docs/system/introduction.rst | 2 ++ > doc

Re: question on s390x topology: KVM only, or also TCG?

2024-03-14 Thread Nina Schoetterl-Glausch
On Thu, 2024-03-14 at 16:54 +0100, Thomas Huth wrote: > On 14/03/2024 16.49, Claudio Fontana wrote: > > Hello Pierre, Ilya, > > > > I have a question on the s390x "topology" feature and examples. > > > > Mainly, is this feature supposed to be KVM accelerator-only, or also > > available when usin

Re: [RFC] docs/s390: Fix wrong command example in s390-cpu-topology.rst

2023-11-27 Thread Nina Schoetterl-Glausch
s->len, which is equal to ms->smp.max_cpus. > > Fix the wrong "core-id" 112 because it is greater than maxcpus (36) in Maybe s/is greater/isn't less/ since the valid ids are 0-35 inclusive. > -smp. > > Cc: Nina Schoetterl-Glausch > Signed-off-by: Zhao Li

[PATCH] target/s390x/cpu topology: Fix ordering and creation of TLEs

2023-10-27 Thread Nina Schoetterl-Glausch
("target/s390x/cpu topology: handle STSI(15) and build the SYSIB") Signed-off-by: Nina Schoetterl-Glausch --- Unfortunately this wasn't caught by the kvm-unit-test because that also had a bug :( target/s390x/kvm/stsi-topology.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions

Re: [PULL 06/25] s390x/cpu topology: resetting the Topology-Change-Report

2023-10-20 Thread Nina Schoetterl-Glausch
On Thu, 2023-10-19 at 21:32 +0200, Thomas Huth wrote: [...] > Thanks, that seems to fix the issue with --enable-debug, too. > I'll squash that into the related patch (also fixing the indentation in > s390_has_topology()) and respin the pull request. > > Thomas > Thanks!

Re: [PULL 06/25] s390x/cpu topology: resetting the Topology-Change-Report

2023-10-19 Thread Nina Schoetterl-Glausch
to clear the Modified Topology Change Report (MTCR) > > bit of the SCA in the case of a subsystem reset. > > > > Signed-off-by: Pierre Morel > > Reviewed-by: Thomas Huth > > Reviewed-by: Nina Schoetterl-Glausch > > Co-developed-by: Nina Schoetterl-Glausch >

Re: [PULL 03/25] s390x/cpu topology: add topology entries on CPU hotplug

2023-10-19 Thread Nina Schoetterl-Glausch
ecifying the topology can > still get some advantage of the CPU topology. > > Signed-off-by: Pierre Morel > Reviewed-by: Nina Schoetterl-Glausch > Co-developed-by: Nina Schoetterl-Glausch > Reviewed-by: Thomas Huth > Signed-off-by: Nina Schoetterl-Glausch >

Re: [PATCH v26 01/21] qapi: machine.json: change docs regarding CPU topology

2023-10-19 Thread Nina Schoetterl-Glausch
On Tue, 2023-10-17 at 13:10 +0200, Thomas Huth wrote: > On 17/10/2023 11.40, Markus Armbruster wrote: > > Nina Schoetterl-Glausch writes: > > > > > Clarify roles of different architectures. > > > Also change things a bit in anticipation of add

[PATCH v26 10/21] machine: adding s390 topology to query-cpu-fast

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas

[PATCH v26 19/21] tests/avocado: s390x cpu topology test socket full

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QMP set-cpu-topology does not accept to overload a socket. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/avocado/s390_topo

[PATCH v26 20/21] tests/avocado: s390x cpu topology dedicated errors

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Let's test that QEMU refuses to setup a dedicated CPU with low or medium entitlement. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/avocad

[PATCH v26 04/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Acked-by: Markus

[PATCH v26 08/21] target/s390x/cpu topology: activate CPU topology

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility in the host CPU model for the guest in the case the topology is available in QEMU and in KVM. The feature is disabled by default and fenced f

[PATCH v26 15/21] tests/avocado: s390x cpu topology core

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Introduction of the s390x cpu topology core functions and basic tests. We test the correlation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v26 12/21] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE QAPI event

2023-10-16 Thread Nina Schoetterl-Glausch
-Glausch Co-developed-by: Nina Schoetterl-Glausch Acked-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 35 +++ hw/s390x/cpu-topology.c | 2 ++ 2 files changed, 37 insertions(+) diff --git a/qapi/machine-target.json b

[PATCH v26 03/21] s390x/cpu topology: add topology entries on CPU hotplug

2023-10-16 Thread Nina Schoetterl-Glausch
added in the physical topology based on its core ID and it gets defaults values for the modifier attributes. This way, starting QEMU without specifying the topology can still get some advantage of the CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by

[PATCH v26 13/21] qapi/s390x/cpu topology: add query-s390x-cpu-polarization command

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel The query-s390x-cpu-polarization qmp command returns the current CPU polarization of the machine. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Acked-by: Markus Armbruster Signed-off-by

[PATCH v26 01/21] qapi: machine.json: change docs regarding CPU topology

2023-10-16 Thread Nina Schoetterl-Glausch
Clarify roles of different architectures. Also change things a bit in anticipation of additional members being added. Suggested-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine.json | 58 +++ 1 file changed, 38 insertions

[PATCH v26 00/21] s390x: CPU Topology

2023-10-16 Thread Nina Schoetterl-Glausch
ce v3 - Added migration (Thomas) - Separated STSI instruction from KVM to prepare TCG (Thomas) - Take care of endianess to prepare TCG (Thomas) - Added comments on STSI CPU container and PFT instruction (Thomas) - Moved enabling the instructions as the last patch (Thomas) Nina Schoette

[PATCH v26 06/21] s390x/cpu topology: resetting the Topology-Change-Report

2023-10-16 Thread Nina Schoetterl-Glausch
Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- include/hw/s390x/cpu-topology.h | 1 + target/s390x/cpu.h | 1 + target/s390x/kvm/kvm_s390x.h| 1 + hw/s390x/cpu-topology.c | 11 +++ hw/s390x/s390-virtio-

[PATCH v26 14/21] docs/s390x/cpu topology: document s390x cpu topology

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Signed-off-by: Nina Schoetterl-Glausch --- MAINTAINERS| 2 + docs/devel/index

[PATCH v26 18/21] tests/avocado: s390x cpu topology test dedicated CPU

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this from both host and guest point of view. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch S

[PATCH v26 09/21] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-10-16 Thread Nina Schoetterl-Glausch
ff-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 42 + hw/s390x/cpu-topology.c | 132 +++ 2 files ch

[PATCH v26 17/21] tests/avocado: s390x cpu topology entitlement tests

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Test changes in the entitlement from both a guest and a host point of view, depending on the polarization. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Tested-by: Thomas Huth Signed-off-by: Nina Schoetterl

[PATCH v26 07/21] s390x/cpu topology: interception of PTF instruction

2023-10-16 Thread Nina Schoetterl-Glausch
code 0 and 1 are intercepted and must be emulated by the userland hypervisor. During RESET all CPU of the configuration are placed in horizontal polarity. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Co-developed-by: Nina Schoetterl-Glausch Signed-off

[PATCH v26 21/21] tests/avocado: s390x cpu topology bad move

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QEMU refuses to move a CPU to an nonexistent location. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/avocado/s390_topology.

[PATCH v26 05/21] s390x/sclp: reporting the maximum nested topology entries

2023-10-16 Thread Nina Schoetterl-Glausch
: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- include/hw/s390x/sclp.h | 5 +++-- hw/s390x/sclp.c | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index c49051e17e..9aef6d9370 100644 --- a/include/hw/s390x

[PATCH v26 11/21] machine: adding s390 topology to info hotpluggable-cpus

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390 topology adds books and drawers topology containers. Let's add these to the HMP information for hotpluggable cpus. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- hw/core/machine-hmp-cmds.c | 6 ++ 1 file chang

[PATCH v26 02/21] CPU topology: extend with s390 specifics

2023-10-16 Thread Nina Schoetterl-Glausch
levels to the relevant QAPI structs. Add all the supported topology levels, dedication and entitlement as properties to S390 CPUs. Create machine-common.json so we can later include it in machine-target.json also. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v26 16/21] tests/avocado: s390x cpu topology polarization

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoe

Re: [PATCH v25 02/21] CPU topology: extend with s390 specifics

2023-10-13 Thread Nina Schoetterl-Glausch
On Thu, 2023-10-12 at 13:02 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > S390 adds two new SMP levels, drawers and books to the CPU > > topology. > > S390 CPUs have specific topology features like d

Re: [PATCH v24 01/21] qapi: machine.json: change docs regarding CpuInstanceProperties

2023-10-13 Thread Nina Schoetterl-Glausch
On Thu, 2023-10-12 at 07:59 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > Clarify roles of different architectures. > > Also change things a bit in anticipation of additional members being > > added. > > > > Suggested-by: Markus

[PATCH v25 19/21] tests/avocado: s390x cpu topology test socket full

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QMP set-cpu-topology does not accept to overload a socket. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/avocado/s390_topo

[PATCH v25 20/21] tests/avocado: s390x cpu topology dedicated errors

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel Let's test that QEMU refuses to setup a dedicated CPU with low or medium entitlement. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/avocad

[PATCH v25 06/21] s390x/cpu topology: resetting the Topology-Change-Report

2023-10-05 Thread Nina Schoetterl-Glausch
Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- include/hw/s390x/cpu-topology.h | 1 + target/s390x/cpu.h | 1 + target/s390x/kvm/kvm_s390x.h| 1 + hw/s390x/cpu-topology.c | 11 +++ hw/s390x/s390-virtio-

[PATCH v25 01/21] qapi: machine.json: change docs regarding CpuInstanceProperties

2023-10-05 Thread Nina Schoetterl-Glausch
Clarify roles of different architectures. Also change things a bit in anticipation of additional members being added. Suggested-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine.json | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a

[PATCH v25 10/21] machine: adding s390 topology to query-cpu-fast

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas

[PATCH v25 09/21] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-10-05 Thread Nina Schoetterl-Glausch
ff-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 42 + hw/s390x/cpu-topology.c | 132 +++ 2 files changed, 174 insertions(+)

[PATCH v25 07/21] s390x/cpu topology: interception of PTF instruction

2023-10-05 Thread Nina Schoetterl-Glausch
code 0 and 1 are intercepted and must be emulated by the userland hypervisor. During RESET all CPU of the configuration are placed in horizontal polarity. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Co-developed-by: Nina Schoetterl-Glausch Signed-off

[PATCH v25 04/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch

[PATCH v25 03/21] s390x/cpu topology: add topology entries on CPU hotplug

2023-10-05 Thread Nina Schoetterl-Glausch
added in the physical topology based on its core ID and it gets defaults values for the modifier attributes. This way, starting QEMU without specifying the topology can still get some advantage of the CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by

[PATCH v25 11/21] machine: adding s390 topology to info hotpluggable-cpus

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390 topology adds books and drawers topology containers. Let's add these to the HMP information for hotpluggable cpus. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- hw/core/machine-hmp-cmds.c | 6 ++ 1 file chang

[PATCH v25 17/21] tests/avocado: s390x cpu topology entitlement tests

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel Test changes in the entitlement from both a guest and a host point of view, depending on the polarization. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Tested-by: Thomas Huth Signed-off-by: Nina Schoetterl

[PATCH v25 16/21] tests/avocado: s390x cpu topology polarization

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoe

[PATCH v25 15/21] tests/avocado: s390x cpu topology core

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel Introduction of the s390x cpu topology core functions and basic tests. We test the correlation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v25 08/21] target/s390x/cpu topology: activate CPU topology

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility in the host CPU model for the guest in the case the topology is available in QEMU and in KVM. The feature is disabled by default and fenced f

[PATCH v25 14/21] docs/s390x/cpu topology: document s390x cpu topology

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Signed-off-by: Nina Schoetterl-Glausch --- MAINTAINERS| 2 + docs/devel/index

[PATCH v25 21/21] tests/avocado: s390x cpu topology bad move

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QEMU refuses to move a CPU to an nonexistent location. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/avocado/s390_topology.

[PATCH v25 02/21] CPU topology: extend with s390 specifics

2023-10-05 Thread Nina Schoetterl-Glausch
the SMP properties with books and drawers levels and S390 CPU with dedication and entitlement, Add machine-common.json so we can later include it in machine-target.json also. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by

[PATCH v25 05/21] s390x/sclp: reporting the maximum nested topology entries

2023-10-05 Thread Nina Schoetterl-Glausch
: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- include/hw/s390x/sclp.h | 5 +++-- hw/s390x/sclp.c | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index c49051e17e..9aef6d9370 100644 --- a/include/hw/s390x

[PATCH v25 12/21] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event

2023-10-05 Thread Nina Schoetterl-Glausch
-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 34 ++ hw/s390x/cpu-topology.c | 2 ++ 2 files changed, 36 insertions(+) diff --git a/qapi/machine-target.json b/qapi/machine-target.json index

[PATCH v25 18/21] tests/avocado: s390x cpu topology test dedicated CPU

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this from both host and guest point of view. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch S

[PATCH v25 13/21] qapi/s390x/cpu topology: add query-s390x-cpu-polarization command

2023-10-05 Thread Nina Schoetterl-Glausch
From: Pierre Morel The query-s390x-cpu-polarization qmp command returns the current CPU polarization of the machine. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch

[PATCH v25 00/21] s390x: CPU Topology

2023-10-05 Thread Nina Schoetterl-Glausch
s of type CpuInstanceProperties associated with a +# virtual CPU, e.g. the socket id # 2: 3ea5ee1016 ! 2: 4a6314be55 CPU topology: extend with s390 specifics @@ Commit message Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch

Re: [PATCH v24 02/21] CPU topology: extend with s390 specifics

2023-10-04 Thread Nina Schoetterl-Glausch
On Tue, 2023-09-26 at 14:15 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > S390 adds two new SMP levels, drawers and books to the CPU > topology. > S390 CPUs have specific topology features like dedication and > entitlement. These indicate to the guest informat

[PATCH v24 04/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch

[PATCH v24 13/21] qapi/s390x/cpu topology: add query-s390x-cpu-polarization command

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel The query-s390x-cpu-polarization qmp command returns the current CPU polarization of the machine. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch

[PATCH v24 06/21] s390x/cpu topology: resetting the Topology-Change-Report

2023-09-26 Thread Nina Schoetterl-Glausch
Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- include/hw/s390x/cpu-topology.h | 1 + target/s390x/cpu.h | 1 + target/s390x/kvm/kvm_s390x.h| 1 + hw/s390x/cpu-topology.c | 11 +++ hw/s390x/s390-virtio-

[PATCH v24 19/21] tests/avocado: s390x cpu topology test socket full

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QMP set-cpu-topology does not accept to overload a socket. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/avocado/s390_topo

[PATCH v24 21/21] tests/avocado: s390x cpu topology bad move

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QEMU refuses to move a CPU to an nonexistent location. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/avocado/s390_topology.

[PATCH v24 05/21] s390x/sclp: reporting the maximum nested topology entries

2023-09-26 Thread Nina Schoetterl-Glausch
: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- include/hw/s390x/sclp.h | 5 +++-- hw/s390x/sclp.c | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index c49051e17e..9aef6d9370 100644 --- a/include/hw/s390x

[PATCH v24 09/21] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-09-26 Thread Nina Schoetterl-Glausch
ff-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 42 + hw/s390x/cpu-topology.c | 132 +++ 2 files changed, 174 insertions(+)

[PATCH v24 03/21] s390x/cpu topology: add topology entries on CPU hotplug

2023-09-26 Thread Nina Schoetterl-Glausch
added in the physical topology based on its core ID and it gets defaults values for the modifier attributes. This way, starting QEMU without specifying the topology can still get some advantage of the CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by

[PATCH v24 08/21] target/s390x/cpu topology: activate CPU topology

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility in the host CPU model for the guest in the case the topology is available in QEMU and in KVM. The feature is disabled by default and fenced f

[PATCH v24 10/21] machine: adding s390 topology to query-cpu-fast

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas

[PATCH v24 12/21] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event

2023-09-26 Thread Nina Schoetterl-Glausch
-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 34 ++ hw/s390x/cpu-topology.c | 2 ++ 2 files changed, 36 insertions(+) diff --git a/qapi/machine-target.json b/qapi/machine-target.json index

[PATCH v24 17/21] tests/avocado: s390x cpu topology entitlement tests

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Test changes in the entitlement from both a guest and a host point of view, depending on the polarization. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- tests/avocado

[PATCH v24 07/21] s390x/cpu topology: interception of PTF instruction

2023-09-26 Thread Nina Schoetterl-Glausch
code 0 and 1 are intercepted and must be emulated by the userland hypervisor. During RESET all CPU of the configuration are placed in horizontal polarity. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Co-developed-by: Nina Schoetterl-Glausch Signed-off

[PATCH v24 18/21] tests/avocado: s390x cpu topology test dedicated CPU

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this from both host and guest point of view. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch S

[PATCH v24 01/21] qapi: machine.json: change docs regarding CpuInstanceProperties

2023-09-26 Thread Nina Schoetterl-Glausch
Clarify roles of different architectures. Also change things a bit in anticipation of additional members being added. Suggested-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- Reference to s390x docs added in patch 14 qapi/machine.json | 17 + 1 file

[PATCH v24 15/21] tests/avocado: s390x cpu topology core

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Introduction of the s390x cpu topology core functions and basic tests. We test the correlation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v24 16/21] tests/avocado: s390x cpu topology polarization

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoe

[PATCH v24 14/21] docs/s390x/cpu topology: document s390x cpu topology

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Signed-off-by: Nina Schoetterl-Glausch --- MAINTAINERS| 2 + docs/devel/index

[PATCH v24 20/21] tests/avocado: s390x cpu topology dedicated errors

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Let's test that QEMU refuses to setup a dedicated CPU with low or medium entitlement. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/avocad

[PATCH v24 11/21] machine: adding s390 topology to info hotpluggable-cpus

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390 topology adds books and drawers topology containers. Let's add these to the HMP information for hotpluggable cpus. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- hw/core/machine-hmp-cmds.c | 6 ++ 1 file chang

[PATCH v24 02/21] CPU topology: extend with s390 specifics

2023-09-26 Thread Nina Schoetterl-Glausch
the SMP properties with books and drawers levels and S390 CPU with dedication and entitlement, Add machine-common.json so we can later include it in machine-target.json also. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by

[PATCH v24 00/21] s390x: CPU Topology

2023-09-26 Thread Nina Schoetterl-Glausch
ion (Thomas) - Separated STSI instruction from KVM to prepare TCG (Thomas) - Take care of endianess to prepare TCG (Thomas) - Added comments on STSI CPU container and PFT instruction (Thomas) - Moved enabling the instructions as the last patch (Thomas) Nina Schoetterl-Glausch (1): qapi: ma

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-25 Thread Nina Schoetterl-Glausch
On Tue, 2023-09-19 at 14:47 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > S390 adds two new SMP levels, drawers and books to the CPU > > topology. > > S390 CPUs have specific topology features like d

Re: [PATCH v23 08/20] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-09-25 Thread Nina Schoetterl-Glausch
On Wed, 2023-09-20 at 13:36 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > The modification of the CPU attributes are done through a monitor > > command. > > > > It allows to move the core inside t

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-22 Thread Nina Schoetterl-Glausch
On Wed, 2023-09-20 at 13:11 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > S390 adds two new SMP levels, drawers and books to the CPU > > topology. > > S390 CPUs have specific topology features like d

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-21 Thread Nina Schoetterl-Glausch
On Wed, 2023-09-20 at 12:57 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > On Tue, 2023-09-19 at 14:47 +0200, Markus Armbruster wrote: > > > Nina Schoetterl-Glausch writes: > > > > > > > From: Pierre Morel > > > &

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-19 Thread Nina Schoetterl-Glausch
On Tue, 2023-09-19 at 14:47 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > S390 adds two new SMP levels, drawers and books to the CPU > > topology. > > S390 CPUs have specific topology features like d

  1   2   3   >