Re: [Qemu-devel] hw/nand hw/onenand and read-only

On 18.10.11 16:38 , "ext Markus Armbruster" wrote: >$ qemu-system-arm -drive if=none,file=tmp.qcow2,readonly,id=foo >-device nand,drive=foo -kernel /dev/null >qemu: hardware error: nand_device_init: Unsupported NAND block size. >[...] > >Note that I didn't bother supplying a drive wit

Re: [Qemu-devel] hw/nand hw/onenand and read-only

On 18.10.11 11:23 , "ext Markus Armbruster" wrote: >These guys have been converted to qdev relatively recently. > >I wonder what happens when they use a drive defined with "-drive >if=none,readonly". > >If that's not a valid configuration, we better reject read-only drives, >like ide_init_drive()

Re: [Qemu-devel] [PATCH 0/3] usb-musb: make qdev-aware

>>How to you test musb? > >Unfortunately I don't have any test cases which actively use the musb, >so I settle for testing an n810 image (and a beagle image in my omap3 >tree) and confirming that the init part of things still works ok. >(I'm not entirely happy with this but init is really all we're

Re: [Qemu-devel] OSX build issues

On 17.03.11 13:09 , "ext Tristan Gingold" wrote: >On Mar 17, 2011, at 11:28 AM, François Revol wrote: > >>From the content of the functions called it's either one of the added >>fds which cause problem on select() (but why ?), or likely some signal >>masks which interfere with some internal thre

[Qemu-devel] Re: OMAP3 bug: disassembler disagreed with translator

On Feb 18, 2011, at 14:08, ext Антон Кочков wrote: > Here also modified omap3_boot.c file. I'm dont know why it is > successfully load bootrom at 0x40014000, but cant do this for 0x14000 > - it always fill by zeroes. > I'm only need copy memory from already loaded rom image from > 0x40014000 to 0

Re: Về: [Qemu-devel] How to fix NEON of cor text-a9 on qemu

On Sep 22, 2010, at 19:56, ext Pham Van Thiet wrote: > I try to find them on meego.gitorious.org/qemu-maemo but I didn't find them. > Can > you send the links to me? Just clone the git repository and build qemu. Since it is more a development branch than a staging branch against upstream al

Re: [Qemu-devel] How to fix NEON of cortext-a9 on qemu

On Sep 21, 2010, at 19:22, ext Pham Van Thiet wrote: > example for it please send it for me. Or if you have a patch file for NEON > instruction on qemu please send it for me? You could have a try with the MeeGo QEMU branch (meego.gitorious.org/qemu-maemo). We have a bunch of ARM patches on top

Re: [Qemu-devel] Can not find the function body of omap3_lcd_panel_draw_fn_32

On Apr 23, 2010, at 15:17, ext steven_c...@htc.com wrote: I am tracing the code and I can not find the body of omap3_lcd_panel_draw_fn_32. I did print out the address and search the map file, that address did not match any function. Can some one give me a hint?? Tha

Re: [Qemu-devel] QEMU state of ARM NEON support.

On Mar 25, 2010, at 12:27, ext Dmitry Zhurikhin wrote: > juha.riihim...@nokia.com wrote: >> - vqdmlsl yields different results for some specific input values, however I >> think QEMU is producing correct results. For example, >> 1431655765-(2*-32768*-32768)=-715827883 but your reference hardwar

Re: [Qemu-devel] QEMU state of ARM NEON support.

Hi, Thanks for the testing. I fixed all of the issues found by your test programs except: - vmull.p8 is not implemented in QEMU. - vrecpe/vrsqrte returns exact reciprocal/root in QEMU instead of estimate. - Using subnormal floating point input values yields wrong results (this is visible in y

Re: [Qemu-devel] QEMU support for ARM security features / TrustZone

On Jan 22, 2010, at 14:01, ext leic...@informatik.uni-frankfurt.de wrote: > I found that QEMU emulates ARM Cortex-8 which in hardware have Trustzone > support. It is unclear to me if this is the case in the version that QEMU > emulates. ARM TrustZone features are currently not emulated. Regard

Re: [Qemu-devel] [PATCH 09/11] Cocoa: Shutdown when window is closed

On Dec 13, 2009, at 04:55, ext Andreas Färber wrote: > The application is not very useful once the guest window is closed. > QEMU is not a document-based application; terminating it automatically > saves the user another action and resembles SDL behavior. > > Signed-off-by: Andreas Färber > Cc:

Re: [Qemu-devel] [PATCH] target-arm: tcg temp variable usage cleanup

On Nov 1, 2009, at 02:08, ext Laurent Desnogues wrote: > On Thu, Oct 29, 2009 at 3:01 PM, wrote: >> From: Juha Riihimäki >> >> TCG temporary variable handling in target-arm/translate.c is >> currently >> somewhat inconsistent; some functions allocate new temporaries that >> the >> calling f

Re: [Qemu-devel] [PATCH 00/19 v2] Add virtio-net/tap support for partial csums and GSO

On Oct 22, 2009, at 19:43, ext Mark McLoughlin wrote: > Hey, >Over a year ago we added some code to qemu-kvm.git which takes > advantage of the recent tun/tap IFF_VNET_HDR feature in order to allow > virtio-net to send and receive packets with partial checksums and > segmentation offloaded

Re: [Qemu-devel] [PATCH v2 09/10] target-arm: optimize neon vld/vst ops

On Oct 26, 2009, at 23:05, ext Aurelien Jarno wrote: > On Mon, Oct 26, 2009 at 10:11:07AM +0100, Laurent Desnogues wrote: >> On Mon, Oct 26, 2009 at 8:46 AM, wrote: >>> >>> On Oct 25, 2009, at 16:01, ext Laurent Desnogues wrote: >>> I don't really like the idea of having tcg_qemu_ld/st not

Re: [Qemu-devel] [PATCH v2 05/10] target-arm: optimize arm load/store multiple ops

On Oct 27, 2009, at 11:00, ext Aurelien Jarno wrote: > juha.riihim...@nokia.com a écrit : >> On Oct 27, 2009, at 10:39, ext Aurelien Jarno wrote: >> >>> On Sat, Oct 24, 2009 at 03:19:04PM +0300, juha.riihim...@nokia.com >>> wrote: From: Juha Riihimäki RM load/store multiple instruc

Re: [Qemu-devel] [PATCH v2 05/10] target-arm: optimize arm load/store multiple ops

On Oct 27, 2009, at 10:39, ext Aurelien Jarno wrote: > On Sat, Oct 24, 2009 at 03:19:04PM +0300, juha.riihim...@nokia.com > wrote: >> From: Juha Riihimäki >> >> RM load/store multiple instructions can be slightly optimized by >> loading the register offset constant into a variable outside the >

Re: [Qemu-devel] [PATCH v2][RESEND] target-arm: cleanup internal resource leaks

On Oct 26, 2009, at 12:46, ext Laurent Desnogues wrote: >> @@ -5511,8 +5539,9 @@ static int disas_neon_data_insn(CPUState * >> env, DisasContext *s, uint32_t insn) >>tcg_gen_movi_i32(tmp, 0); >>} >>tmp2 = neon_load_reg(rm, 0); >> -

Re: [Qemu-devel] [PATCH v2 09/10] target-arm: optimize neon vld/vst ops

On Oct 25, 2009, at 16:01, ext Laurent Desnogues wrote: > I don't really like the idea of having tcg_qemu_ld/st not factored > in some place, as it makes memory access tracing extensions > more intrusive. > > This brings us back to the problem having function freeing tmps. > In that case, you cou

Re: [Qemu-devel] [PATCH v2 03/10] target-arm: allow modifying vfp fpexc en bit only

On Oct 25, 2009, at 14:23, ext Laurent Desnogues wrote: > On Sat, Oct 24, 2009 at 1:19 PM, wrote: >> From: Juha Riihimäki >> >> All other bits except for the EN in the VFP FPEXC register are >> defined >> as subarchitecture specific and real functionality for any of the >> other bits has not

Re: [Qemu-devel] [PATCH] Add support for multiple simultaneously used keyboard devices.

On Oct 24, 2009, at 18:09, ext Filip Navara wrote: > The support for multiple keyboard devices is essential for emulating > embedded boards where multiple input devices are present (eg. keypad > and rotary encoder) which are implemented using separate QEMU devices. Nice to see someone else ne

Re: [Qemu-devel] [PATCH 10/12] target-arm: replace tcg_gen_rori_i32 by tcg_gen_rotri_i32

On Oct 23, 2009, at 18:25, ext Aurelien Jarno wrote: > On Wed, Oct 21, 2009 at 12:18:08PM +0200, juha.riihim...@nokia.com > wrote: >> Use native rotation if possible instead of a simulated one. > > I have another patch in my local tree that handle more cases: Great, I'll drop it from my patch

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

On Oct 22, 2009, at 13:08, ext Gerd Hoffmann wrote: > On 10/22/09 11:55, juha.riihim...@nokia.com wrote: > > Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. >>> >>> Makes it very difficult to extract the patches in a automated >>> way ... >> >> Well, I tes

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

On Oct 22, 2009, at 12:10, ext Gerd Hoffmann wrote: > On 10/22/09 10:35, juha.riihim...@nokia.com wrote: >>> Hi, >>> -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) >>> >>> Your mailer mangles the patches. >> >> Yes, I know, I can't help it, I'm sorry.

Re: [Qemu-devel] [PATCH 03/12] target-arm: add support for neon vld1.64 instruction

On Oct 22, 2009, at 11:39, ext Laurent Desnogues wrote: > On Wed, Oct 21, 2009 at 12:17 PM, wrote: >> Add support for neon vld1.64 instruction. >> >> From: Riku Voipio >> Signed-off-by: Juha Riihimäki >> --- >> diff --git a/target-arm/translate.c b/target-arm/translate.c >> index 3ea9d51..d02

Re: [Qemu-devel] [PATCH 12/12] [RESEND] target-arm: fix neon shift helper functions

On Oct 22, 2009, at 10:57, ext Laurent Desnogues wrote: > On Wed, Oct 21, 2009 at 1:01 PM, wrote: >> Current code is broken at least on gcc 4.2, the result of a >> comparison >> "-1 >= sizeof(type) * 8" results true and causes wrong code path to >> be >> taken. The fix utilizes abs() functi

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

On Oct 22, 2009, at 11:04, ext Gerd Hoffmann wrote: > > Hi, > >> -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, >> tcg_const_i32(mask)) > > Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. That's why I include the patch as an attachment as well -- the at

Re: [Qemu-devel] [PATCH 07/12] target-arm: fix neon vsri, vshl and vsli ops

On Oct 22, 2009, at 10:18, ext Laurent Desnogues wrote: > On Thu, Oct 22, 2009 at 8:49 AM, wrote: >> >> On Oct 21, 2009, at 13:46, ext Laurent Desnogues wrote: >> @@ -4624,31 +4624,31 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)

Re: [Qemu-devel] [PATCH] target-arm: cleanup internal resource leaks

On Oct 22, 2009, at 08:40, Riihimaki Juha (Nokia-D/Helsinki) wrote: >>> @@ -4676,12 +4694,16 @@ static int disas_neon_data_insn(CPUState * >>> env, DisasContext *s, uint32_t insn) >>>gen_neon_narrow_satu(size - 1, tmp, >>> cpu_V0); >>>} >>>

Re: [Qemu-devel] [PATCH 07/12] target-arm: fix neon vsri, vshl and vsli ops

On Oct 21, 2009, at 13:46, ext Laurent Desnogues wrote: >> @@ -4624,31 +4624,31 @@ static int disas_neon_data_insn(CPUState * >> env, DisasContext *s, uint32_t insn) >> switch (size) { >> case 0: >> if (op

[Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

Revised patch for getting rid of tcg temporary variable leaks in target-arm/translate.c. This version also includes the leak patch for gen_set_cpsr macro, now converted as a static inline function, which I sent earlier as a separate patch on top of this patch. This patch (the attached version) shou

Re: [Qemu-devel] [PATCH] target-arm: cleanup internal resource leaks

Thanks for your feedback. I'll iron out the issues you mentioned, please look at my further inlined comments below. Cheers, Juha On Oct 21, 2009, at 22:20, ext Laurent Desnogues wrote: >> @@ -4676,12 +4694,16 @@ static int disas_neon_data_insn(CPUState * >> env, DisasContext *s, uint32_t insn

[Qemu-devel] [PATCH 12/12] [RESEND] target-arm: fix neon shift helper functions

Current code is broken at least on gcc 4.2, the result of a comparison "-1 >= sizeof(type) * 8" results true and causes wrong code path to be taken. The fix utilizes abs() function where applicable and otherwise adds a test to ensure both arguments are positive before making the aforementioned comp

[Qemu-devel] [PATCH 05/12] target-arm: optimize vfp load/store multiple ops

VFP load/store multiple instructions can be slightly optimized by loading the register offset constant into a variable outside the register loop and using the preloaded variable inside the loop instead of reloading the offset value to a temporary variable on each loop iteration. This causes

[Qemu-devel] [PATCH 08/12] target-arm: optimize thumb2 load/store multiple ops

Thumb2 load/store multiple instructions can be slightly optimized by loading the register offset constant into a variable outside the register loop and using the preloaded variable inside the loop instead of reloading the offset value to a temporary variable on each loop iteration. This cau

[Qemu-devel] [PATCH 09/12] target-arm: optimize thumb push/pop ops

Thumb push/pop instructions can be slightly optimized by loading the register offset constant into a variable outside the register loop and using the preloaded variable inside the loop instead of reloading the offset value to a temporary variable on each loop iteration. This causes less TCG

[Qemu-devel] [PATCH 12/12] target-arm: fix neon shift helper functions

Current code is broken at least on gcc 4.2, the result of a comparison "-1 >= sizeof(type) * 8" results true and causes wrong code path to be taken. The fix utilizes abs() function where applicable and otherwise adds a test to ensure both arguments are positive before making the aforementio

[Qemu-devel] [PATCH 04/12] target-arm: allow modifying vfp fpexc en bit only

All other bits except for the EN in the VFP FPEXC register are defined as subarchitecture specific and real functionality for any of the other bits has not been implemented in QEMU. However, current code allows modifying all bits in the VFP FPEXC register leading to problems when guest code

[Qemu-devel] [PATCH 11/12] target-arm: optimize neon vld/vst ops

Reduce the amount of tcg ops generated from NEON vld/vst instructions by simplifying the code generation. Signed-off-by: Juha Riihimäki --- diff --git a/target-arm/translate.c b/target-arm/translate.c index 1734fae..fa03df8 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -36

[Qemu-devel] [PATCH 01/12] target-arm: fix resource leak in gen_set_cpsr macro

Current implementation of the gen_set_cpsr macro creates a new temporary tcg variable through the tcg_const_i32 call but never marks it dead. Signed-off-by: Juha Riihimäki --- diff --git a/target-arm/translate.c b/target-arm/translate.c index bc51bcb..bda105e 100644 --- a/target-arm/translate

[Qemu-devel] [PATCH 10/12] target-arm: replace tcg_gen_rori_i32 by tcg_gen_rotri_i32

Use native rotation if possible instead of a simulated one. From: Filip Navara Signed-off-by: Juha Riihimäki --- diff --git a/target-arm/translate.c b/target-arm/translate.c index 99a9ffd..1734fae 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -418,21 +418,6 @@ static inline

[Qemu-devel] [PATCH 06/12] target-arm: optimize arm load/store multiple ops

ARM load/store multiple instructions can be slightly optimized by loading the register offset constant into a variable outside the register loop and using the preloaded variable inside the loop instead of reloading the offset value to a temporary variable on each loop iteration. This causes

[Qemu-devel] [PATCH 07/12] target-arm: fix neon vsri, vshl and vsli ops

Shift immediate value is incorrectly overwritten by a temporary variable in the processing of NEON vsri, vshl and vsli instructions. Signed-off-by: Juha Riihimäki --- diff --git a/target-arm/translate.c b/target-arm/translate.c index 59bf7bc..c92ecc6 100644 --- a/target-arm/translate.c +++ b/ta

[Qemu-devel] [PATCH 02/12] target-arm: optimize thumb 32bit multiply

Current implementation of thumb mul instruction is implemented as a 32x32->64 multiply which then uses only 32 least significant bits of the result. Replace that with a simple 32x32->32 multiply. Signed-off-by: Juha Riihimäki --- diff --git a/target-arm/translate.c b/target-arm/translate.c in

[Qemu-devel] [PATCH 03/12] target-arm: add support for neon vld1.64 instruction

Add support for neon vld1.64 instruction. From: Riku Voipio Signed-off-by: Juha Riihimäki --- diff --git a/target-arm/translate.c b/target-arm/translate.c index 3ea9d51..d027572 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -795,6 +795,12 @@ static inline TCGv gen_ld32(TCGv

[Qemu-devel] [PATCH 00/12] target-arm: miscellaneous fixes

Hi, This patch series includes a number of smaller fixes and improvements to the ARM translator. The series should be applied in sequence as the modifications are all but one related to the same file, target-arm/ translate.c. The whole series should apply cleanly against latest git AFTER ap

Re: [Qemu-devel] [PATCH 00/18] target-arm cleanup

On Oct 19, 2009, at 16:23, ext Aurelien Jarno wrote: >> I think I have a couple of other fixes and patches on top of that as >> well, but I'd rather wait until you get this bunch committed and then >> format the patches against the new mainline so that they apply. > > Thanks I have seen your patc

[Qemu-devel] [PATCH] target-arm: cleanup internal resource leaks

Current ARM translator code has several places where it leaves temporary TCG variables alive. This patch removes all such instances I have found so far. Sorry for the mangled inlined patch, the mailserver I use doesn't like patches so I've also included it as an attachment that hopefully status cor

Re: [Qemu-devel] [PATCH 00/18] target-arm cleanup

>> Apart from the points you have raised about specific patches there >> were few more minor bugs in the series spotted by Juha Riihimäki >> . A fix is available at >> http://repo.or.cz/w/qemu/navara.git?a=commit;h=2ce696baa6fc5d99522cf387b6a4913807fd43ed > > One of the fix was already in my branch