On 11/05/2014 03:12 AM, Shannon Zhao wrote:
> Hi Rémy,
>
> On 2014/11/5 16:26, GAUGUEY Rémy 228890 wrote:
>> Hi Shannon,
>>
>>> Type of backend bandwith(GBytes/sec)
>>> virtio-net 0.66
>>> vhost-net 1.49
>>> vhost-net with irqfd2.01
>>>
>>> Test cmd: ./iperf
On 08/21/2014 09:51 AM, Wei Huang wrote:
Current ARM virt model supports up to 4 CPUs. Given that many recent
ARM servers contain 8 or more cores, it is time to bump up max guest CPUs
to 8. This patch was tested with a VM runnng 3.15 Linux kernel. All 8
VCPUs showed up.
Signed-off-by: Wei Huang
On 08/20/2014 02:41 PM, Alex Williamson wrote:
> On Wed, 2014-08-20 at 14:12 -0500, Joel Schopp wrote:
>>> +int vfio_get_device(VFIOGroup *group, const char *name,
>>> + VFIODevice *vbasedev)
>>> +{
>>> +struct vfio_device_inf
> +int vfio_get_device(VFIOGroup *group, const char *name,
> + VFIODevice *vbasedev)
> +{
> +struct vfio_device_info dev_info = { .argsz = sizeof(dev_info) };
> +struct vfio_region_info reg_info = { .argsz = sizeof(reg_info) };
> +struct vfio_irq_info irq_info = {
On 08/19/2014 05:43 PM, Peter Maydell wrote:
> On 19 August 2014 22:33, Joel Schopp wrote:
>> I'm running on a system with 8 cpus and it would be nice to have qemu
>> support all of them. The attached patch does that and has been tested.
>>
>> That said, I
Cc: Peter Maydell
Signed-off-by: Joel Schopp
---
hw/arm/virt.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 06f4fad..7a09260 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -605,7 +605,7 @@ static QEMUMachine machvirt_a15_machine = {
>> For the index [2*i],[2*i+1], etc is clearly a bug as when i = 1 it will
>> overwrite two of the values. Changing that to [4*i],[4*i+1],etc fixes it.
>>
>> I think you are right on the size. I also wonder if the user doesn't
>> pass in a dtb if qemu should try to recreate the device-tree entry
On 08/18/2014 05:11 PM, Peter Maydell wrote:
> On 18 August 2014 22:54, Joel Schopp wrote:
>> +static void vfio_fdt_add_device_node(SysBusDevice *sbdev, void *opaque)
>> +{
>> +PlatformDevtreeData *data = opaque;
>> +void *fdt = data->fdt;
>> +
+static void vfio_fdt_add_device_node(SysBusDevice *sbdev, void *opaque)
+{
+PlatformDevtreeData *data = opaque;
+void *fdt = data->fdt;
+const char *parent_node = data->node;
+int compat_str_len;
+char *nodename;
+int i, ret;
+uint32_t *irq_attr;
+uint64_t *reg_att
we at Virtual Open Systems did some work and tested vhost-net on ARM
back in March.
The setup was based on:
- host kernel with our ioeventfd patches:
http://www.spinics.net/lists/kvm-arm/msg08413.html
- qemu with the aforementioned patches from Ying-Shiuan Pan
https://lists.gnu.org/archive/ht
On 08/11/2014 08:09 AM, Juan Quintela wrote:
> Hi
>
> Please, send any topic that you are interested in covering.
>
> People have complained on the past that I don't cancel the call until
> the very last minute. So, what do you think that deadline for
> submitting topics is 23:00UTC on Monday?
I
On 08/06/2014 12:30 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Hi,
> This patch-pair adds the QEMUSizedBuffer based in-memory QEMUFile
> written by Stefan Berger and Joel Schopp. I've made some minor
> fixes (and typo cleanup
The combination of a newer kernel and newer qemu make qemu work with
-smp 2 . Rather than go figure out what got fixed let's just be happy
it did.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is su
On 08/01/2014 09:19 AM, Paolo Bonzini wrote:
> Il 01/08/2014 16:02, Joel Schopp ha scritto:
>>>> I think the patch is right but, besides these considerations, does this
>>>> bug still manifest itself after Andrew fixed the start address of the
>>>> devi
> I agree.
>
> I think the patch is right but, besides these considerations, does this
> bug still manifest itself after Andrew fixed the start address of the
> device at 0x9001 (IIRC it was the pl031)?
The device I see with that address is:
hw/arm/virt.c:[VIRT_RTC] = { 0x9001, 0x1000
** Changed in: qemu
Assignee: (unassigned) => Joel Schopp (joel-schopp)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1348719
Title:
arm64: -smp 2 hangs qemu
Status in QEMU:
New
Public bug reported:
It appears that smp is broken on qemu for arm64. I'm looking into the
root cause but am curious if others can reproduce in their environments.
Tested with commit f368c33d5ab09dd5656924185cd975b11838cd25 (July 22)
from https://github.com/qemu/qemu.git
[root@joelaarch64 ~]# /
un fine there
with the patch applied.
Cc: Peter Maydell
Signed-off-by: Joel Schopp
---
kvm-all.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 1402f4f..1975862 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -618,14 +618,14 @@ static void kvm
Yea it's not hard to invent a random format each time we write something
on disk.
But I think ASN.1 BER will be useful to have in qemu anyway. E.g. it's a
better format for migration than what we have now. Once we have it in
tree re-using it seems cleaner than maintaining some per-TPM thing.
+case 0x41:
+case 0x40:
+num.mpn.sign = ((number.first & 0x1) != 0);
+num.mpn.biased_exponent = ~0;
+num.mpn.mantissa_low = 0;
+num.mpn.mantissa_high = 0;
+*obj = num.v_double;
Is this really portable enough? In other words, do we really require
This patch adds support functions for operating on in memory sized file buffers.
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/migration/qemu-file.h | 12 +++
include/qemu-common.h | 15
util/qemu-file.c | 184
Implement an input visitor for ASN.1 BER encoding.
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/qapi/ber-input-visitor.h | 30 ++
qapi/Makefile.objs |2 +-
qapi/ber-input-visitor.c | 1073
Implement an output visitor for ASN.1 BER encoding.
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
configure |2 +-
include/qapi/ber-output-visitor.h | 28 ++
include/qapi/ber.h| 107 +++
qapi/Makefile.objs
Add BER Visitor hooks to test-visitor-serialization
Cc: Michael Tsirkin
Cc: Stefan Berger
Signed-off-by: Joel Schopp
---
tests/Makefile |2 +-
tests/test-visitor-serialization.c | 72
2 files changed, 73 insertions(+), 1 deletion
Add a 3 very short file wrapper functions to make code that follows more
readable. Also export an existing function that is currently static.
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/migration/qemu-file.h |3 +++
util/qemu-file.c
they are for now
v3 forward port to resolve conflicts
v2 forward port to resolve conflicts, strip trailing whitespace during move
Cc: Paolo Bonzini
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/migration/qemu-file.h |5 +
savevm.c
Since I'm throwing all this code out there I'm also signing up to maintain it.
Send me your bug reports.
Cc: Michael Tsirkin
Cc: Stefan Berger
Signed-off-by: Joel Schopp
---
MAINTAINERS |8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
ind
rm so long as it can
be deserialized into a single-dimension C array.
Cc: Michael Tsirkin
Cc: Paolo Bonzini
Signed-off-by: Michael Roth
Signed-off-by: Joel Schopp
---
include/qapi/visitor-impl.h |4
include/qapi/visitor.h |4
qapi/qapi-visit-core.c |
Add a sized buffer interface to qapi.
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/qapi/visitor-impl.h |2 ++
include/qapi/visitor.h |2 ++
qapi/qapi-visit-core.c |8
3 files changed, 12 insertions(+)
diff --git a
These patches implement asn1 ber visitors for encoding and decoding data.
changed since v2:
Moved qemu-file.c to util/
Left the bdrv functions in savevm.c
Fixed a typo in the introduction to qapi c arrays patch
Fixed two indendations in the qapi c arrays patch
changed since v1:
Moved .c files in
they are for now
v3 forward port to resolve conflicts
v2 forward port to resolve conflicts, strip trailing whitespace during move
Cc: Paolo Bonzini
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/migration/qemu-file.h |5 +
savevm.c
-util-obj-y = util/ qobject/ qapi/ trace/
+util-obj-y = util/ qobject/ qapi/ trace/ qemu-file.o
Please either move it to util/ (and the include file to
include/qemu/file.h), or leave it in common-obj-y. I prefer the former,
since as a rule of thumb util-obj-y includes code that should be easy
Add BER Visitor hooks to test-visitor-serialization
Cc: Michael Tsirkin
Cc: Stefan Berger
Signed-off-by: Joel Schopp
---
tests/Makefile |2 +-
tests/test-visitor-serialization.c | 72
2 files changed, 73 insertions(+), 1 deletion
Implement an output visitor for ASN.1 BER encoding.
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
configure |2 +-
include/qapi/ber-output-visitor.h | 28 ++
include/qapi/ber.h| 107 +++
qapi/Makefile.objs
Implement an input visitor for ASN.1 BER encoding.
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/qapi/ber-input-visitor.h | 30 ++
qapi/Makefile.objs |2 +-
qapi/ber-input-visitor.c | 1073
This patch adds support functions for operating on in memory sized file buffers.
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/migration/qemu-file.h | 12 +++
include/qemu-common.h | 15
qemu-file.c | 184
Since I'm throwing all this code out there I'm also signing up to maintain it.
Send me your bug reports.
Cc: Michael Tsirkin
Cc: Stefan Berger
Signed-off-by: Joel Schopp
---
MAINTAINERS |8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
ind
rm so long as it can
be deserialized into a single-dimension C array.
Cc: Michael Tsirkin
Cc: Paolo Bonzini
Signed-off-by: Michael Roth
Signed-off-by: Joel Schopp
---
include/qapi/visitor-impl.h |4
include/qapi/visitor.h |4
qapi/qapi-visit-core.c |
: Joel Schopp
---
Makefile.objs |2 +-
include/migration/qemu-file.h |6 +
qemu-file.c | 715 +
savevm.c | 690 ---
4 files changed, 722 insertions(+), 691
Add a 3 very short file wrapper functions to make code that follows more
readable. Also export an existing function that is currently static.
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/migration/qemu-file.h |3 +++
qemu-file.c
Add a sized buffer interface to qapi.
Cc: Michael Tsirkin
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
include/qapi/visitor-impl.h |2 ++
include/qapi/visitor.h |2 ++
qapi/qapi-visit-core.c |8
3 files changed, 12 insertions(+)
diff --git a
These patches implement asn1 ber visitors for encoding and decoding data.
changed since v1:
Moved .c files into qapi directory
Moved .h files into include/qapi
Added sized buffer code
cleaned up Makefile changes to play nicer
Broke out patches for output/input visitors
New tests in tests/test-vis
conflicts, strip trailing whitespace during move
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
Makefile.objs |2 +-
include/migration/qemu-file.h |6 +
qemu-file.c | 715 +
savevm.c
good...
Reviewed-by: Joel Schopp
Thanks for the feedback.
On 02/27/2013 02:28 AM, Andreas Färber wrote:
Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com:
These patches implement asn1 ber visitors for encoding and decoding data.
Would be good to not be lazy and spell them correctly in at least one of
the two lines of t
Not sure how you sent this but it's not threaded properly and the diffs
aren't git diffs. Please use git-send-email.
I used quilt mail. I apologize for the improper threading. I'll switch
over to git-send-email in the future.
+int qemu_write_bytes(QEMUFile *f, const uint8_t *buf, int si
+if(popen_file == NULL) {
Please make a preparatory patch which adds missing spaces between 'if'
statements and '('.
I'll do a preparatory style cleanup patch of existing code if it is
deemed necessary by the maintainers, but I don't think it's a good idea.
The patch as it stands now
during move
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
Makefile.objs |2
include/migration/qemu-file.h |4
qemu-file.c | 670 ++
savevm.c | 646
This patch reorganizes qemu file operations to be in their own source file
instead of being lumped in savevm.c. Besides being more logical for maintenance
it also makes it easier for future users of the file functions to add tests.
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
> Is there some magic (= tool) which detected these "broken windows"
> in hw/loader.c, qemu-io.c and vl.c, or was it just a manual code
> review or luck?
I used a proprietary static analysis tool called BEAM.
http://domino.research.ibm.com/comm/research.nsf/pages/r.da.beam.html
It found pages o
least leave us with easier to
maintain code.
Joel Schopp (3):
remove dead code from hw/loader.c
fix variable type in qemu-io.c
remove pointless if from vl.c
hw/loader.c |5 -
qemu-io.c |4 ++--
vl.c|4 +---
3 files changed, 3 insertions(+), 10 deletions(-)
We already set sockets to nonzero in the code above.
So this if statement always evaluates true. Remove it.
Signed-off-by: Joel Schopp
---
vl.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index 8a5de9f..a0c28b6 100644
--- a/vl.c
+++ b/vl.c
@@ -801,9
The variable len can get a negative return value from cvtnum,
which we check for, but which is impossible with the current
unsigned variable type. Currently the if(len < 0) check is
pointless. This patch fixes that.
Signed-off-by: Joel Schopp
---
qemu-io.c |4 ++--
1 files changed
Removing dead code. Above we already continued when
rom->addr + valuegreaterthan0 < addr so this condition is always false.
Signed-off-by: Joel Schopp
---
hw/loader.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/hw/loader.c b/hw/loader.c
index 79a6f95..4
This is a simple cleanup patch that catches a few places where a function
returns early but doesn't free recently malloced memory, resulting in a memory
leak.
Signed-off-by: Joel Schopp
---
linux-user/elfload.c |8 ++--
qemu-io.c|8 ++--
qemu-sock
** Tags added: windows
--
Windows XP x64 / 2008 Server x64 broken on 32-bit hosts with QEMU > 0.9.0
https://bugs.launchpad.net/bugs/521202
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
QEMU >0.9.0
Please send this patch with a signed-off-by: to the linux kernel mailing
list and netdev mailing lists, see
http://www.kernel.org/pub/linux/docs/lkml/#s3-3
** Changed in: qemu
Status: New => Incomplete
--
no useful error message when tap device open fails
https://bugs.launchpad.net/bugs/5
** Tags added: windows
--
DHCP/NAT: Vista fails to get IP from DHCP engine
https://bugs.launchpad.net/bugs/318824
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
Problem: When I use userspace netwo
** Tags added: windows
--
64-bit win2003r2 with sp2 64-bit with network type rtl8139 generates blue
screen after running network test
https://bugs.launchpad.net/bugs/485258
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU
** Tags added: windows
--
remote migration fails with message "load of migration failed"
https://bugs.launchpad.net/bugs/491345
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
Remote migration fails
** Tags added: windows
--
winxp.64 fails to install in -rc2 with kvm
https://bugs.launchpad.net/bugs/497273
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
Host: Fedora11, 64-bit
Kernel: 2.6.30.9-96
** Tags added: windows
--
qemu-system-x86_64 fails to install 32-bit vista and windows 2008
https://bugs.launchpad.net/bugs/485243
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
Hello everyone
qem
** Tags added: powerpc
--
broken qemu linux-user build on ppc
https://bugs.launchpad.net/bugs/393531
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
kvm-87 build fails on ppc, kvm-86 builds fine.
** Tags added: windows
--
nic e1000 network interface does not work with 32-bit windows 2003r2 with sp2
https://bugs.launchpad.net/bugs/485250
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
nic e1
** Tags added: powerpc
--
qemu powerpc target crashes on "hello world"
https://bugs.launchpad.net/bugs/501141
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
Downloaded qemu and associated PowerPc
** Tags added: windows
--
Windos XP BSOD with HP Photosmart usb device attached
https://bugs.launchpad.net/bugs/441672
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
https://bugzilla.redhat.com/sho
** Tags added: windows
--
Windows 2008 datacenter- 64 bit , installation fails with qemu-system-x86_64
0.11.50
https://bugs.launchpad.net/bugs/485239
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
** Tags added: windows
--
sound broken in qemu 0.12.x
https://bugs.launchpad.net/bugs/510612
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Bug description:
In qemu 0.12.x there is a jitter when sound is played by
** Tags added: windows
--
Windows XP/2003 doesn't boot
https://bugs.launchpad.net/bugs/586175
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: New
Status in Fedora: Unknown
Bug description:
Hello everyone,
my qemu doesn
69 matches
Mail list logo