> I agree. > > I think the patch is right but, besides these considerations, does this > bug still manifest itself after Andrew fixed the start address of the > device at 0x90010000 (IIRC it was the pl031)? The device I see with that address is: hw/arm/virt.c: [VIRT_RTC] = { 0x90010000, 0x1000 },
The bug still manifests itself with that in the tree (without my patch applied).