[PATCH v13 09/10] docs/system: virtio-gpu: Update Venus link

2025-06-01 Thread Dmitry Osipenko
Change virtio-gpu Venus link, pointing it at the Mesa Venus documentation instead of the protocol. The Mesa doc provides more information and also has a link to the protocol. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio

[PATCH v13 05/10] virtio-gpu: Support DRM native context

2025-06-01 Thread Dmitry Osipenko
sults in a lightweight context implementations that yield better performance. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 11 +++ hw/display/virtio-gpu-gl.c | 2 ++ hw/display/

[PATCH v13 04/10] virtio-gpu: Support asynchronous fencing

2025-06-01 Thread Dmitry Osipenko
ontexts in virglrenderer. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 5 ++ hw/display/virtio-gpu-virgl.c | 130 + include/hw/virtio/vi

[PATCH v13 07/10] ui/gtk: Don't disable scanout when display is refreshed

2025-06-01 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v13 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc

2025-06-01 Thread Dmitry Osipenko
Extend virtio-gpu documentation with a link to the Mesa VirGL documentation. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/devices

[PATCH v13 06/10] ui/sdl2: Don't disable scanout when display is refreshed

2025-06-01 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v13 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-06-01 Thread Dmitry Osipenko
Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko [dmitry.osipe...@collabora.com: Extended and corrected doc] --- docs/system/devices/virtio-gpu.rst | 101 - 1 file changed, 98 insertions(+), 3 deletions(-) diff --git a/docs/system/devices/virtio-gpu.rst b/docs

[PATCH v13 01/10] ui/sdl2: Restore original context after new context creation

2025-06-01 Thread Dmitry Osipenko
Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- ui/sdl2-gl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index 3be17d1079af..ea2301305d3e 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -168,6 +168,9 @@ QEMUGLContext sdl2_gl_create_

[PATCH v13 00/10] Support virtio-gpu DRM native context

2025-06-01 Thread Dmitry Osipenko
ror message if DRM context can't be initialized instead of giving a warning message, as was suggested by Akihiko Odaki. - Added patchew's dependecy tag to the cover letter as was suggested by Akihiko Odaki. Alex Bennée (1): docs/system: virtio-gpu: Document host/g

[PATCH v13 03/10] virtio-gpu: Handle virgl fence creation errors

2025-06-01 Thread Dmitry Osipenko
Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 27 ++- 1 file

[PATCH v13 02/10] ui/sdl2: Implement dpy dmabuf functions

2025-06-01 Thread Dmitry Osipenko
ael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Pierre-Eric Pelloux-Prayer Signed-off-by: Dmitry Osipenko --- include/ui/sdl2.h | 7 + meson.build | 6 ++--- ui/sdl2-gl.c | 66 +++ ui/sdl2.c | 42

Re: [PATCH v12 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-05-26 Thread Dmitry Osipenko
On 5/24/25 02:33, Dmitry Osipenko wrote: > + * - Asahi DRM native context > +- `Downstream version`_ of Asahi Linux kernel > +- `mr1274`_ > + > +.. _mr1384: > https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1384 > +.. _mr1274: > https://gitl

Re: [PATCH v12 03/10] virtio-gpu: Handle virgl fence creation errors

2025-05-26 Thread Dmitry Osipenko
On 5/24/25 02:32, Dmitry Osipenko wrote: > @@ -872,6 +872,8 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, >struct virtio_gpu_ctrl_command *cmd) > { > bool cmd_suspended = false; > +uint32_t flags; Realized I re-introduced th

Re: [PATCH v4 5/7] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-05-24 Thread Dmitry Osipenko
On 5/15/25 05:45, Vivek Kasireddy wrote: > +bool surface_gl_create_texture_from_fd(DisplaySurface *surface, > + int fd, GLuint *texture) > +{ > +unsigned long size = surface_stride(surface) * surface_height(surface); > +GLenum err = glGetError(); > +

[PATCH v12 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-05-23 Thread Dmitry Osipenko
Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko [dmitry.osipe...@collabora.com: Extended and corrected doc] --- docs/system/devices/virtio-gpu.rst | 101 - 1 file changed, 98 insertions(+), 3 deletions(-) diff --git a/docs/system/devices/virtio-gpu.rst b/docs

[PATCH v12 00/10] Support virtio-gpu DRM native context

2025-05-23 Thread Dmitry Osipenko
the cover letter as was suggested by Akihiko Odaki. Alex Bennée (1): docs/system: virtio-gpu: Document host/guest requirements Dmitry Osipenko (8): ui/sdl2: Restore original context after new context creation virtio-gpu: Handle virgl fence creation errors virtio-gpu: Support asynchronous

[PATCH v12 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc

2025-05-23 Thread Dmitry Osipenko
Extend virtio-gpu documentation with a link to the Mesa VirGL documentation. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/devices

[PATCH v12 02/10] ui/sdl2: Implement dpy dmabuf functions

2025-05-23 Thread Dmitry Osipenko
ael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Pierre-Eric Pelloux-Prayer Signed-off-by: Dmitry Osipenko --- include/ui/sdl2.h | 7 + meson.build | 6 ++--- ui/sdl2-gl.c | 66 +++ ui/sdl2.c | 42

[PATCH v12 09/10] docs/system: virtio-gpu: Update Venus link

2025-05-23 Thread Dmitry Osipenko
Change virtio-gpu Venus link, pointing it at the Mesa Venus documentation instead of the protocol. The Mesa doc provides more information and also has a link to the protocol. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio

[PATCH v12 07/10] ui/gtk: Don't disable scanout when display is refreshed

2025-05-23 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v12 04/10] virtio-gpu: Support asynchronous fencing

2025-05-23 Thread Dmitry Osipenko
ontexts in virglrenderer. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 5 ++ hw/display/virtio-gpu-virgl.c | 130 + include/hw/virtio/vi

[PATCH v12 05/10] virtio-gpu: Support DRM native context

2025-05-23 Thread Dmitry Osipenko
sults in a lightweight context implementations that yield better performance. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 11 +++ hw/display/virtio-gpu-gl.c | 2 ++ hw/display/

[PATCH v12 01/10] ui/sdl2: Restore original context after new context creation

2025-05-23 Thread Dmitry Osipenko
Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- ui/sdl2-gl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index e01d9ab0c7bf..b1fe96d6af22 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -168,6 +168,9 @@ QEMUGLContext sdl2_gl_create_

[PATCH v12 06/10] ui/sdl2: Don't disable scanout when display is refreshed

2025-05-23 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v12 03/10] virtio-gpu: Handle virgl fence creation errors

2025-05-23 Thread Dmitry Osipenko
Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 28 +++- 1 file

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-20 Thread Dmitry Osipenko
On 5/20/25 11:26, Yiwei Zhang wrote: > On Mon, May 19, 2025 at 7:29 PM Dmitry Osipenko > wrote: >> >> On 5/18/25 18:26, Yiwei Zhang wrote: >>> +#if VIRGL_VERSION_MAJOR >= 1 >>> +static void virgl_write_cont

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-20 Thread Dmitry Osipenko
it msg updates based on feedbacks from BALATON >> >> Cc: qemu-sta...@nongnu.org >> Fixes: 94d0ea1c1928 ("virtio-gpu: Support Venus context") >> Signed-off-by: Yiwei Zhang > > Queued to virtio-gpu/next (in maintainer/may-2025), thanks. > > Wanted to no

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-19 Thread Dmitry Osipenko
On 5/18/25 18:26, Yiwei Zhang wrote: > +#if VIRGL_VERSION_MAJOR >= 1 > +static void virgl_write_context_fence(void *opaque, uint32_t ctx_id, > + uint32_t ring_idx, uint64_t fence_id) { > +VirtIOGPU *g = opaque; > +struct virtio_gpu_ctrl_command *cmd, *tm

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-19 Thread Dmitry Osipenko
On 5/20/25 01:20, Yiwei Zhang wrote: >> Is it possible that virglrenderer will ever write a context fence in >> virgl_renderer_create_fence()? Do we really need this check? > I assume you were referring to whether a context fence can be written > in virgl_write_fence(). Yes, the fenceq contains bot

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-19 Thread Dmitry Osipenko
On 5/18/25 18:26, Yiwei Zhang wrote: > Venus and later native contexts have their own fence context along with > multiple timelines within. Fences wtih VIRTIO_GPU_FLAG_INFO_RING_IDX in > the flags must be dispatched to be created on the target context. Fence > signaling also has to be handled on th

Re: [PATCH v2] virtio-gpu: support context init multiple timeline

2025-05-18 Thread Dmitry Osipenko
t never showed a problem during venus testing in the past. Reviewed-by: Dmitry Osipenko There could be multiple sources of a problem RE frames going backwards. I'm always testing venus in conjunction with async-cb patch that adds per-context fencing support and it doesn't help the X11

Re: [PATCH v2 12/14] ui/gtk-gl-area: Remove extra draw call in refresh

2025-05-10 Thread Dmitry Osipenko
On 5/10/25 07:52, Akihiko Odaki wrote: > On 2025/05/06 21:57, Alex Bennée wrote: >> From: Dongwon Kim >> >> This partially reverts commit 77bf310084dad38b3a2badf01766c659056f1cf2 >> which causes some guest display corruption when gtk-gl-area >> is used for GTK rendering (e.g. Wayland Compositor) p

Re: [PATCH 6/9] MAINTAINERS: add myself to virtio-gpu for Odd Fixes

2025-05-05 Thread Dmitry Osipenko
On 5/4/25 10:20, Akihiko Odaki wrote: > On 2025/04/30 3:56, Dmitry Osipenko wrote: >> On 4/28/25 15:59, Alex Bennée wrote: >>> Seeing as I've taken a few patches to here now I might as well put >>> myself forward to maintain virtio-gpu. I've marked it as Od

Re: [PATCH 8/9] virtio-gpu: fix hang under TCG when unmapping blob

2025-04-30 Thread Dmitry Osipenko
On 4/30/25 13:24, Alex Bennée wrote: >> On 4/30/25 00:19, Alex Bennée wrote: This change makes QEMU to crash. >>> What is your command line to cause the crash? >> I applied this patch on top of native context v11, ran AMD nctx and >> got a crash on SDDM startup. > Did you also include the pre-

Re: [PATCH 8/9] virtio-gpu: fix hang under TCG when unmapping blob

2025-04-29 Thread Dmitry Osipenko
On 4/30/25 00:19, Alex Bennée wrote: >> This change makes QEMU to crash. > What is your command line to cause the crash? I applied this patch on top of native context v11, ran AMD nctx and got a crash on SDDM startup. (gdb) bt #0 0x75411b54 in __pthread_kill_implementation () at /lib64/

Re: [PATCH 6/9] MAINTAINERS: add myself to virtio-gpu for Odd Fixes

2025-04-29 Thread Dmitry Osipenko
On 4/28/25 15:59, Alex Bennée wrote: > Seeing as I've taken a few patches to here now I might as well put > myself forward to maintain virtio-gpu. I've marked it as Odd Fixes as > it's not my core focus. If someone with more GPU experience comes > forward we can always update again. > > Signed-of

Re: [PATCH 8/9] virtio-gpu: fix hang under TCG when unmapping blob

2025-04-29 Thread Dmitry Osipenko
On 4/28/25 15:59, Alex Bennée wrote: > From: Manos Pitsidianakis > > This commit fixes an indefinite hang when using VIRTIO GPU blob objects > under TCG in certain conditions. > > The VIRTIO_GPU_CMD_RESOURCE_MAP_BLOB VIRTIO command creates a > MemoryRegion and attaches it to an offset on a PCI

Re: [PATCH v3 4/6] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-04-29 Thread Dmitry Osipenko
On 4/29/25 09:08, Vivek Kasireddy wrote: > +#ifdef GL_EXT_memory_object_fd > +glCreateMemoryObjectsEXT(1, &mem_obj); > +glImportMemoryFdEXT(mem_obj, size, GL_HANDLE_TYPE_OPAQUE_FD_EXT, fd); > +if (glGetError() != GL_NO_ERROR) { > +error_report("spice: cannot import memory object

Re: [PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-04-27 Thread Dmitry Osipenko
On 4/27/25 14:53, 刘聪 wrote: > Hi Dmitry, > > The virglrender patch can fix the virgl issue, but the native context still > fails to run on my machine. > I'm not sure if anyone has successfully run it on an ARM64 machine before. Thanks for the testing! > When running with Venus, the virtual mach

Re: [PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-04-26 Thread Dmitry Osipenko
On 4/14/25 17:47, Dmitry Osipenko wrote: > On 4/11/25 04:42, 刘聪 wrote: >> >> >> >>> -Original Messages----- >>> From: "Dmitry Osipenko" >>> Send time:Friday, 04/11/2025 05:59:11 >>> To: "Cong Liu"

Re: [PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-04-14 Thread Dmitry Osipenko
On 4/11/25 04:42, 刘聪 wrote: > > > >> -Original Messages- >> From: "Dmitry Osipenko" >> Send time:Friday, 04/11/2025 05:59:11 >> To: "Cong Liu" >> Cc: jiqian.c...@amd.com, akihiko.od...@daynix.com, alex.ben...@linaro.o

Re: [PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-04-10 Thread Dmitry Osipenko
10.04.2025 12:54, Cong Liu пишет: > I discovered that on an ARM64 environment, the 'virtio-gpu: Support > asynchronous fencing' patch causes the virtual machine GUI to fail to > display. Rolling back this patch and using virgl allows the virtual machine > to start normally. When the VM screen is

Re: [PATCH v2 4/6] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-03-25 Thread Dmitry Osipenko
On 3/26/25 02:39, Vivek Kasireddy wrote: > +void surface_gl_create_texture_from_fd(DisplaySurface *surface, > + int fd, GLuint *texture) > +{ > +unsigned long size = surface_stride(surface) * surface_height(surface); > +GLuint mem_obj; > + > +if (!e

Re: [PATCH v11 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-03-15 Thread Dmitry Osipenko
On 3/10/25 15:25, Akihiko Odaki wrote: > On 2025/03/10 21:05, Dmitry Osipenko wrote: >> From: Alex Bennée >> >> This attempts to tidy up the VirtIO GPU documentation to make the list >> of requirements clearer. There are still a lot of moving parts and the >> di

[PATCH v10 00/10] Support virtio-gpu DRM native context

2025-03-12 Thread Dmitry Osipenko
gested by Akihiko Odaki. - Added patchew's dependecy tag to the cover letter as was suggested by Akihiko Odaki. Alex Bennée (1): docs/system: virtio-gpu: Document host/guest requirements Dmitry Osipenko (8): ui/sdl2: Restore original context after new context creation virtio-gpu

[PATCH v9 04/10] virtio-gpu: Support asynchronous fencing

2025-03-11 Thread Dmitry Osipenko
ontexts in virglrenderer. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 3 + hw/display/virtio-gpu-virgl.c | 147 +++-- include/hw/virtio/vi

[PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-03-11 Thread Dmitry Osipenko
ontexts in virglrenderer. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 3 + hw/display/virtio-gpu-virgl.c | 147 +++-- include/hw/virtio/vi

[PATCH v10 01/10] ui/sdl2: Restore original context after new context creation

2025-03-11 Thread Dmitry Osipenko
Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- ui/sdl2-gl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index e01d9ab0c7bf..b1fe96d6af22 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -168,6 +168,9 @@ QEMUGLContext sdl2_gl_create_

[PATCH v10 04/10] virtio-gpu: Support asynchronous fencing

2025-03-11 Thread Dmitry Osipenko
ontexts in virglrenderer. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 3 + hw/display/virtio-gpu-virgl.c | 147 +++-- include/hw/virtio/vi

[PATCH v10 02/10] ui/sdl2: Implement dpy dmabuf functions

2025-03-11 Thread Dmitry Osipenko
ael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Pierre-Eric Pelloux-Prayer Signed-off-by: Dmitry Osipenko --- include/ui/sdl2.h | 7 ++ meson.build | 6 ++--- ui/sdl2-gl.c | 64 +++ ui/sdl2.c | 42 +

[PATCH v9 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-03-11 Thread Dmitry Osipenko
Signed-off-by: Dmitry Osipenko [dmitry.osipe...@collabora.com: Extended and corrected doc] --- docs/system/devices/virtio-gpu.rst | 90 +- 1 file changed, 87 insertions(+), 3 deletions(-) diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/virtio

[PATCH v10 07/10] ui/gtk: Don't disable scanout when display is refreshed

2025-03-11 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v10 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc

2025-03-11 Thread Dmitry Osipenko
Extend virtio-gpu documentation with a link to the Mesa VirGL documentation. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/devices

[PATCH v11 05/10] virtio-gpu: Support DRM native context

2025-03-10 Thread Dmitry Osipenko
sults in a lightweight context implementations that yield better performance. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 11 +++ hw/display/virtio-gpu-gl.c | 2 ++ hw/display/

[PATCH v11 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-03-10 Thread Dmitry Osipenko
Signed-off-by: Dmitry Osipenko [dmitry.osipe...@collabora.com: Extended and corrected doc] --- docs/system/devices/virtio-gpu.rst | 101 - 1 file changed, 98 insertions(+), 3 deletions(-) diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/virtio

[PATCH v11 02/10] ui/sdl2: Implement dpy dmabuf functions

2025-03-10 Thread Dmitry Osipenko
ael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Pierre-Eric Pelloux-Prayer Signed-off-by: Dmitry Osipenko --- include/ui/sdl2.h | 7 ++ meson.build | 6 ++--- ui/sdl2-gl.c | 64 +++ ui/sdl2.c | 42 +

[PATCH v11 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc

2025-03-10 Thread Dmitry Osipenko
Extend virtio-gpu documentation with a link to the Mesa VirGL documentation. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/devices

[PATCH v11 07/10] ui/gtk: Don't disable scanout when display is refreshed

2025-03-10 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v11 06/10] ui/sdl2: Don't disable scanout when display is refreshed

2025-03-10 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v11 03/10] virtio-gpu: Handle virgl fence creation errors

2025-03-10 Thread Dmitry Osipenko
Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 13 - 1 file changed, 12

[PATCH v11 09/10] docs/system: virtio-gpu: Update Venus link

2025-03-10 Thread Dmitry Osipenko
Change virtio-gpu Venus link, pointing it at the Mesa Venus documentation instead of the protocol. The Mesa doc provides more information and also has a link to the protocol. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio

[PATCH v11 01/10] ui/sdl2: Restore original context after new context creation

2025-03-10 Thread Dmitry Osipenko
Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- ui/sdl2-gl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index e01d9ab0c7bf..b1fe96d6af22 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -168,6 +168,9 @@ QEMUGLContext sdl2_gl_create_

[PATCH v11 00/10] Support virtio-gpu DRM native context

2025-03-10 Thread Dmitry Osipenko
irgl_init() to fail with a error message if DRM context can't be initialized instead of giving a warning message, as was suggested by Akihiko Odaki. - Added patchew's dependecy tag to the cover letter as was suggested by Akihiko Odaki. Alex Bennée (1): docs/system:

Re: [PATCH v10 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-03-10 Thread Dmitry Osipenko
On 3/10/25 14:35, Akihiko Odaki wrote: > On 2025/03/10 20:12, Dmitry Osipenko wrote: >> From: Alex Bennée >> >> This attempts to tidy up the VirtIO GPU documentation to make the list >> of requirements clearer. There are still a lot of moving parts and the >> di

[PATCH v10 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-03-10 Thread Dmitry Osipenko
Signed-off-by: Dmitry Osipenko [dmitry.osipe...@collabora.com: Extended and corrected doc] --- docs/system/devices/virtio-gpu.rst | 94 +- 1 file changed, 91 insertions(+), 3 deletions(-) diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/virtio

[PATCH v10 09/10] docs/system: virtio-gpu: Update Venus link

2025-03-10 Thread Dmitry Osipenko
Change virtio-gpu Venus link, pointing it at the Mesa Venus documentation instead of the protocol. The Mesa doc provides more information and also has a link to the protocol. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio

[PATCH v10 05/10] virtio-gpu: Support DRM native context

2025-03-10 Thread Dmitry Osipenko
sults in a lightweight context implementations that yield better performance. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 11 +++ hw/display/virtio-gpu-gl.c | 2 ++ hw/display/

[PATCH v10 06/10] ui/sdl2: Don't disable scanout when display is refreshed

2025-03-10 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v10 03/10] virtio-gpu: Handle virgl fence creation errors

2025-03-10 Thread Dmitry Osipenko
Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 13 - 1 file changed, 12

[PATCH v9 01/10] ui/sdl2: Restore original context after new context creation

2025-03-09 Thread Dmitry Osipenko
Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- ui/sdl2-gl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index e01d9ab0c7bf..b1fe96d6af22 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -168,6 +168,9 @@ QEMUGLContext sdl2_gl_create_

[PATCH v9 02/10] ui/sdl2: Implement dpy dmabuf functions

2025-03-09 Thread Dmitry Osipenko
ael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Pierre-Eric Pelloux-Prayer Signed-off-by: Dmitry Osipenko --- include/ui/sdl2.h | 7 ++ meson.build | 6 ++--- ui/sdl2-gl.c | 64 +++ ui/sdl2.c | 42 +

[PATCH v9 07/10] ui/gtk: Don't disable scanout when display is refreshed

2025-03-09 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v9 09/10] docs/system: virtio-gpu: Update Venus link

2025-03-09 Thread Dmitry Osipenko
Change virtio-gpu Venus link, pointing it at the Mesa Venus documentation instead of the protocol. The Mesa doc provides more information and also has a link to the protocol. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio

[PATCH v9 05/10] virtio-gpu: Support DRM native context

2025-03-09 Thread Dmitry Osipenko
sults in a lightweight context implementations that yield better performance. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 11 +++ hw/display/virtio-gpu-gl.c | 2 ++ hw/display/

[PATCH v9 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc

2025-03-09 Thread Dmitry Osipenko
Extend virtio-gpu documentation with a link to the Mesa VirGL documentation. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/devices

[PATCH v9 06/10] ui/sdl2: Don't disable scanout when display is refreshed

2025-03-09 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v9 03/10] virtio-gpu: Handle virgl fence creation errors

2025-03-09 Thread Dmitry Osipenko
Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 13 - 1 file changed, 12

[PATCH v9 00/10] Support virtio-gpu DRM native context

2025-03-09 Thread Dmitry Osipenko
of giving a warning message, as was suggested by Akihiko Odaki. - Added patchew's dependecy tag to the cover letter as was suggested by Akihiko Odaki. Alex Bennée (1): docs/system: virtio-gpu: Document host/guest requirements Dmitry Osipenko (8): ui/sdl2: Restore

Re: [RFC PATCH] hw/display: add blocklist for known bad drivers

2025-02-23 Thread Dmitry Osipenko
On 2/21/25 19:01, Alex Bennée wrote: ... > diff --git a/stubs/host-gpu.c b/stubs/host-gpu.c > new file mode 100644 > index 00..7bf76ee4f6 > --- /dev/null > +++ b/stubs/host-gpu.c Looks okay Nit: host-gpu is a too generic name, IMO. Name should reflect Vulkan dedication, like host-vk-gpu.c

Re: [PATCH v5 8/8] docs/system: Expand the virtio-gpu documentation

2025-02-17 Thread Dmitry Osipenko
On 2/18/25 09:27, Dmitry Osipenko wrote: >> To be honest, I'm concerned that you may be using QEMU as a staging tree >> for Mesa/virglrenderer. Submitting a documentation to QEMU as a >> preparation to submit one to Mesa is not OK. >> >> You shouldn't su

Re: [PATCH v5 8/8] docs/system: Expand the virtio-gpu documentation

2025-02-17 Thread Dmitry Osipenko
On 2/13/25 07:32, Akihiko Odaki wrote: > On 2025/02/10 6:03, Dmitry Osipenko wrote: >> On 2/6/25 08:41, Akihiko Odaki wrote: >>> On 2025/02/06 2:40, Dmitry Osipenko wrote: >>>> On 2/3/25 08:31, Akihiko Odaki wrote: >>>> ... >>>>>> Req

Re: [PATCH v6 00/10] Support virtio-gpu DRM native context

2025-02-17 Thread Dmitry Osipenko
On 2/17/25 18:22, Alex Bennée wrote: ... >> This VK_KHR_display problem is only reproducible with your rootfs that >> you shared with me. It could be a trouble with your build configs or a >> buggy package version used by your rootfs build, more likely the >> former. > So you have built that latest

Re: [PATCH] ui/gtk-gl-area: Remove extra draw call in refresh

2025-02-14 Thread Dmitry Osipenko
On 2/14/25 18:26, Dmitry Osipenko wrote: > On 2/14/25 17:06, Alex Bennée wrote: >> dongwon@intel.com writes: >> >>> From: Dongwon Kim >>> >>> This partially reverts commit 77bf310084dad38b3a2badf01766c659056f1cf2 >>> which causes some guest

Re: [PATCH v8 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-02-14 Thread Dmitry Osipenko
On 2/13/25 07:47, Akihiko Odaki wrote: > On 2025/02/10 1:56, Dmitry Osipenko wrote: >> From: Alex Bennée >> >> This attempts to tidy up the VirtIO GPU documentation to make the list >> of requirements clearer. There are still a lot of moving parts and the >> di

Re: [PATCH v6 00/10] Support virtio-gpu DRM native context

2025-02-14 Thread Dmitry Osipenko
On 2/14/25 17:33, Alex Bennée wrote: > Dmitry Osipenko writes: > >> This patchset adds DRM native context support to VirtIO-GPU on Qemu. >> >> Contarary to Virgl and Venus contexts that mediates high level GFX APIs, >> DRM native context [1] mediates lower l

Re: [PATCH] ui/gtk-gl-area: Remove extra draw call in refresh

2025-02-14 Thread Dmitry Osipenko
g (e.g. Wayland Compositor) possibly due to >> simulataneous accesses on the guest frame buffer by host compositor >> and the guest. >> >> Reported-by: Dmitry Osipenko >> Reported-by: Alex Bennée >> Cc: Marc-André Lureau >> Cc: Vivek Kasireddy >&g

Re: [PATCH v6 00/10] Support virtio-gpu DRM native context

2025-02-11 Thread Dmitry Osipenko
On 2/6/25 01:13, Dmitry Osipenko wrote: > On 2/5/25 23:08, Dmitry Osipenko wrote: >>> Thanks for showing me the video. I will take a look and check what would go >>> wrong here. I kinda understand corruption may happen >>> in some scenario but I don't know wha

Re: [PATCH v5 8/8] docs/system: Expand the virtio-gpu documentation

2025-02-09 Thread Dmitry Osipenko
On 2/6/25 08:41, Akihiko Odaki wrote: > On 2025/02/06 2:40, Dmitry Osipenko wrote: >> On 2/3/25 08:31, Akihiko Odaki wrote: >> ... >>>> Requirements don't vary much. For example virglrenderer minigbm support >>>> is mandatory for crosvm, while for QEMU i

[PATCH v8 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-02-09 Thread Dmitry Osipenko
Signed-off-by: Dmitry Osipenko [dmitry.osipe...@collabora.com: Extended and corrected doc] --- docs/system/devices/virtio-gpu.rst | 106 - 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/docs/system/devices/virtio-gpu.rst b/docs/system/devices/virtio

[PATCH v8 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc

2025-02-09 Thread Dmitry Osipenko
Extend virtio-gpu documentation with a link to the Mesa VirGL documentation. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/devices

[PATCH v8 09/10] docs/system: virtio-gpu: Update Venus link

2025-02-09 Thread Dmitry Osipenko
Change virtio-gpu Venus link, pointing it at the Mesa Venus documentation instead of the protocol. The Mesa doc provides more information and also has a link to the protocol. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio

[PATCH v8 04/10] virtio-gpu: Support asynchronous fencing

2025-02-09 Thread Dmitry Osipenko
ontexts in virglrenderer. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 3 + hw/display/virtio-gpu-virgl.c | 147 +++-- include/hw/virtio/vi

[PATCH v8 06/10] ui/sdl2: Don't disable scanout when display is refreshed

2025-02-09 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v8 05/10] virtio-gpu: Support DRM native context

2025-02-09 Thread Dmitry Osipenko
sults in a lightweight context implementations that yield better performance. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 11 +++ hw/display/virtio-gpu-gl.c | 2 ++ hw/display/

[PATCH v8 07/10] ui/gtk: Don't disable scanout when display is refreshed

2025-02-09 Thread Dmitry Osipenko
vblank_mode=0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --

[PATCH v8 02/10] ui/sdl2: Implement dpy dmabuf functions

2025-02-09 Thread Dmitry Osipenko
ael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Pierre-Eric Pelloux-Prayer Signed-off-by: Dmitry Osipenko --- include/ui/sdl2.h | 7 ++ meson.build | 6 ++--- ui/sdl2-gl.c | 64 +++ ui/sdl2.c | 42 +

[PATCH v8 03/10] virtio-gpu: Handle virgl fence creation errors

2025-02-09 Thread Dmitry Osipenko
Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 13 - 1 file changed, 12

[PATCH v8 00/10] Support virtio-gpu DRM native context

2025-02-09 Thread Dmitry Osipenko
example and made virtio_gpu_virgl_init() to fail with a error message if DRM context can't be initialized instead of giving a warning message, as was suggested by Akihiko Odaki. - Added patchew's dependecy tag to the cover letter as was suggested by Akihiko Odaki.

[PATCH v8 01/10] ui/sdl2: Restore original context after new context creation

2025-02-09 Thread Dmitry Osipenko
Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- ui/sdl2-gl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index e01d9ab0c7bf..b1fe96d6af22 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -168,6 +168,9 @@ QEMUGLContext sdl2_gl_create_

Re: [PATCH v7 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-02-09 Thread Dmitry Osipenko
On 2/3/25 09:04, Akihiko Odaki wrote: > On 2025/02/03 8:21, Dmitry Osipenko wrote: >> From: Alex Bennée >> >> This attempts to tidy up the VirtIO GPU documentation to make the list >> of requirements clearer. There are still a lot of moving parts and the >> di

  1   2   3   4   5   6   7   >