[PATCH v2] hw/i386/pc_piix: Fix RTC ISA IRQ wiring of isapc machine

2025-05-26 Thread Bernhard Beschow
ves: https://gitlab.com/qemu-project/qemu/-/issues/2961 Fixes: 56b1f50e3c10 ("hw/i386/pc: Wire RTC ISA IRQs in south bridges") cc: qemu-stable Signed-off-by: Bernhard Beschow Reviewed-by: Mark Cave-Ayland --- v2: * add ISA_DEVICE() QOM cast as a safety check (Mark) --- hw/i386/pc_piix

Re: Using parallel port on the Pegasos 2

2025-05-26 Thread Bernhard Beschow
Am 25. Mai 2025 00:03:15 UTC schrieb BALATON Zoltan : >On Sun, 28 Jul 2024, BALATON Zoltan wrote: >> On Sun, 28 Jul 2024, quan wrote: >>> I am playing around with the parallel port on the pegasos 2 and I noticed >>> the following issue: >>> The parallel port on startup is set to iobase 0x378, th

[PATCH 3/3] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources

2025-05-23 Thread Bernhard Beschow
From: Bernhard Beschow Rather than accessing the attributes of TYPE_CCSR directly, use the SysBusDevice API which exists exactly for that purpose. Furthermore, registering the memory region with the SysBusDevice API makes it show up in QMP's `info qom-tree` command. Signed-off-by: Ber

Re: [PATCH] hw/i386/pc_piix: Fix RTC ISA IRQ wiring of isapc machine

2025-05-15 Thread Bernhard Beschow
Am 13. Mai 2025 09:02:56 UTC schrieb Mark Cave-Ayland : >On 12/05/2025 22:09, Bernhard Beschow wrote: > >> Commit 56b1f50e3c10 ("hw/i386/pc: Wire RTC ISA IRQs in south bridges") >> attempted to refactor RTC IRQ wiring which was previously done in >> pc_basic_

[PATCH] hw/i386/pc_piix: Fix RTC ISA IRQ wiring of isapc machine

2025-05-12 Thread Bernhard Beschow
ves: https://gitlab.com/qemu-project/qemu/-/issues/2961 Fixes: 56b1f50e3c10 ("hw/i386/pc: Wire RTC ISA IRQs in south bridges") cc: qemu-stable Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_pii

[PATCH] hw/i2c/imx_i2c: Always set interrupt status bit if interrupt condition occurs

2025-05-07 Thread Bernhard Beschow
ned-off-by: Bernhard Beschow --- hw/i2c/imx_i2c.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c index 91f84c2ad7..d26177c85d 100644 --- a/hw/i2c/imx_i2c.c +++ b/hw/i2c/imx_i2c.c @@ -79,13 +79,12 @@ static void imx_i2c_reset(D

Re: [PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread Bernhard Beschow
Am 1. Mai 2025 19:02:35 UTC schrieb "Philippe Mathieu-Daudé" : >On 1/5/25 20:34, Bernhard Beschow wrote: >> The DEFINE_TYPES() macro doesn't need the qemu/module.h include. >> >> Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types usin

Re: [PATCH-for-10.0? v2] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-05-01 Thread Bernhard Beschow
Am 23. April 2025 11:31:31 UTC schrieb "Philippe Mathieu-Daudé" : >Hi Thomas, > >On 23/4/25 11:40, Thomas Huth wrote: >> On 23/04/2025 11.31, Bernhard Beschow wrote: >>> >>> >>> Am 10. April 2025 06:05:35 UTC schrieb Thomas Hut

[PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread Bernhard Beschow
The DEFINE_TYPES() macro doesn't need the qemu/module.h include. Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro") Signed-off-by: Bernhard Beschow --- hw/pci-host/designware.c | 1 - 1 file changed, 1 deletion(-) diff --gi

[PATCH 2/3] hw/pci-host/designware: Fix viewport configuration

2025-05-01 Thread Bernhard Beschow
re: Use deposit/extract API") Signed-off-by: Bernhard Beschow --- hw/pci-host/designware.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index b4bff14579..f6e49ce9b8 100644 --- a/hw/pci-host/designware.c +++ b/hw/p

[PATCH 0/3] i.MX fixes

2025-05-01 Thread Bernhard Beschow
. Bernhard Beschow (3): hw/pci-host/designware: Remove unused include hw/pci-host/designware: Fix viewport configuration hw/gpio/imx_gpio: Fix interpretation of GDIR polarity hw/gpio/imx_gpio.c | 2 +- hw/pci-host/designware.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions

[PATCH 3/3] hw/gpio/imx_gpio: Fix interpretation of GDIR polarity

2025-05-01 Thread Bernhard Beschow
condition. Fix this by returning early when the bit is set. Fixes: f44272809779 ("i.MX: Add GPIO device") cc: qemu-stable Signed-off-by: Bernhard Beschow --- hw/gpio/imx_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gp

Re: [PATCH-for-10.0? v2] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-23 Thread Bernhard Beschow
Am 10. April 2025 06:05:35 UTC schrieb Thomas Huth : >On 09/04/2025 22.26, Bernhard Beschow wrote: >> Introduce a functional test which boots Debian 12 on the imx8mp-evk board. >> Since >> the root filesystem resides on an SD card, the test also verifies the basic >

Re: [PATCH v6 3/3] hw/ppc/e500: Add Freescale eSDHC to e500plat

2025-04-20 Thread Bernhard Beschow
t; firmware images to access SD cards. >>> >>> Signed-off-by: Bernhard Beschow >>> Message-Id: <20221018210146.193159-8-shen...@gmail.com> >>> [PMD: Simplify using create_unimplemented_device("esdhc")] >>> Signed-off-by: Philippe Mathieu-D

Re: [PATCH v2 1/3] hw/misc/aspeed_otp: Add Aspeed OTP memory device model

2025-04-17 Thread Bernhard Beschow
Am 17. April 2025 03:09:53 UTC schrieb Kane Chen via : >From: Kane-Chen-AS > >This introduces a new model for the ASPEED OTP (One-Time Programmable) >memory. The device is implemented as a `SysBusDevice` and provides an >abstracted interface for OTP read, write (program), and default value >ini

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-10 Thread Bernhard Beschow
/hcd-dwc3: Set erstba-hi-lo property > > hw/usb/hcd-dwc3.c | 1 + > hw/usb/hcd-xhci.c | 8 +++- > hw/usb/hcd-xhci.h | 1 + > 3 files changed, 9 insertions(+), 1 deletion(-) Series: Reviewed-by: Bernhard Beschow

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-10 Thread Bernhard Beschow
Am 11. April 2025 03:53:27 UTC schrieb Guenter Roeck : >On 4/8/25 14:56, Bernhard Beschow wrote: > >>>>> Tt turns out that sabrelite has the same problem. >>>> >>>> Did it work with QEMU 9.2? >>>> >>> >>> No, the pcie

[PATCH-for-10.0? v2] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-09 Thread Bernhard Beschow
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic operation of the USDHC. Signed-off-by: Bernhard Beschow -- v2: * Make test file executable (Thomas) * Omit fetch() (Thomas) * Omit "-

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-08 Thread Bernhard Beschow
Am 8. April 2025 20:31:58 UTC schrieb Guenter Roeck : >On 4/8/25 12:57, Bernhard Beschow wrote: >> >> >> Am 8. April 2025 16:09:58 UTC schrieb Guenter Roeck : >>> On 4/6/25 11:08, Bernhard Beschow wrote: >>> [ .. ] >>> >>>>>>

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-08 Thread Bernhard Beschow
Am 1. April 2025 10:51:06 UTC schrieb Bernhard Beschow : > > >Am 31. März 2025 09:53:41 UTC schrieb Paolo Bonzini : >>On 3/30/25 22:58, Bernhard Beschow wrote: >>> A qemu_log_mask!() macro is provided which expects similar arguments as the >>> C >>>

Re: [PATCH-for-10.0 0/3] More imx8mp-evk improvements

2025-04-08 Thread Bernhard Beschow
Am 8. April 2025 18:57:45 UTC schrieb "Philippe Mathieu-Daudé" : >On 5/4/25 23:48, Bernhard Beschow wrote: > >> Guenter Roeck (2): >>hw/arm/imx8mp-evk: Remove unimplemented cpu-idle-states properties >> from devicetree >>hw/arm/imx8mp-evk: R

Re: [PATCH preview 0/3] rust: update build system for Meson 1.8.0

2025-04-08 Thread Bernhard Beschow
Am 5. April 2025 10:06:00 UTC schrieb Paolo Bonzini : >Meson 1.7.0 and 1.8.0 include improved support for Rust, namely: >* support for "objects" in Rust executables >* support for doctest targets Using Meson 1.7.2 (shipped with my distro) I didn't succeed with either of these. If just applying

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-08 Thread Bernhard Beschow
Am 8. April 2025 16:09:58 UTC schrieb Guenter Roeck : >On 4/6/25 11:08, Bernhard Beschow wrote: >[ .. ] > >>>> Yeah, it works with Buildroot as described in the handbook. When I append >>>> `-netdev user,id=net0 -device virtio-net-pci,netdev=net0`

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-08 Thread Bernhard Beschow
/hcd-dwc3: Set erstba-hi-lo property > > hw/usb/hcd-dwc3.c | 1 + > hw/usb/hcd-xhci.c | 8 +++- > hw/usb/hcd-xhci.h | 1 + > 3 files changed, 9 insertions(+), 1 deletion(-) Series: Tested-by: Bernhard Beschow ... on imx8mp-evk board with 6.14 defconfig kernel. It indeed helps to get USB working with this kernel. Best regards, Bernhard

Re: [PATCH-for-10.0 1/3] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-08 Thread Bernhard Beschow
Am 7. April 2025 05:38:28 UTC schrieb Thomas Huth : > Hi! > >On 05/04/2025 23.48, Bernhard Beschow wrote: >> Introduce a functional test which boots Debian 12 on the imx8mp-evk board. >> Since >> the root filesystem resides on an SD card, the test also verifies th

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-06 Thread Bernhard Beschow
Am 6. April 2025 15:30:42 UTC schrieb Guenter Roeck : >On 4/6/25 04:03, Bernhard Beschow wrote: >> >> >> Am 6. April 2025 01:31:49 UTC schrieb Guenter Roeck : >>> On 4/5/25 12:28, Bernhard Beschow wrote: >>>> >>>> >>>> Am 5.

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-06 Thread Bernhard Beschow
Am 6. April 2025 01:31:49 UTC schrieb Guenter Roeck : >On 4/5/25 12:28, Bernhard Beschow wrote: >> >> >> Am 5. April 2025 17:26:14 UTC schrieb Guenter Roeck : >>> On 4/5/25 07:25, Philippe Mathieu-Daudé wrote: >>>> Hi Guenter, >>>> >&g

[PATCH-for-10.0 1/3] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-05 Thread Bernhard Beschow
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic operation of the USDHC. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 1 + tests/functional

[PATCH-for-10.0 0/3] More imx8mp-evk improvements

2025-04-05 Thread Bernhard Beschow
boot is resolved by also automatically removing an offending device node. Supersedes: 20250330094139.11948-1-shen...@gmail.com Bernhard Beschow (1): tests/functional: Add test for imx8mp-evk board with USDHC coverage Guenter Roeck (2): hw/arm/imx8mp-evk: Remove unimplemented cpu-idle-states

[PATCH-for-10.0 3/3] hw/arm/imx8mp-evk: Remove unimplemented nxp, imx8mp-fspi node from devicetree

2025-04-05 Thread Bernhard Beschow
From: Guenter Roeck The nxp,imx8mp-fspi node triggers a warning backtrace. Remove it from the devicetree file. Signed-off-by: Guenter Roeck Inspired-by: commit bf1da4b308 ("hw/arm/raspi4b: Temporarily disable unimplemented rpi4b devices") Signed-off-by: Bernhard Beschow [Bernhard: s

[PATCH-for-10.0 2/3] hw/arm/imx8mp-evk: Remove unimplemented cpu-idle-states properties from devicetree

2025-04-05 Thread Bernhard Beschow
From: Guenter Roeck The cpu-idle-states property causes a hard boot hang. Rather than documenting the workaround, perform the removal from the devicetree automatically. Signed-off-by: Guenter Roeck Signed-off-by: Bernhard Beschow [Bernhard: split patch, update documentation, adapt commit

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-05 Thread Bernhard Beschow
Am 5. April 2025 17:26:14 UTC schrieb Guenter Roeck : >On 4/5/25 07:25, Philippe Mathieu-Daudé wrote: >> Hi Guenter, >> >> On 5/4/25 16:00, Guenter Roeck wrote: >>> This series is needed to support the USB interface on imx8mp-evk when >>> booting the Linux kernel. >>> >>> According to the XHCI

[PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-05 Thread Bernhard Beschow
suffice for the current use case of Rust in QEMU. Signed-off-by: Bernhard Beschow --- docs/devel/rust.rst | 1 + rust/wrapper.h| 2 ++ rust/qemu-api/meson.build | 1 + rust/qemu-api/src/lib.rs | 1 + rust/qemu-api/src/log.rs | 55 +++ 5

Re: [PATCH 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-04-05 Thread Bernhard Beschow
Am 31. März 2025 09:18:05 UTC schrieb "Daniel P. Berrangé" : >On Sun, Mar 30, 2025 at 10:58:57PM +0200, Bernhard Beschow wrote: >> Now that there is logging support in Rust for QEMU, use it in the pl011 >> device. >> >> Signed-off-by: Bernhard Besch

Re: [PATCH 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-04-03 Thread Bernhard Beschow
Am 2. April 2025 13:27:53 UTC schrieb "Daniel P. Berrangé" : >On Wed, Apr 02, 2025 at 09:33:16AM +0000, Bernhard Beschow wrote: >> >> >> Am 31. März 2025 09:18:05 UTC schrieb "Daniel P. Berrangé" >> : >> >On Sun, Mar 30, 2025 at 10:58:

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-01 Thread Bernhard Beschow
Am 31. März 2025 09:53:41 UTC schrieb Paolo Bonzini : >On 3/30/25 22:58, Bernhard Beschow wrote: >> A qemu_log_mask!() macro is provided which expects similar arguments as the C >> version. However, the formatting works as one would expect from Rust. >> >> To maxim

[PATCH 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-03-30 Thread Bernhard Beschow
Now that there is logging support in Rust for QEMU, use it in the pl011 device. Signed-off-by: Bernhard Beschow --- rust/hw/char/pl011/src/device.rs | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src

[PATCH 0/2] Initial logging support for Rust

2025-03-30 Thread Bernhard Beschow
;t be silenced by users. Note that this is my first Rust contribution, so please check if the usage of `unsafe` is sound. Bernhard Beschow (2): rust/qemu-api: Add initial logging support based on C API rust/hw/char/pl011/src/device: Implement logging docs/devel/rust.rst | 1 +

Re: Plea for advice with PCIe on QEMU for iMX6 and plan to add FlexCAN controller support

2025-03-30 Thread Bernhard Beschow
Am 2. Oktober 2024 15:06:01 UTC schrieb Pavel Pisa : >Dear Nikita and other, > >my student Matyas Bobek has chosen to work >on QEMU CAN support in a frame of his study >final project. > >We have identified iMX6 FlexCAN as the next interesting >CAN controller for emulation. I'd be interested in

Re: [PATCH v3 0/3] i.MX 8M Plus EVK Fixes

2025-03-30 Thread Bernhard Beschow
Am 27. März 2025 16:19:32 UTC schrieb "Philippe Mathieu-Daudé" : > >> Bernhard Beschow (3): >>hw/arm/imx8mp-evk: Fix reference count of SoC object >>hw/arm/fsl-imx8mp: Derive struct FslImx8mpState from >> TYPE_SYS_BUS_DEVICE >>hw/arm

[PATCH] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-03-30 Thread Bernhard Beschow
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic operation of the USDHC. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 1 + tests/functional

Re: [PATCH-for-10.0 10/12] hw/rtc: Categorize and add description

2025-03-27 Thread Bernhard Beschow
Am 25. März 2025 22:43:08 UTC schrieb "Philippe Mathieu-Daudé" : >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/rtc/ds1338.c | 2 ++ > hw/rtc/m41t80.c | 2 ++ > hw/rtc/rs5c372.c | 2 ++ For rs5c372: Acked-by: Bernhard Beschow > 3 files changed, 6 insertio

Re: [PATCH v3 1/3] hw/arm/imx8mp-evk: Fix reference count of SoC object

2025-03-26 Thread Bernhard Beschow
Am 19. März 2025 18:06:14 UTC schrieb Peter Maydell : >On Tue, 18 Mar 2025 at 20:57, Bernhard Beschow wrote: >> >> TYPE_FSL_IMX8MP is created using object_new(), so must be realized with >> qdev_realize_and_unref() to keep the reference counting intact. >> >>

Re: [PATCH v2] tests/qtest: Unit test for pcf8563_rtc

2025-03-26 Thread Bernhard Beschow
Am 10. März 2025 11:36:35 UTC schrieb Ilya Chichkov : >Add a unit test for pcf8563_rtc module > >- Check default value after initialization >- Check set/get time >- Check minute alarm >- Check hour alarm >- Check day alarm >- Check wday alarm >- Check minute & hour alarm >- Check minute & day al

Re: [PATCH v2] hw/rtc: Add RTC PCF8563 module

2025-03-22 Thread Bernhard Beschow
Am 10. März 2025 11:36:34 UTC schrieb Ilya Chichkov : >Add PCF8563 a real-time clock with calendar and I2C interface. >This commit adds support for interfacing with it and implements >functionality of setting timer, alarm, reading and writing time. > >Signed-off-by: Ilya Chichkov >--- >v1->v2 >

Re: [PATCH v3 1/3] hw/arm/imx8mp-evk: Fix reference count of SoC object

2025-03-19 Thread Bernhard Beschow
Am 18. März 2025 20:57:07 UTC schrieb Bernhard Beschow : >TYPE_FSL_IMX8MP is created using object_new(), so must be realized with >qdev_realize_and_unref() to keep the reference counting intact. > Fixes: a4eefc69b237 "hw/arm: Add i.MX 8M Plus EVK board" >Signed-of

Re: [PATCH v2 1/2] hw/arm/fsl-imx8mp: Derive struct FslImx8mpState from TYPE_SYS_BUS_DEVICE

2025-03-19 Thread Bernhard Beschow
Am 18. März 2025 15:29:17 UTC schrieb Peter Maydell : >On Tue, 18 Mar 2025 at 15:27, Peter Maydell wrote: >> >> On Fri, 14 Mar 2025 at 18:32, Bernhard Beschow wrote: >> > >> > Deriving from TYPE_SYS_BUS_DEVICE fixes the SoC object to be reset upon >>

[PATCH v3 1/3] hw/arm/imx8mp-evk: Fix reference count of SoC object

2025-03-18 Thread Bernhard Beschow
TYPE_FSL_IMX8MP is created using object_new(), so must be realized with qdev_realize_and_unref() to keep the reference counting intact. Signed-off-by: Bernhard Beschow --- hw/arm/imx8mp-evk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/imx8mp-evk.c b/hw/arm/imx8mp

[PATCH v3 0/3] i.MX 8M Plus EVK Fixes

2025-03-18 Thread Bernhard Beschow
; (Zoltan, Peter) [1] https://lore.kernel.org/qemu-devel/1cdb6643-8fcc-4bd8-93fc-fcc93589c...@redhat.com/ Bernhard Beschow (3): hw/arm/imx8mp-evk: Fix reference count of SoC object hw/arm/fsl-imx8mp: Derive struct FslImx8mpState from TYPE_SYS_BUS_DEVICE hw/arm/fsl-imx8mp: Remove unused

[PATCH v3 3/3] hw/arm/fsl-imx8mp: Remove unused define

2025-03-18 Thread Bernhard Beschow
The SoC has three SPI controllers, not four. Remove the extra define of an SPI IRQ. Fixes: 06908a84f036 "hw/arm/fsl-imx8mp: Add SPI controllers" Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- include/hw/arm/fsl-imx8mp.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 2/3] hw/arm/fsl-imx8mp: Derive struct FslImx8mpState from TYPE_SYS_BUS_DEVICE

2025-03-18 Thread Bernhard Beschow
aydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- include/hw/arm/fsl-imx8mp.h | 3 ++- hw/arm/fsl-imx8mp.c | 2 +- hw/arm/imx8mp-evk.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/hw/ar

[PATCH v2 0/2] i.MX 8M Plus EVK Fixes

2025-03-15 Thread Bernhard Beschow
/1cdb6643-8fcc-4bd8-93fc-fcc93589c...@redhat.com/ Bernhard Beschow (2): hw/arm/fsl-imx8mp: Derive struct FslImx8mpState from TYPE_SYS_BUS_DEVICE hw/arm/fsl-imx8mp: Remove unused define include/hw/arm/fsl-imx8mp.h | 4 ++-- hw/arm/fsl-imx8mp.c | 2 +- hw/arm/imx8mp-evk.c | 2

[PATCH v2 1/2] hw/arm/fsl-imx8mp: Derive struct FslImx8mpState from TYPE_SYS_BUS_DEVICE

2025-03-14 Thread Bernhard Beschow
aydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Bernhard Beschow --- include/hw/arm/fsl-imx8mp.h | 3 ++- hw/arm/fsl-imx8mp.c | 2 +- hw/arm/imx8mp-evk.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/hw/arm/fsl-imx8mp.h b/include/hw/

[PATCH v2 2/2] hw/arm/fsl-imx8mp: Remove unused define

2025-03-14 Thread Bernhard Beschow
The SoC has three SPI controllers, not four. Remove the extra define of an SPI IRQ. Fixes: 06908a84f036 "hw/arm/fsl-imx8mp: Add SPI controllers" Signed-off-by: Bernhard Beschow --- include/hw/arm/fsl-imx8mp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/arm/fsl-

Re: [PATCH 1/2] hw/arm/fsl-imx8mp: Make SoC not user-creatable, derive from TYPE_SYS_BUS_DEVICE

2025-03-14 Thread Bernhard Beschow
Am 13. März 2025 10:12:18 UTC schrieb Peter Maydell : >On Wed, 12 Mar 2025 at 23:58, BALATON Zoltan wrote: >> >> On Wed, 12 Mar 2025, Bernhard Beschow wrote: >> > Fixes a crash when creating the SoC object on the command line: >> > >> > $ ./qemu-

[PATCH 0/2] i.MX 8M Plus EVK Fixes

2025-03-12 Thread Bernhard Beschow
/ Bernhard Beschow (2): hw/arm/fsl-imx8mp: Make SoC not user-creatable, derive from TYPE_SYS_BUS_DEVICE hw/arm/fsl-imx8mp: Remove unused define include/hw/arm/fsl-imx8mp.h | 4 ++-- hw/arm/fsl-imx8mp.c | 4 +++- hw/arm/imx8mp-evk.c | 2 +- 3 files changed, 6 insertions(+), 4

[PATCH 1/2] hw/arm/fsl-imx8mp: Make SoC not user-creatable, derive from TYPE_SYS_BUS_DEVICE

2025-03-12 Thread Bernhard Beschow
l Signed-off-by: Bernhard Beschow --- include/hw/arm/fsl-imx8mp.h | 3 ++- hw/arm/fsl-imx8mp.c | 4 +++- hw/arm/imx8mp-evk.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/include/hw/arm/fsl-imx8mp.h b/include/hw/arm/fsl-imx8mp.h index bc97fc416e..22fdc0d67c 1006

[PATCH 2/2] hw/arm/fsl-imx8mp: Remove unused define

2025-03-12 Thread Bernhard Beschow
The SoC has three SPI controllers, not four. Remove the extra define of an SPI IRQ. Fixes: 06908a84f036 "hw/arm/fsl-imx8mp: Add SPI controllers" Signed-off-by: Bernhard Beschow --- include/hw/arm/fsl-imx8mp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/arm/fsl-

Re: [PULL 31/43] hw/arm: Add i.MX 8M Plus EVK board

2025-03-12 Thread Bernhard Beschow
Am 12. März 2025 11:13:01 UTC schrieb Peter Maydell : >On Wed, 12 Mar 2025 at 10:44, Cédric Le Goater wrote: >> >> On 3/12/25 11:27, Philippe Mathieu-Daudé wrote: >> > + Cédric for Aspeed >> > >> > On 12/3/25 11:20, Peter Maydell wrote: >> >> The bug is that this is directly inheriting from TYP

Re: [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation

2025-03-11 Thread Bernhard Beschow
Am 7. März 2025 19:18:34 UTC schrieb Bernhard Beschow : > > >Am 4. März 2025 18:53:10 UTC schrieb Bernhard Beschow : >> >> >>Am 23. Februar 2025 11:47:08 UTC schrieb Bernhard Beschow : >>>The implementation just allows Linux to determine date and time. &g

Re: [PATCH v5 14/14] hw/sd/sdhci: Remove unnecessary 'endianness' property

2025-03-11 Thread Bernhard Beschow
ones. > >Remove the code related to SDHCIState::endianess field. > >Remove the now unused SDHCIState::io_ops field, since we >directly use the class one. > >Suggested-by: Bernhard Beschow >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/sd/sdhci-internal.h | 1

Re: [PATCH v5 14/14] hw/sd/sdhci: Remove unnecessary 'endianness' property

2025-03-10 Thread Bernhard Beschow
rent ones. >>>>> >>>>> Remove the code related to SDHCIState::endianess field. >>>>> >>>>> Remove the now unused SDHCIState::io_ops field, since we >>>>> directly use the class one. >&g

Re: [PATCH v4 02/14] hw/sd/sdhci: Remove need for SDHCIState::vendor field

2025-03-09 Thread Bernhard Beschow
/sdhci.c >@@ -1731,16 +1731,10 @@ usdhc_write(void *opaque, hwaddr offset, uint64_t val, >unsigned size) > > case USDHC_VENDOR_SPEC: > s->vendor_spec = value; >-switch (s->vendor) { >-case SDHCI_VENDOR_IMX: >-if (value & USDHC_IMX_FRC_SDCLK_ON) { >-s->prnsts &= ~SDHC_IMX_CLOCK_GATE_OFF; >-} else { >-s->prnsts |= SDHC_IMX_CLOCK_GATE_OFF; >-} >-break; >-default: >-break; >+if (value & USDHC_IMX_FRC_SDCLK_ON) { >+s->prnsts &= ~SDHC_IMX_CLOCK_GATE_OFF; >+} else { >+s->prnsts |= SDHC_IMX_CLOCK_GATE_OFF; > } > break; > Reviewed-by: Bernhard Beschow

Re: [PATCH v4 09/14] hw/sd/sdhci: Unify default MemoryRegionOps

2025-03-09 Thread Bernhard Beschow
Am 8. März 2025 21:36:35 UTC schrieb "Philippe Mathieu-Daudé" : >Note, sdhci_mmio_le_ops[] was missing .impl.access_size = 4. > >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/sd/sdhci.c | 46 -- > 1 file changed, 20 insertions(+), 26 deletions(-) >

Re: [PATCH] tests/functional: Require 'user' netdev for ppc64 e500 test

2025-03-09 Thread Bernhard Beschow
ser') > self.cpu = 'e5500' > > uimage_path = self.ASSET_BR2_E5500_UIMAGE.fetch() Thanks for taking care of it, Cédric. Acked-by: Bernhard Beschow

Re: [PATCH v4 14/14] hw/ppc/e500: Replace generic SDHCI by Freescale eSDHC

2025-03-09 Thread Bernhard Beschow
.c >@@ -1027,20 +1027,12 @@ void ppce500_init(MachineState *machine) > > /* eSDHC */ > if (pmc->has_esdhc) { >-dev = qdev_new(TYPE_UNIMPLEMENTED_DEVICE); "hw/misc/unimp.h" include is now unused and should therefore be removed. With that fix

Re: [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation

2025-03-07 Thread Bernhard Beschow
Am 4. März 2025 18:53:10 UTC schrieb Bernhard Beschow : > > >Am 23. Februar 2025 11:47:08 UTC schrieb Bernhard Beschow : >>The implementation just allows Linux to determine date and time. >> >>Signed-off-by: Bernhard Beschow >>--- >> MAINTAINERS

Re: [PATCH] target/i386: Improve 16-bit/real mode debug support in GDB

2025-03-07 Thread Bernhard Beschow
Am 21. Dezember 2024 05:45:49 UTC schrieb Davidson Francis : >Debugging 16-bit/real mode code in QEMU+GDB is challenging due to >incorrect architecture detection and segmented memory addressing issues. > >This patch improves the debugging experience by reporting i8086 >architecture to GDB when

Re: [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation

2025-03-04 Thread Bernhard Beschow
Am 23. Februar 2025 11:47:08 UTC schrieb Bernhard Beschow : >The implementation just allows Linux to determine date and time. > >Signed-off-by: Bernhard Beschow >--- > MAINTAINERS| 2 + > hw/rtc/rs5c372.c | 236 +

Re: [PATCH v2] hw/sd/sdhci: Set reset value of interrupt registers

2025-03-03 Thread Bernhard Beschow
Am 1. März 2025 16:02:05 UTC schrieb BALATON Zoltan : >On Mon, 10 Feb 2025, BALATON Zoltan wrote: >> The interrupt enable registers are not reset to 0 on Freescale eSDHC >> but some bits are enabled on reset. At least some U-Boot versions seem >> to expect this and not initialise these registers

Re: [PATCH] hw/ppc/e500: Partial implementation of local access window registers

2025-03-02 Thread Bernhard Beschow
Am 1. März 2025 16:10:35 UTC schrieb BALATON Zoltan : >On Wed, 15 Jan 2025, BALATON Zoltan wrote: >> This allows guests to set the CCSR base address. Also store and return >> values of the local access window registers but their functionality >> isn't implemented. > >Bernhard, Hi Zoltan, > >If

Re: [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category

2025-03-02 Thread Bernhard Beschow
dc->categories); > } > > static const TypeInfo etsec_types[] = { Reviewed-by: Bernhard Beschow

Re: [PATCH v2 04/18] hw/arm: Add i.MX 8M Plus EVK board

2025-02-26 Thread Bernhard Beschow
Am 25. Februar 2025 17:00:53 UTC schrieb Peter Maydell : >On Tue, 25 Feb 2025 at 15:42, Peter Maydell wrote: >> The C compiler for the OpenSUSE CI job doesn't seem to like this: >> https://gitlab.com/pm215/qemu/-/jobs/9239416833 >> >> ../hw/arm/fsl-imx8mp.c: In function ‘fsl_imx8mp_realize’: >

Re: [PATCH v2 04/18] hw/arm: Add i.MX 8M Plus EVK board

2025-02-25 Thread Bernhard Beschow
Am 25. Februar 2025 17:00:53 UTC schrieb Peter Maydell : >On Tue, 25 Feb 2025 at 15:42, Peter Maydell wrote: >> The C compiler for the OpenSUSE CI job doesn't seem to like this: >> https://gitlab.com/pm215/qemu/-/jobs/9239416833 >> >> ../hw/arm/fsl-imx8mp.c: In function ‘fsl_imx8mp_realize’: >

Re: [PATCH v2 00/18] Add i.MX 8M Plus EVK machine

2025-02-25 Thread Bernhard Beschow
Am 25. Februar 2025 14:43:32 UTC schrieb Peter Maydell : >On Sun, 23 Feb 2025 at 11:47, Bernhard Beschow wrote: >> >> This series adds a new aarch64 machine to QEMU: i.MX 8M Plus EVK [1]. It >> allows >> for running Linux distributions such as Buildroot >> (f

Re: [PATCH v2 16/18] hw/arm/fsl-imx8mp: Add boot ROM

2025-02-25 Thread Bernhard Beschow
Am 25. Februar 2025 14:29:15 UTC schrieb Peter Maydell : >On Sun, 23 Feb 2025 at 11:47, Bernhard Beschow wrote: >> >> On a real device, the boot ROM contains the very first instructions the CPU >> executes. Also, U-Boot calls into the ROM to determine the boot devic

Re: [PATCH 0/4] ppc/amigaone patches

2025-02-24 Thread Bernhard Beschow
Am 22. Februar 2025 17:52:27 UTC schrieb BALATON Zoltan : >Hello, > >This series adds NVRAM and support for -kernel, -initrd and -append >options to the amigaone machine. This makes it easier to boot AmigaOS >and avoids a crash in the guest when it tries to access NVRAM. Looks like the above in

Re: [PATCH v2 6/9] hw/char/imx_serial: Really use RX FIFO depth

2025-02-24 Thread Bernhard Beschow
char >at a time! > >Have the IOCanReadHandler handler return how many elements are >available, and use that in the IOReadHandler handler. > >Signed-off-by: Philippe Mathieu-Daudé >Reviewed-by: Luc Michel Tested-by: Bernhard Beschow >--- > hw/char/imx_serial.c | 8 ++-- > 1 fi

Re: [PATCH v2 04/18] hw/arm: Add i.MX 8M Plus EVK board

2025-02-23 Thread Bernhard Beschow
Am 10. Februar 2025 17:30:01 UTC schrieb Peter Maydell : >On Tue, 4 Feb 2025 at 09:21, Bernhard Beschow wrote: >> >> As a first step, implement the bare minimum: CPUs, RAM, interrupt controller, >> serial. All other devices of the A53 memory map are represented as >>

[PATCH v2 07/18] hw/arm/fsl-imx8mp: Add USDHC storage controllers

2025-02-23 Thread Bernhard Beschow
The USDHC emulation allows for running real-world images such as those generated by Buildroot. Convert the board documentation accordingly instead of running a Linux kernel with ephemeral storage. Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst

[PATCH v2 11/18] hw/arm/fsl-imx8mp: Add SPI controllers

2025-02-23 Thread Bernhard Beschow
Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl-imx8mp.h| 8 hw/arm/fsl-imx8mp.c| 26 ++ 3 files changed, 35 insertions(+) diff --git a/docs/system/arm/imx8mp-evk.rst b

[PATCH v2 15/18] hw/arm/fsl-imx8mp: Add USB support

2025-02-23 Thread Bernhard Beschow
Split the USB MMIO regions to better keep track of the implemented vs. unimplemented regions. Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl-imx8mp.h| 12 +++ hw/arm/fsl-imx8mp.c| 37

[PATCH v2 09/18] hw/arm/fsl-imx8mp: Add GPIO controllers

2025-02-23 Thread Bernhard Beschow
Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl-imx8mp.h| 14 + hw/arm/fsl-imx8mp.c| 55 ++ 3 files changed, 70 insertions(+) diff --git a/docs/system/arm/imx8mp

[PATCH v2 13/18] hw/arm/fsl-imx8mp: Implement general purpose timers

2025-02-23 Thread Bernhard Beschow
Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl-imx8mp.h| 11 +++ include/hw/timer/imx_gpt.h | 1 + hw/arm/fsl-imx8mp.c| 53 ++ hw/timer/imx_gpt.c | 25

[PATCH v2 14/18] hw/arm/fsl-imx8mp: Add Ethernet controller

2025-02-23 Thread Bernhard Beschow
The i.MX 8M Plus SoC actually has two ethernet controllers, the usual ENET one and a Designware one. There is no device model for the latter, so only add the ENET one. Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl

[PATCH v2 04/18] hw/arm: Add i.MX 8M Plus EVK board

2025-02-23 Thread Bernhard Beschow
. Signed-off-by: Bernhard Beschow --- MAINTAINERS| 9 + docs/system/arm/imx8mp-evk.rst | 54 + docs/system/target-arm.rst | 1 + include/hw/arm/fsl-imx8mp.h| 189 + hw/arm/fsl-imx8mp.c| 367 + hw/arm/imx8mp

[PATCH v2 02/18] hw/pci-host/designware: Prevent device attachment on internal PCIe root bus

2025-02-23 Thread Bernhard Beschow
: Peter Maydell Signed-off-by: Bernhard Beschow --- include/hw/pci-host/designware.h | 7 +++ hw/pci-host/designware.c | 18 +- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/include/hw/pci-host/designware.h b/include/hw/pci-host/designware.h index

[PATCH v2 17/18] hw/arm/fsl-imx8mp: Add on-chip RAM

2025-02-23 Thread Bernhard Beschow
Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- include/hw/arm/fsl-imx8mp.h | 1 + hw/arm/fsl-imx8mp.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/hw/arm/fsl-imx8mp.h b/include/hw/arm/fsl-imx8mp.h index 4dbe30f524..03f057c7db 100644 --- a

[PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation

2025-02-23 Thread Bernhard Beschow
The implementation just allows Linux to determine date and time. Signed-off-by: Bernhard Beschow --- MAINTAINERS| 2 + hw/rtc/rs5c372.c | 236 + tests/qtest/rs5c372-test.c | 43 +++ hw/rtc/Kconfig | 5 + hw/rtc

[PATCH v2 03/18] hw/gpio/pca955*: Move Kconfig switches next to implementations

2025-02-23 Thread Bernhard Beschow
The move of the Kconfig bits to hw/gpio is fixing a bug in 6328d8ffa6cb9d ("misc/pca955*: Move models under hw/gpio"), which moved the code but forgot to move the Kconfig sections. Fixes: 6328d8ffa6cb9d "misc/pca955*: Move models under hw/gpio" Signed-off-by: Bernhard B

[PATCH v2 08/18] hw/arm/fsl-imx8mp: Add PCIe support

2025-02-23 Thread Bernhard Beschow
Linux checks for the PLLs in the PHY to be locked, so implement a model emulating that. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 2 + docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl-imx8mp.h | 10 +++ include/hw/pci-host/fsl_imx8m_phy.h

[PATCH v2 00/18] Add i.MX 8M Plus EVK machine

2025-02-23 Thread Bernhard Beschow
(Zoltan) Instead, document Buildroot process in the first place and change it slightly. * Drop TCA6416 device model (Phil, Dmitrii) * Add pca955* Kconfig cleanup patch [1] https://www.nxp.com/design/design-center/development-boards-and-designs/8MPLUSLPD4-EVK [2] https://archlinuxarm.org/platforms

[PATCH v2 06/18] hw/arm/fsl-imx8mp: Add SNVS

2025-02-23 Thread Bernhard Beschow
SNVS contains an RTC which allows Linux to deal correctly with time. This is particularly useful when handling persistent storage which will be done in the next patch. Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl

[PATCH v2 12/18] hw/arm/fsl-imx8mp: Add watchdog support

2025-02-23 Thread Bernhard Beschow
Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl-imx8mp.h| 7 +++ hw/arm/fsl-imx8mp.c| 28 hw/arm/Kconfig | 1 + 4 files changed, 37 insertions(+) diff

[PATCH v2 10/18] hw/arm/fsl-imx8mp: Add I2C controllers

2025-02-23 Thread Bernhard Beschow
Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl-imx8mp.h| 11 +++ hw/arm/fsl-imx8mp.c| 29 + hw/arm/Kconfig | 2 ++ 4 files changed, 43 insertions

[PATCH v2 16/18] hw/arm/fsl-imx8mp: Add boot ROM

2025-02-23 Thread Bernhard Beschow
ementing a ROM later without touching the source code and even allows for users to provide their own ROMs. The imx8mp-boot.rom was created with `dd if=/dev/zero of=imx8mp-boot.rom bs=1 count=258048`. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 1 + include/hw/arm/fsl-imx8

[PATCH v2 05/18] hw/arm/fsl-imx8mp: Implement clock tree

2025-02-23 Thread Bernhard Beschow
Fixes quite a few stack traces during the Linux boot process. Also provides the clocks for devices added later, e.g. enet1. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 2 + docs/system/arm/imx8mp-evk.rst | 1 + include/hw/arm/fsl-imx8mp.h | 4 + include/hw

[PATCH v2 01/18] hw/usb/hcd-dwc3: Align global registers size with Linux

2025-02-23 Thread Bernhard Beschow
While at it add missing GUSB2RHBCTL register as found in i.MX 8M Plus reference manual. Reviewed-by: Peter Maydell Signed-off-by: Bernhard Beschow --- include/hw/usb/hcd-dwc3.h | 2 +- hw/usb/hcd-dwc3.c | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/hw

Re: [PATCH v2 16/18] hw/arm/fsl-imx8mp: Add boot ROM

2025-02-23 Thread Bernhard Beschow
Am 17. Februar 2025 22:48:23 UTC schrieb Bernhard Beschow : > > >Am 17. Februar 2025 13:28:42 UTC schrieb Peter Maydell >: >>On Tue, 4 Feb 2025 at 09:21, Bernhard Beschow wrote: >>> >>> On a real device, the boot ROM contains the very first instruction

Re: [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation

2025-02-23 Thread Bernhard Beschow
Am 10. Februar 2025 22:48:24 UTC schrieb Bernhard Beschow : > > >Am 10. Februar 2025 14:26:00 UTC schrieb "Philippe Mathieu-Daudé" >: >>On 6/2/25 22:58, Bernhard Beschow wrote: >>> >>> >>> Am 6. Februar 2025 17:32:31 UTC schrieb Peter Ma

  1   2   3   4   5   6   7   8   9   10   >