se the code in the .c and the .h file to GPL-v2-or-later,
> to make it compatible with the rest of QEMU.
>
> Signed-off-by: Peter Maydell
Signed-off-by: Artyom Tarasenko
> ---
> Before we can commit this to either head-of-git or any stable branch,
> we need a Signed-off-by: fr
On Wed, Aug 25, 2021 at 12:29 PM Philippe Mathieu-Daudé wrote:
>
> Fixes: 24f675cd3b ("sparc/sun4m: Use start-powered-off CPUState
> property")
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Philippe Mathieu-Daudé
>
> diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h
> index f
Daudé
>
For SPARC part:
Acked-by: Artyom Tarasenko
---
> I suppose X86_64 should also select I386?
> No clue about PPC/RISCV.
> ---
> meson.build | 3 ++-
> Kconfig | 1 +
> target/Kconfig| 23 +++
> target/
Nice, thanks for this!
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-by: Artyom Tarasenko
---
> hw/sparc64/sun4u.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
> index 0fa13a73302..fdf0aa875be
gt; if both the IRQ lines are high, and then one goes low, the PIC input will
> see
> this as a high-to-low transition even though the second IRQ line should
> still
> be holding it high).
>
> This kind of wiring needs an explicitly created OR gate; add one.
>
> Signed-off-by: M
Reported-by: Euler Robot
> Signed-off-by: Chen Qun
>
Reviewed-by: Artyom Tarasenko
---
> Cc: Mark Cave-Ayland
> Cc: Artyom Tarasenko
> ---
> target/sparc/win_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/sparc/win_helper.c b/targe
gt; compiler.
>
> Reported-by: Euler Robot
> Signed-off-by: Chen Qun
>
Reviewed-by: Artyom Tarasenko
---
> Cc: Mark Cave-Ayland
> Cc: Artyom Tarasenko
> ---
> target/sparc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Sun, Oct 4, 2020 at 8:25 PM Philippe Mathieu-Daudé wrote:
>
> These individual contributors have a number of contributions,
> add them to the 'individual' group map.
>
...
> +atar4q...@gmail.com
Acked-by: Artyom Tarasenko
Is this a regression? Can you please bisect to the first commit where it
happened?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1874504
Title:
VFIO passthrough spits out thousands of messages
Sta
On Fri, Oct 16, 2020 at 10:38 PM BALATON Zoltan wrote:
>
> On Fri, 16 Oct 2020, Mark Cave-Ayland wrote:
> > Signed-off-by: Mark Cave-Ayland
> > ---
> > hw/ppc/ppc405_boards.c | 10 +-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/pp
Hi Mark,
could you please pick it up?
Regards,
Artyom
сб, 19 сент. 2020 г., 20:47 Henrik Carlqvist :
> Just wanted to check that my patch hasn't been forgotten... I was hoping
> that
> it would make it into some branch in git.
>
> Do you want me to do any more changes to the patch or the descri
On Mon, Aug 3, 2020 at 8:36 PM Henrik Carlqvist wrote:
>
> Thanks for finding my typos!
:-)
> On Mon, 3 Aug 2020 20:16:43 +0200
> Artyom Tarasenko wrote:
>
> > > > On Fri, 10 Jul 2020 20:19:11 +0200
> > > > Henrik Carlqvist wrote:
> > > &
> >> +{"nl-be", 0x3c}, /* Belgium (Belgian5.kt) */
> >> +{"be",0x3c}, /* Belgium (Belgian5.kt) */
> >> +};
> >> +
> >> +for (i = 0;
> >> + i < sizeof(languages) / sizeof(struct layout_values);
> >> + i++) {
> >> +if (!strcmp(keyboard_layout, languages[i].lang)) {
> >> +ret = languages[i].dip;
> >> +return ret;
> >> +}
> >> +}
> >> +/* Found no known language code */
> >> +
> >> +if ((keyboard_layout[0] >= '0') && (keyboard_layout[0] <= '9')) {
> >> +unsigned int tmp;
> >> +/* As a fallback we also accept numeric dip switch value */
> >> +if (!qemu_strtoui(keyboard_layout, NULL, 0, &tmp)) {
> >> +ret = (unsigned char)tmp;
> >> +}
> >> +}
> >> +}
> >> +if (ret == 0xff) {
> >> +/* Final fallback if keyboard_layout was not set or recognized */
> >> +ret = 0x21; /* en-us layout */
> >> +}
> >> +return ret;
> >> +}
> >> +
> >> static void handle_kbd_command(ESCCChannelState *s, int val)
> >> {
> >> trace_escc_kbd_command(val);
> >> @@ -751,7 +823,7 @@ static void handle_kbd_command(ESCCChannelState *s, int
> >> val) case 0xf:
> >> clear_queue(s);
> >> put_queue(s, 0xfe);
> >> -put_queue(s, 0x21); /* en-us layout */
> >> +put_queue(s, sun_keyboard_layout_dip_switch());
> >> break;
> >> default:
> >> break;
> >> --
> >> 2.14.5
> >
Looks good otherwise. For the v2:
Reviewed-by: Artyom Tarasenko
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
Kconfig |8 +
> hw/char/Makefile.objs |1 +
> hw/char/escc2.c | 1135 +++
> hw/char/trace-events|6 +
> include/hw/char/escc2.h | 17 +
> 5 files changed, 1167 insertions(+)
> create mode 100644 hw/char/escc2.c
> create mode 100644 include/hw/char/escc2.h
>
> --
> 2.26.2
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
0800ff000/1000
>dev: grlib,irqmp, id ""
>
> Cc: Fabien Chouteau
> Cc: KONRAD Frederic
> Cc: Mark Cave-Ayland
> Cc: Artyom Tarasenko
> Signed-off-by: Markus Armbruster
> Reviewed-by: KONRAD Frederic
> Reviewed-by: Philippe Mathieu-Daudé
;
> > +sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, cpu_irqs[LEON3_UART_IRQ]);
> > +grlib_apb_pnp_add_entry(apb_pnp, LEON3_UART_OFFSET, 0xFFF,
> > + GRLIB_VENDOR_GAISLER, GRLIB_APBUART_DEV, 1,
> > +LEON3_UART_IRQ, GRLIB_APBIO_AREA);
> > }
> >
> > static void leon3_generic_machine_init(MachineClass *mc)
> >
>
> Reviewed-by: KONRAD Frederic
Acked-by: Artyom Tarasenko
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
On Mon, Jun 8, 2020 at 7:21 PM Philippe Mathieu-Daudé wrote:
>
> NIAGARA_UART_BASE is already defined few lines earlier.
>
> Signed-off-by: Philippe Mathieu-Daudé
Thanks!
Reviewed-by: Artyom Tarasenko
> ---
> hw/sparc64/niagara.c | 1 -
> 1 file changed, 1 deletion(-
On Mon, Jun 8, 2020 at 7:21 PM Philippe Mathieu-Daudé wrote:
>
> The UART is present on the machine regardless there is a
> character device connected to it. Map it unconditionally.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/
)
> >>>>>> KONRAD Frederic (maintainer:Leon3)
> >>>>>> qemu-devel@nongnu.org (open list:All patches CC here)
> >>>>>>
> >>>>>
> >>>>>> This is a bug but not 'security critical', so it migh
pproach to empty
> > slots fine?
>
> Thanks Aleksandar for looking at this series.
>
> I expect a neutral opinion from Peter.
>
> What would be helpful is feedback from Artyom, since it authored this
> device.
>
> Artyom, do you mind Acking the series?
Thanks for
On Sun, May 17, 2020 at 9:57 AM wrote:
>
> I've written up a basic implementation of the SAB 82532 ESCC2 device
> and have written a patch for OpenBIOS to add it to the device tree. I
> still have the 16550A UART acting as ttya to avoid having to write an
> OpenBIOS device driver.
Great progress!
gt;> > Well, theoretically yes, but practically there is just one baudrate
>> > which can be specified in the OBP. I think it's perfectly safe to use
>> > max(rxrate,txrate), or min(rxrate,txrate), whatever you prefer.
>>
>> I'll do this while look
ave++;
> >> env->canrestore--;
> >> #endif
> >> diff --git a/target/sparc/translate.c b/target/sparc/translate.c
> >> index 9416a551cf..1a4efd4ed6 100644
> >> --- a/target/sparc/translate.c
> >> +++ b/target/sparc/translate.c
> >> @@ -3663,6 +3663,8 @@ static void disas_sparc_insn(DisasContext * dc,
> >> unsigned int insn)
> >> #endif
> >> gen_store_gpr(dc, rd, cpu_tmp0);
> >> break;
> >> +#endif
> >> +#if defined(TARGET_SPARC64) || !defined(CONFIG_USER_ONLY)
> >> } else if (xop == 0x2b) { /* rdtbr / V9 flushw */
> >> #ifdef TARGET_SPARC64
> >> gen_helper_flushw(cpu_env);
> >>
> >
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
use the menu.
> > >
> > >
> > >
> > > The driver Solaris 10 is using for the device appears to be
> > > similar/same as
> > >
> > > /usr/src/uts/sun4/io/su_driver.c in the OpenSolaris code found at
> > > https://github.com/n
sion yet, but checked how it's done
in OFW. OFW did definitely work on via boards. Surprisingly OFW
Switches all IDE boards into native mode the same way:
my-space 9 + dup " config-b@" $call-parent
05 or swap " config-b!" $call-parent
HTH
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
ard
> > - - Less fixed hardware choices
> > - - DBRI audio (Am7930)
> > - - BPP parallel
> > - - Diagnostic switch
> > - - ESP PIO mode
> > -
> > -Sun4d:
> > -- A lot of unimplemented features:
> > - - SBI
> > - - IO-unit
> > -- M
he moment there is just a serial line which can probably be used
for ppp or slip, but I haven't tried it yet.
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
On Thu, Oct 24, 2019 at 4:10 PM Philippe Mathieu-Daudé
wrote:
>
> Hi Artyom,
>
> Do you mind Acking this patch?
Sorry for the late reply:
Reviewed-by: Artyom Tarasenko
>
> On 10/4/19 1:03 AM, Philippe Mathieu-Daudé wrote:
> > Move RTC devices under the hw/rtc/ subdir
t; > refactor, first drop the 'owner' argument from these 4 uses.
> >
> > $ git grep memory_region_allocate_system_memory hw/ | wc -l
> > 58
> >
> > Signed-off-by: Philippe Mathieu-Daudé
>
> Reviewed-by: Alistair Francis
Reviewed-by: Artyom Tarasenko
OFW I haven't found a way to the info from the
memory controller. I think it's not implemented. Or at least wasn't
back then.
And since I wanted to be compatible with the real hw, which doesn't
have a fw device, I just kept the hardcoded value in OFW.
If it's in the MC meanwhile, I can add the check to OFW as well.
> >>> +
> >>> +self.vm.launch()
> >>> +self.wait_for_console_pattern('>> OpenBIOS')
> >>> +self.wait_for_console_pattern('>> Memory: 192M')
> >>> +self.wait_for_console_pattern('>> CPU type PowerPC,604')
> >>> +
> >>
> >> On my testing, this is a very stable test, I'm only getting PASSes.
> >
> >
> > --
> > Alex Bennée
> >
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
rn(os_banner)
> >> > self.wait_for_console_pattern('Model: IBM PPS Model 6015')
> >> > +
> >> > +def test_openfirmware(self):
> >> > +"""
> >> > +:avocado: tags=arch:ppc
> >> > +:avocado: tags=m
ady has reviewed-by maintainer, so I don't suppose you'll need
it, but just in case,
Acked-by: Artyom Tarasenko
)
>
> User case from:
> http://mail-index.netbsd.org/port-prep/2017/04/11/msg000112.html
>
> Reviewed-by: Hervé Poussineau
> Signed-off-by: Philippe Mathieu-D
On Sun, Sep 15, 2019 at 11:19 PM Philippe Mathieu-Daudé wrote:
>
> User case from:
> https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html
>
> Signed-off-by: Philippe Mathieu-Daudé
Thanks a lot for this one, Philippe!
Acked-by: Artyom Tarasenko
> ---
&
On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote:
>
> These devices are not slots on a bus, but real devices that
> we do not implement.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/sparc/sun4m.c | 11 +++
out ECC don't trap when missing ram is accessed */
> -if (!hwdef->ecc_base) {
> -empty_slot_init(machine->ram_size, hwdef->max_mem -
> machine->ram_size);
> -}
>
> prom_init(hwdef->slavio_base, bios_name);
>
> @@ -1561,7 +1503,6 @@ static void sun4m_register_types(void)
> type_register_static(&idreg_info);
> type_register_static(&afx_info);
> type_register_static(&prom_info);
> -type_register_static(&ram_info);
>
> type_register_static(&ss5_type);
> type_register_static(&ss10_type);
> --
> 2.19.1
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote:
>
> Add a qdev 'size' property, check the size is not zero in the
> realize() function, simplify the empty_slot_init() logic.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
>
On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> include/hw/empty_slot.h| 7 ---
> include/hw/misc/empty_slot.h | 32
> hw
On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote:
>
> If few commits empty_slot_init() will take 'name' as argument.
> Meanwhile, initialize it as 'empty-slot'.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
&g
is accessed.
>
> The device is mapped at priority -1 to allow other devices
> to be mapped on top of it.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/misc/empty_slot.c | 6 +-
> 1 file changed, 5 insertions(+), 1 delet
On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote:
>
> The EmptySlot and UnimplementedDevice are very similar, the only
> difference is how they log guest accesses.
> Maintain them altogether.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasen
On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/misc/empty_slot.c | 19 ---
> hw/misc/trace-events | 4
> 2 files changed, 12 insertions(+), 11 deletions
On Tue, Jun 25, 2019 at 12:01 AM Philippe Mathieu-Daudé wrote:
>
> Use the slot name to have more meaningful tracing logs.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> include/hw/misc/empty_slot.h | 3 ++-
> hw/mips/mips_malta.c
On Mon, May 6, 2019 at 4:27 PM Mark Cave-Ayland
wrote:
>
> On 06/05/2019 09:42, Artyom Tarasenko wrote:
>
> > On Sun, May 5, 2019 at 12:43 PM Mark Cave-Ayland
> > wrote:
> >>
> >> On 04/05/2019 22:02, Artyom Tarasenko wrote:
> >>
> >>&g
On Sun, May 5, 2019 at 5:19 PM Philippe Mathieu-Daudé wrote:
>
> Hi Mark, Artyom.
>
> On 5/5/19 12:46 PM, Mark Cave-Ayland wrote:
> > On 04/05/2019 22:02, Artyom Tarasenko wrote:
> >
> >> AIX 5.1 expects the base year to be 1900. Adjust accordingly.
> >
On Sun, May 5, 2019 at 12:43 PM Mark Cave-Ayland
wrote:
>
> On 04/05/2019 22:02, Artyom Tarasenko wrote:
>
> > AIX/PReP does access to the aliased IO registers of 53810.
> > Implement aliasing to make the AIX driver work.
> >
> > Signed-off-by: Artyom Tarasenko
AIX 5.1 expects the base year to be 1900. Adjust accordingly.
Signed-off-by: Artyom Tarasenko
Reviewed-by: Hervé Poussineau
---
hw/isa/i82378.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
index a5d67bc..546c928 100644
--- a/hw/isa
This series makes various fixes for the -M 40p target.
Particularly now it's possible to boot AIX 5.1 (both from a cdrom
and a hard disk).
The OFW image:
https://github.com/artyom-tarasenko/openfirmware/releases/download/20190406-AIX-boots/q40pofw-serial.rom
The command line:
qemu-syste
AIX/PReP does access to the aliased IO registers of 53810.
Implement aliasing to make the AIX driver work.
Signed-off-by: Artyom Tarasenko
---
hw/scsi/lsi53c895a.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
Signed-off-by: Artyom Tarasenko
Reviewed-by: Hervé Poussineau
---
hw/pci-host/prep.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
index 8b9e1fd..94b7465 100644
--- a/hw/pci-host/prep.c
+++ b/hw/pci-host/prep.c
On Mon, Apr 15, 2019 at 12:36 PM Philippe Mathieu-Daudé
wrote:
>
> On 4/14/19 11:24 PM, Hervé Poussineau wrote:
> > Le 14/04/2019 à 20:53, Artyom Tarasenko a écrit :
> >> On Sun, Apr 14, 2019 at 7:01 PM Hervé Poussineau
> >> wrote:
> >>>
> >&g
On Sun, Apr 14, 2019 at 7:01 PM Hervé Poussineau wrote:
>
> Le 12/04/2019 à 23:06, Artyom Tarasenko a écrit :
> > AIX 5.1 expects the base year to be 1900. Adjust accordingly.
> >
> > Signed-off-by: Artyom Tarasenko
> > ---
> > hw/isa/i82378.c | 4 +++-
>
On Sun, Apr 14, 2019 at 5:43 PM Hervé Poussineau wrote:
>
> Le 12/04/2019 à 23:06, Artyom Tarasenko a écrit :
> > AIX/PReP does access to the aliased IO registers of 53810.
> > Implement aliasing to make the AIX driver work.
> >
> > Signed-off-by: Artyom Ta
AIX 5.1 expects the base year to be 1900. Adjust accordingly.
Signed-off-by: Artyom Tarasenko
---
hw/isa/i82378.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
index a5d67bc..546c928 100644
--- a/hw/isa/i82378.c
+++ b/hw/isa/i82378.c
Performing a complete flush is ~ 100 times faster than flushing
256MiB of 4KiB pages. Set a limit of 1024 pages and perform a complete
flush afterwards.
This patch significantly speeds up AIX 5.1 and NetBSD-ofppc.
Signed-off-by: Artyom Tarasenko
---
target/ppc/mmu_helper.c | 7 +++
1 file
Signed-off-by: Artyom Tarasenko
---
hw/pci-host/prep.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
index 8b9e1fd..94b7465 100644
--- a/hw/pci-host/prep.c
+++ b/hw/pci-host/prep.c
@@ -62,6 +62,7 @@ typedef struct
AIX/PReP does access to the aliased IO registers of 53810.
Implement aliasing to make the AIX driver work.
Signed-off-by: Artyom Tarasenko
---
hw/scsi/lsi53c895a.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi
This series makes various fixes for the -M 40p target.
Particularly now it's possible to boot AIX 5.1 (both from a cdrom
and a hard disk).
The OFW image:
https://github.com/artyom-tarasenko/openfirmware/releases/download/20190406-AIX-boots/q40pofw-serial.rom
The command line:
qemu-system-p
ARA_IOBSIZE);
> > sun4v_rtc_init(NIAGARA_RTC_BASE);
> > }
>
> Is this actually an unimplemented (missing) device, or are we
> implementing hardware-defined "no bus errors when this range is
> touched" behaviour ?
In this case it's really an unimplemented
On Tue, Oct 2, 2018 at 12:10 AM Philippe Mathieu-Daudé wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/timer/sun4v-rtc.c | 13 +++--
> hw/timer/trace-events | 4
> 2 files changed, 7 insertions(+), 10 deletions(-)
&
create_unimplemented_device("dbri.prom", hwdef->dbri_base + 0x1000,
> +0x30);
> /* reg space */
> -empty_slot_init(hwdef->dbri_base+0x1, 0x100);
> +create_unimplemented_device("dbri", hwdef->dbri_base + 0x1,
> 0x100);
> }
>
> if (hwdef->bpp_base) {
> /* parallel port */
> -empty_slot_init(hwdef->bpp_base, 0x20);
> +create_unimplemented_device("bpp", hwdef->bpp_base, 0x20);
> }
>
> kernel_size = sun4m_load_kernel(machine->kernel_filename,
> --
> 2.19.0
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
On Thu, Sep 13, 2018 at 5:30 PM Mark Cave-Ayland
wrote:
>
> On 13/09/18 15:21, Artyom Tarasenko wrote:
>
> > On Sat, Sep 8, 2018 at 11:11 AM Mark Cave-Ayland
> > wrote:
> >>
> >> Whilst the PReP specification describes how all PCI IRQs are routed via IRQ
&
v);
>
> -dev = DEVICE(pci_create_simple(pci_bus, PCI_DEVFN(1, 0),
> - "lsi53c810"));
> -lsi53c8xx_handle_legacy_cmdline(dev);
> +pci = PCI_DEVICE(pci_create_simple(pci_bus, PCI_DEVFN(1, 0),
> + "lsi53c810"));
> +/* Interrupt pin C for fixed LSI SCSI IRQ routing */
> +pci->config[PCI_INTERRUPT_PIN] = 0x3;
> +lsi53c8xx_handle_legacy_cmdline(DEVICE(pci));
>
> /* XXX: s3-trio at PCI_DEVFN(2, 0) */
> pci_vga_init(pci_bus);
> --
> 2.11.0
>
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
.write = power_mem_write,
> .endianness = DEVICE_NATIVE_ENDIAN,
> .valid = {
> --
> 2.17.1
>
>
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
On Sat, Aug 18, 2018 at 8:56 PM Donald R Laster Jr
<1787...@bugs.launchpad.net> wrote:
>
> Public bug reported:
>
> The output for the "-cpu help" on the Sparc executables is not
> generating accurate information.
>
> Running
>
> ./qemu-sparc64 -cpu help
>
> produces:
>
> Sparc Fujitsu Sparc64 IU
t; *initrd_size = 0;
> -if (initrd_filename) {
> +if (initrd_filename && kernel_top) {
> *initrd_addr = TARGET_PAGE_ALIGN(kernel_top);
>
> *initrd_size = load_image_targphys(initrd_filename,
>
>
Looks good to me.
Acked-by: Artyom Tarasenko
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
7;s really good to have icount support for SPARC64. Good job, Mark!
Acked-by: Artyom Tarasenko
> ---
> target/sparc/translate.c | 111
> ++-
> 1 file changed, 110 insertions(+), 1 deletion(-)
>
> diff --git a/target/sparc/trans
_init_ram_nomigrate(&s->prom, obj, "sun4u.prom",
>> PROM_SIZE_MAX,
>> - &error_fatal);
>> vmstate_register_ram_global(&s->prom);
>> memory_region_set_readonly(&s->prom, true);
>> sysbus_init_mmio(
};
>>
>> #define TYPE_OPENPROM "openprom"
>> @@ -680,13 +707,19 @@ static void prom_init(hwaddr addr, const char
>> *bios_name)
>> }
>> }
>>
>> -static void prom_init1(Object *obj)
>> +static void prom_realize(DeviceState *ds, Error **errp)
>> {
>> -PROMState *s = OPENPROM(obj);
>> -SysBusDevice *dev = SYS_BUS_DEVICE(obj);
>> +PROMState *s = OPENPROM(ds);
>> +SysBusDevice *dev = SYS_BUS_DEVICE(ds);
>> +Error *local_err = NULL;
>> +
>> +memory_region_init_ram_nomigrate(&s->prom, OBJECT(ds), "sun4m.prom",
>> + PROM_SIZE_MAX, &local_err);
>> +if (local_err) {
>> +error_propagate(errp, local_err);
>> +return;
>> +}
>>
>> -memory_region_init_ram_nomigrate(&s->prom, obj, "sun4m.prom",
>> PROM_SIZE_MAX,
>> - &error_fatal);
>> vmstate_register_ram_global(&s->prom);
>> memory_region_set_readonly(&s->prom, true);
>> sysbus_init_mmio(dev, &s->prom);
>> @@ -701,6 +734,7 @@ static void prom_class_init(ObjectClass *klass, void
>> *data)
>> DeviceClass *dc = DEVICE_CLASS(klass);
>>
>> dc->props = prom_properties;
>> +dc->realize = prom_realize;
>> }
>>
>> static const TypeInfo prom_info = {
>> @@ -708,7 +742,6 @@ static const TypeInfo prom_info = {
>> .parent= TYPE_SYS_BUS_DEVICE,
>> .instance_size = sizeof(PROMState),
>> .class_init= prom_class_init,
>> -.instance_init = prom_init1,
>> };
>>
>> #define TYPE_SUN4M_MEMORY "memory"
>>
>
> Ping!
Acked-by: Artyom Tarasenko
Mark, can you please pick it in your tree?
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
;>>smbus_eeprom_init(smbus, 8, smbus_eeprom_buf, smbus_eeprom_size);
>>>> g_free(smbus_eeprom_buf);
>>>>pit = i8254_pit_init(isa_bus, 0x40, 0, NULL);
>>>> -DMA_init(isa_bus, 0);
>>>> +i8257_dma_init(isa_bus, 0);
>>>> /* Super I/O */
>>>>isa_create_simple(isa_bus, "i8042");
>>>> diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
>>>> index 0f5804b3b4..fa1bfd6c92 100644
>>>> --- a/hw/sparc/sun4m.c
>>>> +++ b/hw/sparc/sun4m.c
>>>> @@ -99,10 +99,6 @@ struct sun4m_hwdef {
>>>>uint8_t nvram_machine_id;
>>>>};
>>>>-void DMA_init(ISABus *bus, int high_page_enable)
>>>> -{
>>>> -}
>>>> -
>>>>static void fw_cfg_boot_set(void *opaque, const char *boot_device,
>>>>Error **errp)
>>>>{
>>>> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
>>>> index ceb1ba7eaf..0ca0243821 100644
>>>> --- a/hw/sparc64/sun4u.c
>>>> +++ b/hw/sparc64/sun4u.c
>>>> @@ -90,10 +90,6 @@ typedef struct EbusState {
>>>>#define TYPE_EBUS "ebus"
>>>>#define EBUS(obj) OBJECT_CHECK(EbusState, (obj), TYPE_EBUS)
>>>>-void DMA_init(ISABus *bus, int high_page_enable)
>>>> -{
>>>> -}
>>>> -
>>>>static void fw_cfg_boot_set(void *opaque, const char *boot_device,
>>>>Error **errp)
>>>>{
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index c0f1620f3a..335c6c9f65 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -929,8 +929,8 @@ F: hw/timer/mc146818rtc*
>>>>F: hw/watchdog/wdt_ib700.c
>>>>F: include/hw/display/vga.h
>>>>F: include/hw/char/parallel.h
>>>> +F: include/hw/dma/i8257.h
>>>>F: include/hw/i2c/pm_smbus.h
>>>> -F: include/hw/isa/i8257.h
>>>>F: include/hw/timer/hpet.h
>>>>F: include/hw/timer/i8254*
>>>>F: include/hw/timer/mc146818rtc*
>>>>
>>>
>>> Presumably these DMA_init() functions have been unused on sun4u/sun4m
>>> for a while which is why they are being removed? Might be worth a
>>> mention of this in the commit message.
>>
>>
>> Apparently (from git log) once the Sparc machine was copied from the PC
>> machine (~ 6f7e9aec5), using an empty stub, and finally got cleaned in
>> ba0a71022 but this function was missed. So this function has never been
>> implemented.
>>
>> I'll add a comment if I need to respin, or gently add the maintainer to
>> update the commit message if this series is accepted :)
>>
>> Thanks!
>>
>> Phil.
>
>
> Got it. In that case for sun4/sun4u:
>
> Reviewed-by: Mark Cave-Ayland
Out of curiosity, isn't ISA-DMA used by FDthree on Ultra-5/Ultra-10 machines?
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
10 with the conversion to tracepoints.
>>
>>
>> This can be avoided moving patch #8 after #10, although not worthy IMHO.
>
>
> Thanks once again for the review. It was quite a tricky patchset to order in
> the end because of the rename, and there wasn't really one ordering which I
> found completely satisfactory.
>
> Given that you're generally happy with the patches, I'm inclined to keep the
> patchset in its current form, pending any further comments from Artyom.
>
The whole series does look good to me. The new naming conventions are
really a lot cleaner than what we used to have. Well done!
Acked-by: Artyom Tarasenko
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
r now. The guests should get the
info from the device tree.
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/sparc64/sun4u.c | 64
> +-
> 1 file changed, 63 insertions(+), 1 deletion(-)
>
> diff --
On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland
wrote:
> This belongs in the PCI-ISA bridge rather than at the machine level.
>
> Signed-off-by: Mark Cave-Ayland
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/sp
On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland
wrote:
> This is a first step towards removing pci_apb_init() completely.
>
> Signed-off-by: Mark Cave-Ayland
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/pci-host/apb.c | 8
On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland
wrote:
> Signed-off-by: Mark Cave-Ayland
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/pci-host/apb.c | 6 ++
> hw/sparc64/sparc64.c | 2 ++
> hw/sparc64/su
On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland
wrote:
> Signed-off-by: Mark Cave-Ayland
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/sparc64/sun4u.c | 12 ++--
> hw/sparc64/trace-events | 3 +++
> 2 files changed, 5
On Thu, Dec 21, 2017 at 9:20 AM, Mark Cave-Ayland
wrote:
> After the previous refactoring it is now possible to use separate functions
> to improve the clarity of the interrupt paths.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/p
an now manually update the PCI configuration for bridge A in
> pci_pbm_reset() and thus completely remove the busA property from the
> PBMPCIBridge state.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/pci-host/apb.c | 29 +-
On Tue, Dec 19, 2017 at 10:27 AM, Mark Cave-Ayland
wrote:
> On 19/12/17 07:56, Artyom Tarasenko wrote:
>>
>> On Sun, Dec 17, 2017 at 12:09 PM, Mark Cave-Ayland
>> wrote:
>>>
>>> On 19/11/17 11:06, Mark Cave-Ayland wrote:
>>>
>>>> On 17
in
> a conversion from DPRINTF macros to trace-events for good measure while
> we are here.
>
> Signed-off-by: Mark Cave-Ayland
Acked-by: Artyom Tarasenko
> Based-on: 1511699686-12605-1-git-send-email-mark.cave-ayl...@ilande.co.uk
> ([PATCHv2 00/15] sun4u: tidy-up CPU, APB and e
On Sun, Dec 17, 2017 at 12:09 PM, Mark Cave-Ayland
wrote:
> On 19/11/17 11:06, Mark Cave-Ayland wrote:
>
>> On 17/11/17 14:33, Artyom Tarasenko wrote:
>>
>>> On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland
>>> wrote:
>>>>
>>>> After
On Fri, Nov 17, 2017 at 4:46 PM, Mark Cave-Ayland
wrote:
> On 17/11/17 14:53, Artyom Tarasenko wrote:
>
>> On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland
>> wrote:
>>> Since the EBus is effectively a PCI-ISA bridge then the underlying ISA bus
>>> shoul
On Fri, Nov 17, 2017 at 4:40 PM, Mark Cave-Ayland
wrote:
> On 17/11/17 14:24, Artyom Tarasenko wrote:
>
>> Hi Mark,
>>
>> On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland
>> wrote:
>>> This also includes the related IOMMUState typedef and defines.
{
> +error_setg(errp, "unable to instantiate EBUS ISA bus");
> return;
> }
>
> --
> 1.7.10.4
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland
wrote:
> This enables us to remove these parameters from pci_apb_init().
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/pci-host/apb.c | 14 +-
> hw/sparc64/sun
using standard qdev
> create/init functions in sun4u.c.
Nice!
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/pci-host/apb.c | 123
> ++---
> hw/sparc64/sun4u.c|6 ++-
> include
; to them by looking up the APB device during ebus realize.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/pci-host/apb.c |4 +---
> hw/sparc64/sun4u.c| 29 ++---
> include/hw/pci-host/apb.h |3 +--
>
On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland
wrote:
> This is in preparation for switching code in hw/sparc64 from DPRINTF over to
> trace events.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> Makefile.objs |1 +
> hw/sparc6
gt; }
>
> static const TypeInfo pbm_pci_bridge_info = {
> diff --git a/include/hw/pci-host/apb.h b/include/hw/pci-host/apb.h
> index f0074f7..dd49437 100644
> --- a/include/hw/pci-host/apb.h
> +++ b/include/hw/pci-host/apb.h
> @@ -86,9 +86,6 @@ typedef struct APBState {
> typedef struct PBMPCIBridge {
> /*< private >*/
> PCIBridge parent_obj;
> -
> -/* Is this busA with in-built devices (ebus)? */
> -bool busA;
> } PBMPCIBridge;
>
> #define TYPE_PBM_PCI_BRIDGE "pbm-bridge"
> --
> 1.7.10.4
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
OBIO interrupt numbers with constants
> designating the interrupt source, and rename isa_irq_handler() to
> ebus_isa_irq_handler().
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/pci-host/apb.c |2 +-
&g
On Fri, Nov 17, 2017 at 2:42 PM, Mark Cave-Ayland
wrote:
> Following on from the previous commit, we can also do the same with
> with legacy OBIO interrupts in pci_pbmA_map_irq().
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/pci-host/ap
+uint64_t pci_irq_in;
> +IOMMUState iommu;
> +uint32_t pci_control[16];
> +uint32_t pci_irq_map[8];
> +uint32_t pci_err_irq_map[4];
> +uint32_t obio_irq_map[32];
> +qemu_irq *pbm_irqs;
> +qemu_irq *ivec_irqs;
> +unsigned int irq_request;
> +uint32_t reset_control;
> +unsigned int nr_resets;
> +} APBState;
> +
> +typedef struct PBMPCIBridge {
> +/*< private >*/
> +PCIBridge parent_obj;
> +
> +/* Is this busA with in-built devices (ebus)? */
> +bool busA;
> +} PBMPCIBridge;
> +
> +#define TYPE_PBM_PCI_BRIDGE "pbm-bridge"
> +#define PBM_PCI_BRIDGE(obj) \
> +OBJECT_CHECK(PBMPCIBridge, (obj), TYPE_PBM_PCI_BRIDGE)
>
> PCIBus *pci_apb_init(hwaddr special_base,
> hwaddr mem_base,
> --
> 1.7.10.4
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
t it is now possible to remove both the iommu_opaque
> and is_ledma workarounds from the code, and the code for wiring up
> the espdma/ledma and respective devices is also a lot more readable.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
>
> v4:
> - Reb
t it is now possible to remove both the iommu_opaque
> and is_ledma workarounds from the code, and the code for wiring up
> the espdma/ledma and respective devices is also a lot more readable.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
>
> v3:
> - Add m
same except omitting the realize as originally intended.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
> ---
> hw/sparc64/sun4u.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.
MAINTAINERS b/MAINTAINERS
>> index 18ddaf4070..3938ccbf8a 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -778,7 +778,7 @@ F: pc-bios/openbios-sparc64
>> Sun4v
>> M: Artyom Tarasenko
>> S: Maintained
>> -F: hw/sparc64/sun4v.
8df47..731c5c7ec2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -778,7 +778,6 @@ F: pc-bios/openbios-sparc64
>> Sun4v
>> M: Artyom Tarasenko
>> S: Maintained
>> -F: hw/sparc64/sun4v.c
>
> I guess you should rather replace that one with:
>
t it is now possible to remove both the iommu_opaque
> and is_ledma workarounds from the code.
>
> Signed-off-by: Mark Cave-Ayland
Reviewed-by: Artyom Tarasenko
>
> Mark Cave-Ayland (8):
> sparc32_dma: rename SPARC32_DMA type to SPARC32_DMA_DEVICE
> sparc32_dma: s
On Thu, Oct 5, 2017 at 3:51 PM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> CC: mark.cave-ayl...@ilande.co.uk
> CC: atar4q...@gmail.com
> CC:
On Thu, Oct 5, 2017 at 3:51 PM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> CC: mark.cave-ayl...@ilande.co.uk
> CC: atar4q...@gmail.com
> ---
>
On Thu, Oct 5, 2017 at 3:51 PM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> CC: mark.cave-ayl...@ilande.co.uk
> CC: atar4q...@gmail.com
> ---
> include/hw/sparc/sparc64.h | 3 +--
&g
1 - 100 of 701 matches
Mail list logo
