David Gibson writes:
> On Mon, Mar 14, 2022 at 07:10:10PM -0300, Fabiano Rosas wrote:
>> David Gibson writes:
>>
>> > On Tue, Mar 08, 2022 at 10:23:59PM -0300, Fabiano Rosas wrote:
>>
...
>> To satisfy TCG we could keep a spapr capability as ON and usually the
>> guest would pass cap-gtse=off
Daniel Henrique Barboza writes:
> On 11/5/21 10:51, Nicholas Piggin wrote:
>> A configuration that specifies multiple nodes without distance info
>> results in the non-local points in the FORM2 matrix having a distance of
>> 0. This causes Linux to complain "Invalid distance value range" because
Daniel Henrique Barboza writes:
> The spapr-nvdimm driver is able to operate in two ways. The first
> one is as a regular memory in which the NUMA node of the parent
> pc-dimm class is used. The second mode, as persistent memory, allows for
> a different NUMA node to be used based on the locality
On 5/4/21 11:13 AM, Pankaj Gupta wrote:
What this patch series did was to express that property via a device
tree node and guest driver enables a hypercall based flush mechanism to
ensure persistence.
Would VIRTIO (entirely asynchronous, no trap at host side) based
mechanism is better
th
On 5/4/21 1:11 AM, Dan Williams wrote:
On Mon, May 3, 2021 at 7:06 AM Shivaprasad G Bhat wrote:
.
The proposal that "sync-dax=unsafe" for non-PPC architectures, is a
fundamental misrepresentation of how this is supposed to work. Rather
than make "sync-dax" a first class citizen of th
On 5/1/21 12:44 AM, Dan Williams wrote:
Some corrections to terminology confusion below...
...
file on the host in case of file backed v-nvdimms. This is addressed by
virtio-pmem in case of x86_64 by making explicit flushes translating to
fsync at qemu.
Note that virtio-pmem was a pro
On 4/29/21 9:25 PM, Stefan Hajnoczi wrote:
On Wed, Apr 28, 2021 at 11:48:21PM -0400, Shivaprasad G Bhat wrote:
The nvdimm devices are expected to ensure write persistence during power
failure kind of scenarios.
The libpmem has architecture specific instructions like dcbf on POWER
to flush the c
On 3/24/21 8:37 AM, David Gibson wrote:
On Tue, Mar 23, 2021 at 09:47:38AM -0400, Shivaprasad G Bhat wrote:
The patch adds support for the SCM flush hcall for the nvdimm devices.
To be available for exploitation by guest through the next patch.
The hcall expects the semantics such that the flus
On 3/24/21 8:39 AM, David Gibson wrote:
On Tue, Mar 23, 2021 at 09:47:55AM -0400, Shivaprasad G Bhat wrote:
The patch adds the 'sync-dax' property to the nvdimm device.
When the sync-dax is 'off', the device tree property
"hcall-flush-required" is added to the nvdimm node which makes the
guest
ty reasons
>
> For all these reasons, the handle backend is now deprecated.
>
> [1] https://www.tuxera.com/community/posix-test-suite/
>
Reviewed-by: Aneesh Kumar K.V
> Signed-off-by: Greg Kurz
> ---
>
> Aneesh,
>
> Even if I see the benefit of using file handl
Greg Kurz writes:
> Aneesh has been working on other topics for some time now. Let's reflect
> that in the MAINTAINERS file, so that people stop Cc'ing him.
>
> Signed-off-by: Greg Kurz
Acked-by: Aneesh Kumar K.V
> ---
> MAINTAINERS |2 --
> 1 file changed
Eric Blake writes:
> [ Unknown signature status ]
> On 08/30/2016 12:11 PM, Greg Kurz wrote:
>> Empty path components don't make sense for most commands and may cause
>> undefined behavior, depending on the backend.
>>
>> Also, the walk request described in the 9P spec [1] clearly shows that
>>
P J P writes:
> From: Prasad J Pandit
>
> At various places in 9pfs back-end, it creates full path by
> concatenating two path strings. It could lead to a path
> traversal issue if one of the parameter was a relative path.
> Add check to avoid it.
>
> Reported-by: Felix Wilhelm
> Signed-off-by:
inhibitted | memory conference) as valid values
for wimg flags.
Signed-off-by: Aneesh Kumar K.V
---
hw/ppc/spapr_hcall.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index 2ba5cbdb194a..e011ed4b664b 100644
--- a/hw/ppc/spapr_hcall.c
Greg Kurz writes:
> On Tue, 15 Mar 2016 00:02:48 +0800
> Jevon Qiao wrote:
>
>> Ceph as a promising unified distributed storage system is widely used in the
>> world of OpenStack. OpenStack users deploying Ceph for block (Cinder) and
>> object (S3/Swift) are unsurprisingly looking at Manila and
Jevon Qiao writes:
> Hi Aneesh,
>
> Thank you for reviewing my code, please see my reply in-line.
> On 14/2/16 21:38, Aneesh Kumar K.V wrote:
>> Jevon Qiao writes:
>>
>>> The following patch is to fix alignment issue when host filesystem block
>>
Jevon Qiao writes:
> The following patch is to fix alignment issue when host filesystem block
> size
> is larger than client msize.
>
> Thanks,
> Jevon
That is not the right format to send patch. You can send them as a
series using git-send-email.
>
> From: Jevon Qiao
> Date: Sun, 14 Feb 2016
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index f972731..385c01d 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -1326,7 +1326,7 @@ out_nofid:
> static int32_t get_iounit(V9fsPDU *pdu, V9fsPath *path)
> {
> struct statfs stbuf;
> -int32_t iounit =
From: Wei Liu
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 6d32b81faa25..e97adc8ba3f2 100644
--- a/hw/9pfs/virtio-9p.c
+++ b
From: Wei Liu
Factor out v9fs_iov_v{,un}marshal. Implement pdu_{,un}marshal with those
functions.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
fsdev/9p-iov-marshal.c | 42 ++
fsdev/9p-iov-marshal.h | 5 +
hw/9pfs/virtio-9p.c| 26
The following changes since commit a7e00e2536941a6e570b45b7ab4afec4505ff67e:
petalogix-ml605: Set the MicroBlaze CPU version to 8.10.a (2016-01-07
14:57:26 +0100)
are available in the git repository at:
https://github.com/kvaneesh/qemu.git tags/for-upstream-signed
for you to fetch changes
From: Wei Liu
These three files are not virtio specific. Rename them to generic
names.
Fix comments and header inclusion in various files.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/9p-handle.c | 2 +-
hw/9pfs/9p-local.c
From: Wei Liu
They will be used in later patches.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/9p.h| 3 +++
hw/9pfs/virtio-9p.c | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
index 9aeb8745cf20
From: Wei Liu
This file is not virtio specific. Rename it to use generic name.
Fix comment and remove unneeded inclusion of virtio.h.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/{virtio-9p-handle.c => 9p-handle.c} | 3 +--
hw/9pfs/Makefile.o
From: Wei Liu
Now that file only contains generic code.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/{virtio-9p.c => 9p.c} | 0
hw/9pfs/Makefile.objs | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
rename hw/9pfs/{virtio-9p.c => 9p.c} (100%)
diff
From: Wei Liu
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-device.c | 12
hw/9pfs/virtio-9p.c| 8 +---
hw/9pfs/virtio-9p.h| 2 ++
3 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw
From: Wei Liu
Move out generic definitions from virtio-9p.h to 9p.h. Fix header
inclusions.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/9p-handle.c | 2 +-
hw/9pfs/9p-local.c | 2 +-
hw/9pfs/9p-posix-acl.c | 2 +-
hw/9pfs/9p-proxy.c | 2 +-
hw
From: Wei Liu
The new function resides in virtio specific file.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-device.c | 11 +++
hw/9pfs/virtio-9p.c| 8 +---
hw/9pfs/virtio-9p.h| 2 ++
3 files changed, 14 insertions(+), 7 deletions
From: Wei Liu
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/9p.c | 95 ++
hw/9pfs/9p.h | 2 +
hw/9pfs/virtio-9p-device.c | 90 ---
3 files changed, 104
From: Wei Liu
These two files are not virtio specific. Rename them to use generic
names.
Fix includes in various C files. Change define guards and comments
in header files.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/{virtio-9p-synth.c => 9p-synth.c} | 2 +-
hw/9
From: Wei Liu
This file is not virtio specific. Rename it to use generic name.
Fix comment and remove unneeded inclusion of virtio.h.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/{virtio-9p-local.c => 9p-local.c} | 3 +--
hw/9pfs/Makefile.objs
From: Wei Liu
Break out some generic functions for marshaling 9p state. Pure code
motion plus minor fixes for build system.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
Makefile | 2 +-
fsdev/9p-marshal.c| 56 +++
fsdev/9p
From: Wei Liu
It's only used in virtio device.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-device.c | 34 ++
hw/9pfs/virtio-9p.c| 33 -
hw/9pfs/virtio-9p.h| 1 -
3 files ch
transport is going to have its own marshalling interface.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
Makefile| 2 +-
fsdev/{virtio-9p-marshal.c => 9p-iov-marshal.c} | 110 +---
fsdev/9p-iov-marsha
From: Wei Liu
Some structures in virtio-9p.h have been unused since 2011 when relevant
functions switched to use coroutines.
The declaration of pdu_packunpack and function do_pdu_unpack are
useless.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p.h | 68
From: Wei Liu
V9fsState now only contains generic fields. Introduce V9fsVirtioState
for virtio transport. Change virtio-pci and virtio-ccw to use
V9fsVirtioState.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/9p.c | 11 +--
hw/9pfs/9p.h
From: Wei Liu
Those two files are not virtio specific. Rename them to use generic
names.
Fix includes in various C files. Change define guards and comments in
header files.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/Makefile.objs| 2 +-
hw/9pfs
From: Wei Liu
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-device.c | 14 ++
hw/9pfs/virtio-9p.c| 6 ++
hw/9pfs/virtio-9p.h| 5 +
3 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/hw/9pfs/virtio-9p-device.c b
From: Wei Liu
V9fsState can be referenced by pdu->s. Initialise that in device
realization function.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-device.c | 1 +
hw/9pfs/virtio-9p.c| 98 +-
2 files chan
From: Wei Liu
The deleted file only contained V9fsConf which wasn't virtio specific.
Merge that to the general header of 9pfs.
Fixed header inclusions as I went along.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-device.c| 1 -
hw/9pfs/virtio
From: Wei Liu
This file is not virtio specific. Rename it to use generic name.
Fix comment and remove unneeded inclusion of virtio.h.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/{virtio-9p-posix-acl.c => 9p-posix-acl.c} | 3 +--
hw/9pfs/Makefile.o
From: Wei Liu
It's not virtio specific.
Signed-off-by: Wei Liu
---
hw/9pfs/virtio-9p.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 7fb05240987e..379fdcb2fe86 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -3
From: Wei Liu
This matches naming convention of pdu_marshal and pdu_unmarshal.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p.c | 88 ++---
1 file changed, 44 insertions(+), 44 deletions(-)
diff --git a/hw/9pfs
From: Wei Liu
Those two files are not virtio specific. Rename them to use generic
names.
Fix includes in various C files. Change define guards and comments
in header files.
Signed-off-by: Wei Liu
Signed-off-by: Aneesh Kumar K.V
---
fsdev/virtfs-proxy-helper.c | 2 +-
hw/9pfs
Wei Liu writes:
> On Mon, Jan 11, 2016 at 07:26:39PM +0530, Aneesh Kumar K.V wrote:
> [...]
>> > xattr_len = fidp->fs.xattr.len;
>> > read_count = xattr_len - off;
>> > @@ -1596,14 +1597,18 @@ static int v9fs_xattr_read(V9fsState *s, V9
Wei Liu writes:
> And make v9fs_pack static function. Now we only need to export
> v9fs_{,un}marshal to device.
>
> Signed-off-by: Wei Liu
> ---
> v3: fix bug discovered by Aneesh
> ---
> fsdev/9p-iov-marshal.c | 4 ++--
> fsdev/9p-iov-marshal.h | 3 ---
> hw/9pfs/9p.c | 21
Wei Liu writes:
> On Fri, Jan 08, 2016 at 02:00:31PM +0530, Aneesh Kumar K.V wrote:
>> Wei Liu writes:
>>
>> > And make v9fs_pack static function. Now we only need to export
>> > v9fs_{,un}marshal to device.
>> >
>> > Signed-off-by: Wei
Wei Liu writes:
> Hi all
>
> Version 2 of this series is even longer. :-)
>
> Back in 2015 summer one of our OPW interns Linda Jacobson explored the
> possibility of making 9pfs work on Xen. It turned out lots of code in QEMU can
> be reused.
>
> This patch series can be found at:
>
> git://xen
Wei Liu writes:
> The new function resides in virtio specific file.
>
> Signed-off-by: Wei Liu
> ---
> v2: new, part of original "9pfs: break out generic code from
> virtio-9p.{c,h}"
> ---
> hw/9pfs/virtio-9p-device.c | 11 +++
> hw/9pfs/virtio-9p.c| 8 +---
> hw/9pfs/v
Wei Liu writes:
> And make v9fs_pack static function. Now we only need to export
> v9fs_{,un}marshal to device.
>
> Signed-off-by: Wei Liu
> ---
> fsdev/virtio-9p-marshal.c | 4 ++--
> fsdev/virtio-9p-marshal.h | 3 ---
> hw/9pfs/virtio-9p.c | 21 +
> 3 files changed
Wei Liu writes:
> V9fsState now only contains generic fields. Introduce V9fsVirtioState
> for virtio transport. Change virtio-pci and virtio-ccw to use
> V9fsVirtioState. Handle transport enumeration in generic routines.
>
Few comments below
> Signed-off-by: Wei Liu
> ---
> hw/9pfs/9p.c
Wei Liu writes:
> On Thu, Jan 07, 2016 at 10:27:13PM +0530, Aneesh Kumar K.V wrote:
>> Wei Liu writes:
>>
>> > The vast majority of code in virtio-9p.c is actually generic code.
>> > Rename that file to 9p.c and move virtio specific code to
>> > virt
Wei Liu writes:
> Hi all
>
> Back in 2015 summer one of our OPW interns Linda Jacobson explored the
> possibility of making 9pfs work on Xen. It turned out lots of code in QEMU can
> be reused.
>
> This series refactors 9pfs related code:
>
> 1. Rename a bunch of files and functions to make clear
Wei Liu writes:
> Some structures virtio-9p.h have been unused since 2011 when relevant
> functions switched to use coroutines.
>
> The declaration of pdu_packunpack and function do_pdu_unpack are
> useless.
>
> The function virtio_9p_set_fd_limit is unused.
>
> Signed-off-by: Wei Liu
> ---
> h
"Michael S. Tsirkin" writes:
> On Tue, Dec 01, 2015 at 04:23:11PM +0530, Aneesh Kumar K.V wrote:
>> "Michael S. Tsirkin" writes:
>>
>> > On Mon, Nov 30, 2015 at 02:46:31PM +0100, Greg Kurz wrote:
>> >> On Mon, 30 N
"Michael S. Tsirkin" writes:
> On Mon, Nov 30, 2015 at 02:46:31PM +0100, Greg Kurz wrote:
>> On Mon, 30 Nov 2015 15:06:33 +0200
>> "Michael S. Tsirkin" wrote:
>>
>>
>> On ppc64, the address space is divided in 256MB-sized segments where all
>> pages
>> have the same size. This is a hw
Greg Kurz writes:
> As suggested by Paolo, I add myself as maintainer for virtio-9p.
>
> Signed-off-by: Greg Kurz
Acked-by: Aneesh Kumar K.V
> ---
> MAINTAINERS |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bb1f3e
Stefan Hajnoczi writes:
> On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote:
>> If the user tries to hot unplug a virtio-9p device, it seems to succeed but
>> in fact:
>> - virtio-9p coroutines thread pool and async queue are leaked
>> - QEMU crashes in virtio_vmstate_change() if the user
Greg Kurz writes:
> In a cross-endian setup, the virtio-9p device has state in @device_endian. It
> must be migrated.
>
> Signed-off-by: Greg Kurz
With 9p mounted, we don't support qemu migration. We have
migration blocker added in v9fs_attach.
> ---
> hw/9pfs/virtio-9p-device.c | 11 +
Greg Kurz writes:
> In a cross-endian setup, the virtio-9p device has state in @device_endian. It
> must be migrated.
>
> Signed-off-by: Greg Kurz
With 9p mounted, we don't support qemu migration. We still have
migration blocker added in v9fs_attach.
> ---
> hw/9pfs/virtio-9p-device.c | 11
The following changes since commit 93f6d1c16036aaf34055d16f54ea770fb8d6d280:
Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20150615-1' into
staging (2015-06-16 10:35:43 +0100)
are available in the git repository at:
https://github.com/kvaneesh/qemu.git tags/for-upstream-signed
From: Stefan Hajnoczi
Replace the assertion check with graceful failure when the socket path
is too long. Programs should not crash on invalid input. Print an
error message and exit properly.
Cc: Shannon Zhao
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Aneesh Kumar K.V
---
fsdev/virtfs
-off-by: Aneesh Kumar K.V
---
fsdev/virtfs-proxy-helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index a698e2dbb37b..91e8b9b7f1cf 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -49,6 +49,7
"Aneesh Kumar K.V" writes:
> Stefan Hajnoczi writes:
>
>> On Mon, Mar 30, 2015 at 02:57:14PM +0100, Stefan Hajnoczi wrote:
>>> These fixes are not critical but it wouldn't hurt to get them into QEMU 2.3.
>>>
I am not sure whether this is critical
Stefan Hajnoczi writes:
> On Mon, Mar 30, 2015 at 02:57:14PM +0100, Stefan Hajnoczi wrote:
>> These fixes are not critical but it wouldn't hurt to get them into QEMU 2.3.
>>
>> See patches for descriptions.
>>
>> Stefan Hajnoczi (2):
>> virtfs-proxy-helper: add missing long option terminator
Stefan Hajnoczi writes:
> On Sat, Mar 14, 2015 at 10:00:16AM +0800, Shannon Zhao wrote:
>> It's detected by coverity. As max of sockaddr_un.sun_path is
>> sizeof(helper.sun_path), should check the length of source
>> and use strncpy instead of strcpy.
>>
>> Signed-off-by: Shannon Zhao
>> Signed
() instead so we have
consistent result. This also makes sure the function
will do the right thing in corner cases (eg, empty
pathname is given), when basename(3) return entirely
another string.
Signed-off-by: Michael Tokarev
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-local.c | 24
r to each other
Signed-off-by: Michael Tokarev
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-proxy.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
index 59c7445deab9..6bb191ee6ab8 100644
From: Shannon Zhao
It's detected by coverity. Fix out-of-bounds access of the function
mp_dacl_listxattr.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-posix-acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Stefan Weil
All four leaks are similar, so fix them in one patch.
Success path was not doing memory free.
Signed-off-by: Stefan Weil
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-local.c | 28
1 file changed, 8 insertions(+), 20 deletions(-)
diff
Hi,
Please pull the below update for VirtFS
The following changes since commit ee74801035b0b5f1fdfd4e31d3a53f511f91c804:
Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150311' into staging
(2015-03-11 18:22:15 +)
are available in the git repository at:
https://github.com/kv
From: Shannon Zhao
It's detected by coverity. Check the return value of proxy_marshal.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Signed-off-by: Aneesh Kumar K.V
---
fsdev/virtfs-proxy-helper.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fsdev/virtfs-proxy-helpe
From: Shannon Zhao
It's detected by coverity. The socket name specified
should fit in the sockadd_un.sun_path. If not abort.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Signed-off-by: Aneesh Kumar K.V
---
fsdev/virtfs-proxy-helper.c | 1 +
hw/9pfs/virtio-9p-proxy.c | 4 ++
Stefan Weil writes:
> All four leaks are similar, so fix them in one patch.
Ok had to spent some time to figure out which was the path that was not
freeing memory. So added extra information to commit message.
Success path was not doing memory free.
Applied.
>
> Signed-off-by: Stefan Weil
>
Shannon Zhao writes:
> It's detected by coverity. As max of sockaddr_un.sun_path is
> sizeof(helper.sun_path), should check the length of source
> and use strncpy instead of strcpy.
>
> Signed-off-by: Shannon Zhao
> Signed-off-by: Shannon Zhao
> ---
> hw/9pfs/virtio-9p-proxy.c | 3 ++-
> 1 fil
Shannon Zhao writes:
> It's detected by coverity. As max of sockaddr_un.sun_path is
> sizeof(helper.sun_path), should check the length of source
> and use strncpy instead of strcpy.
updated such that,
The socket name specified should fit in the sockadd_un.sun_path. If not
abort.
with that appl
Shannon Zhao writes:
> It's detected by coverity. Check the return value of proxy_marshal.
>
> Signed-off-by: Shannon Zhao
> Signed-off-by: Shannon Zhao
Applied
> ---
> fsdev/virtfs-proxy-helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev
Shannon Zhao writes:
> It's detected by coverity. Fix out-of-bounds access of the function
> mp_dacl_listxattr.
>
> Signed-off-by: Shannon Zhao
> Signed-off-by: Shannon Zhao
> ---
> hw/9pfs/virtio-9p-posix-acl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/
Michael Tokarev writes:
> Omit one unnecessary memory allocation for components
> of the path and create the resulting path directly given
> lengths of the components.
>
> Do not use basename(3) because there are 2 versions of
> this function which differs when argument ends with
> slash characte
Michael Tokarev writes:
> Don't compare syscall return with -1, use "<0" condition.
> Don't introduce useless local variables when we already
> have similar variable
> Rename local variable to be consistent with other usages
> Finally make the two methods, read and write, to be similar to each ot
Michael Tokarev writes:
> 10.03.2015 20:41, Aneesh Kumar K.V пишет:
>> Michael Tokarev writes:
>>
>>> 08.03.2015 19:27, Aneesh Kumar K.V wrote:
>>>> Michael Tokarev writes:
>>> []
>>>>> Actually, after reading almost whole 9pfs and
Michael Tokarev writes:
> 08.03.2015 19:27, Aneesh Kumar K.V wrote:
>> Michael Tokarev writes:
> []
>>> Actually, after reading almost whole 9pfs and fsdev code, I can
>>> say with great confidence this code is nearly hopeless.
>>
>> Is that about t
Michael S. Tsirkin
> Cc: Aneesh Kumar K.V
> Signed-off-by: Stefan Weil
Reviewed-by: Aneesh Kumar K.V
> ---
> hw/9pfs/virtio-9p-handle.c | 4 ++--
> hw/9pfs/virtio-9p-local.c | 4 ++--
> hw/9pfs/virtio-9p-proxy.c | 4 ++--
> hw/9pfs/virtio-9p.c| 3 ++-
> 4 file
Michael Tokarev writes:
> 08.03.2015 19:39, Aneesh Kumar K.V wrote:
>> Michael Tokarev writes:
>>
>>> This simplifies code in v9fs_request() a bit by replacing several
>>> ifs with a common variable check and rearranging error/cleanup
>>>
Michael Tokarev writes:
> Omit one unnecessary memory allocation for components of the path
> and create the resulting path directly given lengths of the components.
>
> This uses (char*) cast because basename() accepts a char* without const,
> for unknown reason. Maybe it is better to use strrc
Michael Tokarev writes:
> Don't compare syscall return with -1, use "<0" condition.
> Don't introduce useless local variables when we already
> have similar variable
> Rename local variable to be consistent with other usages
>
> Signed-off-by: Michael Tokarev
> ---
> hw/9pfs/virtio-9p-proxy.c |
Michael Tokarev writes:
> This simplifies code in v9fs_request() a bit by replacing several
> ifs with a common variable check and rearranging error/cleanup
> code a bit.
Is this -V2 of
http://mid.gmane.org/b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git@msgid.tls.msk.ru
I am slight
Michael Tokarev writes:
> 07.03.2015 23:37, Eric Blake wrote:
>> On 03/06/2015 02:43 PM, Michael Tokarev wrote:
>>> All filesystem methods that call common v9fs_request() function
>>> also convert return value to errno. Move this conversion to the
>>> common function and remove redundand error h
Michael Tokarev writes:
> All filesystem methods that call common v9fs_request() function
> also convert return value to errno. Move this conversion to the
> common function and remove redundand error handling in methods.
>
> I didn't remove local `retval' variable in simple functions to
> keep
Michael Tokarev writes:
> Another interesting tidbit is in hw/9pfs/virtio-9p-proxy.c.
>
> All filesystem methods use common v9fs_request() function,
> which returns -errno. So far so good.
>
> Now, *all* places which call this function, does this:
>
> retval = v9fs_request(...);
> if (re
Michael Tokarev writes:
> I was looking at various interesting functions in hw/9pfs/virtio-9p-local.c
> and noticed local_open2() which basically tries to open a file in a
> filesystem, and if that is successful, it tries to set file credentials
> using a configured mechanism, and if that fails,
0x 0x
Signed-off-by: Aneesh Kumar K.V
---
target-ppc/cpu.h| 1 +
target-ppc/mmu-hash64.c | 37 ++---
target-ppc/mmu-hash64.h | 3 +++
3 files changed, 30 insertions(+), 11 deletions(-)
diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
hosts.
NOTE: This will break big-endian host that have virtFS exports
using security model mapped-xattr. They will have to use external tools
to convert the xattr to little-endian format.
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-local.c | 44
sufficient to just set d_type to DT_UNKNOWN,
so guest will know to look it up separately.
This is a -stable material.
Signed-off-by: Bastian Blank
Signed-off-by: Michael Tokarev
Signed-off-by: Aneesh Kumar K.V
---
hw/9pfs/virtio-9p-local.c | 5 -
1 file changed, 4 insertions(+), 1 deletion
m
for you to fetch changes up to 840a1bf2832f5783d1070547fcb460216fc219e5:
hw/9pfs: Don't return type from host in readdir on local 9p filesystem
(2014-09-04 10:51:13 -0500)
--------
Aneesh Kumar K.V (1):
hw/9pfs: Use little-en
Alexander Graf writes:
> On 03.09.14 23:21, Aneesh Kumar K.V wrote:
>> "Aneesh Kumar K.V" writes:
>>
>>> Stefan Hajnoczi writes:
>>>
>>>> On Tue, Sep 02, 2014 at 02:12:45PM +0100, Mark Cave-Ayland wrote:
>>>>> Fortunat
Michael Tokarev writes:
> From: Bastian Blank
>
> When using mapped mode in 9pfs, readdir implementation
> should not return file type in d_type from the host
> readdir, instead, it should use the type stored in
> the extended attributes. Since d_type is optional
> and reading ext attrs for ev
"Aneesh Kumar K.V" writes:
> Stefan Hajnoczi writes:
>
>> On Tue, Sep 02, 2014 at 02:12:45PM +0100, Mark Cave-Ayland wrote:
>>> Fortunately I can reproduce the issue with a debug-enabled build of
>>> qemu-system-sparc64, and I've posted a backtra
Stefan Hajnoczi writes:
> On Tue, Sep 02, 2014 at 02:12:45PM +0100, Mark Cave-Ayland wrote:
>> Fortunately I can reproduce the issue with a debug-enabled build of
>> qemu-system-sparc64, and I've posted a backtrace obtained during the hung
>> state at http://www.ilande.co.uk/tmp/sparc64-gdb-bt.tx
Michael Tokarev writes:
> I haven't noticed this email - which is almost a month old now - until today.
> So replying now...
>
> 30.07.2014 21:43, Aneesh Kumar K.V wrote:
>> "Aneesh Kumar K.V" writes:
>>
>>> Michael Tokarev writes:
>>>
1 - 100 of 680 matches
Mail list logo
