Re: [PATCH] target/i386: Fix #GP error code for INT instructions

2025-05-20 Thread Andrew Cooper
Ping? On 12/03/2025 12:06 am, Andrew Cooper wrote: > While the (intno << shift) expression is correct for indexing the IDT based on > whether Long Mode is active, the error code itself was unchanged with AMD64, > and is still the index with 3 bits of metadata in the bottom. > &g

[PATCH] target/i386: Fix #GP error code for INT instructions

2025-03-11 Thread Andrew Cooper
ted to being told there was an error with IDT index 256 when INT $0x80 (128) was the problem instruction: ... Error: Unexpected fault 0x800d0802, #GP[IDT[256]] ... Fixes: d2fd1af76777 ("x86_64 linux user emulation") Signed-off-by: Andrew Cooper --- CC: Paolo Bonzini CC: Richa

Re: [PULL 3/9] meson: Disallow 64-bit on 32-bit Xen emulation

2025-02-18 Thread Andrew Cooper
On 18/02/2025 11:20 am, Philippe Mathieu-Daudé wrote: > Hi, > > Adding Xen community. > > On 8/2/25 21:57, Richard Henderson wrote: >> Require a 64-bit host binary to spawn a 64-bit guest. >> >> Reviewed-by: Thomas Huth >> Reviewed-by: Philippe Mathieu-Daudé >> Signed-off-by: Richard Henderson >

Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier

2025-01-15 Thread Andrew Cooper
On 15/01/2025 4:27 pm, David Woodhouse wrote: > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c > index adfc4efad0..85b92cded4 100644 > --- a/hw/xen/xen-bus.c > +++ b/hw/xen/xen-bus.c > @@ -650,6 +650,16 @@ int xen_device_frontend_scanf(XenDevice *xendev, const > char *key, > return rc; > }

Re: [PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-13 Thread Andrew Cooper
On 13/08/2024 6:02 pm, Edgar E. Iglesias wrote: > On Mon, Aug 12, 2024 at 06:47:17PM -0700, Stefano Stabellini wrote: >> On Mon, 12 Aug 2024, Edgar E. Iglesias wrote: >>> From: "Edgar E. Iglesias" >>> >>> Add SMP support for Xen PVH ARM guests. Create max_cpus ioreq >>> servers to handle hotplug.

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-11 Thread Andrew Cooper
On 11/11/2023 8:18 pm, David Woodhouse wrote: > On 11 November 2023 08:43:40 GMT-05:00, Andrew Cooper > wrote: >> Furthermore, the control domain doesn't always have the domid of 0. >> >> If qemu wants/needs to make changes like this, the control domain has to &g

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-11 Thread Andrew Cooper
On 11/11/2023 10:55 am, David Woodhouse wrote: > On Fri, 2023-11-10 at 20:42 +, Volodymyr Babchuk wrote: >> From: Oleksandr Tyshchenko >> >> The PV backend running in other than Dom0 domain (non toolstack domain) >> is not allowed to write frontend nodes. The more, the backend does not >> need

Re: [PATCH] include/hw/xen: Use more inclusive language in comment

2023-11-09 Thread Andrew Cooper
On 09/11/2023 5:40 pm, Thomas Huth wrote: > Let's improve the wording here. > > Signed-off-by: Thomas Huth Thankyou for the patch, but this is a verbatim copy of a set of Xen headers. Would you mind submitting a correction to xen.git:xen/include/public/hvm/params.h first, and then syncing the re

Re: [PATCH v3 28/28] docs: update Xen-on-KVM documentation

2023-10-25 Thread Andrew Cooper
On 25/10/2023 7:26 pm, David Woodhouse wrote: > On Wed, 2023-10-25 at 13:20 -0500, Eric Blake wrote: >> On Wed, Oct 25, 2023 at 03:50:42PM +0100, David Woodhouse wrote: >>> + >>> +Booting Xen PV guests >>> +- >>> + >>> +Booting PV guest kernels is possible by using the Xen PV sh

Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen

2022-11-14 Thread Andrew Cooper
On 14/11/2022 19:20, Marek Marczykowski-Górecki wrote: > The /dev/mem is used for two purposes: > - reading PCI_MSIX_ENTRY_CTRL_MASKBIT > - reading Pending Bit Array (PBA) > > The first one was originally done because when Xen did not send all > vector ctrl writes to the device model, so QEMU mig

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-28 Thread Andrew Cooper
On 28/03/2019 11:40, Anthony PERARD wrote: > On Wed, Mar 27, 2019 at 08:32:28PM +, Paul Durrant wrote: >>> -Original Message- >>> From: Andrew Cooper >>> Sent: 27 March 2019 18:20 >>> To: Paul Durrant ; xen-de...@lists.xenproject.org; &g

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-27 Thread Andrew Cooper
On 27/03/2019 17:32, Paul Durrant wrote: > The Xen blkif protocol is confusing but discussion with the maintainer > has clarified that sector based quantities in requests and the 'sectors' > value advertized in xenstore should always be in terms of 512-byte > units and not the advertised logical 's

Re: [Qemu-devel] [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2019-03-15 Thread Andrew Cooper
On 15/03/2019 09:17, Paul Durrant wrote: >> -Original Message- >> From: Jason Andryuk [mailto:jandr...@gmail.com] >> Sent: 14 March 2019 18:16 >> To: Paul Durrant >> Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; >> marma...@invisiblethingslab.com; Simon >> Gaiser ; Stefano St

Re: [Qemu-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE

2019-03-14 Thread Andrew Cooper
On 14/03/2019 19:22, Simon Gaiser wrote: > Jason Andryuk: >> On Wed, Mar 13, 2019 at 11:09 AM Paul Durrant >> wrote: -Original Message- From: Jason Andryuk [mailto:jandr...@gmail.com] Sent: 11 March 2019 18:02 To: qemu-devel@nongnu.org Cc: xen-de...@lists.xenproje

Re: [Qemu-devel] [Xen-devel] [PATCH] hw/block/xen: use proper format string for printing sectors

2019-01-16 Thread Andrew Cooper
On 16/01/2019 12:13, Alex Bennée wrote: > The %lu format string is different depending on the host architecture > which causes builds like the debian-armhf-cross build to fail. Use the > correct PRi64 format string. > > Signed-off-by: Alex Bennée > --- > hw/block/xen-block.c | 2 +- > 1 file chan

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xen/pt: Fix a xen passthrough failure

2018-12-03 Thread Andrew Cooper
On 03/12/2018 05:04, Zhao Yan wrote: > For some pci device, even its PCI_INTERRUPT_PIN is not 0, it actually > doesn't support INTx mode, so its machine irq read from host sysfs is 0. > In that case, report PCI_INTERRUPT_PIN as 0 to guest and let passthrough > continue. What causes this problem? 

Re: [Qemu-devel] [Xen-devel] [PATCH 3/8] xen: defer call to xen_restrict until just before os_setup_post

2017-10-13 Thread Andrew Cooper
On 13/10/2017 09:37, Ross Lagerwall wrote: > On 10/09/2017 05:01 PM, Ian Jackson wrote: >> We need to restrict *all* the control fds that qemu opens.  Looking in >> /proc/PID/fd shows there are many; their allocation seems scattered >> throughout Xen support code in qemu. >> >> We must postpone the

Re: [Qemu-devel] [Xen-devel] [PATCH] MAINTAINERS: Update xen-devel mailing list address

2017-01-25 Thread Andrew Cooper
On 25/01/17 14:32, Andrew Cooper wrote: > On 25/01/17 14:29, Anthony PERARD wrote: >> On Mon, Nov 28, 2016 at 10:14:00AM -0800, Stefano Stabellini wrote: >>> On Fri, 25 Nov 2016, Anthony PERARD wrote: >>>> Signed-off-by: Anthony PERARD >>> Acked-by: Stefano

Re: [Qemu-devel] [Xen-devel] [PATCH] MAINTAINERS: Update xen-devel mailing list address

2017-01-25 Thread Andrew Cooper
On 25/01/17 14:29, Anthony PERARD wrote: > On Mon, Nov 28, 2016 at 10:14:00AM -0800, Stefano Stabellini wrote: >> On Fri, 25 Nov 2016, Anthony PERARD wrote: >>> Signed-off-by: Anthony PERARD >> Acked-by: Stefano Stabellini > Hi, > > This patch has never been applied. Queued. Sorry for letting i

Re: [Qemu-devel] [Xen-devel] [PATCH v2 2/3] xenfb: move xen_rmb to the correct location

2016-04-12 Thread Andrew Cooper
On 12/04/16 13:57, David Vrabel wrote: > On 12/04/16 11:43, Wei Liu wrote: >> It should be placed before first time producer and consumer are used. > This change isn't necessary and is confusing as this is not what this > barrier is for. > > The barrier needs to be between the load of prod and the

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: remove out_cons in xenfb_handle_events

2016-04-12 Thread Andrew Cooper
On 12/04/16 10:57, Wei Liu wrote: > The variable out_cons was only used to temporarily hold the consumer > index. Use cons directly to simplify code a bit. > > No functional change introduced. > > Signed-off-by: Wei Liu > --- > Cc: Stefano Stabellini > Cc: Anthony Perard > --- > hw/display/xenf

Re: [Qemu-devel] [Xen-devel] new barrier type for paravirt (was Re: [PATCH] virtio_ring: use smp_store_mb)

2015-12-20 Thread Andrew Cooper
On 20/12/15 09:25, Michael S. Tsirkin wrote: > On Thu, Dec 17, 2015 at 03:39:10PM +0100, Peter Zijlstra wrote: >> On Thu, Dec 17, 2015 at 04:33:44PM +0200, Michael S. Tsirkin wrote: >>> On Thu, Dec 17, 2015 at 02:57:26PM +0100, Peter Zijlstra wrote: You could of course go fix that instead of m

Re: [Qemu-devel] [Xen-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-09 Thread Andrew Cooper
On 09/12/15 13:41, Ian Campbell wrote: > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: >> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c >> index 5e324ef..c96d974 100644 >> --- a/hw/display/xenfb.c >> +++ b/hw/display/xenfb.c >> @@ -104,9 +104,8 @@ static int common_bind(struct commo

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-01 Thread Andrew Cooper
On 01/04/15 10:20, Stefano Stabellini wrote: > CC'ing the author of the patch and xen-devel. > FYI I think that Jan is going to be on vacation for a couple of weeks. > > On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: >> On Tue, Mar 31, 2015 at 03:18:03PM +0100, Stefano Stabellini wrote: >>> From: Ja

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-11-25 Thread Andrew Cooper
On 25/11/14 17:45, Stefano Stabellini wrote: > Increase maxmem before calling xc_domain_populate_physmap_exact to avoid > the risk of running out of guest memory. This way we can also avoid > complex memory calculations in libxl at domain construction time. > > This patch fixes an abort() when assi

Re: [Qemu-devel] [Xen-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-15 Thread Andrew Cooper
On 15/10/14 15:51, Paul Durrant wrote: >> -Original Message- >> From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] >> Sent: 15 October 2014 15:38 >> To: Paul Durrant >> Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano >> Stabellini; Peter Maydell; Paolo Bon

Re: [Qemu-devel] [Xen-devel] Xen hypervisor inside KVM guest with x2apic CPU feature fails to boot

2014-06-02 Thread Andrew Cooper
On 02/06/14 13:45, Daniel P. Berrange wrote: > I'm running > > kernel-3.14.4-200.fc20.x86_64 > qemu-1.6.2-5.fc20.x86_64 > xen-4.4.0-4.fc21 > > In process of trying to get a Xen hypervisor running inside a KVM guest I > found that there's a problem with x2apic. NB I do *not* use nested-VMX > here

Re: [Qemu-devel] [Xen-devel] [PATCH 1/2] xen: fix usage of ENODATA

2014-04-15 Thread Andrew Cooper
On 15/04/14 17:28, Roger Pau Monné wrote: > On 15/04/14 18:15, Anthony PERARD wrote: >> On Tue, Apr 15, 2014 at 10:33:08AM +0200, Roger Pau Monne wrote: >>> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the >>> hypervisor are translated to ENOENT. >>> >>> Also, the error code is r