Re: [RFC PATCH 01/19] hw/arm/virt: Only require TCG || QTest to use virtualization extension

ve NV support for KVM in QEMU. BTW Philippe isn't the same test needed above for secure (which can't be supported even with KVM NV support). > > Miguel > >> error_report("mach-virt: %s does not support providing " >> "Virtualization extensions to the guest CPU", >> current_accel_name()); >> -- >> 2.49.0 >> >> -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH 13/19] accel: Introduce AccelOpsClass::cpu_thread_routine handler

t AccelOpsClass *ops) { assert(ops != NULL); -assert(ops->create_vcpu_thread != NULL); /* mandatory */ +assert(ops->create_vcpu_thread || ops->cpu_thread_routine); /* mandatory */ cpus_accel = ops; } -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH 00/19] accel: Preparatory cleanups for split-accel

Philippe Mathieu-Daudé writes: > Few changes needed before being able to add the > split acceleration. Mostly adapting few prototypes > so callees have all necessary information. make check-tcg failed: ➜ make check-tcg /home/alex/lsrc/qemu.git/builds/arm.all/pyvenv/bin/meson i

Re: [RFC PATCH 09/19] accel: Factor accel_cpu_realize() out

claration -Wold-style-definition -Wredundant-decls -Wshadow=local -Wstrict-prototypes -Wtype-limits -Wundef -Wvla -Wwrite-strings -Wno-missing-include-dirs -Wno-psabi -Wno-shift-negative-value -isystem /home/alex/lsrc/qemu.git/linux-headers -isystem linux-headers -iquote . -iquote /home/alex/lsrc/qem

Re: [RFC PATCH 01/19] hw/arm/virt: Only require TCG || QTest to use virtualization extension

Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH 03/19] accel: Keep reference to AccelOpsClass in AccelClass

accel/tcg/tcg-accel-ops.c > +++ b/accel/tcg/tcg-accel-ops.c > @@ -198,8 +198,10 @@ static inline void tcg_remove_all_breakpoints(CPUState > *cpu) > cpu_watchpoint_remove_all(cpu, BP_GDB); > } > > -static void tcg_accel_ops_init(AccelOpsClass *ops) > +static void

Re: [RFC PATCH 04/19] accel: Propagate AccelState to AccelClass::init_machine()

Philippe Mathieu-Daudé writes: > In order to avoid init_machine() to call current_accel(), > pass AccelState along. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2] ramfb: Add property to control if load the romfile

so we're clear > >>> about the proposed usage. > >> > >> yes. And please change the vfio-pci property name to use underscores. > > > > Sorry, to *not* use underscores : use-legacy-x86-rom > > Thanks for pointing out it. Will fix it. It's also not evident from the property that this is restricted to ramfb behavior. Should the option on the vfio-pci device be prefixed with ramfb? Thanks, Alex

Re: [PATCH v9 3/9] plugins: Add enforcement of QEMU_PLUGIN_CB flags in register R/W callbacks

should rectified if we are no longer running translated code - indeed currently it is rectified by the time we leave the translated block and before we start the next one. There are some edge cases when we handle exceptions but we should have fixed up any register state before we longjmp back to the start of the run loop. -- Alex Bennée Virtualisation Tech Lead @ Linaro

KVM/QEMU community call 10/06/2025 agenda items?

Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 10/06/2025 14:00 UTC Are there any agenda items for the sync-up? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH RESEND v3] meson: fix Windows build

paths > are on different drives. I made sure to convert the Windows paths to > Unix paths to prevent warnings in generated files. > > Signed-off-by: oltolm for plugins: Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL v2 00/11] maintainer updates for May (testing, plugins)

bitfields ---- Alex Bennée (8): tests/docker: expose $HOME/.cache/qemu as docker volume gitlab: disable debug info on CI builds tests/tcg: make aarch64 boot.S handle different starting modes contrib/plugins: add a scaling factor

Re: [PULL 00/17] maintainer updates for May (testing, plugins, virtio-gpu)

Stefan Hajnoczi writes: > On Thu, Jun 5, 2025 at 12:28 PM Alex Bennée wrote: >> >> The following changes since commit 09be8a511a2e278b45729d7b065d30c68dd699d0: >> >> Merge tag 'pull-qapi-2025-06-03' of https://repo.or.cz/qemu/armbru into >> st

Re: [PULL 09/17] hw/display: re-arrange memory region tracking

Akihiko Odaki writes: > On 2025/06/06 18:54, Alex Bennée wrote: >> Akihiko Odaki writes: >> >>> On 2025/06/06 1:26, Alex Bennée wrote: >>>> QOM objects can be embedded in other QOM objects and managed as part >>>&g

Re: [PATCH v4 09/17] hw/display: re-arrange memory region tracking

Akihiko Odaki writes: > On 2025/06/05 20:57, Alex Bennée wrote: >> Akihiko Odaki writes: >> >>> On 2025/06/03 20:01, Alex Bennée wrote: >>>> QOM objects can be embedded in other QOM objects and managed as part >>>&g

Re: [PATCH v3 0/2] semihosting/uaccess: Compile once

Philippe Mathieu-Daudé writes: > ping? Queued to semihosting/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PULL 09/17] hw/display: re-arrange memory region tracking

Akihiko Odaki writes: > On 2025/06/06 1:26, Alex Bennée wrote: >> QOM objects can be embedded in other QOM objects and managed as part >> of their lifetime but this isn't the case for >> virtio_gpu_virgl_hostmem_region. However before we can split it out we >> ne

Re: [PATCH] record/replay: fix race condition on test_aarch64_reverse_debug

77b5dc961da4364af26e771bd39f379cbbf7') > > -@skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2921";) > def test_aarch64_virt(self): > self.set_machine('virt') > self.cpu = 'cortex-a53' -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/4] system: Forbid alloca()

| 4 > backends/tpm/tpm_emulator.c | 4 ++-- > hw/gpio/pca9552.c | 2 +- > tests/unit/test-char.c | 3 +-- > 4 files changed, 8 insertions(+), 5 deletions(-) -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL 17/17] gdbstub: update aarch64-core.xml

B: expanded upstream link] Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-18-alex.ben...@linaro.org> diff --git a/gdb-xml/aarch64-core.xml b/gdb-xml/aarch64-core.xml index e1e9dc3f91..b8046510b9 100644 --- a/gdb-xml/aarch64-core.xml +++ b/gdb-xml/aarch64-core

[PULL 16/17] gdbstub: Implement qGDBServerVersion packet

s/2648 Co-authored-by: Patryk 'patryk4815' Sondej Signed-off-by: Dominik 'Disconnect3d' Czarnota Message-Id: <20250403191340.53343-1-dominik.b.czarn...@gmail.com> [AJB: fix include, checkpatch linewrap] Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-1

[PULL 00/17] maintainer updates for May (testing, plugins, virtio-gpu)

assets in size_memop - fix include guard in gdbstub - introduce qGDBServerVersion gdbstub query - update gdb aarch64-core.xml to support bitfields ---- Alex Bennée (11): tests/docker: expose $HOME/.cache/qemu as docker volume

[PULL 07/17] MAINTAINERS: add myself to virtio-gpu for Odd Fixes

Seeing as I've taken a few patches to here now I might as well put myself forward to maintain virtio-gpu. I've marked it as Odd Fixes as it is not my core focus. If someone with more GPU experience comes forward we can always update again. Reviewed-by: Markus Armbruster Signed-of

[PULL 05/17] contrib/plugins: add a scaling factor to the ips arg

It's easy to get lost in zeros while setting the numbers of instructions per second. Add a scaling suffix to make things simpler. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-6-alex.ben...@linaro.org> diff --git a/contrib/plugins/ips.

[PULL 08/17] MAINTAINERS: add Akihiko and Dmitry as reviewers

Thanks for volunteering to help. Cc: Akihiko Odaki Cc: Dmitry Osipenko Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-9-alex.ben...@linaro.org> diff --git a/MAINTAI

[PULL 03/17] tests/tcg: make aarch64 boot.S handle different starting modes

: Jim MacArthur Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-4-alex.ben...@linaro.org> diff --git a/tests/tcg/aarch64/Makefile.softmmu-target b/tests/tcg/aarch64/Makefile.softmmu-target index 9c52475b7a..f7a7d2b800 100644 --- a/tests/tcg/aarch64/Makefile.softmmu-target

[PULL 12/17] virtio-gpu: support context init multiple timeline

commit message] Tested-by: Dmitry Osipenko Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-13-alex.ben...@linaro.org> diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index b4aa8abb96..cea2e12eb9 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/disp

[PULL 14/17] include/gdbstub: fix include guard in commands.h

Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-15-alex.ben...@linaro.org> diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h index 40f0514fe9..bff3674872 100644 --- a/include/gdbstub/comm

[PULL 01/17] tests/docker: expose $HOME/.cache/qemu as docker volume

If you want to run functional tests we should share .cache/qemu so we don't force containers to continually re-download images. We also move ccache to use this shared area. Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-2-alex.ben...@linaro.or

[PULL 04/17] tests/qtest: Avoid unaligned access in IGB test

pe Mathieu-Daudé Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-5-alex.ben...@linaro.org> diff --git a/tests/qtest/libqos/igb.c b/tests/qtest/libqos/igb.c index f40c4ec4cd..ab3ef6f0c3 100644 --- a/tests/qtest/libqos/igb.c +++ b/tests/qtest/libqos/igb.c @@ -104,10

[PULL 02/17] gitlab: disable debug info on CI builds

like --enable-debug-tcg. Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-3-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index 118371e377..19663126ca 100644 --- a/.gitlab-ci.d/bui

[PULL 06/17] contrib/plugins: allow setting of instructions per quantum

The default is we update time every 1/10th of a second or so. However for some cases we might want to update time more frequently. Allow this to be set via the command line through the ipq argument. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-ID: <20250603110204.83811

[PULL 15/17] gdbstub: assert earlier in handle_read_all_regs

When things go wrong we want to assert on the register that failed to be able to figure out what went wrong. Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-16-alex.ben...@linaro.org> diff --git a/g

[PULL 13/17] include/exec: fix assert in size_memop

We can handle larger sized memops now, expand the range of the assert. Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits) Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-14-alex.ben...@linaro.org> diff --git a/include/exec/memop.h b/includ

[PULL 10/17] virtio-gpu: refactor async blob unmapping

Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20250410122643.1747913-4-manos.pitsidiana...@linaro.org> Cc: qemu-sta...@nongnu.org Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-11-alex.ben...@linaro.org> diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio

[PULL 11/17] ui/gtk-gl-area: Remove extra draw call in refresh

guest. Fixes: 77bf310084 ("ui/gtk: Draw guest frame at refresh cycle") Reported-by: Dmitry Osipenko Reported-by: Alex Bennée Tested-by: Alex Bennée Tested-by: Dmitry Osipenko Reviewed-by: Alex Bennée Reviewed-by: Dmitry Osipenko Cc: Marc-André Lureau Cc: Vivek Kasireddy Signed-off-b

[PULL 09/17] hw/display: re-arrange memory region tracking

Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20250410122643.1747913-2-manos.pitsidiana...@linaro.org> Cc: qemu-sta...@nongnu.org Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-10-alex.ben...@linaro.org> diff --git a/include/system/memory.h b/include/syst

Re: [PATCH v3 1/3] docs: introduce dedicated page about code provenance / sign-off

Markus Armbruster writes: > Markus Armbruster writes: > >> Alex Bennée writes: > > [...] > >>> We don't mention the Link: or Message-Id: tags. >> >> Yes, but should it go into code-provenance.rst or >> submitting-a-patch.rst? >> >&

Re: [PATCH v5 0/7] ui/spice: Enable gl=on option for non-local or remote clients

https://gitlab.freedesktop.org/spice/spice/-/merge_requests/229 > > --- > Cc: Gerd Hoffmann > Cc: Marc-André Lureau > Cc: Dmitry Osipenko > Cc: Frediano Ziglio > Cc: Michael Scherle > Cc: Dongwon Kim > Cc: Alex Bennée > > Vivek Kasireddy (7): > ui/egl-hel

Re: [PATCH v4 3/3] docs: define policy forbidding use of AI code generators

safe, then relax. > > Meanwhile requests for exceptions can also be considered on a case by > case basis. > > Signed-off-by: Daniel P. Berrangé > Acked-by: Stefan Hajnoczi > Reviewed-by: Kevin Wolf > Signed-off-by: Markus Armbruster Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v4 1/3] docs: introduce dedicated page about code provenance / sign-off

rrangé > Reviewed-by: Peter Maydell > Signed-off-by: Markus Armbruster Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v4 09/17] hw/display: re-arrange memory region tracking

Akihiko Odaki writes: > On 2025/06/03 20:01, Alex Bennée wrote: >> QOM objects can be embedded in other QOM objects and managed as part >> of their lifetime but this isn't the case for >> virtio_gpu_virgl_hostmem_region. However before we can split it out we >> ne

Re: [PATCH v4 03/17] tests/tcg: make aarch64 boot.S handle different starting modes

Akihiko Odaki writes: > On 2025/06/03 20:01, Alex Bennée wrote: >> Currently the boot.S code assumes everything starts at EL1. This will >> break things like the memory test which will barf on unaligned memory >> access when run at a higher level. >> Adapt the

Re: [PATCH v3 1/3] docs: introduce dedicated page about code provenance / sign-off

ame spelling. It's okay if you subscribe or contribute to > -the list via more than one address, but using multiple addresses in one > -commit just confuses things. If someone else wrote the patch, git will > -include a "From:" line in the body of the email (different from your > -envelope From:) that will give credit to the correct author; but again, > -that author's Signed-off-by: line is mandatory, with the same spelling. > +this and happy for it to go into QEMU". For full guidance, read the > +:ref:`code-provenance` documentation. > > The name used with "Signed-off-by" does not need to be your legal name, > nor birth name, nor appear on any government ID. It is the identity you > choose to be known by in the community, but should not be anonymous, > nor misrepresent whom you are. > > -There are various tooling options for automatically adding these tags > -include using ``git commit -s`` or ``git format-patch -s``. For more > -information see `SubmittingPatches 1.12 > -<http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297>`__. > > .. _include_a_meaningful_cover_letter: -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH v4 13/17] include/exec: fix assert in size_memop

We can handle larger sized memops now, expand the range of the assert. Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits) Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - instead of 128 use 1 << MO_SIZE for future proofing v3 - fix comment, 1 << MO_SIZE goe

[PATCH v4 11/17] ui/gtk-gl-area: Remove extra draw call in refresh

guest. Fixes: 77bf310084 ("ui/gtk: Draw guest frame at refresh cycle") Reported-by: Dmitry Osipenko Reported-by: Alex Bennée Tested-by: Alex Bennée Tested-by: Dmitry Osipenko Reviewed-by: Alex Bennée Reviewed-by: Dmitry Osipenko Cc: Marc-André Lureau Cc: Vivek Kasireddy Signed-off-b

[PATCH v4 04/17] tests/qtest: Avoid unaligned access in IGB test

s properly against uint32_t and uint16_t. Signed-off-by: Nabih Estefan Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20250429155621.2028198-1-nabiheste...@google.com> [AJB: fix commit message, remove unneeded casts] Signed-off-by: Alex Ben

[PATCH v4 16/17] gdbstub: Implement qGDBServerVersion packet

s/2648 Co-authored-by: Patryk 'patryk4815' Sondej Signed-off-by: Dominik 'Disconnect3d' Czarnota Message-Id: <20250403191340.53343-1-dominik.b.czarn...@gmail.com> [AJB: fix include, checkpatch linewrap] Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 17

[PATCH v4 03/17] tests/tcg: make aarch64 boot.S handle different starting modes

: Jim MacArthur Signed-off-by: Alex Bennée --- v4 - drop post eret nops - proper error string for EL0 error case - clamp any invalid target EL value to 1 v3 - create system stack so we _exit cleanly - normalise EL string before compares - catch when we start in a lower EL than we asked

[PATCH v4 12/17] virtio-gpu: support context init multiple timeline

d this via guest and host side perfetto tracing. Cc: Fixes: 94d0ea1c1928 ("virtio-gpu: Support Venus context") Signed-off-by: Yiwei Zhang Reviewed-by: Dmitry Osipenko Message-Id: <20250518152651.334115-1-zzyi...@gmail.com> [AJB: remove version history from commit message]

[PATCH v4 02/17] gitlab: disable debug info on CI builds

like --enable-debug-tcg. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth --- .gitlab-ci.d/buildtest-template.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index 118371e377..19663126ca 100644 --- a/.gitlab

[PATCH v4 06/17] contrib/plugins: allow setting of instructions per quantum

The default is we update time every 1/10th of a second or so. However for some cases we might want to update time more frequently. Allow this to be set via the command line through the ipq argument. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- v4 - simplify error checking

[PATCH v4 10/17] virtio-gpu: refactor async blob unmapping

From: Manos Pitsidianakis Change the 3 part async cleanup of a blob memory mapping to check if the unmapping has finished already after deleting the subregion; this condition allows us to skip suspending the command and responding to the guest right away. Signed-off-by: Manos Pitsidianakis Revi

[PATCH v4 09/17] hw/display: re-arrange memory region tracking

Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20250410122643.1747913-2-manos.pitsidiana...@linaro.org> Cc: qemu-sta...@nongnu.org --- include/system/memory.h | 1 + hw/display/virtio-gpu-virgl.c | 23 --- 2 files changed, 9

[PATCH v4 01/17] tests/docker: expose $HOME/.cache/qemu as docker volume

If you want to run functional tests we should share .cache/qemu so we don't force containers to continually re-download images. We also move ccache to use this shared area. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth --- v3 - mention ccache v2 - Share a whole .cache/qemu

[PATCH v4 15/17] gdbstub: assert earlier in handle_read_all_regs

When things go wrong we want to assert on the register that failed to be able to figure out what went wrong. Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v4 17/17] gdbstub: update aarch64-core.xml

B: expanded upstream link] Signed-off-by: Alex Bennée --- gdb-xml/aarch64-core.xml | 52 ++-- 1 file changed, 50 insertions(+), 2 deletions(-) diff --git a/gdb-xml/aarch64-core.xml b/gdb-xml/aarch64-core.xml index e1e9dc3f91..b8046510b9 100644 --- a/gdb-xml/aarch

[PATCH v4 00/17] Maintainer updates for May (testing, plugins, virtio-gpu) - pre-PR

hiko/Dmitry as virtio-gpu reviewers The following still need review: tests/tcg: make aarch64 boot.S handle different starting modes Alex. Alex Bennée (11): tests/docker: expose $HOME/.cache/qemu as docker volume gitlab: disable debug info on CI builds tests/tcg: make aarch64 boot.S handle

[PATCH v4 14/17] include/gdbstub: fix include guard in commands.h

Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- include/gdbstub/commands.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h index 40f0514fe9..bff3674872 100644 --- a

[PATCH v4 08/17] MAINTAINERS: add Akihiko and Dmitry as reviewers

Thanks for volunteering to help. Cc: Akihiko Odaki Cc: Dmitry Osipenko Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Acked-by: Michael S. Tsirkin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v4 07/17] MAINTAINERS: add myself to virtio-gpu for Odd Fixes

Seeing as I've taken a few patches to here now I might as well put myself forward to maintain virtio-gpu. I've marked it as Odd Fixes as it is not my core focus. If someone with more GPU experience comes forward we can always update again. Reviewed-by: Markus Armbruster Signed-of

[PATCH v4 05/17] contrib/plugins: add a scaling factor to the ips arg

It's easy to get lost in zeros while setting the numbers of instructions per second. Add a scaling suffix to make things simpler. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- v2 - normalise the suffix before a full strcmp0 - check endptr actually set - fix check

Re: TCG Address Sanitizer Optimization.

> > > Hence the current implementation is a little clumsy! > > Thanks for your advice. > > Jon > > On Mon, Jun 2, 2025 at 4:09 PM Alex Bennée wrote: > > Jon Wilson writes: > > (Adding Richard, the

Re: TCG Address Sanitizer Optimization.

re I > think the issue is caused by the surrounding TCG in the block it is injected > into? > > //// > runner-x86_64: ../tcg/tcg.c:4852: tcg_reg_alloc_mov: Assertion `ts->val_type > == TEMP_VAL_REG' failed. > Aborted (core dumped) > > > I would be very grateful for any advice of how to resolve this issue, or any > alternative approaches I could use to optimize my original implementation. The > code is obviously a very hot path and so even a tiny performance improvement > could result in a large performance gain overall. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2] vfio/pci: Introduce x-pci-class-code option

ield was defined, so at least before 1995. Also, neither the kernel or QEMU is_vga helpers account for this, so they'd not have a VGA region or be properly detected elsewhere. Thanks, Alex > + > if (!(reg_info->flags & VFIO_REGION_INFO_FLAG_READ) ||

Re: [PATCH v2] vfio/igd: Fix incorrect error propagation in vfio_pci_igd_opregion_detect()

errp)) { > +if (!vfio_pci_igd_opregion_detect(vdev, &opregion)) { > return true; > } > info_report("OpRegion detected on Intel display %x.", vdev->device_id); > @@ -695,7 +693,7 @@ static bool vfio_pci_kvmgt_config_quirk(VFIOPCIDevice > *vdev, E

Re: [PATCH] vfio/pci: Introduce x-pci-class-code option

to a non-VGA device that doesn't make any sense. vfio_populate_vga() needs to care about the exposed class code now too. Thanks, Alex > Signed-off-by: Tomita Moeko > --- > hw/vfio/pci.c| 17 + > hw/vfio/pci.h| 1 + > hw/vfio/trace-events | 1 + >

Re: [PATCH v3 12/20] virtio-gpu: fix hang under TCG when unmapping blob

Akihiko Odaki writes: > On 2025/05/22 18:28, Alex Bennée wrote: >> Akihiko Odaki writes: >> >>> On 2025/05/22 16:31, Manos Pitsidianakis wrote: >>>> On Thu, May 22, 2025 at 10:03 AM Akihiko Odaki >>>> wrote: >>>>> >>>

Re: [PATCH v3 19/20] gdbstub: Implement qGDBServerVersion packet

Philippe Mathieu-Daudé writes: > On 21/5/25 17:42, Alex Bennée wrote: >> From: Dominik 'Disconnect3d' Czarnota >> This commit adds support for the `qGDBServerVersion` packet to the >> qemu >> gdbstub which could be used by clients to detect the QEMU versio

KVM/QEMU community call today @ 14:00 UTC

Hi, I forgot to send this yesterday due to local bank holidays, anyway the KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 27/05/2025 14:00 UTC Are there any agenda items for the sync-up? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v4] tests/functional: Add PCI hotplug test for aarch64

TRD = Asset( > +('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/' > + 'current/images/netboot/debian-installer/arm64/initrd.gz'), > + > '2583ec22b45265ad69e82f198674f53d4cd85be124fe012eedc2fd91156bc4b4') Hmm do we need

Re: [PATCH] tests/functional/test_mips_malta: Re-enable the check for the PCI host bridge

Thomas Huth writes: > From: Thomas Huth > > The problem with the PCI bridge has been fixed in commit e5894fd6f411c1 > ("hw/pci-host/gt64120: Fix endianness handling"), so we can enable the > corresponding test again. > > Signed-off-by: Thomas Huth Reviewed-by

Re: [PATCH v3 2/8] Add register write API

. I would expect us to: a) handle the QEMU_PLUGIN_CB_RW_REGS b) try and enforce we are only being called from such callbacks Otherwise TCG won't know to restore register state from what has been written to. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v3 05/20] tests/Makefile: include test-plugins in per-arch build deps

Akihiko Odaki writes: > On 2025/05/22 1:42, Alex Bennée wrote: >> The user can run a subset of the tcg tests directly, e.g.: >>make run-tcg-tests-hexagon-linux-user >> but in this case we fail if there has not been a full build to >> ensure >> all th

Re: [PATCH v3 19/20] gdbstub: Implement qGDBServerVersion packet

Akihiko Odaki writes: > On 2025/05/22 1:42, Alex Bennée wrote: >> From: Dominik 'Disconnect3d' Czarnota >> This commit adds support for the `qGDBServerVersion` packet to the >> qemu >> gdbstub which could be used by clients to detect the QEMU version >

Re: [PATCH v3 12/20] virtio-gpu: fix hang under TCG when unmapping blob

Akihiko Odaki writes: > On 2025/05/22 16:31, Manos Pitsidianakis wrote: >> On Thu, May 22, 2025 at 10:03 AM Akihiko Odaki >> wrote: >>> >>> On 2025/05/22 15:45, Alex Bennée wrote: >>>> Akihiko Odaki writes: >>>> >>>>>

Re: [PATCH v3 12/20] virtio-gpu: fix hang under TCG when unmapping blob

Akihiko Odaki writes: > On 2025/05/22 1:42, Alex Bennée wrote: >> From: Manos Pitsidianakis >> This commit fixes an indefinite hang when using VIRTIO GPU blob >> objects >> under TCG in certain conditions. >> The VIRTIO_GPU_CMD_RESOURCE_MAP_BLOB VIRTIO comm

Re: [PATCH] vfio/igd: Fix incorrect error propagation in vfio_pci_igd_opregion_detect()

On Wed, 21 May 2025 23:40:36 +0800 Tomita Moeko wrote: > In vfio_pci_igd_opregion_detect(), errp will be set when device does > not have OpRegion or is hotplugged. This errp will be propergated to propagated > pci_qdev_realize(), which interprets it as failure, causing unexpected > termination

Re: [PATCH] tests/functional/test_sparc64_tuxrun: Explicitly set the 'sun4u' machine

Thomas Huth writes: > From: Thomas Huth > > Use self.set_machine() to set the machine instead of relying on the > default machine of the binary. This way the test can be skipped in > case the machine has not been compiled into the QEMU binary. > > Signed-off-by: Thomas Hut

[PATCH v3 16/20] include/exec: fix assert in size_memop

We can handle larger sized memops now, expand the range of the assert. Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits) Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - instead of 128 use 1 << MO_SIZE for future proofing v3 - fix comment, 1 << MO_SIZE

[PATCH v3 17/20] include/gdbstub: fix include guard in commands.h

Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- include/gdbstub/commands.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h index 40f0514fe9..bff3674872 100644 --- a

[PATCH v3 20/20] gdbstub: update aarch64-core.xml

B: expanded upstream link] Signed-off-by: Alex Bennée --- gdb-xml/aarch64-core.xml | 52 ++-- 1 file changed, 50 insertions(+), 2 deletions(-) diff --git a/gdb-xml/aarch64-core.xml b/gdb-xml/aarch64-core.xml index e1e9dc3f91..b8046510b9 100644 --- a/gdb-xml/aarch

[PATCH v3 18/20] gdbstub: assert earlier in handle_read_all_regs

When things go wrong we want to assert on the register that failed to be able to figure out what went wrong. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub

[PATCH v3 14/20] ui/gtk-gl-area: Remove extra draw call in refresh

guest. Fixes: 77bf310084 ("ui/gtk: Draw guest frame at refresh cycle") Reported-by: Dmitry Osipenko Reported-by: Alex Bennée Tested-by: Alex Bennée Tested-by: Dmitry Osipenko Reviewed-by: Alex Bennée Reviewed-by: Dmitry Osipenko Cc: Marc-André Lureau Cc: Vivek Kasireddy Signed-off-b

[PATCH v3 10/20] MAINTAINERS: add Akihiko and Dmitry as reviewers

Thanks for volunteering to help. Cc: Akihiko Odaki Cc: Dmitry Osipenko Signed-off-by: Alex Bennée --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8dfb393c06..a14e2796e0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2674,6 +2674,8 @@ F

[PATCH v3 01/20] tests/docker: expose $HOME/.cache/qemu as docker volume

If you want to run functional tests we should share .cache/qemu so we don't force containers to continually re-download images. Signed-off-by: Alex Bennée --- v2 - Share a whole .cache/qemu path. --- tests/docker/Makefile.include | 10 ++ 1 file changed, 6 insertions(+), 4 dele

[PATCH v3 09/20] MAINTAINERS: add myself to virtio-gpu for Odd Fixes

Seeing as I've taken a few patches to here now I might as well put myself forward to maintain virtio-gpu. I've marked it as Odd Fixes as it is not my core focus. If someone with more GPU experience comes forward we can always update again. Signed-off-by: Alex Bennée --- v2 - s/M:/S

[PATCH v3 06/20] tests/functional: Add PCI hotplug test for aarch64

m link] Signed-off-by: Alex Bennée --- v2 - add qemu-arm link to MAINTAINERS --- MAINTAINERS | 6 ++ tests/functional/meson.build | 1 + tests/functional/test_aarch64_hotplug_pci.py | 74 3 files changed, 81 insertions(+) creat

[PATCH v3 15/20] virtio-gpu: support context init multiple timeline

d this via guest and host side perfetto tracing. Cc: Fixes: 94d0ea1c1928 ("virtio-gpu: Support Venus context") Signed-off-by: Yiwei Zhang Reviewed-by: Dmitry Osipenko Message-Id: <20250518152651.334115-1-zzyi...@gmail.com> [AJB: remove version history from commit message]

[PATCH v3 13/20] virtio-gpu: refactor async blob unmapping

From: Manos Pitsidianakis Change the 3 part async cleanup of a blob memory mapping to check if the unmapping has finished already after deleting the subregion; this condition allows us to skip suspending the command and responding to the guest right away. Signed-off-by: Manos Pitsidianakis Revi

[PATCH v3 03/20] tests/tcg: make aarch64 boot.S handle different starting modes

: Jim MacArthur Signed-off-by: Alex Bennée --- v3 - create system stack so we _exit cleanly - normalise EL string before compares - catch when we start in a lower EL than we asked for - default to EL1 when arg unclear v2 - allow tests to control the final EL we end up at - use tabs

[PATCH v3 19/20] gdbstub: Implement qGDBServerVersion packet

s/2648 Co-authored-by: Patryk 'patryk4815' Sondej Signed-off-by: Dominik 'Disconnect3d' Czarnota Message-Id: <20250403191340.53343-1-dominik.b.czarn...@gmail.com> [AJB: fix include, checkpatch linewrap] Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 17

[PATCH v3 05/20] tests/Makefile: include test-plugins in per-arch build deps

: Alex Bennée --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 23fb722d42..7f7f62cbf6 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -46,7 +46,7 @@ $(foreach TARGET

[PATCH v3 07/20] contrib/plugins: add a scaling factor to the ips arg

It's easy to get lost in zeros while setting the numbers of instructions per second. Add a scaling suffix to make things simpler. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- v2 - normalise the suffix before a full strcmp0 - check endptr actually set - fix check

[PATCH v3 11/20] hw/display: re-arrange memory region tracking

Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20250410122643.1747913-2-manos.pitsidiana...@linaro.org> Cc: qemu-sta...@nongnu.org --- include/system/memory.h | 1 + hw/display/virtio-gpu-virgl.c | 23 --- 2 files changed, 9

[PATCH v3 08/20] contrib/plugins: allow setting of instructions per quantum

The default is we update time every 1/10th of a second or so. However for some cases we might want to update time more frequently. Allow this to be set via the command line through the ipq argument. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- v3 - error checking for ipq v2

[PATCH v3 00/20] Maintainer updates for May (testing, plugins, virtio-gpu) - pre-PR

se $HOME/.cache/qemu as docker volume Alex. Alex Bennée (12): tests/docker: expose $HOME/.cache/qemu as docker volume gitlab: disable debug info on CI builds tests/tcg: make aarch64 boot.S handle different starting modes tests/Makefile: include test-plugins in per-arch build deps contrib

[PATCH v3 12/20] virtio-gpu: fix hang under TCG when unmapping blob

e, which removes the extra owner reference in the memory region and causes the MR to be freed right away in the main context. Acked-by: Michael S. Tsirkin Signed-off-by: Manos Pitsidianakis Reviewed-by: Alex Bennée Tested-by: Alex Bennée Message-Id: <20250410122643.1747913-3-manos.pitsidiana.

[PATCH v3 02/20] gitlab: disable debug info on CI builds

like --enable-debug-tcg. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth --- .gitlab-ci.d/buildtest-template.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index 118371e377..19663126ca 100644 --- a/.gitlab

[PATCH v3 04/20] tests/qtest: fix igb test failure under --enable-ubsan

g properly against uint32_t and uint16_t. Signed-off-by: Nabih Estefan Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20250429155621.2028198-1-nabiheste...@google.com> [AJB: fix commit message, remove unneeded casts] Signed-off-by: Alex

  1   2   3   4   5   6   7   8   9   10   >