>> So finally:
>>
>> Tested-by: Alex Bennée
> Thanks for the testing.
>
> Abdallah: I've added this series to my target-arm.next queue,
> so it should reach QEMU master some time next week. Thanks for
> your efforts in working through QEMU's review process, and
> sorry this took us so long to dea
> Abdallah Bouassida writes:
>
>> The previous version:
>> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714
> I was trying to do some testing but I was finding it very hard to do at
> gdb kept throwing up errors like:
>
> (gdb) x/10i $pc
> =&g
ping
Le 4/19/2018 à 4:56 PM, Abdallah Bouassida a écrit :
> The previous version:
> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714
>
> Abdallah Bouassida (3):
> target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo
> type
>
Generate an XML description for the cp-regs.
Register these regs with the gdb_register_coprocessor().
Add arm_gdb_get_sysreg() to use it as a callback to read those regs.
Add a dummy arm_gdb_set_sysreg().
Signed-off-by: Abdallah Bouassida
---
gdbstub.c| 10 +++
include/qom/cpu.h
follow the same convention.
Signed-off-by: Abdallah Bouassida
Reviewed-by: Peter Maydell
Reviewed-by: Alex Bennée
---
target/arm/helper.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index 799e32
any register we want to remove from the
dynamic XML description.
Signed-off-by: Abdallah Bouassida
Reviewed-by: Peter Maydell
Reviewed-by: Alex Bennée
---
target/arm/cpu.h| 3 ++-
target/arm/helper.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu.h b
The previous version:
http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714
Abdallah Bouassida (3):
target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo
type
target/arm: Add "_S" suffix to the secure version of a sysreg
target/arm:
Hi Alex,
First of all, thanks for the review!
>> +static int arm_gdb_get_sysreg(CPUARMState *env, uint8_t *buf, int reg)
>> +{
>> +ARMCPU *cpu = arm_env_get_cpu(env);
>> +const ARMCPRegInfo *ri;
>> +uint32_t key;
>> +
>> +key = cpu->dyn_xml.cpregs_keys[reg];
>> +ri = get_arm_cp
ping
http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714
follow the same convention.
Signed-off-by: Abdallah Bouassida
Reviewed-by: Peter Maydell
---
target/arm/helper.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index db8c925..1360a14 100644
--- a/
Generate an XML description for the cp-regs.
Register these regs with the gdb_register_coprocessor().
Add arm_gdb_get_sysreg() to use it as a callback to read those regs.
Add a dummy arm_gdb_set_sysreg().
Signed-off-by: Abdallah Bouassida
---
gdbstub.c| 10
include/qom
The previous version:
http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33190
Abdallah Bouassida (3):
target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo
type
target/arm: Add "_S" suffix to the secure version of a sysreg
target/arm:
any register we want to remove from the
dynamic XML description.
Signed-off-by: Abdallah Bouassida
Reviewed-by: Peter Maydell
---
target/arm/cpu.h| 3 ++-
target/arm/helper.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index
This is a callback to set the cp-regs registered by the dynamic XML.
Signed-off-by: Abdallah Bouassida
---
>> Adding to that our customers may need this write access, our tool TRACE32®
>> needs this also in some particular cases. For example: temporary disabling
>> MMU
&
follow the same convention.
Signed-off-by: Abdallah Bouassida
---
target/arm/helper.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index c5d62c8..3b31f71 100644
--- a/target/arm/helper.c
+++ b/
Generate an XML description for the cp-regs.
Register these regs with the gdb_register_coprocessor().
Add arm_gdb_get_sysreg() to use it as a callback to read those regs.
Add a dummy arm_gdb_set_sysreg().
Signed-off-by: Abdallah Bouassida
---
gdbstub.c| 10
include/qom
any register we want to remove from the
dynamic XML description.
Signed-off-by: Abdallah Bouassida
Reviewed-by: Peter Maydell
---
target/arm/cpu.h| 3 ++-
target/arm/helper.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index
The previous version:
http://patchwork.ozlabs.org/project/qemu-devel/list/?series=30973
Abdallah Bouassida (4):
target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo
type
target/arm: Add "_S" suffix to the secure version of a sysreg
target/arm:
Hi Peter,
>> diff --git a/gdbstub.c b/gdbstub.c
>> index f1d5148..ffab30b 100644
>> --- a/gdbstub.c
>> +++ b/gdbstub.c
>> @@ -665,6 +665,9 @@ static const char *get_feature_xml(const char *p, const
>> char **newp,
>> pstrcat(target_xml, sizeof(target_xml), "> pstrcat(targ
Generate an XML description for the cp-regs.
Register these regs with the gdb_register_coprocessor().
Add arm_gdb_get_sysreg() to use it as a callback to read those regs.
Signed-off-by: Abdallah Bouassida
---
gdbstub.c| 7
include/qom/cpu.h| 9 -
target/arm/cpu.c
last review, Thanks a lot ;)
Abdallah Bouassida (4):
target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo
type
target/arm: Add "_S" suffix to the secure version of a sysreg
target/arm: Add the XML dynamic generation
target/arm: Add arm_gdb_set_s
This is a callback to set the cp-regs registered by the dynamic XML.
Signed-off-by: Abdallah Bouassida
---
>> Some of our customers need to connect to Qemu using our tool TRACE32®
>> via GDB,
>> and for some use case they need to have write access to some particular
>>
any register we want to remove from the
dynamic XML description.
Signed-off-by: Abdallah Bouassida
---
target/arm/cpu.h| 3 ++-
target/arm/helper.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 8c839fa..92cfe4c 100644
--- a
follow the same convention.
Signed-off-by: Abdallah Bouassida
---
target/arm/helper.c | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index bdd212f..1594ec45 100644
--- a/target/arm/helper.c
+++ b/
[PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB
This patch offers to GDB the ability to read/write all the coprocessor
registers for ARM and ARM64 by generating dynamically an XML-description for
these registers.
Signed-off-by: Abdallah Bouassida
---
Hi Peter
[PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers
to GDB
This patch offers to GDB the ability to read/write all the coprocessor
registers for ARM and ARM64 by generating dynamically an XML-description for
these registers.
Signed-off-by: Abdallah Bouassida
---
Hi. I
dynamically an
XML-description for
these registers.
Signed-off-by: Abdallah Bouassida
---
Hello Peter,
Thanks for reviewing the previous version of this patch!
http://patchwork.ozlabs.org/patch/861374/
*For the ARM64, should I differentiate the registers that have two views (32
and 64)
Maybe by
.
Signed-off-by: Abdallah Bouassida
---
Hello Peter,
Thanks for reviewing the previous version of this patch!
http://patchwork.ozlabs.org/patch/861374/
*For the ARM64, should I differentiate the registers that have two views (32
and 64)
Maybe by adding in the XML description a "32" t
[PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers
to GDB
This patch offers to GDB the ability to read/write all the coprocessor
registers for ARM and ARM64 by generating dynamically an XML-description for
these registers.
Signed-off-by: Abdallah Bouassida
---
Hello
; tag for the registers name
for the
32bit view and a "64" for the 64bit view.
*How to properly handle the secure and the non secure views?
Signed-off-by: Abdallah Bouassida
---
gdbstub.c | 18 +++
include/qom/cpu.h | 19 +++
target/arm/cpu.c | 5
Oh, I see!
Thanks for the details!
Regards,
Abdallah
Le 6/16/2017 à 3:51 PM, Peter Maydell a écrit :
On 16 June 2017 at 15:42, Abdallah Bouassida
wrote:
Check if the CPU supports AARCH64 before adding the 64bit view of
the coprocessor's register to the cp_regs hashtable.
Signed-o
Check if the CPU supports AARCH64 before adding the 64bit view of
the coprocessor's register to the cp_regs hashtable.
Signed-off-by: Abdallah Bouassida
---
Bug description: if a register has the .state = ARM_CP_STATE_BOTH, its
64bit view will be added to the hashtable even if the CPU i
e to the new XML wrapper,
modify the gdb_num_core_regs to fit the registers number defined in each
XML file.
Signed-off-by: Abdallah Bouassida
---
@Paolo: This patch is in response to your hints here:
https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg03314.html
Thank you for pointing m
ping
http://patchwork.ozlabs.org/patch/709408/
Le 12/28/2016 à 5:34 PM, Abdallah Bouassida a écrit :
[Qemu-devel] [PATCH] target-x86:Add GDB XML register description support
This patch implements XML target description support for X86 and X86-64
architectures in the GDB stub, as the way with
file.
Signed-off-by: Abdallah Bouassida
---
configure | 2 ++
gdb-xml/32bit-core.xml | 65
gdb-xml/64bit-core.xml | 73
++
target/i386/cpu.c | 21 ---
4 files changed,
35 matches
Mail list logo
