Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Akihiko Odaki
On 2025/05/23 23:46, Paolo Abeni wrote: On 5/23/25 1:35 PM, Akihiko Odaki wrote: On 2025/05/23 19:40, Paolo Abeni wrote: On 5/23/25 10:16 AM, Akihiko Odaki wrote: On 2025/05/21 20:34, Paolo Abeni wrote: @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet *n)

Re: [PULL 0/6] Python patches

2025-05-23 Thread Stefan Hajnoczi
On Mon, May 19, 2025 at 1:03 PM John Snow wrote: > > The following changes since commit 757a34115e7491744a63dfc3d291fd1de5297ee2: > > Merge tag 'pull-nvme-20250515' of https://gitlab.com/birkelund/qemu into > staging (2025-05-15 13:42:27 -0400) > > are available in the Git repository at: > >

[PATCH v12 10/10] docs/system: virtio-gpu: Document host/guest requirements

2025-05-23 Thread Dmitry Osipenko
From: Alex Bennée This attempts to tidy up the VirtIO GPU documentation to make the list of requirements clearer. There are still a lot of moving parts and the distros have some catching up to do before this is all handled automatically. Signed-off-by: Alex Bennée Cc: Sergio Lopez Pascual Revi

[PATCH v12 00/10] Support virtio-gpu DRM native context

2025-05-23 Thread Dmitry Osipenko
This patchset adds DRM native context support to VirtIO-GPU on Qemu. Contarary to Virgl and Venus contexts that mediates high level GFX APIs, DRM native context [1] mediates lower level kernel driver UAPI, which reflects in a less CPU overhead and less/simpler code needed to support it. DRM contex

[PATCH v12 08/10] docs/system: virtio-gpu: Add link to Mesa VirGL doc

2025-05-23 Thread Dmitry Osipenko
Extend virtio-gpu documentation with a link to the Mesa VirGL documentation. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gpu.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/devices/vi

[PATCH v12 02/10] ui/sdl2: Implement dpy dmabuf functions

2025-05-23 Thread Dmitry Osipenko
From: Pierre-Eric Pelloux-Prayer If EGL is used, we can rely on dmabuf to import textures without doing copies. To get this working on X11, we use the existing SDL hint: SDL_HINT_VIDEO_X11_FORCE_EGL (because dmabuf can't be used with GLX). Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirki

[PATCH v12 09/10] docs/system: virtio-gpu: Update Venus link

2025-05-23 Thread Dmitry Osipenko
Change virtio-gpu Venus link, pointing it at the Mesa Venus documentation instead of the protocol. The Mesa doc provides more information and also has a link to the protocol. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Signed-off-by: Dmitry Osipenko --- docs/system/devices/virtio-gp

[PATCH v12 07/10] ui/gtk: Don't disable scanout when display is refreshed

2025-05-23 Thread Dmitry Osipenko
Display refreshment is invoked by a timer and it erroneously disables the active scanout if it happens to be invoked after scanout has been enabled. This offending scanout-disable race condition with a timer can be easily hit when Qemu runs with a disabled vsync by using SDL or GTK displays (with v

[PATCH v12 04/10] virtio-gpu: Support asynchronous fencing

2025-05-23 Thread Dmitry Osipenko
Support asynchronous fencing feature of virglrenderer. It allows Qemu to handle fence as soon as it's signalled instead of periodically polling the fence status. This feature is required for enabling DRM context support in Qemu because legacy fencing mode isn't supported for DRM contexts in virglre

[PATCH v12 05/10] virtio-gpu: Support DRM native context

2025-05-23 Thread Dmitry Osipenko
Add support for DRM native contexts to VirtIO-GPU. DRM context is enabled using a new virtio-gpu-gl device option "drm_native_context=on". Unlike Virgl and Venus contexts that operate on application API level, DRM native contexts work on a kernel UAPI level. This lower level results in a lightweig

[PATCH v12 01/10] ui/sdl2: Restore original context after new context creation

2025-05-23 Thread Dmitry Osipenko
SDL API changes GL context to a newly created GL context, which differs from other GL providers that don't switch context. Change SDL backend to restore the original GL context. This allows Qemu's virtio-gpu to support new virglrenderer async-fencing feature for Virgl contexts, otherwise virglrende

[PATCH v12 06/10] ui/sdl2: Don't disable scanout when display is refreshed

2025-05-23 Thread Dmitry Osipenko
Display refreshment is invoked by a timer and it erroneously disables the active scanout if it happens to be invoked after scanout has been enabled. This offending scanout-disable race condition with a timer can be easily hit when Qemu runs with a disabled vsync by using SDL or GTK displays (with v

[PATCH v12 03/10] virtio-gpu: Handle virgl fence creation errors

2025-05-23 Thread Dmitry Osipenko
Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Bennée Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 28 +++- 1 file change

Re: [PATCH] meson: fix Windows build

2025-05-23 Thread Paolo Bonzini
On 5/23/25 21:57, oltolm wrote: The build failed when run on Windows. I replaced calls to Unix programs like `cat` and `true` with calls to `python`. I wrapped calls to `os.path.relpath` in try-except because it can fail when the two paths are on different drives. I made sure to convert the Windo

Re: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-05-23 Thread Nicolin Chen
Hey, Thanks for the reply. Just want to say that I am asking a lot to understand why VT-d is different than ARM, so as to decide whether ARM should follow VT-d implementing a separate listener or just use the VFIO listener. On Fri, May 23, 2025 at 02:22:15PM +0800, Yi Liu wrote: > Hey Nic, > >

[PATCH] x86/cpu: Handle SMM mode in x86_cpu_dump_state for softmmu

2025-05-23 Thread Kirill Martynov
Certain error conditions can trigger x86_cpu_dump_state() to output CPU state debug information e.g. KVM emulation failure due to misbehaving guest. However, if the CPU is in System Management Mode (SMM) when the assertion in cpu_asidx_from_attrs failure happens because: 1. In SMM mode (smm=1), th

[PATCH] meson: fix Windows build

2025-05-23 Thread oltolm
The build failed when run on Windows. I replaced calls to Unix programs like `cat` and `true` with calls to `python`. I wrapped calls to `os.path.relpath` in try-except because it can fail when the two paths are on different drives. I made sure to convert the Windows paths to Unix paths to prevent

Re: [PATCH v2 25/25] docs/system/s390x: Add secure IPL documentation

2025-05-23 Thread Collin Walling
On 5/21/25 8:37 AM, Thomas Huth wrote: > On 09/05/2025 00.50, Zhuoying Cai wrote: >> Add documentation for secure IPL. >> >> Signed-off-by: Collin Walling >> Signed-off-by: Zhuoying Cai >> --- >> docs/system/s390x/secure-ipl.rst | 249 +++ >> 1 file changed, 249 ins

Re: [PATCH V3 29/42] backends/iommufd: change process ioctl

2025-05-23 Thread Steven Sistare
On 5/23/2025 10:56 AM, Steven Sistare wrote: On 5/23/2025 4:56 AM, Duan, Zhenzhong wrote: -Original Message- From: Steven Sistare Subject: Re: [PATCH V3 29/42] backends/iommufd: change process ioctl On 5/21/2025 11:19 PM, Duan, Zhenzhong wrote: -Original Message- From: Steven

Re: [PULL 0/6] Python patches

2025-05-23 Thread Stefan Hajnoczi
On Fri, May 23, 2025 at 1:40 PM John Snow wrote: > On Tue, May 20, 2025 at 9:38 AM Stefan Hajnoczi wrote: >> >> Applied, thanks. >> >> Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any >> user-visible changes. > > > Did these get dropped? I don't see them in origin/mast

Re: [PATCH] qcow2: Forbid use of protocol: prefix on data_file

2025-05-23 Thread Eric Blake
On Fri, May 23, 2025 at 01:20:32PM -0500, Eric Blake wrote: > Ever since CVE-2024-4467 (see commit 7ead9469 in qemu v9.1.0), we have > intentionally treated command-line arguments as local files, and not > protocol specifications (you have to specify backing files with > full-blown QMP if it is int

[PATCH v3 3/4] qapi: remove trivial "Returns:" sections

2025-05-23 Thread John Snow
The new qapidoc transmogrifier can generate "Returns" statements with type information just fine, so we can remove it from the source where it doesn't add anything particularly novel or helpful and just repeats the type info. This patch does not touch Returns: lines that add some information (pote

[PATCH v3 4/4] qapi: rephrase return docs to avoid type name

2025-05-23 Thread John Snow
Well, I tried. Maybe not very hard. Sorry! Signed-off-by: John Snow --- qapi/block-core.json | 6 +++--- qapi/block-export.json | 2 +- qapi/block.json | 2 +- qapi/control.json| 5 ++--- qapi/dump.json | 5 ++--- qapi/introspect.json | 6 +++--- qapi/job.jso

[PATCH v3 2/4] docs, qapi: generate undocumented return sections

2025-05-23 Thread John Snow
This patch changes the qapidoc transmogrifier to generate Return value documentation for any command that has a return value but hasn't explicitly documented that return value. Signed-off-by: John Snow --- docs/sphinx/qapidoc.py | 14 -- scripts/qapi/parser.py | 15 +++ s

Re: [PATCH v2 03/24] block/snapshot: move drain outside of read-locked bdrv_snapshot_delete()

2025-05-23 Thread Andrey Drobyshev
On 5/20/25 1:29 PM, Fiona Ebner wrote: > This is in preparation to mark bdrv_drained_begin() as GRAPH_UNLOCKED. > > More granular draining is not trivially possible, because > bdrv_snapshot_delete() can recursively call itself. > > The return value of bdrv_all_delete_snapshot() changes from -1 to

[PATCH v3 1/4] docs/qapi-domain: add return-nodesc

2025-05-23 Thread John Snow
This form is used to annotate a return type without an accompanying description, for when there is no "Returns:" information in the source doc, but we have a return type we want to generate a cross-reference to. The syntax is: :return-nodesc: TypeName It's primarily necessary because Sphinx alwa

[PATCH v3 0/4] qapi: add auto-generated return docs

2025-05-23 Thread John Snow
v3: rebased on top of python-qapi-linting (v4) pull request; removed commits that are no longer needed. Markus: I forget where we left off... shall we refresh? v2: fix multi-return-sections bug :( John Snow (4): docs/qapi-domain: add return-nodesc docs, qapi: generate undocumented ret

[PATCH] qcow2: Forbid use of protocol: prefix on data_file

2025-05-23 Thread Eric Blake
Ever since CVE-2024-4467 (see commit 7ead9469 in qemu v9.1.0), we have intentionally treated command-line arguments as local files, and not protocol specifications (you have to specify backing files with full-blown QMP if it is intentional to access something more complicated). However, that patch

[PATCH 1/1] docs/qapi-domain: Improve QAPI indices

2025-05-23 Thread John Snow
This patch changes the "by type" categorization in favor of using sub-categories of a literal "By type" category instead. A new "By module" categorization is also added that follows a similar pattern. Alphabetical sorting has been improved and will sort in a case insensitive manner for all categor

[PATCH 0/1] Sphinx: refactor QAPI indices

2025-05-23 Thread John Snow
RFC quality - what do we think about this style of index vs the one we currently have? John Snow (1): docs/qapi-domain: Improve QAPI indices docs/sphinx/qapi_domain.py | 51 +++--- 1 file changed, 37 insertions(+), 14 deletions(-) -- 2.48.1

Re: [PATCH V3 33/42] vfio/iommufd: define hwpt constructors

2025-05-23 Thread Steven Sistare
On 5/19/2025 11:55 AM, Steven Sistare wrote: On 5/16/2025 4:55 AM, Duan, Zhenzhong wrote: -Original Message- From: Steve Sistare Subject: [PATCH V3 33/42] vfio/iommufd: define hwpt constructors Extract hwpt creation code from iommufd_cdev_autodomains_get into the helpers iommufd_cdev_u

Re: [PULL 0/6] Python patches

2025-05-23 Thread John Snow
On Tue, May 20, 2025 at 9:38 AM Stefan Hajnoczi wrote: > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for > any user-visible changes. > Did these get dropped? I don't see them in origin/master. --js

Re: [PATCH v2 07/24] block: mark bdrv_child_change_aio_context() GRAPH_RDLOCK

2025-05-23 Thread Andrey Drobyshev
On 5/20/25 1:29 PM, Fiona Ebner wrote: > This is a small step in preparation to mark bdrv_drained_begin() as > GRAPH_UNLOCKED. More concretely, it is in preparatoin to move the > drain out of bdrv_change_aio_context() and marking that function as > GRAPH_RDLOCK. > > Signed-off-by: Fiona Ebner > -

Re: [PATCH v2 19/24] block: mark bdrv_drained_begin() as GRAPH_UNLOCKED

2025-05-23 Thread Andrey Drobyshev
On 5/20/25 1:30 PM, Fiona Ebner wrote: > bdrv_drained_begin() polls and is not allowed to be called with the > block graph lock held. Mark the function as such. > > Suggested-by: Kevin Wolf > Signed-off-by: Fiona Ebner > --- > > No changes in v2, but ordered differently (in particular, it avoid

Re: [PATCH v2 2/3] iotests: Improve mirror-sparse on ext4

2025-05-23 Thread Eric Blake
On Fri, May 23, 2025 at 11:27:22AM -0500, Eric Blake wrote: > Fiona reported that an ext4 filesystem on top of LVM can sometimes > report over-allocation to du (based on the hueristics the filesystem and despite my other edits, I still missed fixing my typo on heuristics > is making while observi

Re: [RFC PATCH 12/25] accel/mshv: Add vCPU creation and execution loop

2025-05-23 Thread Wei Liu
On Tue, May 20, 2025 at 03:54:57PM +0200, Paolo Bonzini wrote: > On 5/20/25 15:50, Paolo Bonzini wrote: > > You need support in the hypervisor for this: KVM and HVF both have it. > > > > There are two ways to do it > > Sorry - I left out the other way which is to pass something *into* > MSHV_RUN_

Re: [EXTERNAL] [PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-23 Thread David Woodhouse
On Fri, 2025-05-23 at 16:01 +, Liam Merwick wrote: > When the '--enable-trace-backends=syslog' build option is configured, > the following compilation error is encountered. > > In file included from /usr/include/sys/syslog.h:207, > from /usr/include/syslog.h:1, >  

[PATCH v2 2/3] iotests: Improve mirror-sparse on ext4

2025-05-23 Thread Eric Blake
Fiona reported that an ext4 filesystem on top of LVM can sometimes report over-allocation to du (based on the hueristics the filesystem is making while observing the contents being mirrored); even though the contents and actual size matched, about 50% of the time the size reported by disk_usage was

[PATCH v2 3/3] iotests: Filter out ZFS in several tests

2025-05-23 Thread Eric Blake
Fiona reported that ZFS makes sparse file testing awkward, since: - it has asynchronous allocation (not even 'fsync $file' makes du see the desired size; it takes the slower 'fsync -f $file' which is not appropriate for the tests) - for tests of fully allocated files, ZFS with compression enabl

[PATCH v2 0/3] iotests improvements for mirror-sparse and others

2025-05-23 Thread Eric Blake
v1 was here: https://lists.gnu.org/archive/html/qemu-devel/2025-05/msg05449.html Since then - add more patches - don't try sync; that wasn't enough for ZFS I don't have ZFS locally, so patch 3 WILL need to be tested there (but I did test that the skip mechanism works on ext4 when I intentionall

[PATCH v2 1/3] iotests: Use disk_usage in more places

2025-05-23 Thread Eric Blake
Commit be9bac07 added a utility disk_usage function, but there are a couple of other tests that could also use it. Signed-off-by: Eric Blake --- tests/qemu-iotests/125 | 2 +- tests/qemu-iotests/308 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/125 b

[RFC PATCH v11 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-23 Thread Rorie Reyes
Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 12 +++

Re: [RFC PATCH 08/25] accel/mshv: Initialize VM partition

2025-05-23 Thread Magnus Kulke
On Fri, May 23, 2025 at 03:37:02PM +, Wei Liu wrote: > On Fri, May 23, 2025 at 10:23:58AM +0200, Magnus Kulke wrote: > > On Tue, May 20, 2025 at 07:07:06PM +, Wei Liu wrote: > > > On Tue, May 20, 2025 at 01:30:01PM +0200, Magnus Kulke wrote: > > > > Create the MSHV virtual machine by openin

[RFC PATCH v11 1/4] hw/vfio/ap: notification handler for AP config changed event

2025-05-23 Thread Rorie Reyes
Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak --- hw/vfio/ap.c | 31 +++ 1 file cha

[RFC PATCH v11 4/4] s390: implementing CHSC SEI for AP config change

2025-05-23 Thread Rorie Reyes
Handle interception of the CHSC SEI instruction for requests indicating the guest's AP configuration has changed. If configuring --without-default-devices, hw/s390x/ap-stub.c was created to handle such circumstance. Also added the following to hw/s390x/meson.build if CONFIG_VFIO_AP is false, it wi

[RFC PATCH v11 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-23 Thread Rorie Reyes
These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 53 inc

[RFC PATCH v11 0/4] Report vfio-ap configuration changes

2025-05-23 Thread Rorie Reyes
Changelog: v11: - reverted return type to int for 'ap_chsc_sei_nt0_get_event' - files reflected are 'ap.c', 'ap-bridge'h, and 'ap-stub.c' - using defined variables to represent return 0 and 1 to reflect logical sense - update documentation for 'ap_chsc_sei_nt0_get_event' to reflect return types

[PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-23 Thread Liam Merwick
When the '--enable-trace-backends=syslog' build option is configured, the following compilation error is encountered. In file included from /usr/include/sys/syslog.h:207, from /usr/include/syslog.h:1, from ./trace/trace-hw_xen.h:224, from ../hw/xe

Re: [PULL 0/5] Block layer patches

2025-05-23 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/23] Misc VNC, I/O, Crypto & checkpatch fixes

2025-05-23 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [RFC PATCH 08/25] accel/mshv: Initialize VM partition

2025-05-23 Thread Wei Liu
On Fri, May 23, 2025 at 10:23:58AM +0200, Magnus Kulke wrote: > On Tue, May 20, 2025 at 07:07:06PM +, Wei Liu wrote: > > On Tue, May 20, 2025 at 01:30:01PM +0200, Magnus Kulke wrote: > > > Create the MSHV virtual machine by opening a partition and issuing > > > the necessary ioctl to initialize

[PATCH 3/3] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources

2025-05-23 Thread Bernhard Beschow
From: Bernhard Beschow Rather than accessing the attributes of TYPE_CCSR directly, use the SysBusDevice API which exists exactly for that purpose. Furthermore, registering the memory region with the SysBusDevice API makes it show up in QMP's `info qom-tree` command. Signed-off-by: Bernhard Besch

Re: [PATCH 3/3] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources

2025-05-23 Thread BALATON Zoltan
On Fri, 23 May 2025, Bernhard Beschow wrote: From: Bernhard Beschow This was meant to be only here but somehow it alse overwrote the ream From that should have been my address. Sorry for that, but patch is still correct. Regards, BALATON Zoltan Rather than accessing the attributes of TYP

[PATCH 0/3] Misc ppc/e500 patches

2025-05-23 Thread BALATON Zoltan
Some small patches to e500 related parts. Also includes a patch from Bernhard that is rebased on current version. Regards, BALATON Zoltan BALATON Zoltan (2): hw/ppc/e500: Move clock and TB frequency to machine class hw/net/fsl_etsec: Set default MAC address Bernhard Beschow (1): hw/ppc/e50

[PATCH 2/3] hw/net/fsl_etsec: Set default MAC address

2025-05-23 Thread BALATON Zoltan
Use default MAC address if none is specified by property as done by most other network interface models. Signed-off-by: BALATON Zoltan --- hw/net/fsl_etsec/etsec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index d14cb2a101..846f6cbc5d

[PATCH 1/3] hw/ppc/e500: Move clock and TB frequency to machine class

2025-05-23 Thread BALATON Zoltan
Different machines have different frequencies so make this configurable in machine class instead of using a hard coded constant. Signed-off-by: BALATON Zoltan --- hw/ppc/e500.c | 18 +- hw/ppc/e500.h | 4 hw/ppc/e500plat.c | 2 ++ hw/ppc/mpc8544ds.c | 2 ++ 4 f

Re: [PATCH V3 29/42] backends/iommufd: change process ioctl

2025-05-23 Thread Steven Sistare
On 5/23/2025 4:56 AM, Duan, Zhenzhong wrote: -Original Message- From: Steven Sistare Subject: Re: [PATCH V3 29/42] backends/iommufd: change process ioctl On 5/21/2025 11:19 PM, Duan, Zhenzhong wrote: -Original Message- From: Steven Sistare Subject: Re: [PATCH V3 29/42] backend

Re: [PATCH] vfio/container: pass MemoryRegion to DMA operations

2025-05-23 Thread Steven Sistare
On 5/23/2025 2:24 AM, Cédric Le Goater wrote: On 5/22/25 19:30, Steven Sistare wrote: On 5/22/2025 1:20 PM, Cédric Le Goater wrote: On 5/21/25 23:55, John Levon wrote: Pass through the MemoryRegion to DMA operation handlers of vfio containers. The vfio-user container will need this later, to t

Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Paolo Abeni
On 5/23/25 1:35 PM, Akihiko Odaki wrote: > On 2025/05/23 19:40, Paolo Abeni wrote: >> On 5/23/25 10:16 AM, Akihiko Odaki wrote: >>> On 2025/05/21 20:34, Paolo Abeni wrote: @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet *n) .ufo = !!(n->curr_gue

Re: [RFC PATCH 09/25] accel/mshv: Register guest memory regions with hypervisor

2025-05-23 Thread Magnus Kulke
On Tue, May 20, 2025 at 08:07:27PM +, Wei Liu wrote: > On Tue, May 20, 2025 at 01:30:02PM +0200, Magnus Kulke wrote: > > Handle region_add events by invoking the MSHV memory registration > > +return set_guest_memory(vm_fd, ®ion); > > +} > > + > > +region.flags = (1 << MSHV_SET_M

Re: [RFC PATCH v10 4/4] s390: implementing CHSC SEI for AP config change

2025-05-23 Thread Rorie Reyes
diff --git a/hw/s390x/ap-stub.c b/hw/s390x/ap-stub.c new file mode 100644 index 00..e2dacff959 --- /dev/null +++ b/hw/s390x/ap-stub.c @@ -0,0 +1,25 @@ +/* + * VFIO based AP matrix device assignment + * + * Copyright 2025 IBM Corp. + * Author(s): Rorie Reyes + * + * SPDX-License-Identifier

Re: [RFC PATCH 07/13] migration: Introduce new MigrationConfig structure

2025-05-23 Thread Fabiano Rosas
Markus Armbruster writes: Markus, sorry for the delay here. I had vacations and holidays, plus a pile of patches to review. > Fabiano Rosas writes: > >> Add a new migration structure to consolidate the capabilities and >> parameters. This structure will be used in place of the s->parameters >>

Re: [RFC PATCH v10 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-23 Thread Rorie Reyes
@@ -96,6 +99,49 @@ static void vfio_ap_cfg_chg_notifier_handler(void *opaque)     }   +bool ap_chsc_sei_nt0_get_event(void *res) +{ +    ChscSeiNt0Res *nt0_res  = (ChscSeiNt0Res *)res; +    APConfigChgEvent *cfg_chg_event; + +    qemu_mutex_lock(&cfg_chg_events_lock); + +    if (!ap_chsc_sei_nt0_

RE: [PATCH v3 00/10] kvm/arm: Introduce a customizable aarch64 KVM host model

2025-05-23 Thread Shameerali Kolothum Thodi via
Hi, > -Original Message- > From: Cornelia Huck > Sent: Monday, April 14, 2025 5:39 PM > To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- > de...@nongnu.org; qemu-...@nongnu.org; kvm...@lists.linux.dev; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > alex.ben...@linar

Re: [PATCH WIP RFC] rust: add qdev DeviceProperties derive macro

2025-05-23 Thread Paolo Bonzini
Il gio 22 mag 2025, 10:12 Manos Pitsidianakis < manos.pitsidiana...@linaro.org> ha scritto: > This is unnecessary though, because once we have the > const_refs_to_static feature we can introduce a QdevProp trait that > returns a reference to a type's qdev_prop_* global variable. We cannot > do thi

Re: [RFC PATCH v10 4/4] s390: implementing CHSC SEI for AP config change

2025-05-23 Thread Anthony Krowiak
On 5/23/25 12:47 AM, Rorie Reyes wrote: Handle interception of the CHSC SEI instruction for requests indicating the guest's AP configuration has changed. If configuring --without-default-devices, hw/s390x/ap-stub.c was created to handle such circumstance. Also added the following to hw/s390x

Re: [RFC PATCH v10 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-23 Thread Anthony Krowiak
On 5/23/25 12:47 AM, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-23 Thread Eric Blake
On Fri, May 23, 2025 at 02:03:14PM +0300, Andrey Drobyshev wrote: > >> I agree with Markus that this setting value different from what's been > >> directly requested by user shouldn't go silent. Having some kind of > >> warning at the very least would be nice. > > > > Okay, I'll make sure to warn

[PATCH v5 3/4] hw/acpi/aml-build: Build a root node in the PPTT table

2025-05-23 Thread Alireza Sanaee via
Currently we build the PPTT starting from the socket node and each socket will be a separate tree. For a multi-socket system it'll be hard for the OS to know the whole system is homogeneous or not (actually we're in the current implementation) since no parent node to telling the identical implement

Re: [PATCH RFC 00/16] virtio: introduce support for GSO over UDP tunnel

2025-05-23 Thread Akihiko Odaki
On 2025/05/23 18:43, Paolo Abeni wrote: On 5/23/25 9:19 AM, Akihiko Odaki wrote: On 2025/05/21 20:33, Paolo Abeni wrote: Some virtualized deployments use UDP tunnel pervasively and are impacted negatively by the lack of GSO support for such kind of traffic in the virtual NIC driver. The virtio

RE: [PATCH V3 29/42] backends/iommufd: change process ioctl

2025-05-23 Thread Duan, Zhenzhong
>-Original Message- >From: Steven Sistare >Subject: Re: [PATCH V3 29/42] backends/iommufd: change process ioctl > >On 5/21/2025 11:19 PM, Duan, Zhenzhong wrote: >>> -Original Message- >>> From: Steven Sistare >>> Subject: Re: [PATCH V3 29/42] backends/iommufd: change process ioc

[PATCH] tests/qtest: Remove migration-helpers.c

2025-05-23 Thread Fabiano Rosas
Commit 407bc4bf90 ("qapi: Move include/qapi/qmp/ to include/qobject/") brought the migration-helpers.c back by mistake. This file has been replaced with migration/migration-qmp.c and migration/migration-util.c. Fixes: 407bc4bf90 ("qapi: Move include/qapi/qmp/ to include/qobject/") Signed-off-by: F

Re: [PATCH v4 1/4] hw/s390x: add SCLP event type CPI

2025-05-23 Thread Hendrik Brueckner
On Tue, May 06, 2025 at 02:16:18PM +0200, Shalini Chellathurai Saroja wrote: > On 2025-05-06 09:48, Thomas Huth wrote: > > On 06/05/2025 08.48, Nina Schoetterl-Glausch wrote: > > > On Mon, 2025-05-05 at 08:55 +0200, Shalini Chellathurai Saroja wrote: > > > > On 2025-04-28 11:22, Janis Schoetterl-Gl

Re: [PATCH RFC 00/16] virtio: introduce support for GSO over UDP tunnel

2025-05-23 Thread Paolo Abeni
On 5/23/25 9:19 AM, Akihiko Odaki wrote: > On 2025/05/21 20:33, Paolo Abeni wrote: >> Some virtualized deployments use UDP tunnel pervasively and are impacted >> negatively by the lack of GSO support for such kind of traffic in the >> virtual NIC driver. >> >> The virtio_net specification recently

[PATCH v2 2/3] hw/arm/stm32f100: Add DMA support for stm32f100

2025-05-23 Thread Nikita Shubin
From: Nikita Shubin Add STM32 DMA support for stm32f100 SoC. Signals from periphery to DMA are not connected, as no STM32 periphery currently supports DMA. Signed-off-by: Nikita Shubin --- hw/arm/Kconfig | 1 + hw/arm/stm32f100_soc.c | 51 +

[PATCH v2 1/3] hw/dma: Add STM32 platfrom DMA controller emulation

2025-05-23 Thread Nikita Shubin
From: Nikita Shubin STMicroelectronics STM32 SoCs integrate DMA engine that supports: * Independent concurrent DMA transfers using 7/5 DMA channels * Generation of interrupts on various conditions during execution * PERIPH to MEMORY transactions, invoked by peripheral device models * MEMORY to M

[PATCH v2 0/3] Add STM32 DMA model

2025-05-23 Thread Nikita Shubin
From: Nikita Shubin Add STM32 DMA model and include it in STM32F100 SoC. The model is fully compatible with GD32F303x DMA. To: qemu-devel@nongnu.org Cc: Paolo Bonzini Cc: Alistair Francis Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: Alexandre Iooss Cc: Fabiano Rosas Cc: Laurent Vivier Cc

[PATCH v2 3/3] tests/qtest: add qtests for STM32 DMA

2025-05-23 Thread Nikita Shubin
From: Nikita Shubin Signed-off-by: Nikita Shubin --- tests/qtest/meson.build | 1 + tests/qtest/stm32-dma-test.c | 421 +++ 2 files changed, 422 insertions(+) create mode 100644 tests/qtest/stm32-dma-test.c diff --git a/tests/qtest/meson.build b/tests/qt

Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Akihiko Odaki
On 2025/05/23 19:40, Paolo Abeni wrote: On 5/23/25 10:16 AM, Akihiko Odaki wrote: On 2025/05/21 20:34, Paolo Abeni wrote: @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet *n) .ufo = !!(n->curr_guest_offloads & (1ULL << VIRTIO_NET_F_GUEST_UFO)), .us

Re: [PATCH RFC 12/16] virtio-net: implement extended features support.

2025-05-23 Thread Paolo Abeni
On 5/23/25 10:09 AM, Akihiko Odaki wrote: > On 2025/05/21 20:34, Paolo Abeni wrote: >> Use the extended types and helpers to manipulate the virtio_net >> features. >> >> Note that offloads are still 64bits wide, as per specification, >> and extended offloads will be mapped into such range. >> >> Si

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-23 Thread Andrey Drobyshev
On 5/22/25 9:44 PM, Eric Blake wrote: > On Thu, May 22, 2025 at 08:38:34PM +0300, Andrey Drobyshev wrote: >> On 4/28/25 9:46 PM, Eric Blake wrote: >>> From: "Richard W.M. Jones" >>> >>> Add multi-conn option to the NBD client. This commit just adds the >>> option, it is not functional. >>> >>> Se

Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Paolo Abeni
On 5/23/25 12:54 PM, Akihiko Odaki wrote: > On 2025/05/23 19:40, Paolo Abeni wrote: >> On 5/23/25 10:16 AM, Akihiko Odaki wrote: >>> On 2025/05/21 20:34, Paolo Abeni wrote: @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet *n) .ufo = !!(n->curr_gu

Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Paolo Abeni
On 5/23/25 10:16 AM, Akihiko Odaki wrote: > On 2025/05/21 20:34, Paolo Abeni wrote: >> @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet >> *n) >> .ufo = !!(n->curr_guest_offloads & (1ULL << >> VIRTIO_NET_F_GUEST_UFO)), >> .uso4 = !!(n->curr_guest_offlo

Re: [PATCH RFC 15/16] net: implement tnl feature offloading

2025-05-23 Thread Akihiko Odaki
On 2025/05/23 19:40, Paolo Abeni wrote: On 5/23/25 10:16 AM, Akihiko Odaki wrote: On 2025/05/21 20:34, Paolo Abeni wrote: @@ -890,6 +915,12 @@ static void virtio_net_apply_guest_offloads(VirtIONet *n) .ufo = !!(n->curr_guest_offloads & (1ULL << VIRTIO_NET_F_GUEST_UFO)), .us

Re: [PATCH v5 0/6] hw/arm/aspeed_ast2700-fc: Fix null pointer dereference

2025-05-23 Thread Cédric Le Goater
On 5/23/25 11:31, Steven Lee wrote: Clang's sanitizer reports a runtime error when booting with '-net nic -net user', due to a null pointer being passed to memory_region_find(), which subsequently triggers a crash in flatview_lookup(). Root cause: - Missing NIC configuration in the CA35 initiali

Re: [PATCH v5 1/6] hw/arm/aspeed_ast2700-fc: Add network support

2025-05-23 Thread Cédric Le Goater
On 5/23/25 11:31, Steven Lee wrote: This patch adds network support to the ast2700fc machine by initializing the NIC device in the ca35. Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed_ast27x0-fc.c | 7 +++ 1 file changed, 7 insertions(+) di

Re: [PATCH RFC 13/16] net: implement tunnel probing

2025-05-23 Thread Akihiko Odaki
On 2025/05/23 19:24, Paolo Abeni wrote: On 5/23/25 9:39 AM, Akihiko Odaki wrote: diff --git a/net/tap-linux.c b/net/tap-linux.c index 22ec2f45d2..2df601551e 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -37,6 +37,14 @@ #define PATH_NET_TUN "/dev/net/tun" +#ifndef TUN_F_UDP_TUN

[PATCH v5 4/4] tests: virt: Update expected ACPI tables for virt test

2025-05-23 Thread Alireza Sanaee via
Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h. The disassembled differences between actual and expected PPTT shows below. Only about the root node adding and identification flag set as expected. /* * Intel ACPI Component Architecture

Re: [PATCH RFC 01/16] linux-headers: Update to Linux v6.15-rc net-next

2025-05-23 Thread Akihiko Odaki
On 2025/05/21 20:33, Paolo Abeni wrote: Update headers to include the virtio GSO over UDP tunnel features Signed-off-by: Paolo Abeni --- The relevant bits are not yet merged upstream, will update this patch after merge. --- include/standard-headers/asm-x86/setup_data.h | 4 +- include/stan

[PATCH v5 2/4] hw/acpi/aml-build: Set identical implementation flag for PPTT processor nodes

2025-05-23 Thread Alireza Sanaee via
From: Yicong Yang Per ACPI 6.5 Table 5.158: Processor Structure Flags, the identical implementation flag indicates whether all the children processors of this node share the same identical implementation revision. Currently Linux support parsing this field [1] and maybe used to identify the heter

[PATCH v5 1/4] tests: virt: Allow changes to PPTT test table

2025-05-23 Thread Alireza Sanaee via
From: Yicong Yang Allow changes to PPTT test table, preparing for adding identical implementation flags support and for adding a root node for all the system. Signed-off-by: Yicong Yang Reviewed-by: Jonathan Cameron Signed-off-by: Alireza Sanaee --- tests/qtest/bios-tables-test-allowed-diff.

[PATCH v5 0/4] Building PPTT with root node and identical implementation flag

2025-05-23 Thread Alireza Sanaee via
OS like Linux is using PPTT processor node's identical implementation flag [1] to infer whether the whole system or a certain CPU cluster is homogeneous or not [2]. QEMU currently only support building homogeneous system, set the flag to indicate the fact. Build a root node in PPTT for indicates th

Re: [PATCH RFC 13/16] net: implement tunnel probing

2025-05-23 Thread Paolo Abeni
On 5/23/25 9:39 AM, Akihiko Odaki wrote: >> diff --git a/net/tap-linux.c b/net/tap-linux.c >> index 22ec2f45d2..2df601551e 100644 >> --- a/net/tap-linux.c >> +++ b/net/tap-linux.c >> @@ -37,6 +37,14 @@ >> >> #define PATH_NET_TUN "/dev/net/tun" >> >> +#ifndef TUN_F_UDP_TUNNEL_GSO >> +#define

Re: [PATCH RFC 12/16] virtio-net: implement extended features support.

2025-05-23 Thread Akihiko Odaki
On 2025/05/23 19:01, Paolo Abeni wrote: On 5/23/25 10:09 AM, Akihiko Odaki wrote: On 2025/05/21 20:34, Paolo Abeni wrote: Use the extended types and helpers to manipulate the virtio_net features. Note that offloads are still 64bits wide, as per specification, and extended offloads will be mapp

Re: [PATCH RFC 01/16] linux-headers: Update to Linux v6.15-rc net-next

2025-05-23 Thread Paolo Abeni
On 5/23/25 11:50 AM, Akihiko Odaki wrote: > On 2025/05/21 20:33, Paolo Abeni wrote: >> @@ -235,4 +235,12 @@ >>*/ >> #define VHOST_VDPA_GET_VRING_SIZE _IOWR(VHOST_VIRTIO, 0x82, \ >>struct vhost_vring_state) >> + >> +/* Extended features manipu

Re: [PATCH RFC 07/16] virtio-pci: implement support for extended features.

2025-05-23 Thread Paolo Abeni
On 5/23/25 9:23 AM, Akihiko Odaki wrote: >> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c >> index 0fa8fe4955..7815ef2d9b 100644 >> --- a/hw/virtio/virtio-pci.c >> +++ b/hw/virtio/virtio-pci.c >> @@ -123,7 +123,8 @@ static const VMStateDescription >> vmstate_virtio_pci_modern_state_

[PATCH] hw/intc/loongarch_extioi: Move unrealize function to common code

2025-05-23 Thread Bibo Mao
Memory about LoongArchExtIOICommonState::cpu is allocated in common code, it had better be freed in common code also. Signed-off-by: Bibo Mao --- hw/intc/loongarch_extioi.c| 9 - hw/intc/loongarch_extioi_common.c | 9 + include/hw/intc/loongarch_extioi.h

[PATCH v5 4/6] hw/arm/aspeed_ast27x0-fc: Map ca35 memory into system memory

2025-05-23 Thread Steven Lee via
Map the CA35 memory region as a subregion of system_memory to ensure a valid FlatView. This prevents failures in APIs that rely on the global memory view, such as rom_check_and_register_reset(). Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/arm/aspeed_ast27x0-fc.c | 1 + 1 file

[PATCH v5 1/6] hw/arm/aspeed_ast2700-fc: Add network support

2025-05-23 Thread Steven Lee via
This patch adds network support to the ast2700fc machine by initializing the NIC device in the ca35. Signed-off-by: Steven Lee --- hw/arm/aspeed_ast27x0-fc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/aspeed_ast27x0-fc.c b/hw/arm/aspeed_ast27x0-fc.c index 125a3ade40..7bf4f

[PATCH v5 3/6] hw/arm/aspeed_ast27x0: Fix unimplemented region overlap with vbootrom

2025-05-23 Thread Steven Lee via
The unimplemented memory region overlaps with the VBootROM address range, causing incorrect memory layout. This patch adjusts the size and start address of the unimplemented region to avoid collision. The IO memory region (ASPEED_DEV_IOMEM) is now moved to 0x2 to reserve space for VBootROM at

  1   2   >