Re: [RFC PATCH 09/25] accel/mshv: Register guest memory regions with hypervisor

[Magnus Kulke]

On Tue, May 20, 2025 at 08:07:27PM +0000, Wei Liu wrote:
> On Tue, May 20, 2025 at 01:30:02PM +0200, Magnus Kulke wrote:
> > Handle region_add events by invoking the MSHV memory registration
> > +        return set_guest_memory(vm_fd, &region);
> > +    }
> > +
> > +    region.flags = (1 << MSHV_SET_MEM_BIT_EXECUTABLE);
> 
> Should this be always set? Is there a way to get more information from
> the caller or QEMU's core memory region management logic?
> 

HVF always sets the bit and as far as I can tell KVM doesn't have a
KVM_MEM_EXECUTE flag, so it's implied.

Still, there might be some criteria to determine whether a region is
executable or not, I'll look further into that.