There are two pointers that are needed during error injection:
1. The start address of the CPER block to be stored;
2. The address of the read ack.
It is preferable to calculate them from the HEST table. This allows
checking the source ID, the size of the table and the type of the
HEST error blo
On 5/13/25 13:38, Anthony Krowiak wrote:
On 5/12/25 2:02 PM, Rorie Reyes wrote:
Handle interception of the CHSC SEI instruction for requests
indicating the guest's AP configuration has changed.
If configuring --without-default-devices, hw/s390x/ap-stub.c
was created to handle such circumstan
The GHES migration logic should now support HEST table location too.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/generic_event_device.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/acpi/gener
The ghes_record_cper_errors() function was introduced to be used
by other types of errors, as part of the error injection
patch series. That's why it is not static.
Make it non-static again to allow its usage outside ghes.c
This reverts commit 611f3bdb20f7828b0813aa90d47d1275ef18329b.
Signed-off
Such file will be used to track HEST table changes.
For now, disallow HEST table check until we update it to the
current data.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
tests/data/acpi/aarch64/virt/HEST | 0
tests/qtest/bios-table
Em Sun, 11 May 2025 09:45:55 -0400
"Michael S. Tsirkin" escreveu:
> On Sun, May 11, 2025 at 09:45:04AM -0400, Michael S. Tsirkin wrote:
> > On Fri, Mar 07, 2025 at 08:14:29PM +0100, Mauro Carvalho Chehab wrote:
> > > Hi Michael,
> > >
> > > I'm sending v8 to avoid a merge conflict with v7 due
Adds a generic error device to handle generic hardware error
events as specified at ACPI 6.5 specification at 18.3.2.7.2:
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources
using HID PNP0C33.
The PNP0C33 device is used to report hardware
Using the QMP GHESv2 API requires preparing a raw data array
containing a CPER record.
Add a helper script with subcommands to prepare such data.
Currently, only ARM Processor error CPER record is supported, by
using:
$ ghes_inject.py arm
which produces those warnings on Linux:
[ 705.0
While the HEST layout didn't change, there are some internal
changes related to how offsets are calculated and how memory error
events are triggered.
Update specs to reflect such changes.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
docs/sp
Add a new ags flag to change the way HEST offsets are calculated.
Currently, offsets needed to store ACPI HEST offsets and read ack
are calculated based on a previous knowledge from the logic
which creates the HEST table.
Such logic is not generic, not allowing to easily add more HEST
entries nor
On 5/19/25 15:26, Steve Sistare wrote:
Modify memory_get_xlat_addr and vfio_get_xlat_addr to return the memory
region that the translated address is found in. This will be needed by
CPR in a subsequent patch to map blocks using IOMMU_IOAS_MAP_FILE.
Also return the xlat offset, so we can simplif
@@ -1,39 +1,39 @@
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20240322 (64-bit version)
* Copyright (c) 2000 - 2023 Intel Corporation
*
- * Disassembly of tests/data/acpi/aarch64/virt/HEST
+ * Disassembly of /tmp/aml-DMPE22
*
* ACPI Data Table [HEST]
*
*
Move the check logic into a common function and simplify the
code which checks if GHES is enabled and was properly setup.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes-stub.c| 7 ---
hw/acpi/ghes.c | 38 +
The current code is actually dependent on having just one error
structure with a single source, as any change there would cause
migration issues.
As the number of sources should be arch-dependent, as it will depend on
what kind of notifications will exist, and how many errors can be
reported at th
Now that HEST table is checked for aarch64, add the current
firmware file.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
tests/data/acpi/aarch64/virt/HEST | Bin 0 -> 132 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 1 -
2 fil
Currently, aarch64 can generate a HEST table when loaded with
-machine ras=on. Add support for it.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
tests/qtest/bios-tables-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi Michael,
This is v9 of the patch series, rebased to apply after release
10.0. It addresses 3 issues:
- backward compatibility logic moved to version 10.0;
- fixed a compilation issue with target/arm/kvm.c (probably
caused by some rebase - funny enough, incremental
compilation was fine her
Creates a QMP command to be used for generic ACPI APEI hardware error
injection (HEST) via GHESv2, and add support for it for ARM guests.
Error injection uses ACPI_HEST_SRC_ID_QMP source ID to be platform
independent. This is mapped at arch virt bindings, depending on the
types supported by QEMU a
Store HEST table address at GPA, placing its the start of the table at
hest_addr_le variable.
Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Jonathan Cameron
Reviewed-by: Igor Mammedov
---
hw/acpi/ghes.c | 22 --
include/hw/acpi/ghes.h | 6 +-
2 files change
We'll be adding a new GED device for HEST GPIO notification and
increasing the number of entries at the HEST table.
Blocklist testing HEST and DSDT tables until such changes
are completed.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Igor Mammedov
Reviewed-by: Jonathan Cameron
---
tests/qte
On 5/12/25 17:32, Steve Sistare wrote:
If there are multiple containers and unmap-all fails for some container, we
need to remap vaddr for the other containers for which unmap-all succeeded.
Recover by walking all address ranges of all containers to restore the vaddr
for each. Do so by invoking
On 5/15/25 08:05, Alistair Francis wrote:
On Mon, May 12, 2025 at 7:53 PM Paolo Bonzini wrote:
Same as v4, with suggestion from Richard to avoid parentheses---which also
fixes the issue with kvm-cpu.c reported by Daniel Barboza. KVM/RISC-V is
now covered in CI and passes with this version.
P
On Mon, May 19, 2025 at 3:20 AM Alistair Francis wrote:
>
> On Tue, May 6, 2025 at 8:47 AM Daniel Henrique Barboza
> wrote:
> >
> > Hi Alistair,
> >
> >
> > I think we should push this upstream and see what happens. We'll have a
> > full release cycle to undo the change in case we find unintended
On 19.05.25 2:10 PM, Fiona Ebner wrote:
> Am 14.05.25 um 21:54 schrieb Kevin Wolf:
>> Am 08.05.2025 um 16:09 hat Fiona Ebner geschrieben:
>>> In bdrv_graph_wrlock() there is a comment that it uses
>>> bdrv_drain_all_begin_nopoll() to make sure that constantly arriving
>>> new I/O doesn't cause star
Hello John,
Would it be complex to propose a functional test for it ?
We have a libvfio-user we can use, but this would be a problem:
487 │ 2025-05-19 14:19:20,304: modprobe gpio-pci-idio-16
488 │ 2025-05-19 14:19:20,306: modprobe: FATAL: Module gpio-pci-idio-16 not
found in director
On Tue, May 20, 2025 at 3:08 PM Michael Tokarev wrote:
>
> On 19.05.2025 07:04, alistai...@gmail.com wrote:
> > From: Alistair Francis
>
> > First RISC-V PR for 10.1
> >
> > * Add support for RIMT to virt machine ACPI
> > * Don't allow PMP RLB to bypass rule privileges
> > * Fix checks on writes
On 5/16/25 19:58, Steven Sistare wrote:
On 5/16/2025 4:31 AM, Cédric Le Goater wrote:
On 5/12/25 17:32, Steve Sistare wrote:
Export various MSI functions, for use by CPR in subsequent patches.
No functional change.
Signed-off-by: Steve Sistare
Please rename this routines with a 'vfio_pci' p
On 19.05.2025 07:04, alistai...@gmail.com wrote:
From: Alistair Francis
First RISC-V PR for 10.1
* Add support for RIMT to virt machine ACPI
* Don't allow PMP RLB to bypass rule privileges
* Fix checks on writes to pmpcfg in Smepmp MML mode
* Generate strided vector loads/stores with tcg nod
Hello Alistair,
Could you please comment?
I'd like to know if this version of patch set need any more work.
Thanks & Regards,
Ran
On 2025/4/25 20:17, Ran Wang wrote:
This serial adds Xiangshan Kunminghu CPU and its FPGA prototype
platform, which include UART, CLINT, IMSIC, and APLIC
devices.
On 5/18/25 18:26, Yiwei Zhang wrote:
> +#if VIRGL_VERSION_MAJOR >= 1
> +static void virgl_write_context_fence(void *opaque, uint32_t ctx_id,
> + uint32_t ring_idx, uint64_t fence_id) {
> +VirtIOGPU *g = opaque;
> +struct virtio_gpu_ctrl_command *cmd, *tm
On 5/20/25 01:20, Yiwei Zhang wrote:
>> Is it possible that virglrenderer will ever write a context fence in
>> virgl_renderer_create_fence()? Do we really need this check?
> I assume you were referring to whether a context fence can be written
> in virgl_write_fence(). Yes, the fenceq contains bot
On Mon, May 19, 2025 at 03:51:13PM +0100, Peter Maydell wrote:
> Date: Mon, 19 May 2025 15:51:13 +0100
> From: Peter Maydell
> Subject: [PATCH v2 3/4] target/i386: Wire up MXCSR.DE and FPUS.DE correctly
> X-Mailer: git-send-email 2.43.0
>
> The x86 DE bit in the FPU and MXCSR status is supposed t
On Mon, May 19, 2025 at 03:51:12PM +0100, Peter Maydell wrote:
> Date: Mon, 19 May 2025 15:51:12 +0100
> From: Peter Maydell
> Subject: [PATCH v2 2/4] target/i386: Use correct type for
> get_float_exception_flags() values
> X-Mailer: git-send-email 2.43.0
>
> The softfloat get_float_exception_fl
On Tue, May 20, 2025 at 12:36 AM Jim Shu wrote:
>
> This patch series contains several sstc fixes:
>
> (1) Writing to ACLINT mtime should also update the period of S/VS-mode
> timer, just like M-mode timer.
> (2) VSTIP bit of $mip CSR should check both M-mode and H-mode STCE.
> (3) Writing to
On 2025/05/19 23:54, Alex Bennée wrote:
Akihiko Odaki writes:
On 2025/05/06 21:57, Alex Bennée wrote:
It's easy to get lost in zeros while setting the numbers of
instructions per second. Add a scaling suffix to make things simpler.
Signed-off-by: Alex Bennée
Reviewed-by: Pierrick Bouvier
--
On Mon, May 19, 2025 at 6:12 AM Dmitry Osipenko
wrote:
>
> On 5/18/25 18:26, Yiwei Zhang wrote:
> > Venus and later native contexts have their own fence context along with
> > multiple timelines within. Fences wtih VIRTIO_GPU_FLAG_INFO_RING_IDX in
> > the flags must be dispatched to be created on
clang-21 complains about the const "name" field in struct debug_entry.
While this warning may be too aggressive, there is not too much value
in having const there, so just drop it.
Note: in addition to this fix, I had to turn off the following clang-21
warnings to make the build work:
* -Wno-pare
Steve Sistare writes:
> Add the helper function cpr_get_fd_param, to use when preserving
> a file descriptor that is opened externally and passed to QEMU.
> cpr_get_fd_param returns a descriptor number either from a QEMU
> command-line parameter, from a getfd command, or from CPR state.
>
> When
Steve Sistare writes:
> Using qom-list and qom-get to get all the nodes and property values in a
> QOM tree can take multiple seconds because it requires 1000's of individual
> QOM requests. Some managers fetch the entire tree or a large subset
> of it when starting a new VM, and this cost is a
Hi,
Hopefully this is just a temporary issue. The functional-system-debian
CI job is failing because the following image URL is down:
https://k-space.ee.armbian.com/archive/orangepipc/archive/Armbian_23.8.1_Orangepipc_jammy_current_6.1.47.img.xz
https://gitlab.com/qemu-project/qemu/-/jobs/10082011
On Mon, May 19, 2025 at 12:20:48PM +0100, Richard W.M. Jones wrote:
> On Sat, May 17, 2025 at 11:11:52PM +0300, Nir Soffer wrote:
> > Testings reading and writing from qemu-nbd using a unix domain socket
>
> Nit pick that this should be "Testing", not "Testings". (Or
> "Experiments" if you really
On Sat, May 17, 2025 at 11:11:51PM +0300, Nir Soffer wrote:
> On both macOS and Linux, the default send buffer size is too small causing
> poor
> performance when reading and writing to qemu-nbd. A simple way to experience
> this is to compare TCP and unix sockets, showing that TCP socket is much
On 5/19/2025 4:51 AM, Cédric Le Goater wrote:
On 5/16/25 20:18, Steven Sistare wrote:
On 5/16/2025 4:35 AM, Cédric Le Goater wrote:
On 5/12/25 17:32, Steve Sistare wrote:
cpr-transfer breaks vfio network connectivity to and from the guest, and
the host system log shows:
irq bypass consumer
Remove hot paths from .c file and added it in .h file to keep it inline.
Signed-off-by: Tanish Desai
---
scripts/tracetool/backend/simple.py | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/scripts/tracetool/backend/simple.py
b/scripts/tracetool/back
In this patch, we don't have a builtin type to use for a type hint, but
we do have collections.abc and other standard library types. Replace
deprecated type hints with their standard library equivalents:
typing.Awaitable => collections.abc.Awaitable
typing.AbstractSet=> collections.abc.Ab
On 19.05.2025 10:42, Manos Pitsidianakis wrote:
> On Wed, 30 Apr 2025 08:27, Mario Fleischmann
> wrote:
>> Signed-off-by: Mario Fleischmann
>> ---
>> gdbstub/gdbstub.c | 7 ---
>> include/exec/gdbstub.h | 8 +++-
>> 2 files changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/g
Thank you for taking the time to review this patch!
On 19.05.2025 12:00, Manos Pitsidianakis wrote:
> On Wed, 30 Apr 2025 08:27, Mario Fleischmann
> wrote:
>> Support three main memory space types:
>>
>> * Physical memory
>> * Logical memory (MMU)
>> * GDB Registers
>>
>> Use custom memory type
We don't need these requirements anymore, so remove them.
Signed-off-by: John Snow
---
python/setup.cfg | 1 -
1 file changed, 1 deletion(-)
diff --git a/python/setup.cfg b/python/setup.cfg
index 02cc076eaea..1afdcf1c3cd 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -41,7 +41,6 @@ dev
Removing this configuration line allows mypy to type check files from
the context of whatever version of Python it happens to be running
under, which is actually what we want here, so long as we do actually
support running these scripts under multiple versions of Python, which
we currently do.
Sig
Synchronize changes from the standalone python-qemu-qmp repository for
the primary purpose of removing some pre-3.9 compatibility crud that we
no longer need or want.
My plan for this release cycle is to finally eliminate this duplication
so this type of patch will no longer be necessary -- but fo
This patch changes type hints that have built-in equivalents as of
Python 3.9. The versions we currently use, imported from the typing
module, have been deprecated since 3.9 and may be removed at any time -
though to my knowledge, they are not scheduled for removal in 3.14.
The type hints to updat
Currently, we instruct mypy to pretend it is type checking under a
specific version of python. For our case, where our scripts may in fact
actually be executing under a number of different environments in the
build system, we want mypy to remove this restriction.
This patch adjusts some of the imp
Newer versions of setuptools increasingly expect that packages are
defined using the pyproject.toml/PEP517 packaging layout format. With
3.9 as our minimum, I believe it's finally appropriate to make the shift
away from the legacy packaging format.
Update documentation and dependencies that change
The next patch will synchronize the qemu.qmp library with the external,
standalone version. That synchronization will require a few extra
ignores for pylint, so do that now.
Signed-off-by: John Snow
---
python/setup.cfg | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pyt
This series does a couple things that I'll probably end up splitting out
into smaller series if history is any guide, but either way, here it
goes:
A) Convert qemu.git/python/ to a PEP517/pyproject.toml
package. Ultimately this means deleting setup.py and fully migrating to
newer python infrastruc
On Thu, May 15, 2025 at 4:38 AM Markus Armbruster wrote:
> John Snow writes:
>
> > Hiya, this series turns on automated linting for scripts/qapi,
> > docs/sphinx/qapidoc.py and docs/sphinx/qapi_domain.py.
> >
> > This includes flake8/isort/pylint/mypy for scripts/qapi, but omits mypy
> > from th
On Sat, May 10, 2025 at 2:17 AM Akihiko Odaki
wrote:
> Supersedes: <20250505-sphinx82-v1-0-85f2418b3...@daynix.com>
> ("[PATCH 0/2] docs: Bump sphinx to 8.2.3")
>
> sphinx 5.3.0 fails with Python 3.13.1:
>
> ../docs/meson.build:37: WARNING:
> /home/me/qemu/build/pyvenv/bin/sphinx-build:
> Extensi
Thanks for the comments, Ill make a new patch with a `vfio_is_display`
function`,
should I still change all uses of the `vfio_is_vga` function to use that one
even if the other quirks aren't needed in that configuration?
ma 19.5.2025 klo 20.28 Tomita Moeko (tomitamo...@gmail.com) kirjoitti:
> On
On 5/20/25 01:15, Alex Williamson wrote:
> [Please Cc maintainers - added here]
>
> On Mon, 19 May 2025 18:08:39 +0300
> Qwinci wrote:
>
>> Change the IGD detection logic to also accept gpus with
>> PCI_CLASS_DISPLAY_OTHER class which is used if the igpu is not
>> set as the primary boot gpu.
>>
On 5/19/25 19:10, Daniel P. Berrangé wrote:
The previous commit mandates use of SPDX-License-Identifier on common
source files, and encourages it on all other files.
Some contributors are none the less still also including the license
boilerplate text. This is redundant and will potentially caus
On Mon, 19 May 2025 at 18:10, Daniel P. Berrangé wrote:
>
> The previous commit mandates use of SPDX-License-Identifier on common
> source files, and encourages it on all other files.
>
> Some contributors are none the less still also including the license
> boilerplate text. This is redundant and
[Please Cc maintainers - added here]
On Mon, 19 May 2025 18:08:39 +0300
Qwinci wrote:
> Change the IGD detection logic to also accept gpus with
> PCI_CLASS_DISPLAY_OTHER class which is used if the igpu is not
> set as the primary boot gpu.
>
> Signed-off-by: Qwinci
> ---
> hw/vfio/igd.c | 16
On 5/19/25 1:35 PM, Andrew Jones wrote:
On Mon, May 19, 2025 at 09:48:14AM -0300, Daniel Henrique Barboza wrote:
On 5/16/25 9:23 AM, Alexandre Ghiti wrote:
The satp mode is set using the svXX properties, but that actually
restricts the satp mode to the minimum required by the profile and
p
The current regex matches Makefile & Makefile.objs, but the latter is
no longer used, anjd we're missing coverage of Makefile.include and
Makefile.target. Expand the pattern to match any suffix.
Reviewed-by: Cédric Le Goater
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
scri
Going forward we want all newly created source files to have an
SPDX-License-Identifier tag present.
Initially mandate this for C, Python, Perl, Shell source files,
as well as JSON (QAPI) and Makefiles, while encouraging users
to consider it for other file types.
The new attempt at detecting miss
When seeing a new/deleted/renamed file we check to see if MAINTAINERS
is updated, but we don't give the user a list of files affected, as
we don't want to repeat the same warning many times over.
Using the new file list hook, we can give a single warning at the
end with a list of filenames include
The file permissions check is the kind of check intended to be performed
in the new start of file hook.
Reviewed-by: Cédric Le Goater
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
scripts/checkpatch.pl | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-
This reverts commit fa4d79c64dae03ffa269e42e21822453856618b7.
The logic in this commit was flawed in two critical ways
* It always failed to report SPDX validation on the last newly
added file. IOW, it only worked if at least 2 new files were
added in a commit
* If an existing file chang
Some checks want to be performed either at the start of a new file
within a patch, or at the end. This is complicated by the fact that
the information relevant to the check may be spread across multiple
lines. It is further complicated by a need to support both git and
non-git diffs, and special ha
From: Markus Armbruster
strict = True implies warn_unused_configs = True.
Signed-off-by: Markus Armbruster
Signed-off-by: John Snow
Reviewed-by: Markus Armbruster
Message-id: 20250512193357.3388514-6-js...@redhat.com
Signed-off-by: John Snow
---
python/setup.cfg | 1 -
1 file changed, 1 del
From: Thomas Huth
The 2023 edition of the QEMU advent calendar featured an image
that we can use to test whether the lm3s6965evb machine is basically
still working.
And for the lm3s811evb there is a small test kernel on github
which can be used to check its UART.
Signed-off-by: Thomas Huth
---
The previous commit mandates use of SPDX-License-Identifier on common
source files, and encourages it on all other files.
Some contributors are none the less still also including the license
boilerplate text. This is redundant and will potentially cause
trouble if inconsistent with the SPDX declar
The ACPI test data check needs to analyse a list of all files in a
commit, so can use the new hook for processing the file list.
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
scripts/checkpatch.pl | 61 ---
1 file changed, 29 insertions
This is hugely expanded an update of
https://lists.nongnu.org/archive/html/qemu-devel/2025-05/msg02040.html
In that series, Peter suggested creating standalone methods to act
as hooks to call when detecting the start/end of a file in a diff.
This implements that idea and adapts a number of exi
Various checks in the code were under-indented relative to other
surrounding code. Some places used 4-space indents instead of
single tab, while other places simply used too few tabs.
Reviewed-by: Cédric Le Goater
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
scripts/checkpa
The following changes since commit 757a34115e7491744a63dfc3d291fd1de5297ee2:
Merge tag 'pull-nvme-20250515' of https://gitlab.com/birkelund/qemu into
staging (2025-05-15 13:42:27 -0400)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/python-pull-request
for y
We pin all dependencies for the "check-minreqs" test because pip lacks a
dependency resolver that installs "the oldest possible package that
meets dependency criteria". So, in order to test our stated minimum
requirements, we pin all of our dependencies (and their dependencies,
transitively) at the
Since the previous commit, python/setup.cfg applies to scripts/qapi/ as
well. Configuration files in scripts/qapi/ override python/setup.cfg.
scripts/qapi/.flake8 and scripts/qapi/.isort.cfg actually match
python/setup.cfg exactly, and can go.
The differences between scripts/qapi/mypy.ini and py
This restores the linting baseline in QAPI.
Signed-off-by: John Snow
Reviewed-by: Markus Armbruster
Message-id: 20250512193357.3388514-2-js...@redhat.com
Signed-off-by: John Snow
---
scripts/qapi/backend.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi/backend.py b/scripts
Update the python tests to also check QAPI and the QAPI Sphinx
extensions. The docs/sphinx/qapidoc_legacy.py file is not included in
these checks, as it is destined for removal soon. mypy is also not
called on the QAPI Sphinx extensions, owing to difficulties supporting
Sphinx 3.x - 8.x while maint
This restores the linting baseline in qapidoc. The order of some imports
change slightly here due to configuring isort a little better:
previously, isort was having difficulty understanding that "compat" and
"qapidoc_legacy" were local modules because docs/sphinx "isn't a python
package". Configuri
Jiaxun Yang 于2025年5月19日周一 17:17写道：
>
>
>
> 在2025年5月19日周一 上午9:55，Bibo Mao写道：
> [...]
> >> It's actually different machine as kernel irqchip is never on par with
> >> usermode
> >> emulation. This approach is taken by i386 (TYPE_KVM_IOAPIC vs TYPE_IOAPIC),
> >> Arm (TYPE_KVM_ARM_ITS vs TYPE_ARM_GIC
On 15.05.2025 11:58, Daniel P. Berrangé wrote:
> On Wed, Apr 30, 2025 at 07:27:29AM +0200, Mario Fleischmann wrote:
>> This commit implements the necessary operations required to establish
>> a connection with the MCD server:
>>
>> * query information about the server
>> * connect to "
>> * discon
On 15.05.2025 15:02, Markus Armbruster wrote:
> Mario Fleischmann writes:
>
>> The target initialization API ensures that the requested and provided
>> MCD versions are compatible.
>>
>> * implement mcd_initialize_f and mcd_qry_error_info_f in mcdserver
>> * implement QMP stub functionality
>> *
On Mon, May 19, 2025 at 05:44:51PM +0100, Peter Maydell wrote:
> On Mon, 19 May 2025 at 17:37, Daniel P. Berrangé wrote:
> >
> > The previous commit mandates use of SPDX-License-Identifier on common
> > source files, and encourages it on all other files.
> >
> > Some contributors are none the less
On 5/19/25 18:37, Daniel P. Berrangé wrote:
The previous commit mandates use of SPDX-License-Identifier on common
source files, and encourages it on all other files.
Some contributors are none the less still also including the license
boilerplate text. This is redundant and will potentially caus
On Mon, 19 May 2025 at 17:37, Daniel P. Berrangé wrote:
>
> The previous commit mandates use of SPDX-License-Identifier on common
> source files, and encourages it on all other files.
>
> Some contributors are none the less still also including the license
> boilerplate text. This is redundant and
在2025年5月19日周一 下午2:24，bibo mao写道：
[...]
>> I don't think there is any disadvantage. I don't really buy the "different
>> machine"
>> justification you made. Paravirt solution tends to have its own behaviour
>> and I don't
>> think it's a bad thing to expose it to users.
> irqchip-in-kernel is s
On Mon, 19 May 2025 at 17:27, Alex Bennée wrote:
>
> Daniel P. Berrangé writes:
>
> > Various checks in the code were under-indented relative to other
> > surrounding code.
>
> Are we accepting that we have hard forked from the Linux checkpatch now?
Yes, I think that ship sailed some years ago:
The ACPI test data check needs to analyse a list of all files in a
commit, so can use the new hook for processing the file list.
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
scripts/checkpatch.pl | 61 ---
1 file changed, 29 insertions
When seeing a new/deleted/renamed file we check to see if MAINTAINERS
is updated, but we don't give the user a list of files affected, as
we don't want to repeat the same warning many times over.
Using the new file list hook, we can give a single warning at the
end with a list of filenames include
The previous commit mandates use of SPDX-License-Identifier on common
source files, and encourages it on all other files.
Some contributors are none the less still also including the license
boilerplate text. This is redundant and will potentially cause
trouble if inconsistent with the SPDX declar
The current regex matches Makefile & Makefile.objs, but the latter is
no longer used, anjd we're missing coverage of Makefile.include and
Makefile.target. Expand the pattern to match any suffix.
Reviewed-by: Cédric Le Goater
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
scri
Going forward we want all newly created source files to have an
SPDX-License-Identifier tag present.
Initially mandate this for C, Python, Perl, Shell source files,
as well as JSON (QAPI) and Makefiles, while encouraging users
to consider it for other file types.
The new attempt at detecting miss
Some checks want to be performed either at the start of a new file
within a patch, or at the end. This is complicated by the fact that
the information relevant to the check may be spread across multiple
lines. It is further complicated by a need to support both git and
non-git diffs, and special ha
The file permissions check is the kind of check intended to be performed
in the new start of file hook.
Reviewed-by: Cédric Le Goater
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
scripts/checkpatch.pl | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-
This reverts commit fa4d79c64dae03ffa269e42e21822453856618b7.
The logic in this commit was flawed in two critical ways
* It always failed to report SPDX validation on the last newly
added file. IOW, it only worked if at least 2 new files were
added in a commit
* If an existing file chang
Various checks in the code were under-indented relative to other
surrounding code. Some places used 4-space indents instead of
single tab, while other places simply used too few tabs.
Reviewed-by: Cédric Le Goater
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
scripts/checkpa
This is hugely expanded an update of
https://lists.nongnu.org/archive/html/qemu-devel/2025-05/msg02040.html
In that series, Peter suggested creating standalone methods to act
as hooks to call when detecting the start/end of a file in a diff.
This implements that idea and adapts a number of exi
On Mon, May 19, 2025 at 05:27:21PM +0100, Alex Bennée wrote:
> Daniel P. Berrangé writes:
>
> > Various checks in the code were under-indented relative to other
> > surrounding code.
>
> Are we accepting that we have hard forked from the Linux checkpatch now?
The changed lines were all in QEMU
1 - 100 of 260 matches
Mail list logo
