Re: [PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-23 Thread Pavel Dovgalyuk
On 23.12.2024 20:26, Peter Xu wrote: On Sat, Dec 21, 2024 at 01:02:01PM +1000, Nicholas Piggin wrote: On Sat Dec 21, 2024 at 2:31 AM AEST, Peter Xu wrote: On Fri, Dec 20, 2024 at 08:42:03PM +1000, Nicholas Piggin wrote: Migration reads CLOCK_HOST when not holding the replay_mutex, which assert

Re: [PATCH v8 08/12] migration/multifd: Add new migration option for multifd DSA offloading.

2024-12-23 Thread Yichen Wang
On Tue, Dec 3, 2024 at 6:12 PM Yichen Wang wrote: > > From: Hao Xiang > > Intel DSA offloading is an optional feature that turns on if > proper hardware and software stack is available. To turn on > DSA offloading in multifd live migration by setting: > > zero-page-detection=dsa-accel > accel-pat

Re: [PATCH v1 04/19] intel_iommu: Fill the PASID field when creating an IOMMUTLBEntry

2024-12-23 Thread CLEMENT MATHIEU--DRIF
Hi zhenzhong, On 23/12/2024 06:50, Duan, Zhenzhong wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > > Hi Clement, > >> -Original Message- >> From: CLEMENT MATHIEU--DRIF >> Subjec

Re: [PATCH] Add a b4 configuration file

2024-12-23 Thread Konstantin Ryabitsev
On Sun, Dec 22, 2024 at 04:53:41PM +, Jiaxun Yang wrote: > +[b4] > +send-series-to = qemu-devel@nongnu.org > +send-auto-to-cmd = echo Hmm... does it not work without the above line? If so, can you please send a bug report to to...@kernel.org? Thanks! -K

Re: [PATCH] hw/loongarch/boot: Support Linux raw boot image

2024-12-23 Thread bibo mao
On 2024/12/23 上午8:30, Jiaxun Yang wrote: Many distros are shipping raw kernel images (i.e. vmlinux.efi). Support booting such image by parsing header as per Linux's specification [1]. [1]: https://docs.kernel.org/arch/loongarch/booting.html Signed-off-by: Jiaxun Yang --- It is based on my

Re: [PATCH 2/3] target/loongarch: Fix LLSC for LoongArch32

2024-12-23 Thread Richard Henderson
On 12/23/24 13:01, Jiaxun Yang wrote: 在2024年12月23日十二月 下午3:15,Richard Henderson写道: On 12/22/24 15:40, Jiaxun Yang wrote: @@ -9,7 +9,7 @@ static bool gen_ll(DisasContext *ctx, arg_rr_i *a, MemOp mop) TCGv src1 = gpr_src(ctx, a->rj, EXT_NONE); TCGv t0 = make_address_i(ctx, src1, a-

macaddr: ignore the checking from index to 0xFF

2024-12-23 Thread Liu Jaloo
bash-5.1$ git diff net/net.c diff --git a/net/net.c b/net/net.c index c1bb19a523..af68029428 100644 --- a/net/net.c +++ b/net/net.c @@ -173,6 +173,7 @@ static void qemu_macaddr_set_used(MACAddr *macaddr) for (index = 0x56; index < 0xFF; index++) { if (macaddr->a[5] == index) {

Re: [PATCH] hw/loongarch/boot: Support Linux raw boot image

2024-12-23 Thread bibo mao
On 2024/12/24 上午10:31, Jiaxun Yang wrote: 在2024年12月24日十二月 上午1:25,bibo mao写道: On 2024/12/24 上午9:15, Jiaxun Yang wrote: 在2024年12月24日十二月 上午12:56,bibo mao写道: Sorry, I do not know the background. Now kernel image with EFI format can boot if uefi bios is provided. What is this patch to do?

Re: [PATCH] target/loongarch: Fix vldi inst

2024-12-23 Thread bibo mao
On 2024/12/19 下午8:23, Xianglai Li wrote: From: ghy <2247883...@qq.com> Refer to the link below for a description of the vldi instructions: https://jia.je/unofficial-loongarch-intrinsics-guide/lsx/misc/#synopsis_88 Fixed errors in vldi instruction implementation. Signed-off-by: Guo Hongyu Te

Re: [PATCH] hw/loongarch/boot: Support Linux raw boot image

2024-12-23 Thread Jiaxun Yang
在2024年12月24日十二月 上午1:25,bibo mao写道: > On 2024/12/24 上午9:15, Jiaxun Yang wrote: >> >> >> 在2024年12月24日十二月 上午12:56,bibo mao写道: >>> Sorry, I do not know the background. >>> Now kernel image with EFI format can boot if uefi bios is provided. >>> >>> What is this patch to do? is it to direct boot ke

[PATCH] backends/cryptodev-vhost-user: Fix local_error leaks

2024-12-23 Thread Gabriel Barrantes
>From c808fa797942b9bd32221594b7eef690a7558b14 Mon Sep 17 00:00:00 2001 From: Gabriel Barrantes Date: Mon, 23 Dec 2024 14:58:12 -0600 Subject: [PATCH] backends/cryptodev-vhost-user: Fix local_error leaks Do not propagate error to the upper, directly output the error to avoid leaks. Closes: #2714

Re: [PATCH v3 49/51] tcg/optimize: Re-enable sign-mask optimizations

2024-12-23 Thread Pierrick Bouvier
On 12/22/24 08:24, Richard Henderson wrote: All instances of s_mask have been converted to the new representation. We can now re-enable usage. Signed-off-by: Richard Henderson --- tcg/optimize.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/opt

RE: [PATCH v1 2/3] hw/timer/aspeed: Add AST2700 Support

2024-12-23 Thread Jamin Lin
H Cedric, > Subject: Re: [PATCH v1 2/3] hw/timer/aspeed: Add AST2700 Support > > On 12/16/24 08:53, Jamin Lin wrote: > > The timer controller include 8 sets of 32-bit decrement counters, > > based on either PCLK or 1MHZ clock and the design of timer controller > > between AST2600 and AST2700 are

Re: [PATCH v3 06/51] tcg/optimize: Change representation of s_mask

2024-12-23 Thread Pierrick Bouvier
On 12/22/24 08:24, Richard Henderson wrote: Change the representation from sign bit repetitions to all bits equal to the sign bit, including the sign bit itself. The previous format has a problem in that it is difficult to recreate a valid sign mask after a shift operation: the "repetitions" par

Re: [PATCH] hw/loongarch/boot: Support Linux raw boot image

2024-12-23 Thread bibo mao
On 2024/12/24 上午9:15, Jiaxun Yang wrote: 在2024年12月24日十二月 上午12:56,bibo mao写道: Sorry, I do not know the background. Now kernel image with EFI format can boot if uefi bios is provided. What is this patch to do? is it to direct boot kernel with EFI format without UEFI bios parameter? Yes, i

Re: [PATCH 1/3] target/loongarch: Enable rotr.w/rotri.w for LoongArch32

2024-12-23 Thread Jiaxun Yang
在2024年12月23日十二月 下午12:46,Philippe Mathieu-Daudé写道: > On 23/12/24 00:40, Jiaxun Yang wrote: >> As per "LoongArch Reference Manual Volume 1: Basic Architecture" v1.1.0, >> "2.2 Table 2. Application-level basic integer instructions in LA32", >> rotr.w and rotri.w is a part of LA32 basic integer inst

Re: [PATCH 3/3] target/loongarch: Fix PGD CSR for LoongArch32

2024-12-23 Thread Jiaxun Yang
在2024年12月23日十二月 下午12:52,Philippe Mathieu-Daudé写道: > On 23/12/24 00:40, Jiaxun Yang wrote: >> As per manual, the source of PGD CSR is relevant to highest bit of >> BADV. In LoongArch32, all CSRs are 32 bits only, thus we should check >> bit 31 of BADV to determine PGDH/PGDL for LoongArch32. >> >

Re: [PATCH v4 0/6] hw/ppc: Remove tswap() calls

2024-12-23 Thread Harsh Prateek Bora
On Sat, 21 Dec, 2024, 3:02 am Philippe Mathieu-Daudé, wrote: > Since v3: > - Addressed Nick & Harsh review comments > > Remove the tswap() calls on ePAPR, and convert > them to big-endian LD/ST API on sPAPR. > > Build-tested only. > > Philippe Mathieu-Daudé (6): > hw/ppc/spapr: Convert HPTE()

Re: [PATCH 2/3] target/loongarch: Fix LLSC for LoongArch32

2024-12-23 Thread Jiaxun Yang
在2024年12月23日十二月 下午11:18,Philippe Mathieu-Daudé写道: > On 23/12/24 22:01, Jiaxun Yang wrote: >> >> >> 在2024年12月23日十二月 下午3:15,Richard Henderson写道: >>> On 12/22/24 15:40, Jiaxun Yang wrote: @@ -9,7 +9,7 @@ static bool gen_ll(DisasContext *ctx, arg_rr_i *a, MemOp mop) TCGv src

Re: [PATCH] hw/loongarch/boot: Support Linux raw boot image

2024-12-23 Thread Jiaxun Yang
在2024年12月24日十二月 上午12:56,bibo mao写道: > Sorry, I do not know the background. > Now kernel image with EFI format can boot if uefi bios is provided. > > What is this patch to do? is it to direct boot kernel with EFI format > without UEFI bios parameter? Yes, it’s now capable for booting vmlinux.e

Re: [PATCH] hw/loongarch/boot: Support Linux raw boot image

2024-12-23 Thread bibo mao
Sorry, I do not know the background. Now kernel image with EFI format can boot if uefi bios is provided. What is this patch to do? is it to direct boot kernel with EFI format without UEFI bios parameter? Regards Bibo Mao On 2024/12/23 上午8:30, Jiaxun Yang wrote: Many distros are shipping raw

Re: [PATCH 2/3] target/loongarch: Fix LLSC for LoongArch32

2024-12-23 Thread Philippe Mathieu-Daudé
On 23/12/24 22:01, Jiaxun Yang wrote: 在2024年12月23日十二月 下午3:15,Richard Henderson写道: On 12/22/24 15:40, Jiaxun Yang wrote: @@ -9,7 +9,7 @@ static bool gen_ll(DisasContext *ctx, arg_rr_i *a, MemOp mop) TCGv src1 = gpr_src(ctx, a->rj, EXT_NONE); TCGv t0 = make_address_i(ctx, src1, a-

Re: [PATCH v15 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-12-23 Thread Philippe Mathieu-Daudé
On 23/12/24 23:17, Phil Dennis-Jordan wrote: > Do you have other changes in your v16? I'm quite happy to integrate this > v15. The ones proposed by Akihiko are the only ones. I’ve already implemented them, so I’m happy to post v16. OK, rebasing on the upstream master bra

Re: [PATCH v16 00/14] macOS PV Graphics and new vmapple machine type

2024-12-23 Thread Philippe Mathieu-Daudé
On 23/12/24 23:16, Phil Dennis-Jordan wrote: This patch set introduces a new ARM and macOS HVF specific machine type called "vmapple", as well as a family of display devices based on the ParavirtualizedGraphics.framework in macOS. One of the display adapter variants, apple-gfx-mmio, is required f

[PATCH v16 11/14] hw/vmapple/cfg: Introduce vmapple cfg region

2024-12-23 Thread Phil Dennis-Jordan
From: Alexander Graf Instead of device tree or other more standardized means, VMApple passes platform configuration to the first stage boot loader in a binary encoded format that resides at a dedicated RAM region in physical address space. This patch models this configuration space as a qdev dev

[PATCH v16 08/14] gpex: Allow more than 4 legacy IRQs

2024-12-23 Thread Phil Dennis-Jordan
From: Alexander Graf Some boards such as vmapple don't do real legacy PCI IRQ swizzling. Instead, they just keep allocating more board IRQ lines for each new legacy IRQ. Let's support that mode by giving instantiators a new "nr_irqs" property they can use to support more than 4 legacy IRQ lines.

[PATCH v16 07/14] hw/misc/pvpanic: Add MMIO interface

2024-12-23 Thread Phil Dennis-Jordan
From: Alexander Graf In addition to the ISA and PCI variants of pvpanic, let's add an MMIO platform device that we can use in embedded arm environments. Signed-off-by: Alexander Graf Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Phil Dennis-Jordan Revie

[PATCH v16 03/14] hw/display/apple-gfx: Adds PCI implementation

2024-12-23 Thread Phil Dennis-Jordan
This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Ak

[PATCH v16 12/14] hw/vmapple/virtio-blk: Add support for apple virtio-blk

2024-12-23 Thread Phil Dennis-Jordan
From: Alexander Graf Apple has its own virtio-blk PCI device ID where it deviates from the official virtio-pci spec slightly: It puts a new "apple type" field at a static offset in config space and introduces a new barrier command. This patch first creates a mechanism for virtio-blk downstream c

[PATCH v16 13/14] hw/block/virtio-blk: Replaces request free function with g_free

2024-12-23 Thread Phil Dennis-Jordan
The virtio_blk_free_request() function has been a 1-liner forwarding to g_free() for a while now. We may as well call g_free on the request pointer directly. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki --- hw/block/virtio-blk.c | 43 ++

[PATCH v16 09/14] hw/vmapple/aes: Introduce aes engine

2024-12-23 Thread Phil Dennis-Jordan
From: Alexander Graf VMApple contains an "aes" engine device that it uses to encrypt and decrypt its nvram. It has trivial hard coded keys it uses for that purpose. Add device emulation for this device model. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko

[PATCH v16 14/14] hw/vmapple/vmapple: Add vmapple machine type

2024-12-23 Thread Phil Dennis-Jordan
From: Alexander Graf Apple defines a new "vmapple" machine type as part of its proprietary macOS Virtualization.Framework vmm. This machine type is similar to the virt one, but with subtle differences in base devices, a few special vmapple device additions and a vastly different boot chain. This

[PATCH v16 05/14] MAINTAINERS: Add myself as maintainer for apple-gfx, reviewer for HVF

2024-12-23 Thread Phil Dennis-Jordan
I'm happy to take responsibility for the macOS PV graphics code. As HVF patches don't seem to get much attention at the moment, I'm also adding myself as designated reviewer for HVF and x86 HVF to try and improve that. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Roman Bolshakov Reviewed-by: P

[PATCH v16 02/14] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-12-23 Thread Phil Dennis-Jordan
MacOS provides a framework (library) that allows any vmm to implement a paravirtualized 3d graphics passthrough to the host metal stack called ParavirtualizedGraphics.Framework (PVG). The library abstracts away almost every aspect of the paravirtualized device model and only provides and receives c

Re: [PATCH v15 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-12-23 Thread Phil Dennis-Jordan
On Mon, 23 Dec 2024 at 18:38, Phil Dennis-Jordan wrote: > Hi Philippe, > > > On 23.12.2024, at 17:36, Philippe Mathieu-Daudé > wrote: > > > > Hi Phil, > > > >> On 23/12/24 14:53, Phil Dennis-Jordan wrote: > >> On Thu, 19 Dec 2024 at 11:50, Akihiko Odaki > wrote

[PATCH v16 06/14] hw: Add vmapple subdir

2024-12-23 Thread Phil Dennis-Jordan
From: Alexander Graf We will introduce a number of devices that are specific to the vmapple target machine. To keep them all tidily together, let's put them into a single target directory. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki Tested-by: Ak

[PATCH v16 04/14] hw/display/apple-gfx: Adds configurable mode list

2024-12-23 Thread Phil Dennis-Jordan
This change adds a property 'display_modes' on the graphics device which permits specifying a list of display modes. (screen resolution and refresh rate) The property is an array of a custom type to make the syntax slightly less awkward to use, for example: -device '{"driver":"apple-gfx-pci", "di

[PATCH v16 10/14] hw/vmapple/bdif: Introduce vmapple backdoor interface

2024-12-23 Thread Phil Dennis-Jordan
From: Alexander Graf The VMApple machine exposes AUX and ROOT block devices (as well as USB OTG emulation) via virtio-pci as well as a special, simple backdoor platform device. This patch implements this backdoor platform device to the best of my understanding. I left out any USB OTG parts; they

[PATCH v16 01/14] ui & main loop: Redesign of system-specific main thread event handling

2024-12-23 Thread Phil Dennis-Jordan
macOS's Cocoa event handling must be done on the initial (main) thread of the process. Furthermore, if library or application code uses libdispatch, the main dispatch queue must be handling events on the main thread as well. So far, this has affected Qemu in both the Cocoa and SDL UIs, although in

[PATCH v16 00/14] macOS PV Graphics and new vmapple machine type

2024-12-23 Thread Phil Dennis-Jordan
This patch set introduces a new ARM and macOS HVF specific machine type called "vmapple", as well as a family of display devices based on the ParavirtualizedGraphics.framework in macOS. One of the display adapter variants, apple-gfx-mmio, is required for the new machine type, while apple-gfx-pci ca

Re: [PATCH] Add a b4 configuration file

2024-12-23 Thread Jiaxun Yang
在2024年12月23日十二月 下午12:24,Philippe Mathieu-Daudé写道: > On 23/12/24 13:18, Philippe Mathieu-Daudé wrote: >> Hi Jiaxun, >> >> On 22/12/24 17:53, Jiaxun Yang wrote: >>> b4 [1] is a convenient tool to manage patch series with mailing list >>> working flow. >>> >>> Add a project default config file to

Re: [PATCH 2/3] target/loongarch: Fix LLSC for LoongArch32

2024-12-23 Thread Jiaxun Yang
在2024年12月23日十二月 下午3:15,Richard Henderson写道: > On 12/22/24 15:40, Jiaxun Yang wrote: >> @@ -9,7 +9,7 @@ static bool gen_ll(DisasContext *ctx, arg_rr_i *a, MemOp mop) >> TCGv src1 = gpr_src(ctx, a->rj, EXT_NONE); >> TCGv t0 = make_address_i(ctx, src1, a->imm); > ... >> @@ -28,7 +28,8 @

Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-23 Thread Cédric Le Goater
On 12/23/24 19:43, Joao Martins wrote: On 23/12/2024 18:31, Cédric Le Goater wrote: On 12/23/24 18:55, Joao Martins wrote: On 18/12/2024 13:40, Avihai Horon wrote: Hello, This follows up on Peter's series [1] to simplify migration status API to a single migration_is_running() function. Peter

Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-23 Thread Joao Martins
On 23/12/2024 18:31, Cédric Le Goater wrote: > On 12/23/24 18:55, Joao Martins wrote: >> On 18/12/2024 13:40, Avihai Horon wrote: >>> Hello, >>> >>> This follows up on Peter's series [1] to simplify migration status API >>> to a single migration_is_running() function. >>> >>> Peter's series tried t

Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-23 Thread Cédric Le Goater
On 12/23/24 18:55, Joao Martins wrote: On 18/12/2024 13:40, Avihai Horon wrote: Hello, This follows up on Peter's series [1] to simplify migration status API to a single migration_is_running() function. Peter's series tried to drop migration_is_device() and migration_is_active(), however VFIO

Re: [PATCH v4 7/7] Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h.

2024-12-23 Thread Jonathan Cameron via
On Mon, 16 Dec 2024 17:54:14 + Alireza Sanaee wrote: > The disassembled differences between actual and expected PPTT based on > the following cache topology representation: > > ``` > test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster," > "smp-cache.1.

Re: [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology

2024-12-23 Thread Jonathan Cameron via
On Mon, 16 Dec 2024 17:54:13 + Alireza Sanaee wrote: > Test new PPTT topolopy with cache representation. > > Signed-off-by: Alireza Sanaee > --- > tests/qtest/bios-tables-test.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tests/qtest/bios-tables-test.c b/

Re: [PATCH v4 3/7] arm/virt.c: add cache hierarchy to device tree

2024-12-23 Thread Jonathan Cameron via
On Mon, 16 Dec 2024 17:54:10 + Alireza Sanaee wrote: > Specify which layer (core/cluster/socket) caches found at in the CPU > topology. Updating cache topology to device tree (spec v0.4). > Example: > > Here, 2 sockets (packages), and 2 clusters, 4 cores and 2 threads > created, in aggregate

Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

2024-12-23 Thread Joao Martins
On 18/12/2024 13:40, Avihai Horon wrote: > Hello, > > This follows up on Peter's series [1] to simplify migration status API > to a single migration_is_running() function. > > Peter's series tried to drop migration_is_device() and > migration_is_active(), however VFIO used them to check if dirty

Re: [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property

2024-12-23 Thread Jonathan Cameron via
On Mon, 16 Dec 2024 17:54:08 + Alireza Sanaee wrote: > This commit adds IsDefined flag to the object and this helps in avoiding > extra checks for every single layer of caches in both x86 and ARM. > > There is already a discussion on mailing list to have this flag. A > patch that enables thi

Re: [PATCH v4 2/7] target/arm/tcg: increase cache level for cpu=max

2024-12-23 Thread Jonathan Cameron via
On Mon, 16 Dec 2024 17:54:09 + Alireza Sanaee wrote: > This patch addresses cache description in the `aarch64_max_tcg_initfn` > function for cpu=max. It introduces three layers of caches and modifies > the cache description registers accordingly. > > Signed-off-by: Alireza Sanaee I think t

Re: [PATCH v2 3/7] vfio/migration: Refactor vfio_devices_all_running_and_mig_active() logic

2024-12-23 Thread Joao Martins
On 18/12/2024 13:40, Avihai Horon wrote: > During DMA unmap with vIOMMU, vfio_devices_all_running_and_mig_active() > is used to check whether a dirty page log sync of the unmapped pages is > required. Such log sync is needed during migration pre-copy phase, and > the current logic detects it by che

Re: [PATCH v2 2/7] vfio/migration: Refactor vfio_devices_all_dirty_tracking() logic

2024-12-23 Thread Joao Martins
On 18/12/2024 13:40, Avihai Horon wrote: > During dirty page log sync, vfio_devices_all_dirty_tracking() is used to > check if dirty tracking has been started in order to avoid errors. The > current logic checks if migration is in ACTIVE or DEVICE states to > ensure dirty tracking has been started.

Re: [PATCH] dma-helpers: Fix iovec alignment

2024-12-23 Thread Peter Xu
On Sat, Dec 21, 2024 at 12:07:05AM +0300, Michael Tokarev wrote: > 11.08.2024 20:47, Michael Tokarev пишет: > > 12.04.2024 18:25, Eric Blake wrote: > > > On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote: > > > > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a >

Re: [PATCH v15 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-12-23 Thread Phil Dennis-Jordan
Hi Philippe, > On 23.12.2024, at 17:36, Philippe Mathieu-Daudé wrote: > > Hi Phil, > >> On 23/12/24 14:53, Phil Dennis-Jordan wrote: >> On Thu, 19 Dec 2024 at 11:50, Akihiko Odaki > > wrote: >>Reviewing "[PATCH v2 6/6] hw/vmapple: XHCI controller's interrup

Re: [PATCH 2/2] hvf: arm: disable unavailable features on older macOS

2024-12-23 Thread Joelle van Dyne
I think it is acceptable policy to not test against older macOS versions, although I want to point out that a significant population of macOS users are still on macOS 11-13. It is bad practice to just crash when a function is not found. This is why the compiler throws a warning asking you to explic

Re: [PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-12-23 Thread Peter Xu
On Fri, Dec 20, 2024 at 10:38:40PM +0100, Philippe Mathieu-Daudé wrote: > > OTOH, this works for me: > > > > ===8<=== > > diff --git a/linux-user/main.c b/linux-user/main.c > > index b09af8d436..009b7695f2 100644 > > --- a/linux-user/main.c > > +++ b/linux-user/main.c > > @@ -819,6 +819,11 @@ int

Re: [PATCH 01/17] replay: Fix migration use of clock for statistics

2024-12-23 Thread Peter Xu
On Sat, Dec 21, 2024 at 01:02:01PM +1000, Nicholas Piggin wrote: > On Sat Dec 21, 2024 at 2:31 AM AEST, Peter Xu wrote: > > On Fri, Dec 20, 2024 at 08:42:03PM +1000, Nicholas Piggin wrote: > > > Migration reads CLOCK_HOST when not holding the replay_mutex, which > > > asserts when recording a trace

Re: [PATCH v15 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-12-23 Thread Philippe Mathieu-Daudé
Hi Phil, On 23/12/24 14:53, Phil Dennis-Jordan wrote: On Thu, 19 Dec 2024 at 11:50, Akihiko Odaki > wrote: Reviewing "[PATCH v2 6/6] hw/vmapple: XHCI controller's interrupt mapping workaround for macOS", I found a few problems so I'm adding comments

Re: [PATCH v2 0/2] Move net backend cleanup to NIC cleanup

2024-12-23 Thread Eugenio Perez Martin
On Fri, Dec 20, 2024 at 10:02 PM Michael Tokarev wrote: > > 12.09.2024 19:54, Eugenio Pérez wrote: > > Commit a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net > > structures if peer nic is present") effectively delayed the backend > > cleanup, allowing the frontend or the guest to access

Re: [PATCH v15 09/15] gpex: Allow more than 4 legacy IRQs

2024-12-23 Thread Philippe Mathieu-Daudé
On 18/12/24 21:20, Phil Dennis-Jordan wrote: From: Alexander Graf Some boards such as vmapple don't do real legacy PCI IRQ swizzling. Instead, they just keep allocating more board IRQ lines for each new legacy IRQ. Let's support that mode by giving instantiators a new "nr_irqs" property they ca

Re: [PATCH v15 05/15] MAINTAINERS: Add myself as maintainer for apple-gfx, reviewer for HVF

2024-12-23 Thread Philippe Mathieu-Daudé
On 18/12/24 21:20, Phil Dennis-Jordan wrote: I'm happy to take responsibility for the macOS PV graphics code. As HVF patches don't seem to get much attention at the moment, I'm also adding myself as designated reviewer for HVF and x86 HVF to try and improve that. I anticipate that the resulting

Re: [PATCH 2/3] target/loongarch: Fix LLSC for LoongArch32

2024-12-23 Thread Richard Henderson
On 12/22/24 15:40, Jiaxun Yang wrote: @@ -9,7 +9,7 @@ static bool gen_ll(DisasContext *ctx, arg_rr_i *a, MemOp mop) TCGv src1 = gpr_src(ctx, a->rj, EXT_NONE); TCGv t0 = make_address_i(ctx, src1, a->imm); ... @@ -28,7 +28,8 @@ static bool gen_sc(DisasContext *ctx, arg_rr_i *a, MemOp

Re: [PATCH v15 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-12-23 Thread Phil Dennis-Jordan
On Thu, 19 Dec 2024 at 11:50, Akihiko Odaki wrote: > Reviewing "[PATCH v2 6/6] hw/vmapple: XHCI controller's interrupt > mapping workaround for macOS", I found a few problems so I'm adding > comments for them: > > On 2024/12/19 5:20, Phil Dennis-Jordan wrote: > > From: Alexander Graf > > > > App