[PATCH v2 1/2] hw/openrisc/openrisc_sim: keep serial@90000000 as default

2024-11-30 Thread Stafford Horne
From: Ahmad Fatoum We used to only have a single UART on the platform and it was located at address 0x9000. When the number of UARTs was increased to 4, the first UART remained at it's location, but instead of being the first one to be registered, it became the last. This caused QEMU to pick

[PATCH v2 0/2] Misc OpenRISC fixes for 9.2.0

2024-11-30 Thread Stafford Horne
This series has 2 fixes for OpenRISC that came in over that past few months. Since v1: - Use DIVIDE_ROUND_UP instead of open coding as pointed out by Richard - Fix off-by-1 bug in TTCR patch pointed out by Richard - Fix commit message and reverse registration order as pointed out by Peter. Ahm

[PATCH v2 2/2] hw/openrisc: Fixed undercounting of TTCR in continuous mode

2024-11-30 Thread Stafford Horne
From: Joel Holdsworth In the existing design, TTCR is prone to undercounting when running in continuous mode. This manifests as a timer interrupt appearing to trigger a few cycles prior to the deadline set in SPR_TTMR_TP. When the timer triggers, the virtual time delta in nanoseconds between the

Re: [PATCH 1/2] hw/openrisc/openrisc_sim: keep serial@90000000 as default

2024-11-30 Thread Stafford Horne
On Sun, Dec 01, 2024 at 06:44:39AM +, Stafford Horne wrote: > On Mon, Nov 25, 2024 at 02:02:35PM +, Peter Maydell wrote: > > On Sat, 23 Nov 2024 at 10:39, Stafford Horne wrote: > > > > > > From: Ahmad Fatoum > > > > > > We used to only have a single UART on the platform and it was located

Re: [PATCH 1/2] hw/openrisc/openrisc_sim: keep serial@90000000 as default

2024-11-30 Thread Stafford Horne
On Mon, Nov 25, 2024 at 02:02:35PM +, Peter Maydell wrote: > On Sat, 23 Nov 2024 at 10:39, Stafford Horne wrote: > > > > From: Ahmad Fatoum > > > > We used to only have a single UART on the platform and it was located at > > address 0x9000. When the number of UARTs was increased to 4, the

Re: [PATCH] hw/virtio/virtio-mem: Prohibit unplugging when size <= requested_size

2024-11-30 Thread David Hildenbrand
On 30.11.24 13:48, Wei Chen wrote: > That doesn't explain the full story about MIGRATE_UNMOVABLE. I assume > one precondition is missing in your explanation. I have double-checked the source code. My initial description of the process seems somewhat imprecise. vIOMMU does not convert pages to

Re: [PATCH 05/22] tests/functional: remove duplicated 'which' function impl

2024-11-30 Thread Richard Henderson
On 11/29/24 11:31, Daniel P. Berrangé wrote: Put the 'which' function into shared code. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/__init__.py | 2 +- tests/functional/qemu_test/cmd.py | 10 ++ tests/functional/test_acpi_bits.py | 13 + t

Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment

2024-11-30 Thread Yong Huang
On Fri, Nov 29, 2024 at 9:44 PM Fabiano Rosas wrote: > Fabiano Rosas writes: > > > Yong Huang writes: > > > >> On Wed, Oct 23, 2024 at 11:06 PM Fabiano Rosas wrote: > >> > >>> yong.hu...@smartx.com writes: > >>> > >>> > From: Hyman Huang > >>> > > >>> > v3: > >>> > 1. Remove the two redundant

Re: [PATCH] hw/virtio/virtio-mem: Prohibit unplugging when size <= requested_size

2024-11-30 Thread Wei Chen
> That doesn't explain the full story about MIGRATE_UNMOVABLE. I assume > one precondition is missing in your explanation. I have double-checked the source code. My initial description of the process seems somewhat imprecise. vIOMMU does not convert pages to UNMOVABLE during pinning, it is that pi

Re: [PATCH 14/22] tests/functional: remove redundant 'rmtree' call

2024-11-30 Thread Thomas Huth
On 29/11/2024 18.31, Daniel P. Berrangé wrote: Everything in the scratch directory is automatically purged. Calling 'rmtree' again breaks the ability to optionally preserve the scratch directory contents. Signed-off-by: Daniel P. Berrangé --- tests/functional/test_sh4eb_r2d.py | 3 --- 1 fil

Re: [PATCH 05/22] tests/functional: remove duplicated 'which' function impl

2024-11-30 Thread Thomas Huth
On 29/11/2024 18.31, Daniel P. Berrangé wrote: Put the 'which' function into shared code. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/__init__.py | 2 +- tests/functional/qemu_test/cmd.py | 10 ++ tests/functional/test_acpi_bits.py | 13 +

Re: [PATCH 03/22] tests/functional: remove duplicated 'qemu_test' import statements

2024-11-30 Thread Thomas Huth
On 29/11/2024 18.31, Daniel P. Berrangé wrote: Group all imports that originate in the 'qemu_test' package into one statement. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/tuxruntest.py | 9 + tests/functional/test_aarch64_raspi4.py | 4 ++-- t

Re: [PATCH 04/22] tests/functional: remove pointless with statement

2024-11-30 Thread Thomas Huth
On 29/11/2024 18.31, Daniel P. Berrangé wrote: The xorriso command directly writes to 'filename', so the surrounding 'with' statement is pointless. Signed-off-by: Daniel P. Berrangé --- tests/functional/test_ppc64_hv.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 02/22] tests/functional: remove unused system imports

2024-11-30 Thread Thomas Huth
On 29/11/2024 18.31, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- tests/functional/test_aarch64_sbsaref.py | 1 - tests/functional/test_acpi_bits.py | 1 - tests/functional/test_m68k_mcf5208evb.py | 2 -- tests/functional/test_microblaze_s3adsp1800

Re: [PATCH 01/22] tests/functional: increase timeouts for arm sx1 test

2024-11-30 Thread Thomas Huth
On 29/11/2024 18.30, Daniel P. Berrangé wrote: When under high load the test VM does not complete running in the default 30 second timeout. Double it to give more headroom. Signed-off-by: Daniel P. Berrangé --- tests/functional/test_arm_sx1.py | 6 +++--- 1 file changed, 3 insertions(+), 3 d