On 29/11/2024 18.31, Daniel P. Berrangé wrote:
Group all imports that originate in the 'qemu_test' package into
one statement.
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
---
tests/functional/qemu_test/tuxruntest.py | 9 +++++----
tests/functional/test_aarch64_raspi4.py | 4 ++--
tests/functional/test_aarch64_sbsaref.py | 5 ++---
tests/functional/test_aarch64_sbsaref_alpine.py | 5 ++---
tests/functional/test_aarch64_sbsaref_freebsd.py | 5 ++---
tests/functional/test_aarch64_virt.py | 6 ++----
tests/functional/test_arm_aspeed.py | 7 +++----
tests/functional/test_arm_bflt.py | 3 +--
tests/functional/test_arm_bpim2u.py | 8 ++++----
tests/functional/test_arm_canona1100.py | 3 +--
tests/functional/test_arm_integratorcp.py | 3 +--
tests/functional/test_arm_orangepi.py | 10 +++++-----
tests/functional/test_arm_raspi2.py | 4 ++--
tests/functional/test_loongarch64_virt.py | 6 +++---
tests/functional/test_microblaze_s3adsp1800.py | 5 ++---
tests/functional/test_microblazeel_s3adsp1800.py | 5 ++---
tests/functional/test_mips64el_fuloong2e.py | 7 ++++---
tests/functional/test_mips64el_loongson3v.py | 3 +--
tests/functional/test_mips64el_malta.py | 4 ++--
tests/functional/test_mipsel_malta.py | 6 +++---
tests/functional/test_multiprocess.py | 4 ++--
tests/functional/test_netdev_ethtool.py | 3 +--
tests/functional/test_ppc64_hv.py | 4 ++--
tests/functional/test_ppc64_powernv.py | 3 +--
tests/functional/test_ppc64_pseries.py | 3 +--
tests/functional/test_ppc_405.py | 6 +++---
tests/functional/test_ppc_40p.py | 3 +--
tests/functional/test_ppc_74xx.py | 3 +--
tests/functional/test_ppc_amiga.py | 3 +--
tests/functional/test_ppc_bamboo.py | 6 +++---
tests/functional/test_ppc_mpc8544ds.py | 3 +--
tests/functional/test_ppc_virtex_ml507.py | 3 +--
tests/functional/test_riscv_opensbi.py | 4 ++--
tests/functional/test_rx_gdbsim.py | 6 +++---
tests/functional/test_s390x_ccw_virtio.py | 6 +++---
tests/functional/test_s390x_topology.py | 7 +++----
tests/functional/test_sh4eb_r2d.py | 4 ++--
tests/functional/test_sparc64_sun4u.py | 3 +--
tests/functional/test_virtio_gpu.py | 10 ++++------
39 files changed, 85 insertions(+), 107 deletions(-)
diff --git a/tests/functional/qemu_test/tuxruntest.py
b/tests/functional/qemu_test/tuxruntest.py
index ab3b27da43..7c0456923e 100644
--- a/tests/functional/qemu_test/tuxruntest.py
+++ b/tests/functional/qemu_test/tuxruntest.py
@@ -13,10 +13,11 @@
import stat
import time
-from qemu_test import QemuSystemTest
-from qemu_test import exec_command, exec_command_and_wait_for_pattern
-from qemu_test import wait_for_console_pattern
-from qemu_test import has_cmd, run_cmd, get_qemu_img
+from qemu_test import (QemuSystemTest, exec_command,
+ exec_command_and_wait_for_pattern,
+ wait_for_console_pattern,
+ has_cmd, run_cmd, get_qemu_img)
Is there a real advantage in writing it this way? For most files, this not
seem to reduce the lines of code, so at a quick glance, it rather looks like
unnecessary code churn to me...?
Thomas
