Re: [PATCH v3 00/17] intel_iommu: Enable stage-1 translation for emulated device

Hi Zhenzhong, Thanks for posting a new version. I think it starting to look good. Just a few comments. >cmd On 11/09/2024 07:22, Zhenzhong Duan wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is sa

Re: [PATCH v3 15/17] intel_iommu: Modify x-scalable-mode to be string option to expose scalable modern mode

Reviewed-by: Clément Mathieu--Drif On 11/09/2024 07:22, Zhenzhong Duan wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > > From: Yi Liu > > Intel VT-d 3.0 introduces scalable mode, and i

Re: [PATCH v3 04/17] intel_iommu: Flush stage-2 cache in PASID-selective PASID-based iotlb invalidation

Reviewed-by: Clément Mathieu--Drif On 11/09/2024 07:22, Zhenzhong Duan wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > > Per spec 6.5.2.4, PADID-selective PASID-based iotlb invalidation

Re: [PATCH] arm/kvm: add support for MTE

On 10-09-2024 05:53 pm, Peter Maydell wrote: On Tue, 10 Sept 2024 at 12:57, Ganapatrao Kulkarni wrote: On 16-07-2024 09:15 pm, Peter Maydell wrote: Since Cornelia first wrote the patch this is based on, we've landed gdbstub support for MTE (so gdb can find out which addresses in the memory

[PULL 03/10] tests/docker: use debian-all-test-cross for mips64el tests

While the mips64el cross compilation environment is busted in Debian we can use the debian-all-test-cross image for building TCG tests like we do in the CI. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-4-alex.ben...@linaro.org> diff --git a/confi

[PULL 01/10] tests/docker: remove debian-armel-cross

As debian-11 transitions to LTS we are starting to have problems building the image. While we could update to a later Debian building a 32 bit QEMU without modern floating point is niche host amongst the few remaining 32 bit hosts we regularly build for. For now we still have armhf-debian-cross-con

[PULL 00/10] testing and gdbstub updates

The following changes since commit a66f28df650166ae8b50c992eea45e7b247f4143: Merge tag 'migration-20240909-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-09-10 11:19:22 +0100) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-testing-g

[PULL 10/10] tests/tcg/aarch64: Extend MTE gdbstub tests to system mode

From: Gustavo Romero Extend MTE gdbstub tests to also run in system mode (share tests between user mode and system mode). The tests will only run if a version of GDB that supports MTE on baremetal is available in the test environment and if available compiler supports the 'memtag' flag (-march=ar

[PULL 06/10] gdbstub: Use specific MMU index when probing MTE addresses

From: Gustavo Romero Use cpu_mmu_index() to determine the specific translation regime (MMU index) before probing addresses using allocation_tag_mem_probe(). Currently, the MMU index is hardcoded to 0 and only works for user mode. By obtaining the specific MMU index according to the translation r

[PULL 05/10] scripts/ci: update the gitlab-runner playbook

The upstream install instructions: https://docs.gitlab.com/runner/install/linux-repository.html Now refer to repositories and a setup script. Modernise the playbook to use the preferred delivery method. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154

[PULL 02/10] tests/docker: update debian i686 and mipsel images to bookworm

Whatever issues there were which stopped these being updates when the rest were have now been resolved. However mips64el continues to be broken so don't update it here. Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-3-

[PULL 07/10] gdbstub: Add support for MTE in system mode

From: Gustavo Romero This commit makes handle_q_memtag, handle_q_isaddresstagged, and handle_Q_memtag stubs build for system mode, allowing all GDB 'memory-tag' subcommands to work with QEMU gdbstub on aarch64 system mode. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/620 Signed-off-by

[PULL 08/10] tests/guest-debug: Support passing arguments to the GDB test script

From: Gustavo Romero This commit adds support for passing arguments to the GDB test scripts so it's possible to parse the args in an "argparse way" in the test scripts launched by the runner. The arguments should be preceded by -- when passed to the runner. For example, passing "--help" arg to th

[PULL 09/10] tests/tcg/aarch64: Improve linker script organization

From: Gustavo Romero Improve kernel.ld linker script organization by using MEMORY command. Signed-off-by: Richard Henderson Signed-off-by: Gustavo Romero Message-Id: <20240906143316.657436-5-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-10-alex.ben.

[PULL 04/10] docs/devel: fix duplicate line

I guess the same change came in via two patch series. Remove the repetition. Fixes: 2a851fca9f (docs/devel: remind developers to run CI container pipeline when updating images) Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-5-alex.ben...@linaro.org>

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

On 9/10/24 02:34, Peter Maydell wrote: > On Mon, 9 Sept 2024 at 18:40, Philippe Mathieu-Daudé > wrote: >> >> Hi, >> >> (Cc'ing Arnaud & Inès who are listed as maintainers) >> >> On 6/9/24 18:12, Peter Maydell wrote: >>> On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: These changes

Re: [PATCH v3 03/17] intel_iommu: Add a placeholder variable for scalable modern mode

On 11/09/2024 07:22, Zhenzhong Duan wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > > Add an new element scalable_mode in IntelIOMMUState to mark scalable > modern mode, this element wil

Re: [PATCH 36/39] ui: remove break after g_assert_not_reached()

On 11/9/24 00:16, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- ui/qemu-pixman.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 07/39] hw/watchdog: replace assert(0) with g_assert_not_reached()

On 11/9/24 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/watchdog/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 28/39] hw/misc: remove break after g_assert_not_reached()

On 11/9/24 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/misc/imx6_ccm.c | 1 - hw/misc/mac_via.c | 2 -- 2 files changed, 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 30/39] hw/pci-host: remove break after g_assert_not_reached()

On 11/9/24 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/pci-host/gt64120.c | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 27/39] hw/gpio: remove break after g_assert_not_reached()

On 11/9/24 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/gpio/nrf51_gpio.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 05/39] hw/core: replace assert(0) with g_assert_not_reached()

On 11/9/24 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/core/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 10/39] system: replace assert(0) with g_assert_not_reached()

On 11/9/24 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- system/rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 04/39] hw/char: replace assert(0) with g_assert_not_reached()

On 11/9/24 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/char/avr_usart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2] docs: fix vhost-user protocol doc

Add a ref link to Memory region description and Multiple Memory region description. Desciptions about memory regions are merged into one line. Add extra type(64 bits) to Log description structure fields Fix ’s to 's >On Sun, Sep 08, 2024 at 10:49:54PM +0800, luzhixing12345 wrote: >> >On Fri, S

Re: [PULL 00/10] Crypto fixes patches

On 9/9/24 17:16, Daniel P. Berrangé wrote: Various crypto fixes * Support sha384 with glib crypto backend * Improve error reporting for unsupported cipher modes * Avoid memory leak when bad cipher mode is given * Run pbkdf tests on macOS * Runtime check for pbkdf hash impls with gnutl

Re: [PATCH v2] adb-mouse: convert to use QemuInputHandler

On 10/9/24 22:36, Mark Cave-Ayland wrote: On 10/09/2024 15:48, Philippe Mathieu-Daudé wrote: Hi Mark, On 7/9/24 19:37, Mark Cave-Ayland wrote: Update the ADB mouse implementation to use QemuInputHandler instead of the legacy qemu_add_mouse_event_handler() function. Signed-off-by: Mark Cave-

Re: [PATCH 19/39] hw/pci: replace assert(false) with g_assert_not_reached()

Hi Pierrick, On 11/9/24 00:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index f0508682d2b..c6950e21bd4 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pc

Re: [PATCH 12/39] tests/qtest: replace assert(0) with g_assert_not_reached()

On 11/09/2024 00.15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- tests/qtest/ipmi-bt-test.c | 2 +- tests/qtest/ipmi-kcs-test.c | 4 ++-- tests/qtest/rtl8139-test.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qt

Re: [PATCH 14/39] include/hw/s390x: replace assert(false) with g_assert_not_reached()

On 11/09/2024 00.15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- include/hw/s390x/cpu-topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h index c064f427e94..dcb25956a64 100644 --- a/in

[PATCH v3 13/17] intel_iommu: piotlb invalidation should notify unmap

This is used by some emulated devices which caches address translation result. When piotlb invalidation issued in guest, those caches should be refreshed. For device that does not implement ATS capability or disable it but still caches the translation result, it is better to implement ATS cap or e

QEMU commit 0a923be2f642 broke my or1k image.

Grab this tarball, extract it, and ./run-qemu.sh. It's a simple linux+initramfs image that boots to a shell prompt. https://landley.net/bin/mkroot/latest/or1k.tgz QEMU 7.0.0 ran that linux-or1k image, but newer qemu does not. I besected the issue to qemu commit 0a923be2f642, and it's still brok

[PATCH v3 14/17] intel_iommu: Set default aw_bits to 48 in scalable modern mode

According to VTD spec, stage-1 page table could support 4-level and 5-level paging. However, 5-level paging translation emulation is unsupported yet. That means the only supported value for aw_bits is 48. So default aw_bits to 48 in scalable modern mode. In other cases, it is still default to 39

[PATCH v3 10/17] intel_iommu: Process PASID-based iotlb invalidation

PASID-based iotlb (piotlb) is used during walking Intel VT-d stage-1 page table. This emulates the stage-1 page table iotlb invalidation requested by a PASID-based IOTLB Invalidate Descriptor (P_IOTLB). Signed-off-by: Yi Liu Signed-off-by: Zhenzhong Duan Reviewed-by: Clément Mathieu--Drif ---

[PATCH v3 02/17] intel_iommu: Make pasid entry type check accurate

When guest configures Nested Translation(011b) or First-stage Translation only (001b), type check passed unaccurately. Fails the type check in those cases as their simulation isn't supported yet. Fixes: fb43cf739e1 ("intel_iommu: scalable mode emulation") Suggested-by: Yi Liu Signed-off-by: Zhen

[PATCH v3 06/17] intel_iommu: Implement stage-1 translation

From: Yi Liu This adds stage-1 page table walking to support stage-1 only transltion in scalable modern mode. Signed-off-by: Yi Liu Co-developed-by: Clément Mathieu--Drif Signed-off-by: Clément Mathieu--Drif Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu_intern

[PATCH v3 17/17] tests/qtest: Add intel-iommu test

Add the framework to test the intel-iommu device. Currently only tested cap/ecap bits correctness in scalable modern mode. Also tested cap/ecap bits consistency before and after system reset. Signed-off-by: Zhenzhong Duan Acked-by: Thomas Huth Reviewed-by: Clément Mathieu--Drif --- MAINTAINERS

[PATCH v3 15/17] intel_iommu: Modify x-scalable-mode to be string option to expose scalable modern mode

From: Yi Liu Intel VT-d 3.0 introduces scalable mode, and it has a bunch of capabilities related to scalable mode translation, thus there are multiple combinations. While this vIOMMU implementation wants to simplify it for user by providing typical combinations. User could config it by "x-scalabl

[PATCH v3 11/17] intel_iommu: Add an internal API to find an address space with PASID

From: Clément Mathieu--Drif This will be used to implement the device IOTLB invalidation Signed-off-by: Clément Mathieu--Drif Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/h

[PATCH v3 05/17] intel_iommu: Rename slpte to pte

From: Yi Liu Because we will support both FST(a.k.a, FLT) and SST(a.k.a, SLT) translation, rename variable and functions from slpte to pte whenever possible. But some are SST only, they are renamed with sl_ prefix. Signed-off-by: Yi Liu Co-developed-by: Clément Mathieu--Drif Signed-off-by: Cl

[PATCH v3 16/17] intel_iommu: Introduce a property to control FS1GP cap bit setting

This gives user flexibility to turn off FS1GP for debug purpose. It is also useful for future nesting feature. When host IOMMU doesn't support FS1GP but vIOMMU does, nested page table on host side works after turn FS1GP off in vIOMMU. This property has no effect when vIOMMU isn't in scalable mode

[PATCH v3 01/17] intel_iommu: Use the latest fault reasons defined by spec

From: Yu Zhang Spec revision 3.0 or above defines more detailed fault reasons for scalable mode. So introduce them into emulation code, see spec section 7.1.2 for details. Note spec revision has no relation with VERSION register, Guest kernel should not use that register to judge what features a

[PATCH v3 07/17] intel_iommu: Check if the input address is canonical

From: Clément Mathieu--Drif First stage translation must fail if the address to translate is not canonical. Signed-off-by: Clément Mathieu--Drif Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu_internal.h | 2 ++ hw/i386/intel_iommu.c | 23 +++ 2 files chang

[PATCH v3 08/17] intel_iommu: Set accessed and dirty bits during first stage translation

From: Clément Mathieu--Drif Signed-off-by: Clément Mathieu--Drif Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu_internal.h | 3 +++ hw/i386/intel_iommu.c | 25 - 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu_internal

[PATCH v3 12/17] intel_iommu: Add support for PASID-based device IOTLB invalidation

From: Clément Mathieu--Drif Signed-off-by: Clément Mathieu--Drif Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu_internal.h | 11 hw/i386/intel_iommu.c | 50 ++ 2 files changed, 61 insertions(+) diff --git a/hw/i386/intel_iommu_internal.

[PATCH v3 04/17] intel_iommu: Flush stage-2 cache in PASID-selective PASID-based iotlb invalidation

Per spec 6.5.2.4, PADID-selective PASID-based iotlb invalidation will flush stage-2 iotlb entries with matching domain id and pasid. With scalable modern mode introduced, guest could send PASID-selective PASID-based iotlb invalidation to flush both stage-1 and stage-2 entries. By this chance, rem

[PATCH v3 09/17] intel_iommu: Flush stage-1 cache in iotlb invalidation

According to spec, Page-Selective-within-Domain Invalidation (11b): 1. IOTLB entries caching second-stage mappings (PGTT=010b) or pass-through (PGTT=100b) mappings associated with the specified domain-id and the input-address range are invalidated. 2. IOTLB entries caching first-stage (PGTT=001b)

[PATCH v3 00/17] intel_iommu: Enable stage-1 translation for emulated device

Hi, Per Jason Wang's suggestion, iommufd nesting series[1] is split into "Enable stage-1 translation for emulated device" series and "Enable stage-1 translation for passthrough device" series. This series enables stage-1 translation support for emulated device in intel iommu which we called "mode

[PATCH v3 03/17] intel_iommu: Add a placeholder variable for scalable modern mode

Add an new element scalable_mode in IntelIOMMUState to mark scalable modern mode, this element will be exposed as an intel_iommu property finally. For now, it's only a placehholder and used for address width compatibility check and block host device passthrough until nesting is supported. Signed-

[PATCH] hw/char/stm32l4x5_usart.c: Enable USART ACK bit response

SW modifying USART_CR1 TE bit should cuase HW to respond by altering USART_ISR TEACK bit, and likewise for RE and REACK bit. This resolves some but not all issues necessary for the official STM USART HAL driver to function as is. Fixes: 87b77e6e01ca ("hw/char/stm32l4x5_usart: Enable serial read a

Re: [PATCH v3 0/1] Add support for generating OpenSBI domains in the device tree

On Wed, Sep 11, 2024 at 7:08 AM Gregor Haas wrote: > > Hi Alistair! > > On Sun, Sep 8, 2024 at 8:27 PM Alistair Francis wrote: >> >> On Tue, Aug 6, 2024 at 7:05 AM Gregor Haas wrote: >> > >> > This patch series adds support for specifying OpenSBI domains on the QEMU >> > command line. A simple e

Re: [PATCH 39/39] scripts/checkpatch.pl: emit error when using assert(false)

On 9/10/24 15:16, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- scripts/checkpatch.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 65b6f46f905..fa9c12230eb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.p

Re: [PATCH 38/39] tcg/loongarch64: remove break after g_assert_not_reached()

On 9/10/24 15:16, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- tcg/loongarch64/tcg-target.c.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc index 5b7ed5c176b..973601aec36 100644 --- a/tcg/loongarch64/tcg

Re: [PATCH 37/39] fpu: remove break after g_assert_not_reached()

On 9/10/24 15:16, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- fpu/softfloat-parts.c.inc | 2 -- 1 file changed, 2 deletions(-) diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc index a44649f4f4a..cc6e06b9761 100644 --- a/fpu/softfloat-parts.c.inc +++ b/fpu/so

Re: [PATCH 36/39] ui: remove break after g_assert_not_reached()

On 9/10/24 15:16, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- ui/qemu-pixman.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c index 5ca55dd1998..6cada8b45e1 100644 --- a/ui/qemu-pixman.c +++ b/ui/qemu-pixman.c @@ -49,7 +49,6 @@ PixelForm

Re: [PATCH 34/39] target/riscv: remove break after g_assert_not_reached()

On 9/10/24 15:16, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/riscv/monitor.c | 1 - target/riscv/insn_trans/trans_rvv.c.inc | 2 -- 2 files changed, 3 deletions(-) diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c index f5b1ffe6c3e..15

Re: [PATCH 35/39] tests/qtest: remove break after g_assert_not_reached()

On 9/10/24 15:16, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- tests/qtest/migration-helpers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c index a43d180c807..00259338833 100644 --- a/tests/qtest/migration-

Re: [PATCH 32/39] hw/tpm: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/tpm/tpm_spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c index e084e987e6e..5f7a0dfc617 100644 --- a/hw/tpm/tpm_spapr.c +++ b/hw/tpm/tpm_spapr.c @@ -206,7 +206,6

Re: [PATCH 33/39] target/arm: remove break after g_assert_not_reached()

On 9/10/24 15:16, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/hyp_gdbstub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index f120d55caab..1e861263b3d 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/h

Re: [PATCH 31/39] hw/scsi: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/scsi/virtio-scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 9f02ceea099..6637cfeaf51 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@

Re: [PATCH 30/39] hw/pci-host: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/pci-host/gt64120.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/pci-host/gt64120.c b/hw/pci-host/gt64120.c index 33607dfbec4..58557416629 100644 --- a/hw/pci-host/gt64120.c +++ b/hw/pci-host/gt64120.c

Re: [PATCH 29/39] hw/net: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/net/net_rx_pkt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 6b9c4c9559d..0ea87344745 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -376,7 +3

Re: [PATCH 28/39] hw/misc: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/misc/imx6_ccm.c | 1 - hw/misc/mac_via.c | 2 -- 2 files changed, 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 26/39] hw/acpi: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/acpi/aml-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 006c506a375..34e0ddbde87 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -535,7 +5

Re: [PATCH 27/39] hw/gpio: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/gpio/nrf51_gpio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/gpio/nrf51_gpio.c b/hw/gpio/nrf51_gpio.c index ffc7dff7964..f259be651e1 100644 --- a/hw/gpio/nrf51_gpio.c +++ b/hw/gpio/nrf51_gpio.c @@ -40,

Re: [PATCH 25/39] block: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- block/ssh.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/ssh.c b/block/ssh.c index 27d582e0e3d..871e1d47534 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -474,7 +474,6 @@ static int check_host_key(BDRVSS

Re: [PATCH 24/39] accel/tcg: remove break after g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- accel/tcg/plugin-gen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index ec89a085b43..2ee4c22befd 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen

Re: [PATCH 23/39] tests/qtest: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- tests/qtest/numa-test.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 22/39] target/i386/kvm: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 2fa88ef1e37..308b0e1cb37 100644 --- a/target/i386/kvm/kvm.c +++ b/tar

Re: [PATCH 21/39] migration: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- migration/dirtyrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 1d9db812990..a28c07327e8 100644 --- a/migration/dirtyrate.c +++ b/migrati

Re: [PATCH 21/39] migration: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- migration/dirtyrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 1d9db812990..a28c07327e8 100644 --- a/migration/dirtyrate.c +++ b/migrati

Re: [PATCH 20/39] hw/ppc: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/ppc/spapr_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index cb05874..38ac1cb7866 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/

Re: [PATCH 19/39] hw/pci: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index f0508682d2b..c6950e21bd4 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @

Re: [PATCH 18/39] hw/nvme: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/nvme/ctrl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 17/39] hw/net: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c| 2 +- hw/net/net_rx_pkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 16/39] hw/hyperv: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 6 +++--- hw/hyperv/vmbus.c | 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 15/39] block: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 70b19730a39..bdc6337826f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -5299,7 +5299,7 @@ qco

Re: [PATCH 14/39] include/hw/s390x: replace assert(false) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- include/hw/s390x/cpu-topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topology.h index c064f427e94..dcb25956a64 100644 --- a/inclu

Re: [PATCH 13/39] tests/unit: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- tests/unit/test-xs-node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-xs-node.c b/tests/unit/test-xs-node.c index ac94e7ed6c2..2f447a73fb8 100644 --- a/tests/unit/test-xs-

Re: [PATCH 12/39] tests/qtest: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- tests/qtest/ipmi-bt-test.c | 2 +- tests/qtest/ipmi-kcs-test.c | 4 ++-- tests/qtest/rtl8139-test.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 11/39] target/ppc: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/ppc/dfp_helper.c | 8 target/ppc/mmu_helper.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index 5967ea07a92..6ef31a480b7

Re: [PATCH 10/39] system: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- system/rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/rtc.c b/system/rtc.c index dc44576686e..216d2aee3ae 100644 --- a/system/rtc.c +++ b/system/rtc.c @@ -62,7 +62,7 @@ static time_

Re: [PATCH 09/39] qobject: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- qobject/qlit.c | 2 +- qobject/qnum.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qobject/qlit.c b/qobject/qlit.c index be8332136c2..a62865b6423 100644 --- a/qobject/qlit.c +++ b/qo

[PATCH v2 0/2] Add FDT table support with acpi ged pm register

ACPI ged is used for power management on LoongArch virt platform, in general it is parsed from acpi table. However if system boot directly from elf kernel, no UEFI bios is provided and acpi table cannot be used also. Here acpi ged pm register is exposed with FDT table, it is compatbile with syscon

[PATCH v2 2/2] hw/loongarch/virt: Add FDT table support with acpi ged pm register

ACPI ged is used for power management on LoongArch virt platform, in general it is parsed from acpi table. However if system boot directly from elf kernel, no UEFI bios is provided and acpi table cannot be used also. Here acpi ged pm register is exposed with FDT table, it is compatbile with syscon

[PATCH v2 1/2] acpi: ged: Add macro for acpi sleep control register

Macro definition is added for acpi sleep control register, so that ged emulation driver can use this, also it can be used in FDT table if ged is exposed with FDT table. Signed-off-by: Bibo Mao --- hw/acpi/generic_event_device.c | 6 +++--- hw/i386/acpi-microvm.c | 2 +- h

Re: [PATCH for-9.2 v15 00/11] hw/pci: SR-IOV related fixes and improvements

On 2024/09/11 0:27, Michael S. Tsirkin wrote: On Tue, Sep 10, 2024 at 04:13:14PM +0200, Cédric Le Goater wrote: On 9/10/24 15:34, Michael S. Tsirkin wrote: On Tue, Sep 10, 2024 at 03:21:54PM +0200, Cédric Le Goater wrote: On 9/10/24 11:33, Akihiko Odaki wrote: On 2024/09/10 18:21, Michael S.

Re: [PATCH] virtio/vhost-user: fix qemu crash when hotunplug vhost-user-net device

Stefano Garzarella 于2024年9月3日周二 18:05写道： > > On Wed, Aug 28, 2024 at 02:50:57PM GMT, Zhenguo Yao wrote: > >I am very sorry that my previous description was not accurate. Below I > >will describe the steps to reproduce this problem and my analysis in > >detail.The conditions for reproducing this pr

Re: [PATCH 08/39] migration: replace assert(0) with g_assert_not_reached()

On 9/10/24 19:17, Richard Henderson wrote: On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- migration/migration-hmp-cmds.c | 2 +- migration/postcopy-ram.c | 14 +++--- migration/ram.c| 6 +++--- 3 files changed, 11 insertion

about "-netdev id=id" User Documentation

on qemu-manpage (https://www.qemu.org/docs/master/system/qemu-manpage.html) -netdev user,id=id[,option][,option][,...] ... id=id Assign symbolic name for use in monitor commands. on qemu-wikipage (https://wiki.qemu.org/Documentation/Networking) -netdev TYPE,id=NAME,... The id option gives the

RE: [PATCH v2 00/17] intel_iommu: Enable stage-1 translation for emulated device

Hi Clement, Yes, I'll send a v3 in this week. Thanks Zhenzhong >-Original Message- >From: CLEMENT MATHIEU--DRIF >Subject: Re: [PATCH v2 00/17] intel_iommu: Enable stage-1 translation for >emulated device > >Hi Zhenzhong, > >Do you plan to post a v3 for this series? > >Thanks > >cmd > >O

Re: [PATCH 08/39] migration: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- migration/migration-hmp-cmds.c | 2 +- migration/postcopy-ram.c | 14 +++--- migration/ram.c| 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/migration/mi

Re: [PATCH 07/39] hw/watchdog: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/watchdog/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/watchdog/watchdog.c b/hw/watchdog/watchdog.c index 955046161bf..d0ce3c4ac55 100644 --- a/hw/watchdog/watchdog.c +++ b/hw/

Re: [PATCH 06/39] hw/net: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/i82596.c b/hw/net/i82596.c index 6cc8292a65a..cd416a00ffa 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -282,7 +282,

Re: [PATCH] tests/functional/qemu_test: Use Python hashlib instead of external programs

On 9/10/2024 5:26 PM, Brad Smith wrote: On 2024-09-10 4:17 p.m., Thomas Huth wrote: Some systems (like OpenBSD) do not have the sha256sum or sha512sum programs installed by default. Use the Python hashlib instead so we don't have to rely on the external programs. On OpenBSD they're named sh

Re: [PATCH v4 2/2] hw/char: sifive_uart: Print uart characters async

On Wed, Sep 11, 2024 at 6:35 AM Mark Cave-Ayland wrote: > > On 10/09/2024 05:54, Alistair Francis wrote: > > > The current approach of using qemu_chr_fe_write() and ignoring the > > return values results in dropped characters [1]. > > > > Let's update the SiFive UART to use a async sifive_uart_xmi

Re: [PATCH 05/39] hw/core: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/core/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index f8ce332cfe9..14283293b42 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -380,7 +380,7 @@

Re: [PATCH 04/39] hw/char: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/char/avr_usart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/avr_usart.c b/hw/char/avr_usart.c index 5bcf9db0b78..e738a2ca97e 100644 --- a/hw/char/avr_usart.c +++ b/hw/char/avr_usa

Re: [PATCH 03/39] hw/arm: replace assert(0) with g_assert_not_reached()

On 9/10/24 15:15, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- hw/arm/highbank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index c71b1a8db32..72c4cbff39d 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -1

  1   2   3   4   5   >