Re: [PATCH 06/39] hw/net: replace assert(0) with g_assert_not_reached()

[Richard Henderson]

On 9/10/24 15:15, Pierrick Bouvier wrote:

Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---
  hw/net/i82596.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/i82596.c b/hw/net/i82596.c
index 6cc8292a65a..cd416a00ffa 100644
--- a/hw/net/i82596.c
+++ b/hw/net/i82596.c
@@ -282,7 +282,7 @@ static void command_loop(I82596State *s)
          case CmdDump:
          case CmdDiagnose:
              printf("FIXME Command %d !!\n", cmd & 7);
-            assert(0);
+            g_assert_not_reached();
          }

/* update status */

Ug, printf.  Anyway,

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~