Re: [PATCH 5/8] tests/unit/test-smp-parse.c: Test "drawers" parameter in -smp

2024-02-29 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu Although drawer was introduced to -smp along with book by s390 machine, as a general topology level in QEMU that may be reused by other arches in the future, it is desirable to cover this parameter's parsing in a separate case. Signed-off-by:

Re: [PATCH 4/8] tests/unit/test-smp-parse.c: Test "books" parameter in -smp

2024-02-29 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu Although book was introduced to -smp along with drawer by s390 machine, as a general topology level in QEMU that may be reused by other arches in the future, it is desirable to cover this parameter's parsing in a separate case. Signed-off-by:

Re: [PATCH 3/8] tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer

2024-02-29 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu Currently, -smp supports 2 more new levels: book and drawer. It is necessary to consider the effects of book and drawer in the test cases to ensure that the calculations are correct. This is also the preparation to add new book and drawer tes

Re: [PATCH V2] migration: export fewer options

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 07:03:36AM +0100, Markus Armbruster wrote: > Steven Sistare writes: > > > Just a reminder, after our further discussion in the V1 thread, > > this patch is still what I propose, no updates needed. > > > > Markus, I think Peter is looking for your blessing on the new > > f

Re: [PATCH 2/8] tests/unit/test-smp-parse.c: Bump max_cpus to 4096

2024-02-29 Thread Zhao Liu
Hi Thomas, On Fri, Mar 01, 2024 at 08:40:54AM +0100, Thomas Huth wrote: > Date: Fri, 1 Mar 2024 08:40:54 +0100 > From: Thomas Huth > Subject: Re: [PATCH 2/8] tests/unit/test-smp-parse.c: Bump max_cpus to 4096 > > On 18/01/2024 15.48, Zhao Liu wrote: > > From: Zhao Liu > > > > PC mahine is tryi

Re: Intention to work on GSoC project

2024-02-29 Thread Eugenio Perez Martin
On Thu, Feb 29, 2024 at 9:32 AM Stefano Garzarella wrote: > > Hi Sahil, > > On Sun, Feb 25, 2024 at 10:38 PM Sahil wrote: > > > > Hi, > > > > My name is Sahil and I go by the pseudonym 'valdaarhun' on Github. I have > > never contributed to QEMU before but I have used it a few times as an end > >

Re: [PATCH v4 6/7] migration/multifd: Add zero pages and zero bytes counter to migration status interface.

2024-02-29 Thread Markus Armbruster
Hao Xiang writes: > This change extends the MigrationStatus interface to track zero pages > and zero bytes counter. > > Signed-off-by: Hao Xiang [...] > diff --git a/qapi/migration.json b/qapi/migration.json > index ca9561fbf1..03b850bab7 100644 > --- a/qapi/migration.json > +++ b/qapi/migrati

Re: [PATCH 2/8] tests/unit/test-smp-parse.c: Bump max_cpus to 4096

2024-02-29 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu PC mahine is trying to support up to 4096 vCPUs [1], so it's necessary s/mahine/machine/ to bump max_cpus in test-smp-parse to 4096 to cover the topological needs of future machines. [1]: https://lore.kernel.org/qemu-devel/20231208122611

Re: [PATCH 1/8] tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology case

2024-02-29 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu Use MAX_CPUS/MIN_CPUS micros in invalid topology case. This gives us the s/micros/macros/ Apart from that typo, FWIW: Reviewed-by: Thomas Huth flexibility to change the maximum and minimum CPU limits. Signed-off-by: Zhao Liu --- test

[PATCH] hw: gpio: introduce pcf8574 driver

2024-02-29 Thread Dmitriy Sharikhin
NXP PCF8574 and compatible ICs are simple I2C GPIO expanders. PCF8574 incorporates quasi-bidirectional IO, and simple communication protocol, when IO read is I2C byte read, and IO write is I2C byte write. User can think of it as open-drain port, when line high state is input and line low state is o

Re: [PATCH v4 2/7] migration/multifd: Implement zero page transmission on the multifd thread.

2024-02-29 Thread Markus Armbruster
Hao Xiang writes: > 1. Add zero_pages field in MultiFDPacket_t. > 2. Implements the zero page detection and handling on the multifd > threads for non-compression, zlib and zstd compression backends. > 3. Added a new value 'multifd' in ZeroPageDetection enumeration. > 4. Handle migration QEMU9.0 -

Re: [PATCH v4 1/7] migration/multifd: Add new migration option zero-page-detection.

2024-02-29 Thread Markus Armbruster
Hao Xiang writes: > This new parameter controls where the zero page checking is running. > 1. If this parameter is set to 'legacy', zero page checking is > done in the migration main thread. > 2. If this parameter is set to 'none', zero page checking is disabled. > > Signed-off-by: Hao Xiang QA

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-02-29 Thread Markus Armbruster
Peter Xu writes: > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: >> Based-on: 74aa0fb297 (migration: options incompatible with cpr) # >> peterx/migration-next >> >> Hi, >> >> In this v6: >> >> - Minor fixes to 17/23 and 19/23 > > The whole set looks good to me now. I plan to

Re: [PULL 26/29] contrib/plugins: extend execlog to track register changes

2024-02-29 Thread Zhao Liu
Hi Alex, I hit the following warnings (with "./configure --enable-werror"): /qemu/contrib/plugins/execlog.c: In function ‘registers_init’: /qemu/contrib/plugins/execlog.c:330:17: warning: ‘g_pattern_match_string’ is deprecated: Use 'g_pattern_spec_match_string' instead [-Wdeprecated-declaration

Re: [PATCH 17/17] target/s390x/cpu_models: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Zhao Liu
> > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > > index a63d990e4e8e..1a1c09612271 100644 > > --- a/target/s390x/cpu_models.c > > +++ b/target/s390x/cpu_models.c > > @@ -503,6 +503,7 @@ static void error_prepend_missing_feat(const char > > *name, void *opaque) > > static

Re: [PATCH 04/17] hw/scsi/vhost-scsi: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Zhao Liu
> > @@ -220,6 +220,7 @@ static int vhost_scsi_set_workers(VHostSCSICommon *vsc, > > bool per_virtqueue) > > static void vhost_scsi_realize(DeviceState *dev, Error **errp) > > { > > +ERRP_GUARD(); > > VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev); > > VHostSCSICommon *vsc = VHO

Re: [PATCH 01/17] hw/misc/ivshmem: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Zhao Liu
> > @@ -832,6 +832,7 @@ static void ivshmem_write_config(PCIDevice *pdev, > > uint32_t address, > > static void ivshmem_common_realize(PCIDevice *dev, Error **errp) > > { > > +ERRP_GUARD(); > > IVShmemState *s = IVSHMEM_COMMON(dev); > > Error *err = NULL; > > Please remove "er

Re: [PATCH V2] migration: massage cpr-reboot documentation

2024-02-29 Thread Peter Xu
On Fri, Mar 01, 2024 at 06:57:32AM +0100, Markus Armbruster wrote: > Upper case "QEMU", please. More of the same below. Fixed five occurances in my queue, attached R-b. https://gitlab.com/peterx/qemu/-/commit/87a2848715f5fc4fa114574dbbf7a5564cb4cdd7 Thanks! -- Peter Xu

Re: [PATCH v9 18/21] hw/i386/pc: Support smp.modules for x86 PC machine

2024-02-29 Thread Zhao Liu
> >> You have added drawers, books here. Were they missing before? > >> > > > > ...so yes, I think those 2 parameters are missed at this place. > > ok. If there is another revision then add a line about this change in the > commit message. Otherwise it is fine. > > Reviewed-by: Babu Moger > Su

Re: [PATCH V2] migration: massage cpr-reboot documentation

2024-02-29 Thread Markus Armbruster
Steve Sistare writes: > Re-wrap the cpr-reboot documentation to 70 columns, use '@' for > cpr-reboot references, capitalize COLO and VFIO, and tweak the > wording. > > Suggested-by: Markus Armbruster > Signed-off-by: Steve Sistare > --- > qapi/migration.json | 36 +++---

Re: [PATCH] hw/scsi/lsi53c895a: add timer to scripts processing

2024-02-29 Thread Sven Schnelle
BALATON Zoltan writes: > On Thu, 29 Feb 2024, Sven Schnelle wrote: >> BALATON Zoltan writes: >> Yes, i changed it to describe the new method: >> >>/* >> * Some windows drivers make the device spin waiting for a memory location >> * to change. If we have executed more than LSI_MAX_INS

Re: [External] Re: [PATCH v3 6/7] migration/multifd: Add zero pages and zero bytes counter to migration status interface.

2024-02-29 Thread Markus Armbruster
Hao Xiang writes: > On Wed, Feb 28, 2024 at 10:01 PM Markus Armbruster wrote: >> >> Hao Xiang writes: >> >> > On Wed, Feb 28, 2024 at 1:52 AM Markus Armbruster >> > wrote: >> >> >> >> Hao Xiang writes: >> >> >> >> > This change extends the MigrationStatus interface to track zero pages >> >>

Re: [PATCH 3/3] physmem: Fix wrong MR in large address_space_read/write_cached_slow()

2024-02-29 Thread Peter Xu
On Thu, Feb 15, 2024 at 02:28:17PM +, Jonathan Cameron wrote: Can we rename the subject? physmem: Fix wrong MR in large address_space_read/write_cached_slow() IMHO "wrong MR" is misleading, as the MR was wrong only because the address passed over is wrong at the first place. Perhaps s/MR/

Re: [PATCH 0/2] Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"

2024-02-29 Thread Michael S. Tsirkin
On Thu, Feb 29, 2024 at 07:38:06PM +, Bernhard Beschow wrote: > > > Am 26. Februar 2024 21:59:07 UTC schrieb Bernhard Beschow : > >As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system > > > >flash handling to pc_sysfw" causes a regression when specifying the property > >

Re: [PATCH 2/3] physmem: Factor out body of flatview_read/write_continue() loop

2024-02-29 Thread Peter Xu
On Fri, Mar 01, 2024 at 01:29:04PM +0800, Peter Xu wrote: > On Thu, Feb 15, 2024 at 02:28:16PM +, Jonathan Cameron wrote: > > This code will be reused for the address_space_cached accessors > > shortly. > > > > Also reduce scope of result variable now we aren't directly > > calling this in the

Re: [PATCH 2/3] physmem: Factor out body of flatview_read/write_continue() loop

2024-02-29 Thread Peter Xu
On Thu, Feb 15, 2024 at 02:28:16PM +, Jonathan Cameron wrote: > This code will be reused for the address_space_cached accessors > shortly. > > Also reduce scope of result variable now we aren't directly > calling this in the loop. > > Signed-off-by: Jonathan Cameron > --- > system/physmem.c

Re: [PATCH 1/3] physmem: Reduce local variable scope in flatview_read/write_continue()

2024-02-29 Thread Peter Xu
On Thu, Feb 15, 2024 at 02:28:15PM +, Jonathan Cameron wrote: > Precursor to factoring out the inner loops for reuse. > > Signed-off-by: Jonathan Cameron Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH 0/2] *** Properly apply migration compression level

2024-02-29 Thread Peter Xu
On Fri, Mar 01, 2024 at 03:58:59AM +, Bryan Zhang wrote: > From: Bryan Zhang > > There is some glue code missing, such that the > `qmp_migrate_set_parameters` function does not properly update the > `multifd_zstd_level` and `multifd_zlib_level` parameters. This patch > adds the glue code and

[PATCH 1/2] migration: Properly apply migration compression level parameters

2024-02-29 Thread Bryan Zhang
From: Bryan Zhang Some glue code was missing, so that using `qmp_migrate_set_parameters` to set `multifd-zstd-level` or `multifd-zlib-level` did not work. This commit adds the glue code to fix that. Signed-off-by: Bryan Zhang --- migration/options.c | 12 1 file changed, 12 insert

[PATCH 2/2] tests/migration: Set compression level in migration tests

2024-02-29 Thread Bryan Zhang
From: Bryan Zhang Adds calls to set compression level for `zstd` and `zlib` migration tests, just to make sure that the calls work. Signed-off-by: Bryan Zhang --- tests/qtest/migration-test.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/q

[PATCH 0/2] *** Properly apply migration compression level

2024-02-29 Thread Bryan Zhang
From: Bryan Zhang There is some glue code missing, such that the `qmp_migrate_set_parameters` function does not properly update the `multifd_zstd_level` and `multifd_zlib_level` parameters. This patch adds the glue code and also adds some function calls to the existing migration tests to make sur

Re: [PATCH v4 08/10] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

2024-02-29 Thread fan
On Tue, Feb 27, 2024 at 10:39:09AM +, Jonathan Cameron wrote: > On Mon, 26 Feb 2024 17:01:22 -0800 > fan wrote: > > > On Mon, Feb 26, 2024 at 06:04:17PM +, Jonathan Cameron wrote: > > > On Wed, 21 Feb 2024 10:16:01 -0800 > > > nifan@gmail.com wrote: > > > > > > > From: Fan Ni > >

Re: [RFC PATCH v5 12/22] target/arm: Handle NMI in arm_cpu_do_interrupt_aarch64()

2024-02-29 Thread Jinjie Ruan via
On 2024/3/1 7:09, Richard Henderson wrote: > On 2/29/24 03:10, Jinjie Ruan via wrote: >> According to Arm GIC section 4.6.3 Interrupt superpriority, the interrupt >> with superpriority is always IRQ, never FIQ, so the NMI exception trap >> entry >> behave like IRQ. However, VNMI can be IRQ or FI

[PATCH v4 3/7] migration/multifd: Implement ram_save_target_page_multifd to handle multifd version of MigrationOps::ram_save_target_page.

2024-02-29 Thread Hao Xiang
1. Add a dedicated handler for MigrationOps::ram_save_target_page in multifd live migration. 2. Refactor ram_save_target_page_legacy so that the legacy and multifd handlers don't have internal functions calling into each other. Signed-off-by: Hao Xiang Reviewed-by: Fabiano Rosas Message-Id: <202

[PATCH v4 5/7] migration/multifd: Add new migration test cases for legacy zero page checking.

2024-02-29 Thread Hao Xiang
Now that zero page checking is done on the multifd sender threads by default, we still provide an option for backward compatibility. This change adds a qtest migration test case to set the zero-page-detection option to "legacy" and run multifd migration with zero page checking on the migration main

[PATCH v4 0/7] Introduce multifd zero page checking.

2024-02-29 Thread Hao Xiang
v4 update: * Fix documentation for interface ZeroPageDetection. * Fix implementation in multifd_send_zero_page_check. * Rebase on top of c0c6a0e3528b88aaad0b9d333e295707a195587b. v3 update: * Change "zero" to "zero-pages" and use type size for "zero-bytes". * Fixed ZeroPageDetection interface desc

[PATCH v4 1/7] migration/multifd: Add new migration option zero-page-detection.

2024-02-29 Thread Hao Xiang
This new parameter controls where the zero page checking is running. 1. If this parameter is set to 'legacy', zero page checking is done in the migration main thread. 2. If this parameter is set to 'none', zero page checking is disabled. Signed-off-by: Hao Xiang --- hw/core/qdev-properties-syste

[PATCH v4 2/7] migration/multifd: Implement zero page transmission on the multifd thread.

2024-02-29 Thread Hao Xiang
1. Add zero_pages field in MultiFDPacket_t. 2. Implements the zero page detection and handling on the multifd threads for non-compression, zlib and zstd compression backends. 3. Added a new value 'multifd' in ZeroPageDetection enumeration. 4. Handle migration QEMU9.0 -> QEMU8.2 compatibility. 5. Ad

[PATCH v4 6/7] migration/multifd: Add zero pages and zero bytes counter to migration status interface.

2024-02-29 Thread Hao Xiang
This change extends the MigrationStatus interface to track zero pages and zero bytes counter. Signed-off-by: Hao Xiang --- migration/migration-hmp-cmds.c | 4 migration/migration.c | 2 ++ qapi/migration.json | 15 ++- tests/migration/guestpe

[PATCH v4 7/7] Update maintainer contact for migration multifd zero page checking acceleration.

2024-02-29 Thread Hao Xiang
Add myself to maintain multifd zero page checking acceleration function. Signed-off-by: Hao Xiang --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 65dfdc9677..b547918e4d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3414,6 +3414,11 @@ F: t

[PATCH v4 4/7] migration/multifd: Enable multifd zero page checking by default.

2024-02-29 Thread Hao Xiang
Set default "zero-page-detection" option to "multifd". Now zero page checking can be done in the multifd threads and this becomes the default configuration. We still provide backward compatibility where zero page checking is done from the migration main thread. Signed-off-by: Hao Xiang --- migra

Re: [PATCH V2] migration: massage cpr-reboot documentation

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 06:54:22AM -0800, Steve Sistare wrote: > Re-wrap the cpr-reboot documentation to 70 columns, use '@' for > cpr-reboot references, capitalize COLO and VFIO, and tweak the > wording. > > Suggested-by: Markus Armbruster > Signed-off-by: Steve Sistare queued. -- Peter Xu

Re: [External] Re: [PATCH v3 2/7] migration/multifd: Implement zero page transmission on the multifd thread.

2024-02-29 Thread Hao Xiang
On Wed, Feb 28, 2024 at 11:46 AM Fabiano Rosas wrote: > > Hao Xiang writes: > > > 1. Add zero_pages field in MultiFDPacket_t. > > 2. Implements the zero page detection and handling on the multifd > > threads for non-compression, zlib and zstd compression backends. > > 3. Added a new value 'multif

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > Based-on: 74aa0fb297 (migration: options incompatible with cpr) # > peterx/migration-next > > Hi, > > In this v6: > > - Minor fixes to 17/23 and 19/23 The whole set looks good to me now. I plan to queue it before the direct-io s

Re: [PATCH v6 22/23] migration/multifd: Add mapped-ram support to fd: URI

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 12:30:16PM -0300, Fabiano Rosas wrote: > If we receive a file descriptor that points to a regular file, there's > nothing stopping us from doing multifd migration with mapped-ram to > that file. > > Enable the fd: URI to work with multifd + mapped-ram. > > Note that the fd

Re: [PATCH v6 19/23] migration/multifd: Prepare multifd sync for mapped-ram migration

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 12:30:13PM -0300, Fabiano Rosas wrote: > The mapped-ram migration can be performed live or non-live, but it is > always asynchronous, i.e. the source machine and the destination > machine are not migrating at the same time. We only need some pieces > of the multifd sync oper

Re: [PATCH v6 17/23] migration/multifd: Add outgoing QIOChannelFile support

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 12:30:11PM -0300, Fabiano Rosas wrote: > Allow multifd to open file-backed channels. This will be used when > enabling the mapped-ram migration stream format which expects a > seekable transport. > > The QIOChannel read and write methods will use the preadv/pwritev > versio

Re: [PATCH 14/17] migration/option: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 10:39:11PM +0800, Zhao Liu wrote: > From: Zhao Liu > > As the comment in qapi/error, passing @errp to error_prepend() requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > ... > *

RE: [PATCH v1 3/8] aspeed/sdmc: Add AST2700 support

2024-02-29 Thread Jamin Lin
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Thursday, February 29, 2024 5:17 PM > To: Jamin Lin ; Cédric Le Goater ; > Peter Maydell ; Andrew Jeffery > ; Joel Stanley ; Alistair > Francis ; open list:ASPEED BMCs > ; open list:All patches CC here > > Cc: Troy Lee ; Yunlin T

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 10:21:14AM -0500, Steven Sistare wrote: > On 2/25/2024 9:08 PM, Peter Xu wrote: > > On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: > >> When migration for cpr is initiated, stop the vm and set state > >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eli

Re: [External] Re: [PATCH v3 2/7] migration/multifd: Implement zero page transmission on the multifd thread.

2024-02-29 Thread Hao Xiang
On Thu, Feb 29, 2024 at 7:47 AM Fabiano Rosas wrote: > > Markus Armbruster writes: > > > Hao Xiang writes: > > > >> On Wed, Feb 28, 2024 at 1:50 AM Markus Armbruster > >> wrote: > >>> > >>> Hao Xiang writes: > >>> > >>> > 1. Add zero_pages field in MultiFDPacket_t. > >>> > 2. Implements the z

Re: [External] Re: [PATCH v3 6/7] migration/multifd: Add zero pages and zero bytes counter to migration status interface.

2024-02-29 Thread Hao Xiang
On Wed, Feb 28, 2024 at 10:01 PM Markus Armbruster wrote: > > Hao Xiang writes: > > > On Wed, Feb 28, 2024 at 1:52 AM Markus Armbruster wrote: > >> > >> Hao Xiang writes: > >> > >> > This change extends the MigrationStatus interface to track zero pages > >> > and zero bytes counter. > >> > > >>

Re: [RFC PATCH v5 19/22] hw/intc/arm_gicv3: Report the NMI interrupt in gicv3_cpuif_update()

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: In CPU Interface, if the IRQ has the superpriority property, report NMI to the corresponding PE. Signed-off-by: Jinjie Ruan --- v4: - Swap the ordering of the IFs. v3: - Remove handling nmi_is_irq flag. --- hw/intc/arm_gicv3_cpuif.c | 4 1 file ch

Re: [PATCH v5 19/23] migration/multifd: Prepare multifd sync for mapped-ram migration

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 10:19:12AM -0300, Fabiano Rosas wrote: > > IMHO EOS cannot be accounted as "invalid" here because it always exists. > > Rather than this trick (then explicitly ignore it below... which is even > > hackier, IMHO), we can avoid setting EOS in invalid_flags, but explicitly > >

RE: [PATCH v3 1/2] ui/gtk: flush display pipeline before saving vmstate when blob=true

2024-02-29 Thread Kim, Dongwon
Hi Marc-André, Can you take a look at this new version and also https://lists.gnu.org/archive/html/qemu-devel/2023-12/msg01828.html? Thanks! DW > -Original Message- > From: qemu-devel-bounces+dongwon.kim=intel@nongnu.org devel-bounces+dongwon.kim=intel@nongnu.org> On Behalf Of

Re: [PATCH v5 17/23] migration/multifd: Add outgoing QIOChannelFile support

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 02:34:13PM +, Daniel P. Berrangé wrote: > On Thu, Feb 29, 2024 at 11:27:44AM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Thu, Feb 29, 2024 at 10:44:21AM +0800, Peter Xu wrote: > > >> On Wed, Feb 28, 2024 at 12:21:21PM -0300, Fabiano Rosas wrote: > > >

RE: [PATCH 0/3] ui/gtk: introducing vc->visible

2024-02-29 Thread Kim, Dongwon
Hi Marc-André Lureau, Just a reminder.. I need your help reviewing this patch series. Please take a look at my messages at https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg06636.html and https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg06637.html Thanks!! DW > -Original Mess

Re: [RFC PATCH v5 18/22] hw/intc/arm_gicv3: Implement NMI interrupt prioirty

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: If GICD_CTLR_DS bit is zero and the NMI is non-secure, the NMI prioirty is higher than 0x80, otherwise it is higher than 0x0. And save NMI super prioirty information in hppi.superprio to deliver NMI exception. Since both GICR and GICD can deliver NMI, it i

Re: [RFC PATCH v5 17/22] hw/intc/arm_gicv3: Add NMI handling CPU interface registers

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: +static uint64_t icv_nmiar1_read(CPUARMState *env, const ARMCPRegInfo *ri) +{ +/* todo */ +uint64_t intid = INTID_SPURIOUS; +return intid; +} You're going to need to fill this in. It's like icv_iar_read() but only affects irqs with superprio

Re: [RFC PATCH v5 20/22] hw/intc/arm_gicv3: Report the VNMI interrupt

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: In vCPU Interface, if the vIRQ has the superpriority property, report vNMI to the corresponding vPE. Signed-off-by: Jinjie Ruan --- hw/intc/arm_gicv3_cpuif.c | 14 -- hw/intc/gicv3_internal.h | 1 + 2 files changed, 13 insertions(+), 2 d

Re: [QEMU][PATCH v3 6/7] xen: add map and unmap callbacks for grant region

2024-02-29 Thread Stefano Stabellini
On Tue, 27 Feb 2024, Vikram Garhwal wrote: > From: Juergen Gross > > Add the callbacks for mapping/unmapping guest memory via grants to the > special grant memory region. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini > --- > hw/xen/xen-ma

Re: [RFC PATCH v5 14/22] hw/intc/arm_gicv3_redist: Implement GICR_INMIR0

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: Add GICR_INMIR0 register and support access GICR_INMIR0. Signed-off-by: Jinjie Ruan --- v4: - Make the GICR_INMIR0 implementation more clearer. --- hw/intc/arm_gicv3_redist.c | 19 +++ hw/intc/gicv3_internal.h | 1 + 2 files changed

Re: [QEMU][PATCH v3 5/7] memory: add MemoryRegion map and unmap callbacks

2024-02-29 Thread Stefano Stabellini
On Tue, 27 Feb 2024, Vikram Garhwal wrote: > From: Juergen Gross > > In order to support mapping and unmapping guest memory dynamically to > and from qemu during address_space_[un]map() operations add the map() > and unmap() callbacks to MemoryRegionOps. > > Those will be used e.g. for Xen grant

Re: [RFC PATCH v5 12/22] target/arm: Handle NMI in arm_cpu_do_interrupt_aarch64()

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: According to Arm GIC section 4.6.3 Interrupt superpriority, the interrupt with superpriority is always IRQ, never FIQ, so the NMI exception trap entry behave like IRQ. However, VNMI can be IRQ or FIQ, FIQ can only come from hcrx_el2.HCRX_VFNMI bit, IRQ can

Re: [RFC PATCH v5 08/22] target/arm: Handle IS/FS in ISR_EL1 for NMI

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: if (hcr_el2 & HCR_FMO) { if (cs->interrupt_request & CPU_INTERRUPT_VFIQ) { ret |= CPSR_F; + +if (env->cp15.hcrx_el2 & HCRX_VFNMI) { +ret |= ISR_FS; +} VFIO can be raised one of two way

Re: [RFC PATCH v5 06/22] target/arm: Add support for Non-maskable Interrupt

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: +bool new_state = ((env->cp15.hcr_el2 & HCR_VI) && + (env->cp15.hcrx_el2 & HCRX_VINMI)) || + ((env->cp15.hcr_el2 & HCR_VF) && + (env->cp15.hcrx_el2 & HCRX_VFNMI)) || +(env->irq_line_

Re: [PATCH] hw/scsi/lsi53c895a: add timer to scripts processing

2024-02-29 Thread BALATON Zoltan
On Thu, 29 Feb 2024, Sven Schnelle wrote: BALATON Zoltan writes: On Thu, 29 Feb 2024, Sven Schnelle wrote: Some OS's like HP-UX 10.20 are spinn I guess the above line is left here by accident. Yes. HP-UX 10.20 seems to make the lsi53c895a spinning on a memory location under certain circ

Re: [RFC PATCH v5 06/22] target/arm: Add support for Non-maskable Interrupt

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: @@ -900,6 +945,31 @@ void arm_cpu_update_vfiq(ARMCPU *cpu) } } +void arm_cpu_update_vnmi(ARMCPU *cpu) +{ +/* + * Update the interrupt level for VNMI, which is the logical OR of + * the HCRX_EL2.VINMI or HCRX_EL2.VFNMI bit and the in

Re: [PATCH v2 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument

2024-02-29 Thread Fabiano Rosas
Fabiano Rosas writes: > Het Gala writes: > >> On 27/02/24 1:04 am, Het Gala wrote: >>> >>> >>> On 26/02/24 6:31 pm, Fabiano Rosas wrote: Het Gala writes: > On 24/02/24 1:42 am, Fabiano Rosas wrote: > this was the same first approach that I attempted. It won't work because

Re: [RFC PATCH v5 04/22] target/arm: Implement ALLINT MSR (immediate)

2024-02-29 Thread Richard Henderson
On 2/29/24 03:10, Jinjie Ruan via wrote: +static bool trans_MSR_i_ALLINT(DisasContext *s, arg_i *a) +{ +if (!dc_isar_feature(aa64_nmi, s) || s->current_el == 0) { +return false; +} + +if (a->imm == 0) { +clear_pstate_bits(PSTATE_ALLINT); +} else if (s->current_el >

Re: [PATCH 0/2] Revert "hw/i386/pc: Confine system flash handling to pc_sysfw"

2024-02-29 Thread Bernhard Beschow
Am 26. Februar 2024 21:59:07 UTC schrieb Bernhard Beschow : >As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system > >flash handling to pc_sysfw" causes a regression when specifying the property > >`-M pflash0` in the PCI PC machines: > > qemu-system-x86_64: Property 'pc-q3

Re: [PATCH] tcg/optimize: fix uninitialized variable

2024-02-29 Thread Richard Henderson
On 2/28/24 09:29, Richard Henderson wrote: On 2/28/24 02:20, Paolo Bonzini wrote: On Wed, Feb 28, 2024 at 12:19 PM Philippe Mathieu-Daudé wrote: On 28/2/24 12:06, Paolo Bonzini wrote: The variables uext_opc and sext_opc are used without initialization if TCG_TARGET_extract_i{32,64}_valid ret

Re: [PATCH] system/qdev-monitor: move drain_call_rcu call under if (!dev) in qmp_device_add()

2024-02-29 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: What is the correct way to add linker dependency to QEMU build system?

2024-02-29 Thread Paolo Bonzini
On Thu, Feb 29, 2024 at 6:02 PM Alex Bennée wrote: > > Paz Offer writes: > > > Hi, > > > > I want to add library 'libdl' to be linked with QEMU build for a particular > > target (e.g. - qemu-system-arm). > > Using meson I would typically do 'compiler.find_library(...)', and later > > add the re

Re: [PATCH] block: Remove special-casing of compound pages

2024-02-29 Thread Greg Edwards
On Thu, Feb 29, 2024 at 07:37:11PM +, Matthew Wilcox wrote: > On Thu, Feb 29, 2024 at 11:25:13AM -0700, Greg Edwards wrote: >>> [1/1] block: Remove special-casing of compound pages >>> commit: 1b151e2435fc3a9b10c8946c6aebe9f3e1938c55 >> >> This commit results in a change of behavior for Q

Re: [PATCH] block: Remove special-casing of compound pages

2024-02-29 Thread Greg Edwards
e0 \ -device virtio-blk-pci,drive=drive0,id=disk0,bootindex=1 rm -f /dev/hugepages/vm00 Some testing notes: * occurs with 6.1.75, 6.6.14, 6.8-rc6, and linux-next-20240229 * occurs with 1 GiB and 2 MiB huge pages, with both hugetlbfs and memfd * occurs with QEMU 8.0.y, 8.1.y, 8.2.y, and master * occurs with (-enable-kvm -cpu host) or without (-cpu qemu64) KVM Thanks for your time! Greg

Re: [PATCH 08/16] block/qcow2: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Eric Blake
On Thu, Feb 29, 2024 at 12:37:15AM +0800, Zhao Liu wrote: > From: Zhao Liu > > As the comment in qapi/error, passing @errp to error_prepend() requires > ERRP_GUARD(): > > > In block/qcow2.c, there're 2 functions passing @errp to error_prepend() s/there're/there are/ > without ERRP_GUARD(): >

[PATCH v2] hw/scsi/lsi53c895a: add timer to scripts processing

2024-02-29 Thread Sven Schnelle
HP-UX 10.20 seems to make the lsi53c895a spinning on a memory location under certain circumstances. As the SCSI controller and CPU are not running at the same time this loop will never finish. After some time, the check loop interrupts with a unexpected device disconnect. This works, but is slow be

Re: [PATCH] hw/scsi/lsi53c895a: add timer to scripts processing

2024-02-29 Thread Sven Schnelle
BALATON Zoltan writes: > On Thu, 29 Feb 2024, Sven Schnelle wrote: >> Some OS's like HP-UX 10.20 are spinn > > I guess the above line is left here by accident. Yes. >> HP-UX 10.20 seems to make the lsi53c895a spinning on a memory location >> under certain circumstances. As the SCSI controller a

Re: [PATCH] hw/scsi/lsi53c895a: add timer to scripts processing

2024-02-29 Thread BALATON Zoltan
On Thu, 29 Feb 2024, Sven Schnelle wrote: Some OS's like HP-UX 10.20 are spinn I guess the above line is left here by accident. HP-UX 10.20 seems to make the lsi53c895a spinning on a memory location under certain circumstances. As the SCSI controller and CPU are not running at the same time t

Re: [PATCH] tests: riscv64: Use 'zfa' instead of 'Zfa'

2024-02-29 Thread Daniel Henrique Barboza
On 2/29/24 15:06, Christoph Müllner wrote: Running test-fcvtmod triggers the following deprecation warning: warning: CPU property 'Zfa' is deprecated. Please use 'zfa' instead Let's fix that. Signed-off-by: Christoph Müllner --- Reviewed-by: Daniel Henrique Barboza tests/tcg/riscv6

Re: [q&a] Status of IOMMU virtualization for nested virtualization (userspace PCI drivers in VMs)

2024-02-29 Thread Peter Delevoryas
> On Feb 28, 2024, at 11:38 AM, Alex Williamson > wrote: > > On Wed, 28 Feb 2024 10:29:32 -0800 > Peter Delevoryas wrote: > >> Hey guys, >> >> I’m having a little trouble reading between the lines on various >> docs, mailing list threads, KVM presentations, github forks, etc, so >> I figur

Re: [PATCH 03/16] block: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Eric Blake
On Thu, Feb 29, 2024 at 12:37:10AM +0800, Zhao Liu wrote: > From: Zhao Liu > > As the comment in qapi/error, passing @errp to error_prepend() requires > ERRP_GUARD(): > > > In block.c, there're 4 functions passing @errp to error_prepend() > without ERRP_GUARD(): > - bdrv_co_create_opts_simple

Re: [PATCH 0/3] plugins/execlog: add data address match and address range support

2024-02-29 Thread Sven Schnelle
Hi Alex, Alex Bennée writes: > Sven Schnelle writes: > I think we've lost a patch in the re-posting. patchew hasn't seen it > either: > > https://patchew.org/QEMU/20240229150729.1620410-1-sv...@stackframe.org/ > >> plugins/execlog: add data address match >> plugins/execlog: add address ra

Re: [PATCH] block: Remove special-casing of compound pages

2024-02-29 Thread Matthew Wilcox
On Thu, Feb 29, 2024 at 11:25:13AM -0700, Greg Edwards wrote: > > [1/1] block: Remove special-casing of compound pages > > commit: 1b151e2435fc3a9b10c8946c6aebe9f3e1938c55 > > This commit results in a change of behavior for QEMU VMs backed by hugepages > that open their VM disk image file wi

[PATCH] hw/scsi/lsi53c895a: add timer to scripts processing

2024-02-29 Thread Sven Schnelle
Some OS's like HP-UX 10.20 are spinn HP-UX 10.20 seems to make the lsi53c895a spinning on a memory location under certain circumstances. As the SCSI controller and CPU are not running at the same time this loop will never finish. After some time, the check loop interrupts with a unexpected device

Re: Intention to work on GSoC project

2024-02-29 Thread Sahil
Hi, Thank you for your reply. On Thursday, February 29, 2024 2:02:25 PM IST you wrote: > [...] > The first project is for sure related with migration. While vhost-user > memory isolation is not really related to migration, but both are > related to virtio devices. > [...] > Yeah, "bite-size" issu

Re: What is the correct way to add linker dependency to QEMU build system?

2024-02-29 Thread Paz Offer
Thanks a lot Peter, This is working. Paz From: Peter Maydell Sent: Thursday, February 29, 2024 7:34 PM To: Paz Offer Cc: qemu-devel@nongnu.org Subject: Re: What is the correct way to add linker dependency to QEMU build system? External email: Use caution openin

Re: [PATCH 3/3] target/hppa: mask CR_SAR register writes to 5/6 bit in gdbstub

2024-02-29 Thread Richard Henderson
On 2/28/24 10:14, Sven Schnelle wrote: Signed-off-by: Sven Schnelle --- target/hppa/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c index a5b2c80c07..049b2d6381 100644 --- a/target/hppa/gdbstub.c +++ b/target/hppa/gdb

Re: [PATCH 11/17] hw/vfio/platform: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Cédric Le Goater
On 2/29/24 15:39, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepen

Re: [PATCH 10/17] hw/vfio/pci: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Cédric Le Goater
On 2/29/24 15:39, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepen

Re: [PATCH] tests: riscv64: Use 'zfa' instead of 'Zfa'

2024-02-29 Thread Richard Henderson
On 2/29/24 08:06, Christoph Müllner wrote: Running test-fcvtmod triggers the following deprecation warning: warning: CPU property 'Zfa' is deprecated. Please use 'zfa' instead Let's fix that. Signed-off-by: Christoph Müllner --- tests/tcg/riscv64/Makefile.target | 2 +- 1 file changed, 1

Re: [PATCH 09/17] hw/vfio/pci-quirks: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Cédric Le Goater
On 2/29/24 15:39, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepen

Re: [PATCH 08/17] hw/vfio/iommufd: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Cédric Le Goater
On 2/29/24 15:39, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepen

Re: [PATCH 07/17] hw/vfio/helpers: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Cédric Le Goater
On 2/29/24 15:39, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepen

Re: [PATCH 06/17] hw/vfio/container: Fix missing ERRP_GUARD() for error_prepend()

2024-02-29 Thread Cédric Le Goater
Hello, On 2/29/24 15:39, Zhao Liu wrote: From: Zhao Liu As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to erro

Re: [RFC PATCH] disas/hppa: drop raw opcode dump

2024-02-29 Thread Richard Henderson
On 2/29/24 04:05, Alex Bennée wrote: The hppa disassembly is different from the others due to leading with the raw opcode data. This confuses plugins looking for instruction prefixes to match instructions. For plugins like execlog there is another mechanism for getting the instruction byte data.

Re: [PATCH v6 06/12] tests/plugin/mem: migrate to new per_vcpu API

2024-02-29 Thread Alex Bennée
Pierrick Bouvier writes: > Reviewed-by: Luc Michel > Signed-off-by: Pierrick Bouvier > --- > tests/plugin/mem.c | 46 +++--- > 1 file changed, 31 insertions(+), 15 deletions(-) > > diff --git a/tests/plugin/mem.c b/tests/plugin/mem.c > index 44e91065ba7.

[PATCH] tests: riscv64: Use 'zfa' instead of 'Zfa'

2024-02-29 Thread Christoph Müllner
Running test-fcvtmod triggers the following deprecation warning: warning: CPU property 'Zfa' is deprecated. Please use 'zfa' instead Let's fix that. Signed-off-by: Christoph Müllner --- tests/tcg/riscv64/Makefile.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/

Re: [PATCH 3/3] plugins/execlog: add address range matching

2024-02-29 Thread Sven Schnelle
Hi Alex, Alex Bennée writes: > Sven Schnelle writes: >> +static void parse_vaddr_match(GArray **matches, char *token) >> { >> -uint64_t v = g_ascii_strtoull(match, NULL, 16); >> +uint64_t low, high; >> +gchar *endp; >> >> -if (!matches) { >> -*matches = g_array_new(fa

  1   2   3   4   >