Re: [PATCH 3/3] target/hppa: mask CR_SAR register writes to 5/6 bit in gdbstub

[Richard Henderson]

On 2/28/24 10:14, Sven Schnelle wrote:

Signed-off-by: Sven Schnelle <sv...@stackframe.org>
---
  target/hppa/gdbstub.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c
index a5b2c80c07..049b2d6381 100644
--- a/target/hppa/gdbstub.c
+++ b/target/hppa/gdbstub.c
@@ -184,7 +184,7 @@ int hppa_cpu_gdb_write_register(CPUState *cs, uint8_t 
*mem_buf, int n)
          env->gr[n] = val;
          break;
      case 32:
-        env->cr[CR_SAR] = val;
+        env->cr[CR_SAR] = val & (hppa_is_pa20(env) ? 63 : 31);
          break;
      case 33:
          env->iaoq_f = val;

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~