Re: QTest framework does not capture toggled irq line

2023-11-11 Thread Gustavo Romero
On 11/10/23 3:16 AM, Thomas Huth wrote: On 10/11/2023 04.40, Gustavo Romero wrote: Hi folks, I'm writing a test for a device that has one IRQ output line that is toggled (raised then lowered) by the device to trigger a CPU interrupt. Afaics the QTest framework does not provide a way to capture

[PATCH] test/qtest: Add an API function to capture IRQ toggling

2023-11-11 Thread Gustavo Romero
Currently the QTest API does not provide a function to allow capturing when an IRQ line is toggled (raised then lowered). Functions like qtest_get_irq() read the current state of the intercepted IRQ lines, which is already low when the function is called, since the line is toggled. This commit int

Re: [PATCH] Fix Windows 2000 and XP HDAudio Support

2023-11-11 Thread Christopher Lentocha
So wait, you want me to add it as another device name? Because it is going to be the same exact way as the 1af4 device just with a number change. Ok, work it is then ... (Sorry about not getting back sooner also) Christopher On 11/8/23 6:12 AM, Gerd Hoffmann wrote: > On Wed, Nov 08, 2023 at 11:0

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-11 Thread David Woodhouse
On 11 November 2023 16:51:22 GMT-05:00, Andrew Cooper wrote: >On 11/11/2023 8:18 pm, David Woodhouse wrote: >> On 11 November 2023 08:43:40 GMT-05:00, Andrew Cooper >> wrote: >>> Furthermore, the control domain doesn't always have the domid of 0. >>> >>> If qemu wants/needs to make changes like

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-11 Thread Andrew Cooper
On 11/11/2023 8:18 pm, David Woodhouse wrote: > On 11 November 2023 08:43:40 GMT-05:00, Andrew Cooper > wrote: >> Furthermore, the control domain doesn't always have the domid of 0. >> >> If qemu wants/needs to make changes like this, the control domain has to >> arrange for qemu's domain to have

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-11 Thread David Woodhouse
On 11 November 2023 08:43:40 GMT-05:00, Andrew Cooper wrote: >Furthermore, the control domain doesn't always have the domid of 0. > >If qemu wants/needs to make changes like this, the control domain has to >arrange for qemu's domain to have appropriate permissions on the nodes. Right. And that's

Re: disable-pie build

2023-11-11 Thread Volker Rümelin
Am 11.11.23 um 17:09 schrieb Paolo Bonzini: > On Sat, Nov 11, 2023 at 3:40 AM Michael Tokarev wrote: >> Hi! >> >> It looks like --disable-pie configure, which uses -fno-pie -no-pie flags >> for the compiler, is broken: it does not not tell the *linker* about the >> option, so the link fails (at le

Re: [PATCH v5 03/20] vfio/iommufd: Implement the iommufd backend

2023-11-11 Thread Nicolin Chen
On Thu, Nov 09, 2023 at 07:45:12PM +0800, Zhenzhong Duan wrote: > +static int iommufd_cdev_attach_ioas_hwpt(VFIODevice *vbasedev, bool is_ioas, > + uint32_t id, Error **errp) > +{ > +int ret, iommufd = vbasedev->iommufd->fd; > +struct vfio_device_att

Re: [PATCH v8] target/ppc: Fix bugs in VSX_CVT_FP_TO_INT and VSX_CVT_FP_TO_INT2 macros

2023-11-11 Thread Cédric Le Goater
Adding Richard, Thanks, C. On 11/10/23 19:41, John Platts wrote: The patch below fixes a bug in the VSX_CVT_FP_TO_INT and VSX_CVT_FP_TO_INT2 macros in target/ppc/fpu_helper.c where a non-NaN floating point value from the source vector is incorrectly converted to 0, 0x8000, or 0x80

Re: [RFC PATCH-for-8.2] .gitlab-ci.d/cirrus.yml: Promote NetBSD job as gating

2023-11-11 Thread Reinoud Zandijk
On Fri, Nov 10, 2023 at 10:12:38PM +0100, Reinoud Zandijk wrote: > On Thu, Nov 09, 2023 at 06:15:51PM +0100, Thomas Huth wrote: > > On 09/11/2023 17.58, Daniel P. Berrangé wrote: > > > On Thu, Nov 09, 2023 at 04:35:56PM +0100, Philippe Mathieu-Daudé wrote: ... > > You're right, Daniel. Seems like b

Re: [PATCH v4 3/3] hw/ppc: Nest1 chiplet wiring

2023-11-11 Thread Cédric Le Goater
On 11/7/23 08:41, Chalapathi V wrote: From: Chalapathi V This part of the patchset connects the nest1 chiplet model to p10 chip. Signed-off-by: Chalapathi V --- hw/ppc/pnv.c | 14 ++ include/hw/ppc/pnv_chip.h | 2 ++ 2 files changed, 16 insertions(+) diff --git

Re: [PATCH v4 2/3] hw/ppc: Add nest1 chiplet model

2023-11-11 Thread Cédric Le Goater
On 11/7/23 08:41, Chalapathi V wrote: From: Chalapathi V The nest1 chiplet handle the high speed i/o traffic over PCIe and others. The nest1 chiplet consists of PowerBus Fabric controller, nest Memory Management Unit, chiplet control unit and more. This commit creates a nest1 chiplet model and

Re: [PULL 0/8] Firmware/edk2 20230918 patches

2023-11-11 Thread Akihiko Odaki
On 2023/09/18 22:33, Gerd Hoffmann wrote: The following changes since commit c5ea91da443b458352c1b629b490ee6631775cb4: Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging (2023-09-08 10:06:25 -0400) are available in the Git repository at: https://gitlab.com/kr

Re: [PATCH v4 1/3] hw/ppc: Add pnv pervasive common chiplet units

2023-11-11 Thread Cédric Le Goater
Hello Chalapathi, Please add to your ~/.gitconfig : [diff] orderFile = /path/to/qemu/scripts/git.orderfile It will order the header file first in the patch. On 11/7/23 08:41, Chalapathi V wrote: From: Chalapathi V This part of the patchset creates a common pervasive chiplet mode

Re: [PATCH v4 0/3] pnv nest1 chiplet model

2023-11-11 Thread Cédric Le Goater
Hello Chalapathi, Please tune the "From: " email address of the series you send. This one uses " Chalapathi V " which is certainly from an internal IBM host. Unfortunately, we can not reply to this user/sender. On 11/7/23 08:41, Chalapathi V wrote: From: Chalapathi V Hello, For modularity re

Re: disable-pie build

2023-11-11 Thread Paolo Bonzini
On Sat, Nov 11, 2023 at 3:40 AM Michael Tokarev wrote: > > Hi! > > It looks like --disable-pie configure, which uses -fno-pie -no-pie flags > for the compiler, is broken: it does not not tell the *linker* about the > option, so the link fails (at least on debian bookworm): Looks good, if you can

[PULL 3/6] docs: document what configure does with virtual environments

2023-11-11 Thread Paolo Bonzini
Given the recent confusion around how QEMU detects the system Meson installation, and/or decides to install its own, it is time to fill in the "Python virtual environments and the QEMU build system" section of the documentation. As a curiosity, a first and partial draft of the text was generated b

[PULL 5/6] .gitlab-ci.d/cirrus: Upgrade macOS to 13 (Ventura)

2023-11-11 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé macOS 14 "Sonoma" was released on September 2023 [1]. According to QEMU's support policy, we stop supporting the previous major release two years after the the new major release has been published. Replace the macOS 12 (Monterey) testing by macOS 13 (Ventura, release

[PULL 0/6] Biuld system and CI changes for 2023-11-10

2023-11-11 Thread Paolo Bonzini
The following changes since commit ad6ef0a42e314a8c6ac6c96d5f6e607a1e5644b5: Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2023-11-09 08:26:01 +0800) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch cha

[PULL 2/6] tests: respect --enable/--disable-download for Avocado

2023-11-11 Thread Paolo Bonzini
Pass the content of $mkvenv_flags (which is either "--online" or empty) down to tests/Makefile.include. Signed-off-by: Paolo Bonzini --- configure | 9 + tests/Makefile.include | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/configure b/configure index

[PULL 1/6] coverity: physmem: use simple assertions instead of modelling

2023-11-11 Thread Paolo Bonzini
From: Vladimir Sementsov-Ogievskiy Unfortunately Coverity doesn't follow the logic aroung "len" and "l" variables in stacks finishing with flatview_{read,write}_continue() and generate a lot of OVERRUN false-positives. When small buffer (2 or 4 bytes) is passed to mem read/write path, Coverity as

[PULL 6/6] .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma)

2023-11-11 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Upgrade libvirt-ci so it covers macOS 14. Add a manual entry (QEMU_JOB_OPTIONAL: 1) to test on Sonoma release. Refresh the lci-tool generated files. Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20231109160504.93677-3-phi...@linaro.org> Signed-off-by: Paolo Bon

[PULL 4/6] buildsys: Bump known good meson version to v1.2.3

2023-11-11 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé We need meson v1.2.3 to build QEMU on macOS Sonoma. It also builds fine all our CI jobs (as tested by also bumping "accepted" in pythondeps.toml), so let's use it as our "good enough" packaged wheel. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1939 Sugge

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

2023-11-11 Thread Akihiko Odaki
On 2023/11/03 22:14, Yuri Benditovich wrote: On Fri, Nov 3, 2023 at 11:55 AM Akihiko Odaki > wrote: On 2023/11/03 18:35, Yuri Benditovich wrote: > > > On Thu, Nov 2, 2023 at 4:56 PM Akihiko Odaki mailto:akihiko.od...@daynix.com> > <

Re: [PATCH 1/1] ui/cocoa: add zoom-interpolation display option

2023-11-11 Thread Akihiko Odaki
On 2023/11/11 1:17, carwynel...@gmail.com wrote: From: Carwyn Ellis Provides a new display option, zoom-interpolation, that enables interpolation of the scaled display when zoom-to-fit is enabled. Also provides a corresponding view menu item to allow this to be toggled as required. Signed-off

Re: [PATCH v6 06/21] net: Remove flag propagation

2023-11-11 Thread Akihiko Odaki
On 2023/11/10 16:35, Pavel Dovgalyuk wrote: You need to bump REPLAY_VERSION in replay/replay.c, because your patch changes the replay log format. Otherwise, for replay part: Acked-by: Pavel Dovgalyuk I'll drop this change then. It's just a cleanup and does not bring an additional benefit wo

Re: [PATCH] hw/audio/es1370: Clean up comment

2023-11-11 Thread Volker Rümelin
Am 10.11.23 um 17:43 schrieb Peter Maydell: > Replace a sweary comment with one that's a bit more helpful to > future readers of the code. > > Signed-off-by: Peter Maydell Reviewed-by: Volker Rümelin > --- > hw/audio/es1370.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-11 Thread Andrew Cooper
On 11/11/2023 10:55 am, David Woodhouse wrote: > On Fri, 2023-11-10 at 20:42 +, Volodymyr Babchuk wrote: >> From: Oleksandr Tyshchenko >> >> The PV backend running in other than Dom0 domain (non toolstack domain) >> is not allowed to write frontend nodes. The more, the backend does not >> need

Re: [PATCH for 8.2] ui/gtk-egl: move function calls back to regular code path

2023-11-11 Thread Volker Rümelin
Cc: Antonio > Commit 6f189a08c1 ("ui/gtk-egl: Check EGLSurface before doing > scanout") introduced a regression when QEMU is running with a > virtio-gpu-gl-device on a host under X11. After the guest has > initialized the virtio-gpu-gl-device, the guest screen only > shows "Display output is not a

Re: [PATCH v1 5/7] xen-bus: Set offline if backend's state is XenbusStateClosed

2023-11-11 Thread David Woodhouse
(When sending a series, if you Cc someone on one message please could you Cc them on the whole thread for context? Thanks.) > Both state (XenbusStateClosed) and online (0) are expected by > toolstack/xl devd to completely destroy the device. But "offline" > is never being set by the backend resul

[PATCH] linux-user: xtensa: fix signal delivery in FDPIC

2023-11-11 Thread Max Filippov
In FDPIC signal handlers are passed around as FD pointers. Actual code address and GOT pointer must be fetched from memory by the QEMU code that implements kernel signal delivery functionality. This change is equivalent to the following kernel change: 9c2cc74fb31e ("xtensa: fix signal delivery to F

Re: [PATCH v1 3/7] xen: xenstore: add possibility to preserve owner

2023-11-11 Thread David Woodhouse
On Fri, 2023-11-10 at 20:42 +, Volodymyr Babchuk wrote: > Add option to preserve owner when creating an entry in Xen Store. This > may be needed in cases when Qemu is working as device model in a > domain that is Domain-0, e.g. in driver domain. > > "owner" parameter for qemu_xen_xs_create() f

Re: [PATCH v1 1/7] xen-block: Do not write frontend nodes

2023-11-11 Thread David Woodhouse
On Fri, 2023-11-10 at 20:42 +, Volodymyr Babchuk wrote: > From: Oleksandr Tyshchenko > > The PV backend running in other than Dom0 domain (non toolstack domain) > is not allowed to write frontend nodes. The more, the backend does not > need to do that at all, this is purely toolstack/xl devd

[PATCH for 8.2] ui/gtk-egl: move function calls back to regular code path

2023-11-11 Thread Volker Rümelin
Commit 6f189a08c1 ("ui/gtk-egl: Check EGLSurface before doing scanout") introduced a regression when QEMU is running with a virtio-gpu-gl-device on a host under X11. After the guest has initialized the virtio-gpu-gl-device, the guest screen only shows "Display output is not active.". Commit 6f189a

Re: [PULL v2 00/11] qdev: Make array properties user accessible again

2023-11-11 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] linux-user/riscv: Add Zicboz block size to hwprobe

2023-11-11 Thread Daniel Henrique Barboza
On 11/10/23 14:37, Palmer Dabbelt wrote: Support for probing the Zicboz block size landed in Linux 6.6, which was released a few weeks ago. This provides the user-configured block size when Zicboz is enabled. Signed-off-by: Palmer Dabbelt --- Reviewed-by: Daniel Henrique Barboza lin