[PATCH v5 1/2] migration/vmstate: Introduce vmstate_save_state_with_err

Currently, a few code paths exist in the function vmstate_save_state_v, which ultimately leads to a migration failure. However, an update in the current MigrationState for the error description is never done. vmstate.c somehow doesn't seem to allow the use of migrate_set_error due to some dependen

[PATCH v5 0/2] migration: Update error description outside migration.c

Hi everyone, Now that the patchset covering improvements in error descriptions inside migration.c has been reviewed and merged, can this patchset, which covers the same outside of the context of migration.c be reviewed as well. Regards Tejus Changelog: v4: - Rebase on master v3: - Rebase on

[PATCH v5 2/2] migration: Update error description outside migration.c

A few code paths exist in the source code,where a migration is marked as failed via MIGRATION_STATUS_FAILED, but the failure happens outside of migration.c In such cases, an error_report() call is made, however the current MigrationState is never updated with the error description, and hence clien

Re: [PATCH 0/2] hw/intc/apic: QOM cleanup

On 15/9/23 18:20, Philippe Mathieu-Daudé wrote: Minor cleanup extracted from a bigger series touching x86_cpu_realizefn(). Philippe Mathieu-Daudé (2): target/i386: Only realize existing APIC device hw/intc/apic: Pass CPU using QOM link property Ping?

Re: [PATCH 0/5] accel: Restrict tcg_exec_[un]realizefn() to TCG

On 15/9/23 21:00, Philippe Mathieu-Daudé wrote: - Add missing accel_cpu_unrealize() - Add AccelClass::[un]realize_cpu handlers - Use tcg_exec_[un]realizefn as AccelClass handlers Philippe Mathieu-Daudé (5): accel: Rename accel_cpu_realizefn() -> accel_cpu_realize() accel: Introduce accel_

[PATCH] tests/avocado: Re-enable MIPS Malta tests (GitLab issue #1884 fixed)

Commit 18a536f1f8 ("accel/tcg: Always require can_do_io") fixed the GitLab issue #1884: we can now re-enable those tests. This reverts commit f959c3d87ccfa585b105de6964a6261e368cc1da. Signed-off-by: Philippe Mathieu-Daudé --- tests/avocado/boot_linux_console.py | 7 --- tests/avocado/machin

Re: [PATCH RFC V2 31/37] physmem,gdbstub: Common helping funcs/changes to *unrealize* vCPU

Hi Salil, On 26/9/23 12:04, Salil Mehta wrote: Supporting vCPU Hotplug for ARM arch also means introducing new functionality of unrealizing the ARMCPU. This requires some new common functions. Defining them as part of architecture independent change so that this code could be reused by other in

Re: [PATCH] xlnx-bbram: hw/nvram: Remove deprecated device reset

Hi Tong, On 3/10/23 07:23, Tong Ho wrote: This change implements the ResettableClass interface for the device. Signed-off-by: Tong Ho --- hw/nvram/xlnx-bbram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé Since you did this one, do yo

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

On Mon, Oct 2, 2023 at 4:17 PM Michael S. Tsirkin wrote: > > On Thu, Sep 28, 2023 at 09:14:07AM +0530, Ani Sinha wrote: > > > > > > > On 27-Sep-2023, at 8:55 PM, Michael S. Tsirkin wrote: > > > > > > On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: > > >> Code changes that addresses all

[PATCH v2] hw/i386: changes towards enabling -Wshadow=local

Code changes that addresses all compiler complaints coming from enabling -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing other local variables or parameters. These makes the code confusing and/or adds bugs that are difficult to catch. CC: Markus Armbruster CC: Philipp

Re: [PATCH RFC V2 05/37] accel/kvm: Extract common KVM vCPU {creation,parking} code

Hi Salil, On 10/3/23 02:20, Salil Mehta wrote: From: Gavin Shan Sent: Wednesday, September 27, 2023 7:52 AM To: Salil Mehta ; qemu-devel@nongnu.org; qemu- a...@nongnu.org Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron ; lpieral...@kernel.org; peter.mayd...@linaro.org; richard

Re: [PATCH RFC V2 02/37] cpus-common: Add common CPU utility for possible vCPUs

Hi Salil, On 10/2/23 20:21, Salil Mehta wrote: From: Gavin Shan Sent: Wednesday, September 27, 2023 4:54 AM To: Salil Mehta ; qemu-devel@nongnu.org; qemu- a...@nongnu.org Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron ; lpieral...@kernel.org; peter.mayd...@linaro.org; richard.h

[PATCH] xlnx-bbram: hw/nvram: Remove deprecated device reset

This change implements the ResettableClass interface for the device. Signed-off-by: Tong Ho --- hw/nvram/xlnx-bbram.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/nvram/xlnx-bbram.c b/hw/nvram/xlnx-bbram.c index c6b484cc85..e18e7770e1 100644 --- a/hw/nvram/xlnx-

[PATCH] xlnx-bbram: hw/nvram: Use dot in device type name

This replaces the comma (,) to dot (.) in the device type name so the name can be used with the 'driver=' command line option. Signed-off-by: Tong Ho --- include/hw/nvram/xlnx-bbram.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/nvram/xlnx-bbram.h b/include/hw/n

Re: [PATCH RFC V2 01/37] arm/virt,target/arm: Add new ARMCPU {socket,cluster,core,thread}-id property

Hi Salil, On 10/2/23 19:53, Salil Mehta wrote: Many thanks for taking pains to review this patch-set. No worries. From: Gavin Shan Sent: Wednesday, September 27, 2023 12:57 AM To: Salil Mehta ; qemu-devel@nongnu.org; qemu-...@nongnu.org Cc: m...@kernel.org; jean-phili...@linaro.org; Jonat

Re: [PATCH RESEND 07/15] ppc: spapr: Implement nested PAPR hcall - H_GUEST_SET_CAPABILITIES

On 9/7/23 07:39, Nicholas Piggin wrote: On Wed Sep 6, 2023 at 2:33 PM AEST, Harsh Prateek Bora wrote: This patch implements nested PAPR hcall H_GUEST_SET_CAPABILITIES. This is used by L1 to set capabilities of the nested guest being created. The capabilities being set are subset of the capabi

Re: [RFC] Proposal of QEMU PCI Endpoint test environment

Hi Vaishnav, On 2023/09/26 21:40, Vaishnav Achath wrote: Hi Kishon, all, On 26/09/23 15:17, Shunsuke Mie wrote: On 2023/09/21 18:11, Kishon Vijay Abraham I wrote: +Vaishnav Hi Shunsuke, On 8/18/2023 7:16 PM, Shunsuke Mie wrote: Hi all, We are proposing to add a new test syste to Linux for

Re: [PATCH V2 10/10] target/arm/kvm: Write CPU state back to KVM on reset

On 9/30/23 10:19, Salil Mehta wrote: From: Jean-Philippe Brucker When a KVM vCPU is reset following a PSCI CPU_ON call, its power state is not synchronized with KVM at the moment. Because the vCPU is not marked dirty, we miss the call to kvm_arch_put_registers() that writes to KVM's MP_STATE.

Re: [PATCH V2 09/10] gdbstub: Add helper function to unregister GDB register space

On 9/30/23 10:19, Salil Mehta wrote: Add common function to help unregister the GDB Register Space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta --- gdbstub/gdbstub.c | 14 ++ include/exec/gdbstub.h | 5 + 2 files changed, 19 ins

Re: [PATCH 4/4] hw/ppc/spapr: Rename 'softmmu' -> 'tcg'

On Mon, Oct 02, 2023 at 04:38:54PM +0200, Philippe Mathieu-Daudé wrote: > spapr_softmmu.c isn't related to having a soft MMU, but having > the TCG accelerator. Rename it using the 'tcg' suffix. That's not really accurate. The functions in there absolutely are about the emulated MMU. They're not

Re: [PATCH 3/4] hw/ppc/spapr_hcall: Rename {softmmu -> tcgppc}_resize_hpt_prepare/commit

On Mon, Oct 02, 2023 at 04:38:53PM +0200, Philippe Mathieu-Daudé wrote: > We use the 'kvmppc' prefix for KVM specific functions: > > $ git grep \ kvmppc_ | wc -l >402 > > Following the same pattern for TCG specific functions, > use the 'tcgppc' prefix (which is clearer than 'softmmu').

Re: [PATCH V2 08/10] physmem: Add helper function to destroy CPU AddressSpace

On 9/30/23 10:19, Salil Mehta wrote: Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta --- include/exec/cpu-common.h | 8 includ

Re: [PULL 0/6] tcg patch queue

On 10/2/23 15:46, Michael Tokarev wrote: 28.09.2023 22:41, Richard Henderson wrote Mini PR, aimed at fixing the mips and ovmf regressions. r~ accel/tcg: Always require can_do_io, for #1866 -

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, 2 Oct 2023 at 18:36, Michael S. Tsirkin wrote: > > On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > > On Wed, 30 Aug 2023 at 09:30,

Re: [PATCH V2 07/10] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

On 9/30/23 10:19, Salil Mehta wrote: ACPI GED shall be used to convey to the guest kernel about any CPU hot-(un)plug events. Therefore, existing ACPI GED framework inside QEMU needs to be enhanced to support CPU hotplug state and events. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Si

Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan

On 9/30/23 10:19, Salil Mehta wrote: OSPM evaluates _EVT method to map the event. The cpu hotplug event eventually results in start of the cpu scan. Scan figures out the cpu and the kind of event(plug/unplug) and notifies it back to the guest. The change in this patch updates the GED AML _EVT me

Re: [PATCH V2 05/10] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

On 9/30/23 10:19, Salil Mehta wrote: CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is based on PCI and is IO port based and hence existing cpus AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control dev

Re: [PATCH 0/8] migration fixes

03.10.2023 02:29, Peter Xu: On Tue, Oct 03, 2023 at 01:55:35AM +0300, Michael Tokarev wrote: What can be done for -stable? At least the whole thing applies cleanly to 8.1. It seems v8.0.5 needs at least a few conflict resolutions. As I stated in recent 8.0.5 stable announce, it was the la

Re: [PATCH 0/8] migration fixes

On Tue, Oct 03, 2023 at 01:55:35AM +0300, Michael Tokarev wrote: > 18.09.2023 20:28, Fabiano Rosas wrote: > > This series contains fixes for the two currently know failures that > > show up in migration tests plus a set of fixes for some theoretical > > race conditions around QEMUFile handling. > >

Re: [PATCH V2 04/10] hw/acpi: Init GED framework with cpu hotplug events

On 9/30/23 10:19, Salil Mehta wrote: ACPI GED(as described in the ACPI 6.2 spec) can be used to generate ACPI events when OSPM/guest receives an interrupt listed in the _CRS object of GED. OSPM then maps or demultiplexes the event by evaluating _EVT method. This change adds the support of cpu ho

Re: [PATCH V2 03/10] hw/acpi: Add ACPI CPU hotplug init stub

On 9/30/23 10:19, Salil Mehta wrote: ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Signed-off-by: Salil Mehta --- hw/acpi/acpi-cpu-hotplug-stub.c

Re: [PATCH V2 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

On 9/30/23 10:19, Salil Mehta wrote: CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée --- hw/acpi/cpu.c

Re: [PATCH V2 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code

On 9/30/23 10:19, Salil Mehta wrote: KVM vCPU creation is done once during the initialization of the VM when Qemu threads are spawned. This is common to all the architectures. ^^^ thread is spawned. Hot-unplug of vCPU results in destruction of the vCPU objects in QOM but t

Re: [PULL v3 00/16] tricore queue

29.09.2023 09:39, Bastian Koppelmann: - Add FTOU, CRCN, FTOHP, and HPTOF insns Changes from v2: - Replaced %ld with PRIu64 for patch 13 - Dropped patches 15 - 19, as

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

On Mon, Oct 2, 2023 at 5:09 AM Simon Rowe wrote: > > On Thursday, 28 September 2023 Fiona Ebner wrote: > > > > > AFAICT, yes, because the DMA callback is invoked before resetting the > > state now. But not 100% sure if it can't be triggered in some other way, > > maybe Simon knows more? I don't h

Re: [PATCH 0/8] migration fixes

18.09.2023 20:28, Fabiano Rosas wrote: This series contains fixes for the two currently know failures that show up in migration tests plus a set of fixes for some theoretical race conditions around QEMUFile handling. Patch 1 addresses the issue found in the postcopy/preempt/plain test: https://g

Re: [PULL 0/6] tcg patch queue

28.09.2023 22:41, Richard Henderson wrote Mini PR, aimed at fixing the mips and ovmf regressions. r~ accel/tcg: Always require can_do_io, for #1866 Richard Henderson

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 05:12:27PM -0400, Stefan Hajnoczi wrote: > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > > > > > On 8/30/23 14:10, Stefan Hajno

Re: [PATCH] pci: SLT must be RO

On Mon, Oct 02, 2023 at 01:39:16PM +0200, Marcin Juszkiewicz wrote: > W dniu 8.09.2023 o 15:29, Marcin Juszkiewicz pisze: > > W dniu 31.08.2023 o 12:05, Marcin Juszkiewicz pisze: > > > W dniu 30.08.2023 o 23:48, Michael S. Tsirkin pisze: > > > > current code sets PCI_SEC_LATENCY_TIMER to WO, but fo

Re: [PULL 0/2] Firmware/seabios 20230929 patches

On Fri, 29 Sept 2023 at 07:30, Gerd Hoffmann wrote: > > The following changes since commit 36e9aab3c569d4c9ad780473596e18479838d1aa: > > migration: Move return path cleanup to main migration thread (2023-09-27 > 13:58:02 -0400) > > are available in the Git repository at: > > https://gitlab.co

Re: [PULL 00/56] -Wshadow=local patches patches for 2023-09-29

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v3 00/16] tricore queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/13] Migration 20231002 patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/6] tcg patch queue

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/14] Tracing patches

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v1 2/9] qapi: golang: Generate qapi's alternate types in Go

On Fri, Sep 29, 2023 at 8:37 AM Daniel P. Berrangé wrote: > > On Fri, Sep 29, 2023 at 02:23:22PM +0200, Victor Toso wrote: > > Hi, > > > > On Thu, Sep 28, 2023 at 03:51:50PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 27, 2023 at 01:25:37PM +0200, Victor Toso wrote: > > > > This patch handl

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

One more question: Why is the disabled state not needed by regular (non-vhost) virtio-net devices? On Mon, 2 Oct 2023 at 17:12, Stefan Hajnoczi wrote: > > On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > > On Wed

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, 2 Oct 2023 at 02:49, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > > > On 8/30/23 14:10, Stefan Hajnoczi wrote: > > > > On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: > > > >

Re: [PATCH v2 4/5] ramfb: make migration conditional

On 10/2/23 22:38, Alex Williamson wrote: > On Mon, 2 Oct 2023 21:41:55 +0200 > Laszlo Ersek wrote: > >> On 10/2/23 21:26, Alex Williamson wrote: >>> On Mon, 2 Oct 2023 20:24:11 +0200 >>> Laszlo Ersek wrote: >>> On 10/2/23 16:41, Alex Williamson wrote: > On Mon, 2 Oct 2023 15:38:10

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

On Tue, Sep 26, 2023 at 10:43:22PM +0200, Markus Armbruster wrote: > Loophole... Here's the stupidest solution that could possibly work: > > ## > # @MigrationParameter: > # > # TODO: elide from generated documentation (type is used only > # internally, and not visible in Q

Re: [PATCH v2 4/5] ramfb: make migration conditional

On Mon, 2 Oct 2023 21:41:55 +0200 Laszlo Ersek wrote: > On 10/2/23 21:26, Alex Williamson wrote: > > On Mon, 2 Oct 2023 20:24:11 +0200 > > Laszlo Ersek wrote: > > > >> On 10/2/23 16:41, Alex Williamson wrote: > >>> On Mon, 2 Oct 2023 15:38:10 +0200 > >>> Cédric Le Goater wrote: > >>>

Re: [PATCH] MAINTAINERS: Add section for overall sensors

02.10.2023 21:26, Thomas Huth : On 20/02/2023 12.02, Philippe Mathieu-Daudé wrote: Sensor devices depend on some bus, not a particular board. While merged for a particular board, sensor devices don't depend on it. They depend on a bus technology, and can be used by any board exposing such bus.

Re: [PATCH v1 2/9] qapi: golang: Generate qapi's alternate types in Go

On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > This patch handles QAPI alternate types and generates data structures > in Go that handles it. > > Alternate types are similar to Union but without a discriminator that > can be used to identify the underlying value on the wire. It is needed >

[PATCH v3 3/7] vhost-user: factor out "vhost_user_write_sync"

The tails of the "vhost_user_set_vring_addr" and "vhost_user_set_u64" functions are now byte-for-byte identical. Factor the common tail out to a new function called "vhost_user_write_sync". This is purely refactoring -- no observable change. Cc: "Michael S. Tsirkin" (supporter:vhost) Cc: Eugenio

[PATCH v3 0/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

v2: - http://mid.mail-archive.com/20230830134055.106812-1-lersek@redhat.com - https://patchwork.ozlabs.org/project/qemu-devel/cover/20230830134055.106812-1-ler...@redhat.com/ v3 picks up tags from Phil, Eugenio and Albert, and updates the commit message on patch#7 according to Eugenio's comments

[PATCH v3 6/7] vhost-user: allow "vhost_set_vring" to wait for a reply

The "vhost_set_vring" function already centralizes the common parts of "vhost_user_set_vring_num", "vhost_user_set_vring_base" and "vhost_user_set_vring_enable". We'll want to allow some of those callers to wait for a reply. Therefore, rebase "vhost_set_vring" from just "vhost_user_write" to "vhos

[PATCH v3 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

(1) The virtio-1.2 specification writes: > 3 General Initialization And Device Operation > 3.1 Device Initialization > 3.1.1 Driver Requirements: Device Initialization > > [...] > > 7. Perform device-specific setup, including d

Re: [PATCH v2 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

On 02/10/2023 16:51, Cédric Le Goater wrote: The hw/ppc/fw_cfg.c file contains the implementation of fw_cfg_arch_key_name(), used by the common nvram model. List it under mac99 machine next to the mac_nvram model. Cc: Mark Cave-Ayland Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric

[PATCH v3 1/7] vhost-user: strip superfluous whitespace

Cc: "Michael S. Tsirkin" (supporter:vhost) Cc: Eugenio Perez Martin Cc: German Maglione Cc: Liu Jiang Cc: Sergio Lopez Pascual Cc: Stefano Garzarella Signed-off-by: Laszlo Ersek Reviewed-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Tested-by: Albert Esteve Reviewed-by: Eugen

[PATCH v3 2/7] vhost-user: tighten "reply_supported" scope in "set_vring_addr"

In the vhost_user_set_vring_addr() function, we calculate "reply_supported" unconditionally, even though we'll only need it if "wait_for_reply" is also true. Restrict the scope of "reply_supported" to the minimum. This is purely refactoring -- no observable change. Cc: "Michael S. Tsirkin" (sup

[PATCH v3 4/7] vhost-user: flatten "enforce_reply" into "vhost_user_write_sync"

At this point, only "vhost_user_write_sync" calls "enforce_reply"; embed the latter into the former. This is purely refactoring -- no observable change. Cc: "Michael S. Tsirkin" (supporter:vhost) Cc: Eugenio Perez Martin Cc: German Maglione Cc: Liu Jiang Cc: Sergio Lopez Pascual Cc: Stefano

[PATCH v3 5/7] vhost-user: hoist "write_sync", "get_features", "get_u64"

In order to avoid a forward-declaration for "vhost_user_write_sync" in a subsequent patch, hoist "vhost_user_write_sync" -> "vhost_user_get_features" -> "vhost_user_get_u64" just above "vhost_set_vring". This is purely code movement -- no observable change. Cc: "Michael S. Tsirkin" (supporter:vh

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

On Mon, Oct 2, 2023 at 3:07 PM John Snow wrote: > > On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > > > This patch handles QAPI enum types and generates its equivalent in Go. > > > > Basically, Enums are being handled as strings in Golang. > > > > 1. For each QAPI enum, we will define a st

Re: [PATCH v3 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

On Tue, Sep 26, 2023 at 10:40:27PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Quotting from Markus in his replies: > > Quoting > > Suggest something like "Markus recently wrote:" Will do. > > > migrate-set-parameters sets migration parameters, and > > query-migrate-paramete

Re: [PATCH v2 1/7] vhost-user: strip superfluous whitespace

On 9/6/23 09:12, Albert Esteve wrote: > > > On Thu, Aug 31, 2023 at 9:14 AM Laszlo Ersek > wrote: > > On 8/30/23 15:40, Laszlo Ersek wrote: > > Cc: "Michael S. Tsirkin" mailto:m...@redhat.com>> > (supporter:vhost) > > Cc: Eugenio Perez Martin

Re: [PATCH v2 4/5] ramfb: make migration conditional

On 10/2/23 21:26, Alex Williamson wrote: > On Mon, 2 Oct 2023 20:24:11 +0200 > Laszlo Ersek wrote: > >> On 10/2/23 16:41, Alex Williamson wrote: >>> On Mon, 2 Oct 2023 15:38:10 +0200 >>> Cédric Le Goater wrote: >>> On 10/2/23 13:11, marcandre.lur...@redhat.com wrote: > From: Marc-A

Re: [PATCH v2 4/5] ramfb: make migration conditional

On Mon, 2 Oct 2023 20:24:11 +0200 Laszlo Ersek wrote: > On 10/2/23 16:41, Alex Williamson wrote: > > On Mon, 2 Oct 2023 15:38:10 +0200 > > Cédric Le Goater wrote: > > > >> On 10/2/23 13:11, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau > >>> > >>> RAMFB migration was uns

Re: [PATCH v1 1/9] qapi: golang: Generate qapi's enum types in Go

On Wed, Sep 27, 2023 at 7:25 AM Victor Toso wrote: > > This patch handles QAPI enum types and generates its equivalent in Go. > > Basically, Enums are being handled as strings in Golang. > > 1. For each QAPI enum, we will define a string type in Go to be the >assigned type of this specific enu

Re: [PATCH] MAINTAINERS: Add section for overall sensors

On 20/02/2023 12.02, Philippe Mathieu-Daudé wrote: Sensor devices depend on some bus, not a particular board. While merged for a particular board, sensor devices don't depend on it. They depend on a bus technology, and can be used by any board exposing such bus. In order to help merging sensor p

Re: MAINTAINERS still leaves more files uncovered than I'd like

On 02/10/2023 08.18, Philippe Mathieu-Daudé wrote: Hi Markus, On 29/9/23 13:43, Markus Armbruster wrote: Back in 2014 (time flies), I posted Subject: MAINTAINERS leaves too many files uncovered Message-ID: <87mw8rumhb@blackfin.pond.sub.org> https://lore.kernel.org/qemu-devel

Re: [PATCH v2 4/5] ramfb: make migration conditional

On 10/2/23 16:41, Alex Williamson wrote: > On Mon, 2 Oct 2023 15:38:10 +0200 > Cédric Le Goater wrote: > >> On 10/2/23 13:11, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> RAMFB migration was unsupported until now, let's make it conditional. >>> The following patch will

Re: [PATCH] Fix compilation when UFFDIO_REGISTER is not set.

On 10/2/23 13:56, Michael Tokarev wrote: 28.09.2023 15:56, Pierre Labatut wrote: Signed-off-by: Pierre Labatut ---   subprojects/libvhost-user/libvhost-user.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) I'm not sure how subprojects are handled here.  Should we commit things to a su

Re: [PATCH] build: Remove --enable-gprof

On 9/30/23 20:18, Richard Henderson wrote: This build option has been deprecated since 8.0. Remove all CONFIG_GPROF code that depends on that, including one errant check using TARGET_GPROF. Signed-off-by: Richard Henderson Acked-by: Paolo Bonzini

RE: [PATCH RFC V2 06/37] arm/virt,kvm: Pre-create disabled possible vCPUs @machine init

Hi Gavin, > From: Gavin Shan > Sent: Wednesday, September 27, 2023 11:05 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > i

RE: [PATCH RFC V2 05/37] accel/kvm: Extract common KVM vCPU {creation,parking} code

Hi Gavin, > From: Gavin Shan > Sent: Wednesday, September 27, 2023 7:52 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > im

Re: [PATCH V2 08/10] physmem: Add helper function to destroy CPU AddressSpace

On Sat, 30 Sep 2023 01:19:31 +0100 Salil Mehta wrote: > Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also > involves destruction of the CPU AddressSpace. Add common function to help > destroy the CPU AddressSpace. > > Signed-off-by: Salil Mehta I'm not that familiar with

Re: [PATCH V2 07/10] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

On Sat, 30 Sep 2023 01:19:30 +0100 Salil Mehta wrote: > ACPI GED shall be used to convey to the guest kernel about any CPU > hot-(un)plug > events. Therefore, existing ACPI GED framework inside QEMU needs to be > enhanced > to support CPU hotplug state and events. > > Co-developed-by: Keqian Z

Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan

On Sat, 30 Sep 2023 01:19:29 +0100 Salil Mehta wrote: > OSPM evaluates _EVT method to map the event. The cpu hotplug event eventually > results in start of the cpu scan. Scan figures out the cpu and the kind of > event(plug/unplug) and notifies it back to the guest. > > The change in this patch

RE: [PATCH RFC V2 04/37] arm/virt,target/arm: Machine init time change common to vCPU {cold|hot}-plug

Hi Gavin, > From: Gavin Shan > Sent: Wednesday, September 27, 2023 7:29 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > im

Re: [PATCH V2 05/10] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

On Sat, 30 Sep 2023 01:19:28 +0100 Salil Mehta wrote: > CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is based > on > PCI and is IO port based and hence existing cpus AML code assumes _CRS objects > would evaluate to a system resource which describes IO Port address. But on

Re: [PATCH V2 04/10] hw/acpi: Init GED framework with cpu hotplug events

On Sat, 30 Sep 2023 01:19:27 +0100 Salil Mehta wrote: > ACPI GED(as described in the ACPI 6.2 spec) can be used to generate ACPI > events > when OSPM/guest receives an interrupt listed in the _CRS object of GED. OSPM > then maps or demultiplexes the event by evaluating _EVT method. > > This cha

Re: [PATCH 4/9] hw/acpi: Init GED framework with cpu hotplug events

On Fri, 29 Sep 2023 13:42:59 +0100 Salil Mehta wrote: > ACPI GED(as described in the ACPI 6.2 spec) can be used to generate ACPI > events > when OSPM/guest receives an interrupt listed in the _CRS object of GED. OSPM > then maps or demultiplexes the event by evaluating _EVT method. > > This cha

Re: [PATCH V2 03/10] hw/acpi: Add ACPI CPU hotplug init stub

On Sat, 30 Sep 2023 01:19:26 +0100 Salil Mehta wrote: > ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG > support has been enabled for particular architecture. Add > cpu_hotplug_hw_init() > stub to avoid compilation break. > > Signed-off-by: Salil Mehta Seems rea

Re: [PATCH V2 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

On Sat, 30 Sep 2023 01:19:25 +0100 Salil Mehta wrote: > CPU ctrl-dev MMIO region length could be used in ACPI GED and various other > architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more > appropriate common header file. > > Signed-off-by: Salil Mehta > Reviewed-by: Alex Be

[PATCH v2 2/8] MAINTAINERS: Adjust file list for PPC ref405ep machine

Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 355b1960ce46..9f2eb00b7744 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [PATCH V2 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code

On Sat, 30 Sep 2023 01:19:24 +0100 Salil Mehta wrote: > KVM vCPU creation is done once during the initialization of the VM when Qemu > threads are spawned. This is common to all the architectures. > > Hot-unplug of vCPU results in destruction of the vCPU objects in QOM but > the KVM vCPU objects

[PATCH v2 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

The hw/ppc/fw_cfg.c file contains the implementation of fw_cfg_arch_key_name(), used by the common nvram model. List it under mac99 machine next to the mac_nvram model. Cc: Mark Cave-Ayland Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- MAINTAINERS | 1 + 1 file chang

[PATCH v2 5/8] MAINTAINERS: Adjust file list for PPC pseries machine

The fdt.{c.h} files provide a helper routine used by the pseries and pnv machines. Attached it to the list of the larger one: pseries. Protected Execution Facility (PEF) is the confidential guest support for PPC pseries machines. Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goat

[PATCH v2 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

Hello, All PPC files should now be correctly assigned to some entry. Cheers, C. Changes in v2: - Took Reviewed-by's from Phil and Daniel - Took tests/avocado/ppc_405.py in patch 2 Cédric Le Goater (8): ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h header MAINTAI

[PATCH v2 4/8] MAINTAINERS: Adjust file list for PPC e500 machines

Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cdac16c8eae7..016cfb355123 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1358,6 +1358,7 @@ e500 L: qemu-...@nongnu.org S:

[PATCH v2 7/8] MAINTAINERS: Add PPC common files to PowerPC TCG CPUs

Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d00f39ac9440..e40f7f71d651 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -307,6 +307,11 @@ F: target/ppc/ F: hw/ppc/ppc.c

[PATCH v2 3/8] MAINTAINERS: Adjust file list for PPC 4xx CPUs

Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9f2eb00b7744..cdac16c8eae7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1961,7 +1961,9 @@ F: docs/specs/ac

[PATCH v2 1/8] ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h header

Cc: "Edgar E. Iglesias" (odd fixer:virtex_ml507) Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- hw/ppc/ppc440_bamboo.c | 1 - hw/ppc/virtex_ml507.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c index 45f409c83862.

[PATCH v2 8/8] MAINTAINERS: Update PPC TCG target with tests

Cc: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel Henrique Barboza Signed-off-by: Cédric Le Goater --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e40f7f71d651..174bcfe39210 100644 --- a/MAINTAINERS +++ b/MAINTAINE

Re: [PATCH 8/8] MAINTAINERS: Update PPC TCG target with tests

On 10/2/23 09:23, Cédric Le Goater wrote: Cc: Richard Henderson Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d00d14ef226..9fe9294eccb9 100644 --- a/MAINTAINERS

Re: [PATCH 7/8] MAINTAINERS: Add PPC common files to PowerPC TCG CPUs

On 10/2/23 09:23, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1f72931ac2a4..2d00d14ef226 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -307,6 +307,11 @@ F: target/ppc/ F:

Re: [PATCH v4 10/15] intel-iommu: Implement IOMMU_ATTR_MAX_IOVA get_attr() attribute

On 7/10/23 15:44, Joao Martins wrote: On 09/07/2023 16:17, Avihai Horon wrote: On 23/06/2023 0:48, Joao Martins wrote: External email: Use caution opening links or attachments From: Avihai Horon Implement get_attr() method and use the address width property to report the IOMMU_ATTR_MAX_I

Re: [PATCH 5/8] MAINTAINERS: Adjust file list for PPC pseries machine

On 10/2/23 09:23, Cédric Le Goater wrote: The fdt.{c.h} files provide a helper routine used by the pseries and pnv machines. Attached it to the list of the larger one: pseries. Protected Execution Facility (PEF) is the confidential guest support for PPC pseries machines. Signed-off-by: Cédri

Re: [PATCH 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

On 10/2/23 09:23, Cédric Le Goater wrote: The hw/ppc/fw_cfg.c file contains the implementation of fw_cfg_arch_key_name(), used by the common nvram model. List it under mac99 machine next to the mac_nvram model. Cc: Mark Cave-Ayland Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel H

Re: [PATCH 4/8] MAINTAINERS: Adjust file list for PPC e500 machines

On 10/2/23 09:23, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- Reviewed-by: Daniel Henrique Barboza MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2bf7af9bd150..23ce59995d59 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

  1   2   3   >