Re: [PATCH] linux-user: Move PRAGMA_DISABLE_PACKED_WARNING to compiler.h

2023-08-29 Thread Thomas Huth
On 29/08/2023 20.45, Warner Losh wrote: Replace the slightly older version of this in include/qemu/compiler.h that was commit as part of bsd-user changes with the newer one from s/commit/committed/ ? linux-user. bsd-user has no regreassions with this. s/regreassions/regressions/ Signed-of

Re: [PATCH] kconfig: Add NVME to s390x machines

2023-08-29 Thread Klaus Jensen
On Aug 28 17:01, Cédric Le Goater wrote: > From: Cédric Le Goater > > We recently had issues with nvme devices on big endian platforms. > Include their compilation on s390x to ease tests. > > Signed-off-by: Cédric Le Goater > --- > hw/nvme/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [qemu]: How to use qemu to emulate MCTP Over SMBus devices?

2023-08-29 Thread Cédric Le Goater
Hello Byron, On 8/30/23 06:05, www wrote: Dear Sir, I have a few questions for you to ask. 1. According to my data collection, MCTP function should not be implemented in qemu. I would like to ask you how to simulate MCTP Over SMBus devices?Or do we have a device program with similar functions

Re: [PATCH v2 41/58] i386/tdx: handle TDG.VP.VMCALL

2023-08-29 Thread Chenyi Qiang
On 8/29/2023 6:25 PM, Daniel P. Berrangé wrote: > On Tue, Aug 29, 2023 at 01:31:37PM +0800, Chenyi Qiang wrote: >> >> >> On 8/22/2023 4:24 PM, Daniel P. Berrangé wrote: >>> On Tue, Aug 22, 2023 at 08:52:30AM +0200, Markus Armbruster wrote: Xiaoyao Li writes: > From: Isaku Yamahata

[PATCH v3 1/2] vhost-user: Fix lost reconnect

2023-08-29 Thread Li Feng
When the vhost-user is reconnecting to the backend, and if the vhost-user fails at the get_features in vhost_dev_init(), then the reconnect will fail and it will not be retriggered forever. The reason is: When the vhost-user fails at get_features, the vhost_dev_cleanup will be called immediately.

Re: [PATCH v2 41/58] i386/tdx: handle TDG.VP.VMCALL

2023-08-29 Thread Xiaoyao Li
On 8/30/2023 1:18 PM, Chenyi Qiang wrote: On 8/29/2023 6:25 PM, Daniel P. Berrangé wrote: On Tue, Aug 29, 2023 at 01:31:37PM +0800, Chenyi Qiang wrote: On 8/22/2023 4:24 PM, Daniel P. Berrangé wrote: On Tue, Aug 22, 2023 at 08:52:30AM +0200, Markus Armbruster wrote: Xiaoyao Li writes:

Re: [RFC 0/1] virtio-net: add support for SR-IOV emulation

2023-08-29 Thread Yui Washizu
On 2023/07/24 15:58, Jason Wang wrote: On Mon, Jul 24, 2023 at 10:32 AM Yui Washizu wrote: On 2023/07/20 11:20, Jason Wang wrote: On Wed, Jul 19, 2023 at 9:59 AM Yui Washizu wrote: This patch series is the first step towards enabling hardware offloading of the L2 packet switching feature

[PATCH v3 2/2] vhost: Add Error parameter to vhost_scsi_common_start()

2023-08-29 Thread Li Feng
Add a Error parameter to report the real error, like vhost-user-blk. Signed-off-by: Li Feng --- hw/scsi/vhost-scsi-common.c | 16 +--- hw/scsi/vhost-scsi.c | 5 +++-- hw/scsi/vhost-user-scsi.c | 14 -- include/hw/virtio/vhost-scsi-c

[PATCH v3 0/2] Fix vhost reconnect issues

2023-08-29 Thread Li Feng
The patchset fixes the regression issue of vhost reconnect. It's a serious bug that the vhost-user will lose the reconnect forever. The 2nd patch enhances the error handle of vhost-user-scsi. This patchset's parent commit is: https://lore.kernel.org/all/20230731121018.2856310-1-fen...@smartx.com/

Re: [PATCH v2 1/2] vhost-user: Fix lost reconnect

2023-08-29 Thread Li Feng
> On 30 Aug 2023, at 6:11 AM, Raphael Norwitz > wrote: > > > >> On Aug 24, 2023, at 3:41 AM, Li Feng wrote: >> >> When the vhost-user is reconnecting to the backend, and if the vhost-user >> fails >> at the get_features in vhost_dev_init(), then the reconnect will fail >> and it will not

[QEMU][PATCH v4 0/2] Add Virtio support to Xenpvh machine for arm

2023-08-29 Thread Vikram Garhwal
Hi, We added virtio-mmio support in xenpvh machine. Now, it can support upto 10 virtio mmio. Changelog: v3->v4: Moved the defs to xen_native.h v2->v3: Define GUEST_VIRTIO_*, GUEST_RAM* and xendevicemodel_set_irq() manually for old xen version. This was done to avoi

[QEMU][PATCH v4 2/2] xen_arm: Initialize RAM and add hi/low memory regions

2023-08-29 Thread Vikram Garhwal
From: Oleksandr Tyshchenko In order to use virtio backends we need to initialize RAM for the xen-mapcache (which is responsible for mapping guest memory using foreign mapping) to work. Calculate and add hi/low memory regions based on machine->ram_size. Use the constants defined in public header

[QEMU][PATCH v4 1/2] xen_arm: Create virtio-mmio devices during initialization

2023-08-29 Thread Vikram Garhwal
From: Oleksandr Tyshchenko In order to use virtio backends we need to allocate virtio-mmio parameters (irq and base) and register corresponding buses. Use the constants defined in public header arch-arm.h to be aligned with the toolstack. So the number of current supported virtio-mmio devices is

[PATCH v2, 1/1] memory: avoid updating ioeventfds for some address_space

2023-08-29 Thread hongmianquan via
When updating ioeventfds, we need to iterate all address spaces, but some address spaces do not register eventfd_add|del call when memory_listener_register() and they do nothing when updating ioeventfds. So we can skip these AS in address_space_update_ioeventfds(). The overhead of memory_region_tr

Re: [PATCH v1 3/7] hw/fsi: Introduce IBM's cfam,fsi-slave

2023-08-29 Thread Ninad Palsule
Hello Cedric, On 8/29/23 08:43, Cédric Le Goater wrote: On 8/29/23 15:39, Ninad Palsule wrote: Hello Thomas, On 8/28/23 21:03, Thomas Huth wrote: On 25/08/2023 22.30, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access

Re: [PATCH v1 0/7] Introduce model for IBM's FSP

2023-08-29 Thread Ninad Palsule
Hello Cedric, On 8/28/23 03:49, Cédric Le Goater wrote: Hello Ninad, On 8/25/23 22:30, Ninad Palsule wrote: Hello, Please review the patch-set. This is a first step towards introducing model for IBM's Flexible Service Interface. The full functionality will be implemented over the time. Nina

[PATCH v3 2/8] hw/fsi: Introduce IBM's scratchpad

2023-08-29 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS device is embeded inside the scratchpad. The scratchpad provides a non-functional registers. There is a 1-1 relation between scratchpad and LBUS devices. Each LBUS device has 1K memory mapped in the LBUS. Si

[PATCH v3 0/8] Introduce model for IBM's FSI

2023-08-29 Thread Ninad Palsule
Hello, Please review the patch-set version 3. I have incorporated review comments from Cedric and Thomas. Ninad Palsule (8): hw/fsi: Introduce IBM's Local bus hw/fsi: Introduce IBM's scratchpad hw/fsi: Introduce IBM's cfam,fsi-slave hw/fsi: Introduce IBM's FSI hw/fsi: IBM's On-chip Peri

[PATCH v3 6/8] hw/fsi: Aspeed APB2OPB interface

2023-08-29 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are indirect through the bridge. Signed-off-

[PATCH v3 3/8] hw/fsi: Introduce IBM's cfam,fsi-slave

2023-08-29 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal and external to the POWER chip. Examples include the SBEFIFO and I2C masters. The engines hang o

[PATCH v3 5/8] hw/fsi: IBM's On-chip Peripheral Bus

2023-08-29 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The On-Chip Peripheral Bus (OPB): A low-speed bus typically found in POWER processors. This now makes an appearance in the ASPEED SoC due to tight integration of the FSI master IP with the OPB, mainly the existence of

[PATCH v3 7/8] hw/arm: Hook up FSI module in AST2600

2023-08-29 Thread Ninad Palsule
This patchset introduces IBM's Flexible Service Interface(FSI). Time for some fun with inter-processor buses. FSI allows a service processor access to the internal buses of a host POWER processor to perform configuration or debugging. FSI has long existed in POWER processes and so comes with some

[PATCH v3 8/8] hw/fsi: Documentation and testing

2023-08-29 Thread Ninad Palsule
Added FSI document Added basic qtests for FSI model. Added MAINITAINER for FSI Replaced some qemu logs to traces. Signed-off-by: Ninad Palsule --- v3: - Incorporated Cedric's review comments. --- MAINTAINERS | 20 docs/specs/fsi.rst | 141 +++ hw/f

[PATCH v3 4/8] hw/fsi: Introduce IBM's FSI

2023-08-29 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. This commit models the FSI bus. CFAM is hanging out of FSI bus. The bus is model such a way that it is embeded inside the FSI master which is a bus controller. The FSI master: A controller in the platform service pro

[PATCH v3 1/8] hw/fsi: Introduce IBM's Local bus

2023-08-29 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain the qdev bus hierarchy and to take advantage of the object model to automatically generate the CFAM configuration block. The configuration block presents engines in the order they are

[PULL 0/1] Quick fix patches

2023-08-29 Thread Warner Losh
The following changes since commit 813bac3d8d70d85cb7835f7945eb9eed84c2d8d0: Merge tag '2023q3-bsd-user-pull-request' of https://gitlab.com/bsdimp/qemu into staging (2023-08-29 08:58:00 -0400) are available in the Git repository at: https://gitlab.com/bsdimp/qemu.git tags/quick-fix-pull-req

[PULL 1/1] linux-user: Move PRAGMA_DISABLE_PACKED_WARNING to compiler.h

2023-08-29 Thread Warner Losh
Replace the slightly older version of this in include/qemu/compiler.h that was commit as part of bsd-user changes with the newer one from linux-user. bsd-user has no regreassions with this. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- include/qemu/compiler.h | 6 +- linux-

Re: [PULL 0/3] Dirty page rate and dirty page limit 20230828 patches

2023-08-29 Thread Yong Huang
On Wed, Aug 30, 2023 at 1:31 AM Stefan Hajnoczi wrote: > On Tue, 29 Aug 2023 at 12:30, Yong Huang wrote: > > On Tue, Aug 29, 2023 at 4:01 AM Stefan Hajnoczi > wrote: > >> > >> On Mon, 28 Aug 2023 at 10:36, Hyman Huang > wrote: > >> > > >> > From: Hyman > >> > > >> > The following changes sinc

Re: [PATCH v2 47/58] i386/tdx: Wire REPORT_FATAL_ERROR with GuestPanic facility

2023-08-29 Thread Xiaoyao Li
On 8/29/2023 6:28 PM, Daniel P. Berrangé wrote: On Mon, Aug 28, 2023 at 09:14:41PM +0800, Xiaoyao Li wrote: On 8/21/2023 5:58 PM, Daniel P. Berrangé wrote: On Fri, Aug 18, 2023 at 05:50:30AM -0400, Xiaoyao Li wrote: Originated-from: Isaku Yamahata Signed-off-by: Xiaoyao Li --- qapi/run-st

Re: [PATCH v2 36/58] memory: Introduce memory_region_init_ram_gmem()

2023-08-29 Thread Xiaoyao Li
On 8/29/2023 10:33 PM, Philippe Mathieu-Daudé wrote: On 18/8/23 11:50, Xiaoyao Li wrote: Introduce memory_region_init_ram_gmem() to allocate private gmem on the MemoryRegion initialization. It's for the usercase of TDVF, which must be private on TDX case. Signed-off-by: Xiaoyao Li ---   includ

Re: [PATCH v2 13/58] kvm: Introduce kvm_arch_pre_create_vcpu()

2023-08-29 Thread Xiaoyao Li
On 8/29/2023 10:40 PM, Philippe Mathieu-Daudé wrote: On 18/8/23 11:49, Xiaoyao Li wrote: Introduce kvm_arch_pre_create_vcpu(), to perform arch-dependent work prior to create any vcpu. This is for i386 TDX because it needs call TDX_INIT_VM before creating any vcpu. Signed-off-by: Xiaoyao Li Ack

Re: [PATCH 2/2] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-08-29 Thread Richard Henderson
On 8/29/23 16:51, Daniel Henrique Barboza wrote: The compiler certainly does eliminate 0 && foo(), even at -O0. There must be something else going on. Pointer to your tree? It's this tree: https://github.com/alistair23/qemu/tree/riscv-to-apply.next Ok, so while -O0 will eliminate 0 && foo(

Re: [PATCH 1/2] igb: Add a VF reset handler

2023-08-29 Thread Akihiko Odaki
On 2023/08/29 18:05, Cédric Le Goater wrote: From: Cédric Le Goater Export the igb_vf_reset() helper routine from the PF model to let the IGBVF model implement its own device reset. Cc: Akihiko Odaki Suggested-by: Sriram Yagnaraman Signed-off-by: Cédric Le Goater Reviewed-by: Akihiko Odak

Re: [PATCH v2] linux-user: Move PRAGMA_DISABLE_PACKED_WARNING to compiler.h

2023-08-29 Thread Warner Losh
On Tue, Aug 29, 2023 at 5:57 PM Warner Losh wrote: > > > On Tue, Aug 29, 2023 at 5:35 PM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 8/29/23 11:47, Warner Losh wrote: >> > Replace the slightly older version of this in include/qemu/compiler.h >> > that was commit as part of

Re: [PATCH v2] linux-user: Move PRAGMA_DISABLE_PACKED_WARNING to compiler.h

2023-08-29 Thread Warner Losh
On Tue, Aug 29, 2023 at 5:35 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/29/23 11:47, Warner Losh wrote: > > Replace the slightly older version of this in include/qemu/compiler.h > > that was commit as part of bsd-user changes with the newer one from > > linux-user. bsd-user

Re: [PATCH 2/2] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-08-29 Thread Daniel Henrique Barboza
On 8/29/23 20:30, Richard Henderson wrote: On 8/29/23 16:09, Daniel Henrique Barboza wrote: -- >8 -- diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c @@ -79,7 +79,9 @@   /* KVM AIA only supports APLIC MSI. APLIC Wired is always emulated by QEMU. */   static bool virt_use_kvm_aia(RISCVVirtState

[PULL v2 0/5] tcg patch queue

2023-08-29 Thread Richard Henderson
8:00 -0400) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230829-2 for you to fetch changes up to 669fd6151337fdc81e34f7eb4940ba2f20d89957: Revert "include/exec: typedef abi_ptr to vaddr in softmmu" (2023-0

Re: [PATCH v2] linux-user: Move PRAGMA_DISABLE_PACKED_WARNING to compiler.h

2023-08-29 Thread Richard Henderson
On 8/29/23 11:47, Warner Losh wrote: Replace the slightly older version of this in include/qemu/compiler.h that was commit as part of bsd-user changes with the newer one from linux-user. bsd-user has no regreassions with this. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson diff

Re: [PATCH 2/2] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-08-29 Thread Richard Henderson
On 8/29/23 16:09, Daniel Henrique Barboza wrote: -- >8 -- diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c @@ -79,7 +79,9 @@   /* KVM AIA only supports APLIC MSI. APLIC Wired is always emulated by QEMU. */   static bool virt_use_kvm_aia(RISCVVirtState *s)   { -    return kvm_irqchip_in_kernel() &&

[PATCH v5 08/12] targer/arm: Inform helpers whether a PAC instruction is 'combined'

2023-08-29 Thread Richard Henderson
From: Aaron Lindsay An instruction is a 'combined' Pointer Authentication instruction if it does something in addition to PAC -- for instance, branching to or loading an address from the authenticated pointer. Knowing whether a PAC operation is 'combined' is needed to implement FEAT_FPACCOMBINE.

Re: [PATCH v8 07/12] virtio-sound: handle VIRTIO_SND_R_PCM_SET_PARAMS

2023-08-29 Thread Alex Bennée
Emmanouil Pitsidianakis writes: > Handle the set parameters control request. It reconfigures a stream > based on a guest's preference if the values are valid and supported. > > Based-on: > https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 > Signed-off-by: Igor

Re: [PATCH 25/32] bsd-user: Implement procctl(2) system call.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.c| 114 ++ bsd-user/freebsd/os-syscall.c | 3 + 2 files changed, 117 Acked-by: Richard Henderson I think you need to

[PATCH v5 01/12] tests/tcg/aarch64: Adjust pauth tests for FEAT_FPAC

2023-08-29 Thread Richard Henderson
With FEAT_FPAC, AUT* instructions that fail authentication do not produce an error value but instead fault. For pauth-2, install a signal handler and verify it gets called. For pauth-4 and pauth-5, we are explicitly testing the error value, so there's nothing to test with FEAT_FPAC, so exit early

[PATCH v5 11/12] linux-user/aarch64: Fix normal SIGILL si_code

2023-08-29 Thread Richard Henderson
Most illegal instructions use ILL_ILLOPC. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/aarch64/cpu_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/aarch64/cpu_loop.c b/linux-user/aarch64/cpu_loop.c index 2e2f7cf218..22c9789326

Re: [PATCH 10/32] bsd-user: Implement host_to_target_waitstatus conversion.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-proc.c | 17 + 1 file changed, 17 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 12/32] bsd-user: Implement getgroups(2) and setgroups(2) system calls.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-proc.h | 44 +++ bsd-user/freebsd/os-syscall.c | 9 +++ 2 files changed, 53 insertions(+) diff --git a/bsd-user/bsd-pro

Re: [PATCH 1/3] linux-user/aarch64: Add ESR signal frame for SIGSEGV, SIGBUS

2023-08-29 Thread Richard Henderson
On 8/29/23 07:35, Peter Maydell wrote: +/* See arch/arm64/mm/fault.c, set_thread_esr. */ +if (sig == TARGET_SIGSEGV || sig == TARGET_SIGBUS) { +return true; +} It's possible to get here without env->exception.syndrome being set correctly, I think, if we take a host SIGSEGV o

Re: [PATCH 06/32] bsd-user: Add bsd-proc.c to meson.build

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Warner Losh Signed-off-by: Warner Losh Signed-off-by: Karim Taha --- bsd-user/bsd-proc.h | 4 bsd-user/meson.build | 6 ++ 2 files changed, 10 insertions(+) diff --git a/bsd-user/bsd-proc.h b/bsd-user/bsd-proc.h index a1061bffb8..048773

[PATCH v5 18/20] linux-user/ppc: Add vdso

2023-08-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/ppc/vdso-asmoffset.h | 20 +++ linux-user/elfload.c| 9 ++ linux-user/ppc/signal.c | 31 +++-- linux-user/gen-vdso-elfn.c.inc | 7 + linux-user/ppc/Makefile.vdso| 18 +++ linux-user/ppc/meson.build | 12 ++ linu

[PATCH 8/9] migration: Add migration_rp_wait|kick()

2023-08-29 Thread Peter Xu
It's just a simple wrapper for rp_sem on either wait() or kick(), make it even clearer on how it is used. Prepared to be used even for other things. Signed-off-by: Peter Xu --- migration/migration.h | 15 +++ migration/migration.c | 4 ++-- migration/ram.c | 16 +++---

[PATCH] linux-user: Move PRAGMA_DISABLE_PACKED_WARNING to compiler.h

2023-08-29 Thread Warner Losh
Replace the slightly older version of this in include/qemu/compiler.h that was commit as part of bsd-user changes with the newer one from linux-user. bsd-user has no regreassions with this. Signed-off-by: Warner Losh --- include/qemu/compiler.h | 3 +-- linux-user/qemu.h| 26 --

Re: [PATCH 11/32] bsd-user: Get number of cpus.

2023-08-29 Thread Warner Losh
On Tue, Aug 29, 2023 at 1:50 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/27/23 08:57, Karim Taha wrote: > > From: Kyle Evans > > > > Signed-off-by: Kyle Evans > > Signed-off-by: Karim Taha > > --- > > bsd-user/bsd-proc.c | 39 +++ > >

Re: [PATCH 32/32] bsd-user: Implement pdfork(2) system call.

2023-08-29 Thread Warner Losh
On Tue, Aug 29, 2023 at 3:53 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/29/23 14:27, Warner Losh wrote: > > > +if (put_user_s32(fd, target_fdp)) { > > > +return -TARGET_EFAULT; > > > +} > > > > I *think* this copy belongs in the parent? >

[PATCH V4 10/11] tests/qtest: postcopy migration with suspend

2023-08-29 Thread Steve Sistare
Add a test case to verify that the suspended state is handled correctly by live migration postcopy. The test suspends the src, migrates, then wakes the dest. Signed-off-by: Steve Sistare --- tests/qtest/migration-test.c | 26 -- 1 file changed, 24 insertions(+), 2 deleti

[PATCH v5 07/12] target/arm: Implement FEAT_Pauth2

2023-08-29 Thread Richard Henderson
From: Aaron Lindsay Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Message-Id: <20230609172324.982888-6-aa...@os.amperecomputing.com> Signed-off-by: Richard Henderson --- docs/system/arm/emulation.rst | 1 + target/arm/tcg/cpu64.c| 2 +- targ

Re: [PATCH v2 00/48] tcg patch queue

2023-08-29 Thread Richard Henderson
On 8/28/23 23:17, Bastian Koppelmann wrote: I'm seeing a segfault in "make docker-test-tcg@debian-tricore-cross" after this pull request. git bisect points to: commit fc15bfb6a6bda8d4d01f1383579d385acae17c0f Author: Anton Johansson Date: Mon Aug 7 17:57:03 2023 +0200 include/exec: typ

Re: [PATCH 01/32] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Kyle Evans Signed-off-by: Kyle Evans Signed-off-by: Karim Taha --- bsd-user/syscall_defs.h | 4 1 file changed, 4 insertions(+) Reviewed-by: Richard Henderson r~

[PATCH v5 05/12] target/arm: Implement FEAT_PACQARMA3

2023-08-29 Thread Richard Henderson
Implement the QARMA3 cryptographic algorithm for PAC calculation. Implement a cpu feature to select the algorithm and document it. Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Message-Id: <20230609172324.982888-4-aa...@os.amperecomputing.com> [rth: Merg

[PATCH v5 06/12] target/arm: Implement FEAT_EPAC

2023-08-29 Thread Richard Henderson
From: Aaron Lindsay Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Message-Id: <20230609172324.982888-5-aa...@os.amperecomputing.com> Signed-off-by: Richard Henderson --- docs/system/arm/emulation.rst | 1 + target/arm/tcg/cpu64.c| 2 +- targ

[PATCH v5 13/20] linux-user/aarch64: Add vdso

2023-08-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/elfload.c | 7 linux-user/aarch64/meson.build | 33 +++ linux-user/aarch64/vdso-be.so | Bin 0 -> 3216 bytes linux-user/aarch64/vdso-le.so | Bin 0 -> 3216 bytes linux-user/aarch64/vdso.S | 73 ++

[PATCH 2/9] migration: Let migrate_set_error() take ownership

2023-08-29 Thread Peter Xu
migrate_set_error() used one error_copy() so it always copy an error. However that's not the major use case - the major use case is one would like to pass the error to migrate_set_error() without further touching the error. It can be proved if we see most of the callers are freeing the error expli

Re: [PATCH 22/32] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.c | 177 + 1 file changed, 177 insertions(+) Acked-by: Richard Henderson +if (do_fexec) { +if (((int)path_

[PATCH v5 10/12] linux-user/aarch64: Add ESR signal frame for SIGSEGV, SIGBUS

2023-08-29 Thread Richard Henderson
These are all synchronous exceptions for which the kernel passes on ESR to the user signal handler. Signed-off-by: Richard Henderson --- linux-user/aarch64/signal.c | 52 - target/arm/tcg/tlb_helper.c | 8 +- 2 files changed, 58 insertions(+), 2 deletions

[PATCH v5 02/12] target/arm: Add ID_AA64ISAR2_EL1

2023-08-29 Thread Richard Henderson
From: Aaron Lindsay Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Aaron Lindsay [PMM: drop the HVF part of the patch and just comment that we need to do something when the register appears in that API] Signed-off-by: Peter Maydell Signed-off-by: Richard He

Re: [PATCH 03/32] bsd-user: Implement host_to_target_siginfo.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Used in wait6 system call Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/signal-common.h | 1 + bsd-user/signal.c| 6 ++ 2 files changed, 7 insertions(+) Reviewed-by: Richard Henderson r~

[PATCH v5 09/12] target/arm: Implement FEAT_FPAC and FEAT_FPACCOMBINE

2023-08-29 Thread Richard Henderson
From: Aaron Lindsay Signed-off-by: Aaron Lindsay Reviewed-by: Richard Henderson Message-Id: <20230609172324.982888-8-aa...@os.amperecomputing.com> [rth: Simplify fpac comparison, reusing cmp_mask] Signed-off-by: Richard Henderson --- docs/system/arm/emulation.rst | 2 ++ target/arm/syndrome.

[PATCH v5 03/12] target/arm: Add feature detection for FEAT_Pauth2 and extensions

2023-08-29 Thread Richard Henderson
From: Aaron Lindsay Rename isar_feature_aa64_pauth_arch to isar_feature_aa64_pauth_qarma5 to distinguish the other architectural algorithm qarma3. Add ARMPauthFeature and isar_feature_pauth_feature to cover the other pauth conditions. Reviewed-by: Peter Maydell Signed-off-by: Aaron Lindsay Me

Re: [PATCH 30/32] bsd-user: Implement fork(2) and vfork(2) system calls.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.h| 34 ++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 42 insertions(+) Reviewed-by: Richard Henders

Re: [PATCH 26/32] bsd-user: Implement execve(2) and fexecve(2) system calls.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.h| 49 +++ bsd-user/freebsd/os-syscall.c | 10 +++ 2 files changed, 59 insertions(+) create mode 100644 bsd-user/fre

[PATCH v5 12/12] linux-user/aarch64: Add ESR signal frame for PACFAIL

2023-08-29 Thread Richard Henderson
The PACFAIL fault uses ILL_ILLOPN and includes ESR. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/aarch64/cpu_loop.c | 7 ++- linux-user/aarch64/signal.c | 6 ++ tests/tcg/aarch64/pauth-2.c | 25 - 3 files changed, 36 insertions

[PATCH v5 04/12] target/arm: Don't change pauth features when changing algorithm

2023-08-29 Thread Richard Henderson
We have cpu properties to adjust the pauth algorithm for the purpose of speed of emulation. Retain the set of pauth features supported by the cpu even as the algorithm changes. This already affects the neoverse-v1 cpu, which has FEAT_EPAC. Reviewed-by: Peter Maydell Signed-off-by: Richard Hende

Re: [PATCH v8 08/12] virtio-sound: handle VIRTIO_SND_R_PCM_PREPARE

2023-08-29 Thread Alex Bennée
Emmanouil Pitsidianakis writes: > Handles the PCM prepare control request. It initializes a PCM stream > when the guests asks for it. > > Based-on: > https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 > Signed-off-by: Igor Skalkin > Signed-off-by: Anton Yakovl

Re: [PATCH 23/32] bsd-user: Implement t2h procctl control request commands and h2t reaper status struct conversion.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/bsd-user/freebsd/os-proc.c b/bsd-user/freebsd/os-proc.c index 396

Re: [PATCH 19/32] bsd-user: Implement getpriority(2) and setpriority(2).

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: +static inline abi_long do_bsd_getpriority(abi_long which, abi_long who) +{ +abi_long ret; +/* + * Note that negative values are valid for getpriority, so we must + * differentiate based on errno settings. + */ +errno = 0; +ret = get

[PATCH v5 00/12] Implement Most ARMv8.3 Pointer Authentication Features

2023-08-29 Thread Richard Henderson
Changes for v5: * Updates for review. * Include linux-user ESR changes. Patch 10 is the only one without review. r~ Aaron Lindsay (6): target/arm: Add ID_AA64ISAR2_EL1 target/arm: Add feature detection for FEAT_Pauth2 and extensions target/arm: Implement FEAT_EPAC target/arm: Imple

Re: [PATCH 08/32] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/bsd-proc.c | 33 + 1 file changed, 33 insertions(+) Reviewed-by: Richard Henderson +rlim_t target_to_host_rlim(abi_llong target_rlim) +{

Re: [PATCH 31/32] bsd-user: Implement rfork(2) system call.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.h| 38 +++ bsd-user/freebsd/os-syscall.c | 4 2 files changed, 42 insertions(+) Reviewed-by: Richard Henderson

[PATCH V4 11/11] tests/qtest: background migration with suspend

2023-08-29 Thread Steve Sistare
Add a test case to verify that the suspended state is handled correctly by a background migration. The test suspends the src, migrates, then wakes the dest. Signed-off-by: Steve Sistare --- tests/qtest/migration-test.c | 21 + 1 file changed, 21 insertions(+) diff --git a/t

Re: [PATCH v2 1/4] nbd: drop unused nbd_receive_negotiate() aio_context argument

2023-08-29 Thread Eric Blake
On Tue, Aug 29, 2023 at 12:06:19PM -0400, Stefan Hajnoczi wrote: > aio_context is always NULL, so drop it. > > Suggested-by: Fabiano Rosas > Signed-off-by: Stefan Hajnoczi > --- > include/block/nbd.h | 3 +-- > nbd/client-connection.c | 3 +-- > nbd/client.c| 5 ++--- > qemu-nbd

Re: [PATCH v4 1/9] tests/tcg/aarch64: Adjust pauth tests for FEAT_FPAC

2023-08-29 Thread Richard Henderson
On 8/29/23 05:52, Peter Maydell wrote: -run-pauth-%: QEMU_OPTS += -cpu max +run-pauth-1: QEMU_OPTS += -cpu max +run-pauth-2: QEMU_OPTS += -cpu max +run-pauth-4: QEMU_OPTS += -cpu neoverse-v1 +run-pauth-5: QEMU_OPTS += -cpu neoverse-v1 Why do we need to specify neoverse-v1 here ? A comment would

[PATCH v5 14/20] linux-user/arm: Add vdso

2023-08-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/arm/signal.c| 28 +++--- linux-user/elfload.c | 3 +- linux-user/arm/meson.build | 35 linux-user/arm/vdso-be.so | Bin 0 -> 2680 bytes linux-user/arm/vdso-le.so | Bin 0 -> 2680 bytes linux-user/arm/vdso.S | 177 ++

Re: [PATCH 24/32] bsd-user: Implement h2t reaper_pidinfo and h2t/t2h reaper_kill structs conversion functions.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/bsd-user/freebsd/os-proc.c b/bsd-user/freebsd/os-proc.c index f06

Re: [PATCH 29/32] bsd-user: Implement pdgetpid(2) and the undocumented setugid.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.h| 23 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 31 insertions(+) Reviewed-by: Richard Henderson +/* u

[PATCH v5 06/20] linux-user: Use ImageSource in load_symbols

2023-08-29 Thread Richard Henderson
Aside from the section headers, we're unlikely to hit the ImageSource cache on guest executables. But the interface for imgsrc_read_* is better. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/elfload.c | 87 1 fi

[PATCH 0/9] migration: Better error handling in rp thread, allow failures in recover

2023-08-29 Thread Peter Xu
This patchset supersedes below: [PATCH v2 0/7] migration: Better error handling in return path thread Another note is that this might conflict with Fabiano's other patchset to fix postcopy race conditions, but maybe not. If collapse, I can rebase. Let me send this out still for early reviews. I

Re: [PULL 0/4] tcg patch queue

2023-08-29 Thread Richard Henderson
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230829 for you to fetch changes up to dad2f2f5afbaf58d6056f31dfd4b9edd0854b8ab: tcg/sparc64: Disable TCG_TARGET_HAS_extr_i64_i32 (2023-08-29 09:57:39 -0700) softmmu: Use async_

Re: [PATCH v8 06/12] virtio-sound: handle VIRTIO_SND_R_PCM_{START,STOP}

2023-08-29 Thread Alex Bennée
Emmanouil Pitsidianakis writes: > Handle the start and stop control messages for a stream_id. This request > does nothing at the moment except for replying to it. Audio playback > or capture will be started/stopped here in follow-up commits. > > Based-on: > https://github.com/OpenSynergy/qemu/

Re: [PATCH 05/10] meson: compile bundled device trees

2023-08-29 Thread Richard Henderson
On 8/29/23 07:25, Philippe Mathieu-Daudé wrote: On 29/8/23 10:29, Paolo Bonzini wrote: If dtc is available, compile the .dts files in the pc-bios directory instead of using the precompiled binaries. Signed-off-by: Paolo Bonzini ---   pc-bios/Makefile    | 19 ---   pc-bios/meson

Re: [PATCH 29/32] bsd-user: Implement pdgetpid(2) and the undocumented setugid.

2023-08-29 Thread Warner Losh
On Tue, Aug 29, 2023 at 2:36 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 8/27/23 08:57, Karim Taha wrote: > > From: Stacey Son > > > > Signed-off-by: Stacey Son > > Signed-off-by: Karim Taha > > --- > > bsd-user/freebsd/os-proc.h| 23 +++ > > bsd-

[PATCH v5 19/20] linux-user/s390x: Rename __SIGNAL_FRAMESIZE to STACK_FRAME_OVERHEAD

2023-08-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/s390x/signal.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index f72165576f..0f8b8e04bf 100644 --- a/linux-user/s390x/signal.c +++ b/linux-user/s390x/signal.c @@ -2

Re: [PATCH v8 05/12] virtio-sound: handle VIRTIO_SND_R_PCM_INFO request

2023-08-29 Thread Alex Bennée
Emmanouil Pitsidianakis writes: > Respond to the VIRTIO_SND_R_PCM_INFO control request with the parameters > of each requested PCM stream. > > Based-on: > https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 > Signed-off-by: Igor Skalkin > Signed-off-by: Anton Y

Re: [PATCH 20/32] bsd-user: Add freebsd/os-proc.c to meson.build

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: Signed-off-by: Karim Taha --- bsd-user/freebsd/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/bsd-user/freebsd/meson.build b/bsd-user/freebsd/meson.build index f87c788e84..d169e31235 100644 --- a/bsd-user/freebsd/meson.build +++ b/bsd-user/

[PATCH V4 04/11] migration: preserve suspended for snapshot

2023-08-29 Thread Steve Sistare
Restoring a snapshot can break a suspended guest. If a guest is suspended and saved to a snapshot using savevm, and qemu is terminated and restarted with the -S option, then loadvm does not restore the guest. The runstate is running, but the guest is not, because vm_start was not called. The roo

Re: [PATCH 3/3] linux-user/aarch64: Add ESR signal frame for PACFAIL

2023-08-29 Thread Richard Henderson
On 8/29/23 07:46, Peter Maydell wrote: +/* See arch/arm64/kernel/traps.c, do_el0_fpac, and our cpu_loop(). */ +if (sig == TARGET_SIGILL && code == TARGET_ILL_ILLOPN) { +return true; +} This works, but we'll need to do something else if the kernel adds some other fault later

[PATCH v5 12/20] linux-user/x86_64: Add vdso

2023-08-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/elfload.c | 4 +- linux-user/x86_64/meson.build | 20 + linux-user/x86_64/vdso.S | 78 ++ linux-user/x86_64/vdso.ld | 73 +++ linux-user/x86_64/vdso.so |

Re: [PATCH 32/32] bsd-user: Implement pdfork(2) system call.

2023-08-29 Thread Richard Henderson
On 8/27/23 08:57, Karim Taha wrote: From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha --- bsd-user/freebsd/os-proc.h| 32 bsd-user/freebsd/os-syscall.c | 4 2 files changed, 36 insertions(+) diff --git a/bsd-user/freebsd/os-pr

[PATCH v5 03/20] linux-user: Tidy loader_exec

2023-08-29 Thread Richard Henderson
Reorg the if cases to reduce indentation. Test for 4 bytes in the file before checking the signatures. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/linuxload.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(

Re: [PATCH v2 1/2] vhost-user: Fix lost reconnect

2023-08-29 Thread Raphael Norwitz
> On Aug 24, 2023, at 3:41 AM, Li Feng wrote: > > When the vhost-user is reconnecting to the backend, and if the vhost-user > fails > at the get_features in vhost_dev_init(), then the reconnect will fail > and it will not be retriggered forever. > > The reason is: > When the vhost-user fails

Re: [PATCH 05/10] meson: compile bundled device trees

2023-08-29 Thread Richard Henderson
On 8/29/23 01:29, Paolo Bonzini wrote: If dtc is available, compile the .dts files in the pc-bios directory instead of using the precompiled binaries. Signed-off-by: Paolo Bonzini --- pc-bios/Makefile| 19 --- pc-bios/meson.build | 25 + 2 files ch

[PATCH v5 02/20] linux-user: Introduce imgsrc_read, imgsrc_read_alloc

2023-08-29 Thread Richard Henderson
Introduced and initialized, but not yet really used. These will tidy the current tests vs BPRM_BUF_SIZE. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/loader.h| 61 +++- linux-user/linuxload.c | 90 +++

  1   2   3   4   >