Re: [PATCH 3/3] vdpa: Expose VIRTIO_NET_F_STATUS unconditionally

2022-11-06 Thread Jason Wang
On Thu, Nov 3, 2022 at 4:12 PM Eugenio Perez Martin wrote: > > On Thu, Nov 3, 2022 at 4:21 AM Jason Wang wrote: > > > > On Wed, Nov 2, 2022 at 7:19 PM Eugenio Perez Martin > > wrote: > > > > > > On Tue, Nov 1, 2022 at 9:10 AM Jason Wang wrote: > > > > > > > > On Fri, Oct 28, 2022 at 5:30 PM Eu

Re: [PATCH] tests/qtest/libqos/e1000e: Use e1000_regs.h

2022-11-06 Thread Jason Wang
On Tue, Oct 25, 2022 at 10:54 PM Thomas Huth wrote: > > On 13/10/2022 07.52, Akihiko Odaki wrote: > > The register definitions in tests/qtest/libqos/e1000e.c had names > > different from hw/net/e1000_regs.h, which made it hard to understand > > what test codes corresponds to the implementation. Us

Re: [PULL v3 49/81] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-06 Thread Ani Sinha
On Mon, Nov 7, 2022 at 3:09 AM Bernhard Beschow wrote: > > > > On Sun, Nov 6, 2022 at 10:16 PM Bernhard Beschow wrote: >> >> >> >> On Sat, Nov 5, 2022 at 6:45 PM Michael S. Tsirkin wrote: >>> >>> From: Igor Mammedov >>> >>> Signed-off-by: Igor Mammedov >>> Message-Id: <20221017102146.2254096-2

Re: [PATCH v2] tests/qtest: netdev: test stream and dgram backends

2022-11-06 Thread Jason Wang
On Mon, Nov 7, 2022 at 2:59 PM Jason Wang wrote: > > On Fri, Nov 4, 2022 at 11:01 PM Laurent Vivier wrote: > > > > Signed-off-by: Laurent Vivier > > Acked-by: Michael S. Tsirkin > > --- > > > > Notes: > > v2: > > - Fix ipv6 free port allocation > > - Check for IPv4, IPv6, AF_UNIX >

Re: [PATCH V5 2/4] intel-iommu: drop VTDBus

2022-11-06 Thread Jason Wang
On Sun, Nov 6, 2022 at 1:37 AM Michael S. Tsirkin wrote: > > On Fri, Oct 28, 2022 at 02:14:34PM +0800, Jason Wang wrote: > > > > -GHashTable *vtd_as_by_busptr; /* VTDBus objects indexed by PCIBus* > > reference */ > > -VTDBus *vtd_as_by_bus_num[VTD_PCI_BUS_MAX]; /* VTDBus objects indexe

Re: [PATCH v2] tests/qtest: netdev: test stream and dgram backends

2022-11-06 Thread Jason Wang
On Fri, Nov 4, 2022 at 11:01 PM Laurent Vivier wrote: > > Signed-off-by: Laurent Vivier > Acked-by: Michael S. Tsirkin > --- > > Notes: > v2: > - Fix ipv6 free port allocation > - Check for IPv4, IPv6, AF_UNIX > - Use g_mkdtemp() rather than g_file_open_tmp() > - Use socketpa

Re: Intermittent hang on x86 replay avocado test?

2022-11-06 Thread Pavel Dovgalyuk
On 04.11.2022 21:53, Peter Maydell wrote: On my machine this avocado test: ./build/all/tests/venv/bin/avocado run ./build/all/tests/avocado/replay_kernel.py:ReplayKernelNormal.test_x86_64_pc seems to hang intermittently (maybe 1 time in 3?). Does anybody else see this? Looking at the avocado l

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-06 Thread Sunil V L
On Sun, Nov 06, 2022 at 10:20:57PM +0300, Mike Maslenkin wrote: > Hello Sunil! > > What about virt_machine_done() function? > kernel_entry variable still points to the second flash started from > virt_memmap[VIRT_FLASH].size / 2. > The base address of the flash has not changed to keep things fle

[PATCH v4 1/2] vhost: Change the sequence of device start

2022-11-06 Thread Yajun Wu
This patch is part of adding vhost-user vhost_dev_start support. The motivation is to improve backend configuration speed and reduce live migration VM downtime. Moving the device start routines after finishing all the necessary device and VQ configuration, further aligning to the virtio specificat

[PATCH v4 0/2] vhost-user: Support vhost_dev_start

2022-11-06 Thread Yajun Wu
The motivation of adding vhost-user vhost_dev_start support is to improve backend configuration speed and reduce live migration VM downtime. Today VQ configuration is issued one by one. For virtio net with multi-queue support, backend needs to update RSS (Receive side scaling) on every rx queue en

[PATCH v4 2/2] vhost-user: Support vhost_dev_start

2022-11-06 Thread Yajun Wu
The motivation of adding vhost-user vhost_dev_start support is to improve backend configuration speed and reduce live migration VM downtime. Today VQ configuration is issued one by one. For virtio net with multi-queue support, backend needs to update RSS (Receive side scaling) on every rx queue en

[PULL 2/2] target/loongarch: Fix return value of CHECK_FPE

2022-11-06 Thread Song Gao
From: Rui Wang Regarding the patchset v3 has been merged into main line, and not approved, this patch updates to patchset v4. Fixes: 2419978c ("target/loongarch: Fix emulation of float-point disable exception") Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg00808.html Reviewe

[PULL 1/2] target/loongarch: Separate the hardware flags into MMU index and PLV

2022-11-06 Thread Song Gao
From: Rui Wang Regarding the patchset v3 has been merged into main line, and not approved, this patch updates to patchset v4. Fixes: b4bda200 ("target/loongarch: Adjust the layout of hardware flags bit fields") Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg00808.html Reviewe

[PULL 0/2] loongarch for 7.2 patches

2022-11-06 Thread Song Gao
The following changes since commit 466e81ff12013d026e2d0154266fce82bce2ee9b: Merge tag 'vfio-fixes-v7.2-rc0.0' of https://gitlab.com/alex.williamson/qemu into staging (2022-11-05 08:41:01 -0400) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-

Re: [PATCH 4/5] target/riscv: No need to re-start QEMU timer when timecmp == UINT64_MAX

2022-11-06 Thread Anup Patel
On Wed, Nov 2, 2022 at 5:40 AM Alistair Francis wrote: > > On Mon, Oct 31, 2022 at 1:49 PM Anup Patel wrote: > > > > On Mon, Oct 31, 2022 at 6:25 AM Alistair Francis > > wrote: > > > > > > On Fri, Oct 28, 2022 at 2:53 AM Anup Patel > > > wrote: > > > > > > > > The time CSR will wrap-around im

[PATCH 2/2] target/loongarch: Fix return value of CHECK_FPE

2022-11-06 Thread Rui Wang
Regarding the patchset v3 has been merged into main line, and not approved, this patch updates to patchset v4. Fixes: 2419978c ("target/loongarch: Fix emulation of float-point disable exception") Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg00808.html Reviewed-by: Richard Hen

[PATCH 0/2] Updates emulation of float-point to v4

2022-11-06 Thread Rui Wang
Regarding the patchset v3 has been merged into main line, and not approved, this patch updates to patchset v4. Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg00808.html Rui Wang (2): target/loongarch: Separate the hardware flags into MMU index and PLV target/loongarch: Fix

[PATCH 1/2] target/loongarch: Separate the hardware flags into MMU index and PLV

2022-11-06 Thread Rui Wang
Regarding the patchset v3 has been merged into main line, and not approved, this patch updates to patchset v4. Fixes: b4bda200 ("target/loongarch: Adjust the layout of hardware flags bit fields") Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg00808.html Reviewed-by: Richard Hen

Re: [PATCH v1 1/4] target/riscv: Add itrigger support when icount is not enabled

2022-11-06 Thread LIU Zhiwei
On 2022/11/7 9:37, Alistair Francis wrote: On Thu, Oct 13, 2022 at 4:32 PM LIU Zhiwei wrote: When icount is not enabled, there is no API in QEMU that can get the guest instruction number. Translate the guest code in a way that each TB only has one instruction. I don't think this is a great

Re: [PATCH v1 1/4] target/riscv: Add itrigger support when icount is not enabled

2022-11-06 Thread Alistair Francis
On Thu, Oct 13, 2022 at 4:32 PM LIU Zhiwei wrote: > > When icount is not enabled, there is no API in QEMU that can get the > guest instruction number. > > Translate the guest code in a way that each TB only has one instruction. I don't think this is a great idea. Why can't we just require icount

Re: [PATCH v3 11/11] Hexagon (target/hexagon) Use direct block chaining for tight loops

2022-11-06 Thread Richard Henderson
On 11/7/22 08:52, Taylor Simpson wrote: I coded this originally with manual handling but decided this would be easier to read/understand/maintain - especially as we add more flags and some have more than 1 bit. I haven't noticed the flags in any of the logs. Where are they printed? Third fi

RE: [PATCH v3 11/11] Hexagon (target/hexagon) Use direct block chaining for tight loops

2022-11-06 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Friday, November 4, 2022 8:44 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Matheus Bernardino (QUIC) > > Subject: Re: [PATCH v3 11/11] Hexagon (target/hexagon) Use

Re: [PULL v3 50/81] tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML automatically

2022-11-06 Thread Bernhard Beschow
On Sat, Nov 5, 2022 at 6:27 PM Michael S. Tsirkin wrote: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Message-Id: <20221017102146.2254096-3-imamm...@redhat.com> > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- > tests/qtest/bios-tables-test-allowed-diff

RE: [PATCH v3 10/11] Hexagon (target/hexagon) Use direct block chaining for direct jump/branch

2022-11-06 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Friday, November 4, 2022 8:33 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Matheus Bernardino (QUIC) > > Subject: Re: [PATCH v3 10/11] Hexagon (target/hexagon) Use

Re: [PULL v3 49/81] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-06 Thread Bernhard Beschow
On Sun, Nov 6, 2022 at 10:16 PM Bernhard Beschow wrote: > > > On Sat, Nov 5, 2022 at 6:45 PM Michael S. Tsirkin wrote: > >> From: Igor Mammedov >> >> Signed-off-by: Igor Mammedov >> Message-Id: <20221017102146.2254096-2-imamm...@redhat.com> >> Reviewed-by: Michael S. Tsirkin >> Signed-off-by:

[PATCH v2 6/6] accel/tcg: Split out setjmp_gen_code

2022-11-06 Thread Richard Henderson
Isolate the code protected by setjmp. Fixes: translate-all.c: In function ‘tb_gen_code’: translate-all.c:748:51: error: argument ‘cflags’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/translat

[PATCH v2 5/6] tcg: Move TCG_TARGET_HAS_direct_jump init to tb_gen_code

2022-11-06 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 10 -- tcg/tcg.c | 12 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 921944a5ab

[PATCH v2 2/6] disas/nanomips: Merge insn{1,2,3} into words[3]

2022-11-06 Thread Richard Henderson
Since Disassemble wants the data in this format, collect it that way. This allows using a loop to print the bytes. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- disas/nanomips.c | 44 +--- 1 file changed, 21 insertions(+), 23 d

[PATCH v2 4/6] disas/nanomips: Tidy read for 48-bit opcodes

2022-11-06 Thread Richard Henderson
There is no point in looking for a 48-bit opcode if we've not read the second word for a 32-bit opcode. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- disas/nanomips.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/disas/nanomips.c b/d

[PATCH v2 3/6] disas/nanomips: Split out read_u16

2022-11-06 Thread Richard Henderson
Split out a helper function for reading a uint16_t with the correct endianness. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- disas/nanomips.c | 48 +++- 1 file changed, 19 insertions(+), 29 deletions(-) diff --git a/disas/

[PATCH v2 1/6] disas/nanomips: Move setjmp into nanomips_dis

2022-11-06 Thread Richard Henderson
Reduce the number of local variables within the scope of the setjmp by moving it to the existing helper. The actual length returned from Disassemble is not used, because we have already determined the length while reading bytes. Fixes: nanomips.c: In function ‘print_insn_nanomips’: nanomips.c:21

[PATCH v2 0/6] Two -Wclobbered fixes, plus other cleanup

2022-11-06 Thread Richard Henderson
Stefan reported for accel/tcg, and I reproduced on Ubuntu 22.04. Changes for v2: * Incorporate suggested changes to nanomips.c (phil, balaton). r~ Richard Henderson (6): disas/nanomips: Move setjmp into nanomips_dis disas/nanomips: Merge insn{1,2,3} into words[3] disas/nanomips: Split

Re: [PULL v3 49/81] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-06 Thread Bernhard Beschow
On Sat, Nov 5, 2022 at 6:45 PM Michael S. Tsirkin wrote: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Message-Id: <20221017102146.2254096-2-imamm...@redhat.com> > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > NB: we do not expect any functional change in >

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-06 Thread Mike Maslenkin
Hello Sunil! What about virt_machine_done() function? kernel_entry variable still points to the second flash started from virt_memmap[VIRT_FLASH].size / 2. On Sun, Nov 6, 2022 at 5:41 PM Sunil V L wrote: > > The pflash implementation currently assumes fixed size of the > backend storage. Due to

Re: [RESEND PATCH 1/6] disas/nanomips: Move setjmp into nanomips_dis

2022-11-06 Thread Philippe Mathieu-Daudé
On 6/11/22 03:37, Richard Henderson wrote: Reduce the number of local variables within the scope of the setjmp by moving it to the existing helper. The actual length returned from Disassemble is not used, because we have already determined the length while reading bytes. Fixes: nanomips.c: In

Re: [PULL v2 31/82] vhost: Change the sequence of device start

2022-11-06 Thread Christian A. Ehrhardt
Hi, On Sat, Nov 05, 2022 at 12:43:05PM -0400, Michael S. Tsirkin wrote: > On Sat, Nov 05, 2022 at 05:35:57PM +0100, Bernhard Beschow wrote: > > > > > > On Wed, Nov 2, 2022 at 5:24 PM Michael S. Tsirkin wrote: > > > > From: Yajun Wu > > > > This patch is part of adding vhost-user vh

Re: [RESEND PATCH 4/6] disas/nanomips: Tidy read for 48-bit opcodes

2022-11-06 Thread Philippe Mathieu-Daudé
On 6/11/22 03:37, Richard Henderson wrote: There is no point in looking for a 48-bit opcode if we've not read the second word for a 32-bit opcode. Signed-off-by: Richard Henderson --- disas/nanomips.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Philippe

Re: [RESEND PATCH 5/6] tcg: Move TCG_TARGET_HAS_direct_jump init to tb_gen_code

2022-11-06 Thread Philippe Mathieu-Daudé
On 6/11/22 03:37, Richard Henderson wrote: Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 10 -- tcg/tcg.c | 12 2 files changed, 12 insertions(+), 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [RESEND PATCH 6/6] accel/tcg: Split out setjmp_gen_code

2022-11-06 Thread Philippe Mathieu-Daudé
On 6/11/22 03:37, Richard Henderson wrote: Isolate the code protected by setjmp. Fixes: translate-all.c: In function ‘tb_gen_code’: translate-all.c:748:51: error: argument ‘cflags’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] Signed-off-by: Richard Henderson --- accel/tcg

Re: [RESEND PATCH 3/6] disas/nanomips: Split out read_u16

2022-11-06 Thread Philippe Mathieu-Daudé
On 6/11/22 03:37, Richard Henderson wrote: Split out a helper function for reading a uint16_t with the correct endianness. Eh I was thinking about that when reviewing the previous patch :) Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- disas/nanomips.c | 48

Re: [RESEND PATCH 2/6] disas/nanomips: Merge insn{1,2,3} into words[3]

2022-11-06 Thread Philippe Mathieu-Daudé
On 6/11/22 03:37, Richard Henderson wrote: Since Disassemble wants the data in this format, collect it that way. This allows using a loop to print the bytes. Signed-off-by: Richard Henderson --- disas/nanomips.c | 44 +--- 1 file changed, 21 insertion

[PULL 03/12] tests/qtest/e1000e-test: Use e1000_regs.h

2022-11-06 Thread Thomas Huth
From: Akihiko Odaki The register definitions in tests/qtest/e1000e-test.c had names different from hw/net/e1000_regs.h, which made it hard to understand what test codes corresponds to the implementation. Use hw/net/e1000_regs.h from tests/qtest/libqos/e1000e.c to remove these duplications. Signe

[PULL 12/12] s390x/cpu topology: add max_threads machine class attribute

2022-11-06 Thread Thomas Huth
From: Pierre Morel The S390 CPU topology accepts the smp.threads argument while in reality it does not effectively allow multthreading. Let's keep this behavior for machines older than 7.2 and refuse to use threads in newer machines until multithreading is really exposed to the guest by the mach

[PULL 08/12] gitlab-ci: increase clang-user timeout

2022-11-06 Thread Thomas Huth
From: Stefan Hajnoczi The clang-user test exceeds the 1 hour timeout occassionally. Philippe Mathieu-Daudé has pointed out that the number of tcg tests has increased since QEMU 7.1. The execution time therefore probably reflects a legitimate increase in tests rather than a performance regression

[PULL 06/12] tests/qtest: Fix two format strings

2022-11-06 Thread Thomas Huth
From: Stefan Weil Signed-off-by: Stefan Weil Message-Id: <20221105115525.623059-1...@weilnetz.de> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.

[PULL 02/12] tests/qtest/libqos/e1000e: Set E1000_CTRL_SLU

2022-11-06 Thread Thomas Huth
From: Akihiko Odaki The later device status check depends on E1000_STATUS_LU, which is enabled by E1000_CTRL_SLU. Though E1000_STATUS_LU is not implemented and E1000_STATUS_LU is always available in the current implementation, be a bit nicer and set E1000_CTRL_SLU just in case the bit is implemen

[PULL 10/12] s390x/pci: RPCIT second pass when mappings exhausted

2022-11-06 Thread Thomas Huth
From: Matthew Rosato If we encounter a new mapping while the number of available DMA entries in vfio is 0, we are currently skipping that mapping which is a problem if we manage to free up DMA space after that within the same RPCIT -- we will return to the guest with CC0 and have not mapped every

[PULL 11/12] s390x: Register TYPE_S390_CCW_MACHINE properties as class properties

2022-11-06 Thread Thomas Huth
From: Pierre Morel Currently, when running 'qemu-system-s390x -M s390-ccw-virtio,help' the s390x-specific properties are not listed anymore. This happens because since commit d8fb7d0969 ("vl: switch -M parsing to keyval") the properties have to be defined at the class level and not at the instanc

[PULL 09/12] s390x/css: revert SCSW ctrl/flag bits on error

2022-11-06 Thread Thomas Huth
From: Peter Jin Revert the control and flag bits in the subchannel status word in case the SSCH operation fails with non-zero CC (ditto for CSCH and HSCH). According to POPS, the control and flag bits are only changed if SSCH, CSCH, and HSCH return CC 0, and no other action should be taken otherw

[PULL 00/12] qtest and s390x patches

2022-11-06 Thread Thomas Huth
Hi Stefan! The following changes since commit 6295a58ad1b73985b9c32d184de7d2ed1fbe1774: Merge tag 'pull-target-arm-20221104' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-11-04 11:01:17 -0400) are available in the Git repository at: https://gitlab.com/thuth/qemu.g

[PULL 04/12] tests/qtest/libqos/e1000e: Use E1000_STATUS_ASDV_1000

2022-11-06 Thread Thomas Huth
From: Akihiko Odaki Nemonics E1000_STATUS_LAN_INIT_DONE and E1000_STATUS_ASDV_1000 have the same value, and E1000_STATUS_ASDV_1000 should be used here because E1000_STATUS_ASDV_1000 represents the auto-detected speed tested here while E1000_STATUS_LAN_INIT_DONE is a value used for a different pur

[PULL 07/12] tests/qtest: migration-test: Enable TLS PSK tests for win32

2022-11-06 Thread Thomas Huth
From: Bin Meng Since commit f1018ea0a30f ("tests: avoid DOS line endings in PSK file"), the bug of the helper test_tls_psk_init_common() that caused TLS PSK tests to fail on Windows was fixed. Let's enable these tests on win32. Signed-off-by: Bin Meng Message-Id: <20221101035021.729669-1-bin.m.

[PULL 05/12] tests/qtest/libqos/e1000e: Use IVAR shift definitions

2022-11-06 Thread Thomas Huth
From: Akihiko Odaki There were still some constants defined in e1000_regs.h. Signed-off-by: Akihiko Odaki Message-Id: <20221105053010.38037-1-akihiko.od...@daynix.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qtest/libqos/e1000e.c | 6 +++--- 1 file changed, 3

[PULL 01/12] tests/qtest/libqos/e1000e: Refer common PCI ID definitions

2022-11-06 Thread Thomas Huth
From: Akihiko Odaki This is yet another minor cleanup to ease understanding and future refactoring of the tests. Signed-off-by: Akihiko Odaki Message-Id: <20221103015017.19947-1-akihiko.od...@daynix.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qtest/libqos/e1

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-06 Thread Andrew Jones
On Sun, Nov 06, 2022 at 08:09:00PM +0530, Sunil V L wrote: > The pflash implementation currently assumes fixed size of the > backend storage. Due to this, the backend storage file needs to be > exactly of size 32M. Otherwise, there will be an error like below. > > "device requires 33554432 bytes,

Re: [RESEND PATCH 1/6] disas/nanomips: Move setjmp into nanomips_dis

2022-11-06 Thread BALATON Zoltan
On Sun, 6 Nov 2022, Richard Henderson wrote: Reduce the number of local variables within the scope of the setjmp by moving it to the existing helper. The actual length returned from Disassemble is not used, because we have already determined the length while reading bytes. Fixes: nanomips.c: I

[Bug 1034423] Re: Guests running OpenIndiana (and relatives) fail to boot on AMD hardware

2022-11-06 Thread Thomas Huth
This bug tracker here is not used anymore. Could you please open a new ticket here: https://gitlab.com/qemu-project/qemu/-/issues Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1034423 Title

Re: [PATCH v7 resend 0/4] add generic vDPA device support

2022-11-06 Thread longpeng2--- via
在 2022/11/6 21:47, Michael S. Tsirkin 写道: On Sun, Nov 06, 2022 at 09:11:39PM +0800, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: 在 2022/11/6 13:22, Michael S. Tsirkin 写道: On Sun, Nov 06, 2022 at 08:17:07AM +0800, Longpeng (Mike, Cloud Infrastructure Service Product

[PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-06 Thread Sunil V L
The pflash implementation currently assumes fixed size of the backend storage. Due to this, the backend storage file needs to be exactly of size 32M. Otherwise, there will be an error like below. "device requires 33554432 bytes, block backend provides 3145728 bytes" Fix this issue by using the ac

Re: [PATCH] LockGuards: replace manual lock()/unlock() calls to WITH_QEMU_LOCK_GUARD()

2022-11-06 Thread Stefan Hajnoczi
On Fri, 4 Nov 2022 at 21:04, wrote: > > From: Samker ... > Signed-off-by: M N Gachu The author and Signed-off-by name/email are different. Do you want to use a single name/email? > --- > softmmu/physmem.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/softmmu/p

Re: [PATCH v7 resend 0/4] add generic vDPA device support

2022-11-06 Thread Michael S. Tsirkin
On Sun, Nov 06, 2022 at 09:11:39PM +0800, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > 在 2022/11/6 13:22, Michael S. Tsirkin 写道: > > On Sun, Nov 06, 2022 at 08:17:07AM +0800, Longpeng (Mike, Cloud > > Infrastructure Service Product Dept.) wrote: > > > > > > > > > 在

Re: [PATCH v7 resend 0/4] add generic vDPA device support

2022-11-06 Thread longpeng2--- via
在 2022/11/6 13:22, Michael S. Tsirkin 写道: On Sun, Nov 06, 2022 at 08:17:07AM +0800, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: 在 2022/11/6 0:43, Michael S. Tsirkin 写道: On Sat, Nov 05, 2022 at 04:36:25PM +0800, Longpeng(Mike) wrote: From: Longpeng Hi guys, With

[Bug 1034423] Re: Guests running OpenIndiana (and relatives) fail to boot on AMD hardware

2022-11-06 Thread Eric Levy
Despite the age of the report, I am also reproducing the issue. I am using Qemu 6.2.0 with KVM on Linux kernel 6.0.5 under Linux Mint 21. The guest is OpenIndiana Hipster 2021.10. A guest console capture is attached. The guest is managed using libvirt 8.0.0 The dump of the libvirt domain confi

Re: [PATCH v11 01/11] s390x: Register TYPE_S390_CCW_MACHINE properties as class properties

2022-11-06 Thread Thomas Huth
On 04/11/2022 15.57, Pierre Morel wrote: On 11/4/22 15:29, Thomas Huth wrote: On 04/11/2022 11.53, Cédric Le Goater wrote: On 11/4/22 11:16, Pierre Morel wrote: On 11/4/22 07:32, Thomas Huth wrote: On 03/11/2022 18.01, Pierre Morel wrote: Signed-off-by: Pierre Morel ---   hw/s390x/s390-

Re: [PATCH v2] s390x/css: revert SCSW ctrl/flag bits on error

2022-11-06 Thread Thomas Huth
On 28/10/2022 22.22, Eric Farman wrote: On Thu, 2022-10-27 at 23:23 +0200, Peter Jin wrote: Revert the control and flag bits in the subchannel status word in case the SSCH operation fails with non-zero CC (ditto for CSCH and HSCH). According to POPS, the control and flag bits are only changed if

[PULL 10/12] module: add Error arguments to module_load and module_load_qom

2022-11-06 Thread Paolo Bonzini
From: Claudio Fontana improve error handling during module load, by changing: bool module_load(const char *prefix, const char *lib_name); void module_load_qom(const char *type); to: int module_load(const char *prefix, const char *name, Error **errp); int module_load_qom(const char *type, Error

[PULL 12/12] accel: abort if we fail to load the accelerator plugin

2022-11-06 Thread Paolo Bonzini
From: Claudio Fontana if QEMU is configured with modules enabled, it is possible that the load of an accelerator module will fail. Exit in this case, relying on module_object_class_by_name to report the specific load error if any. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson

[PULL 11/12] dmg: warn when opening dmg images containing blocks of unknown type

2022-11-06 Thread Paolo Bonzini
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Message-Id: <20220929093035.4231-5-cfont...@suse.de> Signed-off-by: Paolo Bonzini --- block/dmg.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/dmg.c b/bl

[PULL 05/12] Fix broken configure with -Wunused-parameter

2022-11-06 Thread Paolo Bonzini
From: Stefan Weil The configure script fails because it tries to compile small C programs with a main function which is declared with arguments argc and argv although those arguments are unused. Running `configure -extra-cflags=-Wunused-parameter` triggers the problem. configure for a native bui

[PULL 08/12] module: removed unused function argument "mayfail"

2022-11-06 Thread Paolo Bonzini
From: Claudio Fontana mayfail is always passed as false for every invocation throughout the program. It controls whether to printf or not to printf an error on g_module_open failure. Remove this unused argument. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson Reviewed-by: Philip

[PULL 07/12] Add missing include statement for global xml_builtin

2022-11-06 Thread Paolo Bonzini
From: Stefan Weil This fixes some compiler warnings with compiler flag -Wmissing-variable-declarations (tested with clang): aarch64_be-linux-user-gdbstub-xml.c:564:19: warning: no previous extern declaration for non-static variable 'xml_builtin' [-Wmissing-variable-declarations] aarch6

[PULL 06/12] meson: avoid unused arguments of main() in compiler tests

2022-11-06 Thread Paolo Bonzini
meson.build has one test where "main" is declared unnecessarily with argc and argv arguments, but does not use them. Because the test needs -Werror too, HAVE_BROKEN_SIZE_MAX is defined incorrectly. Fix the test and, for consistency, remove argc and argv whenever they are not needed. Signed-off-b

[PULL 09/12] module: rename module_load_one to module_load

2022-11-06 Thread Paolo Bonzini
From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20220929093035.4231-3-cfont...@suse.de> Signed-off-by: Paolo Bonzini --- audio/audio.c | 2 +- block.c | 4 ++-- block/dmg.c

[PULL 00/12] Misc bugfix patches (+ improved module errors) for QEMU 7.2

2022-11-06 Thread Paolo Bonzini
The following changes since commit 6295a58ad1b73985b9c32d184de7d2ed1fbe1774: Merge tag 'pull-target-arm-20221104' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-11-04 11:01:17 -0400) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for

[PULL 04/12] gdb-xml: Fix size of EFER register on i386 architecture when debugged by GDB

2022-11-06 Thread Paolo Bonzini
From: TaiseiIto Before this commit, there were contradictory descriptions about size of EFER register. Line 113 says the size is 8 bytes. Line 129 says the size is 4 bytes. As a result, when GDB is debugging an OS running on QEMU, the GDB cannot read 'g' packets correctly. This 'g' packet transm

[PULL 02/12] util/main-loop: Avoid adding the same HANDLE twice

2022-11-06 Thread Paolo Bonzini
From: Bin Meng Fix the logic in qemu_add_wait_object() to avoid adding the same HANDLE twice, as the behavior is undefined when passing an array that contains same HANDLEs to WaitForMultipleObjects() API. Signed-off-by: Bin Meng Message-Id: <20221019102015.2441622-2-bmeng...@gmail.com> Signed-o

[PULL 01/12] util/main-loop: Fix maximum number of wait objects for win32

2022-11-06 Thread Paolo Bonzini
From: Bin Meng The maximum number of wait objects for win32 should be MAXIMUM_WAIT_OBJECTS, not MAXIMUM_WAIT_OBJECTS + 1. Signed-off-by: Bin Meng Message-Id: <20221019102015.2441622-1-bmeng...@gmail.com> Signed-off-by: Paolo Bonzini --- util/main-loop.c | 10 +- 1 file changed, 5 inse

[PULL 03/12] util/aio-win32: Correct the event array size in aio_poll()

2022-11-06 Thread Paolo Bonzini
From: Bin Meng WaitForMultipleObjects() can only wait for MAXIMUM_WAIT_OBJECTS object handles. Correct the event array size in aio_poll() and add a assert() to ensure it does not cause out of bound access. Signed-off-by: Bin Meng Reviewed-by: Stefan Weil Reviewed-by: Marc-André Lureau Reviewe

Re: [PATCH] tests/qtest/ac97-test: add up-/downsampling tests

2022-11-06 Thread Volker Rümelin
Am 04.11.22 um 18:33 schrieb Thomas Huth: On 26/10/2022 21.34, Volker Rümelin wrote: Am 25.10.22 um 09:44 schrieb Marc-André Lureau: Hi On Tue, Oct 25, 2022 at 12:31 AM Volker Rümelin wrote: Am 24.10.22 um 10:13 schrieb Marc-André Lureau: Hi On Mon, Oct 24, 2022 at 9:28 AM Volker Rümelin w

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

2022-11-06 Thread Thomas Huth
On 05/11/2022 12.48, Michael Tokarev wrote: Fixes: effaf5a240e03020f4ae953e10b764622c3e87cc Signed-off-by: Michael Tokarev --- hw/usb/hcd-xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 8299f35e66..b89b618ec2 100644 --- a/