On Mon, Nov 7, 2022 at 3:09 AM Bernhard Beschow <shen...@gmail.com> wrote: > > > > On Sun, Nov 6, 2022 at 10:16 PM Bernhard Beschow <shen...@gmail.com> wrote: >> >> >> >> On Sat, Nov 5, 2022 at 6:45 PM Michael S. Tsirkin <m...@redhat.com> wrote: >>> >>> From: Igor Mammedov <imamm...@redhat.com> >>> >>> Signed-off-by: Igor Mammedov <imamm...@redhat.com> >>> Message-Id: <20221017102146.2254096-2-imamm...@redhat.com> >>> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> >>> Signed-off-by: Michael S. Tsirkin <m...@redhat.com> >>> NB: we do not expect any functional change in >>> any ACPI tables with this change. It's only a refactoring. >>> >>> Reviewed-by: Ani Sinha <a...@anisinha.ca> >>> --- >>> hw/display/vga_int.h | 2 ++ >>> hw/display/acpi-vga-stub.c | 7 +++++++ >>> hw/display/acpi-vga.c | 26 ++++++++++++++++++++++++++ >>> hw/display/vga-pci.c | 4 ++++ >>> hw/i386/acpi-build.c | 26 +------------------------- >>> hw/display/meson.build | 17 +++++++++++++++++ >>> 6 files changed, 57 insertions(+), 25 deletions(-) >>> create mode 100644 hw/display/acpi-vga-stub.c >>> create mode 100644 hw/display/acpi-vga.c >> >> >> With this "qemu:qtest+qtest-hppa / qtest-hppa/display-vga-test" fails due to >> the symbol "aml_return" being undefined: >> >> # starting QEMU: exec ./qemu-system-hppa -qtest unix:/tmp/qtest-515650.sock >> -qtest-log /dev/null -chardev socket,path=/tmp/qtest-515650.qmp,id=char0 >> -mon chardev=char0,mode=control -display none -vga none -device virtio-vga >> -accel qtest >> ----------------------------------- stderr >> ----------------------------------- >> Failed to open module: >> qemu/build/qemu-bundle/usr/lib/qemu/hw-display-virtio-vga.so: undefined >> symbol: aml_return >> qemu-system-hppa: -device virtio-vga: 'virtio-vga' is not a valid device >> model name >> Broken pipe >> ../src/tests/qtest/libqtest.c:179: kill_qemu() tried to terminate QEMU >> process but encountered exit status 1 (expected 0) >> >> (test program exited with status code -6) > > > It doesn't only affect hppa: > > grep -e "undefined symbol: aml_return" meson-logs/testlog.txt | wc -l > 139 >
Hmm. I see it here too: https://gitlab.com/qemu-project/qemu/-/jobs/3281425457 >>> QTEST_QEMU_IMG=./qemu-img MALLOC_PERTURB_=60 >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh >>> QTEST_QEMU_BINARY=./qemu-system-or1k >>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon >>> /builds/qemu-project/qemu/build/tests/qtest/device-introspect-test --tap -k 219――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――― 220stderr: 221failed to open module: /builds/qemu-project/qemu/build/qemu-bundle/usr/local/lib64/qemu/hw-display-virtio-vga.so: undefined symbol: aml_return 222qemu-system-or1k: ../util/error.c:59: error_setv: Assertion `*errp == NULL' failed. 223Broken pipe 224../tests/qtest/libqtest.c:188: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped) 225TAP parsing error: Too few tests run (expected 6, got 0) 226(test program exited with status code -6) 227―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― 228154/274 qemu:qtest+qtest-or1k / qtest-or1k/machine-none-test OK 0.05s 1 subtests passed 229155/274 qemu:qtest+qtest-or1k / qtest-or1k/qmp-test OK 0.19s 4 subtests passed 230156/274 qemu:qtest+qtest-or1k / qtest-or1k/qmp-cmd-test ERROR 1.72s killed by signal 6 SIGABRT 231>>> QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh QTEST_QEMU_BINARY=./qemu-system-or1k QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon MALLOC_PERTURB_=53 /builds/qemu-project/qemu/build/tests/qtest/qmp-cmd-test --tap -k 232――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――― 233stderr: 234failed to open module: /builds/qemu-project/qemu/build/qemu-bundle/usr/local/lib64/qemu/hw-display-virtio-vga.so: undefined symbol: aml_return 235qemu-system-or1k: ../util/error.c:59: error_setv: Assertion `*errp == NULL' failed. 236Broken pipe 237../tests/qtest/libqtest.c:188: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped) 238TAP parsing error: Too few tests run (expected 62, got 31) 239(test program exited with status code -6) 240
