On 3/22/2022 5:02 PM, Gerd Hoffmann wrote:
On Thu, Mar 17, 2022 at 09:58:49PM +0800, Xiaoyao Li wrote:
Add sept-ve-disable property for tdx-guest object. It's used to
configure bit 28 of TD attributes.
What is this?
It seems this bit doesn't show up in the public spec yet.
Bit 28 (SEPT_VE_D
On 3/22/2022 5:29 PM, Daniel P. Berrangé wrote:
On Tue, Mar 22, 2022 at 10:21:41AM +0100, Gerd Hoffmann wrote:
Hi,
If you don't need a pflash device, don't use it: simply map your nvram
region as ram in your machine. No need to clutter the pflash model like
that.
Using the pflash device f
On Thu, Mar 24, 2022 at 12:15 PM leohou wrote:
>
> hi all,
> When I use DPDK in guestOS and configering the VM with vIOMMU, I found that
> sending the gVA to the hardware device , the hardware device can't find the
> real data.
> But sending the gPA to the hardware device, the hardware devic
hi all,
When I use DPDK in guestOS and configering the VM with vIOMMU, I found that
sending the gVA to the hardware device , the hardware device can't find the
real data.
But sending the gPA to the hardware device, the hardware device can find the
real data.
Environment:
OS: Linux version
The kvm_arch_get_supported_cpuid() only call KVM_GET_SUPPORTED_CPUID one
time, so the cpuid buffer information still keep older value. Once Qemu
enable new dynamic xfeature, like XTILEDATA, the cpuid[0D,0].{EBX,ECX}
still return older value.
This patch can return right size value in kvm_init_xsave
On Tue, Mar 22, 2022 at 11:56 PM Peter Maydell wrote:
>
> On Tue, 22 Mar 2022 at 15:43, Bin Meng wrote:
> >
> > When accessing the per-CPU register bank of some devices (e.g.: GIC)
> > from the GDB stub context, a segfault occurs. This is due to current_cpu
> > is not set, as the contect is not a
On Fri, Mar 18, 2022 at 2:34 PM Weiwei Li wrote:
>
> Co-authored-by: Ruibo Lu
> Co-authored-by: Zewen Ye
> Signed-off-by: Weiwei Li
> Signed-off-by: Junqiang Wang
Acked-by: Alistair Francis
Alistair
> ---
> disas/riscv.c | 173 +-
> 1 file c
On Fri, Mar 18, 2022 at 2:29 PM Weiwei Li wrote:
>
> - add sm3p0, sm3p1, sm4ed and sm4ks instructions
>
> Co-authored-by: Ruibo Lu
> Signed-off-by: Weiwei Li
> Signed-off-by: Junqiang Wang
> Reviewed-by: Richard Henderson
Acked-by: Alistair Francis
Alistair
> ---
> target/riscv/crypto_he
On Thu, Mar 24, 2022 at 8:31 AM Ralf Ramsauer
wrote:
>
> The -bios option is silently ignored if used in combination with -enable-kvm.
> The reason is that the machine starts in S-Mode, and the bios typically runs
> in
> M-Mode.
>
> Warn the user that the bios won't be loaded.
>
> Signed-off-by:
On 3/24/22 02:03, Eric Biggers wrote:
On Wed, Mar 23, 2022 at 03:32:37PM +0800, zhenwei pi wrote:
On 3/23/22 13:17, Eric Biggers wrote:
On Wed, Mar 23, 2022 at 10:49:06AM +0800, zhenwei pi wrote:
v2 -> v3:
- Introduce akcipher types to qapi
- Add test/benchmark suite for akcipher class
- Sepe
Both of these functions missed handling the TLB_MMIO flag
during the conversion to handle MTE.
Fixes: 10a85e2c8ab6 ("target/arm: Reuse sve_probe_page for gather loads")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/925
Signed-off-by: Richard Henderson
---
target/arm/sve_helper.c | 10 +
Hi, Philippe,
Thanks for your reply. I once attached the patch with the mail but it was
dropped during forwarding. I have pasted it as below again. Thanks a lot.
From 2257272c08291006bad5e9a44f48e7365f330640 Mon Sep 17 00:00:00 2001
From: Wenchao Wang
Date: Tue, 15 Mar 2022 20:51:22 +0800
Subj
Am 21. März 2022 13:06:29 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 21/3/22 11:57, Bernhard Beschow wrote:
>> Am 1. März 2022 22:52:19 UTC schrieb Bernhard Beschow :
>>> The QOM API already provides getters for uint64 and uint32 values, so reuse
>>> them.
>>>
>>> Signed-off-by: Bernhard Beschow
With the command line flag -mplt and a recent toolchain, ELF binaries
generated by gcc can obtain EI_ABIVERSION=1, see below, which makes, e.g.,
gcc three-stage bootstrap in a mips-unknown-linux-gnu qemu-user chroot
fail since the binfmt-misc magic does not match anymore.
qemu executes these binar
This information is given by the EF_MIPS_ABI2 (0x20) bit in the
e_flags field of the ELF header (a 4-byte value at offset 0x24 for
the here applicable ELFCLASS32).
See-also: https://www.mail-archive.com/qemu-devel@nongnu.org/msg732572.html
Signed-off-by: Andreas K. Hüttel
---
scripts/qemu-binfmt
Re-sending v3 unchanged as requested.
The first patch has already been submitted earlier and is unchanged from v2.
The second patch extends it and resolves issue 843, "duplicate magic mips
patterns".
Tested with various self-bootstrapped Gentoo chroots and in production on
the Gentoo release eng
Am 22. März 2022 08:23:09 UTC schrieb Mark Cave-Ayland
:
>On 21/03/2022 20:35, Peter Maydell wrote:
>
>> On Mon, 21 Mar 2022 at 18:55, Cédric Le Goater wrote:
>>> I introduced quite a few of these calls,
>>>
>>> hw/ppc/pnv_lpc.c:irqs = qemu_allocate_irqs(handler, lpc,
>>> ISA_NUM_IRQS);
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
From: Mark Kanda
vCPU hotunplug related leak reported by Valgrind:
==102631== 56 bytes in 1 blocks are definitely lost in loss record 5,089 of
8,555
==102631==at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117)
==102631==by 0x69EE4CD
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
static void common_vcpu_thread_destroy(CPUState *cpu)
{
+g_free(cpu->thread);
}
Missing free of halt_cond.
r~
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
+bool rr_destroy_vcpu_thread_precheck(CPUState *cpu)
+{
+if (single_tcg_cpu_thread) {
+single_tcg_cpu_thread = NULL;
+return true;
+}
+return false;
+}
This would become
void rr_destroy_vcpu_thread(CPUState *cpu)
{
The -bios option is silently ignored if used in combination with -enable-kvm.
The reason is that the machine starts in S-Mode, and the bios typically runs in
M-Mode.
Warn the user that the bios won't be loaded.
Signed-off-by: Ralf Ramsauer
---
hw/riscv/virt.c | 4
1 file changed, 4 inserti
On 23/03/2022 22:05, Alistair Francis wrote:
On Thu, Mar 24, 2022 at 3:13 AM Ralf Ramsauer
wrote:
The -bios option is silently ignored if used in combination with -enable-kvm.
The reason is that the machine starts in S-Mode, and the bios typically runs in
M-Mode.
Warn the user that the bio
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Introduce an empty common_vcpu_thread_destroy() function, and
provide a AccelOpsClass::destroy_vcpu_thread_precheck() callback
so accelerators can choose whether to call common_vcpu_thread_destroy.
Signed-off-by: Phil
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Introduce precheck/postcheck handlers which will help to
refactor code common to the various create_vcpu_thread()
implementations.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/accel-ops.h | 4
sof
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
+void rr_create_vcpu_thread_postcheck(CPUState *cpu)
{
-char thread_name[VCPU_THREAD_NAME_SIZE];
static QemuCond *single_tcg_halt_cond;
-static QemuThread *single_tcg_cpu_thread;
-
-if (!single_tcg_cpu_thread) {
-cpu->thr
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
All accelerators implement a very similar create_vcpu_thread()
handler. Extract the common part as common_vcpu_thread_create(),
which only requires the AccelOpsClass::vcpu_thread_fn() routine
and the accelerator AccelO
On Mon, Mar 21, 2022 at 5:08 PM John Snow wrote:
>
> The legacy.py module is heavily based on the QMP module by Luiz
> Capitulino (et al) which is licensed as explicit GPLv2-only. The async
> QMP package is currently licensed similarly, but I intend to relicense
> the async package to the more fle
On 3/22/22 22:49, David Gibson wrote:
On Tue, Mar 22, 2022 at 03:38:50PM -0300, Daniel Henrique Barboza wrote:
Hi,
This short series converts some spapr devices to use the dc->vmsd
interface to register the vmstate. For most of them it was needed
to use qdev_set_legacy_instance_id() to keep
On 3/22/22 22:48, David Gibson wrote:
On Tue, Mar 22, 2022 at 03:38:52PM -0300, Daniel Henrique Barboza wrote:
Similar to logical DRCs, let's convert physical DRCs to register their
vmstates using dc->vmsd.
The same constraints with instance_id being set to spapr_drc_index()
also applies in
On 3/17/22 13:29, Dr. David Alan Gilbert wrote:
* Peter Maydell (peter.mayd...@linaro.org) wrote:
On Thu, 17 Mar 2022 at 14:03, Daniel Henrique Barboza
wrote:
I've been looking into converting some vmstate_register() calls to use dc->vmsd,
using as a base the docs in docs/devel/migration.rs
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Reorg TCG AccelOpsClass initialization to emphasis icount
mode share more code with single-threaded TCG.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/tcg-accel-ops.c | 15 ---
1 file changed, 8 in
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Move TCG cflags initialization to thread handler.
Remove the duplicated assert checks.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/tcg-accel-ops-mttcg.c | 5 ++---
accel/tcg/tcg-accel-ops-rr.c| 7 +++
On Wed, Mar 23, 2022 at 2:20 PM Hanna Reitz wrote:
>
> On 21.03.22 22:08, John Snow wrote:
> > Now that we are fully switched over to the new QMP library, move it back
> > over the old namespace. This is being done primarily so that we may
> > upload this package simply as "qemu.qmp" without intro
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Both xsave_buf and hvf_caps are allocated in hvf_arch_init_vcpu(),
free them in hvf_arch_vcpu_destroy().
Reported-by: Mark Kanda
Suggested-by: Igor Mammedov
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/hvf/h
On 3/23/22 10:17, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Fix vCPU hot-unplug related leak reported by Valgrind:
==132362== 4,096 bytes in 1 blocks are definitely lost in loss record 8,440
of 8,549
==132362==at 0x4C3B15F: memalign (vg_replace_malloc.c:1265)
==13
On 23/3/22 16:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
For consistency with other os_ functions that do not have POSIX
implementation, declare an inline function for the stub in os-win32.h.
Signed-off-by: Marc-André Lureau
---
include/qemu-common.h | 4
inclu
On Thu, Mar 24, 2022 at 3:13 AM Ralf Ramsauer
wrote:
>
> The -bios option is silently ignored if used in combination with -enable-kvm.
> The reason is that the machine starts in S-Mode, and the bios typically runs
> in
> M-Mode.
>
> Warn the user that the bios won't be loaded.
>
> Signed-off-by:
Reviewed-by: Akihiko Odaki
On 2022/03/24 0:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Move qemu_main() declaration to a new header.
Simplify main.c since both cocoa & sdl cannot be enabled together.
(there might be some small conflict with the RFC patch "cocoa: run qemu_
On 3/23/22 10:22, Alex Bennée wrote:
Richard Henderson writes:
Inside qemu_log, we perform qemu_log_lock/unlock, which need
not be done if we have already performed the lock beforehand.
Always check the result of qemu_log_lock -- only checking
qemu_loglevel_mask races with the acquisition of
The CRB command buffer currently is a RAM MemoryRegion and given
its base address alignment, it causes an error report on
vfio_listener_region_add(). This region could have been a RAM device
region, easing the detection of such safe situation but this option
was not well received. So let's add a he
On Mon, Mar 21, 2022 at 7:59 PM Jamin Lin wrote:
> From: Steven Lee
>
> The image should be supplied with ELF binary.
> $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic
>
> Signed-off-by: Troy Lee
> Signed-off-by: Jamin Lin
> Signed-off-by: Steven Lee
>
Reviewed-by: Patrick Vent
On 3/23/22 16:57, Vladimir Sementsov-Ogievskiy wrote:
23.03.2022 13:53, Nikita Lapshin wrote:
From: Nikita Lapshin
This script is used for RAM capabilities test. But it cannot work
in case of no vm description in migration stream.
So new flag is added to allow work this script with ram-only
mig
On Wed, Mar 23, 2022 at 2:24 PM Hanna Reitz wrote:
>
> On 21.03.22 22:08, John Snow wrote:
> > Copy the docstrings out of qemu.qmp, adjusting them as necessary to
> > more accurately reflect the current state of this class.
> >
> > (Licensing: This is copying and modifying GPLv2-only licensed docs
On 3/23/2022 1:56 PM, Philippe Mathieu-Daudé wrote:
On 23/3/22 18:17, Philippe Mathieu-Daudé wrote:
From: Mark Kanda
Create cpu_address_space_destroy() to free a CPU's cpu_ases list.
This seems incorrect...
vCPU hotunplug related leak reported by Valgrind:
==132362== 216 bytes in 1 blocks
Peter Maydell writes:
> On Wed, 23 Mar 2022 at 11:27, Alex Bennée wrote:
>>
>> The following changes since commit 15ef89d2a1a7b93845a6b09c2ee8e1979f6eb30b:
>>
>> Update version for v7.0.0-rc1 release (2022-03-22 22:58:44 +)
>>
>> are available in the Git repository at:
>>
>> https://gi
On 23/3/22 18:17, Philippe Mathieu-Daudé wrote:
From: Mark Kanda
Create cpu_address_space_destroy() to free a CPU's cpu_ases list.
This seems incorrect...
vCPU hotunplug related leak reported by Valgrind:
==132362== 216 bytes in 1 blocks are definitely lost in loss record 7,119 of
8,549
=
On Sat, 19 Mar 2022 08:35:54 +
Mark Cave-Ayland wrote:
> On 18/03/2022 15:06, Jonathan Cameron wrote:
>
> > From: Ben Widawsky
> >
> > CXL host bridges themselves may have MMIO. Since host bridges don't have
> > a BAR they are treated as special for MMIO. This patch includes
> > i386/pc s
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Environment is implicitly inherited from the current process "environ"
variable for execl() or g_spawn_sync(), no need to be explicit about it.
Signed-off-by: Marc-André Lureau
---
meson.build | 2 --
qga/
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
It is only implemented for POSIX anyway.
Signed-off-by: Marc-André Lureau
---
include/qemu/cutils.h | 1 -
include/sysemu/os-posix.h | 2 ++
util/cutils.c | 17 -
util/oslib-posix
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
For consistency with other os_ functions that do not have POSIX
implementation, declare an inline function for the stub in os-win32.h.
Signed-off-by: Marc-André Lureau
---
include/qemu-common.h | 4
include
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
+++ b/include/qemu/qemu-progress.h
@@ -0,0 +1,8 @@
+#ifndef QEMU_PROGRESS_H
All files must have copyright header.
r~
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Since the implementation unit is page-vary.c.
Signed-off-by: Marc-André Lureau
---
include/exec/page-vary.h | 18 ++
include/qemu-common.h| 17 -
page-vary.c | 2 +-
On 21.03.22 22:08, John Snow wrote:
Copy the docstrings out of qemu.qmp, adjusting them as necessary to
more accurately reflect the current state of this class.
(Licensing: This is copying and modifying GPLv2-only licensed docstrings
into a GPLv2-only file.)
Signed-off-by: John Snow
Reviewed-b
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
The header name is more appropriate.
Signed-off-by: Marc-André Lureau
---
util/{qemu-error.c => error-report.c} | 0
util/meson.build | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
re
On Wed, 23 Mar 2022 at 17:36, Zongyuan Li wrote:
>
> Signed-off-by: Zongyuan Li
> ---
> hw/arm/realview.c | 41 -
> 1 file changed, 32 insertions(+), 9 deletions(-)
>
> diff --git a/hw/arm/realview.c b/hw/arm/realview.c
> index 7b424e94a5..97ace560bf 10064
On Wed, 23 Mar 2022 at 17:36, Zongyuan Li wrote:
>
> Signed-off-by: Zongyuan Li
> ---
> hw/arm/stellaris.c | 17 +++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
> index b6c8a5d609..ccc2d5def2 100644
> --- a/hw/arm/stel
On 21.03.22 22:08, John Snow wrote:
Now that we are fully switched over to the new QMP library, move it back
over the old namespace. This is being done primarily so that we may
upload this package simply as "qemu.qmp" without introducing confusion
over whether or not "aqmp" is a new protocol or n
On Sat, 19 Mar 2022 08:32:29 +
Mark Cave-Ayland wrote:
> On 18/03/2022 15:06, Jonathan Cameron via wrote:
>
> > From: Ben Widawsky
> >
> > A CXL memory device (AKA Type 3) is a CXL component that contains some
> > combination of volatile and persistent memory. It also implements the
> > pr
On Wed, 23 Mar 2022 at 17:36, Zongyuan Li wrote:
>
> Signed-off-by: Zongyuan Li
> ---
> hw/intc/exynos4210_gic.c | 25 ++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
>
Same comments apply here as for patch 3 -- this is a device,
so it needs to handle the sub-device
On Wed, 23 Mar 2022 at 17:37, Zongyuan Li wrote:
>
> Signed-off-by: Zongyuan Li
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/811
Reviewed-by: Peter Maydell
thanks
-- PMM
On Wed, 23 Mar 2022 at 17:36, Zongyuan Li wrote:
>
> Signed-off-by: Zongyuan Li
> ---
> hw/intc/exynos4210_combiner.c | 32 +---
> 1 file changed, 25 insertions(+), 7 deletions(-)
>
> diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c
> index 4
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Use more idiomatic glib/auto-style code.
Signed-off-by: Marc-André Lureau
---
tests/unit/check-qobject.c | 127 -
1 file changed, 40 insertions(+), 87 deletions(-)
Reviewed-by:
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Need wrappers for qobject_unref() calls, which is a macro.
Signed-off-by: Marc-André Lureau
---
include/qapi/qmp/qbool.h | 4
include/qapi/qmp/qdict.h | 4
include/qapi/qmp/qlist.h | 4
includ
Hi Wenchao,
On 16/3/22 01:47, Wang, Wenchao wrote:
diff --git a/MAINTAINERS b/MAINTAINERS
index f2e9ce1da2..36f877cf74 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -492,7 +492,6 @@ Guest CPU Cores (HAXM)
-
X86 HAXM CPUs
M: Wenchao Wang
-M: Colin Xu
L: haxm-t...@in
On Wed, 23 Mar 2022 at 11:27, Alex Bennée wrote:
>
> The following changes since commit 15ef89d2a1a7b93845a6b09c2ee8e1979f6eb30b:
>
> Update version for v7.0.0-rc1 release (2022-03-22 22:58:44 +)
>
> are available in the Git repository at:
>
> https://github.com/stsquad/qemu.git tags/pull-
On Wed, Mar 23, 2022 at 03:32:37PM +0800, zhenwei pi wrote:
>
> On 3/23/22 13:17, Eric Biggers wrote:
> > On Wed, Mar 23, 2022 at 10:49:06AM +0800, zhenwei pi wrote:
> > > v2 -> v3:
> > > - Introduce akcipher types to qapi
> > > - Add test/benchmark suite for akcipher class
> > > - Seperate 'virti
Signed-off-by: Zongyuan Li
---
hw/intc/exynos4210_gic.c | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/hw/intc/exynos4210_gic.c b/hw/intc/exynos4210_gic.c
index bc73d1f115..d8ecb9fae3 100644
--- a/hw/intc/exynos4210_gic.c
+++ b/hw/intc/exynos4210_gi
Signed-off-by: Zongyuan Li
---
hw/intc/exynos4210_combiner.c | 32 +---
1 file changed, 25 insertions(+), 7 deletions(-)
diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c
index 4534ee248d..18dade35d3 100644
--- a/hw/intc/exynos4210_combiner.c
Signed-off-by: Zongyuan Li
---
hw/arm/stellaris.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
index b6c8a5d609..ccc2d5def2 100644
--- a/hw/arm/stellaris.c
+++ b/hw/arm/stellaris.c
@@ -9,6 +9,7 @@
#include "qemu/
Signed-off-by: Zongyuan Li
---
hw/arm/realview.c | 41 -
1 file changed, 32 insertions(+), 9 deletions(-)
diff --git a/hw/arm/realview.c b/hw/arm/realview.c
index 7b424e94a5..97ace560bf 100644
--- a/hw/arm/realview.c
+++ b/hw/arm/realview.c
@@ -13,9 +13,11
Signed-off-by: Zongyuan Li
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/811
---
hw/core/irq.c| 15 ---
include/hw/irq.h | 5 -
2 files changed, 20 deletions(-)
diff --git a/hw/core/irq.c b/hw/core/irq.c
index 741219277b..3623f711fe 100644
--- a/hw/core/irq.c
+++ b
Thanks Philippe,
In the patch subject, 'generic_destroy_vcpu_thread()' should be changed to
'common_vcpu_thread_destroy()'.
Same goes for the next patch (Free cpu->halt_cond).
Thanks/regards,
-Mark
On 3/23/2022 12:17 PM, Philippe Mathieu-Daudé wrote:
From: Mark Kanda
Free cpu->thread in a
This patch set tries to replace 'qemu_irq_split' function with QOM
object 'TYPE_SPLIT_IRQ' and totally remove this call.
If this patch set is applied, issue:
https://gitlab.com/qemu-project/qemu/-/issues/811
can be closed.
Changes since rfc v2:
1. Replace all 'qemu_irq_split' calls in multiple
Richard Henderson writes:
> Avoid using QemuLogFile and RCU directly.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
From: Mark Kanda
vCPU hotunplug related leak reported by Valgrind:
==102631== 56 bytes in 1 blocks are definitely lost in loss record 5,089 of
8,555
==102631==at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117)
==102631==by 0x69EE4CD: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.5600.4)
From: Philippe Mathieu-Daudé
TCG/RR is special and creates a single vCPU. It only have
to release its resources once. Implement the .precheck()
for that purpose.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/tcg-accel-ops-rr.c | 9 +
accel/tcg/tcg-accel-ops.c| 1 +
2 files ch
From: Philippe Mathieu-Daudé
All accelerators implement a very similar create_vcpu_thread()
handler. Extract the common part as common_vcpu_thread_create(),
which only requires the AccelOpsClass::vcpu_thread_fn() routine
and the accelerator AccelOpsClass::thread_name for debugging
purpose.
The s
Richard Henderson writes:
> Do not replicate the individual logging statements.
> Use qemu_log_lock/unlock instead of qemu_log directly.
>
> Signed-off-by: Richard Henderson
I don't know why Xen wants to have it's own special handling for errors.
It seems a lot of the xen_pv_printf's of level
From: Philippe Mathieu-Daudé
Reorg TCG AccelOpsClass initialization to emphasis icount
mode share more code with single-threaded TCG.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/tcg-accel-ops.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/accel/tc
Richard Henderson writes:
> Inside qemu_log, we perform qemu_log_lock/unlock, which need
> not be done if we have already performed the lock beforehand.
>
> Always check the result of qemu_log_lock -- only checking
> qemu_loglevel_mask races with the acquisition of the lock
> on the logfile.
I
From: Mark Kanda
Free cpu->thread in a new AccelOpsClass::destroy_vcpu_thread() handler
generic_destroy_vcpu_thread().
vCPU hotunplug related leak reported by Valgrind:
==102631== 8 bytes in 1 blocks are definitely lost in loss record 1,037 of
8,555
==102631==at 0x4C3ADBB: calloc (vg_r
From: Philippe Mathieu-Daudé
Introduce precheck/postcheck handlers which will help to
refactor code common to the various create_vcpu_thread()
implementations.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/accel-ops.h | 4
softmmu/cpus.c | 8 +++-
2 files change
From: Philippe Mathieu-Daudé
Both xsave_buf and hvf_caps are allocated in hvf_arch_init_vcpu(),
free them in hvf_arch_vcpu_destroy().
Reported-by: Mark Kanda
Suggested-by: Igor Mammedov
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/hvf/hvf.c | 2 ++
1 file changed, 2 insertions(+)
d
From: Philippe Mathieu-Daudé
Introduce an empty common_vcpu_thread_destroy() function, and
provide a AccelOpsClass::destroy_vcpu_thread_precheck() callback
so accelerators can choose whether to call common_vcpu_thread_destroy.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/accel-ops.
From: Philippe Mathieu-Daudé
Move TCG cflags initialization to thread handler.
Remove the duplicated assert checks.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/tcg-accel-ops-mttcg.c | 5 ++---
accel/tcg/tcg-accel-ops-rr.c| 7 +++
2 files changed, 5 insertions(+), 7 deletions(-)
From: Philippe Mathieu-Daudé
Hi,
This is a respin of Mark 'vCPU hotunplug related memory leaks' v3:
https://lore.kernel.org/qemu-devel/20220321141409.3112932-1-mark.ka...@oracle.com/
Instead I refactored to extract the common common_vcpu_thread_create()
from all accelerators (except TCG/RR, whi
From: Philippe Mathieu-Daudé
We are going to extract common pattern from rr_start_vcpu_thread().
First extract the rr_create_vcpu_thread_precheck() helper.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/tcg-accel-ops-rr.c | 7 +++
accel/tcg/tcg-accel-ops-rr.h | 1 +
2 files changed, 8
From: Philippe Mathieu-Daudé
Both the comment and the hvf_enabled() check are duplicated
at the beginning of hvf_cpu_thread_fn(), which is the thread
callback created by hvf_start_vcpu_thread(). Remove.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/hvf/hvf-accel-ops.c | 6 --
1 file chan
From: Philippe Mathieu-Daudé
Fix vCPU hot-unplug related leak reported by Valgrind:
==132362== 4,096 bytes in 1 blocks are definitely lost in loss record 8,440
of 8,549
==132362==at 0x4C3B15F: memalign (vg_replace_malloc.c:1265)
==132362==by 0x4C3B288: posix_memalign (vg_replace_m
From: Mark Kanda
Create cpu_address_space_destroy() to free a CPU's cpu_ases list.
vCPU hotunplug related leak reported by Valgrind:
==132362== 216 bytes in 1 blocks are definitely lost in loss record 7,119 of
8,549
==132362==at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117)
==132362==by
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Suggested-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
---
include/qemu/osdep.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/qemu/osdep.h
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Replace a config-time define with a compile time condition
define (compatible with clang and gcc) that must be declared prior to
its usage. This avoids having a global configure time define, but also
prevents from bad u
On 22/03/2022 11.31, Thomas Huth wrote:
On 22/03/2022 09.53, David Hildenbrand wrote:
On 22.03.22 01:04, David Miller wrote:
[...]
diff --git a/tests/tcg/s390x/Makefile.target
b/tests/tcg/s390x/Makefile.target
index 8c9b6a13ce..921a056dd1 100644
--- a/tests/tcg/s390x/Makefile.target
+++ b/tes
The -bios option is silently ignored if used in combination with -enable-kvm.
The reason is that the machine starts in S-Mode, and the bios typically runs in
M-Mode.
Warn the user that the bios won't be loaded.
Signed-off-by: Ralf Ramsauer
---
hw/riscv/virt.c | 3 +++
1 file changed, 3 insertio
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Convert the TARGET_WORDS_BIGENDIAN macro, similarly to what was done
with HOST_BIG_ENDIAN. The new TARGET_BIG_ENDIAN macro is either 0 or 1,
and thus should always be defined to prevent misuse.
Signed-off-by: Marc-Andr
On 3/23/22 08:57, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Replace a config-time define with a compile time condition
define (compatible with clang and gcc) that must be declared prior to
its usage. This avoids having a global configure time define, but also
prevents from bad u
On 21/03/2022 21:47, Palmer Dabbelt wrote:
On Sun, 20 Mar 2022 22:43:07 PDT (-0700), alistai...@gmail.com wrote:
On Thu, Mar 17, 2022 at 7:46 PM Peter Maydell
wrote:
On Wed, 16 Mar 2022 at 22:23, Alistair Francis
wrote:
> Hmm... This seems like a bug. We shouldn't allow the user to spec
Richard Henderson writes:
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Typo s/ressources/resources/ in subject.
On 22/3/22 20:07, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Both xsave_buf and hvf_caps are allocated in hvf_arch_init_vcpu(),
free them in hvf_arch_vcpu_destroy().
Reported-by: Mark Kanda
Suggested-by: Igor Mammedov
Signed-off-by: P
Richard Henderson writes:
> Do not require qemu_log_unlock to be called when
> qemu_log_lock returns NULL.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
1 - 100 of 278 matches
Mail list logo
