Re: [PULL 2/3] hw/usb: hcd-xhci-pci: Raise MSI/MSI-X interrupts only when told to

2021-05-31 Thread Bin Meng
On Mon, May 31, 2021 at 11:33 PM Alexander Bulekov wrote: > > On 210528 1622, Gerd Hoffmann wrote: > > From: Ruimei Yan > > > > At present MSI / MSI-X interrupts are triggered regardless of the > > irq level. We should have checked the level to determine whether > > the interrupt needs to be deli

Re: [PATCH v2 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper

2021-05-31 Thread Alistair Francis
On Mon, May 31, 2021 at 12:34 PM Bin Meng wrote: > > On Fri, Apr 30, 2021 at 3:13 PM Bin Meng wrote: > > > > From: Bin Meng > > > > Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array > > helper"), > > we can use the new helper to set the clock name for the ethernet > > c

[PATCH 2/2] nbd/server: Use drained block ops to quiesce the server

2021-05-31 Thread Sergio Lopez
Before switching between AioContexts we need to make sure that we're fully quiesced ("nb_requests == 0" for every client) when entering the drained section. To do this, we set "quiescing = true" for every client on ".drained_begin" to prevent new coroutines to be created, and check if "nb_requests

[PATCH 1/2] block-backend: add drained_poll

2021-05-31 Thread Sergio Lopez
Allow block backends to poll their devices/users to check if they have been quiesced when entering a drained section. This will be used in the next patch to wait for the NBD server to be completely quiesced. Suggested-by: Kevin Wolf Signed-off-by: Sergio Lopez --- block/block-backend.c

[PATCH 0/2] nbd/server: Quiesce server on drained section

2021-05-31 Thread Sergio Lopez
Before switching between AioContexts we need to make sure that we're fully quiesced ("nb_requests == 0" for every client) when entering the drained section. Otherwise, coroutines may be run in the wrong context after the switch, leading to a number of critical issues. To accomplish this, we add ".

[PATCH v3 1/1] yank: Unregister function when using TLS migration

2021-05-31 Thread Leonardo Bras
After yank feature was introduced in migration, whenever migration is started using TLS, the following error happens in both source and destination hosts: (qemu) qemu-kvm: ../util/yank.c:107: yank_unregister_instance: Assertion `QLIST_EMPTY(&entry->yankfns)' failed. This happens because of a miss

[PATCH v3] docs/secure-coding-practices: Describe how to use 'null-co' block driver

2021-05-31 Thread Philippe Mathieu-Daudé
Document that security reports must use 'null-co,read-zeroes=on' because otherwise the memory is left uninitialized (which is an on-purpose performance feature). Signed-off-by: Philippe Mathieu-Daudé --- v3: Simplified using Vladimir suggestion. --- docs/devel/secure-coding-practices.rst | 9 +++

[PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-05-31 Thread Gavin Shan
We possibly populate empty nodes where memory isn't included and might be hot added at late time. The FDT memory nodes can't be created due to conflicts on their names if multiple empty nodes are specified. For example, the VM fails to start with the following error messages. /home/gavin/sandbox

Re: [PATCH v6 11/26] tcg/tci: Use ffi for calls

2021-05-31 Thread Philippe Mathieu-Daudé
On 5/3/21 1:57 AM, Richard Henderson wrote: > This requires adjusting where arguments are stored. > Place them on the stack at left-aligned positions. > Adjust the stack frame to be at entirely positive offsets. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg.h| 1 + > tcg

Re: [PATCH] Add display suboptions to man pages

2021-05-31 Thread Gerd Hoffmann
Hi, > SRST > ``-numa > node[,mem=size][,cpus=firstcpu[-lastcpu]][,nodeid=node][,initiator=initiator]`` > - \ > + \ Seems some unrelated (whitespace?) changes sneaked in. > @@ -1819,11 +1819,22 @@ SRST > old style -sdl/-curses/... options. Use ``-display help`` to list > the ava

Re: Problem with Avocado and QEMU console

2021-05-31 Thread Philippe Mathieu-Daudé
On 5/3/21 4:46 PM, Willian Rampazzo wrote: > On Mon, May 3, 2021 at 10:36 AM Philippe Mathieu-Daudé > wrote: >> >> On 5/3/21 3:12 PM, Willian Rampazzo wrote: >>> Hi Philippe, >>> >>> On Mon, May 3, 2021 at 9:59 AM Philippe Mathieu-Daudé >>> wrote: Hi Cleber, Willian, Avocado

Re: [PATCH] target/hppa: Remove unused 'memory.h' header

2021-05-31 Thread Philippe Mathieu-Daudé
Laurent, can you take this reviewed patch via qemu-trivial? On 5/17/21 12:15 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/hppa/cpu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h > index 61178fa6a2a..748

Re: [RFC PATCH 00/12] exec/memory: Experimental API to catch unaligned accesses

2021-05-31 Thread Philippe Mathieu-Daudé
Hi, If there is any feedback, should I discard this experiment? On 5/20/21 1:09 PM, Philippe Mathieu-Daudé wrote: > This series is an experiment after chatting with Stefan and having > received review from Peter / Richard on an orthogonal series aiming > to handle unaligned pointers (atomically):

Re: [PATCH 11/11] target/mips: Drop denormal operand to update_msacsr

2021-05-31 Thread Philippe Mathieu-Daudé
On 5/27/21 6:14 AM, Richard Henderson wrote: > The comment about not signaling all underflow cases is > almost certainly incorrect. It has been there since the > initial commit of the file. > > There is a bit of code below that sets underflow with > float_flag_oflush_denormal, which is probably t

Re: [PATCH 09/11] target/mips: Drop inline markers from msa_helper.c

2021-05-31 Thread Philippe Mathieu-Daudé
On 5/27/21 6:14 AM, Richard Henderson wrote: > Some of these functions are quite large. > Let the compiler decide whether to inline. > > Cc: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > target/mips/tcg/msa_helper.c | 262 --- > 1 file changed

Re: [PATCH 07/11] target/rx: Use FloatRoundMode in helper_set_fpsw

2021-05-31 Thread Philippe Mathieu-Daudé
On 5/27/21 6:14 AM, Richard Henderson wrote: > Use the proper type for the roundmode array. > > Cc: Philippe Mathieu-Daudé > Cc: Yoshinori Sato > Signed-off-by: Richard Henderson > --- > target/rx/op_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathie

[PATCH] Add display suboptions to man pages

2021-05-31 Thread email
From: Ahmed Abouzied Updates man pages with the suboptions for the `-display`. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/128 Buglink: https://bugs.launchpad.net/qemu/+bug/1620660 Signed-off-by: Ahmed Abouzied --- This is just a trivial update for the man pages. It's the first ti

Re: [PATCH v4] target/ppc: overhauled and moved logic of storing fpscr

2021-05-31 Thread David Gibson
On Thu, May 27, 2021 at 01:35:22PM -0300, Bruno Larsen (billionai) wrote: 65;6401;1c> Followed the suggested overhaul to store_fpscr logic, and moved it to > cpu.c where it can be accessed in !TCG builds. > > The overhaul was suggested because storing a value to fpscr should > never raise an exce

Re: [PATCH v3 0/4] target/ppc: Remove DO_PPC_STATISTICS and PPC_DUMP_CPU

2021-05-31 Thread David Gibson
On Mon, May 31, 2021 at 11:56:25AM -0300, Bruno Larsen (billionai) wrote: > These 2 defines are being obsoleted as we move to decodetree, so they > were removed. > > Also, upon further inspection, qemu already doesn't build with them > enabled, and probably hasn't for a while, and no one complaine

Re: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU

2021-05-31 Thread da...@gibson.dropbear.id.au
On Mon, May 31, 2021 at 05:46:07PM +, Luis Fernando Fujita Pires wrote: > From: Bruno Larsen (billionai) > > This feature will no longer be useful as ppc moves to using decotree for > > TCG. > > And building with it enabled is no longer possible, due to changes in > > opc_handler_t. Since the

Re: [target/ppc] excp_helper.c and mmu_helper.c cleanup

2021-05-31 Thread David Gibson
On Mon, May 31, 2021 at 04:21:11PM -0300, Lucas Mateus Martins Araujo e Castro wrote: > Hi everyone, > > I'm working on cleaning up some of the changes to enable the disable-tcg > option on PPC, right now focusing on target/ppc/excp_helper.c and > target/ppc/mmu_helper.c as these files have funct

Re: HSS Issue with GCC 10, Qemu Setup for microchip-icicle-kit

2021-05-31 Thread Rahul Pathak
Hi BIn,Alistair, I was passing the hss.elf file and it was strange that gdb after connecting was not letting the target to continue from gdb. what worked was to not pass anything and then connect the to target then load the symbol file as hss.elf. I followed the steps from the "Attaching the GDB"

Re: HSS Issue with GCC 10, Qemu Setup for microchip-icicle-kit

2021-05-31 Thread Bin Meng
Hi Rahul, On Mon, May 31, 2021 at 10:43 PM Rahul Pathak wrote: > > On top of that, it seems I cannot connect with the target using gdb > > (gdb) target remote :1234 > Remote debugging using :1234 > bfd requires flen 8, but target has flen 0 > > Though the ABI is lp64 and ISA is rv64imac when the

[PATCH] hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds

2021-05-31 Thread Peter Xu
These two commands are missing when adding the QMP sister commands. Add them, so developers can play with them easier. Cc: Dr. David Alan Gilbert Cc: Juan Quintela Cc: Leonardo Bras Soares Passos Cc: Chuan Zheng Cc: huang...@chinatelecom.cn Signed-off-by: Peter Xu --- PS: I really doubt whet

Re: HSS Issue with GCC 10, Qemu Setup for microchip-icicle-kit

2021-05-31 Thread Alistair Francis
On Tue, Jun 1, 2021 at 12:43 AM Rahul Pathak wrote: > > On top of that, it seems I cannot connect with the target using gdb > > (gdb) target remote :1234 > Remote debugging using :1234 > bfd requires flen 8, but target has flen 0 > > Though the ABI is lp64 and ISA is rv64imac when the hss was buil

Re: HSS Issue with GCC 10, Qemu Setup for microchip-icicle-kit

2021-05-31 Thread Alistair Francis
On Tue, Jun 1, 2021 at 12:06 AM Rahul Pathak wrote: > > I followed the same link. I will elaborate what is happening at my end - > > First - > Used the same versions as per the doc. Built HSS 2020.12 and used > core-image-minimal-dev-icicle-kit-es-sd-20201009141623.rootfs.wic. > Upon executing th

[PATCH v2] docs/devel: Explain in more detail the TB chaining mechanisms

2021-05-31 Thread Luis Pires
Signed-off-by: Luis Pires --- v2: - s/outer execution loop/main loop - Mention re-evaluation of cpu_exec_interrupt() - Changed wording on lookup_and_goto_ptr() - Added more details to step 2 of goto+tb + exit_tb - Added details about when goto_tb + exit_tb cannot be used docs/devel/tcg.rst

Re: [PATCH 2/3] hw/nvme/ctrl: fix endian conversion for nsid in ctrl list

2021-05-31 Thread Klaus Jensen
On May 17 15:37, Gollu Appalanaidu wrote: In Identify Ctrl List of the CNS 0x12 and 0x13 no endian conversion for the nsid field. Signed-off-by: Gollu Appalanaidu --- hw/nvme/ctrl.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index d

Re: [PATCH] tests/vm/freebsd: Increase code coverage

2021-05-31 Thread Wainer dos Santos Moschetta
Hi, On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote: Install more dependencies to increase code coverage. Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/freebsd | 5 + 1 file changed, 5 insertions(+) With or without this patch I got an error when `make vm-build-freebsd`. It fail

Re: [PATCH 1/3] hw/nvme/ctrl: add controller list cns 0x13

2021-05-31 Thread Klaus Jensen
On May 17 15:37, Gollu Appalanaidu wrote: Add the controller identifiers list available in NVM Subsystem that may or may not be attached to namespaces. Signed-off-by: Gollu Appalanaidu --- hw/nvme/ctrl.c | 25 +++-- hw/nvme/trace-events | 2 +- include/block/nvme.h | 1

Re: [PATCH v2] hw/nvme/ctrl: fix csi field for cns 0x00 and 0x11

2021-05-31 Thread Klaus Jensen
On Apr 27 12:00, Gollu Appalanaidu wrote: As per the TP 4056d Namespace types CNS 0x00 and CNS 0x11 CSI field shouldn't use but it is being used for these two Identify command CNS values, fix that. Remove 'nvme_csi_has_nvm_support()' helper as suggested by Klaus we can safely assume NVM command

Re: [PATCH 0/2] [RESEND] SEV firmware error list touchups

2021-05-31 Thread Eduardo Habkost
On Fri, Apr 30, 2021 at 08:48:28AM -0500, Connor Kuehl wrote: > Connor Kuehl (2): > sev: use explicit indices for mapping firmware error codes to strings > sev: add missing firmware error conditions > > target/i386/sev.c | 48 --- > 1 file changed,

Re: [PATCH v3] target/i386/sev: add support to query the attestation report

2021-05-31 Thread Eduardo Habkost
On Thu, Apr 29, 2021 at 12:07:28PM -0500, Brijesh Singh wrote: > The SEV FW >= 0.23 added a new command that can be used to query the > attestation report containing the SHA-256 digest of the guest memory > and VMSA encrypted with the LAUNCH_UPDATE and sign it with the PEK. > > Note, we already ha

Re: [PATCH v3 3/5] blkdebug: track all actions

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
17.05.2021 17:50, Emanuele Giuseppe Esposito wrote: Add a counter for each action that a rule can trigger. This is mainly used to keep track of how many coroutine_yield() we need to perform after processing all rules in the list. Co-developed-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Es

Re: [PATCH v3 2/5] blkdebug: move post-resume handling to resume_req_by_tag

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
17.05.2021 17:50, Emanuele Giuseppe Esposito wrote: We want to move qemu_coroutine_yield() after the loop on rules, because QLIST_FOREACH_SAFE is wrong if the rule list is modified while the coroutine has yielded. Therefore move the suspended request to the heap and clean it up from the remove s

Re: [PATCH v3 1/5] blkdebug: refactor removal of a suspended request

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
17.05.2021 17:50, Emanuele Giuseppe Esposito wrote: Extract to a separate function. Do not rely on FOREACH_SAFE, which is only "safe" if the *current* node is removed---not if another node is removed. Instead, just walk the entire list from the beginning when asked to resume all suspended reque

Re: [PATCH] hw/nvme: add param to control auto zone transitioning to zone state closed

2021-05-31 Thread Klaus Jensen
On May 31 15:42, Niklas Cassel wrote: On Fri, May 28, 2021 at 01:22:38PM +0200, Klaus Jensen wrote: On May 28 11:05, Niklas Cassel wrote: > From: Niklas Cassel > > In the Zoned Namespace Command Set Specification, chapter > 2.5.1 Managing resources > > "The controller may transition zones in th

Re: [PATCH] tests: Boot and halt a Linux guest on the Raspberry Pi 2 machine

2021-05-31 Thread Wainer dos Santos Moschetta
On 5/31/21 8:38 AM, Philippe Mathieu-Daudé wrote: Add a test booting and quickly shutdown a raspi2 machine, to test the power management model: (1/1) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd: console: [0.00] Booting Linux on physical CPU 0x

[target/ppc] excp_helper.c and mmu_helper.c cleanup

2021-05-31 Thread Lucas Mateus Martins Araujo e Castro
Hi everyone, I'm working on cleaning up some of the changes to enable the disable-tcg option on PPC, right now focusing on target/ppc/excp_helper.c and target/ppc/mmu_helper.c as these files have functions that are needed in a !TCG build but also contains code that doesn't compile in a !TCG b

Re: [PATCH v6 08/26] tcg: Build ffi data structures for helpers

2021-05-31 Thread Philippe Mathieu-Daudé
Hi Richard, On 5/3/21 1:57 AM, Richard Henderson wrote: > Add libffi as a build requirement for TCI. > Add libffi to the dockerfiles to satisfy that requirement. > > Construct an ffi_cif structure for each unique typemask. > Record the result in a separate hash table for later lookup; > this allo

[Bug 1905444] Re: [OSS-Fuzz] Issue 27796 in oss-fuzz: qemu:qemu-fuzz-i386-target-generic-fuzz-xhci: Stack-overflow in address_space_stl_internal

2021-05-31 Thread Thomas Huth
As mentioned by Alexander here: https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg08637.html this has likely been fixed by this commit here: https://gitlab.com/qemu-project/qemu/-/commit/3c6151cd11ae7e4a7dae10f8c17ab1fe2f0a73bf ... thus I'm marking this as fixed now. If it occurs again, plea

Re: [PATCH 02/11] target/ppc: moved ppc_store_sdr1 to cpu.c

2021-05-31 Thread Bruno Piazera Larsen
On 13/05/2021 00:50, David Gibson wrote: On Wed, May 12, 2021 at 11:08:04AM -0300, Bruno Larsen (billionai) wrote: Moved this function that is required in !TCG cases into a common code file The reasons it's needed by !TCG are kind of bogus, related to weirdness in the way KVM PR works. But it

Re: [PATCH v3 2/4] HMP: added info cpustats to removed_features.rst

2021-05-31 Thread Bruno Piazera Larsen
On 31/05/2021 11:56, Bruno Larsen (billionai) wrote: Documented the removal of the HMP command info cpustats Signed-off-by: Bruno Larsen (billionai) Oops, I seem to have dropped a few tags: Reviewed-by: Luis Pires Reviewed-by: Lucas Mateus Reviewed-by: Greg Kurz --- docs/system/removed-

Re: GSoC 2021: Request for WIKI account to update project details

2021-05-31 Thread Niteesh G. S.
Hello Stefan, Thank you. On Mon, May 31, 2021 at 8:00 PM Stefan Hajnoczi wrote: > On Thu, May 27, 2021 at 12:35:48AM +0530, Niteesh G. S. wrote: > > I kindly request the admin to grant me access to the wiki through the > below > > credentials > > Hi Niteesh, > I have created an account for you

RE: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU

2021-05-31 Thread Luis Fernando Fujita Pires
From: Bruno Larsen (billionai) > This feature will no longer be useful as ppc moves to using decotree for TCG. > And building with it enabled is no longer possible, due to changes in > opc_handler_t. Since the last commit that mentions it happened in 2014, I > think > it is safe to remove it. >

RE: [PATCH v3 3/4] target/ppc: removed GEN_OPCODE decision tree

2021-05-31 Thread Luis Fernando Fujita Pires
From: Bruno Larsen (billionai) > .opc1 = op1, > \ > @@ -1353,7 +1352,6 @@ typedef struct opcode_t { > .type = _typ, > \ > .type2 = _typ2,

Re: [PATCH v2 00/33] block: publish backup-top filter

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2021 20:11, Max Reitz wrote: On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: Hi all! v2: 01-02: new 03: don't bother with supporting empty child: we should never have such at this point 05: add comment 06: keep checking conflict with global add realized_set_allowed to qde

Re: [PATCH v2 19/33] block/copy-before-write: initialize block-copy bitmap

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: We are going to publish copy-before-write filter to be used in separate of backup. Future step would support bitmap for the filter. But let's start from full set bitmap. We have to modify backup, as bitmap is first initialized by copy-before

[PATCH v1 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-05-31 Thread huangy81
From: Hyman Huang(黄勇) use dirty ring feature to implement dirtyrate calculation. to enable it, set vcpu option as true in qmp calc-dirty-rate. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 146 ++--- migration/trace-events | 1 + 2 files chan

Re: [PATCH v2 00/33] block: publish backup-top filter

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: Hi all! v2: 01-02: new 03: don't bother with supporting empty child: we should never have such at this point 05: add comment 06: keep checking conflict with global add realized_set_allowed to qdev_prop_drive_iothread 07: improve cb

[PATCH v1 2/6] KVM: introduce dirty_pages into CPUState

2021-05-31 Thread huangy81
From: Hyman Huang(黄勇) dirty_pages is used to calculate dirtyrate via dirty ring, when enabled, kvm-reaper will increase the dirty pages after gfns being dirtied. Signed-off-by: Hyman Huang(黄勇) --- accel/kvm/kvm-all.c | 6 ++ include/hw/core/cpu.h | 2 ++ 2 files changed, 8 insertions(+)

[PATCH v1 4/6] migration/dirtyrate: adjust struct DirtyRateStat

2021-05-31 Thread huangy81
From: Hyman Huang(黄勇) use union to store stat data of two mutual exclusive methods. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 32 migration/dirtyrate.h | 18 +++--- 2 files changed, 35 insertions(+), 15 deletions(-) diff --git a/mi

[PATCH v1 5/6] migration/dirtyrate: check support of calculation for vcpu

2021-05-31 Thread huangy81
From: Hyman Huang(黄勇) vcpu method only works when kvm dirty ring is enabled, use kvm_dirty_ring_enabled to probe if dirty ring is enabled. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/migration/dirtyrate.c b/migration/

[PATCH v1 1/6] KVM: add kvm_dirty_ring_enabled function

2021-05-31 Thread huangy81
From: Hyman Huang(黄勇) introduce kvm_dirty_ring_enabled to show if kvm-reaper is working. dirtyrate thread could use it to check if calculation can base on dirty ring feature. Signed-off-by: Hyman Huang(黄勇) --- accel/kvm/kvm-all.c | 5 + include/sysemu/kvm.h | 1 + 2 files changed, 6 inser

[PATCH v1 3/6] migration/dirtyrate: add vcpu option for qmp calc-dirty-rate

2021-05-31 Thread huangy81
From: Hyman Huang(黄勇) calculate dirtyrate for each vcpu if vcpu is true, add the dirtyrate of each vcpu to the return value also. Signed-off-by: Hyman Huang(黄勇) --- migration/dirtyrate.c | 5 - migration/dirtyrate.h | 1 + qapi/migration.json | 28 ++-- 3 files

Re: [PATCH v2 18/33] block/copy-before-write: cbw_init(): use options

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: One more step closer to .bdrv_open(): use options instead of plain arguments. Move to bdrv_open_child() calls, native for drive open handlers. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 40

[PATCH v1 0/6] support dirtyrate at the granualrity of vcpu

2021-05-31 Thread huangy81
From: Hyman Huang(黄勇) Since the Dirty Ring on QEMU part has been merged recently, how to use this feature is under consideration. In the scene of migration, it is valuable to provide a more accurante interface to track dirty memory than existing one, so that the upper layer application can make

Re: [PATCH v2 15/33] block/copy-before-write: introduce cbw_init()

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: Move part of bdrv_cbw_append() to new function cbw_open(). It's an intermediate step for adding noramal .bdrv_open() handler to the Didn’t notice this in v1, but: *normal Max filter. With this commit no logic is changed, but we have a fu

Re: [PATCH] oslib-posix: Remove OpenBSD workaround for fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure

2021-05-31 Thread Paolo Bonzini
On 01/04/21 19:34, Brad Smith wrote: OpenBSD prior to 6.3 required a workaround to utilize fcntl(F_SETFL) on memory devices. Since modern verions of OpenBSD that are only officialy supported and buildable on do not have this issue I am garbage collecting this workaround. Signed-off-by: Brad Sm

Re: [PATCH v2 14/33] block/copy-before-write: bdrv_cbw_append(): replace child at last

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: Refactor the function to replace child at last. Thus we don't need to revert it and code is simplified. block-copy state initilization being done before replacing the child still *initialization Max doesn't need any drained section. Si

Re: [PATCH v2 5/5] block: improve permission conflict error message

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2021 19:35, Kevin Wolf wrote: Am 31.05.2021 um 18:18 hat Vladimir Sementsov-Ogievskiy geschrieben: 31.05.2021 19:07, Kevin Wolf wrote: Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: Now permissions are updated as follows: 1. do graph modifications ignoring permis

Re: [PATCH v2 2/6] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-05-31 Thread Paolo Bonzini
On 31/05/21 15:59, Kevin Wolf wrote: Apparently the motivation for Maxim's patch was, if I'm reading the description correctly, that it affected non-sg cases by imposing unnecessary restrictions. I see that patch 1 changed the max_iov part so that it won't affect non-sg cases any more, but max_tr

Re: [PATCH v2 5/5] block: improve permission conflict error message

2021-05-31 Thread Kevin Wolf
Am 31.05.2021 um 18:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > 31.05.2021 19:07, Kevin Wolf wrote: > > Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Now permissions are updated as follows: > > > 1. do graph modifications ignoring permissions > > > 2. do perm

Re: [PATCH v2 13/33] block/copy-before-write: use file child instead of backing

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: We are going to publish copy-before-write filter, and there no public backing-child-based filter in Qemu. No reason to create a precedent, so let's refactor copy-before-write filter instead. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [PATCH v2 4/5] block: simplify bdrv_child_user_desc()

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2021 18:50, Kevin Wolf wrote: Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: All existing parent types (block nodes, block devices, jobs) has the realization. So, drop unreachable code. Signed-off-by: Vladimir Sementsov-Ogievskiy Your fixes the other days showed t

Re: [PATCH v2 12/33] block/copy-before-write: drop extra bdrv_unref on failure path

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: bdrv_attach_child() do bdrv_unref() on failure, so we shouldn't do it by hand here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Max Reitz

Re: [PATCH v2 5/5] block: improve permission conflict error message

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2021 19:07, Kevin Wolf wrote: Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: Now permissions are updated as follows: 1. do graph modifications ignoring permissions 2. do permission update (of course, we rollback [1] if [2] fails) So, on stage [2] we can't say

Re: [PATCH v2 2/5] block-backend: improve blk_root_get_parent_desc()

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2021 18:45, Kevin Wolf wrote: Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: We have different types of parents: block nodes, block backends and jobs. So, it makes sense to specify type together with name. While being here also use g_autofree. iotest 307 output is u

Re: [PATCH v2 07/33] block: rename backup-top to copy-before-write

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: We are going to convert backup_top to full featured public filter, which can be used in separate of backup job. Start from renaming from "how it used" to "what it does". While updating comments in 283 iotest, drop and rephrase also things ab

Re: [PATCH v2 5/5] block: improve permission conflict error message

2021-05-31 Thread Kevin Wolf
Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > Now permissions are updated as follows: > 1. do graph modifications ignoring permissions > 2. do permission update > > (of course, we rollback [1] if [2] fails) > > So, on stage [2] we can't say which users are "old" and wh

Re: [PATCH v2 06/33] qdev: allow setting drive property for realized device

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: We need an ability to insert filters above top block node, attached to block device. It can't be achieved with blockdev-reopen command. So, we want do it with help of qom-set. Intended usage: Assume there is a node A that is attached to som

Re: [PATCH v2 05/33] qdev-properties: PropertyInfo: add realized_set_allowed field

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: Add field, so property can declare support for setting the property when device is realized. To be used in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/hw/qdev-properties.h | 1 + hw/core/qdev-properties.

Re: [PATCH v2 4/5] block: simplify bdrv_child_user_desc()

2021-05-31 Thread Kevin Wolf
Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > All existing parent types (block nodes, block devices, jobs) has the > realization. So, drop unreachable code. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Your fixes the other days showed that vvfat has a BdrvChildClass,

Re: [PATCH v2 2/5] block-backend: improve blk_root_get_parent_desc()

2021-05-31 Thread Kevin Wolf
Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > We have different types of parents: block nodes, block backends and > jobs. So, it makes sense to specify type together with name. > > While being here also use g_autofree. > > iotest 307 output is updated. > > Signed-off-by:

Re: [PATCH] hw/nvme: add param to control auto zone transitioning to zone state closed

2021-05-31 Thread Niklas Cassel
On Fri, May 28, 2021 at 01:22:38PM +0200, Klaus Jensen wrote: > On May 28 11:05, Niklas Cassel wrote: > > From: Niklas Cassel > > > > In the Zoned Namespace Command Set Specification, chapter > > 2.5.1 Managing resources > > > > "The controller may transition zones in the ZSIO:Implicitly Opened

Re: [PULL 2/3] hw/usb: hcd-xhci-pci: Raise MSI/MSI-X interrupts only when told to

2021-05-31 Thread Alexander Bulekov
On 210528 1622, Gerd Hoffmann wrote: > From: Ruimei Yan > > At present MSI / MSI-X interrupts are triggered regardless of the > irq level. We should have checked the level to determine whether > the interrupt needs to be delivered. > > The level check logic was present in early versions of the x

[PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU

2021-05-31 Thread Bruno Larsen (billionai)
This feature will no longer be useful as ppc moves to using decotree for TCG. And building with it enabled is no longer possible, due to changes in opc_handler_t. Since the last commit that mentions it happened in 2014, I think it is safe to remove it. Signed-off-by: Bruno Larsen (billionai) ---

[PATCH v3 3/4] target/ppc: removed GEN_OPCODE decision tree

2021-05-31 Thread Bruno Larsen (billionai)
since both, PPC_DO_STATISTICS and PPC_DUMP_CPU, are obsoleted as target/ppc moves to decodetree, we can remove this ifdef based decision tree, and only have what is now the standard option for the macro. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/translate.c | 79

[PATCH v3 2/4] HMP: added info cpustats to removed_features.rst

2021-05-31 Thread Bruno Larsen (billionai)
Documented the removal of the HMP command info cpustats Signed-off-by: Bruno Larsen (billionai) --- docs/system/removed-features.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst index 5a462ac568..2feae41089 100644 --

[PATCH v3 1/4] hw/core/cpu: removed cpu_dump_statistics function

2021-05-31 Thread Bruno Larsen (billionai)
No more architectures set the pointer to dump_statistics, so there's no point in keeping it, or the related cpu_dump_statistics function. Suggested-by: Richard Henderson Signed-off-by: Bruno Larsen (billionai) Message-Id: <20210526202104.127910-6-bruno.lar...@eldorado.org.br> Reviewed-by: Richar

[PATCH v3 0/4] target/ppc: Remove DO_PPC_STATISTICS and PPC_DUMP_CPU

2021-05-31 Thread Bruno Larsen (billionai)
These 2 defines are being obsoleted as we move to decodetree, so they were removed. Also, upon further inspection, qemu already doesn't build with them enabled, and probably hasn't for a while, and no one complained, so I don't think they were actually being used. Based-on: dgibson's ppc-for-6.1

Re: [PATCH v2 0/3] block: drop BlockDriverState::read_only

2021-05-31 Thread Kevin Wolf
Am 27.05.2021 um 17:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > The field duplicates information in .open_flags. We have to carefully > sync these two fields everywhere. It's simple to introduce a bug by > forgetting it. > > Let's drop the field, and fix users to call bdrv_is_r

Re: HSS Issue with GCC 10, Qemu Setup for microchip-icicle-kit

2021-05-31 Thread Rahul Pathak
On top of that, it seems I cannot connect with the target using gdb (gdb) target remote :1234 Remote debugging using :1234 bfd requires flen 8, but target has flen 0 Though the ABI is lp64 and ISA is rv64imac when the hss was built. On Mon, May 31, 2021 at 7:37 PM Rahul Pathak wrote: > I follo

Re: GSoC 2021: Request for WIKI account to update project details

2021-05-31 Thread Stefan Hajnoczi
On Thu, May 27, 2021 at 12:35:48AM +0530, Niteesh G. S. wrote: > I kindly request the admin to grant me access to the wiki through the below > credentials Hi Niteesh, I have created an account for you and sent you the details privately. Stefan signature.asc Description: PGP signature

Re: [PATCH 2/5] target/ppc: remove ppc_cpu_dump_statistics

2021-05-31 Thread Bruno Piazera Larsen
On 29/05/2021 02:47, David Gibson wrote: On Thu, May 27, 2021 at 08:01:56AM +0200, Greg Kurz wrote: On Wed, 26 May 2021 17:21:01 -0300 "Bruno Larsen (billionai)" wrote: This function requires surce code modification to be useful, which means s/surce/source it probably is not used often, a

Re: [PATCH v2 4/5] progressmeter: protect with a mutex

2021-05-31 Thread Stefan Hajnoczi
On Tue, May 18, 2021 at 12:14:17PM +0200, Emanuele Giuseppe Esposito wrote: > On 18/05/2021 12:00, Vladimir Sementsov-Ogievskiy wrote: > > 18.05.2021 12:40, Emanuele Giuseppe Esposito wrote: > > > Progressmeter is protected by the AioContext mutex, which > > > is taken by the block jobs and their c

Re: [PATCH v2 03/33] block: introduce bdrv_replace_child_bs()

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: Add function to transactionally replace bs inside BdrvChild. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 2 ++ block.c | 31 +++ 2 files changed, 33 insertions(+)

Re: HSS Issue with GCC 10, Qemu Setup for microchip-icicle-kit

2021-05-31 Thread Rahul Pathak
I followed the same link. I will elaborate what is happening at my end - *First* - Used the same versions as per the doc. Built HSS 2020.12 and used core-image-minimal-dev-icicle-kit-es-sd-20201009141623.rootfs.wic. Upon executing the qemu launch command as per the doc, it's just waits for the con

Re: [PATCH v2 2/6] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

2021-05-31 Thread Kevin Wolf
Am 27.05.2021 um 22:14 hat Paolo Bonzini geschrieben: > On 27/05/21 17:51, Kevin Wolf wrote: > > Am 24.05.2021 um 18:36 hat Paolo Bonzini geschrieben: > > > bs->sg is only true for character devices, but block devices can also > > > be used with scsi-block and scsi-generic. Unfortunately BLKSECTGE

Re: [RFC PATCH] block/vpc: Support probing of fixed-size VHD images

2021-05-31 Thread Max Reitz
On 19.05.21 12:19, Thomas Huth wrote: On 29/03/2021 09.25, Thomas Huth wrote: Fixed-size VHD images don't have a header, only a footer. To be able to still detect them right, support probing via the file name, too. Without this change, images get detected as raw: $ qemu-img create -f vpc -o su

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-31 Thread BALATON Zoltan
On Sun, 30 May 2021, BALATON Zoltan wrote: On Thu, 20 May 2021, Alexey Kardashevskiy wrote: diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c new file mode 100644 index ..a283b7d251a7 --- /dev/null +++ b/hw/ppc/vof.c @@ -0,0 +1,1021 @@ +/* + * QEMU PowerPC Virtual Open Firmware. + * + * This

Re: [PATCH v2 02/33] block: comment graph-modifying function not updating permissions

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Max Reitz

Re: [PATCH v2 01/33] block: rename bdrv_replace_child to bdrv_replace_child_tran

2021-05-31 Thread Max Reitz
On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote: We have bdrv_replace_child() wrapper on bdrv_replace_child_noperm(). But bdrv_replace_child() doesn't update permissions. It's rather strange, as normally it's expected that foo() should call foo_noperm() and update permissions. Let's rename

[PATCH v8] qapi: introduce 'query-kvm-cpuid' action

2021-05-31 Thread Valeriy Vdovin
Introducing new qapi method 'query-kvm-cpuid'. This method can be used to get virtualized cpu model info generated by QEMU during VM initialization in the form of cpuid representation. Diving into more details about virtual cpu generation: QEMU first parses '-cpu' command line option. From there i

Re: [PATCH v7 1/1] qapi: introduce 'query-cpu-model-cpuid' action

2021-05-31 Thread Valeriy Vdovin
On Wed, May 26, 2021 at 05:44:24PM -0400, Eduardo Habkost wrote: > On Tue, May 04, 2021 at 03:26:39PM +0300, Valeriy Vdovin wrote: > > Introducing new qapi method 'query-cpu-model-cpuid'. This method can be > > used to > > get virtualized cpu model info generated by QEMU during VM initialization i

Re: [PATCH v4 0/8] IOMMU: Add support for IOMMU Bypass Feature

2021-05-31 Thread Xingang Wang
Hi everyone, Do you have any suggestions for this series of patches. The modifications affects many modules, including new command line, PCI modules and ACPI firmware tables. There's modification in IORT DMAR and IVRS, both for arm and x86 platform. I am not sure whether the modification is app

[PATCH] tests: Boot and halt a Linux guest on the Raspberry Pi 2 machine

2021-05-31 Thread Philippe Mathieu-Daudé
Add a test booting and quickly shutdown a raspi2 machine, to test the power management model: (1/1) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_raspi2_initrd: console: [0.00] Booting Linux on physical CPU 0xf00 console: [0.00] Linux version 4.14.98-v7+

Re: [PATCH qemu] Add basic power management to raspi.

2021-05-31 Thread Philippe Mathieu-Daudé
Hi Nolan, Thanks for your patch! There is something odd with your email address, which apparently became source...@sigbus.net instead of no...@sigbus.net. On 5/18/21 10:24 PM, ~nolanl wrote: > From: Nolan Leake > > This is just enough to make reboot and poweroff work. Please precise "for Linu

[RFC PATCH] hw/display/virtio-gpu: Fix memory leak (CID 1453811)

2021-05-31 Thread Philippe Mathieu-Daudé
To avoid leaking memory on the error path, reorder the code as: - check the parameters first - check resource already existing - finally allocate memory Reported-by: Coverity (CID 1453811: RESOURCE_LEAK) Fixes: e0933d91b1c ("virtio-gpu: Add virtio_gpu_resource_create_blob") Signed-off-by: Philippe

Re: [PATCH] qobject: Fix maybe uninitialized in qdict_array_split

2021-05-31 Thread Janosch Frank
On 5/31/21 11:44 AM, Philippe Mathieu-Daudé wrote: > On 5/31/21 11:21 AM, Janosch Frank wrote: >> On 5/18/21 3:06 PM, Janosch Frank wrote: >>> Lets make the compiler happy. >>> >>> Signed-off-by: Janosch Frank >> >> Ping >> My build is still breaking on Ubuntu because of this. >> >>> --- >>> qobj

  1   2   >