On Mon, May 31, 2021 at 04:21:11PM -0300, Lucas Mateus Martins Araujo e Castro wrote: > Hi everyone, > > I'm working on cleaning up some of the changes to enable the disable-tcg > option on PPC, right now focusing on target/ppc/excp_helper.c and > target/ppc/mmu_helper.c as these files have functions that are needed in a > !TCG build but also contains code that doesn't compile in a !TCG build, and > currently that is dealt with #ifdef. > > For excp_helper.c I moved all exception handling functions to a new file > (named target/ppc/excp_handler.c for now) and left only the helpers in it, > and changed meson.build to always compile the new file and only compile the > file with the helpers in a build with TCG.
That sounds reasonable.
> For mmu_helper.c the idea is to move all the code inside #ifdef CONFIG_TCG
> to another file that shouldn't be compiled in a !TCG build. But these
> changes are based on Richard Henderson's patch, so it depends if they'll be
> applied as is or there will be another version.
Ok.
> Also I'm looking into the possibility of not compiling
> ppc_tlb_invalidate_all in mmu_helper.c, but that's only possible if this
> function is not used in a !TCG build, does anyone know if this function is
> used in some corner case when running with KVM?
I'm pretty sure if ppc_tlb_invalidate_all() was ever called with KVM
that would be a bug, so that sounds sensible.
> Any opinion on these changes?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
