[PATCH] util/cacheflush: Fix error generated by clang

When compiling qemu-fuzz-i386 on aarch64 host, clang reported the following error: ../util/cacheflush.c:38:44: error: value size does not match register size specified by the constraint and modifier [-Werror,-Wasm-operand-widths] asm volatile("mrs\t%0, ctr_el0" : "=r"(save_ctr_el0));

[PATCH] qtest/npcm7xx_pwm-test: Fix memleak in pwm_qom_get

The pwm_qom_get function didn't free "response", which caused an indirect memory leak. So use qobject_unref() to fix it. ASAN shows memory leak stack: Indirect leak of 7416 byte(s) in 18000 object(s) allocated from: #0 0x7f96e2f79d4e in __interceptor_calloc (/lib64/libasan.so.5+0x112d4e)

[Bug 1907042] Re: assert issue locates in hw/usb/core.c:727: usb_ep_get: Assertion `pid == USB_TOKEN_IN || pid == USB_TOKEN_OUT' failed

I trigger the usb_ep_get assertion as well, but I think is't not a bug.(I use the ehci) Maybe the logic is the function return ep_ctl whith USB_TOKEN_SETUP and ep==0.Otherwise, will goto the next. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

Re: [RFC PATCH v3 0/6] eBPF RSS support for virtio-net

On 2021/1/15 上午5:16, Andrew Melnychenko wrote: This set of patches introduces the usage of eBPF for packet steering and RSS hash calculation: * RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash * Additionally adding support for the us

Re: [RFC PATCH v3 6/6] docs: Added eBPF documentation.

On 2021/1/15 上午5:16, Andrew Melnychenko wrote: From: Andrew Also, added maintainers information. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- MAINTAINERS | 8 +++ docs/ebpf_rss.rst | 125 ++ 2 files changed, 1

Re: [RFC PATCH v3 5/6] virtio-net: Added eBPF RSS to virtio-net.

On 2021/1/15 上午5:16, Andrew Melnychenko wrote: From: Andrew When RSS is enabled the device tries to load the eBPF program to select RX virtqueue in the TUN. If eBPF can be loaded the RSS will function also with vhost (works with kernel 5.8 and later). Software RSS is used as a fallback with v

Re: [PATCH] hw/block/nvme: conditionally enable DULBE for zoned namespaces

On Jan 14 15:39, Keith Busch wrote: > On Mon, Jan 11, 2021 at 07:09:52PM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > The device uses the BDRV_BLOCK_ZERO flag to determine the "deallocated" > > status of logical blocks. Since the zoned namespaces command set > > specification defines

Re: [PATCH] hw/block/nvme: fix for non-msix machines

On Jan 12 14:20, Philippe Mathieu-Daudé wrote: > On 1/12/21 1:47 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() > > return value") had the unintended effect of breaking support on > > several platforms not supporting MS

Re: [PATCH 07/23] sdlaudio: replace legacy functions with modern ones

On 10/01/2021 11.02, Volker Rümelin wrote: With the modern audio functions it's possible to add new features like audio recording. As a side effect this patch fixes a bug where SDL2 can't be used on Windows. This bug was reported on the qemu-devel mailing list at https://lists.nongnu.org/archiv

Re: [RFC PATCH v3 4/6] ebpf: Added eBPF RSS loader.

On 2021/1/15 上午5:16, Andrew Melnychenko wrote: From: Andrew Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By default, eBPF feature enabled if libbpf is present in the build system. libbpf checked in configuration

[PATCH] plugin: foo * bar should be foo *bar

recently I a code style problem while using checkpatch.pl tool,please review. foo * bar should be foo *bar: Signed-off-by: Haoyu Chai --- plugins/api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/api.c b/plugins/api.c index bbdc5a4eb4..9661824b89 100644 --- a/plu

Re: [PATCH 05/23] sdlaudio: always clear the sample buffer

On 10/01/2021 11.02, Volker Rümelin wrote: Always fill the remaining audio callback buffer with silence. SDL 2.0 doesn't initialize the audio callback buffer. This was an incompatible change compared to SDL 1.2. For reference read the SDL 1.2 to 2.0 migration guide. Signed-off-by: Volker Rümelin

Re: [PATCH 04/23] sdlaudio: don't start playback in init routine

On 10/01/2021 11.02, Volker Rümelin wrote: Every emulated audio device has a way to enable audio playback. Don't start playback until the guest enables the audio device. This patch keeps the SDL2 device pause state in sync with hw->enabled. Signed-off-by: Volker Rümelin --- audio/sdlaudio.c |

Re: [PATCH] hw/block/nvme: fix zone write finalize

On Jan 14 15:03, Keith Busch wrote: > On Tue, Jan 12, 2021 at 10:42:35AM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > The zone write pointer is unconditionally advanced, even for write > > faults. Make sure that the zone is always transitioned to Full if the > > write pointer reaches

[PATCH v2 5/5] softmmu: code indent should never use tabs

This patch fixes error messages found by checkpatch.pl: code indent should never use tabs Signed-off-by: Haoyu Chai --- softmmu/physmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 43e37660c7..7aed899e3f 100644 --- a/softmmu/p

[PATCH v2 4/5] softmmu: "foo* bar" should be "foo *bar"

This patch fixes error messages found by checkpatch.pl: "foo* bar" should be "foo *bar" Signed-off-by: Haoyu Chai --- softmmu/globals.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/globals.c b/softmmu/globals.c index 7d0fc81183..341a7029ff 100644 --- a/softmmu/glo

[PATCH v2 2/5] softmmu: braces {} are needed for if statement

This patch fixes error messages found by checkpatch.pl: braces {} are needed for if statement Signed-off-by: Haoyu Chai --- softmmu/cpus.c | 6 -- softmmu/dma-helpers.c | 3 ++- softmmu/memory.c | 3 ++- softmmu/physmem.c | 15 ++- softmmu/qdev-monitor.c |

[PATCH v2 3/5] softmmu: don't use '#' flag of printf format ('%#') in format strings

This patch fixes error messages found by checkpatch.pl: don't use '#' flag of printf format ('%#') in format strings Signed-off-by: Haoyu Chai --- softmmu/device_tree.c | 2 +- softmmu/runstate.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/softmmu/device_tree.c b

[PATCH v2 1/5] softmmu: fix problems about spaces

This patch fixes error messages found by checkpatch.pl: fix problems about spaces: Signed-off-by: Haoyu Chai --- softmmu/bootdevice.c | 4 ++-- softmmu/memory.c | 16 softmmu/qdev-monitor.c | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/sof

[PATCH v2 0/5] softmmu: some space-style problems while coding

recently I found some code style problems while using checkpatch.pl tool,please review. Haoyu Chai (5): softmmu: add spaces around operator softmmu: braces {} are needed for if statement softmmu: don't use '#' flag of printf format ('%#') in format strings softmmu: "foo* bar" should be "foo *

Re: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands

Hi Bin, On Thu, Jan 14, 2021 at 6:08 PM Bin Meng wrote: > > Hi Francisco, > > On Fri, Jan 15, 2021 at 2:13 AM Francisco Iglesias > wrote: > > > > Hi Bin, > > > > On [2021 Jan 14] Thu 23:08:53, Bin Meng wrote: > > > From: Bin Meng > > > > > > The m25p80 model uses s->needed_bytes to indicate how

[PATCH v4 3/3] hw/blocl/nvme: trigger async event during injecting smart warning

During smart critical warning injection by setting property from QMP command, also try to trigger asynchronous event. Suggested by Keith, if a event has already been raised, there is no need to enqueue the duplicate event any more. Signed-off-by: zhenwei pi --- hw/block/nvme.c | 48 +++

[PATCH v4 0/3] support NVMe smart critial warning injection

v3 -> v4: - Drop "Fix overwritten bar.cap". (Already fixed) - Avoid to enqueue the duplicate event. - Several minor changes for coding style & function/variable name. v2 -> v3: - Introduce "Persistent Memory Region has become read-only or unreliable" - Fix overwritten bar.cap - Check smart c

[PATCH v4 2/3] hw/block/nvme: add smart_critical_warning property

There is a very low probability that hitting physical NVMe disk hardware critical warning case, it's hard to write & test a monitor agent service. For debugging purposes, add a new 'smart_critical_warning' property to emulate this situation. The orignal version of this change is implemented by ad

[PATCH v4 1/3] block/nvme: introduce bit 5 for critical warning

According to NVMe spec 1.4 section , introduce bit 5 for "Persistent Memory Region has become read-only or unreliable". Signed-off-by: zhenwei pi --- include/block/nvme.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/block/nvme.h b/include/block/nvme.h index 9494246f1f..0baf4b27cd

Re: [PATCH] hw/intc/loongson_liointc: Fix per core ISR handling

Reviewed-by: Huacai Chen On Tue, Jan 12, 2021 at 9:25 AM Jiaxun Yang wrote: > > Per core ISR is a set of 32-bit registers spaced by 8 bytes. > This patch fixed calculation of it's size and also added check > of alignment at reading & writing. > > Signed-off-by: Jiaxun Yang > --- > hw/intc/loon

[Bug 1911839] [NEW] [OSS-Fuzz] Issue 29586 e1000e: Memcpy-param-overlap in flatview_write_continue

Public bug reported: === Reproducer === cat << EOF | ./qemu-system-i386 -M q35 -accel qtest \ -qtest stdio -nographic -nodefaults -device \ e1000e,netdev=net0 -netdev user,id=net0 outl 0xcf8 0x8811 outl 0xcfc 0x5ac600 outl 0xcf8 0x8801 outl 0xcfc 0x2600 write 0x5ac60100 0x4 0x56000302

Re: [PATCH 10/11] qapi/commands: Simplify command registry generation

On 12/18/20 3:54 PM, Markus Armbruster wrote: QAPISchemaGenCommandVisitor.visit_command() needs to generate the marshalling function into the current module, and also generate its registration into the ./init system module. The latter is done somewhat awkwardly: .__init__() creates a QAPIGenCCod

Re: [PATCH v3 1/1] target-riscv: support QMP dump-guest-memory

On Thu, 14 Jan 2021 17:28:19 PST (-0800), jiangyi...@huawei.com wrote: Add the support needed for creating prstatus elf notes. Now elf notes only contains user_regs. This allows us to use QMP dump-guest-memory. "Now elf notes only contains user_regs" sounds a bit odd. Also, I usually see this

Re: [PATCH v3 18/19] i386: provide simple 'hv-default=on' option

On Thu, 7 Jan 2021 16:14:49 +0100 Vitaly Kuznetsov wrote: > Enabling Hyper-V emulation for a Windows VM is a tiring experience as it > requires listing all currently supported enlightenments ("hv-*" CPU > features) explicitly. We do have 'hv-passthrough' mode enabling > everything but it can't b

Re: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands

Hi Francisco, On Fri, Jan 15, 2021 at 2:13 AM Francisco Iglesias wrote: > > Hi Bin, > > On [2021 Jan 14] Thu 23:08:53, Bin Meng wrote: > > From: Bin Meng > > > > The m25p80 model uses s->needed_bytes to indicate how many follow-up > > bytes are expected to be received after it receives a command

Re: [PATCH 09/11] qapi/gen: Support for switching to another module temporarily

On 12/18/20 3:54 PM, Markus Armbruster wrote: +@contextmanager +def _temp_module(self, name: str) -> ContextManager[None]: Doesn't quite typecheck; we want Iterator[None] -- I think we're typing the function that is yet-to-be-decorated -- mypy will handle typing the resulting function

Re: [RFC 0/5] pc: support user provided NIC naming/indexing

On Wed, 13 Jan 2021 07:09:56 -0500 "Michael S. Tsirkin" wrote: > On Tue, Dec 22, 2020 at 06:39:29PM -0500, Igor Mammedov wrote: > > > > Series implements support for 'onboard' naming scheme for network > > interfaces (1), which is based on PCI firmware spec and lets user > > to explicitly specif

Re: [PATCH v2 0/7]Fix some style problems in audio

Patchew URL: https://patchew.org/QEMU/20210115012431.79533-1-zhangha...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210115012431.79533-1-zhangha...@huawei.com Subject: [PATCH v2 0/7]Fix some style prob

[PATCH v2 1/7] audio: Add braces for statements/fix braces' position

Fix problems about braces: -braces are necessary for all arms of if/for/while statements -else should follow close brace '}' Signed-off-by: Zhang Han --- audio/alsaaudio.c | 15 +-- audio/audio.c | 26 -- audio/audio_template.h | 12

[PATCH v2 5/7] audio: Don't use '%#' in format strings

Use '0x' prefix instead of '%#' Signed-off-by: Zhang Han --- audio/dsoundaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/dsoundaudio.c b/audio/dsoundaudio.c index 1891a38bee..f7a3351306 100644 --- a/audio/dsoundaudio.c +++ b/audio/dsoundaudio.c @@ -215,7 +215,7

[PATCH v2 3/7] audio: foo* bar" should be "foo *bar".

transfer "foo* " to "foo *" Signed-off-by: Zhang Han --- audio/coreaudio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 6ca0d79c1f..b7c02e0e51 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -421,12 +421,12

[PATCH v2 6/7] audio: Suspect code indent for conditional statements

Fix code indent. Signed-off-by: Zhang Han --- audio/paaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index b052084698..7ea9f637c2 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -437,7 +437,7 @@ static pa_stream *qpa_simple_new

[PATCH v2 7/7] audio: space prohibited between function name and parenthesis'('

Delete spaces between function name and open parenthesis'(' Signed-off-by: Zhang Han --- audio/audio_template.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index 6d42fa7011..05e793f61f 100644 --- a/audio/audio_t

[PATCH v2 4/7] audio: Fix lines over 90 characters

Fix the line width of code. Signed-off-by: Zhang Han --- audio/dsoundaudio.c | 37 +++-- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/audio/dsoundaudio.c b/audio/dsoundaudio.c index 38ae2471f6..1891a38bee 100644 --- a/audio/dsoundaudio.c +++ b/a

[PATCH v2 2/7] audio: Add spaces around operator/delete redundant spaces

Fix problems about spaces: -operator needs spaces around it, add them. -somespaces are redundant, remove them. Signed-off-by: Zhang Han --- audio/audio_template.h | 2 +- audio/coreaudio.c | 2 +- audio/dsoundaudio.c| 2 +- audio/jackaudio.c | 2 +- 4 files changed, 4 insertions(+)

[PATCH v2 0/7]Fix some style problems in audio

Some style problems in audio directory are found by checkpatch.pl. Fix these style problems. v2: - fix style problem: redundant spaces between function name and open parenthesis'(' - fix subject of patch[5/7] for email display Zhang Han (7): audio: Add braces for statements/fix braces' positio

RE: [PATCH v2 1/1] target-riscv: support QMP dump-guest-memory

> -Original Message- > From: Andrew Jones [mailto:drjo...@redhat.com] > Sent: Sunday, January 10, 2021 5:39 AM > To: Jiangyifei > Cc: qemu-devel@nongnu.org; qemu-ri...@nongnu.org; Zhanghailiang > ; sag...@eecs.berkeley.edu; > kbast...@mail.uni-paderborn.de; Zhangxiaofeng (F) > ; limingwa

[PATCH v3 0/1] target-riscv: support QMP dump-guest-memory

Hi, This patch supports QMP dump-guest-memory in RISC-V. We tested this feature by using following command: dump-guest-memory guest.memory. Then we used the gdb tool to debug guest.memory: gdb vmlinux guest.memory. The test result is as follow: 1. info registers ra 0xffe0008cb83c

[PATCH v3 1/1] target-riscv: support QMP dump-guest-memory

Add the support needed for creating prstatus elf notes. Now elf notes only contains user_regs. This allows us to use QMP dump-guest-memory. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li --- target/riscv/arch_dump.c | 202 +++ target/riscv/cpu.c

Re: [PULL 22/23] hw/riscv: Use the CPU to determine if 32-bit

On Sun, Jan 10, 2021 at 11:55 AM Peter Maydell wrote: > > On Fri, 18 Dec 2020 at 06:01, Alistair Francis > wrote: > > > > Instead of using string compares to determine if a RISC-V machine is > > using 32-bit or 64-bit CPUs we can use the initalised CPUs. This avoids > > us having to maintain a l

Re: [PATCH v1 1/7] spapr.h: fix trailing whitespace in phb_placement

On Thu, Jan 14, 2021 at 03:06:22PM -0300, Daniel Henrique Barboza wrote: > This whitespace was messing with lots of diffs if you happen > to use an editor that eliminates trailing whitespaces on file > save. > > Signed-off-by: Daniel Henrique Barboza Applied to ppc-for-6.0, thanks. > --- > inc

Re: [PATCH v1 4/7] spapr_rtas.c: fix identation of rtas_ibm_suspend_me() args

On Thu, Jan 14, 2021 at 03:06:25PM -0300, Daniel Henrique Barboza wrote: > Signed-off-by: Daniel Henrique Barboza Applied to ppc-for-6.0, thanks. > --- > hw/ppc/spapr_rtas.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c

Re: [PATCH v1 6/7] spapr.c: introduce spapr_core_unplug_possible()

On Thu, Jan 14, 2021 at 03:06:27PM -0300, Daniel Henrique Barboza wrote: > Next patch is going to add more conditions to allow a CPU core > hotunplug. Let's put it into a separated function to avoid crowding > the body of spapr_core_unplug_request(). > > Signed-off-by: Daniel Henrique Barboza LG

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

On Thu, Jan 14, 2021 at 03:06:28PM -0300, Daniel Henrique Barboza wrote: > The only restriction we have when unplugging CPUs is to forbid unplug of > the boot cpu core. spapr_core_unplug_possible() does not contemplate the > possibility of some cores being offlined by the guest, meaning that we're

Re: [PATCH v1 2/7] spapr_hcall.c: make do_client_architecture_support static

On Thu, Jan 14, 2021 at 03:06:23PM -0300, Daniel Henrique Barboza wrote: > The function is called only inside spapr_hcall.c. > > Signed-off-by: Daniel Henrique Barboza Nice catch - that's a hangover from an earlier version where it was called elswhere. Applied to ppc-for-6.0. > --- > hw/ppc/s

Re: [PATCH v1 5/7] spapr_cpu_core.c: use g_auto* in spapr_create_vcpu()

On Thu, Jan 14, 2021 at 03:06:26PM -0300, Daniel Henrique Barboza wrote: > Use g_autoptr() with Object and g_autofree with the string to > avoid the need of a cleanup path. > > Signed-off-by: Daniel Henrique Barboza Applied to ppc-for-6.0, thanks. > --- > hw/ppc/spapr_cpu_core.c | 12 +++--

Re: [PATCH v1 3/7] spapr_rtas.c: fix identation in rtas_ibm_nmi_interlock() string

On Thu, Jan 14, 2021 at 03:06:24PM -0300, Daniel Henrique Barboza wrote: > Signed-off-by: Daniel Henrique Barboza Nack. I believe the general consensus is that greppability for long error message strings is sufficient reason to break the normal coding style rules. > --- > hw/ppc/spapr_rtas.c |

[PATCH RFC 2/2] vhost-scsi: implement DeviceEvent

This patch implements DeviceEvent for vhost-scsi. As RFC, this patch only considers the case of eventfd and only for vhost-scsi. Below are example for HMP and QAPI. (qemu) device_event /machine/peripheral/vscsi0 kick 1 { "execute": "x-debug-device-event", "arguments": { "dev": "/machine/periph

[PATCH RFC 0/2] Add debug interface to kick/call on purpose

The virtio device/driver (e.g., vhost-scsi and indeed any device including e1000e) may hang due to the lost of IRQ or the lost of doorbell register kick, e.g., https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01711.html The virtio-net was in trouble in above link because the 'kick' was no

[PATCH RFC 1/2] qdev: add debug interface to kick/call eventfd

The virtio device/driver (e.g., vhost-scsi) may hang due to the lost of IRQ or the lost of doorbell register kick, e.g., https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01711.html This patch adds a new debug interface 'DeviceEvent' to DeviceClass to help narrow down if the issue is due t

Re: [RFC 4/5] pci: acpi: add _DSM method to PCI devices

On Wed, 13 Jan 2021 07:13:04 -0500 "Michael S. Tsirkin" wrote: > On Tue, Dec 22, 2020 at 06:39:33PM -0500, Igor Mammedov wrote: > > Implement _DSM according to: > > PCI Firmware Specification 3.1 > > 4.6.7. DSM for Naming a PCI or PCI Express Device Under > > Operating System

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

On Thu, Jan 14, 2021 at 10:24:57AM +0100, Christian Borntraeger wrote: > > > On 14.01.21 10:19, Christian Borntraeger wrote: > > > > > > On 14.01.21 10:10, Christian Borntraeger wrote: > >> > >> > >> On 14.01.21 00:58, David Gibson wrote: > >> [...] > >>> +int s390_pv_init(ConfidentialGuestSupp

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

On Thu, Jan 14, 2021 at 11:25:17AM +, Daniel P. Berrangé wrote: > On Wed, Jan 13, 2021 at 12:42:26PM +, Dr. David Alan Gilbert wrote: > > * Cornelia Huck (coh...@redhat.com) wrote: > > > On Tue, 5 Jan 2021 12:41:25 -0800 > > > Ram Pai wrote: > > > > > > > On Tue, Jan 05, 2021 at 11:56:14A

[Bug 1908450] Re: ide/core.c ATA Major Version reporting incorrect

I would just fix the comment for now, likewise I don't have the time to audit whether the emulation provides full coverage of the standard. Really there's two cases here 1) We report ATA4-7 (current status), someone discovers missing bits feature Response: They file a ticket on the missing featur

Re: [PATCH 1/6] hw/block/nvme: fix shutdown/reset logic

On Mon, Jan 11, 2021 at 01:32:18PM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > A shutdown is only about flushing stuff. It is the host that should > delete any queues, so do not perform a reset here. > > Also, on shutdown, make sure that the PMR is flushed if in use. > > Fixes: 368f4e75

[PATCH v2] machine: add missing doc for memory-backend option

Add documentation for '-machine memory-backend' CLI option and how to use it. And document that x-use-canonical-path-for-ramblock-id, is considered to be stable to make sure it won't go away by accident. Signed-off-by: Igor Mammedov --- v2: - add doc that x-use-canonical-path-for-ramblock-id is

Re: [PATCH] hw/block/nvme: conditionally enable DULBE for zoned namespaces

On Mon, Jan 11, 2021 at 07:09:52PM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > The device uses the BDRV_BLOCK_ZERO flag to determine the "deallocated" > status of logical blocks. Since the zoned namespaces command set > specification defines that logical blocks SHALL be marked as dealloca

[PATCH v5 0/6] Qemu SEV-ES guest support

From: Tom Lendacky This patch series provides support for launching an SEV-ES guest. Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See "AMD64 Architecture Programmer's Manual Volume 2: System Program

[Bug 1908450] Re: ide/core.c ATA Major Version reporting incorrect

That's probably the single most reasonable thing to do, truth be told! I don't have the time to audit these fields properly; I don't know which versions we truly ought to advertise support for. I know I looked at ATA8-AC3 at some point fairly recently and concluded that we don't support all of the

[PATCH v5 4/6] sev/i386: Don't allow a system reset under an SEV-ES guest

From: Tom Lendacky An SEV-ES guest does not allow register state to be altered once it has been measured. When an SEV-ES guest issues a reboot command, Qemu will reset the vCPU state and resume the guest. This will cause failures under SEV-ES. Prevent that from occuring by introducing an arch-spe

[PATCH v5 6/6] sev/i386: Enable an SEV-ES guest based on SEV policy

From: Tom Lendacky Update the sev_es_enabled() function return value to be based on the SEV policy that has been specified. SEV-ES is enabled if SEV is enabled and the SEV-ES policy bit is set in the policy object. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Reviewed-by: Dr. D

[PATCH v5 5/6] kvm/i386: Use a per-VM check for SMM capability

From: Tom Lendacky SMM is not currently supported for an SEV-ES guest by KVM. Change the SMM capability check from a KVM-wide check to a per-VM check in order to have a finer-grained SMM capability check. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Suggested-by: Sean Christoph

[PATCH v5 3/6] sev/i386: Allow AP booting under SEV-ES

From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the hypervisor cannot emulate this because it cannot update the AP regi

[PATCH v5 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests

From: Tom Lendacky In prep for AP booting, require the use of in-kernel irqchip support. This lessens the Qemu support burden required to boot APs. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Tom Lendacky --- target/i386/sev.c | 6 ++ 1 file changed, 6 ins

[PATCH v5 1/6] sev/i386: Add initial support for SEV-ES

From: Tom Lendacky Provide initial support for SEV-ES. This includes creating a function to indicate the guest is an SEV-ES guest (which will return false until all support is in place), performing the proper SEV initialization and ensuring that the guest CPU state is measured as part of the laun

[Bug 1908450] Re: ide/core.c ATA Major Version reporting incorrect

for what it's worth, i have yet to see a driver actually check this field. I have seen a ton of code (OVMF and others) detect other information and just straight up say "I'm in QEMU" and YOLO a bunch of things like assuming DMA is available and such, so I somewhat doubt anyone *actually* checks th

Re: [PATCH] 9pfs: Fully restart unreclaim loop (CVE-2021-20181)

On Thu, 14 Jan 2021, Greg Kurz wrote: > Depending on the client activity, the server can be asked to open a huge > number of file descriptors and eventually hit RLIMIT_NOFILE. This is > currently mitigated using a reclaim logic : the server closes the file > descriptors of idle fids, based on the a

Re: [PATCH] hw/block/nvme: fix zone write finalize

On Tue, Jan 12, 2021 at 10:42:35AM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > The zone write pointer is unconditionally advanced, even for write > faults. Make sure that the zone is always transitioned to Full if the > write pointer reaches zone capacity. Looks like some spec weirdness.

[Bug 1908450] Re: ide/core.c ATA Major Version reporting incorrect

I doubt we truly implement *any* standard precisely correctly, but if we are advertising support for ATA7 and it works, I'd rather just fix the comment to keep behavior the same. It probably was a mistake in the original commit from ... sometime before 2006, but if nothing is observably broken, ma

[PATCH v2] linux-user: Remove obsolete F_SHLCK and F_EXLCK translation

These lock types are unsupported by Linux since v2.2[0][1] and always return EINVAL (except on SPARC up until v2.6, which just warned). musl libc does not define these constants, so just remove them from the translation cases. [0] https://github.com/mpe/linux-fullhistory/blob/v2.2.0/fs/locks.c#L3

Re: [PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning

On Thu, Jan 14, 2021 at 03:22:51PM +0800, zhenwei pi wrote: > @@ -2860,6 +2887,12 @@ static void nvme_set_smart_warning(Object *obj, > Visitor *v, const char *name, > } > > s->smart_critical_warning = value; > + > +/* test each bit of uint8_t for smart.critical_warning */ > +fo

Re: [PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property

On Thu, Jan 14, 2021 at 03:22:50PM +0800, zhenwei pi wrote: > +static void nvme_get_smart_warning(Object *obj, Visitor *v, const char *name, > + void *opaque, Error **errp) > +{ > +NvmeCtrl *s = NVME(obj); With only one exception, all variables of type 'NvmeCt

[PATCH] fuzz: Add virtio-9p configurations for fuzzing

Signed-off-by: Alexander Bulekov --- tests/qtest/fuzz/generic_fuzz_configs.h | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h index 7fed035345..ffdb590c58 100644 --- a/tests/qtest/fuzz/generic_fuzz

Re: [PATCH v2] osdep.h: Remove include

On 1/13/21 4:56 PM, Michael Forney wrote: Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD (apart from two .c files). The POSIX standard location for this header is just and in fact, OpenBSD's signal.h includes sys/signal.h itself. Unconditionally including on musl causes warning

[Bug 1911797] Re: hmp command `hostfwd_remove` does not work on running vm

** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1911797 Title: hmp command `hostfwd_remove` does not work on running vm Status in QEMU: Invalid B

Re: [RFC PATCH v3 0/6] eBPF RSS support for virtio-net

Patchew URL: https://patchew.org/QEMU/20210114211612.387052-1-and...@daynix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210114211612.387052-1-and...@daynix.com Subject: [RFC PATCH v3 0/6] eBPF RSS support for

[RFC PATCH v3 5/6] virtio-net: Added eBPF RSS to virtio-net.

From: Andrew When RSS is enabled the device tries to load the eBPF program to select RX virtqueue in the TUN. If eBPF can be loaded the RSS will function also with vhost (works with kernel 5.8 and later). Software RSS is used as a fallback with vhost=off when eBPF can't be loaded or when hash pop

[RFC PATCH v3 4/6] ebpf: Added eBPF RSS loader.

From: Andrew Added function that loads RSS eBPF program. Added stub functions for RSS eBPF loader. Added meson and configuration options. By default, eBPF feature enabled if libbpf is present in the build system. libbpf checked in configuration shell script and meson script. Signed-off-by: Yuri

[RFC PATCH v3 0/6] eBPF RSS support for virtio-net

This set of patches introduces the usage of eBPF for packet steering and RSS hash calculation: * RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash * Additionally adding support for the usage of RSS with vhost The eBPF works on kernels 5.

[RFC PATCH v3 3/6] ebpf: Added eBPF RSS program.

From: Andrew RSS program and Makefile to build it. The bpftool used to generate '.h' file. The data in that file may be loaded by libbpf. EBPF compilation is not required for building qemu. You can use Makefile if you need to regenerate rss.bpf.skeleton.h. Signed-off-by: Yuri Benditovich Signed

[RFC PATCH v3 6/6] docs: Added eBPF documentation.

From: Andrew Also, added maintainers information. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko --- MAINTAINERS | 8 +++ docs/ebpf_rss.rst | 125 ++ 2 files changed, 133 insertions(+) create mode 100644 docs/ebpf_rss.rst

[RFC PATCH v3 2/6] net: Added SetSteeringEBPF method for NetClientState.

From: Andrew For now, that method supported only by Linux TAP. Linux TAP uses TUNSETSTEERINGEBPF ioctl. Signed-off-by: Andrew Melnychenko --- include/net/net.h | 2 ++ net/tap-bsd.c | 5 + net/tap-linux.c | 13 + net/tap-solaris.c | 5 + net/tap-stub.c| 5

[RFC PATCH v3 1/6] net/tap: Added TUNSETSTEERINGEBPF code.

From: Andrew Additional code that will be used for eBPF setting steering routine. Signed-off-by: Andrew Melnychenko --- net/tap-linux.h | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tap-linux.h b/net/tap-linux.h index 2f36d100fc..1d06fe0de6 100644 --- a/net/tap-linux.h +++ b/net/tap-

Re: [PATCH] hw/riscv: sifive_u: Use SIFIVE_U_CPU for mc->default_cpu_type

On Sat, Jan 9, 2021 at 6:37 AM Bin Meng wrote: > > From: Bin Meng > > SIFIVE_U_CPU is conditionally set to SIFIVE_U34 or SIFIVE_U54, hence > there is no need to use #idef to set the mc->default_cpu_type. > > Signed-off-by: Bin Meng Thanks! Applied to riscv-to-apply.next Alistair > --- > > h

Re: [PATCH] hw/riscv: sifive_u: Use SIFIVE_U_CPU for mc->default_cpu_type

On Sat, Jan 9, 2021 at 6:37 AM Bin Meng wrote: > > From: Bin Meng > > SIFIVE_U_CPU is conditionally set to SIFIVE_U34 or SIFIVE_U54, hence > there is no need to use #idef to set the mc->default_cpu_type. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > hw/riscv/s

Re: [PATCH 06/22] util: Add CRC16 (CCITT) calculation routines

On Thu, Dec 31, 2020 at 3:35 AM Bin Meng wrote: > > From: Bin Meng > > Import CRC16 calculation routines from Linux kernel v5.10: > > include/linux/crc-ccitt.h > lib/crc-ccitt.c > > to QEMU: > > include/qemu/crc-ccitt.h > util/crc-ccitt.c > > Signed-off-by: Bin Meng Acked-by: Alistair F

Re: [PATCH 1/3] tests/acceptance: Move the pseries test to a separate file

On Tue, Jan 12, 2021 at 1:42 PM Thomas Huth wrote: > > Let's gather the POWER-related tests in a separate file. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS| 1 + > tests/acceptance/boot_linux_console.py | 19 -- > tests/acceptance/machine_ppc.py

Re: [PATCH v2 01/12] tests/docker: Remove Debian 9 remnant lines

On Thu, Jan 14, 2021 at 2:33 PM Alex Bennée wrote: > > From: Philippe Mathieu-Daudé > > Debian 9 base container has been removed in commits > e3755276d1f and c9d78b06c06. Remove the last remnants. > > Fixes: e3755276d1f ("tests/docker: Remove old Debian 9 containers") > Signed-off-by: Philippe Ma

Re: [PATCH 1/2] meson.build: Declare global edk2_targets / install_edk2_blobs variables

On 01/14/21 20:57, Philippe Mathieu-Daudé wrote: > On 1/14/21 8:49 PM, Laszlo Ersek wrote: >> On 01/14/21 18:45, Philippe Mathieu-Daudé wrote: >>> Globally declare in the main meson.build: >>> - the list of EDK2 targets, >>> - whether the EDK2 blobs have to be installed. >>> >>> Signed-off-by: Phil

Re: [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints

On Thu, Jan 14, 2021 at 2:41 PM Max Reitz wrote: > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/129 | 4 ++-- > tests/qemu-iotests/297 | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129 > index 6d21470cd7..201d9e0a

Re: [PATCH v2 09/12] gitlab: move docs and tools build across from Travis

On Thu, Jan 14, 2021 at 2:46 PM Alex Bennée wrote: > > While we are at it we might as well check the tag generation. For > bonus points we run GNU globals htags into the public pages directory > for publishing with the auto generated pages. > > Signed-off-by: Alex Bennée > Reviewed-by: Wainer dos

Re: [PATCH 7/7] block/rbd: change request alignment to 1 byte

Am 14.01.21 um 20:19 schrieb Jason Dillaman: > On Sun, Dec 27, 2020 at 11:42 AM Peter Lieven wrote: >> since we implement byte interfaces and librbd supports aio on byte >> granularity we can lift >> the 512 byte alignment. >> >> Signed-off-by: Peter Lieven >> --- >> block/rbd.c | 2 -- >> 1 fi

Re: [PATCH 1/2] meson.build: Declare global edk2_targets / install_edk2_blobs variables

On 1/14/21 8:49 PM, Laszlo Ersek wrote: > On 01/14/21 18:45, Philippe Mathieu-Daudé wrote: >> Globally declare in the main meson.build: >> - the list of EDK2 targets, >> - whether the EDK2 blobs have to be installed. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Patch trivial to review usi

[Bug 1911797] Re: hmp command `hostfwd_remove` does not work on running vm

(qemu) hostfwd_add tcp::43210-:43210 (qemu) hostfwd_remove tcp::43210-:43210 invalid format -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1911797 Title: hmp command `hostfwd_remove` does not work o

  1   2   3   4   5   >