On 1/13/21 4:56 PM, Michael Forney wrote:
Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD
(apart from two .c files). The POSIX standard location for this
header is just <signal.h> and in fact, OpenBSD's signal.h includes
sys/signal.h itself.
Unconditionally including <sys/signal.h> on musl causes warnings
for just about every source file:
/usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect #include
<sys/signal.h> to <signal.h> [-Wcpp]
1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h>
| ^~~~~~~
Since there don't seem to be any platforms which require including
<sys/signal.h> in addition to <signal.h>, and some platforms like
Haiku lack it completely, just remove it.
Tested building on OpenBSD after removing this include.
Signed-off-by: Michael Forney <mfor...@mforney.org>
Reviewed-by: Eric Blake <ebl...@redhat.com>
I ran into this myself when testing an Alpine linux build with musl.
Seems to certainly cut down on the number of errors seen when building
in Alpine. There's still a few more, but there's definitely less.
Tested-by: John Snow <js...@redhat.com>
