[Bug 1604303] Re: Solaris on KVM/QEMU: WARNING rtls0: Failure resetting PHY

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1604303 Title: Solaris on

[Bug 1174654] Re: qemu-system-x86_64 takes 100% CPU after host machine resumed from suspend to ram

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1174654 Title: qemu-system

[Bug 1615823] Re: Windows 10 reports no compatible TPM found yet device manager shows it?

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1615823 Title: Windows 10

[Bug 1675458] Re: attach-interface - unexpected action

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1675458 Title: attach-inte

[Bug 1674056] Re: USB keyboard and mouse sucked into qemu-kvm (somewhere)

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1674056 Title: USB keyboar

[Bug 1605045] Re: input-linux enter key stuck and/or broken

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1605045 Title: input-linux

[Bug 1732177] Re: SBSA ACS test freezes inside qemu-system-aarch64

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1732177 Title: SBSA ACS te

[Bug 1675333] Re: qemu-system crashes when use sheepdog driver

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1675333 Title: qemu-system

[Bug 1738507] Re: qemu sometimes stuck when booting windows 10

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738507 Title: qemu someti

[Bug 1863486] Re: aarch64/tcg crash with malloc(): unsorted double linked list corrupted

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863486 Title: aarch64/tcg

[Bug 1735082] Re: NVME pass through in th eguest VM

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1735082 Title: NVME pass t

[Bug 1677247] Re: QEMU e500 kvm no video and kernel crashing in virtios modules

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1677247 Title: QEMU e500 k

[Bug 1738434] Re: CALL FWORD PTR [ESP] handled incorrectly

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738434 Title: CALL FWORD

[Bug 1759492] Re: suspend/resume is not supported for vm with tpm device

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1759492 Title: suspend/res

[Bug 1763536] Re: go build fails under qemu-ppc64le-static (qemu-user)

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1763536 Title: go build fa

[Bug 1761153] Re: qemu-user incorrect mmap for large files on 64bits host and 32bits executable.

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1761153 Title: qemu-user i

[Bug 1736042] Re: qemu-system-x86_64 does not boot image reliably

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1736042 Title: qemu-system

[Bug 1767146] Re: No ACPI-table found, option -M 1.6 not found either

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1767146 Title: No ACPI-tab

[Bug 1778182] Re: qemu-system-aarch64 shows black framebuffer window on minimal bare metal example on SDL but not on VNC

2021-01-09 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1778182 Title: qemu-system

[PATCH] tcg: Remove unused tcg_out_dupi_vec() stub

2021-01-09 Thread Wataru Ashihara
This fixes the build with --enable-tcg-interpreter: clang -Ilibqemu-arm-softmmu.fa.p -I. -I.. -Itarget/arm -I../target/arm -I../dtc/libfdt -I../capstone/include/capstone -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/pixman-1 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/includ

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-09 Thread Roman Bolshakov
On Sun, Jan 10, 2021 at 02:13:48AM +0100, BALATON Zoltan wrote: > On Sun, 10 Jan 2021, Roman Bolshakov wrote: > > On Sat, Jan 09, 2021 at 12:13:36AM +0100, BALATON Zoltan wrote: > > > On Sat, 9 Jan 2021, Roman Bolshakov wrote: > > > > On Fri, Jan 08, 2021 at 03:00:07PM +, Peter Maydell wrote: >

Re: [PATCH] hvf: guard xgetbv call.

2021-01-09 Thread Roman Bolshakov
On Sat, Jan 09, 2021 at 11:42:18AM +, Peter Maydell wrote: > On Sat, 9 Jan 2021 at 05:49, Roman Bolshakov wrote: > > > > On Fri, Dec 18, 2020 at 06:13:47PM -0800, Hill Ma wrote: > > > This prevents illegal instruction on cpus do not support xgetbv. > > > > > > Buglink: https://bugs.launchpad.n

Re: [PATCH v3 3/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-09 Thread Bin Meng
Hi Philippe, On Sun, Jan 10, 2021 at 7:53 AM Philippe Mathieu-Daudé wrote: > > On 1/9/21 1:35 PM, Bin Meng wrote: > > From: Bin Meng > > > > Usually the approach is that the device on the other end of the line > > is going to reset its state anyway, so there's no need to actively > > signal an i

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-09 Thread BALATON Zoltan
On Sun, 10 Jan 2021, Roman Bolshakov wrote: On Sat, Jan 09, 2021 at 12:13:36AM +0100, BALATON Zoltan wrote: On Sat, 9 Jan 2021, Roman Bolshakov wrote: On Fri, Jan 08, 2021 at 03:00:07PM +, Peter Maydell wrote: On Fri, 8 Jan 2021 at 13:50, Peter Maydell wrote: On Sat, 2 Jan 2021 at 15:14

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-09 Thread BALATON Zoltan
On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 1/9/21 9:16 PM, BALATON Zoltan wrote: Currently the ISA devices that are part of the VIA south bridge, superio chip are wired up by board code. Move creation of these ISA devices to the VIA ISA bridge model so that board code does

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-09 Thread Roman Bolshakov
On Sat, Jan 09, 2021 at 01:25:44PM +0100, Christian Schoenebeck via wrote: > On Samstag, 9. Januar 2021 00:13:36 CET BALATON Zoltan wrote: > > On Sat, 9 Jan 2021, Roman Bolshakov wrote: > > > On Fri, Jan 08, 2021 at 03:00:07PM +, Peter Maydell wrote: > > >> On Fri, 8 Jan 2021 at 13:50, Peter Ma

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-09 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 1/9/21 9:16 PM, BALATON Zoltan wrote: > Currently the ISA devices that are part of the VIA south bridge, > superio chip are wired up by board code. Move creation of these ISA > devices to the VIA ISA bridge model so that board code does not need > to access ISA bus. This also allows

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-09 Thread Roman Bolshakov
On Sat, Jan 09, 2021 at 12:13:36AM +0100, BALATON Zoltan wrote: > On Sat, 9 Jan 2021, Roman Bolshakov wrote: > > On Fri, Jan 08, 2021 at 03:00:07PM +, Peter Maydell wrote: > > > On Fri, 8 Jan 2021 at 13:50, Peter Maydell > > > wrote: > > > > > > > > On Sat, 2 Jan 2021 at 15:14, Roman Bolshak

Re: [PATCH v2 01/13] vt82c686: Move superio memory region to SuperIOConfig struct

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/9/21 9:16 PM, BALATON Zoltan wrote: > The superio memory region holds the io space index/data registers used > to access the superio config registers that are implemented in struct > SuperIOConfig. To keep these related things together move the memory > region to SuperIOConfig and rename it ac

[PATCH v3] decodetree: Open files with encoding='utf-8'

2021-01-09 Thread Philippe Mathieu-Daudé
When decodetree.py was added in commit 568ae7efae7, QEMU was using Python 2 which happily reads UTF-8 files in text mode. Python 3 requires either UTF-8 locale or an explicit encoding passed to open(). Now that Python 3 is required, explicit UTF-8 encoding for decodetree source files. To avoid fur

Re: [PATCH v3 4/6] hw/ssi: imx_spi: Log unimplemented burst length

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/9/21 1:35 PM, Bin Meng wrote: > From: Bin Meng > > Current implementation of the imx spi controller expects the burst > length to be multiple of 8, which is the most normal use case. s/normal/common/? > > In case the burst length is not what we expect, log it to give user > a chance to no

Re: [PATCH v3 3/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/9/21 1:35 PM, Bin Meng wrote: > From: Bin Meng > > Usually the approach is that the device on the other end of the line > is going to reset its state anyway, so there's no need to actively > signal an irq line change during the reset hook. > > Move imx_spi_update_irq() out of imx_spi_reset(

Re: [PATCH v3 2/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled

2021-01-09 Thread Philippe Mathieu-Daudé
Hi, On 1/9/21 1:35 PM, Bin Meng wrote: > From: Xuzhou Cheng > > When a write to ECSPI_CONREG register to disable the SPI controller, > imx_spi_reset() is called to reset the controller, but chip select > lines should have been disabled, otherwise the state machine of any > devices (e.g.: SPI fla

Re: [PATCH v3 1/6] hw/ssi: imx_spi: Use a macro for number of chip selects supported

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/9/21 1:35 PM, Bin Meng wrote: > From: Bin Meng > > Avoid using a magic number (4) everywhere for the number of chip > selects supported. > > Signed-off-by: Bin Meng > Reviewed-by: Alistair Francis > --- > > (no changes since v1) > > include/hw/ssi/imx_spi.h | 5 - > hw/ssi/imx_spi.

Re: [PATCH] hw/riscv: sifive_u: Use SIFIVE_U_CPU for mc->default_cpu_type

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/9/21 3:36 PM, Bin Meng wrote: > From: Bin Meng > > SIFIVE_U_CPU is conditionally set to SIFIVE_U34 or SIFIVE_U54, hence > there is no need to use #idef to set the mc->default_cpu_type. > > Signed-off-by: Bin Meng > --- > > hw/riscv/sifive_u.c | 6 +- > 1 file changed, 1 insertion(+),

Re: [PATCH v2 06/13] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/9/21 9:16 PM, BALATON Zoltan wrote: > The vt82c686b-pm model can be shared between VT82C686B and VT8231. The > only difference between the two is the device id in what we emulate so > make an abstract via-pm model by renaming appropriately and add types > for vt82c686b-pm and vt8231-pm based o

Re: [PATCH v2 05/13] vt82c686: Set user_creatable=false for VT82C686B_PM

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/9/21 9:16 PM, BALATON Zoltan wrote: > This device is part of the multifunction VIA superio/south bridge chip > so not useful in itself. > > Signed-off-by: BALATON Zoltan > --- > hw/isa/vt82c686.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH] target/i386: Use X86Seg enum for segment registers

2021-01-09 Thread Philippe Mathieu-Daudé
Use the dedicated X86Seg enum type for segment registers. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.h| 4 ++-- target/i386/gdbstub.c| 2 +- target/i386/tcg/seg_helper.c | 8 target/i386/tcg/translate.c | 6 +++--- 4 files changed, 10 insertions(+), 1

Re: [RFC PATCH 0/2] Pegasos2 emulation

2021-01-09 Thread BALATON Zoltan
On Thu, 7 Jan 2021, Philippe Mathieu-Daudé wrote: On 1/7/21 2:15 AM, BALATON Zoltan wrote: On Wed, 6 Jan 2021, BALATON Zoltan wrote: Hello, This is adding a new PPC board called pegasos2 currently posted as RFC because it depends on not yet merged VT8231 emulation currently on the list: https

Re: [PATCH v6 14/35] Hexagon (target/hexagon) instruction printing

2021-01-09 Thread Philippe Mathieu-Daudé
Hi Taylor, On 1/8/21 5:28 AM, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > --- > target/hexagon/printinsn.h | 28 > target/hexagon/printinsn.c | 158 > + > 2 files changed, 186 insertions(+) > create mode 100644 target/hexagon/pr

Re: [PATCH v6 08/35] Hexagon (target/hexagon) GDB Stub

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/8/21 5:28 AM, Taylor Simpson wrote: > GDB register read and write routines > > Signed-off-by: Taylor Simpson > Reviewed-by: Richard Henderson > --- > target/hexagon/internal.h | 3 +++ > target/hexagon/cpu.c | 2 ++ > target/hexagon/gdbstub.c | 47 > +++

Re: [PATCH v2 1/1] target-riscv: support QMP dump-guest-memory

2021-01-09 Thread Andrew Jones
On Fri, Dec 18, 2020 at 10:26:53AM +0800, Yifei Jiang wrote: > Add the support needed for creating prstatus elf notes. Now elf notes > only contains user_regs. This allows us to use QMP dump-guest-memory. > > Signed-off-by: Yifei Jiang > Signed-off-by: Mingwang Li > --- > target/riscv/arch_dump

Re: [PATCH v6 05/35] Hexagon (disas) disassembler

2021-01-09 Thread Philippe Mathieu-Daudé
Hi Taylor, On 1/8/21 5:28 AM, Taylor Simpson wrote: > Add hexagon to disas/meson.build > Add disas/hexagon.c > Add hexagon to include/disas/dis-asm.h > > Signed-off-by: Taylor Simpson > --- > include/disas/dis-asm.h | 1 + > disas/hexagon.c | 68 > +

[RFC PATCH v2 2/2] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-01-09 Thread BALATON Zoltan
Add new machine called pegasos2 emulating the Genesi/bPlan Pegasos II, a PowerPC board based on the Marvell MV64361 system controller and the VIA VT8231 integrated south bridge/superio chips. It can run Linux, AmigaOS and a wide range of MorphOS versions. Currently a firmware ROM image is needed to

[RFC PATCH v2 1/2] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-01-09 Thread BALATON Zoltan
The Marvell Discovery II aka. MV64361 is a PowerPC system controller chip that is used on the pegasos2 PPC board. This adds emulation of it that models the device enough to boot guests on this board. The mv643xx.h header with register definitions is taken from Linux 4.15.10 only fixing end of line

[RFC PATCH v2 0/2] Pegasos2 emulation

2021-01-09 Thread BALATON Zoltan
Hello, v2 adds missing file that's omitted from original series, still based on "[PATCH v2 0/3] Fix up sam460ex fixes" Based-on: This is adding a new PPC board called pegasos2 currently posted as RFC because it depends on not yet merged VT8231 emulation currently under review. A working version

[PATCH 1/1] linux-user/syscall: Fix do_ioctl_ifconf() for 64 bit targets.

2021-01-09 Thread Stefan
The sizeof(struct ifreq) is 40 for 64 bit and 32 for 32 bit architectures. This structure contains a union of other structures, of which struct ifmap is the biggest for 64 bit architectures. Calling ioclt(…, SIOCGIFCONF, …) fills a struct sockaddr of that union, and do_ioctl_ifconf() only considere

[PATCH v2 11/13] vt82c686: QOM-ify superio related functionality

2021-01-09 Thread BALATON Zoltan
Collect superio functionality and its controlling config registers handling in an abstract VIA_SUPERIO class that is a subclass of ISA_SUPERIO and put vt82c686b specific parts in a subclass of this abstract class. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 240

[PATCH v2 13/13] vt82c686: Add emulation of VT8231 south bridge

2021-01-09 Thread BALATON Zoltan
Add emulation of VT8231 south bridge ISA part based on the similar VT82C686B but implemented in a separate subclass that holds the differences while reusing parts that can be shared. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 154 ++ include

[PATCH v2 09/13] vt82c686: Fix superio_cfg_{read,write}() functions

2021-01-09 Thread BALATON Zoltan
These functions are memory region callbacks so we have to check against relative address not the mapped address. Also reduce indentation by returning early and log unimplemented accesses. Additionally we remove separate index value from SuperIOConfig and store the index at reg 0 which is reserved a

[PATCH v2 10/13] vt82c686: Implement control of serial port io ranges via config regs

2021-01-09 Thread BALATON Zoltan
In VIA super south bridge the io ranges of superio components (parallel and serial ports and FDC) can be controlled by superio config registers to set their base address and enable/disable them. This is not easy to implement in QEMU because ISA emulation is only designed to set io base address once

[PATCH v2 02/13] vt82c686: Reorganise code

2021-01-09 Thread BALATON Zoltan
Move lines around so that object definitions become consecutive and not scattered around. This brings functions belonging to an object together so it's clearer what is defined and what parts belong to which object. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/vt8

[PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-09 Thread BALATON Zoltan
Currently the ISA devices that are part of the VIA south bridge, superio chip are wired up by board code. Move creation of these ISA devices to the VIA ISA bridge model so that board code does not need to access ISA bus. This also allows vt82c686b-superio to be made internal to vt82c686 which allow

[PATCH v2 12/13] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO

2021-01-09 Thread BALATON Zoltan
The VT8231 south bridge is very similar to VT82C686B but there are some differences in register addresses and functionality, e.g. the VT8231 only has one serial port. This commit adds VT8231_SUPERIO subclass based on the abstract VIA_SUPERIO class to emulate the superio part of VT8231. Signed-off-

[PATCH v2 07/13] vt82c686: Simplify vt82c686b_realize()

2021-01-09 Thread BALATON Zoltan
Remove unneeded variables and setting value to 0 on zero initialised data and replace check for error with error_fatal. Rationalise loop that sets PCI config header fields read only. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/vt82c686.c | 20 ++-

[PATCH v2 03/13] vt82c686: Fix SMBus IO base and configuration registers

2021-01-09 Thread BALATON Zoltan
The base address of the SMBus io ports and its enabled status is set by registers in the PCI config space but this was not correctly emulated. Instead the SMBus registers were mapped on realize to the base address set by a property to the address expected by fuloong2e firmware. Fix the base and co

[PATCH v2 06/13] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it

2021-01-09 Thread BALATON Zoltan
The vt82c686b-pm model can be shared between VT82C686B and VT8231. The only difference between the two is the device id in what we emulate so make an abstract via-pm model by renaming appropriately and add types for vt82c686b-pm and vt8231-pm based on it. Signed-off-by: BALATON Zoltan --- hw/isa

[PATCH v2 00/13] vt82c686b clean ups and vt8231 emulation

2021-01-09 Thread BALATON Zoltan
Version 2 of remaining patches for VT8231 emulation addressing review comments: - Split off making vt82c686b-pm an abstract class to separate patch - Use constants for PCI IDs Regards, BALATON Zoltan BALATON Zoltan (13): vt82c686: Move superio memory region to SuperIOConfig struct vt82c686:

[PATCH v2 01/13] vt82c686: Move superio memory region to SuperIOConfig struct

2021-01-09 Thread BALATON Zoltan
The superio memory region holds the io space index/data registers used to access the superio config registers that are implemented in struct SuperIOConfig. To keep these related things together move the memory region to SuperIOConfig and rename it accordingly. Also remove the unused "data" member o

[PATCH v2 05/13] vt82c686: Set user_creatable=false for VT82C686B_PM

2021-01-09 Thread BALATON Zoltan
This device is part of the multifunction VIA superio/south bridge chip so not useful in itself. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index fc2a1f4430..9b16660e9d 100644 ---

[PATCH v2 04/13] vt82c686: Fix up power management io base and config

2021-01-09 Thread BALATON Zoltan
Similar to the SMBus io registers there is a power management io range that is set via similar base address reg and enable bit. Some handling of this was already there but with several problems: using the wrong registers and bits, wrong size range, not acually updating mapping and handling reset co

Re: qemu bsd-user plans

2021-01-09 Thread Warner Losh
On Sat, Jan 9, 2021 at 10:03 AM Kyle Evans wrote: > On Fri, 8 Jan 2021 at 19:43, Warner Losh wrote: > > > > The FreeBSD project has rewritten bsd-user. We've been working on this > for quite some time (the earliest commits date from 2013). Maybe a dozen > people have worked on this over time, an

Re: qemu bsd-user plans

2021-01-09 Thread Kyle Evans
On Fri, 8 Jan 2021 at 19:43, Warner Losh wrote: > > The FreeBSD project has rewritten bsd-user. We've been working on this for > quite some time (the earliest commits date from 2013). Maybe a dozen people > have worked on this over time, and there's 3 or 4 active developers focused > on FreeBSD

[PATCH] hw/riscv: sifive_u: Use SIFIVE_U_CPU for mc->default_cpu_type

2021-01-09 Thread Bin Meng
From: Bin Meng SIFIVE_U_CPU is conditionally set to SIFIVE_U34 or SIFIVE_U54, hence there is no need to use #idef to set the mc->default_cpu_type. Signed-off-by: Bin Meng --- hw/riscv/sifive_u.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/riscv/sifive_u.c b/hw/

[PATCH v5 14/14] block/qcow2: refactor qcow2_update_options_prepare error paths

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Keep setting ret close to setting errp and don't merge different error paths into one. This way it's more obvious that we don't return error without setting errp. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff

[PATCH v5 10/14] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
It's better to return status together with setting errp. It makes possible to avoid error propagation. While being here, put ERRP_GUARD() to fix error_prepend(errp, ...) usage inside qcow2_store_persistent_dirty_bitmaps() (see the comment above ERRP_GUARD() definition in include/qapi/error.h) Sig

[PATCH v5 12/14] block/qcow2: simplify qcow2_co_invalidate_cache()

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
qcow2_do_open correctly sets errp on each failure path. So, we can simplify code in qcow2_co_invalidate_cache() and drop explicit error propagation. Add ERRP_GUARD() as mandated by the documentation in include/qapi/error.h so that error_prepend() is actually called even if errp is &error_fatal. S

[PATCH v5 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Don't use error propagation in qcow2_get_specific_info(). For this refactor qcow2_get_bitmap_info_list, its current interface is rather weird. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- block/qcow2.h| 4 ++-- block/qcow2-bitmap.c

[PATCH v5 11/14] block/qcow2: read_cache_sizes: return status value

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
It's better to return status together with setting errp. It allows to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- block/qcow2.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --gi

[PATCH v5 04/14] blockdev: fix drive_backup_prepare() missed error

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
We leak local_err and don't report failure to the caller. It's definitely wrong, let's fix. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- blockdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev

[PATCH v5 07/14] blockjob: return status from block_job_set_speed()

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Better to return status together with setting errp. It allows to avoid error propagation in the caller. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- include/block/blockjob.h | 2 +- blockjob.c | 18 -- 2 files

[PATCH v5 13/14] block/qed: bdrv_qed_do_open: deal with errp

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Set errp always on failure. Generic bdrv_open_driver supports driver functions which can return negative value and forget to set errp. That's a strange thing.. Let's improve bdrv_qed_do_open to not behave this way. This allows to simplify code in bdrv_qed_co_invalidate_cache(). Signed-off-by: Vlad

[PATCH v5 02/14] block: use return status of bdrv_append()

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Now bdrv_append returns status and we can drop all the local_err things around it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 6 ++ block/backup-top.c | 23 +++ block/commit.c | 6 ++ block/mirror.c

[PATCH v5 03/14] block: check return value of bdrv_open_child and drop error propagation

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
This patch is generated by cocci script: @@ symbol bdrv_open_child, errp, local_err; expression file; @@ file = bdrv_open_child(..., -&local_err +errp ); - if (local_err) + if (!file) { ... - error_propagate(err

[PATCH v5 06/14] block/mirror: drop extra error propagation in commit_active_start()

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Let's check return value of mirror_start_job to check for failure instead of local_err. Rename ret to job, as ret is usually integer variable. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- block/mirror.c | 12 +--- 1 file changed, 5

[PATCH v5 05/14] block: drop extra error propagation for bdrv_set_backing_hd

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
bdrv_set_backing_hd now returns status, let's use it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- block.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 2a13fbfc73..0d7a62476f 100644 --- a

[PATCH v5 09/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
It's recommended for bool functions with errp to return true on success and false on failure. Non-standard interfaces don't help to understand the code. The change is also needed to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Gre

[PATCH v5 00/14] block: deal with errp: part I

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
v5: rebase on master Vladimir Sementsov-Ogievskiy (14): block: return status from bdrv_append and friends block: use return status of bdrv_append() block: check return value of bdrv_open_child and drop error propagation blockdev: fix drive_backup_prepare() missed error block: drop ex

[PATCH v5 01/14] block: return status from bdrv_append and friends

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
The recommended use of qemu error api assumes returning status together with setting errp and avoid void functions with errp parameter. Let's improve bdrv_append and some friends to reduce error-propagation overhead in further patches. Choose int return status, because bdrv_replace_node_common() h

[PATCH v3 5/6] hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic

2021-01-09 Thread Bin Meng
From: Bin Meng For the ECSPIx_CONREG register BURST_LENGTH field, the manual says: 0x020 A SPI burst contains the 1 LSB in first word and all 32 bits in second word. 0x021 A SPI burst contains the 2 LSB in first word and all 32 bits in second word. Current logic uses either s->burst_length or

[PATCH v3 1/6] hw/ssi: imx_spi: Use a macro for number of chip selects supported

2021-01-09 Thread Bin Meng
From: Bin Meng Avoid using a magic number (4) everywhere for the number of chip selects supported. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v1) include/hw/ssi/imx_spi.h | 5 - hw/ssi/imx_spi.c | 4 ++-- 2 files changed, 6 insertions(+), 3 delet

[PATCH v3 6/6] hw/ssi: imx_spi: Correct tx and rx fifo endianness

2021-01-09 Thread Bin Meng
From: Bin Meng The endianness of data exchange between tx and rx fifo is incorrect. Earlier bytes are supposed to show up on MSB and later bytes on LSB, ie: in big endian. The manual does not explicitly say this, but the U-Boot and Linux driver codes have a swap on the data transferred to tx fifo

[PATCH v3 4/6] hw/ssi: imx_spi: Log unimplemented burst length

2021-01-09 Thread Bin Meng
From: Bin Meng Current implementation of the imx spi controller expects the burst length to be multiple of 8, which is the most normal use case. In case the burst length is not what we expect, log it to give user a chance to notice it. Signed-off-by: Bin Meng --- Changes in v3: - new patch:

[PATCH v6 06/11] iotests: define group in each iotest

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
We are going to drop group file. Define group in tests as a preparatory step. The patch is generated by cd tests/qemu-iotests grep '^[0-9]\{3\} ' group | while read line; do file=$(awk '{print $1}' <<< "$line"); groups=$(sed -e 's/^... //' <<< "$line"); awk "NR==2

[PATCH v3 3/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-09 Thread Bin Meng
From: Bin Meng Usually the approach is that the device on the other end of the line is going to reset its state anyway, so there's no need to actively signal an irq line change during the reset hook. Move imx_spi_update_irq() out of imx_spi_reset(), along with the disabling of chip selects, to a

[PATCH v6 08/11] iotests: add testenv.py

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Add TestEnv class, which will handle test environment in a new python iotests running framework. Difference with current ./check interface: - -v (verbose) option dropped, as it is unused - -xdiff option is dropped, until somebody complains that it is needed - same for -n option Signed-off-by: Vl

[PATCH v6 07/11] iotests: add findtests.py

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Add python script with new logic of searching for tests: Current ./check behavior: - tests are named [0-9][0-9][0-9] - tests must be registered in group file (even if test doesn't belong to any group, like 142) Behavior of findtests.py: - group file is dropped - tests are all files in test

[PATCH v3 0/6] hw/ssi: imx_spi: Fix various bugs in the imx_spi model

2021-01-09 Thread Bin Meng
From: Bin Meng This series fixes a bunch of bugs in current implementation of the imx spi controller, including the following issues: - chip select signal was not lower down when spi controller is disabled - remove imx_spi_update_irq() in imx_spi_reset() - transfer incorrect data when the burst

[PATCH v3 2/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled

2021-01-09 Thread Bin Meng
From: Xuzhou Cheng When a write to ECSPI_CONREG register to disable the SPI controller, imx_spi_reset() is called to reset the controller, but chip select lines should have been disabled, otherwise the state machine of any devices (e.g.: SPI flashes) connected to the SPI master is stuck to its la

[PATCH v6 05/11] iotests/294: add shebang line

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/294 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/294 b/tests/qemu-iotests/294 index 87da35db49..4c375ed609 100755 --- a/tests/qemu-iotests/294 +++ b/tests/qemu-iotests/294 @@ -1,3 +1,4 @@ +#!/usr/bin/env

[PATCH v6 10/11] iotests: rewrite check into python

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Just use classes introduced in previous three commits. Behavior difference is described in these three commits. Drop group file, as it becomes unused. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/check | 994 ++- tests/qemu-iotests/group

[PATCH v6 04/11] iotests: make tests executable

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
All other test files are executable. Fix these. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/283 | 0 tests/qemu-iotests/298 | 0 tests/qemu-iotests/299 | 0 3 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tests/qemu-iotests/283 mode change 1

[PATCH v6 11/11] iotests: rename and move 169 and 199 tests

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Rename bitmaps migration tests and move them to tests subdirectory to demonstrate new human-friendly test naming. Signed-off-by: Vladimir Sementsov-Ogievskiy --- This patch is and RFC and may be postponed. Or may be applied as well.. tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-te

[PATCH v6 09/11] iotests: add testrunner.py

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Add TestRunner class, which will run tests in a new python iotests running framework. There are some differences with current ./check behavior, most significant are: - Consider all tests self-executable, just run them, don't run python by hand. - Elapsed time is cached in json file - Elapsed tim

[PATCH v6 00/11] Rework iotests/check

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
Hi all! These series has 3 goals: - get rid of group file (to forget about rebase and in-list conflicts) - introduce human-readable names for tests - rewrite check into python v6: 04: condense making 283 and 299 executable into one patch. add 298 too 06: handle three more tests 08: add qemu-

[PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
If you run './check 277', check includes common.config which adjusts $PATH to include '.' first, and therefore finds nbd-fault-injector.py on PATH. But if you run './277' directly, there is nothing to adjust PATH, and if '.' is not already on your PATH by other means, the test fails because the ex

[PATCH v6 03/11] iotests: fix some whitespaces in test output files

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
We are going to be stricter about comparing test result with .out files. So, fix some whitespaces now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/175.out | 2 +- tests/qemu-iotests/271.out | 12 ++-- tests/qemu-iotests/287.out | 10 +- 3 files changed, 12

[PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running

2021-01-09 Thread Vladimir Sementsov-Ogievskiy
If you run './check 303', check includes common.config which adjusts $PATH to include '.' first, and therefore finds qcow2.py on PATH. But if you run './303' directly, there is nothing to adjust PATH, and if '.' is not already on your PATH by other means, the test fails because the executable is n

Re: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur

2021-01-09 Thread Christian Schoenebeck via
On Samstag, 9. Januar 2021 00:13:36 CET BALATON Zoltan wrote: > On Sat, 9 Jan 2021, Roman Bolshakov wrote: > > On Fri, Jan 08, 2021 at 03:00:07PM +, Peter Maydell wrote: > >> On Fri, 8 Jan 2021 at 13:50, Peter Maydell wrote: > >>> On Sat, 2 Jan 2021 at 15:14, Roman Bolshakov wrote: > u

Re: [PATCH] hvf: guard xgetbv call.

2021-01-09 Thread Peter Maydell
On Sat, 9 Jan 2021 at 05:49, Roman Bolshakov wrote: > > On Fri, Dec 18, 2020 at 06:13:47PM -0800, Hill Ma wrote: > > This prevents illegal instruction on cpus do not support xgetbv. > > > > Buglink: https://bugs.launchpad.net/qemu/+bug/1758819 > > Signed-off-by: Hill Ma > > --- > > target/i386/h

  1   2   >