Hi,
On 1/9/21 1:35 PM, Bin Meng wrote:
> From: Xuzhou Cheng <xuzhou.ch...@windriver.com>
>
> When a write to ECSPI_CONREG register to disable the SPI controller,
> imx_spi_reset() is called to reset the controller, but chip select
> lines should have been disabled, otherwise the state machine of any
> devices (e.g.: SPI flashes) connected to the SPI master is stuck to
> its last state and responds incorrectly to any follow-up commands.
>
> Fixes: c906a3a01582 ("i.MX: Add the Freescale SPI Controller")
> Signed-off-by: Xuzhou Cheng <xuzhou.ch...@windriver.com>
> Signed-off-by: Bin Meng <bin.m...@windriver.com>
>
> ---
>
> Changes in v3:
> - Move the chip selects disable out of imx_spi_reset()
>
> Changes in v2:
> - Fix the "Fixes" tag in the commit message
>
> hw/ssi/imx_spi.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c
> index e605049a21..8d429e703f 100644
> --- a/hw/ssi/imx_spi.c
> +++ b/hw/ssi/imx_spi.c
> @@ -353,6 +353,11 @@ static void imx_spi_write(void *opaque, hwaddr offset,
> uint64_t value,
> if (!imx_spi_is_enabled(s)) {
> /* device is disabled, so this is a reset */
> imx_spi_reset(DEVICE(s));
> +
> + for (int i = 0; i < ECSPI_NUM_CS; i++) {
> + qemu_set_irq(s->cs_lines[i], 1);
> + }
Shouldn't this be done in imx_spi_reset()?
