On Fri, Oct 02, 2020 at 04:38:01PM +0100, Daniel P. Berrangé wrote:
> On Fri, Oct 02, 2020 at 02:47:44PM +0200, Gerd Hoffmann wrote:
> > On Thu, Oct 01, 2020 at 07:39:33PM +0200, Paolo Bonzini wrote:
> > > On 01/10/20 19:32, Yonggang Luo wrote:
> > > > And also convert related configure script to
On Tue, Oct 06, 2020 at 12:03:26PM +0200, Igor Mammedov wrote:
> On Thu, 1 Oct 2020 10:28:29 +0200
> Gerd Hoffmann wrote:
>
> > Wire up "usb=on" machine option, when enabled add
> > a sysbus xhci controller with 8 ports.
>
> first pci, and now usb - not so micro anymore.
Both pcie and usb are
On 10/12/20 12:34 AM, David Gibson wrote:
On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote:
The Grackle PCI host model expects the interrupt controller
being set, but does not verify it is present. Add a check to
help developers using this model.
I don't think thaqt's ver
Acked-by: Subbaraya Sundeep
Thanks,
Sundeep
On Sun, Oct 4, 2020 at 11:55 PM Philippe Mathieu-Daudé wrote:
>
> These individual contributors have a number of contributions,
> add them to the 'individual' group map.
>
> Cc: Ahmed Karaman
> Cc: Aleksandar Markovic
> Cc: Alistair Francis
> Cc: A
在 2020/10/11 上午4:43, Philippe Mathieu-Daudé 写道:
The CPU frequency is normally provided by the firmware in the
"cpuclock" environment variable. The 2E board can handles up
to 660MHz, but be conservative and take the same value used
by the Linux kernel: 533 MHz.
Signed-off-by: Philippe Mathieu-
On Fri, Oct 09, 2020 at 07:57:32AM +0200, Cédric Le Goater wrote:
> On 10/9/20 2:23 AM, David Gibson wrote:
> > On Mon, Oct 05, 2020 at 06:51:41PM +0200, Cédric Le Goater wrote:
> >> Hello,
> >>
> >> When an interrupt has been handled, the OS notifies the interrupt
> >> controller with an EOI seque
在 2020/10/11 上午4:43, Philippe Mathieu-Daudé 写道:
The CP0 timer period is a function of the CPU frequency.
Start using the default values, which will be replaced by
properties in the next commits.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Jiaxun Yang
---
[...]
Thanks
- Jiaxun
在 2020/10/11 上午4:43, Philippe Mathieu-Daudé 写道:
Currently the CP0 timer period is fixed at 10 ns, corresponding
to a fixed CPU frequency of 200 MHz (using half the speed of the
CPU).
In few commits we will be able to use a different CPU frequency.
In preparation, move the cp0_count_ns variabl
On Sun, Oct 11, 2020 at 10:23:49AM +0800, Li Qiang wrote:
> David Gibson 于2020年10月10日周六 下午2:34写道：
> >
> > On Fri, Oct 09, 2020 at 07:02:56AM -0700, Elena Afanasova wrote:
> > > >From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 2001
> > > From: Elena Afanasova
> > > Date: Fri, 9 O
On Sat, Oct 10, 2020 at 08:53:00AM -0700, Elena Afanasova wrote:
> On Sat, 2020-10-10 at 17:07 +1100, David Gibson wrote:
> > On Fri, Oct 09, 2020 at 07:02:56AM -0700, Elena Afanasova wrote:
> > > > From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00
> > > > 2001
> > > From: Elena Afa
On 2020/9/30 下午4:07, Michael S. Tsirkin wrote:
On Tue, Sep 29, 2020 at 07:38:24PM +0100, Stefan Hajnoczi wrote:
On Tue, Sep 29, 2020 at 06:04:34AM -0400, Michael S. Tsirkin wrote:
On Tue, Sep 29, 2020 at 09:57:51AM +0100, Stefan Hajnoczi wrote:
On Tue, Sep 29, 2020 at 02:09:55AM -0400, Micha
Simple patch (and test) to avoid crashes when and invalid number
of dies is given.
Cleber Rosa (1):
hw/i386: prevent crash when an invalid number of dies is given
hw/i386/pc.c | 5 +
tests/acceptance/cpu_topology_dies.py | 31 +++
2 files c
When parsing the topology, the right default value of 1 is given to
dies, but if an invalid number such as 0 is given, QEMU will crash
with a floating point exception.
The alternative approach is to silently set dies to a valid value,
as it's done with cores and threads.
Signed-off-by: Cleber Ros
On Sat, Oct 10, 2020 at 09:54:16AM +0200, Philippe Mathieu-Daudé wrote:
> On 10/9/20 10:29 PM, Eduardo Habkost wrote:
> > Add a simple test case that will run QEMU directly (without QMP)
> > just to check for crashes when using `-object`.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > Changes
On Sat, Oct 10, 2020 at 10:07:41AM +0200, Philippe Mathieu-Daudé wrote:
> Avocado documentation referred returns 404 error.
> Update the broken links.
>
Thanks!
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Cleber Rosa
signature.asc
Description: PGP signature
On 2020/9/28 下午11:32, Stefan Hajnoczi wrote:
On Mon, Sep 28, 2020 at 03:21:56PM +0400, Marc-André Lureau wrote:
On Mon, Sep 28, 2020 at 1:25 PM Stefan Hajnoczi
Where this converges with multi-process QEMU
At this point QEMU can run ad-hoc vhost-use
On Sat, Oct 10, 2020 at 09:36:17AM +0200, Philippe Mathieu-Daudé wrote:
> On 10/9/20 10:55 PM, Cleber Rosa wrote:
> > On with certain versions of "pip", package installations will attempt
> > to create wheels. And, on environments without a "complete" Python
> > installation (as described in the a
On 29/09/2020 20:35, Alexey Kardashevskiy wrote:
On 16/07/2020 23:22, David Gibson wrote:
On Thu, Jul 16, 2020 at 07:04:56PM +1000, Alexey Kardashevskiy wrote:
Ping? I kinda realize it is not going to replace SLOF any time soon but
still...
Yeah, I know. I just haven't had time to cons
On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote:
> The Grackle PCI host model expects the interrupt controller
> being set, but does not verify it is present. Add a check to
> help developers using this model.
I don't think thaqt's very likely, but, sure, applied to ppc-for-
In order to use inclusive terminology, rename SSI 'slave' as
'peripheral', following the specification resolution:
https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/
Patch created mechanically using:
$ sed -i s/SSISlave/SSIPeripheral/ $(git grep -l SSISlave)
$ sed -i s/SSI_SLAVE
To make the next commit easier to review, clean this code first.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/ssi/ssi.h | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/include/hw/ssi/ssi.h b/include/hw/ssi/ssi.h
index fe3028c39dc..c15548425a3 100644
-
On 10/11/20 10:28 PM, Stefan Berger wrote:
On 10/11/20 3:32 PM, Philippe Mathieu-Daudé wrote:
The TPM TIS device uses IRQ #5 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philipp
In order to use inclusive terminology, rename SSI 'slave' as
'peripheral', following the resolution Paolo pointed in [*]:
https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/
Candidate to be merged via the ARM or Trivial trees.
[*] https://www.mail-archive.com/qemu-devel@nongnu.org/ms
From: Philippe Mathieu-Daudé
In order to use inclusive terminology, rename max_slaves
as max_peripherals.
Patch generated using:
$ sed -i s/slave/peripheral/ \
hw/ssi/aspeed_smc.c include/hw/ssi/aspeed_smc.h
One line in aspeed_smc_read() has been manually tweaked
to pass checkpatch.
Patchew URL:
https://patchew.org/QEMU/20201011203513.1621355-1-marcandre.lur...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201011203513.1621355-1-marcandre.lur...@redhat.com
Subject: [PoCv2 00/15] Rus
Hi
On Mon, Oct 12, 2020 at 12:35 AM wrote:
>
> From: Marc-André Lureau
>
> Always put osdep.h first, and remove redundant stdlib.h include.
>
> Signed-off-by: Marc-André Lureau
(ignore this patch, which was already sent earlier)
> ---
> migration/dirtyrate.c | 3 ++-
> tests/test-bitmap.c
From: Marc-André Lureau
Most likely, QEMU will want tighter control over the sources, rather
than relying on crates.io downloading, use a git submodule with all the
dependencies.
"cargo vendor" makes that simple.
Signed-off-by: Marc-André Lureau
---
.cargo/config| 5 +
.gitmod
On Sun, 11 Oct 2020 at 20:49, Philippe Mathieu-Daudé wrote:
>
> Use self-explicit WINDOW_COUNT definition instead of a magic value.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/pci-host/versatile.c | 28 ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
>
From: Marc-André Lureau
Use the "hostname" crate (https://github.com/svartalf/hostname)
(notice the wrong error message in our win32 implementation)
Signed-off-by: Marc-André Lureau
---
include/qemu/osdep.h | 10 --
qga/Cargo.toml | 1 +
qga/commands.c | 20 --
From: Marc-André Lureau
This is a rewrite of the C version (using the nix & winapi crates).
The main difference is that Rust doesn't let you mix const/mut logic,
the way transfer_vcpu in C does. The Rust version does introduce some
duplication, but is also more strict and can prevent mistakes.
From: Marc-André Lureau
Generate the C QAPI types in Rust, with a few common niceties to
Debug/Clone/Copy the Rust type.
An important question that remains unsolved to be usable with the QEMU
schema in this version, is the handling of the 'if' compilation
conditions. Since the 'if' value is a C
From: Marc-André Lureau
Add a macro to help wrapping higher-level qmp handlers, by taking care
of errors and return value pointer translation.
Signed-off-by: Marc-André Lureau
---
qga/lib.rs | 1 +
qga/qmp/mod.rs | 36
2 files changed, 37 insertions(+)
From: Marc-André Lureau
Generate high-level idiomatic Rust code for the QAPI types, with to/from
translations for C FFI.
- no conditional support yet
- C FFI types are mapped to higher-level types (char*->String,
Foo*->Foo, has_foo/foo->Option etc)
- C enums are simply aliased
- C structure
From: Marc-André Lureau
This crates provides common bindings and facilities for QEMU C API
shared by various projects.
Most importantly, it defines the conversion traits used to convert from
C to Rust types. Those traits are largely adapted from glib-rs, since
those have prooven to be very flexi
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
.travis.yml | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 1054ec5d29..b2835316bc 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -23,6 +23,8 @@ addons:
apt:
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
qga/lib.rs | 1 +
qga/meson.build | 1 +
qga/qapi.rs | 6 ++
3 files changed, 8 insertions(+)
create mode 100644 qga/qapi.rs
diff --git a/qga/lib.rs b/qga/lib.rs
index 050a47e2a3..bff4107569 100644
--- a/qga/lib.rs
+++
From: Marc-André Lureau
Introduce a script to help calling cargo from Rust.
Cargo is the most convenient way to build Rust code, with various
crates, and has many features that meson lacks in general for Rust.
Trying to convert projects to meson automatically is an option I
considered (see for e
From: Marc-André Lureau
Meson doesn't integrate very smoothly with Cargo. Use the cargo-wrapper
script as a custom_target() always stale to build the Rust code. The
"build-lib" command will produce a static library in the meson expected
output directory, as well as link flags that must be employe
From: Marc-André Lureau
Add the build-sys infrastructure to build Rust code. Introduce a
top-level workspace, so various sub-projects (libraries, executables
etc) can be developed together, sharing the dependencies and output
directory.
If not Tier 1, many of the platforms QEMU supports are cons
From: Marc-André Lureau
Use qapi-gen to generate low-level C sys bindings for QAPI types,
include them to the build.
Signed-off-by: Marc-André Lureau
---
qga/Cargo.toml | 4
qga/lib.rs | 1 +
qga/meson.build | 11 +++
qga/qapi_sys.rs | 5 +
4 files changed, 21 inserti
From: Marc-André Lureau
As it should be, since the argument isn't owned by the callee,
but a lot of code in QEMU rely on non-const arguments to tweak it.
Since Rust types / bindings are derived from the C version, we have to
be more accurate there to do correct ownership conversions.
Signed-off
From: Marc-André Lureau
Always put osdep.h first, and remove redundant stdlib.h include.
Signed-off-by: Marc-André Lureau
---
migration/dirtyrate.c | 3 ++-
tests/test-bitmap.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
From: Marc-André Lureau
Hi,
Among the QEMU developers, there is a desire to use Rust. (see previous
thread from Stefan "Why QEMU should move from C to Rust", the rust-vmm
related projects and other experiments).
Thanks to our QAPI type system and the associate code generator, it is
relatively s
On 10/11/20 3:32 PM, Philippe Mathieu-Daudé wrote:
The TPM TIS device uses IRQ #5 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h
Commit 0b09be2b2f ("Nicer debug output for exceptions") added
twice the same "Tag Overflow" entry, remove the extra one.
Signed-off-by: Philippe Mathieu-Daudé
---
target/sparc/int32_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helpe
Use self-explicit NANOSECONDS_PER_SECOND definition instead
of a magic value.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/rtc-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/rtc-test.c b/tests/qtest/rtc-test.c
index c7af34f6b1b..402ce2c6090 100644
Use self-explicit WINDOW_COUNT definition instead of a magic value.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/pci-host/versatile.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c
index b495102
Replace the magic '4' by ARRAY_SIZE(mem->alias) which is more explicit.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/pci-host/pam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/pam.c b/hw/pci-host/pam.c
index a4962057833..4712260025a 100644
--- a/hw/pci-host/pa
Signed-off-by: Philippe Mathieu-Daudé
---
hw/scsi/megasas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index e24c12d7eed..d57402c9b09 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -2384,8 +2384,8 @@ static void megasas
A bunch of trivial cleanups, replacing magic
values by definitions to make the code easier
to review.
Expected to be merged via qemu-trivial@.
Regards,
Phil.
Philippe Mathieu-Daudé (4):
hw: Replace magic value by PCI_NUM_PINS definition
hw/pci-host/pam: Use ARRAY_SIZE() instead of magic val
Use self-explicit PCI_NUM_PINS definition instead of magic value.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/virt.c | 4 ++--
hw/mips/gt64xxx_pci.c | 2 +-
hw/pci-host/versatile.c | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/
The network devices use IRQ #9 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
hw/net/ne2000-isa.c | 2 +-
2 files changed, 2
The IDE controller uses IRQ #14 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
hw/ide/isa.c | 2 +-
2 files changed,
The first serial port uses IRQ #4 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
hw/sparc64/sun4u.c | 2 +-
2 files changed
The floppy disk controller uses IRQ #6 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
hw/block/fdc.c | 4 ++--
hw/sparc
The PS2 mouse uses IRQ #12 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
hw/input/pckbd.c | 2 +-
hw/sparc64/sun4u.c |
The parallel port uses IRQ #7 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
hw/char/parallel.c | 2 +-
hw/sparc64/sun4u.c
We are going to list all default ISA IRQs. As all the definitions
are related, introduce the IsaIrqNumber type to enumerate them.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/hw/isa/isa.h b/include/h
The TPM TIS device uses IRQ #5 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
hw/i386/acpi-build.c | 2 +-
hw/ipmi/isa_ip
The RTC time keep clock ses IRQ #8 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
include/hw/rtc/mc146818rtc.h | 1 -
The PS2 keyboard uses IRQ #1 by default. Add this
default definition to the IsaIrqNumber enum.
Avoid magic values in the code, replace them by the
newly introduced definition.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/isa/isa.h | 1 +
hw/sparc64/sun4u.c | 2 +-
2 files changed, 2 i
Replace various magic values by definitions to make
the code easier to read.
This probably makes sense to merge this series via
the 'PC chipset' tree, rather than qemu-trivial@.
Regards,
Phil.
Philippe Mathieu-Daudé (10):
hw/isa: Introduce IsaIrqNumber enum
hw/isa: Add the ISA_IRQ_KBD_DEFAU
The Grackle PCI host model expects the interrupt controller
being set, but does not verify it is present. Add a check to
help developers using this model.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/pci-host/grackle.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/pci-host/grackle.c
On Fri, 9 Oct 2020 at 20:35, Stefan Hajnoczi wrote:
>
> The following changes since commit 497d415d76b9f59fcae27f22df1ca2c3fa4df64e:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20201008-1' into staging (2020-10-08
> 21:41:20 +0100)
>
> are available in the Git rep
On Thu, 8 Oct 2020 at 20:13, Dr. David Alan Gilbert (git)
wrote:
>
> From: "Dr. David Alan Gilbert"
>
> The following changes since commit e64cf4d569f6461d6b9072e00d6e78d0ab8bd4a7:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20201008' into
> staging (2020-10-08 17:18:46 +0100)
On 18:18 Sat 10 Oct , Philippe Mathieu-Daudé wrote:
> On 10/10/20 3:57 PM, Luc Michel wrote:
> > Those reset values have been extracted from a Raspberry Pi 3 model B
> > v1.2, using the 2020-08-20 version of raspios. The dump was done using
> > the debugfs interface of the CPRMAN driver in Linu
On Sun, 11 Oct 2020 at 14:52, Bihong Yu wrote:
> @@ -998,7 +998,7 @@ static int block_load(QEMUFile *f, void *opaque, int
> version_id)
> (addr == 100) ? '\n' : '\r');
> fflush(stdout);
> } else if (!(flags & BLK_MIG_FLAG_EOS)) {
> -fprintf(st
On Fri, 9 Oct 2020 at 17:31, Alex Bennée wrote:
>
> The following changes since commit 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.2-20201009'
> into staging (2020-10-09 15:48:04 +0100)
>
> are available in the Git repository at:
>
On 201008 0939, Paolo Bonzini wrote:
> On 21/09/20 04:24, Alexander Bulekov wrote:
> > This patch declares the fuzz_dma_read_cb function and uses the
> > preprocessor and linker(weak symbols) to handle these cases:
> >
> > When we build softmmu/all with --enable-fuzzing, there should be no
> > str
On 201008 0903, Paolo Bonzini wrote:
> On 21/09/20 16:34, Alexander Bulekov wrote:
> >> Can you fuzz writing "FUZZ" in memory? Like:
> >> OP_WRITE(0x10, "UsingLibFUZZerString")?
> > No.. Hopefully that's not a huge problem.
> >
>
> Instead of always looking for a separator, can you:
>
> 1) s
Patchew URL:
https://patchew.org/QEMU/1602413863-19513-1-git-send-email-yubih...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1602413863-19513-1-git-send-email-yubih...@huawei.com
Subject: [PATCH v1 0/8]
Patchew URL:
https://patchew.org/QEMU/1602413321-22252-1-git-send-email-yubih...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1602413321-22252-1-git-send-email-yubih...@huawei.com
Subject: [PATCH v1 0/8]
Hi Maxim,
Thanks much for your reply.
On Sun, Oct 11, 2020 at 3:29 AM Maxim Levitsky wrote:
>
> On Sun, 2020-10-11 at 01:26 -0400, harry harry wrote:
> > Hi QEMU/KVM developers,
> >
> > I am sorry if my email disturbs you. I did an experiment and found the
> > guest physical addresses (GPAs) are
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/ram.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 90b277b..12e7296 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -101,14 +101,16
Patchew URL:
https://patchew.org/QEMU/1602411429-12043-1-git-send-email-yubih...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1602411429-12043-1-git-send-email-yubih...@huawei.com
Subject: [PATCH v1 0/8]
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/migration.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/migration.h b/migration/migration.h
index deb411a..99784b4 100644
--- a/migration/migration.h
+++ b/migration/migra
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/ram.c| 2 +-
migration/savevm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 12e7296..f71ff2b 100644
--- a/migration/ram.c
+++ b/migratio
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/block.c | 2 +-
migration/ram.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 4b8576b..399dfb8 100644
--- a/migration/block.c
+++ b/mi
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/migration.c| 4 ++--
migration/postcopy-ram.c | 2 +-
migration/ram.c | 2 +-
migration/savevm.c | 2 +-
migration/vmstate.c | 10 +-
5 files changed, 10 insertions(+), 10
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/block.c | 2 +-
migration/rdma.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 737b649..4b8576b 100644
--- a/migration/block.c
+++ b/migr
Recently I am reading migration related code, find some style problems in
migration directory while using checkpatch.pl to check migration code. Fix the
error style problems.
Bihong Yu (8):
migration: Do not use C99 // comments
migration: Don't use '#' flag of printf format
migration: Add sp
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/ram.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 90b277b..12e7296 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -101,14 +101,16
Recently I am reading migration related code, find some style problems in
migration directory while using checkpatch.pl to check migration code. Fix the
error style problems.
Bihong Yu (8):
migration: Do not use C99 // comments
migration: Don't use '#' flag of printf format
migration: Add sp
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/ram.c| 2 +-
migration/savevm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 12e7296..f71ff2b 100644
--- a/migration/ram.c
+++ b/migratio
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index ca4d315..00eac34 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -855,7 +855,7 @@
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/rdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 0eb42b7..ca4d315 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -273,7 +273,8 @
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/migration.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/migration.h b/migration/migration.h
index deb411a..99784b4 100644
--- a/migration/migration.h
+++ b/migration/migra
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/block.c | 2 +-
migration/rdma.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 737b649..4b8576b 100644
--- a/migration/block.c
+++ b/migr
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/migration.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/migration.h b/migration/migration.h
index deb411a..99784b4 100644
--- a/migration/migration.h
+++ b/migration/migra
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/block.c | 2 +-
migration/ram.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 4b8576b..399dfb8 100644
--- a/migration/block.c
+++ b/mi
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/block.c | 2 +-
migration/rdma.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 737b649..4b8576b 100644
--- a/migration/block.c
+++ b/migr
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/block.c | 2 +-
migration/ram.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 4b8576b..399dfb8 100644
--- a/migration/block.c
+++ b/mi
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/rdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 0eb42b7..ca4d315 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -273,7 +273,8 @
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index ca4d315..00eac34 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -855,7 +855,7 @@
Recently I am reading migration related code, find some style problems in
migration directory while using checkpatch.pl to check migration code. Fix the
error style problems.
Bihong Yu (8):
migration: Do not use C99 // comments
migration: Don't use '#' flag of printf format
migration: Add sp
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index ca4d315..00eac34 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -855,7 +855,7 @@
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/ram.c| 2 +-
migration/savevm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 12e7296..f71ff2b 100644
--- a/migration/ram.c
+++ b/migratio
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/ram.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 90b277b..12e7296 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -101,14 +101,16
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/migration.c| 4 ++--
migration/postcopy-ram.c | 2 +-
migration/ram.c | 2 +-
migration/savevm.c | 2 +-
migration/vmstate.c | 10 +-
5 files changed, 10 insertions(+), 10
Signed-off-by:Bihong Yu
Reviewed-by: Chuan Zheng
Signed-off-by: Bihong Yu
---
migration/migration.c| 4 ++--
migration/postcopy-ram.c | 2 +-
migration/ram.c | 2 +-
migration/savevm.c | 2 +-
migration/vmstate.c | 10 +-
5 files changed, 10 insertions(+), 10
1 - 100 of 119 matches
Mail list logo
