On 16/09/2020 20.25, Eduardo Habkost wrote:
> One of the goals of having less boilerplate on QOM declarations
> is to avoid human error. Requiring an extra argument that is
> never used is an opportunity for mistakes.
>
> Remove the unused argument from OBJECT_DECLARE_TYPE and
> OBJECT_DECLARE_SI
On Thu, Sep 17, 2020 at 11:46 AM Igor Mammedov wrote:
>
> On Wed, 16 Sep 2020 13:49:08 +0530
> Ani Sinha wrote:
>
> > When acpi hotplug is turned off for both root pci bus as well as for pci
> > bridges, we should not generate the related acpi code for DSDT table or
> > initialize related hw port
On 9/17/20 2:55 AM, Joel Stanley wrote:
> On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote:
>>
>> Hi Philippe,
>>
>>
>>
>> We are looking to add eMMC support, I searched the mailing list and found a
>> series posted on eMMC by “Vincent Palatin”
>>
>> https://lists.gnu.org/archive/html/qemu-dev
On 16/09/2020 19.19, Thomas Huth wrote:
> GCC 9.3.0 on Ubuntu complains:
>
> In file included from /usr/include/string.h:495,
> from /home/travis/build/huth/qemu/include/qemu/osdep.h:87,
> from ../migration/global_state.c:13:
> In function ‘strncpy’,
> inlined
On Wed, 16 Sep 2020 13:48:59 +0530
Ani Sinha wrote:
> In v5, I have tried to address all the latest review comments in commit logs
> and in patches. Also added "Reviewed-by" and "Acked-by" tags when a particular
> patch was already reviewed.
points that weren't addressed in this version across w
Hi all,
We try to add DSP architecure to QEMU 4.2. To load the
COFF format object file, we have added loader code to load content from
the object file. The rom_add_blob() function is used. We firstly
analyze the COFF file to figure out which sections are chained
together(so each cha
From: Marc-André Lureau
Note that for consistency, we use the same logic as MonitorsConfig to
figure out the associated monitor. However, I can't find traces of the
discussion/patches about the "new spice-server" behaviour: it still uses
the multiple-configurations path in git master.
Signed-off
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
hw/display/virtio-gpu-base.c | 2 ++
hw/display/virtio-gpu.c| 2 ++
include/hw/virtio/virtio-gpu.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c
index aeb87
From: Marc-André Lureau
The following patch is going to introduce extra fields / details to
UIInfo. Add a getter and keep the current values, instead of memset(0)
Signed-off-by: Marc-André Lureau
---
include/ui/console.h | 1 +
ui/console.c | 7 +++
ui/spice-display.c | 2 +-
3 f
From: Marc-André Lureau
Replace dpi with width_mm/height_mm in qemu_edid_info.
Use it when set (non-zero) to compute the DPI and generate the EDID.
Signed-off-by: Marc-André Lureau
---
hw/display/edid-generate.c | 36 +---
include/hw/display/edid.h | 5 -
From: Marc-André Lureau
Hi,
This series improves the support for HiDPI displays with Spice.
The related spice series have already been merged.
Marc-André Lureau (5):
edid: fix physical display size computation
edid: use physical dimensions if available
ui: add getter for UIInfo
spice: g
From: Marc-André Lureau
Divide the resolution by the DPI, and multiply to mm.
Note the computation done for edid[21/22] is correct (in cm).
Signed-off-by: Marc-André Lureau
---
hw/display/edid-generate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/edid-g
On Wed, 16 Sep 2020 13:49:10 +0530
Ani Sinha wrote:
> This change adds a new DSDT golden master table blob to test disabling
> hotplug on both pci root bus and pci bridges. Also reverts the change
> in file bios-tables-test-allowed-diff.h to make sure its now empty so that
> future modifications
On Wed, 16 Sep 2020 13:49:09 +0530
Ani Sinha wrote:
> This change adds a unit test to exercise the case when hotplug is disabled
> both for
> pci root bus and the pci bridges by passing the following two switches to
> qemu:
>
> -global PIIX4_PM.acpi-root-pci-hotplug=off
> -global PIIX4_PM.
On Wed, 16 Sep 2020 13:49:08 +0530
Ani Sinha wrote:
> When acpi hotplug is turned off for both root pci bus as well as for pci
> bridges, we should not generate the related acpi code for DSDT table or
> initialize related hw ports or reserve hw resources. This change makes
> sure all those operat
Hi all,
We try to add DSP architecure to QEMU 4.2. To load the
COFF format object file, we have added loader code to load content from
the object file. The rom_add_blob() function is used. We firstly analyze
the COFF file to figure out which sections are chained
together(so each chain
On Wed, 16 Sep 2020 13:49:05 +0530
Ani Sinha wrote:
> The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file
> for
> testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under
> i440fx.
> This change documents this fact.
>
> Signed-off-by: Ani Sinha
Revi
On Wed, 16 Sep 2020 13:49:00 +0530
Ani Sinha wrote:
> A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to
> unit test
> the feature flag that can disable/enable root pci bus hotplug on i440fx. This
> feature was
> added with the commit:
> 3d7e78aaf0 ("Introduce a new
On Wed, 16 Sep 2020 21:14:36 +0200
Julia Suvorova wrote:
> On Wed, Sep 16, 2020 at 8:03 PM Julia Suvorova wrote:
> >
> > On Fri, Aug 21, 2020 at 2:13 PM Igor Mammedov wrote:
> > >
> > > On Tue, 18 Aug 2020 23:52:26 +0200
> > > Julia Suvorova wrote:
> > >
> > > > Other methods may be used i
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1603970
Title:
KVM freezes
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1629483
Title:
Build fails
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1852781
Title:
qemu s390x
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1816805
Title:
Cannot crea
[Expired for Ubuntu on IBM z Systems because there has been no activity
for 60 days.]
** Changed in: ubuntu-z-systems
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bug
Patchew URL:
https://patchew.org/QEMU/20200917035413.701-1-zhaolich...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
http://patchew.org/logs/20200917035413
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the docs folder.
Signed-off-by: zhaolichang
Reviewed-by: Peter Maydell
---
docs/COLO-FT.txt | 6 +++---
docs/
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the contrib folder.
Signed-off-by: zhaolichang
Reviewed-by: Alex Bennée
---
contrib/gitdm/filetypes.txt | 6 +++--
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the linux-user folder.
Signed-off-by: zhaolichang
Reviewed-by: Alex Bennée
---
linux-user/aarch64/signal.c | 2 +
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the migration folder.
Signed-off-by: zhaolichang
Reviewed-by: Peter Maydell
---
migration/colo-failover.c | 2 +-
migration/
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the disas folder.
Signed-off-by: zhaolichang
---
disas/hppa.c | 2 +-
disas/m68k.c | 8
disas/ppc.c | 2 +-
3 files
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the folder.
Signed-off-by: zhaolichang
Reviewed-by: Alex Bennée
---
Changelog | 2 +-
accel/tcg/user-exec.c
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the block folder.
Signed-off-by: zhaolichang
---
block/block-copy.c | 2 +-
block/linux-aio.c | 2 +-
block/mirror.c | 2
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the qapi folder.
Signed-off-by: zhaolichang
Reviewed-by: Markus Armbruster
---
qapi/block-core.json | 4 ++--
qapi/crypto.jso
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the util folder.
Signed-off-by: zhaolichang
Reviewed-by: Alex Bennée
---
util/osdep.c | 2 +-
util/qemu-progress.
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors, this series fixed
this
spelling errors.
v1 -> v2:
address Peter Maydell's comments
address Alex Benn¨¦e's comments
add reviewed-by for patch 1,2,3,4,5,6,9,10
zha
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the scripts folder.
Signed-off-by: zhaolichang
Reviewed-by: Peter Maydell
---
scripts/checkpatch.pl | 2 +-
scripts/
A helper struct AcpiCacheOffset is introduced to describe the offset
of three level caches. The cache hierarchy is built according to
ACPI spec v6.3 5.2.29.2. Let's enable CPU cache topology now.
Signed-off-by: Ying Fang
Signed-off-by: Henglong Fan
---
hw/acpi/aml-build.c | 19 +
To build cache information, An AcpiCacheInfo structure is defined to
hold the Type 1 cache structure according to ACPI spec v6.3 5.2.29.2.
A helper function build_cache_hierarchy is introduced to encode the
cache information.
Signed-off-by: Ying Fang
---
hw/acpi/aml-build.c | 26
Support devicetree CPU cache information descriptions
Signed-off-by: Ying Fang
---
hw/arm/virt.c | 91 +++
1 file changed, 91 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 71f7dbb317..74b748ae35 100644
--- a/hw/arm/virt.c
+++ b/hw
Add the Processor Properties Topology Table (PPTT) to present CPU topology
information to the guest.
Signed-off-by: Andrew Jones
Signed-off-by: Ying Fang
---
hw/arm/virt-acpi-build.c | 42
1 file changed, 42 insertions(+)
diff --git a/hw/arm/virt-acpi-b
An accurate cpu topology may help improve the cpu scheduler's decision
making when dealing with multi-core system. So cpu topology description
is helpful to provide guest with the right view. Cpu cache information may
also have slight impact on the sched domain, and even userspace software
may chec
Add the processor hierarchy node structures to build ACPI information
for CPU topology. Three helpers are introduced:
(1) build_socket_hierarchy for socket description structure
(2) build_processor_hierarchy for processor description structure
(3) build_smt_hierarchy for thread (logic processor) d
When building ACPI tables regarding CPUs we should always build
them for the number of possible CPUs, not the number of present
CPUs. We then ensure only the present CPUs are enabled.
Signed-off-by: Andrew Jones
Signed-off-by: Ying Fang
---
hw/arm/virt-acpi-build.c | 17 -
1 fil
Signed-off-by: Ying Fang
---
linux-headers/linux/kvm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
index a28c366737..461a2302e7 100644
--- a/linux-headers/linux/kvm.h
+++ b/linux-headers/linux/kvm.h
@@ -1031,6 +1031,7 @@ struct kvm_
Add the CPUCacheInfo structure to hold CPU cache information for ARM cpus.
A classic three level cache topology is used here. The default cache
capacity is given and userspace can overwrite these values.
Signed-off-by: Ying Fang
---
target/arm/cpu.c | 42 +
From: Andrew Jones
qemu_fdt_add_path works like qemu_fdt_add_subnode, except it
also recursively adds any missing parent nodes.
Cc: Peter Crosthwaite
Cc: Alexander Graf
Signed-off-by: Andrew Jones
---
device_tree.c| 24
include/sysemu/device_tree.h |
From: Andrew Jones
Support devicetree CPU topology descriptions.
Signed-off-by: Andrew Jones
---
hw/arm/virt.c | 37 -
include/hw/arm/virt.h | 1 +
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index ac
MPIDR helps to provide an additional PE identification in a multiprocessor
system. This patch adds support for setting MPIDR from userspace, so that
MPIDR is consistent with CPU topology configured.
Signed-off-by: Ying Fang
---
target/arm/kvm64.c | 46 ++--
MPIDR helps to provide an additional PE identification in a multiprocessor
system. This patch adds support for setting MPIDR from userspace, so that
MPIDR is consistent with CPU topology configured.
Signed-off-by: Ying Fang
---
target/arm/kvm32.c | 46 ++--
Mechanical search/replace to use the new
DECLARE_INTERFACE_CHECKER macro instead of manually defining
macros using INTERFACE_CHECK.
Acked-by: David Gibson
Signed-off-by: Eduardo Habkost
---
This is an alternative to the patches submitted at
https://lore.kernel.org/qemu-devel/20200916193101.51160
The new macro will be similar to DECLARE_INSTANCE_CHECKER,
but for interface types (that use INTEFACE_CHECK instead of
OBJECT_CHECK).
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: none
---
Cc: Paolo Bonzini
Cc: "Daniel P. Berrangé"
Cc: Eduardo Habkost
Cc: qemu-devel@nongnu.org
--
This is an alternative to the series:
Subject: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK
https://lore.kernel.org/qemu-devel/20200916193101.511600-1-ehabk...@redhat.com/
Instead of removing INTERFACE_CHECK completely, keep it but use a
DECLARE_INTERFACE_CHECKER macro to define
On Thu, Sep 17, 2020 at 10:44:34AM +1000, David Gibson wrote:
[...]
> > diff --git a/include/hw/acpi/acpi_dev_interface.h
> > b/include/hw/acpi/acpi_dev_interface.h
> > index 9adf1e4706..96aa63919a 100644
> > --- a/include/hw/acpi/acpi_dev_interface.h
> > +++ b/include/hw/acpi/acpi_dev_interface.h
On Wed, Sep 16, 2020 at 06:32:58PM -0400, Eduardo Habkost wrote:
> Mechanical search/replace to use the new
> DECLARE_INTERFACE_CHECKER macro instead of manually defining
> macros using INTERFACE_CHECK.
>
> Signed-off-by: Eduardo Habkost
ppc parts
Acked-by: David Gibson
> ---
> This is an alte
On Wed, Sep 16, 2020 at 12:49:38PM +1000, David Gibson wrote:
> On Mon, Sep 14, 2020 at 02:34:50PM +0200, Greg Kurz wrote:
> > Yet another round of sanitizing the error handling in spapr. I've
> > identified locations that needed fixing with the errp-guard.cocci
> > coccinelle script. It turns out
On Tue, Sep 15, 2020 at 03:53:52PM +0200, Greg Kurz wrote:
> On Tue, 15 Sep 2020 15:08:05 +0200
> Philippe Mathieu-Daudé wrote:
>
> > On 9/14/20 2:35 PM, Greg Kurz wrote:
> > > As recommended in "qapi/error.h", return true on success and false on
> > > failure. This allows to reduce error propaga
On Tue, Sep 15, 2020 at 01:43:40PM +0200, Greg Kurz wrote:
> On Tue, 15 Sep 2020 13:58:53 +0300
> Vladimir Sementsov-Ogievskiy wrote:
>
> > 14.09.2020 15:35, Greg Kurz wrote:
> > > As recommended in "qapi/error.h", add a bool return value to
> > > spapr_add_lmbs() and spapr_add_nvdimm(), and use
> On Fri, Sep 04, 2020 at 04:35:34PM +0100, Alex Bennée wrote:
>> Given our growing reliance on GitLab and the recent announcement about
>> free tier minutes:
>>
>> https://about.gitlab.com/pricing/faq-consumption-cicd/
>>
>> is it time we officially apply for GitLab's Open Source Program:
>>
On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote:
>
> Hi Philippe,
>
>
>
> We are looking to add eMMC support, I searched the mailing list and found a
> series posted on eMMC by “Vincent Palatin”
>
> https://lists.gnu.org/archive/html/qemu-devel/2011-07/msg02833.html
I would be interested in
On Wed, 16 Sep 2020, 15:48 Philippe Mathieu-Daudé,
wrote:
> On 9/4/20 5:44 PM, Philippe Mathieu-Daudé wrote:
> > Salvaging cleanups patches from the RFC series "Forbid DMA write
> > accesses to MMIO regions" [*], propagating MemTxResult and
> > adding documentation.
> >
> > Philippe Mathieu-Daudé
Mechanical search/replace to use the new
DECLARE_INTERFACE_CHECKER macro instead of manually defining
macros using INTERFACE_CHECK.
Signed-off-by: Eduardo Habkost
---
This is an alternative to the patches submitted at
https://lore.kernel.org/qemu-devel/20200916193101.511600-3-ehabk...@redhat.com/
This is an alternative to the series:
Subject: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK
https://lore.kernel.org/qemu-devel/20200916193101.511600-1-ehabk...@redhat.com/
Instead of removing INTERFACE_CHECK completely, keep it but use a
DECLARE_INTERFACE_CHECKER macro to define
On 9/15/20 6:39 PM, John Snow wrote:
Hi, this series starts adding static type hints to the QAPI module. As
you can see, the series started getting quite a bit long, so this is
only a partial conversion that focuses on a handful of the easier files.
Updated series with current feedback and pus
The new macro will be similar to DECLARE_INSTANCE_CHECKER,
but for interface types (that use INTEFACE_CHECK instead of
OBJECT_CHECK).
Signed-off-by: Eduardo Habkost
---
Cc: Paolo Bonzini
Cc: "Daniel P. Berrangé"
Cc: Eduardo Habkost
Cc: qemu-devel@nongnu.org
---
include/qom/object.h | 14 +
On 9/16/20 11:13 AM, Markus Armbruster wrote:
John Snow writes:
Code style tools really dislike the use of global keywords, because it
generally involves re-binding the name at runtime which can have strange
effects depending on when and how that global name is referenced in
other modules.
Ma
On Thu, Sep 17, 2020 at 01:31:50AM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Sep 16, 2020 at 11:35 PM Eduardo Habkost
> wrote:
>
> > This series replaces INTERFACE_CHECK with OBJECT_CHECK because
> > both macros are exactly the same.
> >
> > The last patch is a new run of the OBJECT_CHECK
On Mon, Sep 14, 2020 at 09:23:42PM -0400, Raphael Norwitz wrote:
> On Fri, Sep 11, 2020 at 4:43 AM Dima Stepanov wrote:
> >
> > Add support for the vhost-user-blk-pci device. This node can be used by
> > the vhost-user-blk tests. Tests for the vhost-user-blk device are added
> > in the following p
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Host Memory : 15.49 GB
Start Time (UTC) : 2020-09-16 21:35:02
End Time (UTC) : 2020-09-16 22:07:32
Execution Time : 0:32:29.941492
Status : SUCCESS
Note:
Changes denoted by '-' are less than 0.01%.
-
Hi
On Wed, Sep 16, 2020 at 11:35 PM Eduardo Habkost
wrote:
> This series replaces INTERFACE_CHECK with OBJECT_CHECK because
> both macros are exactly the same.
>
> The last patch is a new run of the OBJECT_CHECK ->
> DECLARE*_CHECKER* converter script that will convert the former
> INTERFACE_CHE
Public bug reported:
Currently, I am looking for a method of attaching an sd-card to a
specific bus as opposed to defaulting to the first.
QEMU Version: 5.0.0
Specifically trying to use qemu-system-arm binary
Running an "info qtree" shows the output seen in the attached image. I have
attempted
On Wed, Sep 16, 2020 at 2:09 PM Andreas K. Hüttel wrote:
>
> > My guess is that somewhere in QEMU the types don't match what RV32 is
> > using. It's probably worth printing out the size, alignment and value
> > of everything at every stage and see what breaks.
>
> Thanks.
Sorry I can't be more he
> My guess is that somewhere in QEMU the types don't match what RV32 is
> using. It's probably worth printing out the size, alignment and value
> of everything at every stage and see what breaks.
Thanks.
> AFAIK RV32 linux-user mode is pretty much un-tested. So their might be
> all sorts of issue
To avoid multiple endianess conversion, as we know the device
registers are in little-endian, directly use const_le32() with
constant values.
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/
In commit e5ff22ba9fc we changed the doorbells register
declaration but forgot to mark the structure packed (as
MMIO registers), allowing the compiler to optimize it.
Fix by marking it packed, and align it to avoid:
block/nvme.c: In function ‘nvme_create_queue_pair’:
block/nvme.c:252:22: error
Fix a compiler optimization problem introduced in commit
e5ff22ba9fc ("block/nvme: Pair doorbell registers"),
use atomic operations.
For some not understood yet reason using atomic_and triggers
a NMI on x86 arch. Using the following snippet on top of this
series:
-- >8 --
-atomic_set(&s->regs
Follow docs/devel/atomics.rst guidelines and use atomic operations.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Dr. David Alan Gilbert
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 38 --
1 file changed, 20 insertions(+), 18 deletions(-)
diff --
On 9/16/20 4:23 AM, Laszlo Ersek wrote:
> Hi Tom,
Hi Laszlo,
>
> sorry for the random feedback -- I haven't followed (and don't really
> intend to follow) the QEMU side of the feature. Just one style idea:
>
> On 09/15/20 23:29, Tom Lendacky wrote:
>> From: Tom Lendacky
>>
>> When SEV-ES is en
Note that the "real" support is reported. A configuration like
--disable-system --enable-kvm will report "no" for "KVM support" because
no KVM-supported target is being compiled.
Reported-by: Andrew Jones
Signed-off-by: Paolo Bonzini
---
meson.build | 35 ---
1
INTERFACE_CHECK and OBJECT_CHECK do exactly the same. There's no
need to have two different methods for declaring the type checker
macro for interface types.
Signed-off-by: Eduardo Habkost
---
Cc: "Michael S. Tsirkin"
Cc: Igor Mammedov
Cc: Corey Minyard
Cc: "Cédric Le Goater"
Cc: David Gibso
object_class_dynamic_cast_assert() is not used by
INTERFACE_CHECK, remove misleading mention of that function in
the documentation.
Signed-off-by: Eduardo Habkost
---
Cc: Paolo Bonzini
Cc: "Daniel P. Berrangé"
Cc: Eduardo Habkost
Cc: qemu-devel@nongnu.org
---
include/qom/object.h | 2 +-
1 fi
This series replaces INTERFACE_CHECK with OBJECT_CHECK because
both macros are exactly the same.
The last patch is a new run of the OBJECT_CHECK ->
DECLARE*_CHECKER* converter script that will convert the former
INTERFACE_CHECK-based macros.
Eduardo Habkost (3):
qom: Correct object_class_dynami
New round of conversion of type checking macros to
DECLARE_*CHECKER, in the files that were previously using
INTERFACE_CHECK.
Genereated using:
$ ./scripts/codeconverter/converter.py --passes=3 -i \
--pattern=QOMStructTypedefSplit,MoveSymbols,TypeCheckMacro \
include/hw/acpi/acpi_dev_int
On Fri, Aug 21, 2020 at 2:24 PM Igor Mammedov wrote:
>
> On Tue, 18 Aug 2020 23:52:27 +0200
> Julia Suvorova wrote:
>
> > Add acpi_pcihp to ich9_pm and use ACPI PCI hot-plug by default.
>
> I don't see anything related to migrating hotplug state within series,
>
> see VMSTATE_PCI_HOTPLUG for exam
On Wed, Aug 19, 2020 at 5:21 AM Philippe Mathieu-Daudé
wrote:
>
> Hi Julia,
>
> On 8/18/20 11:52 PM, Julia Suvorova wrote:
> > Implement notifications and gpe to support q35 ACPI PCI hot-plug.
> > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports.
> >
> > Signed-off-by: Julia Suvorova
> > -
On Wed, Sep 16, 2020 at 8:03 PM Julia Suvorova wrote:
>
> On Fri, Aug 21, 2020 at 2:13 PM Igor Mammedov wrote:
> >
> > On Tue, 18 Aug 2020 23:52:26 +0200
> > Julia Suvorova wrote:
> >
> > > Other methods may be used if the system is capable of this and the _OSC
> > > bit
> > > is set. Disable t
On Fri, Aug 21, 2020 at 2:08 PM Igor Mammedov wrote:
>
> On Tue, 18 Aug 2020 23:52:25 +0200
> Julia Suvorova wrote:
>
> > Implement notifications and gpe to support q35 ACPI PCI hot-plug.
> > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports.
>
> in addition to comment from Philippe
>
>
> >
Hi Philippe,
We are looking to add eMMC support, I searched the mailing list and found a
series posted on eMMC by "Vincent Palatin"
https://lists.gnu.org/archive/html/qemu-devel/2011-07/msg02833.html
I would like to consider the above work and mix-up with more changes to start
adding support fo
I'm not documenting every single change in the codeconverter
script because most of that code will be deleted once we finish
the QOM code conversion. This patch updates the script to the
latest version that was used to perform changes in the QOM code.
Signed-off-by: Eduardo Habkost
---
.../code
The requirement to specify the parent class type makes the macro
harder to use and easy to misuse (silent bugs can be introduced
if the wrong struct type is specified).
Simplify the macro by just not declaring any class struct,
allowing us to remove the class_size field from the TypeInfo
variables
This converts existing DECLARE_OBJ_CHECKERS usage to
OBJECT_DECLARE_TYPE when possible.
$ ./scripts/codeconverter/converter.py -i \
--pattern=AddObjectDeclareType $(git grep -l '' -- '*.[ch]')
Signed-off-by: Eduardo Habkost
---
Cc: Peter Maydell
Cc: Andrzej Zaborowski
Cc: Alistair Francis
One of the goals of having less boilerplate on QOM declarations
is to avoid human error. Requiring an extra argument that is
never used is an opportunity for mistakes.
Remove the unused argument from OBJECT_DECLARE_TYPE and
OBJECT_DECLARE_SIMPLE_TYPE.
Coccinelle patch used to convert all users o
This converts many QOM types to use OBJECT_DECLARE* instead of
manually using DECLARE*_CHECKER*.
Before doing that, I'm simplifying the OBJECT_DECLARE* API to
make it easier to use and more difficult to misuse. The
module_obj_name and ParentClassType parameters were removed
because they are not n
hum i was hoping to indicate this affect focal in some what but not sure how to
do that but this issue
happens with the ubunutu 20.04 version of qemu 4.2
it does not seam to happen with the centos 8 build of the same qemu so i dont
know if there is a delta in packages or if its just a case that i
On Fri, Aug 21, 2020 at 2:13 PM Igor Mammedov wrote:
>
> On Tue, 18 Aug 2020 23:52:26 +0200
> Julia Suvorova wrote:
>
> > Other methods may be used if the system is capable of this and the _OSC bit
> > is set. Disable them explicitly to force ACPI PCI hot-plug use. The older
> > versions will sti
Update 'SCR.CMD_SUPPORT' register with support of CMD23.
Signed-off-by: Sai Pavan Boddu
Reported-by: Rahul Thati
---
Changes for V2:
Fix commit message
hw/sd/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 0012882..16d1b61 100644
-
On 9/16/20 12:19 PM, Thomas Huth wrote:
GCC 9.3.0 on Ubuntu complains:
In file included from /usr/include/string.h:495,
from /home/travis/build/huth/qemu/include/qemu/osdep.h:87,
from ../migration/global_state.c:13:
In function ‘strncpy’,
inlined from ‘gl
Update SCR.CMD_SUPPORT register with support of CMD23.
Signed-off-by: Sai Pavan Boddu
Reported-by: Rahul Thati
---
hw/sd/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 0012882..16d1b61 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -335,7 +33
+-- On Fri, 4 Sep 2020, P J P wrote --+
| From: Prasad J Pandit
|
| When cancelling an i/o operation via ide_cancel_dma_sync(),
| a block pointer may be null. Add check to avoid null pointer
| dereference.
|
| -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Fide_nullptr1
| ==1803
GCC 9.3.0 on Ubuntu complains:
In file included from /usr/include/string.h:495,
from /home/travis/build/huth/qemu/include/qemu/osdep.h:87,
from ../migration/global_state.c:13:
In function ‘strncpy’,
inlined from ‘global_state_store_running’ at
../migration/gl
Yes, or easier the "false" assignment can be moved out of the "if".
Paolo
Il mer 16 set 2020, 19:09 Thomas Huth ha scritto:
> On 16/09/2020 18.26, Paolo Bonzini wrote:
> > This is the first compiler/linker test that has been moved to Meson.
> > Add more section headings to keep things clearer.
1 - 100 of 428 matches
Mail list logo
