On Thu, Sep 17, 2020 at 01:31:50AM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Sep 16, 2020 at 11:35 PM Eduardo Habkost <ehabk...@redhat.com> > wrote: > > > This series replaces INTERFACE_CHECK with OBJECT_CHECK because > > both macros are exactly the same. > > > > The last patch is a new run of the OBJECT_CHECK -> > > DECLARE*_CHECKER* converter script that will convert the former > > INTERFACE_CHECK-based macros. > > > > > Well, at least having a different macro allows to tweak qom implementation > or replace it with something different more easily. > > I have some wip branch somewhere where I actually made Interface a > different beast than Object (it was saving some fields, and avoiding some > potentially wrong casts iirc - I didn't bother to upstream that yet). Also > I have a different branch where I played with GObject to replace qom. In > both cases, your proposal would have, or would make, the work more > complicated.
If there are expectations that the distinction will become useful, we can keep it by now. I will submit a different proposal to have a DECLARE_INTERFACE_CHECKER macro similar to DECLARE_INSTANCE_CHECKER, followed by a OBJECT_DECLARE_INTERFACE_TYPE macro similar to OBJECT_DECLARE_TYPE. -- Eduardo
