On Fri, 11 Sep 2020 10:07:18 +1000
David Gibson wrote:
> On Thu, Sep 10, 2020 at 08:29:24PM +0200, Halil Pasic wrote:
> > On Thu, 10 Sep 2020 13:36:09 +0200
> > Cornelia Huck wrote:
> >
> > > On Mon, 7 Sep 2020 17:22:53 +0200
> > > Halil Pasic wrote:
> > >
> > > > On Fri, 24 Jul 2020 12:57:44
On Wed, 2020-09-09 at 14:15 -0400, Eduardo Habkost wrote:
> Hi,
>
> Thanks for the patch, and sorry for taking so long to review
> this. I'm finally getting to the patches that were postponed to
> 5.2.
>
> Comments and questions below:
>
> On Thu, Jun 11, 2020 at 10:47:55AM +0800, Robert Hoo wr
On Fri, 11 Sep 2020 07:30:37 +0200
Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Greg Kurz writes:
> >
> >> On Wed, 9 Sep 2020 21:59:23 +0300
> >> Vladimir Sementsov-Ogievskiy wrote:
> >>
> >>> It's simple to avoid error propagation in blk_log_writes_open(), we
> >>> just need t
> This problem occurs on CentOS-7.5 (64-bit) with qemu-5.1.0, qemu head
> > (commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a) for riscv32-linux-
> > user.
>
> I tried to build qemu-5.1 on CentOS-7.5.1 but as python 3.5 is not
> available, I gave up.
>
Thank you for your effort. I installed python3
Markus Armbruster writes:
> Greg Kurz writes:
>
>> On Wed, 9 Sep 2020 21:59:23 +0300
>> Vladimir Sementsov-Ogievskiy wrote:
>>
>>> It's simple to avoid error propagation in blk_log_writes_open(), we
>>> just need to refactor blk_log_writes_find_cur_log_sector() a bit.
>>>
>>> Signed-off-by: V
This adds two acceptance tests for the quanta-gsj machine.
One test downloads a lightly patched openbmc flash image from github and
verifies that it boots all the way to the login prompt.
The other test downloads a kernel, initrd and dtb built from the same
openbmc source and verifies that the ke
This allows these NPCM7xx-based boards to boot from a flash image, e.g.
one built with OpenBMC. For example like this:
IMAGE=${OPENBMC}/build/tmp/deploy/images/gsj/image-bmc
qemu-system-arm -machine quanta-gsj -nographic \
-drive file=${IMAGE},if=mtd,bus=0,unit=0,format=raw,snapshot=on
Re
This implements a device model for the NPCM7xx SPI flash controller.
Direct reads and writes, and user-mode transactions have been tested in
various modes. Protection features are not implemented yet.
All the FIU instances are available in the SoC's address space,
regardless of whether or not the
This supports reading and writing OTP fuses and keys. Only fuse reading
has been tested. Protection is not implemented.
Reviewed-by: Avi Fishman
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Tested-by: Alexander Bulekov
Signed-off-by: Havard Skinnemoen
---
include/hw/
Greg Kurz writes:
> On Wed, 9 Sep 2020 21:59:23 +0300
> Vladimir Sementsov-Ogievskiy wrote:
>
>> It's simple to avoid error propagation in blk_log_writes_open(), we
>> just need to refactor blk_log_writes_find_cur_log_sector() a bit.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
>>
This adds two new machines, both supported by OpenBMC:
- npcm750-evb: Nuvoton NPCM750 Evaluation Board.
- quanta-gsj: A board with a NPCM730 chip.
They rely on the NPCM7xx SoC device to do the heavy lifting. They are
almost completely identical at the moment, apart from the SoC type,
which cu
If a -bios option is specified on the command line, load the image into
the internal ROM memory region, which contains the first instructions
run by the CPU after reset.
If -bios is not specified, the vbootrom included with qemu is loaded by
default.
Reviewed-by: Tyrone Ting
Reviewed-by: Cédric
When booting directly into a kernel, bypassing the boot loader, the CPU and
UART clocks are not set up correctly. This makes the system appear very
slow, and causes the initrd boot test to fail when optimization is off.
The UART clock must run at 24 MHz. The default 25 MHz reference clock
cannot a
Reviewed-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Havard Skinnemoen
---
docs/system/arm/nuvoton.rst | 92 +
docs/system/target-arm.rst | 1 +
2 files changed, 93 insertions(+)
create mode 100644 docs/system/arm/nuvoton.rst
d
This just implements the bare minimum to cause the boot block to skip
memory initialization.
Reviewed-by: Tyrone Ting
Reviewed-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Tested-by: Alexander Bulekov
Signed-off-by: Havard Skinnemoen
---
include
The Nuvoton NPCM7xx SoC family are used to implement Baseboard
Management Controllers in servers. While the family includes four SoCs,
this patch implements limited support for two of them: NPCM730 (targeted
for Data Center applications) and NPCM750 (targeted for Enterprise
applications).
This pat
The NPCM730 and NPCM750 SoCs have three timer modules each holding five
timers and some shared registers (e.g. interrupt status).
Each timer runs at 25 MHz divided by a prescaler, and counts down from a
configurable initial value to zero. When zero is reached, the interrupt
flag for the timer is s
This is a minimalistic boot ROM written specifically for use with QEMU.
It supports loading the second-stage loader from SPI flash into RAM, SMP
boot, and not much else.
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Signed-off-by: Havard Skinnemoen
---
.gitmodules
This should be fully reviewed now, but the Timer patch may deserve another
look, as I fixed a few bugs in it. Huge thanks to everyone who reviewed and/or
tested this patchset, it has clearly improved a lot since I started.
I also pushed this and the previous patchsets to my qemu fork on github. T
Enough functionality to boot the Linux kernel has been implemented. This
includes:
- Correct power-on reset values so the various clock rates can be
accurately calculated.
- Clock enables stick around when written.
In addition, a best effort attempt to implement SECCNT and CNTR25M was
mad
Implement a device model for the System Global Control Registers in the
NPCM730 and NPCM750 BMC SoCs.
This is primarily used to enable SMP boot (the boot ROM spins reading
the SCRPAD register) and DDR memory initialization; other registers are
best effort for now.
The reset values of the MDLR and
Markus Armbruster writes:
> dubo...@gmail.com writes:
>
>> From: Josh DuBois
>>
>> Tracing can be enabled at the command line or via the
>> monitor. Command-line trace options are recorded during
>> trace_opt_parse(), but tracing is not enabled until the various
>> front-ends later call trace_in
On 10/09/2020 11.36, Collin Walling wrote:
> The start of the CPU entry region in the Read SCP Info response data is
> denoted by the offset_cpu field. As such, QEMU needs to begin creating
> entries at this address.
>
> This is in preparation for when Read SCP Info inevitably introduces new
> byt
The nested KVM code does not yet support HPT guests. Calling the
KVM_CAP_PPC_ALLOC_HTAB ioctl currently leads to KVM setting the guest
as HPT and erroneously executing code in L1 that should only run in
hypervisor mode, leading to an exception in the L1 vcpu thread when it
enters the nested guest.
On 26/08/2020 12.15, AlexChen wrote:
> From: AlexChen
>
> The 'kdgb' is allocating memory in get_kdbg(), but it is not freed
> in both fill_header() and fill_context() failed branches, fix it.
>
> Signed-off-by: AlexChen
> ---
> contrib/elf2dmp/main.c | 4 ++--
> 1 file changed, 2 insertions(+
On Mon, Sep 07, 2020 at 05:10:46PM +0200, Halil Pasic wrote:
> On Fri, 24 Jul 2020 12:57:43 +1000
> David Gibson wrote:
>
> > The default behaviour for virtio devices is not to use the platforms normal
> > DMA paths, but instead to use the fact that it's running in a hypervisor
> > to directly ac
Public bug reported:
If trying to run qemu with -vnc :0, it will fail with:
./qemu-system-x86_64 -vnc :2
qemu-system-x86_64: -vnc :2: could not read keymap file: 'en-us'
share/keymaps is missing en-us keymap and only has sl and sv, confirmed
previous stable versions had en-us.
Tried with multipl
>From 533ed02427bdaf0265f62fcb4f961854a41b7037 Mon Sep 17 00:00:00 2001
From: ZouXu
Date: Wed, 9 Sep 2020 21:59:13 +0800
Subject: [PATCH 1/1] accel/tcg/user-exec: support computing is_write for
mips32
Those MIPS32 instructions can cause store operation:
SB/SH/SW/SD/SWL/SWR/SDL/SDR/CACHE
SC/SCD/S
On Thu, Sep 10, 2020 at 12:02:44PM -0600, Alex Williamson wrote:
> On Thu, 10 Sep 2020 13:50:11 +0100
> Sean Mooney wrote:
>
> > On Thu, 2020-09-10 at 14:38 +0200, Cornelia Huck wrote:
> > > On Wed, 9 Sep 2020 10:13:09 +0800
> > > Yan Zhao wrote:
> > >
> > > > > > still, I'd like to put it mo
On Thu, Sep 10, 2020 at 08:29:24PM +0200, Halil Pasic wrote:
> On Thu, 10 Sep 2020 13:36:09 +0200
> Cornelia Huck wrote:
>
> > On Mon, 7 Sep 2020 17:22:53 +0200
> > Halil Pasic wrote:
> >
> > > On Fri, 24 Jul 2020 12:57:44 +1000
> > > David Gibson wrote:
> > >
> > > > At least some s390 cpu m
On Thu, Sep 10, 2020 at 06:15:26PM -0400, Eduardo Habkost wrote:
> Move the whole contents of the overview doc comment from object.h
> to qom.rst.
>
> This makes the documentation source easier to read and edit, and
> also solves the backslash escaping issue at the typecasting macro
> examples.
>
On Tue, Sep 8, 2020 at 6:32 PM Havard Skinnemoen
wrote:
> On Tue, Sep 8, 2020 at 12:52 PM Havard Skinnemoen
> wrote:
> >
> > On Tue, Sep 8, 2020 at 9:58 AM Philippe Mathieu-Daudé
> wrote:
> > >
> > > On 9/8/20 5:52 PM, Philippe Mathieu-Daudé wrote:
> > > > On 9/8/20 5:02 PM, Alexander Bulekov w
On Thu, Sep 3, 2020 at 11:59 AM Philippe Mathieu-Daudé
wrote:
> On 8/25/20 2:17 AM, Havard Skinnemoen via wrote:
> > If a -bios option is specified on the command line, load the image into
> > the internal ROM memory region, which contains the first instructions
> > run by the CPU after reset.
>
On Tue, Sep 08, 2020 at 12:34:59PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/8/20 12:30 PM, Philippe Mathieu-Daudé wrote:
> >>> On 8/28/20 9:19 PM, Sai Pavan Boddu wrote:
> This patch starts making the hcd-xhci.c pci free, as part of this
> restructuring dma read/writes are handled with
On Tue, Sep 08, 2020 at 12:30:17PM +0200, Philippe Mathieu-Daudé wrote:
> >> On 8/28/20 9:19 PM, Sai Pavan Boddu wrote:
> >>> This patch starts making the hcd-xhci.c pci free, as part of this
> >>> restructuring dma read/writes are handled without passing pci object.
> >>>
> >>> Signed-off-by: Sai
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Host Memory : 15.49 GB
Start Time (UTC) : 2020-09-10 22:30:02
End Time (UTC) : 2020-09-10 23:02:44
Execution Time : 0:32:42.042974
Status : SUCCESS
Note:
Changes denoted by '-' are less than 0.01%.
-
Move the whole contents of the overview doc comment from object.h
to qom.rst.
This makes the documentation source easier to read and edit, and
also solves the backslash escaping issue at the typecasting macro
examples.
Signed-off-by: Eduardo Habkost
---
docs/devel/qom.rst | 373 ++
Signed-off-by: Eduardo Habkost
---
docs/devel/index.rst | 1 +
docs/devel/qom.rst | 5 +
2 files changed, 6 insertions(+)
create mode 100644 docs/devel/qom.rst
diff --git a/docs/devel/index.rst b/docs/devel/index.rst
index 04773ce076..c34b43ec28 100644
--- a/docs/devel/index.rst
+++ b/doc
Convert all example/codelisting markup to Sphinx code-block.
There are a few sections where backslashes at the end of lines
break code formatting. A comment was added noting that this is
an issue.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 135 ++-
Replace gtkdoc markup with Sphinx ``code`` syntax.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index f85718380d..4fb528d841 100644
--- a/include/qom/object.h
+++ b/in
This indents existing code examples that are not indented yet,
just to make future conversion to Sphinx markup easier to review.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 376 +--
1 file changed, 188 insertions(+), 188 deletions(-)
diff --
Add DOC: section keyword to introduction doc comment, so it will
be rendered by kernel-doc.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index 4fb528d841..d2eecdf872 1006
kernel-doc requires all function parameters to be documented, so
document them all.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 47 ++--
1 file changed, 45 insertions(+), 2 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.
This converts the existing gtk-doc markup in object.h (that
probably was never rendered into an actual document) to
kernel-doc + Sphinx syntax, and reference them at
docs/devel/qom.rst.
Eduardo Habkost (9):
qom: Document all function parameters in doc comments
qom: Use kernel-doc private/publi
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index d2eecdf872..da9ecb310f 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -120,7 +120,8 @@ typede
Use kernel-doc syntax for indicating private and public struct
fields.
Signed-off-by: Eduardo Habkost
---
include/qom/object.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index ad2b91ec6c..f85718380d 100644
--- a/include/q
Hi Vladimir!
Thank you for working on this. My comments below.
On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote:
It's simple to avoid error propagation in blk_log_writes_open(), we
just need to refactor blk_log_writes_find_cur_log_sector() a bit.
Signed-off-by: Vladimir Sementsov-Ogievski
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical
Reference Manual' (100112_0200_07_en):
2.1 Overview of the MPS2 and MPS2+ hardware
The MPS2 and MPS2+ FPGA Prototyping Boards contain the
following components and interfaces:
* User switches and user LEDs:
The recently added LED device reports LED status changes with
the 'led_set_intensity' trace event. It is less invasive than
the fprintf() calls. We need however to have a binary built
with tracing support.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/tosa.c | 40 +++-
Track the LED intensity, and emit a trace event when it changes.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/led.c| 4
hw/misc/trace-events | 1 +
2 files changed, 5 insertions(+)
diff --git a/hw/misc/led.c b/hw/misc/led.c
index 3ef4f5e0469..eb
The Witherspoon has 3 LEDs connected to a PCA9552. Add them.
The names and reset values are taken from:
https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml
Example booting obmc-phosphor-image:
$ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity
1592693373.99
Per the 'ARM MPS2 and MPS2+ FPGA Prototyping Boards Technical
Reference Manual' (100112_0200_07_en):
2.1 Overview of the MPS2 and MPS2+ hardware
The MPS2 and MPS2+ FPGA Prototyping Boards contain the
following components and interfaces:
* User switches and user LEDs:
Add a LED device which can be connected to a GPIO output.
They can also be dimmed with PWM devices. For now we do
not implement the dimmed mode, but in preparation of a
future implementation, we start using the LED intensity.
LEDs are limited to a fixed set of colors.
Signed-off-by: Philippe Math
Some devices expose GPIO lines.
Add a GPIO qdev input to our LED device, so we can
connect a GPIO output using qdev_connect_gpio_out().
When used with GPIOs, the intensity can only be either
minium or maximum. This depends of the polarity of the
GPIO (which can be inverted).
Declare the GpioPolar
Hello,
These patches are part of the GSoC unselected 'QEMU visualizer'
project.
This series introduce a LED device that can be easily connected
to a GPIO output.
Since v4:
- Fixed typos (Luc)
- Removed TYPE_TOSA_MISC_GPIO qdev conversion patch (Peter)
Since v3:
- Rebased (TYPE_TOSA_MISC_GPIO)
-
On Fri, Sep 11, 2020 at 4:16 AM Peter Lieven wrote:
>
>
> Am 10.09.2020 um 12:30 schrieb Yonggang Luo :
>
> These compiling errors are fixed:
> ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory
> 27 | #include
> | ^~~~
> compilation terminated.
>
> ../block
On Wed, 26 Aug 2020 18:15:53 +0800
AlexChen wrote:
> From: AlexChen
>
> The 'kdgb' is allocating memory in get_kdbg(), but it is not freed
> in both fill_header() and fill_context() failed branches, fix it.
>
> Signed-off-by: AlexChen
> ---
> contrib/elf2dmp/main.c | 4 ++--
> 1 file changed
On Thu, 10 Sep 2020 at 14:15, Alex Bennée wrote:
>
> The user can still enable this explicitly but they will get a warning
> at the end of configure for their troubles. This also drops any builds
> of ppc64abi32 from our CI tests.
>
> Signed-off-by: Alex Bennée
> Reviewed-by: Philippe Mathieu-Dau
> Am 10.09.2020 um 12:30 schrieb Yonggang Luo :
>
> These compiling errors are fixed:
> ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory
> 27 | #include
> | ^~~~
> compilation terminated.
>
> ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t'
> 6
On 9/10/20 8:16 PM, Michael Roth wrote:
> Quoting Philippe Mathieu-Daudé (2020-09-04 04:20:00)
>> On 9/3/20 10:58 PM, Michael Roth wrote:
>>> Hi everyone,
>>>
>>> The following new patches are queued for QEMU stable v5.0.1:
>>>
>>> https://github.com/mdroth/qemu/commits/stable-5.0-staging
>>>
>>>
Some machines don't have much differences a part from the flash model
being used. Introduce new machine properties to change them from the
command line.
Cc: 郁雷
Signed-off-by: Cédric Le Goater
---
hw/arm/aspeed.c | 45 +++--
1 file changed, 43 insertions(+
On Fri, 4 Sep 2020 at 14:38, Philippe Mathieu-Daudé wrote:
>
> On 9/3/20 10:20 PM, Peter Maydell wrote:
> > Implement a model of the MPS2 with the AN500 firmware. This is
> > similar to the AN385, with the following differences:
> > * Cortex-M7 CPU
> > * PSRAM is at 0x6000_
> > * Ethernet i
> Am 10.09.2020 um 18:58 schrieb Max Reitz :
>
> On 01.09.20 14:51, Peter Lieven wrote:
>> in case of large continous areas that share the same allocation status
>> it happens that the value of s->sector_next_status is unaligned to the
>> cluster size or even request alignment of the source. A
On Thu, 3 Sep 2020 at 20:23, Richard Henderson
wrote:
>
> Only argument set members have to be C identifiers, everything
> else gets prefixed during conversion to C. Some places just
> checked the leading character, and some places matched a leading
> character plus a C identifier.
>
> Convert ev
Ping for review? Mostly I'm interested in whether either
Richard or Alex knows what's up with the discrepancy between
the VLDR/VSTR patterns in current risu and the generated
aarch32 binaries/traces that have been floating around...
thanks
-- PMM
On Tue, 1 Sep 2020 at 17:20, Peter Maydell wrote:
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
include/chardev/char-win.h | 2 +-
chardev/char-pipe.c| 2 +-
chardev/char-win.c | 14 +++---
3 files chang
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/char-win-stdio.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/chardev/char-win-stdio.c
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/wctablet.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/chardev/wctablet.c b/chardev/wcta
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
include/chardev/spice.h | 2 +-
chardev/spice.c | 16
2 files changed, 9 insertions(+), 9 deletions(-)
dif
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/testdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/testdev.c b/chardev/testdev.c
index
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/char-socket.c | 68 +--
1 file changed, 34 insertions(+), 34 deletions(-)
diff --git
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/char-ringbuf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/chardev/char-ringbuf.c b/char
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/chardev-internal.h | 2 +-
chardev/char-fe.c | 4 ++--
chardev/char-mux.c | 22 +++---
cha
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
ui/console.c | 10 +-
ui/gtk.c | 8
ui/spice-app.c | 2 +-
3 files changed, 10 insertions(+), 10 deletions
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/char-udp.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/chardev/char-udp.c b/chardev/ch
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
include/chardev/char-fd.h | 2 +-
chardev/char-fd.c | 14 +++---
chardev/char-serial.c | 2 +-
3 files changed,
Rename instance and class type checkers to match the
TYPE_CHARDEV_BRAILLE constant name and the QOM type name string
("chardev-braille").
Signed-off-by: Eduardo Habkost
---
chardev/baum.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/chardev/baum.c b/chardev/
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/char-pty.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/chardev/char-pty.c b/
Rename instance and class type checkers to match the
TYPE_CHARDEV_* constant names and the QOM type name strings
("chardev-*").
Signed-off-by: Eduardo Habkost
---
chardev/char-parallel.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/chardev/char-parallel.c b/ch
Use DECLARE_INSTANCE_CHECKER instead of manually defining the
instance type checking macro.
Signed-off-by: Eduardo Habkost
---
chardev/char-parallel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char-parallel.c b/chardev/char-parallel.c
index e32aa2d226..3d670
The macro is exactly the same for both Linux and BSD, so move its
definition outside the host OS #ifdef blocks.
Signed-off-by: Eduardo Habkost
---
chardev/char-parallel.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/chardev/char-parallel.c b/chardev/char-parallel.
The struct itself may have a different definition on each OS, but
we can define the typedef in common code, outside the host OS #ifdefs.
Signed-off-by: Eduardo Habkost
---
chardev/char-parallel.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/chardev/char-parallel.c
Some chardev QOM cleanup patches had to be dropped from my queue
due to build erros introduced by code movements across ifdef
boundaries at char-parallel.c. This series redo the changes from
those patches, but the macro renames are now a little different:
In this version I have decided to rename
Rename instance and class type checkers to match the
TYPE_CHARDEV_MSMOUSE constant name and the QOM type name string
("chardev-msmouse").
Signed-off-by: Eduardo Habkost
---
chardev/msmouse.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/chardev/msmouse.c b/char
On 9/10/20 9:12 PM, Eduardo Habkost wrote:
> On Thu, Sep 10, 2020 at 07:29:03AM +0200, Philippe Mathieu-Daudé wrote:
>> On 9/9/20 8:15 PM, Eduardo Habkost wrote:
>>> Hi,
>>>
>>> Thanks for the patch, and sorry for taking so long to review
>>> this. I'm finally getting to the patches that were post
On 9/8/20 9:29 AM, Laszlo Ersek wrote:
> Ref:https://bugs.launchpad.net/qemu/+bug/1852196
> Repo: https://github.com/lersek/qemu.git
> Branch: edk2stable202008_lp_1852196
>
> This series consumes the following upstream edk2 releases:
>
> https://github.com/tianocore/edk2/releases/tag/edk2
On 9/10/20 8:16 PM, Michael Roth wrote:
> Quoting Philippe Mathieu-Daudé (2020-09-04 04:20:00)
>> On 9/3/20 10:58 PM, Michael Roth wrote:
>>> Hi everyone,
>>>
>>> The following new patches are queued for QEMU stable v5.0.1:
>>>
>>> https://github.com/mdroth/qemu/commits/stable-5.0-staging
>>>
>>>
On 9/10/20 9:01 AM, Philippe Mathieu-Daudé wrote:
> In order to use inclusive terminology, rename max_slaves
> as max_devices.>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Cédric Le Goater
> ---
> include/hw/ssi/aspeed_smc.h | 2 +-
> hw/ssi/aspeed_smc.c | 40 +
On Wed, Sep 02, 2020 at 06:42:10PM -0400, Eduardo Habkost wrote:
> This will make the TYPE_* constants consistent with the name of
> most type checking macros we have today.
>
> Signed-off-by: Eduardo Habkost
I will drop this and send a separate patch to rename the type
checking macros instead,
On Thu, Sep 10, 2020 at 07:29:03AM +0200, Philippe Mathieu-Daudé wrote:
> On 9/9/20 8:15 PM, Eduardo Habkost wrote:
> > Hi,
> >
> > Thanks for the patch, and sorry for taking so long to review
> > this. I'm finally getting to the patches that were postponed to
> > 5.2.
>
> Sorry I missed that pa
Le 10/09/2020 à 07:21, Launchpad Bug Tracker a écrit :
> This problem occurs on CentOS-7.5 (64-bit) with qemu-5.1.0, qemu head
> (commit 9435a8b3dd35f1f926f1b9127e8a906217a5518a) for riscv32-linux-
> user.
I tried to build qemu-5.1 on CentOS-7.5.1 but as python 3.5 is not
available, I gave up.
>
* Ján Tomko (jto...@redhat.com) wrote:
> On a Thursday in 2020, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Add a few examples of xattrmaps to the documentation.
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > ---
> > docs/tools/virtiofsd.rst | 49 +
On Thu, 10 Sep 2020 13:36:09 +0200
Cornelia Huck wrote:
> On Mon, 7 Sep 2020 17:22:53 +0200
> Halil Pasic wrote:
>
> > On Fri, 24 Jul 2020 12:57:44 +1000
> > David Gibson wrote:
> >
> > > At least some s390 cpu models support "Protected Virtualization" (PV),
> > > a mechanism to protect guest
On Wed, Sep 9, 2020 at 12:51 PM Palmer Dabbelt wrote:
>
> On Wed, 09 Sep 2020 12:00:07 PDT (-0700), Peter Maydell wrote:
> > On Wed, 9 Sep 2020 at 19:00, Alistair Francis wrote:
> >>
> >> On Tue, Sep 8, 2020 at 7:52 AM Peter Maydell
> >> wrote:
> >> > ...shouldn't the riscv64-softmmu config hav
This will make the type name constant consistent with the name of
the type checking macro.
Signed-off-by: Eduardo Habkost
Reviewed-by: Hervé Poussineau
Message-Id: <20200902224311.1321159-21-ehabk...@redhat.com>
Signed-off-by: Eduardo Habkost
---
include/hw/isa/pc87312.h | 4 ++--
hw/isa/pc873
Thanks for the help. The virt,mte=on did it!
On Thu, Sep 10, 2020 at 1:49 PM Peter Maydell
wrote:
> On Thu, 10 Sep 2020 at 18:43, Andrew Jones wrote:
> >
> > On Thu, Sep 10, 2020 at 05:17:17PM +0100, Peter Maydell wrote:
> > > What QEMU command line are you using to run this?
> > > In particula
This makes the code consistent with the rest of QOM code in QEMU,
and will make automated conversion to type declaration macros
simpler.
Signed-off-by: Eduardo Habkost
Message-Id: <20200824215936.2961951-3-ehabk...@redhat.com>
Signed-off-by: Eduardo Habkost
---
hw/intc/omap_intc.c | 2 +-
1 fil
Make the type checking macro name consistent with the TYPE_*
constant.
Signed-off-by: Eduardo Habkost
Reviewed-by: Eric Auger
Message-Id: <20200902224311.1321159-56-ehabk...@redhat.com>
Signed-off-by: Eduardo Habkost
---
hw/vfio/pci.h | 2 +-
hw/vfio/pci.c | 22 +++---
2 files
This makes the code consistent with the rest of QOM code in QEMU,
and will make automated conversion to type declaration macros
simpler.
Signed-off-by: Eduardo Habkost
Message-Id: <20200824215936.2961951-2-ehabk...@redhat.com>
Signed-off-by: Eduardo Habkost
---
hw/dma/xilinx_axidma.c | 4 ++--
Make the type checking macro name consistent with the TYPE_*
constant.
Signed-off-by: Eduardo Habkost
Reviewed-by: Hervé Poussineau
Message-Id: <20200902224311.1321159-40-ehabk...@redhat.com>
Signed-off-by: Eduardo Habkost
---
include/hw/scsi/esp.h | 2 +-
hw/dma/sparc32_dma.c | 2 +-
hw/m68k
1 - 100 of 466 matches
Mail list logo
