[PATCH v2] trace/simple: Fix unauthorized enable

2020-05-26 Thread Markus Armbruster
st_set_trace_file() accidentally enables tracing. It's called unconditionally during startup, which is why QEMU built with the simple trace backend always writes a trace file "trace-$PID". This has been broken for quite a while. I didn't track down the exact commit. Fix st_set_trace_file() to r

GDB get wrong debug infos on TI DSP architecture extension

2020-05-26 Thread casmac
Hi all,    I am working on a TI DSP architecture extension for QEMU. Now, we are adding GDB debugging features.    We have done the following, but not sure we are on the right track :    - add a xml description file in gdb-xml, without understanding the purpose of the file, why some architectur

Re: [PULL 00/15] ppc-for-5.1 queue 20200527

2020-05-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200527053809.356168-1-da...@gibson.dropbear.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200527053809.356168-1-da...@gibson.dropbear.id.au Subject: [PULL 00/15] ppc-for-5.1 queue 2

Re: [PATCH Kernel v22 0/8] Add UAPIs to support migration for VFIO devices

2020-05-26 Thread Yan Zhao
On Tue, May 26, 2020 at 02:19:39PM -0600, Alex Williamson wrote: > On Mon, 25 May 2020 18:50:54 +0530 > Kirti Wankhede wrote: > > > On 5/25/2020 12:29 PM, Yan Zhao wrote: > > > On Tue, May 19, 2020 at 10:58:04AM -0600, Alex Williamson wrote: > > >> Hi folks, > > >> > > >> My impression is that

Re: [PULL 0/8] Audio 20200526 patches

2020-05-26 Thread Markus Armbruster
he Git repository at: > > git://git.kraxel.org/qemu tags/audio-20200526-pull-request > > for you to fetch changes up to b3b8a1fea6ed5004bbad2f70833caee70402bf02: > > hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include (2020-05-26 > 08:46:14 +0200) > >

[Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2020-05-26 Thread Greg Kurz
For the records. QEMU patches: https://lists.nongnu.org/archive/html/qemu-devel/2016-06/msg07586.html Linux patches: https://sourceforge.net/p/v9fs/mailman/message/35175775/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

Re: [PATCH] hw/vfio/common: Trace in which mode a IOMMU is opened

2020-05-26 Thread Cornelia Huck
On Tue, 26 May 2020 19:35:42 +0200 Philippe Mathieu-Daudé wrote: > One might want to check which IOMMU version the host kernel > provide. Add a trace event to see in which mode we opened > our container. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/vfio/common.c | 19 ++

Re: [PATCH v2 0/7] exec/cpu: Cleanups around "exec/hwaddr.h" (reserved to system-mode)

2020-05-26 Thread Cornelia Huck
On Tue, 26 May 2020 19:24:20 +0200 Philippe Mathieu-Daudé wrote: > The 'hwaddr' type declared in "exec/hwaddr.h" is meant for > system-mode emulation only. > This series is a preparatory cleanup to allow later poisoning > it in user-mode code. > > Missing review: patche 7 > - target/s390x: Restr

Re: [PATCH v2 7/7] target/s390x: Restrict system-mode declarations

2020-05-26 Thread Cornelia Huck
On Tue, 26 May 2020 19:24:27 +0200 Philippe Mathieu-Daudé wrote: > As these declarations are restricted to !CONFIG_USER_ONLY in > helper.c, only declare them when system-mode emulation is used. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Keep load_psw() is /* cc_helper.c */ section (c

[PULL 07/10] mips/boston: Fix boston_mach_init() error handling

2020-05-26 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. boston_mach_init() is

[PULL 05/10] error: Use error_reportf_err() where appropriate

2020-05-26 Thread Markus Armbruster
Replace error_report("...: %s", ..., error_get_pretty(err)); by error_reportf_err(err, "...: ", ...); One of the replaced messages lacked a colon. Add it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200505101908.6207-6

[PULL 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init()

2020-05-26 Thread Markus Armbruster
Cc: Peter Maydell Cc: Jean-Christophe Dubois Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200505101908.6207-10-arm...@redhat.com> [Straightforward conflict with resolved d2623129a7 "qom: Drop parameter @errp of object_property_add() & friends"] --- hw/arm

[PULL 02/10] xen: Fix and improve handling of device_add usb-host errors

2020-05-26 Thread Markus Armbruster
usbback_portid_add() leaks the error when qdev_device_add() fails. Fix that. While there, use the error to improve the error message. The qemu_opts_from_qdict() similarly leaks on failure. But any failure there is a programming error. Pass &error_abort. Fixes: 816ac92ef769f9ffc534e49a1bb6177bd

[PULL 00/10] Error reporting patches for 2020-05-27

2020-05-26 Thread Markus Armbruster
The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into staging (2020-05-26 14:05:53 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2020-05-27 for

[PULL 06/10] mips/malta: Fix create_cps() error handling

2020-05-26 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second create_cps() is wrong that

[PULL 04/10] tests/migration: Tighten error checking

2020-05-26 Thread Markus Armbruster
migrate_get_socket_address() neglects to check visit_type_SocketAddressList() failure. This smells like a leak, but it actually will crash dereferencing @addrs. Pass &error_abort to remove the code smell. Signed-off-by: Markus Armbruster Message-Id: <20200505101908.6207-5-arm...@redhat.com> Rev

[PULL 10/10] i386: Fix x86_cpu_load_model() error API violation

2020-05-26 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. x86_cpu_load_model()

[PULL 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-05-26 Thread Markus Armbruster
Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API violations" neglected to change visit_check_struct()'s Error ** argument along with the others. If visit_check_struct() failed, we'd take the success path. Fortunately, it can't fail here: qobject_input_check_struct() checks we

[PULL 01/10] nvdimm: Plug memory leak in uuid property setter

2020-05-26 Thread Markus Armbruster
nvdimm_set_uuid() leaks memory on qemu_uuid_parse() failure. Fix that. Fixes: 6c5627bb24dcd68c997857a8b671617333b1289f Cc: Xiao Guangrong Cc: Shivaprasad G Bhat Signed-off-by: Markus Armbruster Message-Id: <20200505101908.6207-2-arm...@redhat.com> Tested-by: Shivaprasad G Bhat Reviewed-by: Sh

[PULL 08/10] mips/boston: Plug memory leak in boston_mach_init()

2020-05-26 Thread Markus Armbruster
Fixes: df1d8a1f29f567567b9d20be685a4241282e7005 Cc: Paul Burton Cc: Aleksandar Rikalo Signed-off-by: Markus Armbruster Message-Id: <20200505101908.6207-9-arm...@redhat.com> Reviewed-by: Aleksandar Markovic --- hw/mips/boston.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

[PATCH v2 3/5] hw/riscv: spike: Allow creating multiple sockets

2020-05-26 Thread Anup Patel
We extend RISC-V spike machine to allow creating a multi-socket machine. Each RISC-V spike machine socket is a set of HARTs and a CLINT instance. Other peripherals are shared between all RISC-V spike machine sockets. We also update RISC-V spike machine device tree to treat each socket as a NUMA nod

[PATCH v2 4/5] hw/riscv: Allow creating multiple instances of PLIC

2020-05-26 Thread Anup Patel
We extend PLIC emulation to allow multiple instances of PLIC in a QEMU RISC-V machine. To achieve this, we remove first HART id zero assumption from PLIC emulation. Signed-off-by: Anup Patel Reviewed-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- hw/riscv/sifive_e.c| 2 +- h

[PATCH v2 1/5] hw: Add sockets_specified field in CpuTopology

2020-05-26 Thread Anup Patel
When "sockets" sub-option of "-smp" option is not specified, the smp_parse() function will assume one CPU per-socket and set the number of sockets equal to number of CPUs. This is counter-intuitive and we should allow machine emulation to decide default number of sockets when "sockets" sub-option

[PATCH v2 0/5] RISC-V multi-socket support

2020-05-26 Thread Anup Patel
This series adds multi-socket support for RISC-V virt machine and RISC-V spike machine. The multi-socket support will help us improve various RISC-V operating systems, firmwares, and bootloader to support RISC-V NUMA systems. These patch can be found in riscv_multi_socket_v2 branch at: https://git

[PATCH v2 5/5] hw/riscv: virt: Allow creating multiple sockets

2020-05-26 Thread Anup Patel
We extend RISC-V virt machine to allow creating a multi-socket machine. Each RISC-V virt machine socket is a set of HARTs, a CLINT instance, and a PLIC instance. Other peripherals are shared between all RISC-V virt machine sockets. We also update RISC-V virt machine device tree to treat each socket

[PULL 14/15] target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again

2020-05-26 Thread David Gibson
From: Greg Kurz The penultimate argument of function ppc_radix64_partition_scoped_xlate() has the bool type. Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped translation" Signed-off-by: Greg Kurz Message-Id: <159051003729.407106.10610703877543955831.st...@bahia.lan> Revi

[PATCH v2 2/5] hw/riscv: Allow creating multiple instances of CLINT

2020-05-26 Thread Anup Patel
We extend CLINT emulation to allow multiple instances of CLINT in a QEMU RISC-V machine. To achieve this, we remove first HART id zero assumption from CLINT emulation. Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Reviewed-by: Palmer Dabbelt --- hw/riscv/sifive_clint.c | 20 +

[PULL 13/15] hw/nvram/mac_nvram: Convert debug printf()s to trace events

2020-05-26 Thread David Gibson
From: Philippe Mathieu-Daudé Convert NVR_DPRINTF() to trace events and remove ifdef'ry. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200524165126.13920-1-f4...@amsat.org> Reviewed-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/nvram/mac_nvram.c | 17 +++-- hw/nv

[PULL 09/15] target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate()

2020-05-26 Thread David Gibson
From: Greg Kurz As per CODING_STYLE. Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped translation" Signed-off-by: Greg Kurz Message-Id: <158941062665.240484.2663106458734800894.st...@bahia.lan> Reviewed-by: Cédric Le Goater Signed-off-by: David Gibson --- target/ppc/m

[PULL 15/15] vfio/nvlink: Remove exec permission to avoid SELinux AVCs

2020-05-26 Thread David Gibson
From: Leonardo Bras If SELinux is setup without 'execmem' permission for qemu, all mmap with (PROT_WRITE | PROT_EXEC) will fail and print a warning in SELinux log. If "nvlink2-mr" memory allocation fails (fist diff), it will cause guest NUMA nodes to not be correctly configured (V100 memory will

[PULL 12/15] hw/pci-bridge/dec: Remove dead debug code

2020-05-26 Thread David Gibson
From: Philippe Mathieu-Daudé Remove debug code never used since added in commit e1c6bbabee30. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200525033910.26166-1-f4...@amsat.org> Signed-off-by: David Gibson --- hw/pci-bridge/dec.c | 10 -- 1 file changed, 10 deletions(-) diff -

[PULL 11/15] target/ppc: Don't update radix PTE R/C bits with gdbstub

2020-05-26 Thread David Gibson
From: Greg Kurz gdbstub shouldn't silently change guest visible state when doing address translation. Since the R/C bits can only be updated when handling a MMU fault, let's reuse the cause_excp flag and rename it to guest_visible. While here drop a not very useful comment. This was found while

[PULL 06/15] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr()

2020-05-26 Thread David Gibson
From: Greg Kurz This doesn't require write access to the CPU structure. Signed-off-by: Greg Kurz Message-Id: <158941060817.240484.14621015211317485106.st...@bahia.lan> Reviewed-by: Cédric Le Goater Signed-off-by: David Gibson --- target/ppc/mmu-radix64.h | 4 ++-- 1 file changed, 2 insertion

[PULL 10/15] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate()

2020-05-26 Thread David Gibson
From: Greg Kurz The last two arguments have the bool type. Also, we shouldn't raise an exception when using gdbstub. This was found while reading the code. Since it only affects the powernv machine, I didn't dig further to find an actual bug. Fixes: d04ea940c597 "target/ppc: Add support for Rad

[PULL 04/15] target/ppc: Add support for scv and rfscv instructions

2020-05-26 Thread David Gibson
From: Nicholas Piggin POWER9 adds scv and rfscv instructions and the system call vectored interrupt. Linux does not support this instruction yet but it has been tested with a modified kernel that runs on real hardware. Signed-off-by: Nicholas Piggin Message-Id: <20200507115328.789175-1-npig...@

[PULL 08/15] target/ppc: Don't initialize some local variables in ppc_radix64_xlate()

2020-05-26 Thread David Gibson
From: Greg Kurz It is the job of the ppc_radix64_get_fully_qualified_addr() function which is called at the beginning of ppc_radix64_xlate() to set both lpid *and* pid. It doesn't buy us anything to initialize them first. Worse, a bug in ppc_radix64_get_fully_qualified_addr(), eg. failing to set

[PULL 07/15] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr()

2020-05-26 Thread David Gibson
From: Greg Kurz This doesn't require write access to the CPU registers. Signed-off-by: Greg Kurz Message-Id: <158941061434.240484.10700096396035994133.st...@bahia.lan> Reviewed-by: Cédric Le Goater Signed-off-by: David Gibson --- target/ppc/mmu-radix64.c | 3 ++- 1 file changed, 2 insertions

[PULL 01/15] ppc/pnv: Fix NMI system reset SRR1 value

2020-05-26 Thread David Gibson
From: Nicholas Piggin Commit a77fed5bd926 ("ppc/pnv: Add support for NMI interface") got the SRR1 setting wrong for sresets that hit outside of power-save states. Fix this, better documenting the source for the bit definitions. Fixes: 01b552b05b0f ("ppc/pnv: Add support for NMI interface") Cc:

[PULL 05/15] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-05-26 Thread David Gibson
From: Leonardo Bras On reboot, all memory that was previously added using object_add and device_add is placed in this DIMM area. The new SPAPR_LMB_FLAGS_HOTREMOVABLE flag helps Linux to put this memory in the correct memory zone, so no unmovable allocations are made there, allowing the object to

[PULL 02/15] ppc/spapr: add a POWER10 CPU model

2020-05-26 Thread David Gibson
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-Id: <20200507073855.2485680-1-...@kaod.org> Signed-off-by: David Gibson --- hw/ppc/spapr_cpu_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index e1f76c74f3..9c8c1b14cf

[PULL 00/15] ppc-for-5.1 queue 20200527

2020-05-26 Thread David Gibson
The following changes since commit ddc760832fa8cf5e93b9d9e6e854a5114ac63510: Merge remote-tracking branch 'remotes/gkurz/tags/9p-next-2020-05-26' into staging (2020-05-26 14:05:53 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-5.1-20200527 for

[PULL 03/15] target/ppc: Untabify excp_helper.c

2020-05-26 Thread David Gibson
From: Greg Kurz Some tabs crept in with a recent change. Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging" Signed-off-by: Greg Kurz Message-Id: <158886788307.1560068.14096740175576278978.st...@bahia.lan> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- ta

Re: [PATCH] or1k: Fix compilation hiccup

2020-05-26 Thread Thomas Huth
On 26/05/2020 20.51, Eric Blake wrote: > On my Fedora 32 machine, gcc 10.1.1 at -O2 (the default for a bare > './configure') has a false-positive complaint: > > CC or1k-softmmu/hw/openrisc/openrisc_sim.o > /home/eblake/qemu/hw/openrisc/openrisc_sim.c: In function ‘openrisc_sim_init’: > /hom

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-26 Thread Christian Ehrhardt 
** No longer affects: qemu (Ubuntu Disco) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images Status in ku

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/26/20 11:31 AM, Philippe Mathieu-Daudé wrote: >> +Laurent >> >> On 5/26/20 11:04 AM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> On 5/26/20 9:38 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Signed-

Re: [PATCH 30/55] auxbus: New aux_realize_bus(), pairing with aux_init_bus()

2020-05-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/19/20 4:55 PM, Markus Armbruster wrote: >> aux_init_bus() encapsulates the creation of an aux-bus and its >> aux-to-i2c-bridge device. >> >> Create aux_realize_bus() to similarly encapsulate their realization. >> >> Signed-off-by: Markus Armbruster >> ---

[PATCH v25 QEMU 1/3] virtio-balloon: Implement support for page poison reporting feature

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison reporting if we want to actually get data on if the guest will be poisoning pages. Add a value for reporting the poison value being used if page poisoning is enabled in the guest. With this we can determine if we

[PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report' with 'h

[PATCH v25 QEMU 2/3] virtio-balloon: Provide an interface for free page reporting

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back into th

[PATCH v25 QEMU 0/3] virtio-balloon: add support for page poison and free page reporting

2020-05-26 Thread Alexander Duyck
This series provides an asynchronous means of reporting free guest pages to QEMU through virtio-balloon so that the memory associated with those pages can be dropped and reused by other processes and/or guests on the host. Using this it is possible to avoid unnecessary I/O to disk and greatly impro

RE: [PATCH 2/4] hw/riscv: spike: Allow creating multiple sockets

2020-05-26 Thread Anup Patel
> -Original Message- > From: Alistair Francis > Sent: 27 May 2020 09:00 > To: Anup Patel > Cc: Palmer Dabbelt ; Peter Maydell > ; qemu-ri...@nongnu.org; > sag...@eecs.berkeley.edu; a...@brainfault.org; qemu-devel@nongnu.org; > Atish Patra ; Alistair Francis > > Subject: Re: [PATCH 2/4]

Re: [PATCH 2/4] hw/riscv: spike: Allow creating multiple sockets

2020-05-26 Thread Alistair Francis
at all? AlistairOn Tue, May 26, 2020 at 7:55 PM Anup Patel wrote: > > > > > -Original Message- > > From: Alistair Francis > > Sent: 27 May 2020 06:08 > > To: Anup Patel > > Cc: Palmer Dabbelt ; Peter Maydell > > ; qemu-ri...@nongnu.org; > > sag...@eecs.berkeley.edu; a...@brainfault.org

Re: [PATCH] target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again

2020-05-26 Thread David Gibson
On Tue, May 26, 2020 at 06:20:37PM +0200, Greg Kurz wrote: > The penultimate argument of function ppc_radix64_partition_scoped_xlate() > has the bool type. > > Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped > translation" > Signed-off-by: Greg Kurz Applied, thanks. > -

Re: [RESEND PATCH 1/1] vfio/nvlink: Remove exec permission to avoid SELinux AVCs

2020-05-26 Thread David Gibson
On Tue, May 26, 2020 at 02:43:43PM -0600, Alex Williamson wrote: > On Mon, 18 May 2020 12:05:24 -0300 > Leonardo Bras wrote: > > > If SELinux is setup without 'execmem' permission for qemu, all mmap > > with (PROT_WRITE | PROT_EXEC) will fail and print a warning in > > SELinux log. > > > > If "n

Re: [PATCH] or1k: Fix compilation hiccup

2020-05-26 Thread Eric Blake
On 5/26/20 6:21 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200526185132.1652355-1-ebl...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: === OUTPUT BEGIN === ERROR: spaces required around that '*' (

RE: [PATCH 2/4] hw/riscv: spike: Allow creating multiple sockets

2020-05-26 Thread Anup Patel
> -Original Message- > From: Alistair Francis > Sent: 27 May 2020 06:08 > To: Anup Patel > Cc: Palmer Dabbelt ; Peter Maydell > ; qemu-ri...@nongnu.org; > sag...@eecs.berkeley.edu; a...@brainfault.org; qemu-devel@nongnu.org; > Atish Patra ; Alistair Francis > > Subject: Re: [PATCH 2/4]

Re: [PATCH v3 3/9] target/riscv: Add the lowRISC Ibex CPU

2020-05-26 Thread LIU Zhiwei
On 2020/5/27 1:12, Alistair Francis wrote: On Fri, May 22, 2020 at 12:51 AM LIU Zhiwei wrote: On 2020/5/20 5:31, Alistair Francis wrote: Ibex is a small and efficient, 32-bit, in-order RISC-V core with a 2-stage pipeline that implements the RV32IMC instruction set architecture. For more

Re: [PATCH v3 3/3] target/riscv: Drop support for ISA spec version 1.09.1

2020-05-26 Thread Aleksandar Markovic
сре, 27. мај 2020. у 02:33 Alistair Francis је написао/ла: > > On Tue, May 26, 2020 at 4:55 PM Aleksandar Markovic > wrote: > > > > сре, 27. мај 2020. у 00:56 Alistair Francis > > је написао/ла: > > > > > > The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since > > > 4.1. It's not

Re: [PATCH v3 9/9] target/riscv: Use a smaller guess size for no-MMU PMP

2020-05-26 Thread Alistair Francis
On Wed, May 20, 2020 at 6:52 PM Bin Meng wrote: > > On Wed, May 20, 2020 at 5:40 AM Alistair Francis > wrote: > > > > Signed-off-by: Alistair Francis > > --- > > target/riscv/pmp.c | 14 +- > > 1 file changed, 9 insertions(+), 5 deletions(-) > > > > diff --git a/target/riscv/pmp.c b

Re: [PATCH 2/4] hw/riscv: spike: Allow creating multiple sockets

2020-05-26 Thread Alistair Francis
On Fri, May 22, 2020 at 3:10 AM Anup Patel wrote: > > > > > -Original Message- > > From: Palmer Dabbelt > > Sent: 22 May 2020 01:46 > > To: Anup Patel > > Cc: Peter Maydell ; Alistair Francis > > ; sag...@eecs.berkeley.edu; Atish Patra > > ; a...@brainfault.org; qemu-ri...@nongnu.org; >

Re: [PATCH v3 3/3] target/riscv: Drop support for ISA spec version 1.09.1

2020-05-26 Thread Alistair Francis
On Tue, May 26, 2020 at 4:55 PM Aleksandar Markovic wrote: > > сре, 27. мај 2020. у 00:56 Alistair Francis > је написао/ла: > > > > The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since > > 4.1. It's not commonly used so let's remove support for it. > > > > Hmmm, a very odd commit

Re: [PATCH v3 3/3] target/riscv: Drop support for ISA spec version 1.09.1

2020-05-26 Thread Aleksandar Markovic
сре, 27. мај 2020. у 00:56 Alistair Francis је написао/ла: > > The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since > 4.1. It's not commonly used so let's remove support for it. > Hmmm, a very odd commit message. Do you suggest that there could be the case that spec version 1.09.1

Re: [PATCH] or1k: Fix compilation hiccup

2020-05-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200526185132.1652355-1-ebl...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200526185132.1652355-1-ebl...@redhat.com Subject: [PATCH] or1k: Fix compilation hiccup Type: series

Re: [PATCH] hw/registerfields: Prefix local variables with underscore in macros

2020-05-26 Thread Alistair Francis
On Tue, May 26, 2020 at 9:50 AM Philippe Mathieu-Daudé wrote: > > ping? I'll send a PR with this. Alistair > > On 5/10/20 10:34 PM, Philippe Mathieu-Daudé wrote: > > One can name a local variable holding a value as 'v', but it > > currently clashes with the registerfields macros. To save others

[PATCH v3 3/3] target/riscv: Drop support for ISA spec version 1.09.1

2020-05-26 Thread Alistair Francis
The RISC-V ISA spec version 1.09.1 has been deprecated in QEMU since 4.1. It's not commonly used so let's remove support for it. Signed-off-by: Alistair Francis --- target/riscv/cpu.h| 1 - target/riscv/cpu.c| 2 - target/riscv/cpu_help

[PATCH v3 2/3] target/riscv: Remove the deprecated CPUs

2020-05-26 Thread Alistair Francis
Signed-off-by: Alistair Francis Reviewed-by: Bin Meng --- target/riscv/cpu.h | 7 --- target/riscv/cpu.c | 28 tests/qtest/machine-none-test.c | 4 ++-- 3 files changed, 2 insertions(+), 37 deletions(-) diff --git a/target/riscv/cpu.h

[PATCH v3 1/3] hw/riscv: spike: Remove deprecated ISA specific machines

2020-05-26 Thread Alistair Francis
The ISA specific Spike machines have been deprecated in QEMU since 4.1, let's finally remove them. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng --- include/hw/riscv/spike.h | 6 +- hw/riscv/spike.c | 217 ---

[PATCH v3 0/3] RTISC-V: Remove deprecated ISA, CPUs and machines

2020-05-26 Thread Alistair Francis
v3: - Don't use SiFive CPUs for Spike machine v2: - Remove the CPUs and ISA seperatley Alistair Francis (3): hw/riscv: spike: Remove deprecated ISA specific machines target/riscv: Remove the deprecated CPUs target/riscv: Drop support for ISA spec version 1.09.1 include/hw/riscv/spike.

Re: [PATCH] util/oslib-posix : qemu_init_exec_dir implementation for MacOS

2020-05-26 Thread David CARLIER
>From ce857629697e8b6a2149fd3a1e16b7eea26aafca Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 26 May 2020 21:35:27 +0100 Subject: [PATCH] util/oslib: current process full path resolution on MacOS Using existing libproc to fill the path. Signed-off-by: David Carlier --- util/oslib-posi

Re: [PATCH v7 15/32] qcow2: Add qcow2_get_subcluster_range_type()

2020-05-26 Thread Eric Blake
On 5/25/20 1:08 PM, Alberto Garcia wrote: There are situations in which we want to know how many contiguous subclusters of the same type there are in a given cluster. This can be done by simply iterating over the subclusters and repeatedly calling qcow2_get_subcluster_type() for each one of them.

Re: [PATCH v4 5/5] block/io: refactor save/load vmstate

2020-05-26 Thread Eric Blake
On 5/25/20 5:08 AM, Vladimir Sementsov-Ogievskiy wrote: Like for read/write in a previous commit, drop extra indirection layer, generate directly bdrv_readv_vmstate() and bdrv_writev_vmstate(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/coroutines.h| 10 +++ include/block/

[Bug 1880763] [NEW] Missing page crossing check in use_goto_tb() for rx target

2020-05-26 Thread Ahmed Karaman
Public bug reported: Currently the rx target doesn't have the page crossing check in its use_goto_tb() function. This is a required feature for stable system mode emulations that all other targets implement. ** Affects: qemu Importance: Undecided Assignee: Ahmed Karaman (ahmedkrmn)

Re: [PATCH v4 4/5] block: drop bdrv_prwv

2020-05-26 Thread Eric Blake
On 5/25/20 5:08 AM, Vladimir Sementsov-Ogievskiy wrote: Now, when we are not more paying extra code for coroutine wrappers, there no more sence in extra indirection layer: bdrv_prwv(). Let's drop it and instead genereate pure bdrv_preadv() and bdrv_pwritev(). Typos and grammar; I suggest: Now

Re: [PATCH v4 3/5] block: generate coroutine-wrapper code

2020-05-26 Thread Eric Blake
On 5/25/20 5:07 AM, Vladimir Sementsov-Ogievskiy wrote: We have a very frequent pattern of creating coroutine from function with several arguments: - create structure to pack parameters - create _entry function to call original function taking parameters from struct - do different

[PATCH] fixup! block: generate coroutine-wrapper code

2020-05-26 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Fix Makefile usage for VPATH builds Signed-off-by: Eric Blake --- This fixup lets me build locally with my VPATH build; it probably also explains why patchew and other CLI tools (which use VPATH) were failing. Makefile | 4 +++- 1 file changed, 3 insertions

Re: [PATCH 1/9] tests/acceptance: allow console interaction with specific VMs

2020-05-26 Thread Willian Rampazzo
On Mon, May 25, 2020 at 8:20 AM Pavel Dovgalyuk wrote: > > Console interaction in avocado scripts was possible only with single > default VM. > This patch modifies the function parameters to allow passing a specific > VM as a parameter to interact with it. > > Signed-off-by: Pavel Dovgalyuk > ---

Re: [PATCH 2/9] tests/acceptance: add base class record/replay kernel tests

2020-05-26 Thread Willian Rampazzo
On Mon, May 25, 2020 at 8:22 AM Pavel Dovgalyuk wrote: > > This patch adds a base for testing kernel boot recording and replaying. > Each test has the phase of recording and phase of replaying. > Virtual machines just boot the kernel and do not interact with > the network. > Structure and image li

Re: [RESEND PATCH 1/1] vfio/nvlink: Remove exec permission to avoid SELinux AVCs

2020-05-26 Thread Alex Williamson
On Mon, 18 May 2020 12:05:24 -0300 Leonardo Bras wrote: > If SELinux is setup without 'execmem' permission for qemu, all mmap > with (PROT_WRITE | PROT_EXEC) will fail and print a warning in > SELinux log. > > If "nvlink2-mr" memory allocation fails (fist diff), it will cause > guest NUMA nodes

Re: [PATCH v4 0/5] coroutines: generate wrapper code

2020-05-26 Thread Eric Blake
On 5/25/20 8:48 AM, Vladimir Sementsov-Ogievskiy wrote: 25.05.2020 16:14, no-re...@patchew.org wrote: Patchew URL:https://patchew.org/QEMU/20200525100801.13859-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and the

[PATCH] util/oslib-posix : qemu_init_exec_dir implementation for MacOS

2020-05-26 Thread David CARLIER
>From b24a6702beb2a4e2a9c1c03b69c6d1dd07d4cf08 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 26 May 2020 21:35:27 +0100 Subject: [PATCH] util/oslib: current process full path resolution on MacOS Using existing libproc to fill the path. Signed-off-by: David Carlier --- util/oslib-posi

Re: [PATCH v7 14/32] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-05-26 Thread Eric Blake
On 5/25/20 1:08 PM, Alberto Garcia wrote: This patch adds QCow2SubclusterType, which is the subcluster-level version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the the same meaning as their QCOW2_CLUSTER_* equivalents (when they exist). See below for details and caveats. In images w

[PATCH v2] iotests: Dump QCOW2 dirty bitmaps metadata

2020-05-26 Thread Andrey Shinkevich
Add dirty bitmap information to QCOW2 metadata dump in qcow2.py script. The sample output: Header extension: Bitmaps magic 0x23852875 length24 nb_bitmaps2 reserved320 bitmap_directory_size 0x40 bitmap_directory_off

Re: [PATCH Kernel v22 0/8] Add UAPIs to support migration for VFIO devices

2020-05-26 Thread Alex Williamson
On Mon, 25 May 2020 18:50:54 +0530 Kirti Wankhede wrote: > On 5/25/2020 12:29 PM, Yan Zhao wrote: > > On Tue, May 19, 2020 at 10:58:04AM -0600, Alex Williamson wrote: > >> Hi folks, > >> > >> My impression is that we're getting pretty close to a workable > >> implementation here with v22 plus r

Re: [PATCH 16/19] util: fixed tsan warnings in thread_pool.c

2020-05-26 Thread Paolo Bonzini
On 22/05/20 18:07, Robert Foley wrote: > #include "trace.h" > #include "block/thread-pool.h" > #include "qemu/main-loop.h" > +#include "qemu/tsan.h" > > static void do_spawn_thread(ThreadPool *pool); > > @@ -97,7 +98,9 @@ static void *worker_thread(void *opaque) > } > >

Re: [PATCH 1/2] qapi: Fix comment format for @CpuInstanceProperties

2020-05-26 Thread Eric Blake
On 5/25/20 12:03 PM, Michal Privoznik wrote: In 176d2cda0de, the @die-id attribute was introduced to CpuInstanceProperties type. However, it mangled the comment. Signed-off-by: Michal Privoznik --- qapi/machine.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric

Re: [PATCH v6 07/32] qcow2: Document the Extended L2 Entries feature

2020-05-26 Thread Eric Blake
On 5/24/20 9:51 AM, Alberto Garcia wrote: Subcluster allocation in qcow2 is implemented by extending the existing L2 table entries and adding additional information to indicate the allocation status of each subcluster. This patch documents the changes to the qcow2 format and how they affect the

Re: [PATCH 9/9] tests/acceptance: Linux boot test for record/replay

2020-05-26 Thread Willian Rampazzo
On Mon, May 25, 2020 at 8:30 AM Pavel Dovgalyuk wrote: > > This patch adds a test for record/replay, which boots Linux > image from the disk and interacts with the network. > The idea and code of this test is borrowed from boot_linux.py > However, currently record/replay works only for x86_64, > t

Re: [PATCH v4 2/5] block: declare some coroutine functions in block/coroutines.h

2020-05-26 Thread Eric Blake
On 5/25/20 5:07 AM, Vladimir Sementsov-Ogievskiy wrote: We are going to keep coroutine-wrappers code (structure-packing parameters, BDRV_POLL wrapper functions) in a separate auto-generated s/a // files. So, we'll need a header with declaration of original _co_ functions, for those which are

Re: [PATCH v2 1/7] sysemu/accel: Restrict machine methods to system-mode

2020-05-26 Thread Roman Bolshakov
On Tue, May 26, 2020 at 07:24:21PM +0200, Philippe Mathieu-Daudé wrote: > Restrict init_machine(), setup_post() and has_memory() > to system-mode. > > Reviewed-by: Edgar E. Iglesias > Reviewed-by: Cornelia Huck > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/accel.h | 2 ++ > 1

Re: [PULL 0/5] 9p patches 2020-05-26

2020-05-26 Thread Peter Maydell
On Tue, 26 May 2020 at 12:50, Greg Kurz wrote: > > The following changes since commit fea8f3ed739536fca027cf56af7f5576f37ef9cd: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/pflash-next-20200522' into staging (2020-05-22 > 18:54:47 +0100) > > are available in the Git repositor

Re: [PATCH v4 1/5] block/io: refactor coroutine wrappers

2020-05-26 Thread Eric Blake
On 5/25/20 5:07 AM, Vladimir Sementsov-Ogievskiy wrote: Most of our coroutine wrappers already follow this convention: We have 'coroutine_fn bdrv_co_()' as the core function, and a wrapper 'bdrv_()' which does a polling loop. The only outsiders are the bdrv_prwv_co and bdrv_common_block_status_

Re: [PATCH 8/9] tests/acceptance: record/replay tests with advcal images

2020-05-26 Thread Willian Rampazzo
On Mon, May 25, 2020 at 8:28 AM Pavel Dovgalyuk wrote: > > This patch adds more record/replay tests with kernel images. > > Signed-off-by: Pavel Dovgalyuk > --- > tests/acceptance/replay_kernel.py | 80 > + > 1 file changed, 80 insertions(+) > > diff --git

Re: [PATCH v2 3/7] sysemu/hvf: Only declare hvf_allowed when HVF is available

2020-05-26 Thread Roman Bolshakov
On Tue, May 26, 2020 at 07:24:23PM +0200, Philippe Mathieu-Daudé wrote: > When HVF is not available, the hvf_allowed variable does not exist. > > Reviewed-by: Edgar E. Iglesias > Reviewed-by: Cornelia Huck > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Fixed typo s/tcg_allowed/hvf_allowed/

Re: [RFC v3 4/4] cpus: extract out accel-specific code to each accel

2020-05-26 Thread Roman Bolshakov
On Mon, May 25, 2020 at 04:54:40PM +0200, Claudio Fontana wrote: > each accelerator registers a new "CpusAccelInterface" > on initialization, providing functions for starting a vcpu, > kicking a vcpu, and sychronizing state. > > This way the code in cpus.cc is now all general softmmu code, > nothi

Re: [PATCH 9/9] tests/acceptance: Linux boot test for record/replay

2020-05-26 Thread Willian Rampazzo
On Mon, May 25, 2020 at 8:30 AM Pavel Dovgalyuk wrote: > > This patch adds a test for record/replay, which boots Linux > image from the disk and interacts with the network. > The idea and code of this test is borrowed from boot_linux.py > However, currently record/replay works only for x86_64, > t

Re: [PATCH] iotests: Dump QCOW2 dirty bitmaps metadata

2020-05-26 Thread Eric Blake
On 5/26/20 9:54 AM, Andrey Shinkevich wrote: Add dirty bitmap information to QCOW2 metadata dump in qcow2.py script. The sample output: Header extension (Bitmaps): This change to the output is independently useful. However, per patchew, it does cause 'make check' to fail: https://patchew.o

[PATCH] or1k: Fix compilation hiccup

2020-05-26 Thread Eric Blake
On my Fedora 32 machine, gcc 10.1.1 at -O2 (the default for a bare './configure') has a false-positive complaint: CC or1k-softmmu/hw/openrisc/openrisc_sim.o /home/eblake/qemu/hw/openrisc/openrisc_sim.c: In function ‘openrisc_sim_init’: /home/eblake/qemu/hw/openrisc/openrisc_sim.c:87:42: err

Re: [PATCH 13/19] accel/tcg: Fixed tsan warnings.

2020-05-26 Thread Paolo Bonzini
On 22/05/20 18:07, Robert Foley wrote: > For example: > WARNING: ThreadSanitizer: data race (pid=35425) > Write of size 4 at 0x7bbc00ac by main thread (mutexes: write M875): > #0 cpu_reset_interrupt hw/core/cpu.c:107:28 (qemu-system-aarch64+0x843790) > #1 arm_cpu_set_irq target/arm/cp

Re: [PATCH] iotests: Dump QCOW2 dirty bitmaps metadata

2020-05-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1590504866-679474-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.

[PATCH] block/block-copy: block_copy_dirty_clusters: fix failure check

2020-05-26 Thread Vladimir Sementsov-Ogievskiy
ret may be > 0 on success path at this point. Fix assertion, which may crash currently. Fixes: 4ce5dd3e9b5ee0fac18625860eb3727399ee965e Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/block-copy.c b/b

  1   2   3   4   >