Philippe Mathieu-Daudé <phi...@redhat.com> writes: > On 5/19/20 4:55 PM, Markus Armbruster wrote: >> aux_init_bus() encapsulates the creation of an aux-bus and its >> aux-to-i2c-bridge device. >> >> Create aux_realize_bus() to similarly encapsulate their realization. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> include/hw/misc/auxbus.h | 7 +++++++ >> hw/display/xlnx_dp.c | 2 +- >> hw/misc/auxbus.c | 5 +++++ >> 3 files changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/include/hw/misc/auxbus.h b/include/hw/misc/auxbus.h >> index a539a98c4b..6ab6cf5bb6 100644 >> --- a/include/hw/misc/auxbus.h >> +++ b/include/hw/misc/auxbus.h >> @@ -93,6 +93,13 @@ struct AUXSlave { >> */ >> AUXBus *aux_init_bus(DeviceState *parent, const char *name); > > Previous to your patch, but aux_init_bus() is misnamed. > > I'd rather rename this one aux_bus_init() ... > >> >> +/** >> + * aux_realize_bus: Realize an AUX bus. >> + * >> + * @bus: The AUX bus. >> + */ >> +void aux_realize_bus(AUXBus *bus); > > ... and this one aux_bus_realize(). > > If you mind :)
Makes sense. > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Thanks!