[PATCH v6 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-05-21 Thread Lukas Straub
The chr_out chardev is connected to a filter-redirector running in the main loop. qemu_chr_fe_write_all might block here in compare_chr_send if the (socket-)buffer is full. If another filter-redirector in the main loop want's to send data to chr_pri_in it might also block if the buffer is full. Thi

[PATCH v6 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-21 Thread Lukas Straub
In colo_compare_complete, insert CompareState into net_compares only after everything has been initialized. In colo_compare_finalize, remove CompareState from net_compares before anything is deinitialized. Signed-off-by: Lukas Straub Reviewed-by: Zhang Chen --- net/colo-compare.c | 45 +

[PATCH] replay: notify the main loop when there are no instructions

2020-05-21 Thread Pavel Dovgalyuk
When QEMU is executed in console mode without any external event sources, main loop may sleep for a very long time. But in case of replay there is another event source - event log. This patch adds main loop notification when the vCPU loop has nothing to do and main loop should process the inputs fr

[PATCH v6 2/6] chardev/char.c: Use qemu_co_sleep_ns if in coroutine

2020-05-21 Thread Lukas Straub
This will be needed in the next patch so compare_chr_send can be converted to a coroutine. Signed-off-by: Lukas Straub Reviewed-by: Marc-André Lureau Reviewed-by: Zhang Chen Reviewed-by: Philippe Mathieu-Daudé --- chardev/char.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) dif

[PATCH v6 1/6] net/colo-compare.c: Create event_bh with the right AioContext

2020-05-21 Thread Lukas Straub
qemu_bh_new will set the bh to be executed in the main loop. This causes crashes as colo_compare_handle_event assumes that it has exclusive access the queues, which are also concurrently accessed in the iothread. Create the bh with the AioContext of the iothread to fulfill these assumptions and fi

[PATCH v6 0/6] colo-compare bugfixes

2020-05-21 Thread Lukas Straub
Hello Everyone, Here are fixes for bugs that I found in my tests. I have tested this with my test suite and everything works fine. Regards, Lukas Straub Version changes: v6: -don't touch softmmu/vl.c, use __contructor__ attribute instead -better wording v5: -initialize and use notify_sendco o

[PATCH v6 4/6] net/colo-compare.c: Only hexdump packets if tracing is enabled

2020-05-21 Thread Lukas Straub
Else the log will be flooded if there is a lot of network traffic. Signed-off-by: Lukas Straub Reviewed-by: Zhang Chen Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- net/colo-compare.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ne

[PATCH] replay: fix replay shutdown for console mode

2020-05-21 Thread Pavel Dovgalyuk
When QEMU is used without any graphical window, QEMU execution is terminated with the signal (e.g., Ctrl-C). Signal processing in QEMU does not include qemu_system_shutdown_request call. That is why shutdown event is not recorded by record/replay in this case. This patch adds shutdown event to the

Re: [PATCH] replay: synchronize on every virtual timer callback

2020-05-21 Thread Pavel Dovgalyuk
On 21.05.2020 16:22, Paolo Bonzini wrote: On 06/05/20 10:17, Pavel Dovgalyuk wrote: Sometimes virtual timer callbacks depend on order of virtual timer processing and warping of virtual clock. Therefore every callback should be logged to make replay deterministic. This patch creates a checkpoin

[PATCH v2] replay: synchronize on every virtual timer callback

2020-05-21 Thread Pavel Dovgalyuk
Sometimes virtual timer callbacks depend on order of virtual timer processing and warping of virtual clock. Therefore every callback should be logged to make replay deterministic. This patch creates a checkpoint before every virtual timer callback. With these checkpoints virtual timers processing a

Re: [PATCH v3 07/17] block/io: support int64_t bytes in bdrv_co_do_copy_on_readv()

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
22.05.2020 01:29, Eric Blake wrote: On 4/30/20 6:10 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whol

[Bug 1879425] Re: The thread of "CPU 0 /KVM" keeping 99.9%CPU

2020-05-21 Thread cliff chen
Got it! BTW, you can confirm this is bug for qemu-kvm, right? thank you! Cliff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879425 Title: The thread of "CPU 0 /KVM" keeping 99.9%CPU Status in

[Bug 1879425] Re: The thread of "CPU 0 /KVM" keeping 99.9%CPU

2020-05-21 Thread Thomas Huth
I think you should definitely try a newer version if available - otherwise they'll likely refuse to help you, too (nobody wants to debug old versions when bugs are already fixed in newer ones) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [RFC 1/3] cpu-throttle: new module, extracted from cpus.c

2020-05-21 Thread Thomas Huth
> From: "Claudio Fontana" > Sent: Thursday, May 21, 2020 8:54:05 PM > > this is a first step in the refactoring of cpus.c. Could you maybe extend the commit message in the next version a little bit? ... say something about *what* you are moving to a separate file (and maybe why it is ok to mov

[Bug 1879425] Re: The thread of "CPU 0 /KVM" keeping 99.9%CPU

2020-05-21 Thread cliff chen
Hi Thomas, Do you have any quick suggestion before report it on CentOS? thanks Cliff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879425 Title: The thread of "CPU 0 /KVM" keeping 99.9%CPU Statu

[Bug 1693649] Re: x86 pause misbehaves with -cpu haswell

2020-05-21 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU (currently 5.0)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1693649 Title:

[Bug 1693667] Re: -cpu haswell / broadwell have no MONITOR in features1

2020-05-21 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU? Looking at https://git.qemu.org/?p=qemu.git;a=commitdiff;h=0723cc8a5558c94388 for example, it might have been fixed since QEMU v4.2... ** Changed in: qemu Status: New => Incomplete -- You received this bug notification be

[Bug 1879425] Re: The thread of "CPU 0 /KVM" keeping 99.9%CPU

2020-05-21 Thread Thomas Huth
Can you try with a newer version of CentOS? I think there should be newer versions of qemu-kvm-ev available, so maybe the problem is gone there. Otherwise, please either try to reproduce this problem with upstream QEMU, or report it to the CentOS bug tracker (https://bugs.centos.org/), since we d

[Bug 1879998] Re: Bad check for return value of mmap()

2020-05-21 Thread Thomas Huth
And concerning the mmap in roms/u-boot/, please report that issue to the U-Boot project instead: https://www.denx.de/wiki/U-Boot/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879998 Title: Bad ch

[Bug 1879998] Re: Bad check for return value of mmap()

2020-05-21 Thread Thomas Huth
skiboot is a separate project, we do not manage its code in the QEMU project, but just include the source code in our release tarballs since we ship the skiboot binary with QEMU. Please report these problems to the skiboot project instead: https://github.com/open-power/skiboot ** Changed in: qem

[Bug 1878915] Re: util/fdmon-io_uring.c:95: get_sqe: Assertion `ret > 1' failed.

2020-05-21 Thread Thomas Huth
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878915 Title: util/fdmon-io_uring.c:95: get_sqe: Assertion `ret > 1' failed. Status in QEMU:

Re: [PATCH 0/6] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-05-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200521192133.127559-1-hskinnem...@google.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

[Bug 1877716] Re: Win10 guest unusable after a few minutes

2020-05-21 Thread Thomas Huth
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877716 Title: Win10 guest unusable after a few minutes Status in QEMU: Fix Committed Bug d

[PATCH v1 0/1] target/microblaze: Add GDB XML files

2020-05-21 Thread Joe Komlodi
Hi all, This adds GDB XML files for Microblaze CPUs. For Microblaze, it's split up into core and stack protect XML files. Thanks! Joe Joe Komlodi (1): target/microblaze: Add GDB XML files for Microblaze configure| 1 + gdb-xml/microblaze-core.xml | 62 ++

Re: [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it

2020-05-21 Thread Richard Henderson
On 5/21/20 12:59 PM, Philippe Mathieu-Daudé wrote: > +++ b/hw/semihosting/Kconfig > @@ -1,3 +1,5 @@ > > +# default is 'n' > config SEMIHOSTING > - bool > +bool > +depends on TCG > diff --git a/target/arm/Kconfig b/target/arm/Kconfig > new file mode 100644 > index 00..035592

Re: [PATCH v3 09/11] rules.mak: Add base-arch() rule

2020-05-21 Thread Richard Henderson
On 5/21/20 12:59 PM, Philippe Mathieu-Daudé wrote: > + $(if $(findstring risc,$1),risc,\ Eh? riscv{32,64} vs openrisc. > + $(if $(findstring x86,$1),i386,\ Do we really not need an exact match for x86_64? > + $(if $(findstring aarch64,$1),arm,$1))) Exac

[PATCH v1 1/1] target/microblaze: Add GDB XML files for Microblaze

2020-05-21 Thread Joe Komlodi
This adds the Microblaze core and stack protect XML files, and also modifies the configuration to build those files. Signed-off-by: Joe Komlodi --- configure| 1 + gdb-xml/microblaze-core.xml | 62 gdb-xml/microblaze-stac

Re: [PATCH v3 25/25] ppc64: Clean up reginfo handling

2020-05-21 Thread Richard Henderson
On 5/21/20 7:34 PM, Richard Henderson wrote: > +return memcmp(m, a, sizeof(*m)); Ho hum. memcmp(...) == 0. Fixed locally. r~

[Bug 1880066] [NEW] Microphone input dies in guest when switching evdev input

2020-05-21 Thread Justin Cichra
Public bug reported: justin@justin-3900x:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 20.04 LTS Release:20.04 Codename: focal justin@justin-3900x:~$ apt list --installed | egrep '*qemu*|*kvm*' WARNING: apt does not have a stable CLI

Re: [PATCH v1 12/15] cpus-common: ensure auto-assigned cpu_indexes don't clash

2020-05-21 Thread Richard Henderson
On 5/20/20 7:05 AM, Alex Bennée wrote: > Basing the cpu_index on the number of currently allocated vCPUs fails > when vCPUs aren't removed in a LIFO manner. This is especially true > when we are allocating a cpu_index for each guest thread in > linux-user where there is no ordering constraint on th

Re: [PATCH] minikconf: explicitly set encoding to UTF-8

2020-05-21 Thread Richard Henderson
On 5/21/20 8:36 AM, Stefan Hajnoczi wrote: > QEMU currently only has ASCII Kconfig files but Linux actually uses > UTF-8. Explicitly specify the encoding and that we're doing text file > I/O. > > It's unclear whether or not QEMU will ever need Unicode in its Kconfig > files. If we start using the

Re: [PATCH v2] linux-user: limit check to HOST_LONG_BITS == 32

2020-05-21 Thread Richard Henderson
On 5/21/20 6:57 AM, Alex Bennée wrote: > Newer clangs rightly spot that you can never exceed the full address > space of 64 bit hosts with: > > linux-user/elfload.c:2076:41: error: result of comparison 'unsigned > long' > 18446744073709551615 is always false > [-Werror,-Wtautological-type-li

Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets

2020-05-21 Thread Richard Henderson
On 5/21/20 4:32 AM, Ahmed Karaman wrote: > Does this mean that there is a bug > in this function for the other targets? Yes, I think so. > That we have to do the page crossings check in both modes to avoid the > user-mode failures that you have mentioned above? Well, that or we need to fix linux

Re: [PATCH v1 11/15] tests/tcg/aarch64: Add bti smoke test

2020-05-21 Thread Richard Henderson
On 5/20/20 7:05 AM, Alex Bennée wrote: > From: Richard Henderson > > Requires gcc 10 for -mbranch-protection=standard. > > Signed-off-by: Richard Henderson > Message-Id: <20200520023139.9812-3-richard.hender...@linaro.org> > [AJB: add CROSS_CC_HAS_ARMV8_BTI check] > Signed-off-by: Alex Bennée

Re: [PATCH v1 10/15] tests/docker: use a gcc-10 based image for arm64 tests

2020-05-21 Thread Richard Henderson
On 5/20/20 7:05 AM, Alex Bennée wrote: > As we enable newer features that we want to test on arm64 targets we > need newer compilers. Split off a new debian-arm64-test-cross image > which we can use to build these new tests. > > Signed-off-by: Alex Bennée > --- > tests/docker/Makefile.include

Re: [PATCH v1 09/15] tests/docker: add debian11 base image

2020-05-21 Thread Richard Henderson
On 5/20/20 7:05 AM, Alex Bennée wrote: > We won't use this for building QEMU but we do need newer GCC's and > binutils for building some of our test cases. > > Signed-off-by: Alex Bennée > --- > tests/docker/Makefile.include| 2 +- > tests/docker/dockerfiles/debian11.docker | 18 +++

Re: [PATCH v1 08/15] tests/docker: bump fedora to 32

2020-05-21 Thread Richard Henderson
On 5/20/20 7:05 AM, Alex Bennée wrote: > We should be keeping this up to date as Fedora goes out of support > quite quickly. > > Signed-off-by: Alex Bennée > --- > tests/docker/dockerfiles/fedora.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v1 07/15] tests/tcg: better detect confused gdb which can't connect

2020-05-21 Thread Richard Henderson
On 5/20/20 7:05 AM, Alex Bennée wrote: > While we may gamely give the right information it can still confuse > the wide range of GDBs out there. For example ppc64abi32-linux-user > reports: > > warning: Selected architecture powerpc:common is not compatible with > reported target architecture p

Re: [PATCH v1 06/15] tests/fp: split and audit the conversion tests

2020-05-21 Thread Richard Henderson
On 5/20/20 7:05 AM, Alex Bennée wrote: > Split the float conversion tests into separate groups and audit the > tests to check what is still broken. I was able to enable a bunch of > tests that had been missed before: > > all the float to float conversions > ui32_to_extF80 > ui64_to_extF80 >

Re: [PATCH v1 05/15] tests/fp: enable extf80_le_quite tests

2020-05-21 Thread Richard Henderson
On 5/20/20 7:05 AM, Alex Bennée wrote: > These have been fixed now so we no longer need a special version of > the le_quiet rule to skip the test. > > Signed-off-by: Alex Bennée > --- > tests/Makefile.include | 7 --- > 1 file changed, 7 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PULL 0/1] qemu-openbios queue 20200521

2020-05-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200521200707.13826-1-mark.cave-ayl...@ilande.co.uk/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIP

[PATCH v5] char-socket: initialize reconnect timer only when the timer doesn't start

2020-05-21 Thread Li Feng
When the disconnect event is triggered in the connecting stage, the tcp_chr_disconnect_locked may be called twice. The first call: #0 qemu_chr_socket_restart_timer (chr=0x5582ee90) at chardev/char-socket.c:120 #1 0x5558e38c in tcp_chr_disconnect_locked (chr=) at chardev/cha

Re: [PATCH v4 0/6] hyperv: VMBus implementation

2020-05-21 Thread Jon Doron
On 21/05/2020, Paolo Bonzini wrote: On 24/04/20 14:34, Jon Doron wrote: This is a rebase of the old patchset from Roman for HyperV VMBus implementation. How to use: -device vmbus-bridge Later on new paravirtualized devices can be implemented on top of it (Network/SCSI/etc.) VMBus is a collect

[PATCH v3 25/25] ppc64: Clean up reginfo handling

2020-05-21 Thread Richard Henderson
Several of the gp_reg[] elements are not relevant -- e.g. orig r3, which is related to system calls. Omit those from the original reginfo_init(), so that any differences are automatically hidden. Do not only compare bit 4 of CCR -- this register is 32 bits wide with 8 cr subfields. We should com

[PATCH v3 21/25] ppc64: Use uint64_t to represent double

2020-05-21 Thread Richard Henderson
We want to do exact bitwise comparisons of the data, not be held hostage to IEEE comparisons and NaNs. Signed-off-by: Richard Henderson --- risu_reginfo_ppc64.h | 3 ++- risu_reginfo_ppc64.c | 29 + 2 files changed, 11 insertions(+), 21 deletions(-) diff --git a/ris

[PATCH v3 24/25] Remove return value from reginfo_dump

2020-05-21 Thread Richard Henderson
No uses actually checked the error indication. Even if we wanted to check ferror on the stream, we should do that generically rather than per arch. Signed-off-by: Richard Henderson --- risu.h | 4 ++-- risu_reginfo_aarch64.c | 8 +++- risu_reginfo_arm.c | 6 ++ risu_

[PATCH v3 18/25] Compute reginfo_size based on the reginfo

2020-05-21 Thread Richard Henderson
This will allow dumping of SVE frames without having to know the SVE vector length beforehand. Signed-off-by: Richard Henderson --- risu.h | 2 +- risu.c | 9 +++-- risu_reginfo_aarch64.c | 4 ++-- risu_reginfo_arm.c | 4 ++-- risu_reginfo_i386.c| 4 ++

[PATCH v3 20/25] aarch64: Use arch_init to configure sve

2020-05-21 Thread Richard Henderson
Adjust some of the aarch64 code to look at the reginfo struct instead of looking at test_sve, so that we do not need to pass the --test-sve option in order to dump sve trace files. Signed-off-by: Richard Henderson --- risu.h | 1 + risu.c | 3 +++ risu_reginfo_a

[PATCH v3 17/25] Add magic and size to the trace header

2020-05-21 Thread Richard Henderson
Sanity check that we're not getting out of sync with the trace stream. This will be especially bad with the change in size of the sve save data. Signed-off-by: Richard Henderson --- risu.h | 10 +++- risu.c | 162 - 2 files changed, 136 i

[PATCH v3 15/25] Rearrange reginfo and memblock buffers

2020-05-21 Thread Richard Henderson
For send_register_info from master_sigill, do not keep a reginfo buffer on the stack. At the moment, this struct is quite large for aarch64. Put the two reginfo buffers into an array, for the benefit of future dumping. For recv_and_compare_register_info, index this array with constants, so it's

[PATCH v3 13/25] Split RES_MISMATCH for registers and memory

2020-05-21 Thread Richard Henderson
By remembering the specific comparison that failed, we do not have to try again when it comes time to report. This makes the mem_used flag redundant. Also, packet_mismatch is now redundant with RES_BAD_IO. This means that the only thing that report_match_status does is to report on register stat

[QUESTION] How to improve virtio-gpu performance

2020-05-21 Thread Jun Piao
Hi Gerd, I'm using glmark2 to test virtio-gpu on AMDGPU, but the result is unsatisfactory. GPU: AMD Radeon Pro WX 5100 Host OS: CentOS Linux release 7.7.1908 (AltArch) --QEMU: 4.0.0 --linux kernel 4.18 --mesa 18.3 --virglrenderer --spice server 0.14.2 --spice-gtk3-0.35 --libepoxy 1.

[PATCH v3 12/25] Simplify syncing with master

2020-05-21 Thread Richard Henderson
Do not pass status like RES_BAD_IO from apprentice to master. This means that when master reports i/o error that we know it came from master; the apprentice will report its own i/o error. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- reginfo.c | 11 +-- 1 file changed, 5

[PATCH v3 23/25] Add --fulldump and --diffdup options

2020-05-21 Thread Richard Henderson
These allow the inspection of the trace files. Signed-off-by: Richard Henderson --- risu.c | 117 + 1 file changed, 102 insertions(+), 15 deletions(-) diff --git a/risu.c b/risu.c index f613fa9..8d907d9 100644 --- a/risu.c +++ b/risu.c @@

[PATCH v3 09/25] Unify i/o functions and use RisuResult

2020-05-21 Thread Richard Henderson
Push the trace check down from the function calling the reginfo function down into the i/o function. This means we don't have to pass a function pointer. Return a RisuResult from the i/o functions. This fixes a minor bug in send_register_info (even before the conversion to RisuResult), which ret

[PATCH v3 11/25] Always write for --master

2020-05-21 Thread Richard Henderson
For trace, master of course must write to the file we create. For sockets, we can report mismatches from either end. At present, we are reporting mismatches from master. Reverse that so that we report mismatches from the apprentice, just as we do for trace. Reviewed-by: Alex Bennée Signed-off-

[PATCH v3 22/25] Standardize reginfo_dump_mismatch printing

2020-05-21 Thread Richard Henderson
Hoist the "master vs apprentice" label to apprentice(), since we will want different labels for dumping. Remove all of the "mismatch" text from reginfo_dump_mismatch -- just print "vs". Signed-off-by: Richard Henderson --- risu.h | 4 ++-- risu.c | 1 + risu_re

[PATCH v3 10/25] Pass non-OK result back through siglongjmp

2020-05-21 Thread Richard Henderson
Rather than doing some work in the signal handler and some work outside, move all of the non-resume work outside. This works because we arranged for RES_OK to be 0, which is the normal return from sigsetjmp. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- risu.c | 50 +

[PATCH v3 08/25] Add enum RisuResult

2020-05-21 Thread Richard Henderson
Formalize the random set of numbers into an enum. Doing this makes it easy to see that one of the responses in recv_and_compare_register_info was inconsistent. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- risu.h| 25 + reginfo.c | 32 +++

[PATCH v3 19/25] aarch64: Reorg sve reginfo to save space

2020-05-21 Thread Richard Henderson
Mirror the signal frame by storing all of the registers as a lump. Use the signal macros to pull out the values. Signed-off-by: Richard Henderson --- risu_reginfo_aarch64.h | 16 + risu_reginfo_aarch64.c | 135 + 2 files changed, 73 insertions(+), 78

[PATCH v3 07/25] Add enum RisuOp

2020-05-21 Thread Richard Henderson
Formalize the set of defines, plus -1, into an enum. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- risu.h | 23 +++ reginfo.c | 32 +++- risu_aarch64.c | 6 +++--- risu_arm.c | 6 +++--- risu_i386.c| 4 ++--

[PATCH v3 06/25] Make some risu.c symbols static

2020-05-21 Thread Richard Henderson
These are unused in other translation units. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- risu.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/risu.c b/risu.c index 26dc116..ab17c71 100644 --- a/risu.c +++ b/risu.c @@ -31,18 +31,

[PATCH v3 05/25] Use EXIT_FAILURE, EXIT_SUCCESS

2020-05-21 Thread Richard Henderson
Some of the time we exit via the return value from main. This can make it easier to tell what it is we're returning. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- comms.c| 26 +- risu.c | 22

[PATCH v3 16/25] Split out recv_register_info

2020-05-21 Thread Richard Henderson
We will want to share this code when dumping. Signed-off-by: Richard Henderson --- risu.c | 50 ++ 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/risu.c b/risu.c index b91ad38..80bc3b1 100644 --- a/risu.c +++ b/risu.c @@ -166,6 +16

[PATCH v3 03/25] Hoist trace file and socket opening

2020-05-21 Thread Richard Henderson
We will want to share this code with --dump. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v3: Hoist socket connecting as well as trace file opening. --- risu.c | 49 +++-- 1 file changed, 23 insertions(+),

[PATCH v3 02/25] Unify master_fd and apprentice_fd to comm_fd

2020-05-21 Thread Richard Henderson
Any one invocation cannot be both master and apprentice. Let's use only one variable for the file descriptor. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- risu.c | 40 1 file changed, 20 insertions(+), 20 dele

[PATCH v3 00/25] risu cleanups and improvements

2020-05-21 Thread Richard Henderson
Version 3 changes the --dump option to --fulldump and --diffdump, after an off-hand suggestion by Alex. These are now mode options, similar to --master. Which means that dumping is an orthogonal apprentice type, which means that we can dump from a socket. I'm not sure that will be useful as such

[PATCH v3 04/25] Adjust tracefile open for write

2020-05-21 Thread Richard Henderson
Truncate the new output file. Rely on umask to remove group+other file permissions, if desired. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- risu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/risu.c b/risu.c index 2f6a677..81

[PATCH v3 14/25] Merge reginfo.c into risu.c

2020-05-21 Thread Richard Henderson
The distinction between the two is artificial. Following patches will rearrange the functions involved to make it easier for dumping of the trace file. Signed-off-by: Richard Henderson --- Makefile | 2 +- risu.h| 28 +- reginfo.c | 151 --

[PATCH v3 01/25] Use bool for tracing variables

2020-05-21 Thread Richard Henderson
Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- risu.h| 3 ++- reginfo.c | 2 +- risu.c| 8 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/risu.h b/risu.h index 8d2d646..e2b4508 100644 --- a/risu.h +++ b/risu.h @@ -17,6 +

Re: [PATCH v3 00/11] accel: Allow targets to use Kconfig, disable semihosting by default

2020-05-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200521195911.19685-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

[PATCH] target/i386: correct fix for pcmpxstrx substring search

2020-05-21 Thread Joseph Myers
This corrects a bug introduced in my previous fix for SSE4.2 pcmpestri / pcmpestrm / pcmpistri / pcmpistrm substring search, commit ae35eea7e4a9f21dd147406dfbcd0c4c6aaf2a60. That commit fixed a bug that showed up in four GCC tests with one libc implementation. The tests in question generate rando

Re: cluster_size got from backup_calculate_cluster_size()

2020-05-21 Thread Derek Su
On 2020/5/22 上午4:53, Vladimir Sementsov-Ogievskiy wrote: 21.05.2020 21:19, John Snow wrote: On 5/21/20 5:56 AM, Derek Su wrote: Hi, The cluster_size got from backup_calculate_cluster_size(), MAX(BACKUP_CLUSTER_SIZE_DEFAULT, bdi.cluster_size), is 64K regardless of the target image's cluster s

[Bug 1879425] Re: The thread of "CPU 0 /KVM" keeping 99.9%CPU

2020-05-21 Thread cliff chen
Appreciate any comments or clues -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879425 Title: The thread of "CPU 0 /KVM" keeping 99.9%CPU Status in QEMU: New Bug description: Hi Expert: T

Re: [PATCH v2 0/7] Misc display/sm501 clean ups and fixes

2020-05-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1590089984.git.bala...@eik.bme.hu/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH v2 1/3] hw/riscv: spike: Remove deprecated ISA specific machines

2020-05-21 Thread Bin Meng
On Fri, May 8, 2020 at 3:21 AM Alistair Francis wrote: > > The ISA specific Spike machines have been deprecated in QEMU since 4.1, > let's finally remove them. > > Signed-off-by: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/riscv/spike.c | 217 -

Re: [PATCH v2 1/2] spapr: Add associativity reference point count to machine info

2020-05-21 Thread Reza Arbab
On Thu, May 21, 2020 at 01:34:37AM +0200, Greg Kurz wrote: On Mon, 18 May 2020 16:44:17 -0500 Reza Arbab wrote: @@ -944,8 +946,9 @@ static void spapr_dt_rtas(SpaprMachineState *spapr, void *fdt) qemu_hypertas->str, qemu_hypertas->len)); g_string_free(qemu_hypertas, T

Re: [PATCH v3 07/17] block/io: support int64_t bytes in bdrv_co_do_copy_on_readv()

2020-05-21 Thread Eric Blake
On 4/30/20 6:10 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be

Re: [PATCH 1/2] hw/riscv: sifive_u: Remove the riscv_ prefix of the soc* functions

2020-05-21 Thread Alistair Francis
On Thu, May 21, 2020 at 7:48 AM Philippe Mathieu-Daudé wrote: > > On 5/21/20 4:42 PM, Bin Meng wrote: > > From: Bin Meng > > > > To keep consistency with the machine* functions, remove the riscv_ > > prefix of the soc* functions. > > > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis A

Re: [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support

2020-05-21 Thread Guenter Roeck
On 5/21/20 2:04 PM, Peter Maydell wrote: > On Sun, 17 May 2020 at 17:21, Guenter Roeck wrote: >> >> Implement full support for the watchdog in i.MX systems. >> Pretimeout support is optional because the watchdog hardware >> on i.MX31 does not support pretimeouts. >> >> Signed-off-by: Guenter Roeck

[PATCH v4 6/6] migration/block-dirty-bitmap: forbid migration by generated node-name

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
It actually never worked with libvirt, as auto-generated names are different on source and destination. It's unsafe and useless to migrate by auto-generated node-names, so let's forbid it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich Reviewed-by: Eric Blake --- m

[PATCH v4 4/6] iotests: 194: test also migration of dirty bitmap

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
Test that dirty bitmap migration works when we deal with mirror. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/194 | 14 ++ tests/qemu-iotests/194.out | 6 ++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/

Re: [PATCH 3/4] hw/riscv: Allow creating multiple instances of PLIC

2020-05-21 Thread Alistair Francis
On Fri, May 15, 2020 at 11:39 PM Anup Patel wrote: > > We extend PLIC emulation to allow multiple instances of PLIC in > a QEMU RISC-V machine. To achieve this, we remove first HART id > zero assumption from PLIC emulation. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Alistair

[PATCH v4 3/6] migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
Important thing for bitmap migration is to select destination block node to obtain the migrated bitmap. Prepatch, on source we use bdrv_get_device_or_node_name() to identify the node, and on target we do bdrv_lookup_bs. bdrv_get_device_or_node_name() returns blk name only for direct children of bl

[PATCH v4 5/6] migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name once

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich Reviewed-by: Eric Blake --- migration/block-dirty-bitmap.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c index 04a5

[PATCH v4 0/6] fix migration with bitmaps and mirror

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
v4: (Max's patch marking filters as filters already in master) 03: careful select child of filter, avoid crash 04: add Eric's r-b 05-06: tweak error message, keep Andrey's r-b, add Eric's r-b Vladimir Sementsov-Ogievskiy (6): migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration

[PATCH v4 2/6] block/dirty-bitmap: add bdrv_has_named_bitmaps helper

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
To be used for bitmap migration in further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich Reviewed-by: Eric Blake --- include/block/dirty-bitmap.h | 1 + block/dirty-bitmap.c | 13 + 2 files changed, 14 insertions(+) diff --git a/includ

[PATCH v4 1/6] migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
Split out handling one bs, it is needed for the following commit, which will handle BlockBackends separately. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- migration/block-dirty-bitmap.c | 89 +++--- 1 file changed, 49 insertions(+), 40 dele

Re: [PATCH v3 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-21 Thread Eric Blake
On 5/18/20 1:01 PM, Thomas Huth wrote: Now that the "name" parameter is gone, there is hardly any difference between NetLegacy and Netdev anymore, so we can drop NetLegacy and always use Netdev to simplify the code quite a bit. The only two differences that were really left between Netdev and Ne

Re: [PATCH v3 5/7] iotests: 194: test also migration of dirty bitmap

2020-05-21 Thread Eric Blake
On 5/15/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote: Test that dirty bitmap migration works when we deal with mirror. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/194 | 14 ++ tests/qemu-iotests/194.out | 6 ++ 2 files changed, 16 insertions(+),

Re: [PATCH v3 6/7] migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name once

2020-05-21 Thread Eric Blake
On 5/15/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich --- migration/block-dirty-bitmap.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/migration/block-dirty-bitmap.c b/migrat

[PULL v2 00/29] target-arm queue

2020-05-21 Thread Peter Maydell
7:28 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200521-1 for you to fetch changes up to fafe7229272f39500c14845bc7ea60a8504a5a20: linux-user/arm/signal.c: Drop TARGET_CONFIG_CPU_32 (2020-05-21 22:0

Re: [PATCH v3 7/7] migration/block-dirty-bitmap: forbid migration by generated node-name

2020-05-21 Thread Eric Blake
On 5/15/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote: It actually never worked with libvirt, as auto-generated names are different on source and destination. It's unsafe and useless to migrate by auto-generated node-names, so let's forbid it. Signed-off-by: Vladimir Sementsov-Ogievskiy Revie

Re: [PATCH v3 2/8] hw/watchdog: Implement full i.MX watchdog support

2020-05-21 Thread Peter Maydell
On Sun, 17 May 2020 at 17:21, Guenter Roeck wrote: > > Implement full support for the watchdog in i.MX systems. > Pretimeout support is optional because the watchdog hardware > on i.MX31 does not support pretimeouts. > > Signed-off-by: Guenter Roeck > --- > +static Property imx2_wdt_properties[]

Re: [PATCH v3 4/7] migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration during mirror job

2020-05-21 Thread Eric Blake
On 5/19/20 5:51 AM, Vladimir Sementsov-Ogievskiy wrote: 18.05.2020 23:36, Eric Blake wrote: On 5/15/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote: Important thing for bitmap migration is to select destination block node to obtain the migrated bitmap. +    /* Skip filters without bitmao

Re: cluster_size got from backup_calculate_cluster_size()

2020-05-21 Thread Vladimir Sementsov-Ogievskiy
21.05.2020 21:19, John Snow wrote: On 5/21/20 5:56 AM, Derek Su wrote: Hi, The cluster_size got from backup_calculate_cluster_size(), MAX(BACKUP_CLUSTER_SIZE_DEFAULT, bdi.cluster_size), is 64K regardless of the target image's cluster size. Not regardless -- but it is using 64K as a minimum.

Re: [PATCH QEMU v23 09/18] vfio: Add save state functions to SaveVMHandlers

2020-05-21 Thread Peter Xu
On Wed, May 20, 2020 at 11:54:39PM +0530, Kirti Wankhede wrote: > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes. If pending_bytes > 0, go through below steps. > - read data_offset - indicates kernel driver to write data to staging > buffer. > - read data_size - amount

[PATCH 2/6] hw/misc: Add NPCM7xx System Global Control Registers device model

2020-05-21 Thread Havard Skinnemoen
Implement a device model for the System Global Control Registers in the NPCM730 and NPCM750 BMC SoCs. This is primarily used to enable SMP boot (the boot ROM spins reading the SCRPAD register); other registers are best effort for now. The reset values of the MDLR and PWRON registers are determine

[PATCH 6/6] hw/arm: Add two NPCM7xx-based machines

2020-05-21 Thread Havard Skinnemoen
This adds two new machines: - npcm750-evb: Nuvoton NPCM750 Evaluation Board. - quanta-gsj: A board with a NPCM730 chip. They rely on the NPCM7xx SoC device to do the heavy lifting. They are almost completely identical at the moment, apart from the SoC type, which currently only changes the re

[PATCH 1/6] npcm7xx: Add config symbol

2020-05-21 Thread Havard Skinnemoen
Add a config symbol for the NPCM7xx BMC SoC family that subsequent patches can use in Makefiles. Reviewed-by: Tyrone Ting Signed-off-by: Havard Skinnemoen --- default-configs/arm-softmmu.mak | 1 + hw/arm/Kconfig | 8 2 files changed, 9 insertions(+) diff --git a/defa

  1   2   3   4   5   6   >