27.04.2020 7:08, Andrey Shinkevich wrote:
1. The mirror technology instantiates its own BLK, sets 0/BLK_PERM_ALL for it
on exit and then, via subsequent call to bdrv_child_refresh_perms(), calls
bdrv_child_try_set_perm(). We don't have the extra BLK for our filter in stream
and do call the sam
Because ppc fpu-helper are always clearing float_flag_inexact,
So is that possible to optimize the performance when float_flag_inexact
are cleared?
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
On Sat, Apr 25, 2020 at 11:24:14AM +0200, Paolo Bonzini wrote:
> On 24/04/20 14:16, Dr. David Alan Gilbert wrote:
> >>> I was trying to work out whether we need to migrate this state,
> >>> and I'm not sure. Andrew, do you know? I think this comes down
> >>> to "at what points in QEMU's kvm run loo
On Fri, 24 Apr 2020 10:30:23 +0100
Daniel P. Berrangé wrote:
> On Thu, Apr 23, 2020 at 01:36:48PM -0400, Cleber Rosa wrote:
> >
> >
> > - Original Message -
> > > From: "Daniel P. Berrangé"
> > > To: "Cleber Rosa"
> > > Cc: "Peter Maydell" , "Fam Zheng"
> > > , "Thomas Huth" , "Berald
On Fri, 24 Apr 2020 08:57:46 +0200
Erik Skultety wrote:
> On Thu, Apr 23, 2020 at 11:28:21PM +0200, Philippe Mathieu-Daudé
> wrote:
> > On 4/23/20 7:13 PM, Daniel P. Berrangé wrote:
> > > On Thu, Apr 23, 2020 at 01:04:13PM -0400, Cleber Rosa wrote:
> > > > - Original Message -
> > > > > F
On Thu, 23 Apr 2020 23:28:21 +0200
Philippe Mathieu-Daudé wrote:
> On 4/23/20 7:13 PM, Daniel P. Berrangé wrote:
> > On Thu, Apr 23, 2020 at 01:04:13PM -0400, Cleber Rosa wrote:
> >> - Original Message -
> >>> From: "Peter Maydell"
> >>> To: "Markus Armbruster"
> >>> Cc: "Fam Zheng" , "
On Thu, 23 Apr 2020 18:50:47 +0100
Peter Maydell wrote:
> On Thu, 23 Apr 2020 at 18:37, Cleber Rosa wrote:
> > We're already using the shared x86 runners, but with a different
> > goal. The goal of the "Gating CI" is indeed to expand on non-x86
> > environments. We're in a "chicken and egg" ki
I am interesting doing some help in this area.
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
I am going to do that in version 3. Please review the changes in the version 2
first.
Thanks,
Andrey
From: Vladimir Sementsov-Ogievskiy
Sent: Tuesday, April 21, 2020 4:12 PM
To: Andrey Shinkevich ; qemu-bl...@nongnu.org
Cc: qemu-devel@nongnu.org ; kw...@redhat.
1. The mirror technology instantiates its own BLK, sets 0/BLK_PERM_ALL for it
on exit and then, via subsequent call to bdrv_child_refresh_perms(), calls
bdrv_child_try_set_perm(). We don't have the extra BLK for our filter in stream
and do call the same function directly.
2. The function remove
> -Original Message-
> From: Lukas Straub
> Sent: Monday, April 27, 2020 5:19 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: [PATCH v3 4/6] net/colo-compare.c: Only hexdump packets if tracing
> is enabled
>
> Else
> -Original Message-
> From: Lukas Straub
> Sent: Monday, April 27, 2020 5:19 AM
> To: qemu-devel
> Cc: Zhang, Chen ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in
> compare_chr_send
>
> The chr_out ch
On 2020/4/26 下午6:55, Helge Deller wrote:
The tulip network driver in a qemu-system-hppa emulation is broken in
the sense that bigger network packages aren't received any longer and
thus even running e.g. "apt update" inside the VM fails.
The breakage was introduced by commit 8ffb7265af ("check
On 2020/4/26 下午3:57, Peter Maydell wrote:
On Sun, 26 Apr 2020 at 03:50, Jason Wang wrote:
Looks good to me.
Would you please send a formal patch and cc Peter.
Consider we are about to release 5.0, it's better for him to apply the
patch directly.
I am not applying any further patches for 5
> -Original Message-
> From: Lukas Straub
> Sent: Sunday, April 26, 2020 7:25 PM
> To: Derek Su
> Cc: qemu-devel@nongnu.org; lizhij...@cn.fujitsu.com; chy...@qnap.com;
> jasow...@redhat.com; ctch...@qnap.com; Zhang, Chen
> ; jwsu1...@gmail.com
> Subject: Re: [PATCH v5 1/1] colo-compare
> -Original Message-
> From: Derek Su
> Sent: Friday, April 24, 2020 12:37 PM
> To: Zhang, Chen ; Lukas Straub
>
> Cc: qemu-devel ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: Re: [PATCH 1/3] net/colo-compare.c: Create event_bh with the right
> AioCont
The second argument 'id' is a pointer. Pass NULL rather than 0.
Signed-off-by: Masahiro Yamada
---
softmmu/vl.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 32c0047889..afd2615fb3 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@
macOS API for dealing with serial ports/ttys is identical to BSDs.
Signed-off-by: Mikhail Gusarov
---
Note that the same file has a line
> #endif /* linux || sun */
that is severely out of date.
chardev/char-serial.c | 2 +-
include/qemu/osdep.h | 2 +-
2 files changed, 2 insertions(+), 2 del
Else the log will be flooded if there is a lot of network
traffic.
Signed-off-by: Lukas Straub
---
net/colo-compare.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index ff6a740284..6634911770 100644
--- a/net/colo-compare.
In colo_compare_complete, insert CompareState into net_compares
only after everything has been initialized.
In colo_compare_finalize, remove CompareState from net_compares
before anything is deinitialized.
Signed-off-by: Lukas Straub
---
net/colo-compare.c | 47 +++---
The chr_out chardev is connected to a filter-redirector
running in the main loop. qemu_chr_fe_write_all might block
here in compare_chr_send if the (socket-)buffer is full.
If another filter-redirector in the main loop want's to
send data to chr_pri_in it might also block if the buffer
is full. Thi
If the colo-compare object is removed before failover and a
checkpoint happens, qemu crashes because it tries to lock
the destroyed event_mtx in colo_notify_compares_event.
Fix this by checking if everything is initialized by
introducing a new variable colo_compare_active which
is protected by a n
This will be needed in the next patch.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Reviewed-by: Zhang Chen
---
chardev/char.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index e77564060d..5c8014199f 100644
--- a/chard
Hello Everyone,
The performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in
compare_chr_send", has been fixed in this version by putting the packets in a
queue instead of returning error. I also found and fixed some more bugs.
Benchmark results:
Client-to-server tcp:
without patch:
qemu_bh_new will set the bh to be executed in the main
loop. This causes crashes as colo_compare_handle_event assumes
that it has exclusive access the queues, which are also
concurrently accessed in the iothread.
Create the bh with the AioContext of the iothread to fulfill
these assumptions and fi
Patchew URL: https://patchew.org/QEMU/cover.1587927878.git.lukasstra...@web.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v2 0/6] colo-compare bugfixes
Message-id: cover.1587927878.git.lukasstra...@web.de
Type: series
===
Else the log will be flooded if there is a lot of network
traffic.
Signed-off-by: Lukas Straub
---
net/colo-compare.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index ff6a740284..6634911770 100644
--- a/net/colo-compare.
In colo_compare_complete, insert CompareState into net_compares
only after everything has been initialized.
In colo_compare_finalize, remove CompareState from net_compares
before anything is deinitialized.
Signed-off-by: Lukas Straub
---
net/colo-compare.c | 47 +++---
This will be needed in the next patch.
Signed-off-by: Lukas Straub
Reviewed-by: Marc-André Lureau
Reviewed-by: Zhang Chen
---
chardev/char.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index e77564060d..5c8014199f 100644
--- a/chard
Hi all,
I am trying to make GPU and Audio PCI passthrough to VM using qemu.
display and audio is working fine except HDMI audio. HDMI audio data is
going to HDMI but not able to be heard in hdmi. Here i am passing pci-id's
of VGA and Audio to the qemu with vfio. Anything else to be done? am
qemu_bh_new will set the bh to be executed in the main
loop. This causes crashes as colo_compare_handle_event assumes
that it has exclusive access the queues, which are also
concurrently accessed in the iothread.
Create the bh with the AioContext of the iothread to fulfill
these assumptions and fi
The chr_out chardev is connected to a filter-redirector
running in the main loop. qemu_chr_fe_write_all might block
here in compare_chr_send if the (socket-)buffer is full.
If another filter-redirector in the main loop want's to
send data to chr_pri_in it might also block if the buffer
is full. Thi
Hello Everyone,
The performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in
compare_chr_send", has been fixed in this version by putting the packets in a
queue instead of returning error. I also found and fixed some more bugs.
Benchmark results:
Client-to-server tcp:
without patch:
If the colo-compare object is removed before failover and a
checkpoint happens, qemu crashes because it tries to lock
the destroyed event_mtx in colo_notify_compares_event.
Fix this by checking if everything is initialized by
introducing a new variable colo_compare_active which
is protected by a n
On Fri, Apr 24, 2020 at 11:03:14AM +0200, Cornelia Huck wrote:
> Add 5.1 machine types for arm/i440fx/q35/s390x/spapr.
>
> Signed-off-by: Cornelia Huck
Reviewed-by: Michael S. Tsirkin
> ---
>
> Still keeping the default cpu model version on x86 at v1.
>
> I'll queue this to my s390-next bran
From: Alistair Francis
Signed-off-by: Alistair Francis
---
target/riscv/pmp.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
index 0e6b640fbd..5aba4d13ea 100644
--- a/target/riscv/pmp.c
+++ b/target/riscv/pmp.c
@@
From: Alistair Francis
This adds a barebone OpenTitan machine to QEMU.
Signed-off-by: Alistair Francis
---
MAINTAINERS | 10 ++
default-configs/riscv32-softmmu.mak | 1 +
default-configs/riscv64-softmmu.mak | 11 +-
hw/riscv/Kconfig| 5 +
hw/ri
From: Alistair Francis
The Ibex core contains a PLIC that although similar to the RISC-V spec
is not RISC-V spec compliant.
This patch implements a Ibex PLIC in a somewhat generic way.
As the current RISC-V PLIC needs tidying up, my hope is that as the Ibex
PLIC move towards spec compliance thi
From: Alistair Francis
Signed-off-by: Alistair Francis
---
target/riscv/cpu.c | 10 ++
target/riscv/cpu.h | 1 +
2 files changed, 11 insertions(+)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 8f837edf8d..235101f685 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
From: Alistair Francis
If the reset vector is set in the init function don't set it again in
realise.
Signed-off-by: Alistair Francis
---
target/riscv/cpu.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 0
From: Alistair Francis
Signed-off-by: Alistair Francis
---
hw/riscv/opentitan.c | 19 +--
include/hw/riscv/opentitan.h | 3 +++
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c
index 1f9f4a8dd0..3a845fbb7b 10064
From: Alistair Francis
Signed-off-by: Alistair Francis
---
include/hw/riscv/boot.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h
index df80051fbc..1c37bfbb4f 100644
--- a/include/hw/riscv/boot.h
+++ b/include/hw/riscv/boot.h
@@ -21,6 +21,7
From: Alistair Francis
Signed-off-by: Alistair Francis
---
hw/riscv/opentitan.c | 24 ++--
include/hw/riscv/opentitan.h | 13 +
2 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c
index 3a845fbb7b..8
From: Alistair Francis
OpenTitan is an open source silicon Root of Trust (RoT) project. This
series adds initial support for the OpenTitan machine to QEMU.
This series add the Ibex CPU to the QEMU RISC-V target. It then adds the
OpenTitan machine, the Ibex UART and the Ibex PLIC.
The UART has b
From: Alistair Francis
This is the initial commit of the Ibex UART device. Serial TX is
working, while RX has been implemeneted but untested.
This is based on the documentation from:
https://docs.opentitan.org/hw/ip/uart/doc/
Signed-off-by: Alistair Francis
---
MAINTAINERS |
From: Alistair Francis
Signed-off-by: Alistair Francis
---
target/riscv/cpu_bits.h | 3 +++
target/riscv/csr.c | 40
2 files changed, 43 insertions(+)
diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h
index 8a145e0a32..690f327828 1006
Signed-off-by: Alistair Francis
---
target/riscv/csr.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 6b6080592a..438d0a61ee 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -854,12 +854,21 @@ static int write_satp(CPURISCVSta
Signed-off-by: Alistair Francis
---
target/riscv/cpu_bits.h | 1 +
target/riscv/cpu_helper.c | 8 +---
target/riscv/op_helper.c | 8 ++--
target/riscv/translate.c | 10 --
4 files changed, 4 insertions(+), 23 deletions(-)
diff --git a/target/riscv/cpu_bits.h b/target/riscv
Signed-off-by: Alistair Francis
---
target/riscv/csr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 11d184cd16..88cf0ff600 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -940,7 +940,6 @@ static int read_htinst(CPURISCVState *env, in
Signed-off-by: Alistair Francis
---
target/riscv/cpu_helper.c | 54 +++
1 file changed, 21 insertions(+), 33 deletions(-)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 075675c59c..2ac599505f 100644
--- a/target/riscv/cpu_helper.c
+++
Call the helper_hyp_tlb_flush() function on hfence instructions which
will generate an illegal insruction execption if we don't have
permission to flush the Hypervisor level TLBs.
Signed-off-by: Alistair Francis
---
target/riscv/helper.h | 5
target/riscv/insn_trans/trans
Signed-off-by: Alistair Francis
---
target/riscv/cpu_bits.h | 5 +++--
target/riscv/cpu_helper.c | 20
target/riscv/csr.c| 6 +++---
3 files changed, 22 insertions(+), 9 deletions(-)
diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h
index bb4ee3fc35.
Signed-off-by: Alistair Francis
---
target/riscv/cpu_helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index 93df7a896d..f7ada23861 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -925,
Signed-off-by: Alistair Francis
---
target/riscv/csr.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 438d0a61ee..04f3471f2e 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -858,6 +858,8 @@ static int read_hstatus(CPURISCVState *
Signed-off-by: Alistair Francis
---
target/riscv/cpu_bits.h | 1 +
target/riscv/helper.h | 3 +
target/riscv/insn32-64.decode | 5 +
target/riscv/insn32.decode | 11 +
target/riscv/insn_trans/trans_rvh.inc.c | 340 +++
This series updates the experimental QEMU RISC-V Hypervisor spec to the
v0.6 draft implementation.
THis includes support for the new 2-stage lookup instructions and the new
CSRs.
This was tested by running 32-bit and 64-bit Xvisor on QEMU and starting
Linux guests.
Alistair Francis (15):
tar
Signed-off-by: Alistair Francis
---
target/riscv/cpu.h| 2 ++
target/riscv/cpu_bits.h | 1 +
target/riscv/cpu_helper.c | 18 ++
3 files changed, 21 insertions(+)
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index d0e7f5b9c5..e44a7a91e4 100644
--- a/target/risc
Signed-off-by: Alistair Francis
---
target/riscv/insn32.decode| 6 +-
.../riscv/insn_trans/trans_privileged.inc.c | 40 -
target/riscv/insn_trans/trans_rvh.inc.c | 57 +++
target/riscv/translate.c | 1 +
4 files change
Signed-off-by: Alistair Francis
---
target/riscv/cpu_bits.h | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h
index 6b97c27711..8a145e0a32 100644
--- a/target/riscv/cpu_bits.h
+++ b/target/riscv/cpu_bits.h
@@ -422,
Signed-off-by: Alistair Francis
---
target/riscv/cpu_helper.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index ed64190386..0d4a7b752d 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -
Signed-off-by: Alistair Francis
---
target/riscv/cpu_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index bc80aa87cf..ed64190386 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -456,7 +45
It could be an issue of how the kernel presents the CPU topology.
Hardware: AMD Ryzen 3900X 12 core 24 threads (SMT)
Host: Kernel 5.6.6, QEMU 4.2
virsh capabilities | grep "cpu id"
From: Halloween
Signed-off-by: Halloween
---
hw/virtio/trace-events| 12
hw/virtio/virtio-crypto.c | 29 -
include/hw/virtio/virtio-crypto.h | 11 ---
3 files changed, 28 insertions(+), 24 deletions(-)
diff --git a/hw/virtio/
From: Halloween
Signed-off-by: Halloween
---
hw/virtio/trace-events| 12
hw/virtio/virtio-crypto.c | 29 -
include/hw/virtio/virtio-crypto.h | 11 ---
3 files changed, 28 insertions(+), 24 deletions(-)
diff --git a/hw/virtio/
From: Halloween
Signed-off-by: Halloween
---
hw/virtio/trace-events| 12
hw/virtio/virtio-crypto.c | 29 -
include/hw/virtio/virtio-crypto.h | 11 ---
3 files changed, 28 insertions(+), 24 deletions(-)
diff --git a/hw/virtio/
On Fri, 10 Apr 2020 10:00:56 +0800
Derek Su wrote:
> The patch is to fix the "pkt" memory leak in packet_enqueue().
> The allocated "pkt" needs to be freed if the colo compare
> primary or secondary queue is too big.
>
> Replace the error_report of full queue with a trace event.
>
> Signed-off-
The tulip network driver in a qemu-system-hppa emulation is broken in
the sense that bigger network packages aren't received any longer and
thus even running e.g. "apt update" inside the VM fails.
The breakage was introduced by commit 8ffb7265af ("check frame size and
r/w data length") which added
I had the same problem when I tried to run
[boot.asm](https://github.com/yifengyou/The-design-and-implementation-
of-a-64-bit-os/blob/master/code/c03/1/boot.asm).
i tested `qemu-system-x86_64` and `qemu-system-i386` with
[gdb_init_real_mode.txt](https://github.com/mhugo/gdb_init_real_mode/blob/mas
On Sun, 26 Apr 2020 at 03:50, Jason Wang wrote:
> Looks good to me.
>
> Would you please send a formal patch and cc Peter.
>
> Consider we are about to release 5.0, it's better for him to apply the
> patch directly.
I am not applying any further patches for 5.0 unless they come
with an attached
Traceback (most recent call last):
File "/usr/share/virt-manager/virtManager/asyncjob.py", line 75, in cb_wrapper
callback(asyncjob, *args, **kwargs)
File "/usr/share/virt-manager/virtManager/asyncjob.py", line 111, in tmpcb
callback(*args, **kwargs)
File "/usr/share/virt-manager/virt
Public bug reported:
This issue is introduced in QEMU 4.2.0 (4.1.0 is working fine)
My root disk is a LVM2 volume thin snapshot that is marked as read-only
But when I try to start the domain (using virt-manager) I get the following
error:
Error starting domain: internal error: process exited wh
This patch is trying to fix the same issue with me.
However, our fix is different.
I think that check the s->reconnect_timer is better.
Thanks,
Feng Li
Marc-André Lureau 于2020年4月24日周五 上午3:16写道：
>
> Hi
>
> On Thu, Apr 23, 2020 at 8:41 PM Dima Stepanov wrote:
> >
> > During vhost-user reconnec
On 2020/4/26 下午2:57, Bin Meng wrote:
Hi Jason,
On Tue, Apr 21, 2020 at 10:31 PM Bin Meng wrote:
Hi,
The cadence_gem does the TX checksum offload by:
/* Is checksum offload enabled? */
if (s->regs[GEM_DMACFG] & GEM_DMACFG_TXCSUM_OFFL) {
73 matches
Mail list logo
