John Snow writes:
> On 4/15/20 1:55 PM, Peter Maydell wrote:
>> On Wed, 15 Apr 2020 at 18:33, John Snow wrote:
>>>
>>> sphinx-build is the name of the script entry point from the sphinx
>>> package itself. sphinx-build-3 is a pacakging convention by Linux
>>> distributions. Prefer, where possibl
Consider including a cover letter in the future, and use it to explain
what you're proposing and why. The why is even more important for an
RFC.
On Apr 15 15:26, Philippe Mathieu-Daudé wrote:
> On 4/15/20 3:20 PM, Klaus Birkelund Jensen wrote:
> >
> > I'll get the v1.3 series ready next.
> >
>
> Cool. What really matters (to me) is seeing tests. If we can merge tests
> (without multiple namespaces) before the rest of your series, even be
Adalbert Lazãr writes:
> On Wed, 15 Apr 2020 16:11:14 +0200, Markus Armbruster
> wrote:
>> Adalbert Lazãr writes:
[...]
>> > Until this moment, I did not think that we can use "server=no" through QMP
>> > :))
>>
>> Start here:
>>
>> $ socat "READLINE,history=$HOME/.qmp_history,prompt=QM
John Snow writes:
> On 4/14/20 3:53 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>
>>> Debian:
>>> 8/Jessie: We don't support this anymore AFAIUI.
>>
>> Correct.
>>
>> docs/system/build-platforms.rst:
>>
>> For distributions with long-lifetime releases, the project will aim
>
Hi Kevin,
I tried to start vhost-user block device backend server with the
following command,
$ qemu-storage-daemon --blockdev
driver=file,node-name=disk,filename=file.img,read-only=off \
--object
vhost-user-blk-server,id=disk,unix-socket=/tmp/vu_blk.socket,node-name=disk,wr
On 4/15/20 12:07 PM, Stephen Long wrote:
> +++ b/target/arm/sve.decode
> @@ -147,6 +147,7 @@
> &rprrr_esz rn=%reg_movprfx
> @rdn_pg_rm_ra esz:2 . ra:5 ... pg:3 rm:5 rd:5 \
> &rprrr_esz rn=%reg_movprfx
> +@rd5_pg_rn_rm esz:2 . rm:5 ... pg:3 r
Very good point, I did neglect ramfb resolution changes... But there is one
important thing: it *can* cause a QEMU crash, a potentially exploitable
one, not always a guest crash. That's what motivated my heavy-handed
approach since allowing resolution change would have necessitated a good
deal of s
Tested the proposed patch from Sergei Trofimovich, and it solves the
problem, while doesn't break the other archs I use (mips64,arm,aarch64
also tested).
Thank you!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchp
From: Omar Sandoval
QEMU's local 9pfs server passes through O_NOATIME from the client. If
the QEMU process doesn't have permissions to use O_NOATIME (namely, it
does not own the file nor have the CAP_FOWNER capability), the open will
fail. This causes issues when from the client's point of view,
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
fourth release candidate for the QEMU 5.0 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu-project.org/qemu-5.0.0-rc3.tar.xz
http://down
Proposed possible fix as https://lists.nongnu.org/archive/html/qemu-
devel/2020-04/msg02545.html
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1872847
Title:
qemu-alpha linux-user breaks python3.6
* Remove individual option fields. Common field have been left.
Signed-off-by: Alexey Krasikov
---
crypto/Makefile.objs | 1 +
crypto/secret_interface.c | 156 ++
include/crypto/secret_interface.h | 119 ---
3 files changed,
* Add child 'secret' class from basic 'secret_common'
with 'data' and 'file' properties.
Signed-off-by: Alexey Krasikov
---
crypto/secret.c | 167
include/crypto/secret.h | 133
2 files changed, 300 insertions(+)
* Add the ability for the secret object to obtain secret data from the
Linux in-kernel key managment and retention facility, as an extra option
to the existing ones: reading from a file or passing directly as a
string.
The secret is identified by the key serial number. The upper layers
* Rename for future division into subclasses. Most part of the interface
will remain in basic common class.
Signed-off-by: Alexey Krasikov
---
crypto/{secret.c => secret_interface.c} | 0
include/crypto/{secret.h => secret_interface.h} | 0
2 files changed, 0 insertions(+), 0 deletions
* test_secret_seckey_bad_key_access_right() is not working yet.
We don't know yet if this due a bag in the Linux kernel or
whether it's normal syscall behavior.
We've requested information from kernel maintainer.
Signed-off-by: Alexey Krasikov
---
tests/test-crypto-secret.c | 138 +
Noticed by Barnabás Virágh as a python-3.7 failue on qemu-alpha.
The bug shows up on alpha as it's one of the targets where
EPOLL_CLOEXEC differs from other targets:
sysdeps/unix/sysv/linux/alpha/bits/epoll.h: EPOLL_CLOEXEC = 0100
sysdeps/unix/sysv/linux/bits/epoll.h:EPOLL_CLO
AMD does not use dies. For AMD dies is normally set to 1. You probably
have to pass dies in some other ways. Did you try the latest qemu v 5.0?
Please try it.
Qemu expects the user to configure the topology based on their requirement.
Try replacing
with
You can also use the numa configuratio
On Wed, Apr 15, 2020 at 12:46 PM David Hildenbrand wrote:
>
>
>
> > Am 15.04.2020 um 21:29 schrieb Alexander Duyck :
> >
> > On Wed, Apr 15, 2020 at 11:17 AM David Hildenbrand
> > wrote:
> >>
> >>>
> >>> The comment above explains the "why". Basically poisoning a page will
> >>> dirty it. So wh
On 4/15/20 2:11 PM, Alberto Garcia wrote:
On Fri 10 Apr 2020 11:29:59 AM CEST, Vladimir Sementsov-Ogievskiy wrote:
Should we also document that extended L2 entries are incompatible
with raw external files? [...] After all, when raw external file is
enabled, the entire image is allocated, at whic
On 4/15/20 2:02 PM, Alberto Garcia wrote:
Although we cannot create these images with qemu-img it is still
possible to do it using an external tool. QEMU should refuse to open
them until the data-file-raw bit is cleared with 'qemu-img check'.
Signed-off-by: Alberto Garcia
---
block/qcow2.c
Same problem for Ryzen 9 3900X. There should be 4x L3 caches, but there
are only 3.
Same results with "host-passthrough" and "EPYC-IBPB". Windows doesn't
recognize the correct L3 cache layout.
>From coreinfo.exe:
Logical Processor to Cache Map:
**-- Data Cache 0, Le
On Mon, Apr 13, 2020 at 12:55 PM Michael S. Tsirkin wrote:
>
> On Wed, Apr 08, 2020 at 12:51:20PM +0200, Igor Mammedov wrote:
> > On Tue, 7 Apr 2020 16:50:17 +0200
> > Julia Suvorova wrote:
> >
> > > Raise an error when trying to hot-plug/unplug a device through QMP to a
> > > device
> > > with
* change condition from QCRYPTO_SECRET_FORMAT_RAW
to QCRYPTO_SECRET_FORMAT_BASE64 in if-operator, because
this is potencial error if you add another format value.
Signed-off-by: Alexey Krasikov
---
crypto/secret.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/sec
* Get function returned value of properties 'data' insteed of returning
value of raw data internal field. This error did not affect anyone,
because no one called the get function.
Signed-off-by: Alexey Krasikov
---
crypto/secret.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
On Tue, Apr 14, 2020 at 10:07 AM Marcel Apfelbaum
wrote:
>
> Hi Julia,
>
> On 4/7/20 5:50 PM, Julia Suvorova wrote:
> > Raise an error when trying to hot-plug/unplug a device through QMP to a
> > device
> > with disabled hot-plug capability. This makes the device behaviour more
> > consistent and
> Am 15.04.2020 um 21:29 schrieb Alexander Duyck :
>
> On Wed, Apr 15, 2020 at 11:17 AM David Hildenbrand wrote:
>>
>>>
>>> The comment above explains the "why". Basically poisoning a page will
>>> dirty it. So why hint a page as free when that will drop it back into
>>> the guest and result
On Wed, Apr 15, 2020 at 11:17 AM David Hildenbrand wrote:
>
> >
> > The comment above explains the "why". Basically poisoning a page will
> > dirty it. So why hint a page as free when that will drop it back into
> > the guest and result in it being dirtied again. What you end up with
> > is all th
On Mon, 23 Mar 2020 at 11:29, Philippe Mathieu-Daudé wrote:
>
> vu_queue_pop() returns memory that must be freed with free().
>
> Cc: qemu-sta...@nongnu.org
> Reported-by: Coverity (CID 1421887 ALLOC_FREE_MISMATCH)
> Suggested-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> co
On Fri 10 Apr 2020 11:29:59 AM CEST, Vladimir Sementsov-Ogievskiy wrote:
>> Should we also document that extended L2 entries are incompatible
>> with raw external files? [...] After all, when raw external file is
>> enabled, the entire image is allocated, at which point subclusters
>> don't make mu
Signed-off-by: Stephen Long
---
Realized that I was handling the predicate register incorrectly for the
32 bit case for histcnt_s. There might be a cleaner way to write the
handler function.
target/arm/helper-sve.h| 7
target/arm/sve.decode | 6
target/arm/sve_helper.c|
Although we cannot create these images with qemu-img it is still
possible to do it using an external tool. QEMU should refuse to open
them until the data-file-raw bit is cleared with 'qemu-img check'.
Signed-off-by: Alberto Garcia
---
block/qcow2.c | 39 +
Signed-off-by: Stephen Long
---
Submitting patch for early review. We can probably lookup two elements
at a time for the 32 bit case for histcnt_s.
target/arm/helper-sve.h| 7 +
target/arm/sve.decode | 6
target/arm/sve_helper.c| 63 ++
On 4/15/20 7:59 AM, Stephen Long wrote:
> Signed-off-by: Stephen Long
> ---
> Whoops, forgot to complete the comment for do_match2()
>
> target/arm/helper-sve.h| 10 +++
> target/arm/sve.decode | 5
> target/arm/sve_helper.c| 59 ++
> ta
>
> The comment above explains the "why". Basically poisoning a page will
> dirty it. So why hint a page as free when that will drop it back into
> the guest and result in it being dirtied again. What you end up with
> is all the pages that were temporarily placed in the balloon are dirty
> after
Thanks. I saw the update in the thread.
https://lore.kernel.org/qemu-devel/42f0624d-b0fb-5d96-2921-8994c28b9...@kernkonzept.com/
Looks like you have found a way to take care of your problem.
But We need to fix the CPUID leaf 0x8000'0008 anyways.
Will send the patch to review later this week. Thanks
On 4/15/20 1:55 PM, Peter Maydell wrote:
> On Wed, 15 Apr 2020 at 18:33, John Snow wrote:
>>
>> sphinx-build is the name of the script entry point from the sphinx
>> package itself. sphinx-build-3 is a pacakging convention by Linux
>> distributions. Prefer, where possible, the canonical package
On Wed, 15 Apr 2020 at 18:33, John Snow wrote:
>
> sphinx-build is the name of the script entry point from the sphinx
> package itself. sphinx-build-3 is a pacakging convention by Linux
> distributions. Prefer, where possible, the canonical package name.
This was Markus's code originally; cc'ing
On Wed, 15 Apr 2020 16:11:14 +0200, Markus Armbruster wrote:
> Adalbert Lazãr writes:
>
> > On Wed, 15 Apr 2020 12:37:34 +0200, Marc-André Lureau
> > wrote:
> >> Hi
> >>
> >> On Wed, Apr 15, 2020 at 3:00 AM Adalbert Lazăr
> >> wrote:
> >> >
> >> > qmp_chardev_open_socket() ignores the absen
On Wed, 15 Apr 2020, BALATON Zoltan wrote:
On Wed, 15 Apr 2020, Peter Maydell wrote:
On Mon, 13 Apr 2020 at 23:01, Philippe Mathieu-Daudé
wrote:
Zhang Zi Ming reported a heap overflow in the Drawing Engine of
the SM501 companion chip model, in particular in the COPY_AREA()
macro in sm501_2d_o
On Wed, Apr 15, 2020 at 12:43:01PM -0400, John Snow wrote:
>
>
> On 4/14/20 3:53 AM, Markus Armbruster wrote:
> > John Snow writes:
> >
>
> >> Debian:
> >> 8/Jessie: We don't support this anymore AFAIUI.
> >
> > Correct.
> >
> > docs/system/build-platforms.rst:
> >
> > For distribut
On Wed, 15 Apr 2020 at 16:22, Michael Roth wrote:
>
> The following changes since commit 73995d15557a3cf2328cc6b7982264897c65cf65:
>
> Merge remote-tracking branch
> 'remotes/stsquad/tags/pull-more-fixes-150420-1' into staging (2020-04-15
> 12:02:59 +0100)
>
> are available in the Git reposito
On Wed, 15 Apr 2020, Peter Maydell wrote:
On Mon, 13 Apr 2020 at 23:01, Philippe Mathieu-Daudé wrote:
Zhang Zi Ming reported a heap overflow in the Drawing Engine of
the SM501 companion chip model, in particular in the COPY_AREA()
macro in sm501_2d_operation().
Add a simple check to avoid the
sphinx-build is the name of the script entry point from the sphinx
package itself. sphinx-build-3 is a pacakging convention by Linux
distributions. Prefer, where possible, the canonical package name.
In the event that this resolves to a python2 version, test the
suitability of the binary early in
On Wed, Apr 15, 2020 at 1:08 AM David Hildenbrand wrote:
>
> On 10.04.20 05:41, Alexander Duyck wrote:
> > From: Alexander Duyck
> >
> > We need to make certain to advertise support for page poison tracking if
> > we want to actually get data on if the guest will be poisoning pages. So
> > if fre
When VM starts work very slowly System interrupts in Windows Task
Manager eats up 99% of all CPU resources.
** Attachment added: "Screenshot from 2020-04-15 11-52-47.png"
https://bugs.launchpad.net/qemu/+bug/1873032/+attachment/5354693/+files/Screenshot%20from%202020-04-15%2011-52-47.png
--
Public bug reported:
Description of problem:
After upgrade qemu to 5.0.0-0.3.rc2.fc33 the virtual machine with
Windows 10 after a while starts to work very slowly
I created the virtual machine with Windows 10 with the following config:
- 1 CPU
- 2GB RAM
- With network access
I launch there a we
On 4/14/20 3:53 AM, Markus Armbruster wrote:
> John Snow writes:
>
>> Debian:
>> 8/Jessie: We don't support this anymore AFAIUI.
>
> Correct.
>
> docs/system/build-platforms.rst:
>
> For distributions with long-lifetime releases, the project will aim
> to support the most recen
On Wed, Apr 15, 2020 at 1:17 AM David Hildenbrand wrote:
>
> On 10.04.20 05:41, Alexander Duyck wrote:
> > From: Alexander Duyck
> >
> > Add support for free page reporting. The idea is to function very similar
> > to how the balloon works in that we basically end up madvising the page as
> > not
On 4/15/20 5:22 PM, Michael Roth wrote:
From: Philippe Mathieu-Daudé
On [*] Daniel Berrangé commented:
The QEMU guest agent protocol is not sensible way to access huge
files inside the guest. It requires the inefficient process of
reading the entire data into memory than duplicating i
From: Philippe Mathieu-Daudé
On [*] Daniel Berrangé commented:
The QEMU guest agent protocol is not sensible way to access huge
files inside the guest. It requires the inefficient process of
reading the entire data into memory than duplicating it again in
base64 format, and then copying
From: Philippe Mathieu-Daudé
As we are going to reuse this method, declare it in common
header.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Michael Roth
---
qga/commands-common.h | 18 ++
qga/commands-posix.c | 7 ---
qga/commands-win32.c | 7 ---
3 files
Quoting Philippe Mathieu-Daudé (2020-04-15 08:02:18)
> On 4/15/20 2:34 PM, Daniel P. Berrangé wrote:
> > On Tue, Apr 14, 2020 at 03:30:44PM +0200, Philippe Mathieu-Daudé wrote:
> >> On [*] Daniel Berrangé commented:
> >>
> >>The QEMU guest agent protocol is not sensible way to access huge
> >>
The following changes since commit 73995d15557a3cf2328cc6b7982264897c65cf65:
Merge remote-tracking branch 'remotes/stsquad/tags/pull-more-fixes-150420-1'
into staging (2020-04-15 12:02:59 +0100)
are available in the Git repository at:
git://github.com/mdroth/qemu.git tags/qga-pull-2020-04-1
From: Philippe Mathieu-Daudé
As noted by Daniel Berrangé in [*], the fix from commit 807e2b6fce
which replaced malloc() by try_malloc() is not enough, the process
can still run out of memory a few line later:
346 buf = g_try_malloc0(count + 1);
347 if (!buf) {
348 error_setg(e
From: Philippe Mathieu-Daudé
Extract the common code shared by both POSIX/Win32 implementations.
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Michael Roth
---
qga/commands-common.h | 3 +++
qga/commands-posix.c | 22 +++---
qga/commands-win32.c | 20 +++-
Peter Maydell writes:
> The Linux kernel has dropped support for allowing 32-bit Arm systems
> to host KVM guests (kernel commit 541ad0150ca4aa663a2, which just
> landed upstream in the 5.7 merge window). Mark QEMU's support for
> this configuration as deprecated, so that we can delete that su
(CC Gerd, Qiming, Marcel, qemu-devel for ramfb:)
On 04/14/20 23:20, valerij zaporogeci wrote:
[snip]
> There is a Boot Manager UI display problem, I don't know if this is
> qemu problem, but with the ARM (both 32 and 64 bits, the qemu version
> is 4.2.0, the OVMF is fresh), and using "ramfb" dev
On Mon, 13 Apr 2020 at 23:01, Philippe Mathieu-Daudé wrote:
>
> Zhang Zi Ming reported a heap overflow in the Drawing Engine of
> the SM501 companion chip model, in particular in the COPY_AREA()
> macro in sm501_2d_operation().
>
> Add a simple check to avoid the heap overflow.
> diff --git a/hw/
Signed-off-by: Stephen Long
---
Whoops, forgot to complete the comment for do_match2()
target/arm/helper-sve.h| 10 +++
target/arm/sve.decode | 5
target/arm/sve_helper.c| 59 ++
target/arm/translate-sve.c | 22 ++
4 files ch
On Wed, 15 Apr 2020 at 15:51, Daniel P. Berrangé wrote:
> On Tue, Apr 14, 2020 at 01:41:14PM +0100, Peter Maydell wrote:
> > Update our needs_sphinx setting to indicate that we require at least
> > 1.6. This will allow configure to fall back to "don't build the
> > docs" rather than causing the b
On Tue, Apr 14, 2020 at 01:41:14PM +0100, Peter Maydell wrote:
> Versions of Sphinx older than 1.6 can't build all of our documentation,
> because they are too picky about the syntax of the argument to the
> option:: directive; see Sphinx bugs #646, #3366:
>
> https://github.com/sphinx-doc/sphin
Signed-off-by: Stephen Long
---
Fixed the patch with the suggestions Richard made. I'll be working on
the HIST insns next instead of the 'SVE2 integer add/subtract narrow
high part' ones.
target/arm/helper-sve.h| 10 +++
target/arm/sve.decode | 5
target/arm/sve_helper.c|
Eric Blake writes:
> On 4/15/20 3:30 AM, Markus Armbruster wrote:
>> qdict_iter() has just three uses and no test coverage. Replace by
>> qdict_first(), qdict_next() for more concise code and less type
>> punning.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> include/qapi/qmp/qdict.h |
> Almost all of these are "all CPUs are identical and see basically the same
> view of the system" setups"
On a second thought, that setup would suffice for my use case. Heterogeneous
was just a "nice to have".
Thanks,
Cristian
-Original Message-
From: Peter Maydell
Sent: Wednesday, A
Eric Blake writes:
> On 4/15/20 3:30 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> qobject/qjson.c | 40
>> 1 file changed, 16 insertions(+), 24 deletions(-)
>>
>> diff --git a/qobject/qjson.c b/qobject/qjson.c
>> index db3
Kevin Wolf writes:
> Am 14.04.2020 um 22:13 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 14.04.2020 um 15:36 hat Markus Armbruster geschrieben:
>> >> Kevin Wolf writes:
>> >> > Am 14.04.2020 um 11:10 hat Markus Armbruster geschrieben:
>> >> >> Eric Blake writes:
>> >> >
Patchew URL: https://patchew.org/QEMU/20200415130159.611361-1-...@irrelevant.dk/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v2 00/16] nvme: refactoring and cleanups
Message-id: 20200415130159.611361-1-...@irrelevant.dk
Type:
Adalbert Lazãr writes:
> On Wed, 15 Apr 2020 12:37:34 +0200, Marc-André Lureau
> wrote:
>> Hi
>>
>> On Wed, Apr 15, 2020 at 3:00 AM Adalbert Lazăr
>> wrote:
>> >
>> > qmp_chardev_open_socket() ignores the absence of the 'server' argument
>> > and always switches to listen/server mode.
>> >
>
On Wed, 15 Apr 2020 at 14:27, Ancuta, Cristian
wrote:
> So just to make sure I understand the MMIO stuff correctly, there's no user
> mode support because user mode applications are talking to hardware through
> the OS drivers and syscalls (which would run in system mode) anyway?
Correct.
> Al
Patchew URL: https://patchew.org/QEMU/20200415102445.564803-1-...@irrelevant.dk/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH 00/16] nvme: refactoring and cleanups
Message-id: 20200415102445.564803-1-...@irrelevant.dk
Type: se
On 4/14/20 8:41 AM, Peter Maydell wrote:
> Versions of Sphinx older than 1.6 can't build all of our documentation,
> because they are too picky about the syntax of the argument to the
> option:: directive; see Sphinx bugs #646, #3366:
>
> https://github.com/sphinx-doc/sphinx/issues/646
> ht
On Tue, 24 Mar 2020, Geert Uytterhoeven wrote:
> i801_add_mux() fills in the GPIO lookup table by manually populating an
> array of gpiod_lookup structures. Use the existing GPIO_LOOKUP_IDX()
> helper macro instead, to relax a dependency on the gpiod_lookup
> structure's member names.
>
> Signed
Hello Stefan,
This blog post [0] talks about the AF_VSOCK monitoring device
(vsockmon) Stefan upstreamed into Linux a few years ago. It seems to
me the same rationale for enabling packet captures for AF_VSOCK
traffic applies to UNIX domain sockets as well. What do you think? I
have a proof of conc
Hi, thanks for taking the time.
So just to make sure I understand the MMIO stuff correctly, there's no user
mode support because user mode applications are talking to hardware through the
OS drivers and syscalls (which would run in system mode) anyway?
Also, is there a multi core board in the s
On 4/15/20 3:20 PM, Klaus Birkelund Jensen wrote:
On Apr 15 15:16, Philippe Mathieu-Daudé wrote:
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 46 ++
1 file changed, 26 insertions(
On Apr 15 15:16, Philippe Mathieu-Daudé wrote:
> On 4/15/20 3:01 PM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Signed-off-by: Klaus Jensen
> > ---
> > hw/block/nvme.c | 46 ++
> > 1 file changed, 26 insertions(+), 20 deletions(-)
> >
> > d
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 2b007115c302..906ae595025a 100644
--- a/hw/
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 46 ++
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index d5244102252c..2b007115c302
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
Change the prefix of all nvme device related trace events to 'pci_nvme'
to not clash with trace events from the nvme block driver.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 190 +
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
The size of the BAR is 0x1000 (main registers) + 8 bytes for each
queue. Currently, the size of the BAR is calculated like so:
n->reg_size = pow2ceil(0x1004 + 2 * (n->num_queues + 1) * 4);
Since the 'num_queues' parameter already
From: Klaus Jensen
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/nvme.c | 52 +++--
1 file changed, 29 insertions(+), 23 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 4c28d75e0fc8..804f24719dce 1006
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
Introduce some small helpers to make the next patches easier on the eye.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 3 +--
hw/block/nvme.h | 16
2 files changed, 17 insertions(+), 2 deletions(-)
diff --gi
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 43 ---
1 file changed, 28 insertions(+), 15 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 44856e873fd1..5f9ebbd6a1d5 100
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 45a352b63d89..80da0825d295 100644
--- a/hw/block/nvme.c
+++ b
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 2b007115c302..906ae595025a 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1379,
From: Klaus Jensen
Introduce some small helpers to make the next patches easier on the eye.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 3 +--
hw/block/nvme.h | 16
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 8
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 46 ++
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index d5244102252c..2b007115c302 100644
--- a/hw/block/nvme.c
+++ b/hw/block/
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 45a352b63d89..80da0825d295 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1351,6 +1351,13 @@ stat
From: Klaus Jensen
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/nvme.c | 7 ++-
hw/block/nvme.h | 2 --
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 8092c1b46eb1..44856e873fd1 100644
--- a/hw/block/nv
On 4/15/20 3:01 PM, Klaus Jensen wrote:
From: Klaus Jensen
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/nvme.c | 52 +++--
1 file changed, 29 insertions(+), 23 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/
From: Klaus Jensen
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/nvme.c | 8
include/block/nvme.h | 8
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index a2b1
From: Klaus Jensen
Change the prefix of all nvme device related trace events to 'pci_nvme'
to not clash with trace events from the nvme block driver.
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 190 +-
hw/block/trace-events | 172
On 4/15/20 2:34 PM, Daniel P. Berrangé wrote:
On Tue, Apr 14, 2020 at 03:30:44PM +0200, Philippe Mathieu-Daudé wrote:
On [*] Daniel Berrangé commented:
The QEMU guest agent protocol is not sensible way to access huge
files inside the guest. It requires the inefficient process of
readin
From: Klaus Jensen
Signed-off-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/nvme.c | 49 +++--
1 file changed, 27 insertions(+), 22 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 906ae595025a..4c28d75e0fc8 1006
From: Klaus Jensen
Changes since v1
* nvme: fix pci doorbell size calculation
- added some defines and a better comment (Philippe)
* nvme: rename trace events to pci_nvme
- changed the prefix from nvme_dev to pci_nvme (Philippe)
* nvme: add max_ioqpairs device parameter
-
From: Klaus Jensen
The num_queues device paramater has a slightly confusing meaning because
it accounts for the admin queue pair which is not really optional.
Secondly, it is really a maximum value of queues allowed.
Add a new max_ioqpairs parameter that only accounts for I/O queue pairs,
but ke
From: Klaus Jensen
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 43 ---
1 file changed, 28 insertions(+), 15 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 44856e873fd1..5f9ebbd6a1d5 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvm
From: Klaus Jensen
Move device configuration parameters to separate struct to make it
explicit what is configurable and what is set internally.
Signed-off-by: Klaus Jensen
Signed-off-by: Klaus Jensen
Acked-by: Keith Busch
Reviewed-by: Maxim Levitsky
Reviewed-by: Philippe Mathieu-Daudé
---
1 - 100 of 242 matches
Mail list logo
