[Bug 1868221] Re: /usr/share/applications/qemu.desktop should have an "Exec=" key.

I'll report a bug in KDE and let's see if the guys agree. Maybe it is a deficiency of the .desktop specification. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1868221 Title: /usr/share/application

Re: [PATCH-for-5.0 v2 04/11] hw/input/adb-kbd: Remove dead assignment

On Sat, Mar 21, 2020 at 03:41:03PM +0100, Philippe Mathieu-Daudé wrote: > Since commit 5a1f49718 the 'olen' variable is not really > used. Remove it to fix a warning reported by Clang static > code analyzer: > > CC hw/input/adb-kbd.o > hw/input/adb-kbd.c:200:5: warning: Value stored to

Re: [PATCH] spapr: Fix memory leak in h_client_architecture_support()

On Sat, Mar 21, 2020 at 06:34:22PM +0100, Greg Kurz wrote: > This is the only error path that needs to free the previously allocated > ov1. > > Reported-by: Coverity (CID 1421924) > Fixes: cbd0d7f36322 "spapr: Fail CAS if option vector table cannot be parsed" > Signed-off-by: Greg Kurz Applied t

Re: deprecation of in-tree builds

On Sat, 21 Mar 2020, Peter Maydell wrote: AIUI from Paolo, the intention is to deprecate and eventually stop supporting "in-tree" builds, so that the only option is building in a separate build directory. I thought we should probably mention that in the 5.0 changelog, so I wrote up some text: ht

Re: [Qemu-devel] [PATCH PULL 0/4] RDMA queue

On Sat, 21 Mar 2020 at 19:13, Marcel Apfelbaum wrote: > > The following changes since commit 52a96afaa23d883d281bc7b95b9e69db7d6d3d3f: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging > (2020-03-20 16:00:21 +) > > are available in the G

deprecation of in-tree builds

AIUI from Paolo, the intention is to deprecate and eventually stop supporting "in-tree" builds, so that the only option is building in a separate build directory. I thought we should probably mention that in the 5.0 changelog, so I wrote up some text: https://wiki.qemu.org/ChangeLog/5.0#Build_Info

Re: [PULL 0/1] DTC queue for 5.0

On Fri, 20 Mar 2020 at 22:06, Alistair Francis wrote: > > The following changes since commit 3d0ac346032a1fa9afafcaedc979a99f670e077e: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/python-next-pull-request' into staging (2020-03-20 > 13:54:23 +) > > are available in the Git rep

Re: In tree configure errors since 6116aea9

On Sat, 21 Mar 2020 at 18:32, BALATON Zoltan wrote: > On Sat, 21 Mar 2020, Laurent Vivier wrote: > > I didn't see that because I always do an out-of-tree build. > > Isn't there a test for that or should there be one? It's not in my set of CI tests (mostly because it's a bit awkward to do). We're

Re: [PULL 21/36] hw/arm/allwinner-h3: add Boot ROM support

On Sat, 21 Mar 2020 at 17:17, Niek Linnenbank wrote: > By the way, I do not have the coverity tool unfortunately. So I can't really > check myself > if any of the other Allwinner H3 files also have warnings that can be fixed.. > But if coverity finds more, just let me know, and I'll look into it.

Re: [PULL v2 0/1] Slirp patches

On Fri, 20 Mar 2020 at 15:51, Marc-André Lureau wrote: > > The following changes since commit f57587c7d47b35b2d9b31def3a74d81bdb5475d7: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' > into staging (2020-03-19 10:18:07 +) > > are available in the Git repository

[Qemu-devel] [PATCH PULL 4/4] hw/rdma: avoid suspicious strncpy() use

From: Stefan Hajnoczi gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) with sanitizers enabled reports the following error: CC x86_64-softmmu/hw/rdma/vmw/pvrdma_dev_ring.o In file included from /usr/include/string.h:495, from include/qemu/osdep.h:101, from hw/r

[Qemu-devel] [PATCH PULL 2/4] hw/rdma: Cosmetic change - no need for two sge arrays

From: Yuval Shaia The function build_host_sge_array uses two sge arrays, one for input and one for output. Since the size of the two arrays is the same, the function can write directly to the given source array (i.e. input/output argument). Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelba

[Qemu-devel] [PATCH PULL 1/4] hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy

From: Julia Suvorova ring->name is defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated strncpy with QEMU function. This case prevented QEMU from compiling with --enable-sanitizers. Signed-off-by: Julia Suvorova Message-Id: <20200318134849.237011-1-jus...@redhat.com> Reviewed-by: Yuval

[Qemu-devel] [PATCH PULL 0/4] RDMA queue

The following changes since commit 52a96afaa23d883d281bc7b95b9e69db7d6d3d3f: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging (2020-03-20 16:00:21 +) are available in the Git repository at: https://github.com/marcel-apf/qemu tags/rdma-pul

[Qemu-devel] [PATCH PULL 3/4] hw/rdma: Skip data-path mr_id translation

From: Yuval Shaia With the change made in commit 68b89aee71 ("Utilize ibv_reg_mr_iova for memory registration") the MR emulation is no longer needed in order to translate the guest addresses into host addresses. With that, the next obvious step is to skip entirely the processing in data-path. To

Re: In tree configure errors since 6116aea9

On Sat, 21 Mar 2020, Laurent Vivier wrote: Le 21/03/2020 à 18:29, BALATON Zoltan a écrit : Hello, Since 6116aea99, or actually 4d6a835d (linux-user: introduce parameters to generate syscall_nr.h) but only next commit starts to enable it I get these errors when running configure in source tree:

Re: [PATCH] spapr: Fix memory leak in h_client_architecture_support()

On 3/21/20 6:34 PM, Greg Kurz wrote: This is the only error path that needs to free the previously allocated ov1. Reported-by: Coverity (CID 1421924) Fixes: cbd0d7f36322 "spapr: Fail CAS if option vector table cannot be parsed" Signed-off-by: Greg Kurz --- hw/ppc/spapr_hcall.c |1 + 1 fi

Re: In tree configure errors since 6116aea9

Le 21/03/2020 à 18:29, BALATON Zoltan a écrit : > Hello, > > Since 6116aea99, or actually 4d6a835d (linux-user: introduce parameters > to generate syscall_nr.h) but only next commit starts to enable it I get > these errors when running configure in source tree: > > grep: ./.gitlab-ci.d: Is a dire

[PATCH] spapr: Fix memory leak in h_client_architecture_support()

This is the only error path that needs to free the previously allocated ov1. Reported-by: Coverity (CID 1421924) Fixes: cbd0d7f36322 "spapr: Fail CAS if option vector table cannot be parsed" Signed-off-by: Greg Kurz --- hw/ppc/spapr_hcall.c |1 + 1 file changed, 1 insertion(+) diff --git a/

In tree configure errors since 6116aea9

Hello, Since 6116aea99, or actually 4d6a835d (linux-user: introduce parameters to generate syscall_nr.h) but only next commit starts to enable it I get these errors when running configure in source tree: grep: ./.gitlab-ci.d: Is a directory grep: ./scripts/qemu-guest-agent/fsfreeze-hook.d: Is

Re: [PATCH 2/2] hw/rdma: avoid suspicious strncpy() use

Hi Stefan, On 3/20/20 1:55 PM, Yuval Shaia wrote: On Mon, 16 Mar 2020 at 18:07, Stefan Hajnoczi > wrote: gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) with sanitizers enabled reports the following error:   CC      x86_64-softmmu/hw/rdma/vmw/pvrdma_dev_ri

Re: [PULL 21/36] hw/arm/allwinner-h3: add Boot ROM support

Hi Peter, On Fri, Mar 20, 2020 at 1:08 PM Peter Maydell wrote: > On Thu, 12 Mar 2020 at 16:45, Peter Maydell > wrote: > > > > From: Niek Linnenbank > > > > A real Allwinner H3 SoC contains a Boot ROM which is the > > first code that runs right after the SoC is powered on. > > The Boot ROM is

Re: [PATCH v1 2/2] hw/rdma: Skip data-path mr_id translation

On 3/20/20 4:34 PM, Yuval Shaia wrote: With the change made in commit 68b89aee71 ("Utilize ibv_reg_mr_iova for memory registration") the MR emulation is no longer needed in order to translate the guest addresses into host addresses. With that, the next obvious step is to skip entirely the proc

Re: [PATCH v1 1/2] hw/rdma: Cosmetic change - no need for two sge arrays

On 3/20/20 4:34 PM, Yuval Shaia wrote: The function build_host_sge_array uses two sge arrays, one for input and one for output. Since the size of the two arrays is the same, the function can write directly to the given source array (i.e. input/output argument). Signed-off-by: Yuval Shaia ---

Re: [PULL v4 00/32] Linux user for 5.0 patches

On Fri, 20 Mar 2020 at 15:27, Laurent Vivier wrote: > > The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: > > qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linu

Re: [PATCH-for-5.0 01/11] block: Remove dead assignment

On Sat, 21 Mar 2020, Aleksandar Markovic wrote: 12:49 PM Sub, 21.03.2020. Philippe Mathieu-Daudé је написао/ла: Fix warning reported by Clang static code analyzer: block.c:3167:5: warning: Value stored to 'ret' is never read ret = bdrv_fill_options(&options, filename, &flags, &local_e

[PATCH] monitor/hmp-cmds: remove redundant check for tls_authz in hmp_info_migrate_parameters

'params->has_tls_authz = true' has been hardcoded as true in qmp_query_migrate_parameters, so remove the redundant check. Signed-off-by: Mao Zhongyi --- monitor/hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index f8be6bbb16

Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes

On 3/21/20 3:40 PM, Philippe Mathieu-Daudé wrote: Fix trivial warnings reported by the Clang static code analyzer. I forgot to add the official Clang static code analyzer documentation is on https://clang-analyzer.llvm.org/ and on Fedora I simply used it as: $ sudo dnf install clang-analyzer

[PATCH-for-5.0 v2 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/timer/stm32f2xx_timer.o hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is never read value = timer_val; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathie

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

On Sat, Mar 21, 2020 at 7:17 PM Jiaxun Yang wrote: > > > > 于 2020年3月21日 GMT+08:00 下午6:57:54, Jiaxun Yang 写到: > > > > > >于 2020年3月21日 GMT+08:00 下午6:39:21, "Philippe Mathieu-Daudé" > > 写到: > >>On 3/21/20 5:56 AM, Jiaxun Yang wrote: > >>> Loongson multimedia condition instructions were previously >

[PATCH-for-5.0 v2 08/11] hw/timer/exynos4210_mct: Remove dead assignments

Fix warnings reported by Clang static code analyzer: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~ hw/timer/exynos4210_mct.c:1399:9: warning: Value s

[PATCH-for-5.0 v2 10/11] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning

pxa2xx_timer_tick4() takes an opaque pointer, then calls pxa2xx_timer_update4(), so the static analyzer can not verify that the 'n < 8': 425 static void pxa2xx_timer_tick4(void *opaque) 426 { 427 PXA2xxTimer4 *t = (PXA2xxTimer4 *) opaque; 428 PXA2xxTimerInfo *i = (PXA2xxTimerInfo *

[PATCH-for-5.0 v2 07/11] hw/gpio/aspeed_gpio: Remove dead assignment

Fix warning reported by Clang static code analyzer: hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its initialization is never read int set_idx, g_idx = *group_idx; ^ ~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mat

[PATCH-for-5.0 v2 04/11] hw/input/adb-kbd: Remove dead assignment

Since commit 5a1f49718 the 'olen' variable is not really used. Remove it to fix a warning reported by Clang static code analyzer: CC hw/input/adb-kbd.o hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read olen = 0; ^ ~ Fixes: 5a1f49718 (adb: add supp

[PATCH-for-5.0 v2 11/11] hw/scsi/esp-pci: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/scsi/esp-pci.o hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size = 4; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/esp-pci.c | 1 -

[PATCH-for-5.0 v2 06/11] hw/isa/i82378: Remove dead assignment

Rename the unique variable assigned as 'pit' which better represents what it holds, to fix a warning reported by the Clang static code analyzer: CC hw/isa/i82378.o hw/isa/i82378.c:108:5: warning: Value stored to 'isa' is never read isa = isa_create_simple(isabus, "i82374");

[PATCH-for-5.0 v2 03/11] hw/i2c/pm_smbus: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/i2c/pm_smbus.o hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read ret = 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/pm_

[PATCH-for-5.0 v2 05/11] hw/ide/sii3112: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val = 0; ^ ~ Fixes: a9dd6604 Reported-by: Clang Static Analyzer Reviewed-by: BALATON Zoltan Signed-off-by: Philippe Math

[PATCH-for-5.0 v2 02/11] blockdev: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC blockdev.o blockdev.c:2744:5: warning: Value stored to 'ret' is never read ret = blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp); ^ ~~~ Reported-by: Clang

[PATCH-for-5.0 v2 01/11] block: Avoid dead assignment

Fix warning reported by Clang static code analyzer: block.c:3167:5: warning: Value stored to 'ret' is never read ret = bdrv_fill_options(&options, filename, &flags, &local_err); ^ ~ Fixes: 462f5bcf6 Reported-by: Clang Stati

[PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes

Fix trivial warnings reported by the Clang static code analyzer. Since v1: - Addressed Markus/Zoltan/Aleksandar review comments Philippe Mathieu-Daudé (11): block: Avoid dead assignment blockdev: Remove dead assignment hw/i2c/pm_smbus: Remove dead assignment hw/input/adb-kbd: Remove dead

POWERPC_EXCP_PROGRAM POWERPC_EXCP_INVAL in PowerPC simulation.

I am facing a exception when running the following code: ``` 00e86000 : excConnectCode(): e86000: 3c 60 00 e1 lis r3,225 e86004: 60 63 c3 80 ori r3,r3,50048 e86008: 7c 68 03 a6 mtlrr3 ``` How to implement an instruction in ppc translate? Raise exception at 00e86000 => 0060 (2

[PATCH v8 1/4] qcow2: introduce compression type feature

The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus c

[PATCH v8 0/4] qcow2: Implement zstd cluster compression method

v8: * 03: switch zstd API from simple to stream [Eric] No need to state a special cluster layout for zstd compressed clusters. v7: * use qapi_enum_parse instead of the open-coding [Eric] * fix wording, typos and spelling [Eric] v6: * "block/qcow2-threads: fix qcow2_de

[PATCH v8 3/4] qcow2: add zstd cluster compression

zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and decompresse

[PATCH v8 4/4] iotests: 287: add qcow2 compression type test

The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/287 | 128 + tests/qemu-iotests/287.out

[PATCH v8 2/4] qcow2: rework the cluster compression routine

The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2-threads.c | 71 ++

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

On 3/21/20 3:14 PM, Philippe Mathieu-Daudé wrote: On 3/21/20 2:39 PM, Aleksandar Markovic wrote: On Saturday, March 21, 2020, Philippe Mathieu-Daudé > wrote:     Fix warning reported by Clang static code analyzer:     CC      hw/ide/sii3112.o   hw/ide/sii

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

On Sat, 21 Mar 2020, Philippe Mathieu-Daudé wrote: On 3/21/20 3:12 PM, BALATON Zoltan wrote: On Sat, 21 Mar 2020, Aleksandar Markovic wrote: On Saturday, March 21, 2020, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer:     CC  hw/ide/sii3112.o   hw/ide/s

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

On 3/21/20 3:12 PM, BALATON Zoltan wrote: On Sat, 21 Mar 2020, Aleksandar Markovic wrote: On Saturday, March 21, 2020, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer:     CC  hw/ide/sii3112.o   hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is ne

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

On 3/21/20 2:39 PM, Aleksandar Markovic wrote: On Saturday, March 21, 2020, Philippe Mathieu-Daudé > wrote: Fix warning reported by Clang static code analyzer:     CC      hw/ide/sii3112.o   hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is nev

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

On Sat, 21 Mar 2020, Aleksandar Markovic wrote: On Saturday, March 21, 2020, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val = 0; ^

Re: [PATCH-for-5.0 07/11] hw/gpio/aspeed_gpio: Remove dead assignment

On 3/21/20 2:22 PM, BALATON Zoltan wrote: On Sat, 21 Mar 2020, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer:  hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its initialization is never read int set_idx, g_idx = *group_idx;   

Re: [PATCH] gdbstub: add support to Xfer:auxv:read: packet

Lirong Yuan writes: > On Fri, Mar 20, 2020 at 2:17 AM Alex Bennée wrote: >> >> Sorry I missed this on my radar. There was a minor re-factor of gdbstub >> that was just merged which will mean this patch needs a re-base to use >> g_string_* functions to expand stings. >> >> Also we have some si

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

On Saturday, March 21, 2020, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > CC hw/ide/sii3112.o > hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read > val = 0; > ^ ~ > > Reported-by: Clang Static Analyze

[PATCH v2] migration: use "" instead of (null) for tls-authz

run: (qemu) info migrate_parameters announce-initial: 50 ms ... announce-max: 550 ms multifd-compression: none xbzrle-cache-size: 4194304 max-postcopy-bandwidth: 0 tls-authz: '(null)' Migration parameter 'tls-authz' is used to provide the QOM ID of a QAuthZ subclass instance that provides the acc

Re: [PATCH-for-5.0 07/11] hw/gpio/aspeed_gpio: Remove dead assignment

On Sat, 21 Mar 2020, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer: hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its initialization is never read int set_idx, g_idx = *group_idx; ^ ~~ Reported-by:

Re: [PATCH-for-5.0 01/11] block: Remove dead assignment

Laurent Vivier writes: > Le 21/03/2020 à 12:46, Philippe Mathieu-Daudé a écrit : >> Fix warning reported by Clang static code analyzer: >> >> block.c:3167:5: warning: Value stored to 'ret' is never read >> ret = bdrv_fill_options(&options, filename, &flags, &local_err); >> ^ ~~

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

On Sat, 21 Mar 2020, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val = 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe

Re: [PATCH-for-5.0 04/11] hw/input/adb-kbd: Remove dead assignment

On Sat, 21 Mar 2020, Philippe Mathieu-Daudé wrote: Fix warning reported by Clang static code analyzer: CC hw/input/adb-kbd.o hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read olen = 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe M

Re: [PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

On 3/21/20 1:01 PM, Aleksandar Markovic wrote: 12:47 PM Sub, 21.03.2020. Philippe Mathieu-Daudé > је написао/ла: > > Fix trivial warnings reported by the Clang static code analyzer. > Philippe, It would be useful and customary for this type of fixes to provide here

Re: [PATCH-for-5.0] tools/virtiofsd/passthrough_ll: Fix double close()

On 3/21/20 1:06 PM, Philippe Mathieu-Daudé wrote: On success, the fdopendir() call closes fd. Later on the error path we try to close an already-closed fd. This can lead to use-after-free. Fix by only closing the fd if the fdopendir() call failed. Cc: qemu-sta...@nongnu.org Fixes: 7c6b66027 (Imp

[PATCH-for-5.0] tools/virtiofsd/passthrough_ll: Fix double close()

On success, the fdopendir() call closes fd. Later on the error path we try to close an already-closed fd. This can lead to use-after-free. Fix by only closing the fd if the fdopendir() call failed. Cc: qemu-sta...@nongnu.org Fixes: 7c6b66027 (Import passthrough_ll from libfuse fuse-3.8.0) Reported

Re: [PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

12:47 PM Sub, 21.03.2020. Philippe Mathieu-Daudé је написао/ла: > > Fix trivial warnings reported by the Clang static code analyzer. > Philippe, It would be useful and customary for this type of fixes to provide here the environment you used for obtaining the warnings (clang version, configure p

Re: [PATCH-for-5.0 01/11] block: Remove dead assignment

Le 21/03/2020 à 12:46, Philippe Mathieu-Daudé a écrit : > Fix warning reported by Clang static code analyzer: > > block.c:3167:5: warning: Value stored to 'ret' is never read > ret = bdrv_fill_options(&options, filename, &flags, &local_err); > ^ ~~

Re: [PATCH-for-5.0 01/11] block: Remove dead assignment

12:49 PM Sub, 21.03.2020. Philippe Mathieu-Daudé је написао/ла: > > Fix warning reported by Clang static code analyzer: > > block.c:3167:5: warning: Value stored to 'ret' is never read > ret = bdrv_fill_options(&options, filename, &flags, &local_err); > ^

[PATCH-for-5.0 10/11] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning

pxa2xx_timer_tick4() takes an opaque pointer, then calls pxa2xx_timer_update4(), so the static analyzer can not verify that the 'n < 8': 425 static void pxa2xx_timer_tick4(void *opaque) 426 { 427 PXA2xxTimer4 *t = (PXA2xxTimer4 *) opaque; 428 PXA2xxTimerInfo *i = (PXA2xxTimerInfo *

[PATCH-for-5.0 08/11] hw/timer/exynos4210_mct: Remove dead assignments

Fix warnings reported by Clang static code analyzer: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never read index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~ hw/timer/exynos4210_mct.c:1399:9: warning: Value s

Re: [PATCH-for-5.0 2/4] tests/docker: Install gcrypt devel package in Debian image

8:06 PM Pet, 20.03.2020. Philippe Mathieu-Daudé је написао/ла: > > Apparently Debian Stretch was listing gcrypt as a QEMU dependency, > but this is not the case anymore in Buster, so we need to install > it manually (it it not listed by 'apt-get -s build-dep qemu' in > the common debian10.docker a

[PATCH-for-5.0 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/timer/stm32f2xx_timer.o hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is never read value = timer_val; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathie

[PATCH-for-5.0 04/11] hw/input/adb-kbd: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/input/adb-kbd.o hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read olen = 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- hw/input/adb-kbd.c | 1 - 1 fi

[PATCH-for-5.0 07/11] hw/gpio/aspeed_gpio: Remove dead assignment

Fix warning reported by Clang static code analyzer: hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its initialization is never read int set_idx, g_idx = *group_idx; ^ ~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mat

[PATCH-for-5.0 06/11] hw/isa/i82378: Remove dead assignment

Rename the unique variable assigned as 'pit' which better represents what it holds, to fix a warning reported by the Clang static code analyzer: CC hw/isa/i82378.o hw/isa/i82378.c:108:5: warning: Value stored to 'isa' is never read isa = isa_create_simple(isabus, "i82374");

[PATCH-for-5.0 11/11] hw/scsi/esp-pci: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/scsi/esp-pci.o hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size = 4; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/esp-pci.c | 1 -

[PATCH-for-5.0 01/11] block: Remove dead assignment

Fix warning reported by Clang static code analyzer: block.c:3167:5: warning: Value stored to 'ret' is never read ret = bdrv_fill_options(&options, filename, &flags, &local_err); ^ ~ Reported-by: Clang Static Analyzer Signed

[PATCH-for-5.0 03/11] hw/i2c/pm_smbus: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/i2c/pm_smbus.o hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read ret = 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/pm_

[PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val = 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/sii3112.c | 2 +- 1 fi

[PATCH-for-5.0 02/11] blockdev: Remove dead assignment

Fix warning reported by Clang static code analyzer: CC blockdev.o blockdev.c:2744:5: warning: Value stored to 'ret' is never read ret = blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp); ^ ~~~ Reported-by: Clang

[PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

Fix trivial warnings reported by the Clang static code analyzer. Philippe Mathieu-Daudé (11): block: Remove dead assignment blockdev: Remove dead assignment hw/i2c/pm_smbus: Remove dead assignment hw/input/adb-kbd: Remove dead assignment hw/ide/sii3112: Remove dead assignment hw/isa/i8

Re: [PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

On 3/21/20 3:14 PM, Markus Armbruster wrote: "Dr. David Alan Gilbert" writes: * Daniel P. Berrangé (berra...@redhat.com) wrote: On Fri, Mar 20, 2020 at 05:31:17PM +, Dr. David Alan Gilbert wrote: (Rearranging the text a bit) * Markus Armbruster (arm...@redhat.com) wrote: David (cc'e

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

于 2020年3月21日 GMT+08:00 下午6:57:54, Jiaxun Yang 写到: > > >于 2020年3月21日 GMT+08:00 下午6:39:21, "Philippe Mathieu-Daudé" > 写到: >>On 3/21/20 5:56 AM, Jiaxun Yang wrote: >>> Loongson multimedia condition instructions were previously >>implemented as >>> write 0 to rd due to lack of documentation. So I j

Re: [PULL v2 05/13] target/rx: CPU definitions

On 3/21/20 12:05 PM, Philippe Mathieu-Daudé wrote: On 3/20/20 5:37 PM, Peter Maydell wrote: On Fri, 20 Mar 2020 at 16:32, Philippe Mathieu-Daudé wrote: -fwrapv is here indeed. I use --extra-cflags=-fsanitize=address,alignment,array-bounds,bool,builtin,enum,float-cast-overflow,float-divide-by-

Re: [PULL v2 05/13] target/rx: CPU definitions

On 3/20/20 5:37 PM, Peter Maydell wrote: On Fri, 20 Mar 2020 at 16:32, Philippe Mathieu-Daudé wrote: -fwrapv is here indeed. I use --extra-cflags=-fsanitize=address,alignment,array-bounds,bool,builtin,enum,float-cast-overflow,float-divide-by-zero,function,integer-divide-by-zero,nonnull-attribu

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

于 2020年3月21日 GMT+08:00 下午6:39:21, "Philippe Mathieu-Daudé" 写到: >On 3/21/20 5:56 AM, Jiaxun Yang wrote: >> Loongson multimedia condition instructions were previously >implemented as >> write 0 to rd due to lack of documentation. So I just confirmed with >Loongson >> about their encoding and imp

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

On 3/21/20 5:56 AM, Jiaxun Yang wrote: Loongson multimedia condition instructions were previously implemented as write 0 to rd due to lack of documentation. So I just confirmed with Loongson about their encoding and implemented them correctly. Can you refer to the datasheet in the commit messag

Re: Qemu on Windows 10 - no acceleration found

Perfect Stefan - that did the trick. Thank you. Jerry On Sat, Mar 21, 2020 at 3:14 AM Stefan Weil wrote: > Am 20.03.20 um 21:22 schrieb Jerry Geis: > > > So I tried --enable-whpx and I get Invalid option. Im on Windows 10 > > and QEMU 4.2.0 > > > > I'm confused. Then I don't know where to down

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

5:58 AM Sub, 21.03.2020. Jiaxun Yang је написао/ла: > > Loongson multimedia condition instructions were previously implemented as > write 0 to rd due to lack of documentation. So I just confirmed with Loongson > about their encoding and implemented them correctly. > > Signed-off-by: Jiaxun Yang >

Re: Qemu on Windows 10 - no acceleration found

Am 20.03.20 um 21:22 schrieb Jerry Geis: > So I tried --enable-whpx and I get Invalid option. Im on Windows 10 > and QEMU 4.2.0 > > I'm confused.  Then I don't know where to download the HAXM. The place > I found is GIT and it wants the user to compile it. I was looking for > just an EXE. > > Than

Re: [PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

"Dr. David Alan Gilbert" writes: > * Daniel P. Berrangé (berra...@redhat.com) wrote: >> On Fri, Mar 20, 2020 at 05:31:17PM +, Dr. David Alan Gilbert wrote: >> > (Rearranging the text a bit) >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: >> > >> > > David (cc'ed) should be able to