Lirong Yuan <yua...@google.com> writes:
> On Fri, Mar 20, 2020 at 2:17 AM Alex Bennée <alex.ben...@linaro.org> wrote: <snip> >> >> Sorry I missed this on my radar. There was a minor re-factor of gdbstub >> that was just merged which will mean this patch needs a re-base to use >> g_string_* functions to expand stings. >> >> Also we have some simple gdbstub tests now - could we come up with a >> multiarch gdbstub test to verify this is working properly? >> <snip> > For sure, I will re-base this patch to use g_string_* functions. > > Currently we are using qemu aarch64. I am not sure how to do this yet, but > I could try to add something to > https://github.com/qemu/qemu/tree/master/tests/tcg/aarch64/gdbstub If the auxv support is appropriate to all linux-user targets you can plumb it into the multiarch tests - you can even use the existing binaries. So you need: - a stanza in the makefiles to launch the test (see tests/tcg/aarch64/Makefile.target) - a .py test script that manipulates gdbstub to check things are working So something like: .PHONY: gdbstub-foo-binary run-gdbstub-foo-binary: foo-binary $(call run-test, $@, $(GDB_SCRIPT) \ --gdb $(HAVE_GDB_BIN) \ --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \ --bin $< --test $(MULTIARCH_SRC)/gdbstub/test-foo.py, \ "basic gdbstub FOO support") > > Does this sound good? Hope that helps. > > Thanks! > Lirong -- Alex Bennée
