Re: [PATCH v32 21/22] BootLinuxConsoleTest: Test the RX-Virt machine

2020-03-08 Thread Yoshinori Sato
On Mon, 09 Mar 2020 01:20:05 +0900, Philippe Mathieu-Daudé wrote: > > On 2/24/20 3:19 PM, Yoshinori Sato wrote: > > From: Philippe Mathieu-Daudé > > > > Add two tests for the rx-virt machine, based on the recommended test > > setup from Yoshinori Sato: > > https://lists.gnu.org/archive/html/qemu

Re: [PATCH v32 16/22] hw/char: RX62N serial communication interface (SCI)

2020-03-08 Thread Yoshinori Sato
On Mon, 09 Mar 2020 00:41:45 +0900, Philippe Mathieu-Daudé wrote: > > Hi Yoshinori, > > On 2/24/20 3:19 PM, Yoshinori Sato wrote: > > This module supported only non FIFO type. > > Hardware manual. > > https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf > > >

[Question] An issue when repeat reboot in guest during migration

2020-03-08 Thread Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
Hi guys, We find an issue when repeat reboot in guest during migration, it cause the migration thread never be waken up again. | | main_loop_should_exit [BQL LOCK] | pause_all_vcpus | 1. set all cpus ->stop=true

I am trying to fixes a issue with QEMU with VxWorks.

2020-03-08 Thread Yonggang Luo
When I am running QEMU to simulating PowerPC. And after running the following powerpc code: 00e2b5dc : intUnlock(): e2b5dc: 54 63 04 20 rlwinm r3,r3,0,16,16 e2b5e0: 7c 80 00 a6 mfmsr r4 e2b5e4: 7c 83 1b 78 or r3,r4,r3 e2b5e8: 7c 60 01 24 mtmsr r3 e2b5ec: 4c 00 01 2c isync e2b5f0: 4e 80

Re: [PATCH] dp8393x: Mask EOL bit from descriptor addresses, take 2

2020-03-08 Thread Jason Wang
On 2020/3/8 下午5:52, Laurent Vivier wrote: Le 04/03/2020 à 04:23, Finn Thain a écrit : A portion of a recent patch got lost due to a merge snafu. That patch is now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses"). This patch restores the portion that got lost. Signed-off-b

Re: [PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200309021738.30072-1-pannengy...@huawei.com/ Hi, This series failed the docker-clang@ubuntu build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH v2 2/2] via-ide: Also emulate non 100% native mode

2020-03-08 Thread BALATON Zoltan
Some machines operate in "non 100% native mode" where interrupts are fixed at legacy IDE interrupts and some guests expect this behaviour without checking based on knowledge about hardware. Even Linux has arch specific workarounds for this that are activated on such boards so this needs to be emula

[PATCH v2 0/2] Implement "non 100% native mode" in via-ide

2020-03-08 Thread BALATON Zoltan
This small series implements the quirky mode of via-ide found at least on pegasos2 which is needed for guests that expect this and activate work arounds on that platform and don't work unless this is emulated. (Symptom is missing IDE interrupts.) We need a flag to turn this mode on or off so the fi

[PATCH v2 1/2] ide: Make room for flags in PCIIDEState and add one for legacy IRQ routing

2020-03-08 Thread BALATON Zoltan
We'll need a flag for implementing some device specific behaviour in via-ide but we already have a currently CMD646 specific field that can be repurposed for this and leave room for furhter flags if needed in the future. This patch changes the "secondary" field to "flags" and define the flags for C

Re: [PATCH v2] hw/char/pl011: Enable TxFIFO and async transmission

2020-03-08 Thread Gavin Shan
On 3/6/20 10:15 PM, Marc-André Lureau wrote: On Mon, Feb 24, 2020 at 4:13 AM Gavin Shan wrote: The depth of TxFIFO can be 1 or 16 depending on LCR[4]. The TxFIFO is disabled when its depth is 1. It's nice to have TxFIFO enabled if possible because more characters can be piled and transmitted

[PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-08 Thread Pan Nengyuan
We neglect to free port->bh on the error paths. Fix that. Reproducer: {'execute': 'device_add', 'arguments': {'id': 'virtio_serial_pci0', 'driver': 'virtio-serial-pci', 'bus': 'pci.0', 'addr': '0x5'}, 'id': 'yVkZcGgV'} {'execute': 'device_add', 'arguments': {'id': 'port1', 'driver': 'vir

[Bug 1866577] [NEW] powerpc-none-eabi-gdb.exe GDB 9.1 with QEMU 4.2 gdb-stub comes with Reply contains invalid hex digit 79

2020-03-08 Thread Yonggang Luo
Public bug reported: I am using powerpc-none-eabi-gdb with qemu 4.2, but it comes with the following error: undefinedC:\CI-Tools\msys64\powerpc-none-eabi\usr\local\bin\powerpc- none-eabi-gdb.exe: warning: Couldn't determine a path for the index cache directory. ```Not implemented stop reason (a

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-08 Thread Pan Nengyuan
On 3/8/2020 9:29 PM, Peter Maydell wrote: > On Thu, 5 Mar 2020 at 06:39, Pan Nengyuan wrote: >> >> This patch fix a bug in mac_via where it failed to actually realize devices >> it was using. >> And move the init codes which inits the mos6522 objects and properties on >> them from realize() >

Re: [PATCH v4 0/3] delay timer_new from init to realize to fix memleaks.

2020-03-08 Thread Pan Nengyuan
On 3/8/2020 9:39 PM, Peter Maydell wrote: > On Sun, 8 Mar 2020 at 11:58, Mark Cave-Ayland > wrote: >> I just tried this patchset applied on top of git master and it causes >> qemu-system-ppc >> to segfault on startup: >> >> $ gdb --args ./qemu-system-ppc >> ... >> ... >> Thread 1 "qemu-system-

[PATCH v2 6/6] audio: add audiodev format=f32 option documentation

2020-03-08 Thread Volker Rümelin
The documentaion for -audiodev format=f32 option was missing. Signed-off-by: Volker Rümelin --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index f9fefd43be..2919eddf4d 100644 --- a/qemu-options.hx +++ b/qemu-options.h

[PATCH v2 3/6] audio: consistency changes

2020-03-08 Thread Volker Rümelin
Change the clip_natural_float_from_mono() function in audio/mixeng.c to be consistent with the clip_*_from_mono() functions in audio/mixeng_template.h. Signed-off-by: Volker Rümelin --- audio/mixeng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/mixeng.c b/audio/mixe

[PATCH v2 5/6] audio: fix saturation nonlinearity in clip_* functions

2020-03-08 Thread Volker Rümelin
The current positive limit for the saturation nonlinearity is only correct if the type of the result has 8 bits or less. Signed-off-by: Volker Rümelin --- audio/mixeng_template.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/audio/mixeng_template.h b/audio/mixeng_templ

[PATCH v2 4/6] audio: change mixing engine float range to [-1.f, 1.f]

2020-03-08 Thread Volker Rümelin
Currently the internal float range of the mixing engine is [-.5f, .5f]. PulseAudio, SDL2 and libasound use a [-1.f, 1.f] range. This means with float samples the audio playback volume is 6dB too low and audio recording signals will be clipped in most cases. To avoid another scaling factor in the c

[PATCH v2 2/6] audio: change naming scheme of FLOAT_CONV macros

2020-03-08 Thread Volker Rümelin
This patch changes the naming scheme of the FLOAT_CONV_TO and FLOAT_CONV_FROM macros to the scheme used in mixeng_template.h. Signed-off-by: Volker Rümelin --- audio/mixeng.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/audio/mixeng.c b/audio/mixen

[PATCH v2 1/6] qapi/audio: add documentation for AudioFormat

2020-03-08 Thread Volker Rümelin
The review for patch ed2a4a7941 "audio: proper support for float samples in mixeng" suggested this would be a good idea. Acked-by: Markus Armbruster Signed-off-by: Volker Rümelin --- qapi/audio.json | 14 ++ 1 file changed, 14 insertions(+) diff --git a/qapi/audio.json b/qapi/audio

[PATCH v2 0/6] mostly changes related to audio float samples

2020-03-08 Thread Volker Rümelin
v2: - "qapi/audio: add documentation for AudioFormat"   Markus suggested to correct a spelling mistake. - "audio: add audiodev format=f32 option documentation"   New patch. Volker Rümelin (6):   qapi/audio: add documentation for AudioFormat   audio: change naming scheme of FLOAT_CONV macros   aud

Re: [PATCH 0/5] mostly changes related to audio float samples

2020-03-08 Thread Volker Rümelin
Hi Howard, thank you for testing the patches. > Hi, > > I applied these to Mark's screamer branch to create a new OSX build. Testing > was done by playing system sounds, and an MP3/Internet radio with > QuickTime/iTunes. With or without 6dB, the max volume is way out of my > comfort zone. I he

Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-08 Thread Christian Schoenebeck
On Freitag, 6. März 2020 06:15:28 CET Vladimir Sementsov-Ogievskiy wrote: > diff --git a/scripts/coccinelle/auto-propagated-errp.cocci > b/scripts/coccinelle/auto-propagated-errp.cocci new file mode 100644 > index 00..bff274bd6d > --- /dev/null > +++ b/scripts/coccinelle/auto-propagated-err

Re: [PATCH v8 07/10] virtio-9p: introduce ERRP_AUTO_PROPAGATE

2020-03-08 Thread Christian Schoenebeck
On Freitag, 6. März 2020 06:15:33 CET Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &error_fatal > (the program will exit prior

Re: [PATCH v6 3/4] linux-user: Support futex_time64

2020-03-08 Thread Laurent Vivier
Le 06/03/2020 à 19:24, Alistair Francis a écrit : > Add support for host and target futex_time64. If futex_time64 exists on > the host we try that first before falling back to the standard futux > syscall. In fact there are two definitions for futex: one to use as system call in TARGET_NR_exit (sy

Regarding SESparse support in QEMU

2020-03-08 Thread Tirthankar Saha
Hi Sam, Can you please share any notes that you have regarding the structure of the SESparse journal? This will help in adding "read-write" support for SESparse snapshots. Thanks, Tirthankar

Re: [PATCH v32 21/22] BootLinuxConsoleTest: Test the RX-Virt machine

2020-03-08 Thread Philippe Mathieu-Daudé
On 2/24/20 3:19 PM, Yoshinori Sato wrote: From: Philippe Mathieu-Daudé Add two tests for the rx-virt machine, based on the recommended test setup from Yoshinori Sato: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03586.html - U-Boot prompt - Linux kernel with Sash shell These are v

Re: [PATCH v32 16/22] hw/char: RX62N serial communication interface (SCI)

2020-03-08 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 2/24/20 3:19 PM, Yoshinori Sato wrote: This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Dau

[PATCH v2 13/14] block/qcow2: implement blockdev-amend

2020-03-08 Thread Maxim Levitsky
Currently the implementation only supports amending the encryption options, unlike the qemu-img version Signed-off-by: Maxim Levitsky Reviewed-by: Daniel P. Berrangé --- block/qcow2.c| 39 +++ qapi/block-core.json | 16 +++- 2 files change

[PATCH v2 12/14] block/crypto: implement blockdev-amend

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Daniel P. Berrangé --- block/crypto.c | 72 qapi/block-core.json | 14 - 2 files changed, 66 insertions(+), 20 deletions(-) diff --git a/block/crypto.c b/block/crypto.c index 727a3fde58..389586

[PATCH v2 09/14] iotests: filter few more luks specific create options

2020-03-08 Thread Maxim Levitsky
This allows more tests to be able to have same output on both qcow2 luks encrypted images and raw luks images Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/087.out | 6 +++--- tests/qemu-iotests/134.out | 2 +- tests/qemu-iotests/158.out | 4 ++-- tests/qemu-iotests/188

[PATCH v2 06/14] block/crypto: rename two functions

2020-03-08 Thread Maxim Levitsky
rename the write_func to create_write_func, and init_func to create_init_func. This is preparation for other write_func that will be used to update the encryption keys. No functional changes Signed-off-by: Maxim Levitsky Reviewed-by: Daniel P. Berrangé --- block/crypto.c | 25

[PATCH v2 05/14] block/amend: refactor qcow2 amend options

2020-03-08 Thread Maxim Levitsky
Some qcow2 create options can't be used for amend. Remove them from the qcow2 create options and add generic logic to detect such options in qemu-img Signed-off-by: Maxim Levitsky --- block/qcow2.c | 108 ++--- qemu-img.c | 18 +++- tests/qemu-iotest

[PATCH v2 14/14] iotests: add tests for blockdev-amend

2020-03-08 Thread Maxim Levitsky
This commit adds two tests that cover the new blockdev-amend functionality of luks and qcow2 driver Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/302 | 278 + tests/qemu-iotests/302.out | 40 ++ tests/qemu-iotests/303 | 233

[PATCH v2 03/14] block/amend: add 'force' option

2020-03-08 Thread Maxim Levitsky
'force' option will be used for some unsafe amend operations. This includes things like erasing last keyslot in luks based formats (which destroys the data, unless the master key is backed up by external means), but that _might_ be desired result. Signed-off-by: Maxim Levitsky Reviewed-by: Danie

[PATCH v2 11/14] block/core: add generic infrastructure for x-blockdev-amend qmp command

2020-03-08 Thread Maxim Levitsky
blockdev-amend will be used similiar to blockdev-create to allow on the fly changes of the structure of the format based block devices. Current plan is to first support encryption keyslot management for luks based formats (raw and embedded in qcow2) Signed-off-by: Maxim Levitsky --- block/Makef

[PATCH v2 07/14] block/crypto: implement the encryption key management

2020-03-08 Thread Maxim Levitsky
This implements the encryption key management using the generic code in qcrypto layer and exposes it to the user via qemu-img This code adds another 'write_func' because the initialization write_func works directly on the underlying file, and amend works on instance of luks device. This commit al

[PATCH v2 02/14] qcrypto/luks: implement encryption key management

2020-03-08 Thread Maxim Levitsky
Next few patches will expose that functionality to the user. Signed-off-by: Maxim Levitsky --- crypto/block-luks.c | 398 +++- qapi/crypto.json| 61 ++- 2 files changed, 455 insertions(+), 4 deletions(-) diff --git a/crypto/block-luks.c b/crypto/

[PATCH v2 08/14] block/qcow2: extend qemu-img amend interface with crypto options

2020-03-08 Thread Maxim Levitsky
Now that we have all the infrastructure in place, wire it in the qcow2 driver and expose this to the user. Signed-off-by: Maxim Levitsky --- block/qcow2.c | 80 -- tests/qemu-iotests/082.out | 45 + 2 files changed, 114 inserti

[PATCH v2 10/14] iotests: qemu-img tests for luks key management

2020-03-08 Thread Maxim Levitsky
This commit adds two tests, which test the new amend interface of both luks raw images and qcow2 luks encrypted images. Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/300 | 207 + tests/qemu-iotests/300.out | 99 ++ tests/qemu-iotest

[PATCH v2 01/14] qcrypto/core: add generic infrastructure for crypto options amendment

2020-03-08 Thread Maxim Levitsky
This will be used first to implement luks keyslot management. block_crypto_amend_opts_init will be used to convert qemu-img cmdline to QCryptoBlockAmendOptions Signed-off-by: Maxim Levitsky Reviewed-by: Daniel P. Berrangé --- block/crypto.c | 17 + block/crypto.h

[PATCH v2 04/14] block/amend: separate amend and create options for qemu-img

2020-03-08 Thread Maxim Levitsky
Some options are only useful for creation (or hard to be amended, like cluster size for qcow2), while some other options are only useful for amend, like upcoming keyslot management options for luks Since currently only qcow2 supports amend, move all its options to a common macro and then include i

[PATCH v2 00/14] LUKS: encryption slot management using amend interface

2020-03-08 Thread Maxim Levitsky
Hi! Here is the updated series of my patches, incorporating all the feedback I received. This implements the API interface that we agreed upon except that I merged the LUKSKeyslotActive/LUKSKeyslotInactive union into a struct because otherwise I need nested unions which are not supported currentl

Re: [PATCH v4 0/3] delay timer_new from init to realize to fix memleaks.

2020-03-08 Thread Peter Maydell
On Sun, 8 Mar 2020 at 11:58, Mark Cave-Ayland wrote: > I just tried this patchset applied on top of git master and it causes > qemu-system-ppc > to segfault on startup: > > $ gdb --args ./qemu-system-ppc > ... > ... > Thread 1 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault. > 0x000

[PULL 2/4] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM

2020-03-08 Thread Michael S. Tsirkin
From: Jason Wang We turn on device IOTLB via VIRTIO_F_IOMMU_PLATFORM unconditionally on platform without IOMMU support. This can lead unnecessary IOTLB transactions which will damage the performance. Fixing this by check whether the device is backed by IOMMU and disable device IOTLB. Reported-b

[PULL 4/4] hw/i386/intel_iommu: Simplify vtd_find_as_from_bus_num() logic

2020-03-08 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé The vtd_find_as_from_bus_num() function was introduced (in commit dbaabb25f) in a code format that could return an incorrect pointer, which was later fixed by commit a2e1cd41ccf. We could have avoided this by writing the if() statement differently. Do it now, in case

[PULL 3/4] vhost-vsock: fix error message output

2020-03-08 Thread Michael S. Tsirkin
From: Nick Erdmann error_setg_errno takes a positive error number, so we should not invert errno's sign. Signed-off-by: Nick Erdmann Message-Id: <04df3f47-c93b-1d02-d250-f9bda8dbc...@nirf.de> Reviewed-by: Ján Tomko Fixes: fc0b9b0e1cbb ("vhost-vsock: add virtio sockets device") Reviewed-by: Lau

[PULL 0/4] virtio, pci, pc: fixes, cleanups, features

2020-03-08 Thread Michael S. Tsirkin
The following changes since commit 67f17e23baca5dd545fe98b01169cc351a70fe35: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2020-03-06 17:15:36 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

[PULL 1/4] pcie_root_port: Add hotplug disabling option

2020-03-08 Thread Michael S. Tsirkin
From: Julia Suvorova Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt manage it and restrict unplug for the whole machine. This is going to prevent user-initiated unplug in guests (Windows mostly). Hotplug is enabled by default. Usage: -device pcie-root-port,hotplug=off,.

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

2020-03-08 Thread Peter Maydell
On Thu, 5 Mar 2020 at 06:39, Pan Nengyuan wrote: > > This patch fix a bug in mac_via where it failed to actually realize devices > it was using. > And move the init codes which inits the mos6522 objects and properties on > them from realize() > into init(). However, we keep qdev_set_parent_bus i

Re: [PATCH v5 00/16] APIC ID fixes for AMD EPYC CPU model

2020-03-08 Thread Michael S. Tsirkin
On Tue, Mar 03, 2020 at 01:56:51PM -0600, Babu Moger wrote: > This series fixes APIC ID encoding problem reported on AMD EPYC cpu models. > https://bugzilla.redhat.com/show_bug.cgi?id=1728166 > > Currently, the APIC ID is decoded based on the sequence > sockets->dies->cores->threads. This works fo

Re: [PATCH 0/3] reference implementation of RSS

2020-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2020 at 02:44:59PM +0200, Yuri Benditovich wrote: > On Sun, Mar 8, 2020 at 2:17 PM Michael S. Tsirkin wrote: > > > > On Sun, Mar 08, 2020 at 11:56:38AM +0200, Yuri Benditovich wrote: > > > On Sun, Mar 8, 2020 at 10:06 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Fri, Mar

[PATCH] docs: Add RX target.

2020-03-08 Thread Yoshinori Sato
Add rx-virt target specificaion document. Signed-off-by: Yoshinori Sato --- docs/system/target-rx.rst | 35 +++ docs/system/targets.rst | 1 + 2 files changed, 36 insertions(+) create mode 100644 docs/system/target-rx.rst diff --git a/docs/system/target-rx.rs

Re: [PATCH 0/3] reference implementation of RSS

2020-03-08 Thread Yuri Benditovich
On Sun, Mar 8, 2020 at 2:17 PM Michael S. Tsirkin wrote: > > On Sun, Mar 08, 2020 at 11:56:38AM +0200, Yuri Benditovich wrote: > > On Sun, Mar 8, 2020 at 10:06 AM Michael S. Tsirkin wrote: > > > > > > On Fri, Mar 06, 2020 at 11:50:30AM +0200, Yuri Benditovich wrote: > > > > > > > > > > > > On Fri

Re: [PATCH 0/3] reference implementation of RSS

2020-03-08 Thread Michael S. Tsirkin
On Sun, Mar 08, 2020 at 11:56:38AM +0200, Yuri Benditovich wrote: > On Sun, Mar 8, 2020 at 10:06 AM Michael S. Tsirkin wrote: > > > > On Fri, Mar 06, 2020 at 11:50:30AM +0200, Yuri Benditovich wrote: > > > > > > > > > On Fri, Mar 6, 2020 at 11:27 AM Jason Wang wrote: > > > > > > > > > On 2020

Re: [PATCH v4 0/3] delay timer_new from init to realize to fix memleaks.

2020-03-08 Thread Mark Cave-Ayland
On 05/03/2020 06:54, Pan Nengyuan wrote: > This series delay timer_new from init into realize to avoid memleaks when we > call 'device_list_properties'. > And do timer_free only in s390x_cpu_finalize because it's hotplugable. > However, mos6522_realize is never called > at all due to the incorr

Re: [PATCH for-5.0] vl.c: fix migration failure for 3.1 and older machine types

2020-03-08 Thread Lukáš Doktor
Dne 04. 03. 20 v 18:27 Igor Mammedov napsal(a): > Migration from QEMU(v4.0) fails when using 3.1 or older machine > type. For example if one attempts to migrate > QEMU-2.12 started as > qemu-system-ppc64 -nodefaults -M pseries-2.12 -m 4096 -mem-path /tmp/ > to current master, it will fail with >

Re: [PATCH 0/3] reference implementation of RSS

2020-03-08 Thread Yuri Benditovich
On Sun, Mar 8, 2020 at 10:06 AM Michael S. Tsirkin wrote: > > On Fri, Mar 06, 2020 at 11:50:30AM +0200, Yuri Benditovich wrote: > > > > > > On Fri, Mar 6, 2020 at 11:27 AM Jason Wang wrote: > > > > > > On 2020/2/27 上午1:48, Yuri Benditovich wrote: > > > Support for VIRTIO_NET_F_RSS feature

Re: [PATCH] dp8393x: Mask EOL bit from descriptor addresses, take 2

2020-03-08 Thread Laurent Vivier
Le 04/03/2020 à 04:23, Finn Thain a écrit : > A portion of a recent patch got lost due to a merge snafu. That patch is > now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses"). > This patch restores the portion that got lost. > > Signed-off-by: Finn Thain > --- > hw/net/dp8393

Re: [PATCH v5 05/11] monitor/hmp: move hmp_drive_mirror and hmp_drive_backup to block-hmp-cmds.c Moved code was added after 2012-01-13, thus under GPLv2+

2020-03-08 Thread Maxim Levitsky
I see that I have the same issue of long subject line here. Its because I forgot the space after first line, when adding this. If I need to resend another version of this patchset I'll fix this, but otherwise maybe that can be fixed when applying this to one of maintainer's trees. Sorry for nois

[PATCH v5 11/11] monitor/hmp: Move hmp_drive_add_node to block-hmp-cmds.c

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 30 blockdev.c | 43 +++--- include/block/block_int.h | 5 ++-- 3 files changed, 41 insertions(+), 37 deletions(-)

[PATCH v5 10/11] monitor/hmp: move hmp_info_block* to block-hmp-cmds.c

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 389 + include/block/block-hmp-cmds.h | 4 + include/monitor/hmp.h | 4 - monitor/hmp-cmds.c | 388 4 f

[PATCH v5 09/11] monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 140 + include/block/block-hmp-cmds.h | 9 +++ include/monitor/hmp.h | 6 -- monitor/hmp-cmds.c | 137

[PATCH v5 05/11] monitor/hmp: move hmp_drive_mirror and hmp_drive_backup to block-hmp-cmds.c Moved code was added after 2012-01-13, thus under GPLv2+

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 60 ++ include/block/block-hmp-cmds.h | 12 +-- include/monitor/hmp.h | 2 -- monitor/hmp-cmds.c | 58

[PATCH v5 07/11] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c

2020-03-08 Thread Maxim Levitsky
hmp_snapshot_blkdev is from GPLv2 version of the hmp-cmds.c thus have to change the licence to GPLv2 Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 58 -- include/block/block-hmp-cmds.h | 4 +++ include/mon

[PATCH v5 08/11] monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 101 + include/block/block-hmp-cmds.h | 5 ++ include/monitor/hmp.h | 4 -- monitor/hmp-cmds.c | 100 4

[PATCH v5 06/11] monitor/hmp: move hmp_block_job* to block-hmp-cmds.c

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 52 ++ include/block/block-hmp-cmds.h | 6 include/monitor/hmp.h | 5 monitor/hmp-cmds.c | 52 --

[PATCH v5 03/11] monitor/hmp: rename device-hotplug.c to block/monitor/block-hmp-cmds.c

2020-03-08 Thread Maxim Levitsky
These days device-hotplug.c only contains the hmp_drive_add In the next patch, rest of hmp_drive* functions will be moved there. Also add block-hmp-cmds.h to contain prototypes of these functions License for block-hmp-cmds.h since it contains the code moved from sysemu.h which lacks license and t

[PATCH v5 04/11] monitor/hmp: move hmp_drive_del and hmp_commit to block-hmp-cmds.c

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert --- block/monitor/block-hmp-cmds.c | 108 - blockdev.c | 96 + include/block/block-hmp-cmds.h | 4 ++ include/sysemu/blockdev.h | 4 -- 4 fi

[PATCH v5 02/11] monitor/hmp: inline add_init_drive

2020-03-08 Thread Maxim Levitsky
This function is only used by hmp_drive_add. The code is just a bit shorter this way. No functional changes Signed-off-by: Maxim Levitsky Reviewed-by: Markus Armbruster --- device-hotplug.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/de

[PATCH v5 00/11] HMP monitor handlers refactoring

2020-03-08 Thread Maxim Levitsky
This patch series is bunch of cleanups to the hmp monitor code. It mostly moves the blockdev related hmp handlers to its own file, and does some minor refactoring. No functional changes expected. Changes from V1: * move the handlers to block/monitor/block-hmp-cmds.c * tiny cleanup for the c

[PATCH v5 01/11] usb/dev-storage: remove unused include

2020-03-08 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daudé --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 90da008df1..5629213d55 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -19,7 +19,6 @@ #

Re: [PATCH 0/3] reference implementation of RSS

2020-03-08 Thread Michael S. Tsirkin
On Fri, Mar 06, 2020 at 11:50:30AM +0200, Yuri Benditovich wrote: > > > On Fri, Mar 6, 2020 at 11:27 AM Jason Wang wrote: > > > On 2020/2/27 上午1:48, Yuri Benditovich wrote: > > Support for VIRTIO_NET_F_RSS feature in QEMU for reference > > purpose. Implements Toeplitz hash calculat